Hi,

On Wed, 9 Jan 2008, Laurent Vivier wrote:

> but "-hda" is an alias for "-drive file="%s",index=%d,media=disk".

It appears to me as if "-hda" is implemented suboptimally, then.  In 
particular, drive_add() should be able to get a separate "file" parameter, 
which can be overridden by the "fmt" parameter.  Of course, this would 
mean that the global drives_opt[] array should not have element type 
"char", but a struct.

It is a pity that there is DWIMery going on in drive_init(), needing the 
other options to be parsed already, otherwise drive_add() could have been 
replaced by calls to drive_init().

Ciao,
Dscho


Reply via email to