Le mercredi 09 janvier 2008 à 12:27 +0000, Johannes Schindelin a écrit : > Hi, > > On Wed, 9 Jan 2008, Laurent Vivier wrote: > > > but "-hda" is an alias for "-drive file="%s",index=%d,media=disk". > > It appears to me as if "-hda" is implemented suboptimally, then. In > particular, drive_add() should be able to get a separate "file" parameter, > which can be overridden by the "fmt" parameter. Of course, this would > mean that the global drives_opt[] array should not have element type > "char", but a struct.
This introduces complexity and special cases I don't want to manage... > It is a pity that there is DWIMery going on in drive_init(), needing the > other options to be parsed already, otherwise drive_add() could have been > replaced by calls to drive_init(). I just mimic here already existing behavior of qemu. drive_init() already parse parameter to extract options. You can't make drive_init() before having parsed all parameters because of parameters like "-hda f -hdachs x,y,z" Regards, Laurent -- ----------------- [EMAIL PROTECTED] ------------------ "La perfection est atteinte non quand il ne reste rien à ajouter mais quand il ne reste rien à enlever." Saint Exupéry
signature.asc
Description: Ceci est une partie de message numériquement signée