Re: [Qemu-devel] [PATCH 3/4] target-arm: Fix VFP register byte order in GDB remote

[Paul Brook]

> From GDB Remote Serial Protocol doc:
> 
> "The bytes with the register are transmitted in target byte order."

>          /* Aliases for Q regs.  */
>          nregs += 16;
>          if (reg < nregs) {
> 
> -            stfq_le_p(buf, env->vfp.regs[(reg - 32) * 2]);
> -            stfq_le_p(buf + 8, env->vfp.regs[(reg - 32) * 2 + 1]);
> +            stfq_p(buf, env->vfp.regs[(reg - 32) * 2]);
> +            stfq_p(buf + 8, env->vfp.regs[(reg - 32) * 2 + 1]);

This is wrong. You're still using little-endian ordering of words.

Paul