Hi Peter, Am 07.06.2013 10:41, schrieb Peter Crosthwaite: > I have a series that fixes all qom cast macros for all PCI devices tree > wide. Can post. Qom cast macros added as needed.
Sounds promising! I just CC'ed you on my ISA series v2, which touches on PCI_BUS() in the final patch, dropping FROM_QBUS(). > How are you regression testing this series? If you have a pc/PCI > regression suite I could use it for my series. I rely on `make check` to find the most obvious QOM errors. libqos PCI support is still very new, so we don't have full device coverage there yet. Usually I run an openSUSE and/or SLES guest under KVM (pick your favorite), which will exercise the relevant init, realize and reset code paths at least. And finally I re-review things in gitk before sending - not the nicest tool but convenient for fixing up things and verifying quickly. HTH, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
