On Sun, 2021-07-25 at 23:27 +0200, Philippe Mathieu-Daudé wrote: > +Cédric/Benjamin > > On 7/25/21 2:24 PM, Richard Henderson wrote: > > From clang-13: > > hw/pci-host/pnv_phb4.c:375:18: error: variable 'v' set but not used > > \ > > [-Werror,-Wunused-but-set-variable] > > > > It's pretty clear that we meant to write back 'v' after > > all that computation and not 'val'. > > > > Fixes: 4f9924c4d4c ("ppc/pnv: Add models for POWER9 PHB4 PCIe Host > bridge")
Acked-by: Benjamin Herrenschmidt <b...@kernel.crashing.org> > > > Acked-by: David Gibson <da...@gibson.dropbear.id.au> > > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > > --- > > hw/pci-host/pnv_phb4.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c > > index 54f57c660a..5c375a9f28 100644 > > --- a/hw/pci-host/pnv_phb4.c > > +++ b/hw/pci-host/pnv_phb4.c > > @@ -392,7 +392,7 @@ static void pnv_phb4_ioda_write(PnvPHB4 *phb, > > uint64_t val) > > v &= 0xffffffffffff0000ull; > > v |= 0x000000000000cfffull & val; > > } > > - *tptr = val; > > + *tptr = v; > > break; > > } > > case IODA3_TBL_MBT: > >