Hi Derrell, unfortunately your patch[4] doesn't work perfectly... Now the "contextMenuFromDataCellsOnly" switch only seems to be effective when "showCellFocusIndicator" is true!
So here's the matrix I've tested: ---------+---------------+-------- FocusInd | DataCellsOnly | Result ---------+---------------+-------- true | true | OK true | false | OK false | true | NOK context menu is shown in gray area false | false | OK ---------+---------------+-------- I hope I did apply the patch correct (I will double-check again). By the way: Can you recommend a Windows(TM)-Tool for applying you patch? The one shipped with TortoiseSVN does not really like the *NIX-Diff Nevertheless, I can see the approach for this Bug ;) /Peter [1] http://bugzilla.qooxdoo.org/attachment.cgi?id=871 On 1/24/2011 10:15 PM Derrell Lipman wrote: > On Mon, Jan 24, 2011 at 12:01, Peter Schneider <[email protected]>wrote: > > >> This bug is independent of my last proposal (showMenuOnEmptyRows property). > > The work-around with the "row===null" check in the ContextMenuHandler >> callback >> is working good and should therefore be a valid "fix" for Bug 4568. >> >> Nevertheless, I think it would be nice to find out why >> ShowCellFocusIndicator >> has an impact on that... >> > > Please try my latest patch I applied to the bug report. I think it should > solve all of these problems. It incorporates a property similar to your > proposal, but also explicitly handles allowing the cellContextmenu event to > fire if the click is in the empty area instead of depending on having no > focus indicator to allow entry into that block of code. > > Derrell ------------------------------------------------------------------------------ Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d _______________________________________________ qooxdoo-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
