Hi Derrell, this time it seems to be 100% !!! :-D Your revised patch [1] works on all four combinations!
Thanks a lot. From my perspective you can commit the changes and set the bug to RESOLVED. Another side-question: Do you think this fix will make it into 1.2.x branch? The issue has a target Milestone of 1.3.1, so I might have to switch to the 1.3.x branch sooner or later. /Peter [1] http://bugzilla.qooxdoo.org/attachment.cgi?id=872 On 1/25/2011 2:57 PM Derrell Lipman wrote: > On Tue, Jan 25, 2011 at 04:20, Peter Schneider <[email protected]>wrote: > >> Hi Derrell, >> >> the results are the same after I removed any other previous patch :( >> >> ---------+---------------+-------- >> FocusInd | DataCellsOnly | Result >> ---------+---------------+-------- >> true | true | OK >> true | false | OK >> false | true | NOK context menu is shown in gray area >> false | false | OK >> ---------+---------------+-------- >> >> So it looks like, when the FocusIndicator is off, the other switch has no >> effect. >> > > Doh! Yeah, I tried to cram too many tests into a complicated if statement, > and did it incorrectly. I've attached a new patch to the bug report that > I've tested with all four entries in the matrix. > > >> Together with the "row===null" check in the ContextMenuHandler callback >> this >> can be circumnavigated, but still it's not perfect ;) >> > > No, that was intended as a temporary work-around, not a permanent fix. > > >> P.S.: Should we continue with PM, to keep this newsgroup-thread a bit >> cleaner? > > > No, I don't think so. There's at least one other person, the OP, interested > in this discussion, and others may be too. > > Derrell ------------------------------------------------------------------------------ Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d _______________________________________________ qooxdoo-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
