On Jun 17, 2009, at 8:13, Filippo Carletti wrote:

+++ qpsmtpd-0.40/plugins/check_spamhelo 2007-06-14 13:21:45.000000000 -0600
@@ -23,7 +23,7 @@
  for my $bad ($self->qp->config('badhelo')) {
    if ($host eq lc $bad) {
$self->log(LOGDEBUG, "Denying HELO from host claiming to be $bad");
-      return (DENY, "Sorry, I don't believe that you are $host.");
+ return (DENY_DISCONNECT, "Sorry, I don't believe that you are $host.");

Is this a good idea now? It used to be that so many MTAs got confused when you refused a connection before RCPT TO that it was better to wait. I guess this plugin won't catch any legitimate mailers anyway ... I'll apply it.

The rest of the patches looked good, too. I'll apply them tomorrow. I'll attribute the rhsbl and spamassassin ones to Charlie and the others to you?

Thanks for going back through your changes and getting them submitted!


 - ask

--
http://develooper.com/ - http://askask.com/


Reply via email to