On Wednesday 04 Aug 2004 16:27, Helio Chissini de Castro wrote: > Here's attached two patches to solve compilation problems against new gcc > 3.4.1 C++ parser and Qt 3.3.1
Thanks for this -- I see Guillaume has applied them. > Major change is QPixmap inline constructions that move to a private > constructor instead the QString based one, so i moved to no inline > constructions. I'm probably being very stupid, but I don't quite see how this change works. It seems you've changed instances like QIconSet icon = QIconSet(QCanvasPixmap(pixmapDir + "/toolbar/matrix.xpm")); //... icon = QIconSet(QCanvasPixmap(pixmapDir + "/toolbar/notation.xpm")); into QCanvasPixmap pixmap( pixmapDir + "/toolbar/matrix.xpm" ); QIconSet icon = QIconSet( pixmap ); //... pixmap.load( pixmapDir + "/toolbar/notation.xpm" ); icon = QIconSet( pixmap ); But I don't see what the difference is. The first version contains: (a) construction of QCanvasPixmap from QString ref; (b) construction of QIconSet from QCanvasPixmap ref; (c) assignment operator on QIconSet; (d) all of (a)-(c) again. The second version contains: (a) construction of QCanvasPixmap from QString ref; (b) construction of QIconSet from QCanvasPixmap ref; (c) assignment operator on QIconSet; (d) QCanvasPixmap::load() call; (e) both of (b) and (c) again. In other words, all the syntax in the first version is also in the second, so if the first doesn't work, how come the second does? What am I missing? > Btw, theres a lot of calls to same process QPixmap, which could be improved > if a single static funtions fro loading pixmaps was added. Of course this > is relevant in the case of new parser. I don't quite understand what you're saying here either, I'm afraid. Chris ------------------------------------------------------- This SF.Net email is sponsored by OSTG. Have you noticed the changes on Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now, one more big change to announce. We are now OSTG- Open Source Technology Group. Come see the changes on the new OSTG site. www.ostg.com _______________________________________________ Rosegarden-devel mailing list [EMAIL PROTECTED] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
