On Wednesday, January 25, 2012, Tom Breton (Tehom) wrote: > So ignore most of what I said. So I'll use Instrument's old m_channel as > its channel just when it's fixed, which is just when it's not auto. And > bring the remapping check and warning back in, and save the > device-relative channel despite anything auto does.
I wonder about the remapping check. It _should_ only come into play for old compositions. What would have happened before is Rosegarden would just remap the channels, and if you didn't like it, too bad. Whether that's the right approach or not isn't worth debating; that's just what you're up against for baseline behavior. As such, I think it would be entirely appropriate just to default to auto for everything, and ignore whatever m_channel was completely. There was no way to specify fixed vs. auto in old versions, so there's no way to guess if the user might prefer the channels fixed for some reason. In most cases, these old compositions will probably load and work just fine with automatically-allocated channels, and if there is some need for tweaking, the controls are available. I think that's the way I'd go. Future compositions that need fixed channels for some reason will carry the information we need, but so long as the channel and instrument number continue to correspond, there won't be any future need for remapping. I think it's still safe to dump that stuff. This is pretty much the whole thought process that went through my head the other day when I saw you were going to dump this, and I said, "Interesting." > I'm glad you said something, because that will be much easier than what I > was thinking. For some strange reason I was doing it the hard way. That happens frequently around here. No one is immune to that, I'm afraid. -- D. Michael McIntyre ------------------------------------------------------------------------------ Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d _______________________________________________ Rosegarden-devel mailing list [email protected] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
