On Friday 01 November 2013 08:46:22 D. Michael McIntyre wrote: > On 11/01/2013 04:23 AM, Repository Rosegarden code wrote: > > Solved a problem in Pitch::transpose(const Pitch &) when the result was > > B#, B##, Cb or Cbb. http://sourceforge.net/p/rosegarden/code/13537/ > > How sure are you of that fix? If you already hammered it pretty hard, > that's good enough for me, but if you just kind of threw that out there > and tested it a couple times, we need to give it a hard thrashing. This > kind of stuff is absolutely notorious for bizarre edge cases where > things break.
I'm quite sure, not only by testing but mainly by carefully checking the algorithm. And the number of cases I have to check was not that much, due to the algorithm. > > It's about half likely you just solved a problem I've been chasing for a > long time. I'll be very amused if that proves to be the case. I think I have to disappoint you, I solved an issue in a new Pitch::transpose method I added besides the existing one. The reason was I had to "add" two pitches (what transposing is). So if the bug you are chasing for is in the existing Pitch::transpose my patch won't help. Is this bug a reported bug or can you give me some information regarding this issue? Maybe I can have a look? Best regards, Niek ------------------------------------------------------------------------------ Android is increasing in popularity, but the open development platform that developers love is also attractive to malware creators. Download this white paper to learn more about secure code signing practices that can help keep Android apps secure. http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk _______________________________________________ Rosegarden-devel mailing list [email protected] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
