On 11/04/2013 04:22 PM, Niek van den Berg wrote: > Since we are interested in the difference, this common offset won't harm but > is > make sure the pitch will be positive (unless we have to transpose over 5 > octaves which is very unlikely :-)).
Unlikely means some idiot will do it eventually. But looking around, I don't think it's physically possible the way SegmentSyncCommand is used. The biggest gap we could ever face is piccolo trumpet (sounds +10) against contrabass saxophone (sounds -33). I could be doing the math wrong, but I think adding 60 to the front end of this calculation still allows room to figure that difference correctly. So part of me wants to look for that extreme edge case we're both overlooking, and part of me just wants to go with it. Plus it works in the use case that I actually care about in real life, which is converting from Bb to Eb (I have an alto or tenor horn, depending on what country you're in). I added a bit of your text as an explanatory comment to document why the number 60 is there, and we'll call this fixed. Looks good to me. -- D. Michael McIntyre ------------------------------------------------------------------------------ November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk _______________________________________________ Rosegarden-devel mailing list [email protected] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
