@pmatilai commented on this pull request.


>      case MODE_LISTKEY:
+       if (args != NULL) {
+           argerror(_("--list-keys does not take any arguments"));
+       }
+       ARGV_t query = argvSplitString("gpg-pubkey", " ", ARGV_NONE);

It's a bit creative way to initialize an argv... I think
```
ARGV_t query = NULL;
argvAdd(&query, "gpg-pubkey");
```
...would be a well worth the one extra line in obviousness :smile: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2921#pullrequestreview-1892397084
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2921/review/1892397...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to