@pmatilai commented on this pull request.


> @@ -42,6 +41,20 @@ static struct poptOption optionsTable[] = {
     POPT_TABLEEND
 };
 
+static ARGV_t gpgkeyargs(ARGV_const_t args) {
+    ARGV_t gpgargs = argvNew();
+    for (char * const * arg = args; *arg; arg++) {
+       if (strncmp(*arg, "gpg-pubkey-", 11)) {
+           char * gpgarg = rpmExpand("gpg-pubkey-", *arg, NULL);

Again, why the macro expand? 'rpmkeys --delete %{somemacro}' seems like a weird 
use-case to support, I'd think for something like OpenPGP keys you'd rather 
always be explicit about the key.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2921#pullrequestreview-1902735001
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2921/review/1902735...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to