Re: [asterisk-dev] [Code Review] 4415: Testsuite: Attended transfers from non-Stasis to a Stasis bridge

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4415/ --- (Updated Feb. 12, 2015, 12:34 a.m.) Review request for Asterisk Developers

[asterisk-dev] [Code Review] 4415: Testsuite: Attended transfers from non-Stasis to a Stasis bridge

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4415/ --- Review request for Asterisk Developers and Mark Michelson. Bugs: ASTERISK-

[asterisk-dev] t38 488

Given the case where asterisk has a single peer, such as a local kamailio and multiple remote sip destinations, is it possible to negotiate t38 both will remotes which specify redundancy in their re-invites and with remotes which specify fec? I was helping debug a case where the remote specified r

[asterisk-dev] [Code Review] 4414: res_pjsip_session: Fix double re-INVITE collision crash.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4414/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24727 https://i

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

> On Jan. 27, 2015, 1:34 p.m., Matt Jordan wrote: > > /branches/13/configs/examples/super_awesome_company/extensions.conf, line 42 > > > > > > I know '=' is the same as '=>', but I (for some reason) still prefer > >

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

> On Jan. 27, 2015, 2:34 p.m., Matt Jordan wrote: > > /branches/13/configs/examples/super_awesome_company/extensions.conf, line 42 > > > > > > I know '=' is the same as '=>', but I (for some reason) still prefer > >

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

> On Jan. 27, 2015, 8:34 p.m., Matt Jordan wrote: > > /branches/13/configs/examples/super_awesome_company/extensions.conf, line 42 > > > > > > I know '=' is the same as '=>', but I (for some reason) still prefer > >

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

> On Jan. 27, 2015, 1:34 p.m., Matt Jordan wrote: > > /branches/13/configs/examples/super_awesome_company/extensions.conf, line 42 > > > > > > I know '=' is the same as '=>', but I (for some reason) still prefer > >

Re: [asterisk-dev] [Code Review] 4409: res_pjsip: dtls_handler causes Asterisk to crash

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4409/ --- (Updated Feb. 11, 2015, 12:02 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

> On Jan. 29, 2015, 4:23 p.m., Mark Michelson wrote: > > /branches/13/configs/examples/super_awesome_company/pjsip.conf, line 41 > > > > > > I'm curious why you elected to use MAC addresses as the endpoint names. > >

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

> On Jan. 27, 2015, 2:34 p.m., Matt Jordan wrote: > > /branches/13/configs/examples/super_awesome_company/extensions.conf, line 42 > > > > > > I know '=' is the same as '=>', but I (for some reason) still prefer > >

Re: [asterisk-dev] [Code Review] 4399: HTTP: Stop accepting requests on final system shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4399/ --- (Updated Feb. 11, 2015, 11:28 a.m.) Status -- This change has been ma

Re: [asterisk-dev] AstriDevCon Follow Up - Asterisk and Kamailio - smoother integration

On 11 Feb 2015, at 17:50, Matthew Jordan wrote: > > > On Tue, Feb 3, 2015 at 6:11 AM, Daniel-Constantin Mierla > wrote: > Thanks Matt for all the valuable details -- even quite some time since your > answer, I still have to digest parts of it, given that I had some tough cold > to deal wit

Re: [asterisk-dev] [Code Review] 4411: testsuite: fix a number of tests where Asterisk does not shutdown gracefully

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4411/ --- (Updated Feb. 11, 2015, 11:09 a.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 4410: testsuite: Fix output of minversion/maxversion of tests that cannot run

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4410/ --- (Updated Feb. 11, 2015, 11:04 a.m.) Status -- This change has been ma

Re: [asterisk-dev] AstriDevCon Follow Up - Asterisk and Kamailio - smoother integration

On Tue, Feb 3, 2015 at 6:11 AM, Daniel-Constantin Mierla wrote: > Thanks Matt for all the valuable details -- even quite some time since > your answer, I still have to digest parts of it, given that I had some > tough cold to deal with and then a bit of traveling. But that gave time to > think m

Re: [asterisk-dev] [Code Review] 4412: res_http_websocket: websocket write timeout fails to fully disconnect underlying socket

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4412/ --- (Updated Feb. 11, 2015, 10:46 a.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

> On Jan. 30, 2015, 7:51 p.m., Paul Belanger wrote: > > /branches/13/configs/examples/super_awesome_company/indications.conf, line 1 > > > > > > Again, this file seem to be the default. I'd rather see a symlink. > >

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

> On Jan. 30, 2015, 7:51 p.m., Paul Belanger wrote: > > /branches/13/configs/examples/super_awesome_company/extensions.conf, line 78 > > > > > > I prefer putting include statements at the top of the context. > >

Re: [asterisk-dev] [Code Review] 4141: Enable REF_DEBUG for ast_module_ref / ast_module_unref

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4141/ --- (Updated Feb. 11, 2015, 9:38 a.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

On Fri, 30 Jan 2015, Paul Belanger wrote: I'd also prefer to see the first time always a naked NoOp() exten => 8000,1,NoOp() same => n,Verbose(1, "blah") What value does noop() add? I start my contexts with exten = s,1, verbose(1,[${EXTEN}@${CONTEXT}!.' (I d

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

On Fri, 6 Feb 2015, rnewton wrote: I used MAC addresses as that is what we use as an example in our security best practices document: http://svnview.digium.com/svn/asterisk/trunk/README-SERIOUSLY.bestpractices.txt?view=markup Perhaps this is a moot point. SAC's Asterisk system is behind NAT a

Re: [asterisk-dev] [Code Review] 4411: testsuite: fix a number of tests where Asterisk does not shutdown gracefully

> On Feb. 10, 2015, 12:29 p.m., Mark Michelson wrote: > > The only caveat here is that you may want to watch automated runs of the > > SIP info_dtmf test to be sure that on awful hardware the 5 second Wait() > > isn't too short for the test to complete. I suspect it will be okay though. > > >

Re: [asterisk-dev] Queue realtime and members ordering

On Wed, Feb 11, 2015 at 8:14 AM, Matthew Jordan wrote: > > Do you think it is doable? will such change be accepted? do you think >> there can be a better way? >> > > The problem you are always going to face when modifying app_queue is > ensuring that you haven't broken anything else. That means w

Re: [asterisk-dev] Queue realtime and members ordering

On Mon, Feb 9, 2015 at 4:17 PM, Leandro Dardini wrote: > I am back to try to fight with the problem highlighted few years ago > https://issues.asterisk.org/jira/browse/ASTERISK-18480 > > In short, when using realtime queue members, it is impossible to use > ordered ringing method because it is im