KarboniteKream commented on PR #13762:
URL: https://github.com/apache/kafka/pull/13762#issuecomment-1583888214
Sure, I understand the concerns.
> you might want to align your PR with that PR?
Do you mean waiting for that PR to get merged, then rebase my changes? Or
add my
showuon merged PR #13807:
URL: https://github.com/apache/kafka/pull/13807
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
vcrfxia commented on code in PR #13830:
URL: https://github.com/apache/kafka/pull/13830#discussion_r1223656443
##
streams/src/main/java/org/apache/kafka/streams/state/internals/TimeOrderedKeyValueBuffer.java:
##
@@ -27,14 +26,14 @@
import java.util.function.Consumer;
import
[
https://issues.apache.org/jira/browse/KAFKA-15053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730767#comment-17730767
]
Bo Gao edited comment on KAFKA-15053 at 6/8/23 11:45 PM:
-
Hi [~ChrisEgerton] ,
[
https://issues.apache.org/jira/browse/KAFKA-15053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730767#comment-17730767
]
Bo Gao edited comment on KAFKA-15053 at 6/8/23 11:44 PM:
-
Hi [~ChrisEgerton] ,
[
https://issues.apache.org/jira/browse/KAFKA-15053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730767#comment-17730767
]
Bo Gao commented on KAFKA-15053:
Hi [~ChrisEgerton] , just created a pull request for the fix
bogao007 opened a new pull request, #13831:
URL: https://github.com/apache/kafka/pull/13831
Fixed a regression described in
[KAFKA-15053](https://issues.apache.org/jira/browse/KAFKA-15053) that
security.protocol only allows uppercase values like PLAINTEXT, SSL,
SASL_PLAINTEXT, SASL_SSL.
ijuma commented on code in PR #13679:
URL: https://github.com/apache/kafka/pull/13679#discussion_r1223558292
##
core/src/main/scala/kafka/server/ApiVersionManager.scala:
##
@@ -112,4 +157,8 @@ class DefaultApiVersionManager(
zkMigrationEnabled
)
}
+
+ override
[
https://issues.apache.org/jira/browse/KAFKA-14966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao resolved KAFKA-14966.
-
Fix Version/s: 3.6.0
Resolution: Fixed
Merged the PR to trunk.
> Extract reusable common logic
junrao merged PR #13815:
URL: https://github.com/apache/kafka/pull/13815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lianetm commented on PR #13815:
URL: https://github.com/apache/kafka/pull/13815#issuecomment-1583285348
Thanks @junrao. Just addressed the comment and checked unrelated failing
tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
bmscomp commented on PR #13662:
URL: https://github.com/apache/kafka/pull/13662#issuecomment-1583266979
@showuon Yes I'll do ,Thanks so much @divijvaidya for reviews, I am back
from holidays :) , I'll continue working on this topic, I'll check all comments
one by one and try to bring the
[
https://issues.apache.org/jira/browse/KAFKA-14995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steven Booke reassigned KAFKA-14995:
Assignee: Steven Booke
> Automate asf.yaml collaborators refresh
>
kirktrue commented on code in PR #13797:
URL: https://github.com/apache/kafka/pull/13797#discussion_r1223461888
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -522,7 +525,35 @@ public void subscribe(Collection topics,
kirktrue commented on code in PR #13797:
URL: https://github.com/apache/kafka/pull/13797#discussion_r1223461556
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -537,7 +568,9 @@ public void subscribe(Pattern pattern) {
kirktrue commented on code in PR #13797:
URL: https://github.com/apache/kafka/pull/13797#discussion_r1223461234
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -522,7 +525,35 @@ public void subscribe(Collection topics,
kirktrue commented on code in PR #13797:
URL: https://github.com/apache/kafka/pull/13797#discussion_r1223460895
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -522,7 +525,35 @@ public void subscribe(Collection topics,
kirktrue commented on code in PR #13797:
URL: https://github.com/apache/kafka/pull/13797#discussion_r1223460709
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##
@@ -106,4 +114,17 @@ private boolean process(final
kirktrue commented on code in PR #13797:
URL: https://github.com/apache/kafka/pull/13797#discussion_r1223454138
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##
@@ -106,4 +114,17 @@ private boolean process(final
jlprat commented on code in PR #13827:
URL: https://github.com/apache/kafka/pull/13827#discussion_r1223425372
##
.github/workflows/stale.yml:
##
@@ -0,0 +1,48 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the
jlprat commented on PR #13827:
URL: https://github.com/apache/kafka/pull/13827#issuecomment-1583155790
> I also found
https://github.com/marketplace/actions/auto-label-merge-conflicts which would
add a label to PRs with conflicts. This could be used to create two separate
workflows of the
[
https://issues.apache.org/jira/browse/KAFKA-10337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730665#comment-17730665
]
Erik van Oosten commented on KAFKA-10337:
-
Thanks for your PR [~thomaslee]. It has been merged
ahuang98 commented on code in PR #13802:
URL: https://github.com/apache/kafka/pull/13802#discussion_r1223387331
##
metadata/src/test/java/org/apache/kafka/metadata/migration/KRaftMigrationZkWriterTest.java:
##
@@ -195,9 +235,658 @@ public void iterateTopics(EnumSet
interests,
novosibman commented on PR #13782:
URL: https://github.com/apache/kafka/pull/13782#issuecomment-1583094847
Open/close changes provided.
Also corrected style check issue (in task ':storage:checkstyleMain').
--
This is an automated message from the Apache Git Service.
To respond to the
novosibman commented on code in PR #13782:
URL: https://github.com/apache/kafka/pull/13782#discussion_r1223374923
##
storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java:
##
@@ -681,7 +687,12 @@ private static void writeSnapshot(File file, Map
novosibman commented on code in PR #13782:
URL: https://github.com/apache/kafka/pull/13782#discussion_r1223373702
##
storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java:
##
@@ -430,11 +428,19 @@ public Optional lastEntry(long
producerId) {
wcarlson5 commented on code in PR #13756:
URL: https://github.com/apache/kafka/pull/13756#discussion_r1223326402
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBuffer.java:
##
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software
junrao commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1222183119
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -945,4 +1176,27 @@ public void close() {
}
}
+private static class
wcarlson5 commented on code in PR #13756:
URL: https://github.com/apache/kafka/pull/13756#discussion_r1223321590
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBuffer.java:
##
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software
wcarlson5 opened a new pull request, #13830:
URL: https://github.com/apache/kafka/pull/13830
Make it so the Time ordered buffer doesn't need a change record. We now have
two types for the value. One for the storage type and another for the type.
They can be the same if you don't want to
hudeqi commented on PR #13696:
URL: https://github.com/apache/kafka/pull/13696#issuecomment-1582997213
This minor pr is also about replica fetcher thread, please help to review,
thanks! @viktorsomogyi
--
This is an automated message from the Apache Git Service.
To respond to the
jolshan commented on code in PR #13787:
URL: https://github.com/apache/kafka/pull/13787#discussion_r1223292555
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -980,6 +1006,25 @@ class UnifiedLog(@volatile var logStartOffset: Long,
if
hudeqi commented on PR #13719:
URL: https://github.com/apache/kafka/pull/13719#issuecomment-1582994469
@viktorsomogyi hi, this minor pr is also about replica fetcher thread,
please help to review, thanks! Seems @dajac have no time.
--
This is an automated message from the Apache Git
mumrah commented on code in PR #13802:
URL: https://github.com/apache/kafka/pull/13802#discussion_r1223265946
##
metadata/src/test/java/org/apache/kafka/metadata/migration/KRaftMigrationZkWriterTest.java:
##
@@ -195,9 +235,658 @@ public void iterateTopics(EnumSet
interests,
divijvaidya commented on code in PR #13812:
URL: https://github.com/apache/kafka/pull/13812#discussion_r1223233148
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -0,0 +1,575 @@
+/*
+ * Licensed to the Apache Software
viktorsomogyi commented on code in PR #13421:
URL: https://github.com/apache/kafka/pull/13421#discussion_r1219754042
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -447,11 +447,11 @@ class Partition(val topicPartition: TopicPartition,
private[cluster] def
viktorsomogyi commented on PR #13421:
URL: https://github.com/apache/kafka/pull/13421#issuecomment-1582838059
So I have some context with the replica fetcher area (mostly by reading and
debugging), I hope I can help.
First, since the conversation is a bit long, let me summarize what
cadonna commented on code in PR #13756:
URL: https://github.com/apache/kafka/pull/13756#discussion_r1223073798
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBuffer.java:
##
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/KAFKA-15051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730611#comment-17730611
]
ASF GitHub Bot commented on KAFKA-15051:
C0urante merged PR #520:
URL:
C0urante merged PR #12307:
URL: https://github.com/apache/kafka/pull/12307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
C0urante commented on PR #12307:
URL: https://github.com/apache/kafka/pull/12307#issuecomment-1582800062
Test failures appear unrelated; merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
divijvaidya commented on code in PR #13795:
URL: https://github.com/apache/kafka/pull/13795#discussion_r1223158227
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -0,0 +1,1040 @@
+/*
+ * Licensed to the Apache
divijvaidya commented on code in PR #13828:
URL: https://github.com/apache/kafka/pull/13828#discussion_r1223142144
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -197,7 +199,8 @@ class BrokerServer(
logManager = LogManager(config, initialOfflineDirs,
mumrah commented on PR #13827:
URL: https://github.com/apache/kafka/pull/13827#issuecomment-1582676925
Thanks for taking a look @jlprat!
For the more complex workflow, we could use
https://github.com/actions/github-script. This basically lets you do anything
that the Github API
divijvaidya commented on code in PR #13828:
URL: https://github.com/apache/kafka/pull/13828#discussion_r1223088072
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -220,11 +223,20 @@ public RemoteLogMetadataManager run() {
});
}
+public
divijvaidya commented on code in PR #13820:
URL: https://github.com/apache/kafka/pull/13820#discussion_r1223073346
##
server-common/src/main/java/org/apache/kafka/server/util/timer/SystemTimer.java:
##
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
yashmayya commented on code in PR #13818:
URL: https://github.com/apache/kafka/pull/13818#discussion_r1222869378
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java:
##
@@ -1268,39 +1270,55 @@ public void alterConnectorOffsets(String connName,
Map
lucasbru commented on code in PR #13829:
URL: https://github.com/apache/kafka/pull/13829#discussion_r1222994406
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -294,7 +297,13 @@ private void closeDirtyAndRevive(final Collection
lucasbru commented on code in PR #13829:
URL: https://github.com/apache/kafka/pull/13829#discussion_r1222992405
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -1970,6 +1970,29 @@ public void
cadonna commented on code in PR #13712:
URL: https://github.com/apache/kafka/pull/13712#discussion_r1222986401
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -3694,12 +3694,12 @@ public Map
prepareCommit() {
@Test
cadonna commented on code in PR #13829:
URL: https://github.com/apache/kafka/pull/13829#discussion_r1222976522
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -1970,6 +1970,29 @@ public void
cadonna commented on code in PR #13829:
URL: https://github.com/apache/kafka/pull/13829#discussion_r1222962171
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -294,7 +297,13 @@ private void closeDirtyAndRevive(final Collection
lucasbru commented on code in PR #13829:
URL: https://github.com/apache/kafka/pull/13829#discussion_r1222946279
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -294,7 +297,13 @@ private void closeDirtyAndRevive(final Collection
cadonna opened a new pull request, #13829:
URL: https://github.com/apache/kafka/pull/13829
Fixes a bug regarding the state updater where tasks that experience
corruption during restoration are passed from the state updater to the stream
thread for closing and reviving but then the revived
tinaselenge commented on PR #13760:
URL: https://github.com/apache/kafka/pull/13760#issuecomment-1582411061
@divijvaidya @showuon @mimaison Thank you very much for reviewing the PR!
I believe I have addressed the comments now. Please let me know if I have
missed anything. Thanks.
showuon opened a new pull request, #13828:
URL: https://github.com/apache/kafka/pull/13828
add "remote.log.metadata.manager.listener.name" config to rlmm to allow
producer/consumer to connect to the server. Also add tests.
### Committer Checklist (excluded from commit message)
- [
showuon commented on PR #13807:
URL: https://github.com/apache/kafka/pull/13807#issuecomment-1582296785
@satishd , FYI
Failed tests are unrelated:
```
Build / JDK 17 and Scala 2.13 /
jlprat commented on code in PR #13827:
URL: https://github.com/apache/kafka/pull/13827#discussion_r1222732234
##
.github/workflows/stale.yml:
##
@@ -0,0 +1,47 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the
mimaison commented on code in PR #13760:
URL: https://github.com/apache/kafka/pull/13760#discussion_r1222667563
##
clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteRecordsHandler.java:
##
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the Apache Software Foundation
ashwinpankaj commented on code in PR #13801:
URL: https://github.com/apache/kafka/pull/13801#discussion_r1222706232
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java:
##
@@ -279,10 +280,33 @@ public Future set(Map
values,
[
https://issues.apache.org/jira/browse/KAFKA-15074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
YaYun Wang updated KAFKA-15074:
---
Description:
I got ?? "Fetch position FetchPosition{offset=42574305,
offsetEpoch=Optional[2214],
[
https://issues.apache.org/jira/browse/KAFKA-15074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
YaYun Wang updated KAFKA-15074:
---
Description:
I got ?? "Fetch position FetchPosition{offset=42574305,
offsetEpoch=Optional[2214],
urbandan commented on PR #13796:
URL: https://github.com/apache/kafka/pull/13796#issuecomment-1582188829
> I guess I just need to clarify what retried batches are here -- is the
idea that we wait for inflight batches to return a response or time out? What
if the response triggers another
showuon commented on code in PR #13650:
URL: https://github.com/apache/kafka/pull/13650#discussion_r1222665546
##
connect/mirror/README.md:
##
@@ -1,297 +0,0 @@
-
-# MirrorMaker 2.0
-
-MM2 leverages the Connect framework to replicate topics between Kafka
-clusters. MM2 includes
divijvaidya commented on code in PR #13823:
URL: https://github.com/apache/kafka/pull/13823#discussion_r1222638839
##
server-common/src/test/java/org/apache/kafka/server/util/MockTime.java:
##
@@ -27,15 +23,21 @@
* 1. This has an associated scheduler instance for managing
showuon commented on code in PR #13760:
URL: https://github.com/apache/kafka/pull/13760#discussion_r1222617381
##
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java:
##
@@ -2291,6 +2289,8 @@ public void testDeleteRecords() throws Exception {
showuon commented on code in PR #13760:
URL: https://github.com/apache/kafka/pull/13760#discussion_r1222617381
##
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java:
##
@@ -2291,6 +2289,8 @@ public void testDeleteRecords() throws Exception {
[
https://issues.apache.org/jira/browse/KAFKA-14995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730436#comment-17730436
]
Steven Booke commented on KAFKA-14995:
--
[~vvcephei] Hello John, this will be my first time
urbandan commented on code in PR #13591:
URL: https://github.com/apache/kafka/pull/13591#discussion_r1222556934
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -609,14 +686,15 @@ public synchronized void
69 matches
Mail list logo