[openssl.org #3364] misleading description for -noout in the sess_id application

2014-05-23 Thread Matt Caswell via RT
Patch applied: http://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=c5f0b9bd8650a92eac1ef2fa28c726bbbc272904 Thanks for your contribution. Matt __ OpenSSL Project http://www.openssl.org Develop

[openssl.org #3360] Error building openssl with TLS_DEBUG

2014-05-24 Thread Matt Caswell via RT
Fixed. http://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=955376fde3c60999b27deeebb41d82ad17dca3da Thanks for the report. Matt __ OpenSSL Project http://www.openssl.org Development Mailing Li

[openssl.org #3365] Wrong parameter types in SSL_set_msg_callback[_arg] man page

2014-05-25 Thread Matt Caswell via RT
Fixed: http://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=15658d0cbf51ae32f7c9d0d3dc1eac36e220a167 Thanks for the report. Matt __ OpenSSL Project http://www.openssl.org Development Mailing Li

[openssl.org #3351] BUG: asn1parse chokes with data outside begin/end

2014-05-26 Thread Matt Caswell via RT
This is a feature not a bug ;-) This is actually by design, in that asn1parse is capable of handing arbitrary base64 encoded data (without the PEM BEGIN and END markers). As such it's not quite as simple as just modifying the behaviour to work in the way that you have described (since this would b

[openssl.org #3351] BUG: asn1parse chokes with data outside begin/end

2014-05-26 Thread Matt Caswell via RT
Thanks for the feedback. I have changed tack slightly: http://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=3d9243f1b614640f3dcbba0d7de89f363581e8e0 I think this is a better approach anyway, and resolves your issue with trailing data after the END marker. Matt ___

[openssl.org #3350] Problem using gost engine in Apache 2

2014-05-27 Thread Matt Caswell via RT
Dmitry has confirmed that this is not a defect, so closing this ticket. Matt __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automat

[openssl.org #2598] GOST engine memory problems

2014-05-27 Thread Matt Caswell via RT
Dmitry has confirmed that this is not a defect, so closing this ticket. Matt __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automat

[openssl.org #3346] [PATCH] make test/Makefile cross-platform

2014-05-27 Thread Matt Caswell via RT
Patch applied: http://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=028bac0670c167f154438742eb4d0fbed73df209 Many thanks for your contribution. Matt __ OpenSSL Project http://www.openssl.org De

[openssl.org #3366] 1.0.1g / Windows & Linux / 2 enhancement requests & 2 patches

2014-05-28 Thread Matt Caswell via RT
Hi Libor Many thanks for your submission. Please could your resubmit this with a separate ticket for each item? Having a single ticket for multiple issues makes it quite difficult for us to track and manage - they may not all be reviewed at the same time, or by the same person. Thanks Matt ___

[openssl.org #3363] Patch to fix bad example in ciphers(1) man page

2014-05-30 Thread Matt Caswell via RT
Hi Hubert The title for this request is slightly misleading as this was actually 3 commits only one of which was regards to an example in ciphers(1). Taking the 3 commits in turn: fix example with DH cipher suites: I don't agree that the man page implies anything about anonymous ECDH when it tal

[openssl.org #3319] [Bug report & Patch] Fix TLS export keying material generation for TLS 1.2 version

2014-06-01 Thread Matt Caswell via RT
Steve Henson has comitted this here: https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=4fdf917 Thanks Matt __ OpenSSL Project http://www.openssl.org Development Mailing List

[openssl.org #3362] [PATCH] use-after-free bug in dtls1_buffer_record (ssl/d1_pkt.c)

2014-06-01 Thread Matt Caswell via RT
Hi David Patch applied: https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=d1e1aee Many thanks for your contribution. Matt __ OpenSSL Project http://www.openssl.org Development Mailing

[openssl.org #3344] PATCH: don't crash or fail in ASN1_print from t_pkey.c

2014-06-01 Thread Matt Caswell via RT
On Thu May 29 08:28:24 2014, noloa...@gmail.com wrote: > Matt - > > I have not forgot about this I can't find the machine I wrote the > code on (my place probably looks a lot like your place - different > computers and laptops with different OSes all over the place). My place does look a bit l

[openssl.org #3324] [PATCH] Remedy the coding style after heartbleed

2014-06-02 Thread Matt Caswell via RT
This pull request appears to be closed. Is this ticket still valid? Matt __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated L

[openssl.org #3370] 1.0.1g / Windows / patch - wrong OPENSSL_EC_NISTP_64_GCC_128 definition in ec_lcl.h

2014-06-03 Thread Matt Caswell via RT
Patch applied: https://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=8e3231642b89332fa56ed2b6f501e28722e2048e Thanks for your contribution. Matt __ OpenSSL Project http://www.openssl.org Develo

[openssl.org #3372] Possible patch for typo fix in version number of dylib

2014-06-03 Thread Matt Caswell via RT
Hi Lubu Thanks for your submission. However this is intentional and won't be changed. Closing this ticket. Matt __ OpenSSL Project http://www.openssl.org Development Mailing List

[openssl.org #3376] 0.9.8za/1.0.0m/1.0.1h build failure in ssl/s3_pkt.c - missing include for limits.h

2014-06-05 Thread Matt Caswell via RT
On Thu Jun 05 20:40:49 2014, rainer.j...@kippdata.de wrote: > File ssl/s3_pkt.c uses INT_MAX since May 19th. This macro is defined in > limits.h which is not included in s3_pkt.c. > > +#include > #include > #include Hmmmlook two lines down from where you've added an include for limits.h???

[openssl.org #3376] 0.9.8za/1.0.0m/1.0.1h build failure in ssl/s3_pkt.c - missing include for limits.h

2014-06-05 Thread Matt Caswell via RT
On 05/06/14 20:08, Rainer Jung wrote:> One correction to self: no problem for 1.0.1, which had been fixed in > commit 8ca7d124304502158fba780eed293c4e3c5c1c71 "Fixed Windows > compilation failure". > > But 1.0.0 and 0.9.8 lack tha addition. I have back ported the commit to 1.0.0 and 0.9.8 Matt _

[openssl.org #3331] [PATCH] respect LDFLAGS during build

2014-06-05 Thread Matt Caswell via RT
Hi Mike On Sun Apr 27 13:04:20 2014, vap...@gentoo.org wrote: > It's a standard setting that other build systems use. Can you explain why you need this? > @@ -217,6 +217,7 @@ BUILDENV= PLATFORM='$(PLATFORM)' > PROCESSOR='$(PROCESSOR)' \ > MAKEDEPEND='{TOP}/util/domd {TOP} -MD $(MAKEDEPP

[openssl.org #3378] heartbeat_test: Using internal APIs

2014-06-05 Thread Matt Caswell via RT
On Thu Jun 05 20:41:05 2014, k...@roeckx.be wrote: > This is probably related to me not exporting those symbols as they are > marked local. Kurt Is this related to the way you build the Debian packages? We are likely to see a lot more like this as Mike's test team get going. In unit testing its "

[openssl.org #3378] heartbeat_test: Using internal APIs

2014-06-05 Thread Matt Caswell via RT
On Thu Jun 05 23:42:31 2014, k...@roeckx.be wrote: > > > We are likely to see > > a lot more like this as Mike's test team get going. In unit testing > its "okay" > > to access internal symbols. > > But then you shouldn't link to the shared library. The static > library probably works. Any chance

[openssl.org #3379] OpenSSL 0.9.8za fails to build on Solaris 9 - INT_MAX undefined

2014-06-07 Thread Matt Caswell via RT
Hi Tim Thanks for the report. This has already been fixed in git: https://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=bfce4e5d6ecd445e6e000387deb9afc435778c6b Closing this ticket. Matt __ OpenSSL Project

[openssl.org #3382] Missing Include for Solaris 10 / Studio 12/ OpenSSL 0.9.8za

2014-06-07 Thread Matt Caswell via RT
Hi Marty Thanks for the report. This has already been fixed in git: https://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=bfce4e5d6ecd445e6e000387deb9afc435778c6b Closing this ticket. Matt __ OpenSSL Project

[openssl.org #3389] [PATCH] Create ~/.rnd with mode 0600 instead of 0666

2014-06-08 Thread Matt Caswell via RT
Patch merged: https://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=7be1d8764d30d2f04696d7f834df349bc4bffd73 Thanks for the contribution Matt __ OpenSSL Project http://www.openssl.org Developme

[openssl.org #3381] Typo in macro name for ASN (1.0.1h)

2014-06-08 Thread Matt Caswell via RT
Hi Quanah Thanks for the submission. The problem with correcting this is that technically it forms part of the public API (since the macro is defined in asn1.h). I guess there's probably not a huge risk in changing it, as I can't imagine there's too many people relying on that define being there,

[openssl.org #3384] Patch: add ECC strings to ciphers(1), point out difference between DH and ECDH

2014-06-08 Thread Matt Caswell via RT
Hi Hubert Nice patch! A couple of comments: * aNULL also includes some SRP based ciphersuites SRP-AES-256-CBC-SHA SSLv3 Kx=SRP Au=None Enc=AES(256) Mac=SHA1 SRP-3DES-EDE-CBC-SHA SSLv3 Kx=SRP Au=None Enc=3DES(168) Mac=SHA1 SRP-AES-128-CBC-SHA SSLv3 Kx=SRP Au=None Enc=AES(128) Mac=SHA1 * The patch

[openssl.org #3378] heartbeat_test: Using internal APIs

2014-06-08 Thread Matt Caswell via RT
Merged. Thanks for your contribution. Matt __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager

[openssl.org #3380] OpenSSL 1.0.1h on SGI IRIX

2014-06-10 Thread Matt Caswell via RT
Hi Pieter Can you confirm that this resolves your problem: https://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=5a0d057e49a6f7b5ee5ff6f8af5ae395abc7b918 Thanks Matt __ OpenSSL Project http://

[openssl.org #3396] SRP and aNULL

2014-06-10 Thread Matt Caswell via RT
RFC5054 says: "Cipher suites that begin with TLS_SRP_SHA_RSA or TLS_SRP_SHA_DSS require the server to send a certificate message containing a certificate with the specified type of public key, and to sign the server key exchange message using a matching private key. Cipher suites that do not incl

[openssl.org #3384] Patch: add ECC strings to ciphers(1), point out difference between DH and ECDH

2014-06-10 Thread Matt Caswell via RT
Hi Hubert Many thanks for your contribution. I have merged all 3 of your pull requests. Nice work! https://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=343e5cf194b7baf244ed24efa4b8e6d9fc5d4921 https://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=4ceddeea6c626a922e1b8f54b6fe1d2b89f8ef90 ht

[openssl.org #3384] Patch: add ECC strings to ciphers(1), point out difference between DH and ECDH

2014-06-10 Thread Matt Caswell via RT
Should have added: I did not include the issue around SRP and aNULL. I thought this was a bit odd myself, so after a bit of investigation have decided this is a bug. Raised as #3396 Matt __ OpenSSL Project

[openssl.org #3380] OpenSSL 1.0.1h on SGI IRIX

2014-06-11 Thread Matt Caswell via RT
Closing this ticket. Patch has been reported as working. Matt __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager

[openssl.org #3396] SRP and aNULL

2014-06-11 Thread Matt Caswell via RT
Steve H has fixed this through this commit: https://github.com/openssl/openssl/commit/447280ca7babd7532f23ab7afd9e8393f0b07fc0 Matt __ OpenSSL Project http://www.openssl.org Development Mailing Lis

[openssl.org #3377] 0.9.8za/1.0.0m incomplete backport from 1.0.1h in ssl/s3_pkt.c

2014-06-12 Thread Matt Caswell via RT
Fixed. I have made the following commit to master and 1.0.2: https://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=d84ba7ea23b386f3fe56c4fe7a7aa8ece2e0c356 And this one to 1.0.0 and 0.9.8: https://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=d663f506dc43752b64db58e9169e2e200b3b4be6 Many t

[openssl.org #3372] Possible patch for typo fix in version number of dylib

2014-06-12 Thread Matt Caswell via RT
This version number refers to the ABI version of the library. Matt __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Ma

[openssl.org #3375] Patch: Off-by-one errors in ssl_cipher_get_evp()

2014-06-12 Thread Matt Caswell via RT
Patch applied: https://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=abfb989fe0b749ad61f1aa4cdb0ea4f952fc13e0 Many thanks for your contribution. Matt __ OpenSSL Project http://www.openssl.org D

[openssl.org #3373] [BUG] [WIN] DLL copyright message not synchronize for quite a while

2014-06-16 Thread Matt Caswell via RT
To be honest I'm not too sure what the policy here is, but I think we generally don't update copyright messages unless some significant change is made. There are a lot of files in the OpenSSL source code with these dates inI'd rather not go through each one individually fixing them! Matt

[openssl.org #3385] Patch: document -trusted_first option in man pages and help.

2014-06-16 Thread Matt Caswell via RT
Hi Hubert Thanks for the patch! I've had a look. The apps s_time and ts do not support the -trusted_first option, so I think you need to modify this aspect before this could be merged. Thanks Matt __ OpenSSL Project

[openssl.org #3386] Allow custom iteration count in the PKCS#8 application

2014-06-17 Thread Matt Caswell via RT
Merged: https://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=8a6c6bbf21cc11ea0fed69a106250af0d734d786 https://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=96fc4b72506c1573fd80cfc1d2e5ca4d3d0c2b3f https://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=8a531c22b03dea40e09a95a01dff0639bd56ff

[openssl.org #3385] Patch: document -trusted_first option in man pages and help.

2014-06-19 Thread Matt Caswell via RT
Hi Hubert Many thanks for this very useful patch. I have applied to master here: https://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=e42d84be33cc3cf68012917cc4bf8a9895130149 (also see parents of that commit) I made a minor typo correction here: https://git.openssl.org/gitweb/?p=openssl.git;a

[openssl.org #3375] Patch: Off-by-one errors in ssl_cipher_get_evp()

2014-06-22 Thread Matt Caswell via RT
On Sun Jun 22 20:00:14 2014, k...@x64architecture.com wrote: > Hello, > > Sorry about this whole mess, the issue was discovered and fixed by the > OpenBSD team. I reply'd to the original person who discovered my > mistake of not attributing the OpenBSD team instead of to this list (I > thought I re

[openssl.org #3344] PATCH: don't crash or fail in ASN1_print from t_pkey.c

2014-06-28 Thread Matt Caswell via RT
Not had any further feedback on this issue, so setting this to stalled. Matt __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automa

[openssl.org #3393] PATCH: EVP_SignInit.pod update

2014-06-29 Thread Matt Caswell via RT
Applied. Thanks for your contribution. https://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=6e6ba36d980f67b6e5c7b139f78da7acbbf8ec76 Matt __ OpenSSL Project http://www.openssl.org Development

[openssl.org #3411] Fixed possible null pointers if malloc fails

2014-06-29 Thread Matt Caswell via RT
Closing this as a dupe of #3198 Matt __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager

[openssl.org #3414] OpenSSL: Status of official fix for CVE-2014-0198

2014-07-01 Thread Matt Caswell via RT
I can confirm that "CVE-2014-0198" is fixed in OpenSSL-1.0.1h. Setting this ticket to resolved. Matt __ OpenSSL Project http://www.openssl.org Development Mailing List openss

[openssl.org #3415] Bug report: Uninitialized memory reads reported by valgrind for ECDSA signatures

2014-07-03 Thread Matt Caswell via RT
) Hmmmneeds some more thought. Matt commit 51518506c10cde225d4eb7590b2bc4f0ea67c959 Author: Matt Caswell Date: Thu Jul 3 22:09:08 2014 +0100 Added PURIFY section to initialise variables in BN_consttime_swap to stop valgrind complaining. Assumes constant time is not important when PURIFY

[openssl.org #3416] PATCH: EVP_EncryptionInit and AES-NI note

2014-07-05 Thread Matt Caswell via RT
Thanks Jeff: https://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=75b7606881b08a892f487629cc30e63dff1800cb Applied to master, 1.0.2 and 1.0.1. I don't believe 1.0.0 has AES-NI support (?) so haven't applied it to that branch. Matt

[openssl.org #3430] ssltest fails when using -DTEMP_GOST_TLS

2014-07-06 Thread Matt Caswell via RT
Please raise this issue on the openssl-users list - this is preferred way of raising support questions. If there is a definite bug then please re-raise a ticket in RT. Closing this ticket for now. Matt __ OpenSSL Project

[openssl.org #3433] ESXi 4.1 SSL Patch

2014-07-06 Thread Matt Caswell via RT
Please raise this issue on the openssl-users list - this is the preferred way of raising support questions. If there is a definite bug then please re-raise a ticket in RT. Closing this ticket for now. Matt __ OpenSSL Project

[openssl.org #3437] Bug in TLS Client Hello CipherSuite List

2014-07-06 Thread Matt Caswell via RT
Copying Kurt Roeckx response to this below (which only went to the openssl-dev list, and not to RT). Based on Kurt's response I am closing this ticket for now. Please re-open by responding to this email if you still think this is a defect. Matt On Sun, Jul 06, 2014 at 10:18:29AM +0200, Kaufm

[openssl.org #3425] Potential padding oracle in evp_enc.c

2014-07-07 Thread Matt Caswell via RT
Emilia is looking at this - assigning this ticket to her. Matt __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manage

[openssl.org #3439] Memory leak bug

2014-07-09 Thread Matt Caswell via RT
Fixed: https://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=66816c53bea0ecddb9448da7ea9a51a334496127 I think you meant it should be done like this: if ((a->method != NULL) && (a->method->destroy != NULL)) a->method->destroy(a); This has been lurking there since SSLeay. In practice I don't thi

[openssl.org #3441] bug report - RAND_cleanup in apps_shutdown problem

2014-07-10 Thread Matt Caswell via RT
Running the applications in this way is not supported. Closing this ticket. Matt __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Aut

[openssl.org #3442] [patch] AES XTS: supporting custom iv from openssl enc command

2014-07-10 Thread Matt Caswell via RT
On Wed Jul 09 16:24:04 2014, lull...@yahoo.com wrote: > Hi, > > openssl enc command with -aes-xxx-xts doesnt work if an IV is specified When you say it "doesn't work", what do you mean? Do you get an error? If so what is it? > as below: > openssl enc -engine af_alg -aes-256-xts -in -out > -K

[openssl.org #3448] Overflow

2014-07-10 Thread Matt Caswell via RT
On Thu Jul 10 11:26:46 2014, bcha...@akamai.com wrote: > Hello, > I have been looking at the OpenSSL source code, and this jumped out as a > possible error. 'n¹ is an unsigned before it is passed into ssl3_read_n, > which causes the worry of an overflow. To prevent this, I added check that > just m

[openssl.org #3415] Bug report: Uninitialized memory reads reported by valgrind for ECDSA signatures

2014-07-13 Thread Matt Caswell via RT
Fix applied: https://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=f8571ce82292ed340ed6302635f9bd6dfbc1043a Approach based on Rich Salz's suggestion. This seems to be the most pragmatic way forward, although it does have the disadvantage that this will mask any other future problems in the bn

[openssl.org #3442] [patch] AES XTS: supporting custom iv from openssl enc command

2014-07-13 Thread Matt Caswell via RT
I propose the following patch to deal with this ticket (for master, 1.0.2 and 1.0.1), i.e. disable XTS for the enc utility. Any objections? Matt diff --git a/apps/enc.c b/apps/enc.c index 928d16b..48f1f8b 100644 --- a/apps/enc.c +++ b/apps/enc.c @@ -339,6 +339,12 @@ bad: goto end; } + if (ciphe

[openssl.org #3446] test/testutil.h test registry macros

2014-07-13 Thread Matt Caswell via RT
Hi Mike I'm looking at this. I'll get back to you once I've reviewed. Matt __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automate

[openssl.org #3443] [patch] Implement Camellia-CBC suites from RFC6367

2014-07-14 Thread Matt Caswell via RT
Taking this ticket to investigate further. Matt __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager

[openssl.org #3442] [patch] AES XTS: supporting custom iv from openssl enc command

2014-07-16 Thread Matt Caswell via RT
Fixed (with dkg's suggested wording change): https://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=2097a17c576f2395a10b05f14490688bc5f45a07 Matt __ OpenSSL Project http://www.openssl.org Develo

[openssl.org #3446] test/testutil.h test registry macros

2014-07-19 Thread Matt Caswell via RT
Applied to master. Thanks Mike! Matt __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager

[openssl.org #3457] Possible Bugs in EVP_KeyToBytes?

2014-07-19 Thread Matt Caswell via RT
Closing this ticket in favour of PR#3462. Matt __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager

[openssl.org #3450] Out-of-bounds read in ssl3_get_key_exchange (ssl/s3_clnt.c)

2014-07-19 Thread Matt Caswell via RT
Taking this ticket. Matt __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager majord...@

[openssl.org #2569] [PATCH] EC_POINT_invert checks wrong function pointer

2014-07-21 Thread Matt Caswell via RT
On 21/07/14 21:34, Billy Brumley wrote: > Bump. Three year anniversary! Where's my leather gift?! > > At least libressl picked it up: > > https://github.com/libressl-portable/openbsd/commit/530a3e9ab5b28202266d1a443d4f0da1d2452372 > > BBB Your leather gift is here: https://git.openssl.org/gitweb/?

[openssl.org #3467] FW: Critical vulnerabilities found (#8083-432678597-2590)

2014-07-22 Thread Matt Caswell via RT
If you originally obtained your copy of OpenSSL in binary form (such as from your OS vendor), then please get hold of the latest copy from them. If you originally obtained your copy of OpenSSL in source form then you will need to build a new version from the latest release on the OpenSSL website.

[openssl.org #3450] Out-of-bounds read in ssl3_get_key_exchange (ssl/s3_clnt.c)

2014-08-15 Thread Matt Caswell via RT
Many thanks for your report. Fixed in this commit (and other similar commits for other branches): https://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=f2be92b94dad3c6cbdf79d99a324804094cf1617 Matt __ OpenSSL Project

[openssl.org #3443] [patch] Implement Camellia-CBC suites from RFC6367

2014-08-15 Thread Matt Caswell via RT
Many thanks for your patch. Applied here: https://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=750487899ad2b794078ed998b513a4a14f60f2cc Matt __ OpenSSL Project http://www.openssl.org Developme

[openssl.org #2693] [OpenSSL 1.0.1 beta 2] crypto/ec/ec_key.c - double header inclusion

2014-08-29 Thread Matt Caswell via RT
Someone already fixed this for 1.0.2 and 1.0.1, but for some reason it wasn't fixed in master/1.0.0/0.9.8. I've fixed this now. Thanks for the report. Matt __ OpenSSL Project http://www.openssl.or

[openssl.org #2725] [Patch] Openssl 1.0.1 beta2 - ec_key.c - EC_KEY_generate_key() overwrites user-defined private key

2014-08-29 Thread Matt Caswell via RT
This is working as designed. From the man page: EC_KEY_generate_key generates a new public and private key for the supplied eckey object. Matt __ OpenSSL Project http://www.openssl.org Development

[openssl.org #3530] Problems measuring openssl speed

2014-09-16 Thread Matt Caswell via RT
On 16/09/14 19:31, Dmitry Belyavsky wrote:> Hello! > > I've made a quick fix to solve this problem (attached). The main problem > with this fix is to move locally-defined engine constants to the level > of evp.h, so if you suggest a better solution, I am ready to implement it. > > Thank you! > > >

[openssl.org #3530] Problems measuring openssl speed

2014-09-18 Thread Matt Caswell via RT
On Wed Sep 17 21:41:01 2014, beld...@gmail.com wrote: > Hello Matt, > > the improved patch is attached. It uses the EVP_DigestSign* API > instead of > EVP_digest and does not modify any header files. > > Thank you! Hi Dmitry There are still some significant problems with this patch as it is curr

[openssl.org #3551] [PATCH] Removed duplicated and identical definition of PKCS7_type_is_encrypted

2014-10-06 Thread Matt Caswell via RT
Patch applied to master, 1.0.2, 1.0.1 and 1.0.0: https://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=e0fdea3e49e7454aa76bd5ecf3a3747641354c68 Many thanks for the contribution Matt __ OpenSSL Project

[openssl.org #3592] bug report. Crash. Critical? Security bug?

2014-11-12 Thread Matt Caswell via RT
That link just asks me to log in? __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager ma

[openssl.org #3582] Request openssl-1.0.1j Makefile: move build_tests to do in test

2014-11-12 Thread Matt Caswell via RT
We have no plans to change this. __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager maj

[openssl.org #3595] Free of garbage pointer in ec_wNAF_mul (crypto/ec/ec_mult.c)

2014-11-12 Thread Matt Caswell via RT
Many thanks for the report. Fixed in this commit: https://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=e04d426bf98ebb22abf0f15b6f09d333a6e8b2ad Matt __ OpenSSL Project http://www.openssl.org D

[openssl.org #3535] TS high-precision time malformation

2014-11-12 Thread Matt Caswell via RT
Many thanks for the report and patch. Applied here: https://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=ae64fb528ecc1bc0452842c5217e5989df1177ad Matt __ OpenSSL Project http://www.openssl.org

[openssl.org #3599] [PATCH] Fixes a typo in the docs for EVP_EncryptUpdate

2014-11-12 Thread Matt Caswell via RT
Many thanks. Patch applied: https://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=5211e094dec9486a540ac480f345df1a8d2b2862 Matt __ OpenSSL Project http://www.openssl.org Development Mailing List

[openssl.org #3532] FW: [openssl] Build on Windows fails if cloned with git (#174)

2014-11-12 Thread Matt Caswell via RT
I think this is more of a problem with your git config than with OpenSSL. >From an OpenSSL git repo on Windows try this: git config core.autocrlf false git config core.eol lf git checkout . Matt __ OpenSSL Project

[openssl.org #3592] bug report. Crash. Critical? Security bug?

2014-11-12 Thread Matt Caswell via RT
On Thu Nov 06 10:38:23 2014, v.badal...@open-bs.ru wrote: > HI all > > CentOS x86_64 release 6.6 (Final) > > OpenSSL> version > OpenSSL 1.0.1e-fips 11 Feb 2013 > > # rpm -qa | grep openssl > openssl-devel-1.0.1e-30.el6_6.2.x86_64 > openssl-debuginfo-1.0.1e-30.el6_6.2.x86_64 > openssl-1.0.1e-30.el6_

[openssl.org #3532] FW: [openssl] Build on Windows fails if cloned with git (#174)

2014-11-13 Thread Matt Caswell via RT
On Thu Nov 13 01:15:10 2014, esado...@eniks.com wrote: > Matt, > > It is not just my problem. Google that error and you will find plenty > of other > people having this issue as far back as 5 years ego. I already have > solution > in place and I do not require any fixing but all the people on Windo

[openssl.org #3602] [PATCH]

2014-11-16 Thread Matt Caswell via RT
Unfortunately I don't think it is as simple as that. If I understand the previous change correctly, Emilia has deliberately removed the error message as part of work to protect against timing attacks. The very act of adding an error to the error queue could introduce a measurable timing difference

[openssl.org #3610] Bug, Regression from 1.0.0 : Cannot connect to www.vehicleenquiry.service.gov.uk

2014-11-24 Thread Matt Caswell via RT
On Mon Nov 24 09:40:37 2014, aliosa.janko...@gmail.com wrote: > The connection to www.vehicleenquiry.service.gov.uk fails with openssl > 1.0.1j even if it works well in IE and Google Chrome. This is actually a > regression because it works well even in openssl 1.0.0o version. I > discovered the iss

[openssl.org #3609] Requesting to change the Spelling mistake: Can be changed as bits instead of bit on displaying key size

2014-11-24 Thread Matt Caswell via RT
As per Hubert's note, either usage seems correct to me. Closing this ticket. Matt -BEGIN PGP PUBLIC KEY BLOCK- Version: GnuPG v1 mQENBFGALsIBCADBkh6zfxbewW2KJjaMaishSrpxuiVaUyvWgpe6Moae7JNCW8ay hJbwAtsQ69SGA4gUkyrR6PBvDMVYEiYqZwXB/3IErStESjcu+gkbmsa0XcwHpkE3 iN7I8aU66yMt710nGEmcrR5E4u4N

[openssl.org #3608] SEGV Crash in dtls1_retransmit_message function

2014-11-24 Thread Matt Caswell via RT
On Sun Nov 23 19:09:46 2014, prav...@viptela.com wrote: > This happens when the server is unreachable. The client when it is trying > to resend the client_hello is barfing on fragment->frag value. Is this > known issue ? Let me know if you need any more info. > > Not consistently reproducible. Plea

[openssl.org #3592] bug report. Crash. Critical? Security bug?

2014-11-24 Thread Matt Caswell via RT
On Sat Nov 22 13:19:13 2014, v.badal...@open-bs.ru wrote: > Find this: > https://bugzilla.redhat.com/show_bug.cgi?format=multiple&id=987158 > http://openssl.6102.n7.nabble.com/AES-cbc-encrypt-amp-aesni-cbc- > encrypt-length-parameter-td52370.html > http://www.hardening-consulting.com/en/posts/20140

[openssl.org #3608] SEGV Crash in dtls1_retransmit_message function

2014-11-25 Thread Matt Caswell via RT
track down why its not being correctly set. If you get another crash with this patch applied, then please capture the core and let me know what you find out. Thanks Matt >From 90e37eb304a697e37ebd857ea5456435fa236bc9 Mon Sep 17 00:00:00 2001 From: Matt Caswell Date: Tue, 25 Nov 2014 13:36:00

[openssl.org #3606] Need RSA_pubkey_digest()

2014-11-25 Thread Matt Caswell via RT
On Thu Nov 20 21:35:45 2014, phil...@redfish-solutions.com wrote: > Can the following function please be added: > > int RSA_public_digest(const RSA* key, const EVP_MD *type, unsigned > char *md, unsigned int *len); > > which would use “type” to generate a digest over the DER encoding of > the publi

[openssl.org #3605] bug report: compilation error and fix for OpenSSL on Cygwin64

2014-11-25 Thread Matt Caswell via RT
OpenSSL is currently not supported under Cygwin64. There is a port: http://sourceforge.net/p/cygwin-ports/cygwin64-openssl/ci/master/tree/1.0.1-cygwin64.patch You may wish to submit this defect there. Closing this ticket. Matt ___

[openssl.org #3585] [PATCH] OPENSSL_NO_SSL3 doesn't remove all SSLv3 bits

2014-11-25 Thread Matt Caswell via RT
Thanks for your submission. However Steve Henson has already commited a similar patch, therefore closing this ticket. Matt __ OpenSSL Project http://www.openssl.org Development Mailing List

[openssl.org #3564] Build error OpenSSL 1.0.1i

2014-11-25 Thread Matt Caswell via RT
OP reports this now working. Closing ticket. Matt __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager

[openssl.org #3574] Bug Report: Misleading comments about SSLv23_method

2014-11-25 Thread Matt Caswell via RT
Thanks for the report. This has now been fixed. Matt __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager

[openssl.org #3572] [BUG] Memory leak in DTLS re-negotiation

2014-11-26 Thread Matt Caswell via RT
Dmitry has reported that this has been fixed by this commit: https://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=8a35dbb6d89a16d792b79b157b3e89443639ec94 Closing this ticket Matt __ OpenSSL Project

Re: [openssl.org #3608] SEGV Crash in dtls1_retransmit_message function

2014-11-26 Thread Matt Caswell via RT
On 25/11/14 23:20, Praveen Kariyanahalli wrote: > Hi Matt > > Trying out your patch. Will keep you posted. In meanwhile we ran into > more valgrind issues .. on the server end. Can you please comment on them? > > ==621== 8,680 (1,488 direct, 7,192 indirect) bytes in 62 blocks are > definitely l

Fwd: Re: [openssl.org #3608] SEGV Crash in dtls1_retransmit_message function

2014-11-27 Thread Matt Caswell via RT
Resend this time including r...@openssl.org...sorry for the noise on openssl-dev... On 27/11/14 02:54, Praveen Kariyanahalli via RT wrote: >> The purpose of DTLSv1_listen is to listen for incoming datagrams from >> anyone. If it receives a ClientHello without a cookie it immediately >> responds wi

[openssl.org #3611] Segmentation fault during SSL_free

2014-11-27 Thread Matt Caswell via RT
On Tue Nov 25 09:38:33 2014, shre...@viptela.com wrote: > Version : 1.0.1j > Platform : mips64 > > The client is trying to reach a server that does not exist. And we are > trying to free the ssl peer. It has probably tried a retransmission after 1 > second and SSL_connect returned ERR_WANT. Any hel

[openssl.org #3612] Fwd: [PATCH] Missing documentation for ocsp -timeout option

2014-11-27 Thread Matt Caswell via RT
Patch applied. Many thanks, Matt __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager m

[openssl.org #3606] Need RSA_pubkey_digest()

2014-11-27 Thread Matt Caswell via RT
Adding info from Steve on how to do this on one go and reclosing this ticket: On 25/11/14 16:02, Dr. Stephen Henson wrote: > I'm curious: I've not seen the private key version before, where is it used? > > You can actually perform the encode and digest operation all in one go using > the ASN1_item

[openssl.org #3608] SEGV Crash in dtls1_retransmit_message function

2014-11-27 Thread Matt Caswell via RT
On Thu Nov 27 16:23:04 2014, prav...@viptela.com wrote: > *My approach* > > global_ssl = SSL_new(ctx); > > In Server call back function > > ret = DTLSv1_listen(global_ssl, client_addr); > if ret <= 0 return; > else socket, > bind, > connect (more specific) and > migrate the global_ssl to this peer

[openssl.org #3613] Patch: Fix warning in Nginx logs on every connect when GOST TLS used.

2014-11-27 Thread Matt Caswell via RT
Thanks for the report. I have applied a fix in git...a slightly different solution to the one proposed in your patch. Thanks Matt __ OpenSSL Project http://www.openssl.org Development Mailing List

[openssl.org #1767] bug of EVP_Cipher when use openssl engine

2014-11-27 Thread Matt Caswell via RT
Thanks for the report. This has now been fixed. Matt __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager

<    1   2   3   4   5   6   7   8   9   10   >