RE: [PATCH 15/15] drm/amdgpu: Use new interface to reserve bad page
[AMD Official Use Only - General] With my concern fixed, the series is: Reviewed-by: Tao Zhou > -Original Message- > From: Chai, Thomas > Sent: Thursday, April 18, 2024 5:35 PM > To: Christian König ; amd- > g...@lists.freedesktop.org > Cc: Zhang, Hawking ; Zhou1, Tao > ; Li, Candice ; Wang, Yang(Kevin) > ; Yang, Stanley > Subject: RE: [PATCH 15/15] drm/amdgpu: Use new interface to reserve bad page > > [AMD Official Use Only - General] > > - > Best Regards, > Thomas > > -Original Message- > From: Christian König > Sent: Thursday, April 18, 2024 5:01 PM > To: Chai, Thomas ; amd-gfx@lists.freedesktop.org > Cc: Chai, Thomas ; Zhang, Hawking > ; Zhou1, Tao ; Li, Candice > ; Wang, Yang(Kevin) ; Yang, > Stanley > Subject: Re: [PATCH 15/15] drm/amdgpu: Use new interface to reserve bad page > > Am 18.04.24 um 04:58 schrieb YiPeng Chai: > > Use new interface to reserve bad page. > > > > Signed-off-by: YiPeng Chai > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c > > index d1a2ab944b7d..dee66db10fa2 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c > > @@ -2548,9 +2548,7 @@ int amdgpu_ras_add_bad_pages(struct > amdgpu_device *adev, > > goto out; > > } > > > > - amdgpu_vram_mgr_reserve_range(>mman.vram_mgr, > > - bps[i].retired_page << AMDGPU_GPU_PAGE_SHIFT, > > - AMDGPU_GPU_PAGE_SIZE); > > > Were is the call to reserve the VRAM range now moved? > > [Thomas] Called in amdgpu_ras_reserve_page, amdgpu_ras_reserve_page refer > to " [PATCH 01/15] drm/amdgpu: Add interface to reserve bad page " > > Regards, > Christian. > > > + amdgpu_ras_reserve_page(adev, bps[i].retired_page); > > > > memcpy(>bps[data->count], [i], sizeof(*data->bps)); > > data->count++; >
RE: [PATCH 15/15] drm/amdgpu: Use new interface to reserve bad page
[AMD Official Use Only - General] Ping - Best Regards, Thomas -Original Message- From: Chai, Thomas Sent: Thursday, April 18, 2024 10:59 AM To: amd-gfx@lists.freedesktop.org Cc: Chai, Thomas ; Zhang, Hawking ; Zhou1, Tao ; Li, Candice ; Wang, Yang(Kevin) ; Yang, Stanley ; Chai, Thomas Subject: [PATCH 15/15] drm/amdgpu: Use new interface to reserve bad page Use new interface to reserve bad page. Signed-off-by: YiPeng Chai --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c index d1a2ab944b7d..dee66db10fa2 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c @@ -2548,9 +2548,7 @@ int amdgpu_ras_add_bad_pages(struct amdgpu_device *adev, goto out; } - amdgpu_vram_mgr_reserve_range(>mman.vram_mgr, - bps[i].retired_page << AMDGPU_GPU_PAGE_SHIFT, - AMDGPU_GPU_PAGE_SIZE); + amdgpu_ras_reserve_page(adev, bps[i].retired_page); memcpy(>bps[data->count], [i], sizeof(*data->bps)); data->count++; -- 2.34.1
RE: [PATCH 15/15] drm/amdgpu: Use new interface to reserve bad page
[AMD Official Use Only - General] - Best Regards, Thomas -Original Message- From: Christian König Sent: Thursday, April 18, 2024 5:01 PM To: Chai, Thomas ; amd-gfx@lists.freedesktop.org Cc: Chai, Thomas ; Zhang, Hawking ; Zhou1, Tao ; Li, Candice ; Wang, Yang(Kevin) ; Yang, Stanley Subject: Re: [PATCH 15/15] drm/amdgpu: Use new interface to reserve bad page Am 18.04.24 um 04:58 schrieb YiPeng Chai: > Use new interface to reserve bad page. > > Signed-off-by: YiPeng Chai > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c > index d1a2ab944b7d..dee66db10fa2 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c > @@ -2548,9 +2548,7 @@ int amdgpu_ras_add_bad_pages(struct amdgpu_device *adev, > goto out; > } > > - amdgpu_vram_mgr_reserve_range(>mman.vram_mgr, > - bps[i].retired_page << AMDGPU_GPU_PAGE_SHIFT, > - AMDGPU_GPU_PAGE_SIZE); > Were is the call to reserve the VRAM range now moved? [Thomas] Called in amdgpu_ras_reserve_page, amdgpu_ras_reserve_page refer to " [PATCH 01/15] drm/amdgpu: Add interface to reserve bad page " Regards, Christian. > + amdgpu_ras_reserve_page(adev, bps[i].retired_page); > > memcpy(>bps[data->count], [i], sizeof(*data->bps)); > data->count++;
Re: [PATCH 15/15] drm/amdgpu: Use new interface to reserve bad page
Am 18.04.24 um 04:58 schrieb YiPeng Chai: Use new interface to reserve bad page. Signed-off-by: YiPeng Chai --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c index d1a2ab944b7d..dee66db10fa2 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c @@ -2548,9 +2548,7 @@ int amdgpu_ras_add_bad_pages(struct amdgpu_device *adev, goto out; } - amdgpu_vram_mgr_reserve_range(>mman.vram_mgr, - bps[i].retired_page << AMDGPU_GPU_PAGE_SHIFT, - AMDGPU_GPU_PAGE_SIZE); Were is the call to reserve the VRAM range now moved? Regards, Christian. + amdgpu_ras_reserve_page(adev, bps[i].retired_page); memcpy(>bps[data->count], [i], sizeof(*data->bps)); data->count++;
