Re: [asterisk-dev] [Code Review] 3407: Test Suite: Nominal caller initiated blind transfer tests using PJSIP
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3407/ --- (Updated April 16, 2014, 5:34 p.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers. Changes --- Committed in revision 4964 Bugs: ASTERISK-23446 https://issues.asterisk.org/jira/browse/ASTERISK-23446 Repository: testsuite Description --- These tests cover nominal caller initiated blind transfer tests using PJSIP. Note: All three tests currently fail due to the issues described in ASTERISK-23501 ASTERISK-23502. Each test ensures the presents and values of the following: * channel variables SIPREFERREDBYHDR, SIPREFERTOHDR, SIPTRANSFER, and SIPREFERRINGCONTEXT. * the BlindTransfer event. * the 'Referred-By' header in the INVITE sent to Charlie. Each test also sets the TRANSFER_CONTEXT channel variable to ensure the transfer still occurs properly. The 'caller_with_hold' test additionally requires and checks the MusicOnHoldStart MusicOnHoldStop events. Tests: * caller_refer_only: Uses PJSua library. Basic blind transfer without a hold or direct media being performed at any time. Changes were required to the pjsua_mod.py library to be able to associate pjsua accounts with a specific pjsua transport. * caller_direct_media: Uses SIPp. Blind transfer with direct media between the endpoints before and after the transfer. * caller_with_hold: Uses SIPp. Blind transfer with putting the callee on hold before the transfer. Diffs - /asterisk/trunk/tests/channels/pjsip/transfers/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/charlie.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/bob.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/alice.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/transfer.py PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/charlie.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/bob.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/alice.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/tests.yaml 4911 /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 4911 Diff: https://reviewboard.asterisk.org/r/3407/diff/ Testing --- * Added a pre-dial handler when dialing charlie to add the Referred-By header and commented out the header match for the SIPREFERTOHDR channel variable. This was to mimic a successful pass to validate the test. This was done for each. ** Executed tests in a loop 50+ times to ensure stability. * Reviewed test suite Asterisk logs. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3407: Test Suite: Nominal caller initiated blind transfer tests using PJSIP
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3407/#review11565 --- Ship it! Ship It! - Mark Michelson On April 4, 2014, 10:44 p.m., jbigelow wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3407/ --- (Updated April 4, 2014, 10:44 p.m.) Review request for Asterisk Developers. Bugs: ASTERISK-23446 https://issues.asterisk.org/jira/browse/ASTERISK-23446 Repository: testsuite Description --- These tests cover nominal caller initiated blind transfer tests using PJSIP. Note: All three tests currently fail due to the issues described in ASTERISK-23501 ASTERISK-23502. Each test ensures the presents and values of the following: * channel variables SIPREFERREDBYHDR, SIPREFERTOHDR, SIPTRANSFER, and SIPREFERRINGCONTEXT. * the BlindTransfer event. * the 'Referred-By' header in the INVITE sent to Charlie. Each test also sets the TRANSFER_CONTEXT channel variable to ensure the transfer still occurs properly. The 'caller_with_hold' test additionally requires and checks the MusicOnHoldStart MusicOnHoldStop events. Tests: * caller_refer_only: Uses PJSua library. Basic blind transfer without a hold or direct media being performed at any time. Changes were required to the pjsua_mod.py library to be able to associate pjsua accounts with a specific pjsua transport. * caller_direct_media: Uses SIPp. Blind transfer with direct media between the endpoints before and after the transfer. * caller_with_hold: Uses SIPp. Blind transfer with putting the callee on hold before the transfer. Diffs - /asterisk/trunk/tests/channels/pjsip/transfers/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/charlie.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/bob.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/alice.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/transfer.py PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/charlie.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/bob.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/alice.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/tests.yaml 4911 /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 4911 Diff: https://reviewboard.asterisk.org/r/3407/diff/ Testing --- * Added a pre-dial handler when dialing charlie to add the Referred-By header and commented out the header match for the SIPREFERTOHDR channel variable. This was to mimic a successful pass to validate the test. This was done for each. ** Executed tests in a loop 50+ times to ensure stability. * Reviewed test suite Asterisk logs. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3407: Test Suite: Nominal caller initiated blind transfer tests using PJSIP
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3407/ --- (Updated April 4, 2014, 5:44 p.m.) Review request for Asterisk Developers. Changes --- Addressed all feedback. Bugs: ASTERISK-23446 https://issues.asterisk.org/jira/browse/ASTERISK-23446 Repository: testsuite Description --- These tests cover nominal caller initiated blind transfer tests using PJSIP. Note: All three tests currently fail due to the issues described in ASTERISK-23501 ASTERISK-23502. Each test ensures the presents and values of the following: * channel variables SIPREFERREDBYHDR, SIPREFERTOHDR, SIPTRANSFER, and SIPREFERRINGCONTEXT. * the BlindTransfer event. * the 'Referred-By' header in the INVITE sent to Charlie. Each test also sets the TRANSFER_CONTEXT channel variable to ensure the transfer still occurs properly. The 'caller_with_hold' test additionally requires and checks the MusicOnHoldStart MusicOnHoldStop events. Tests: * caller_refer_only: Uses PJSua library. Basic blind transfer without a hold or direct media being performed at any time. Changes were required to the pjsua_mod.py library to be able to associate pjsua accounts with a specific pjsua transport. * caller_direct_media: Uses SIPp. Blind transfer with direct media between the endpoints before and after the transfer. * caller_with_hold: Uses SIPp. Blind transfer with putting the callee on hold before the transfer. Diffs (updated) - /asterisk/trunk/tests/channels/pjsip/transfers/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/charlie.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/bob.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/alice.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/transfer.py PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/charlie.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/bob.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/alice.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/tests.yaml 4911 /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 4911 Diff: https://reviewboard.asterisk.org/r/3407/diff/ Testing --- * Added a pre-dial handler when dialing charlie to add the Referred-By header and commented out the header match for the SIPREFERTOHDR channel variable. This was to mimic a successful pass to validate the test. This was done for each. ** Executed tests in a loop 50+ times to ensure stability. * Reviewed test suite Asterisk logs. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3407: Test Suite: Nominal caller initiated blind transfer tests using PJSIP
On April 3, 2014, 2:24 p.m., Mark Michelson wrote: /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/test-config.yaml, lines 46-54 https://reviewboard.asterisk.org/r/3407/diff/1/?file=56911#file56911line46 The comments here contradict what is said in the test description. The test description says that Alice transfers Bob to Charlie, but these comments say that Bob transfers Alice to Charlie. Same applies for the second scenario. I blame my copy paste for not automatically making the changes. :) - jbigelow --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3407/#review11484 --- On April 4, 2014, 5:44 p.m., jbigelow wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3407/ --- (Updated April 4, 2014, 5:44 p.m.) Review request for Asterisk Developers. Bugs: ASTERISK-23446 https://issues.asterisk.org/jira/browse/ASTERISK-23446 Repository: testsuite Description --- These tests cover nominal caller initiated blind transfer tests using PJSIP. Note: All three tests currently fail due to the issues described in ASTERISK-23501 ASTERISK-23502. Each test ensures the presents and values of the following: * channel variables SIPREFERREDBYHDR, SIPREFERTOHDR, SIPTRANSFER, and SIPREFERRINGCONTEXT. * the BlindTransfer event. * the 'Referred-By' header in the INVITE sent to Charlie. Each test also sets the TRANSFER_CONTEXT channel variable to ensure the transfer still occurs properly. The 'caller_with_hold' test additionally requires and checks the MusicOnHoldStart MusicOnHoldStop events. Tests: * caller_refer_only: Uses PJSua library. Basic blind transfer without a hold or direct media being performed at any time. Changes were required to the pjsua_mod.py library to be able to associate pjsua accounts with a specific pjsua transport. * caller_direct_media: Uses SIPp. Blind transfer with direct media between the endpoints before and after the transfer. * caller_with_hold: Uses SIPp. Blind transfer with putting the callee on hold before the transfer. Diffs - /asterisk/trunk/tests/channels/pjsip/transfers/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/charlie.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/bob.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/alice.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/transfer.py PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/charlie.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/bob.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/alice.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/tests.yaml 4911 /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 4911 Diff: https://reviewboard.asterisk.org/r/3407/diff/ Testing --- * Added a pre-dial handler when dialing charlie to add the Referred-By header and commented out the header match for the SIPREFERTOHDR channel variable. This was to mimic a successful pass to validate the test. This was done for
Re: [asterisk-dev] [Code Review] 3407: Test Suite: Nominal caller initiated blind transfer tests using PJSIP
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3407/#review11485 --- The pjsip configs here could benefit heavily from use of templates. /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/test-config.yaml https://reviewboard.asterisk.org/r/3407/#comment21209 Unless the value of SIPTRANSFER could be set to something else to indicate failure (it doesn't appear that is the case), this should go up with the conditions and the requirements section can just be dropped since it is optional. This also applies to the other usages of the requirements section here and in the other two tests. - opticron On March 29, 2014, 12:59 a.m., jbigelow wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3407/ --- (Updated March 29, 2014, 12:59 a.m.) Review request for Asterisk Developers. Bugs: ASTERISK-23446 https://issues.asterisk.org/jira/browse/ASTERISK-23446 Repository: testsuite Description --- These tests cover nominal caller initiated blind transfer tests using PJSIP. Note: All three tests currently fail due to the issues described in ASTERISK-23501 ASTERISK-23502. Each test ensures the presents and values of the following: * channel variables SIPREFERREDBYHDR, SIPREFERTOHDR, SIPTRANSFER, and SIPREFERRINGCONTEXT. * the BlindTransfer event. * the 'Referred-By' header in the INVITE sent to Charlie. Each test also sets the TRANSFER_CONTEXT channel variable to ensure the transfer still occurs properly. The 'caller_with_hold' test additionally requires and checks the MusicOnHoldStart MusicOnHoldStop events. Tests: * caller_refer_only: Uses PJSua library. Basic blind transfer without a hold or direct media being performed at any time. Changes were required to the pjsua_mod.py library to be able to associate pjsua accounts with a specific pjsua transport. * caller_direct_media: Uses SIPp. Blind transfer with direct media between the endpoints before and after the transfer. * caller_with_hold: Uses SIPp. Blind transfer with putting the callee on hold before the transfer. Diffs - /asterisk/trunk/tests/channels/pjsip/transfers/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/charlie.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/bob.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/alice.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/transfer.py PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/charlie.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/bob.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/alice.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/tests.yaml 4911 /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 4911 Diff: https://reviewboard.asterisk.org/r/3407/diff/ Testing --- * Added a pre-dial handler when dialing charlie to add the Referred-By header and commented out the header match for the SIPREFERTOHDR channel variable. This was to mimic a successful pass to validate the test. This was done for each.
Re: [asterisk-dev] [Code Review] 3407: Test Suite: Nominal caller initiated blind transfer tests using PJSIP
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3407/#review11484 --- /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/test-config.yaml https://reviewboard.asterisk.org/r/3407/#comment21208 The comments here contradict what is said in the test description. The test description says that Alice transfers Bob to Charlie, but these comments say that Bob transfers Alice to Charlie. Same applies for the second scenario. /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/transfer.py https://reviewboard.asterisk.org/r/3407/#comment21211 IMO, log_call_info would be more sane if it just took in self.call.info() as its only parameter and then extracted what it cared about afterwards. /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/transfer.py https://reviewboard.asterisk.org/r/3407/#comment21210 From on_transfer_status callback documentation: Return: If the callback returns false then no further notification will be sent for the transfer request for this call. So in other words you're supposed to return something. The docs suggest returning cont. /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/test-config.yaml https://reviewboard.asterisk.org/r/3407/#comment21212 Same comment here as for the earlier SIPp test: The comments above the scenarios contradict what the description states. - Mark Michelson On March 29, 2014, 5:59 a.m., jbigelow wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3407/ --- (Updated March 29, 2014, 5:59 a.m.) Review request for Asterisk Developers. Bugs: ASTERISK-23446 https://issues.asterisk.org/jira/browse/ASTERISK-23446 Repository: testsuite Description --- These tests cover nominal caller initiated blind transfer tests using PJSIP. Note: All three tests currently fail due to the issues described in ASTERISK-23501 ASTERISK-23502. Each test ensures the presents and values of the following: * channel variables SIPREFERREDBYHDR, SIPREFERTOHDR, SIPTRANSFER, and SIPREFERRINGCONTEXT. * the BlindTransfer event. * the 'Referred-By' header in the INVITE sent to Charlie. Each test also sets the TRANSFER_CONTEXT channel variable to ensure the transfer still occurs properly. The 'caller_with_hold' test additionally requires and checks the MusicOnHoldStart MusicOnHoldStop events. Tests: * caller_refer_only: Uses PJSua library. Basic blind transfer without a hold or direct media being performed at any time. Changes were required to the pjsua_mod.py library to be able to associate pjsua accounts with a specific pjsua transport. * caller_direct_media: Uses SIPp. Blind transfer with direct media between the endpoints before and after the transfer. * caller_with_hold: Uses SIPp. Blind transfer with putting the callee on hold before the transfer. Diffs - /asterisk/trunk/tests/channels/pjsip/transfers/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/charlie.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/bob.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/alice.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/transfer.py PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/charlie.xml PRE-CREATION
