Re: [Asterisk-Users] Feedback request: AGI GET DATA change termination digits
Hi, this is my 1.st response to this list, i hope this will work. I tend to agree with Steven since just allowing other termination digits probaly wont solve your upcoming the issues anyway. I use a wrapper around the 'get digit' which allows me to specify that the * digit repeats the menu but maxium 3 times and if the * star digit is used twice in sequence (without other digits inbetween ) then it means 'go to the menulevel above current level'. This was todays 'noise' from me. Freddi Subject: Re: [Asterisk-Users] Feedback request: AGI GET DATA change - termination digits From: Steven Critchfield [EMAIL PROTECTED] To: [EMAIL PROTECTED] Date: Sat, 18 Oct 2003 19:14:14 -0500 Reply-To: [EMAIL PROTECTED] While that change is fine, you could also just write the same functionality with get digit and deal with it inside the AGI app. On Sat, 2003-10-18 at 16:50, Paul Crick wrote: ** REPOST: A week later and no feedback - am I the only one ** who'd find this functionality useful? No other AGI stuff ** out there needing something similar? I'd like some feedback on potentially submitting a request (and probably a patch too) to change the way the AGI command GET DATA works. Right now, # terminates the entry, which is then returned with the # stripped off the end. What I'd like is to allow user configurable termination digits, which are not stripped off the end. Reasoning: Some entries you'd like to terminate with #. Right now it's fine, you can tell if # was pressed or not by looking for the lack of a (timeout) entry in the returned result. You may want to allow * to cancel an entry. This is not possible right now. Systems I've coded previously allow # to terminate and complete a digit entry, * to correct an incorrect entry (playing the prompt again and restarting digit collection). Pressing * with no prior digit entry cancels the step and returns to the previous menu. I guess there's a compatibility issue with stuff that's out there already but if it was an optional 4th parameter this would be backwards compatible. Proposed new syntax: GET DATA filename timeout maxdigits terminator If terminator is specified (and it may be multicharacter, like *# to give me the functionality above), return the digit string collected so far, including the terminating digit. The calling app can strip the trailing character if needed. Thoughts? Cheers Paul ___ Asterisk-Users mailing list [EMAIL PROTECTED] http://lists.digium.com/mailman/listinfo/asterisk-users -- Steven Critchfield [EMAIL PROTECTED] ___ Asterisk-Users mailing list [EMAIL PROTECTED] http://lists.digium.com/mailman/listinfo/asterisk-users
Re: [Asterisk-Users] Feedback request: AGI GET DATA change - termination digits
Why use this rather than STREAM FILE? On Sat, 2003-10-18 at 16:50, Paul Crick wrote: ** REPOST: A week later and no feedback - am I the only one ** who'd find this functionality useful? No other AGI stuff ** out there needing something similar? I'd like some feedback on potentially submitting a request (and probably a patch too) to change the way the AGI command GET DATA works. Right now, # terminates the entry, which is then returned with the # stripped off the end. What I'd like is to allow user configurable termination digits, which are not stripped off the end. Reasoning: Some entries you'd like to terminate with #. Right now it's fine, you can tell if # was pressed or not by looking for the lack of a (timeout) entry in the returned result. You may want to allow * to cancel an entry. This is not possible right now. Systems I've coded previously allow # to terminate and complete a digit entry, * to correct an incorrect entry (playing the prompt again and restarting digit collection). Pressing * with no prior digit entry cancels the step and returns to the previous menu. I guess there's a compatibility issue with stuff that's out there already but if it was an optional 4th parameter this would be backwards compatible. Proposed new syntax: GET DATA filename timeout maxdigits terminator If terminator is specified (and it may be multicharacter, like *# to give me the functionality above), return the digit string collected so far, including the terminating digit. The calling app can strip the trailing character if needed. Thoughts? Cheers Paul ___ Asterisk-Users mailing list [EMAIL PROTECTED] http://lists.digium.com/mailman/listinfo/asterisk-users ___ Asterisk-Users mailing list [EMAIL PROTECTED] http://lists.digium.com/mailman/listinfo/asterisk-users
[Asterisk-Users] Feedback request: AGI GET DATA change - termination digits
** REPOST: A week later and no feedback - am I the only one ** who'd find this functionality useful? No other AGI stuff ** out there needing something similar? I'd like some feedback on potentially submitting a request (and probably a patch too) to change the way the AGI command GET DATA works. Right now, # terminates the entry, which is then returned with the # stripped off the end. What I'd like is to allow user configurable termination digits, which are not stripped off the end. Reasoning: Some entries you'd like to terminate with #. Right now it's fine, you can tell if # was pressed or not by looking for the lack of a (timeout) entry in the returned result. You may want to allow * to cancel an entry. This is not possible right now. Systems I've coded previously allow # to terminate and complete a digit entry, * to correct an incorrect entry (playing the prompt again and restarting digit collection). Pressing * with no prior digit entry cancels the step and returns to the previous menu. I guess there's a compatibility issue with stuff that's out there already but if it was an optional 4th parameter this would be backwards compatible. Proposed new syntax: GET DATA filename timeout maxdigits terminator If terminator is specified (and it may be multicharacter, like *# to give me the functionality above), return the digit string collected so far, including the terminating digit. The calling app can strip the trailing character if needed. Thoughts? Cheers Paul ___ Asterisk-Users mailing list [EMAIL PROTECTED] http://lists.digium.com/mailman/listinfo/asterisk-users
Re: [Asterisk-Users] Feedback request: AGI GET DATA change - termination digits
** REPOST: A week later and no feedback - am I the only one ** who'd find this functionality useful? No other AGI stuff ** out there needing something similar? I'd like some feedback on potentially submitting a request (and probably a patch too) to change the way the AGI command GET DATA works. Right now, # terminates the entry, which is then returned with the # stripped off the end. What I'd like is to allow user configurable termination digits, which are not stripped off the end. Reasoning: Some entries you'd like to terminate with #. Right now it's fine, you can tell if # was pressed or not by looking for the lack of a (timeout) entry in the returned result. You may want to allow * to cancel an entry. This is not possible right now. Systems I've coded previously allow # to terminate and complete a digit entry, * to correct an incorrect entry (playing the prompt again and restarting digit collection). Pressing * with no prior digit entry cancels the step and returns to the previous menu. I guess there's a compatibility issue with stuff that's out there already but if it was an optional 4th parameter this would be backwards compatible. Proposed new syntax: GET DATA filename timeout maxdigits terminator If terminator is specified (and it may be multicharacter, like *# to give me the functionality above), return the digit string collected so far, including the terminating digit. The calling app can strip the trailing character if needed. Thoughts? Cheers Paul I can't comment on the usefulness of creating this additional syntax in an AGI (though it does seem like a useful shorthand method to recognize terminators and replay digits) but some of the same comments have been discussed in the bugtracker for dialplan routines. see: http://bugs.digium.com/bug_view_page.php?bug_id=181 JT ___ Asterisk-Users mailing list [EMAIL PROTECTED] http://lists.digium.com/mailman/listinfo/asterisk-users
RE: [Asterisk-Users] Feedback request: AGI GET DATA change -termination digits
While that change is fine, you could also just write the same functionality with get digit and deal with it inside the AGI app. I guess the digit handling part is doable with WAIT FOR DIGIT.. I was going to ask about interupting the prompt that played before that but on RTFM-ing I see that STREAM FILE returns the interrupting digit if interruptions are allowed. Sooo... Knock myself up a subroutine in Perl to handle flexible digit termination as I want.. or have a look at patching the GET DATA function in AGI, potentially making easier for others whilst not breaking anything that currently exists. Would bug tracker be the way to go for further discussion? Or I could go with the second option, stick it in there, and see if it makes it to CVS? Cheers Paul ___ Asterisk-Users mailing list [EMAIL PROTECTED] http://lists.digium.com/mailman/listinfo/asterisk-users
RE: [Asterisk-Users] Feedback request: AGI GET DATA change -termination digits
While that change is fine, you could also just write the same functionality with get digit and deal with it inside the AGI app. I guess the digit handling part is doable with WAIT FOR DIGIT.. I was going to ask about interupting the prompt that played before that but on RTFM-ing I see that STREAM FILE returns the interrupting digit if interruptions are allowed. Sooo... Knock myself up a subroutine in Perl to handle flexible digit termination as I want.. or have a look at patching the GET DATA function in AGI, potentially making easier for others whilst not breaking anything that currently exists. Would bug tracker be the way to go for further discussion? Or I could go with the second option, stick it in there, and see if it makes it to CVS? Cheers Paul I would suggest that if you pursue the second path (patching GET DATA) that you start a new feature request in the bugtracker, since the original item (#181) was about a request to program this into a new application for the dialplan, not AGI. Just because something can be done one way with Asterisk doesn't meant that a shorter/better/different way of doing it won't be well received if it is significantly easier and makes the life of the scripter/dialplanner less complex. JT ___ Asterisk-Users mailing list [EMAIL PROTECTED] http://lists.digium.com/mailman/listinfo/asterisk-users
[Asterisk-Users] Feedback request: AGI GET DATA change - termination digits
I'd like some feedback on potentially submitting a request (and probably a patch too) to change the way the AGI command GET DATA works. Right now, # terminates the entry, which is then returned with the # stripped off the end. What I'd like is to allow user configurable termination digits, which are not stripped off the end. Reasoning: Some entries you'd like to terminate with #. Right now it's fine, you can tell if # was pressed or not by looking for the lack of a (timeout) entry in the returned result. You may want to allow * to cancel an entry. This is not possible right now. Systems I've coded previously allow # to terminate and complete a digit entry, * to correct an incorrect entry (playing the prompt again and restarting digit collection). Pressing * with no prior digit entry cancels the step and returns to the previous menu. I guess there's a compatibility issue with stuff that's out there already but if it was an optional 4th parameter this would be backwards compatible. Proposed new syntax: GET DATA filename timeout maxdigits terminator If terminator is specified (and it may be multicharacter, like *# to give me the functionality above), return the digit string collected so far, including the terminating digit. The calling app can strip the trailing character if needed. Thoughts? Cheers Paul ___ Asterisk-Users mailing list [EMAIL PROTECTED] http://lists.digium.com/mailman/listinfo/asterisk-users
