Re: Fix illegal tab character in Fortran language test.
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 [adding the list, which would have been the more appropriate place to send this] According to Thomas Jahns on 9/4/2009 3:50 AM: Hi, in commit 58a97ecfca0650c90b5dffacd3565c2647f37f0d of the autoconf repository, you replaced several occurrences of blanks with tabs. Unfortunately TAB is not a legal character in Fortran source and one of the lines affected by your change is part of a Fortran print statement which therefore does no longer compile with e.g. gfortran -Werror. Thus I wanted to ask you to apply the attached patch. Thanks for the report (it's especially nice when a bug report comes with a patch, as well as a commit id where the regression was introduced). Shows how little I know about Fortran (and I guess things like this show why AC_FC_FREEFORM is so important in the first place, since modern Fortran has followed the lead of C in its change to allow freeform whitespace). I tweaked your patch to add a comment and quadrigraph to prevent my editor from regressing again, added THANKS, NEWS, and ChangeLog edits, and applied it. - -- Don't work too hard, make some time for fun as well! Eric Blake e...@byu.net -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkqg/KYACgkQ84KuGfSFAYDKlgCfVZFOzquUw8iO64ow3MkDtd9t 5MQAn155a5T+IHyhs4t1B4ywTF4C/8mD =gEBt -END PGP SIGNATURE- From 87c5dbd357ea16629300d46c93dc4b8239a01ccf Mon Sep 17 00:00:00 2001 From: Thomas Jahns jahns@dkrz.de Date: Fri, 4 Sep 2009 11:48:44 +0200 Subject: [PATCH] Fix illegal tab character in Fortran source. --- lib/autoconf/fortran.m4 |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/autoconf/fortran.m4 b/lib/autoconf/fortran.m4 index 93b5f9d..99e4b6b 100644 --- a/lib/autoconf/fortran.m4 +++ b/lib/autoconf/fortran.m4 @@ -1204,7 +1204,7 @@ do program freeform ! FIXME: how to best confuse non-freeform compilers? print *, 'Hello ', - 'world.' + 'world.' end], [ac_cv_fc_freeform=$ac_flag; break]) done -- 1.5.6.5
Re: AC_PREREQ comes first in autoscan
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Ralf Wildenhues on 9/1/2009 11:38 AM:
Hello,
* NightStrike wrote on Tue, Sep 01, 2009 at 06:19:07PM CEST:
This macro is the only macro that may be used before AC_INIT,
This isn't even true. AC_DEFUN and m4_define, as well as other m4sugar
elements, are widely used before AC_INIT (when you consider that
autoconf parses aclocal.m4 before it starts reading configure.ac).
AU_DEFUN and AU_ALIAS should probably be sanctioned as well.
How about simply
This macro may be used before AC_INIT.
? I think elsewhere we state that AC_INIT needs to be the first macro
that produces text in the configure script (which is a better
description of what the text you quoted really wanted to say).
Yes, indeed. Pushing this (NightStrike, let me know if you'd rather have
a real name instead of a pseudonym in THANKS):
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkqhBp0ACgkQ84KuGfSFAYAemwCfQEFueuBuUSAdE226eoBGXqgj
Z54AmQGAS+2YDjRkN9G4GupIryK8rdgw
=WT4K
-END PGP SIGNATURE-
From 0eadc08360f9dd56692186fb5d4233e091388c2d Mon Sep 17 00:00:00 2001
From: Eric Blake e...@byu.net
Date: Fri, 4 Sep 2009 06:18:52 -0600
Subject: [PATCH] Improve wording about what goes before AC_INIT.
* doc/autoconf.texi (Initializing configure): Update wording.
(Versioning) AC_PREREQ: Remove misleading text, to match
autoupdate's behavior.
* THANKS: Update.
Reported by NightStrike, with input from Ralf Wildenhues.
Signed-off-by: Eric Blake e...@byu.net
---
ChangeLog |9 +
doc/autoconf.texi | 10 ++
2 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 1ff51b4..c5be126 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2009-09-04 Eric Blake e...@byu.net
+
+ Improve wording about what goes before AC_INIT.
+ * doc/autoconf.texi (Initializing configure): Update wording.
+ (Versioning) AC_PREREQ: Remove misleading text, to match
+ autoupdate's behavior.
+ * THANKS: Update.
+ Reported by NightStrike, with input from Ralf Wildenhues.
+
2009-09-04 Thomas Jahns ja...@dkrz.de (tiny change)
Fix illegal tab character in Fortran source.
diff --git a/doc/autoconf.texi b/doc/autoconf.texi
index e997962..1d1abfb 100644
--- a/doc/autoconf.texi
+++ b/doc/autoconf.texi
@@ -1754,8 +1754,11 @@ Initializing configure
@section Initializing @command{configure}
Every @command{configure} script must call @code{AC_INIT} before doing
-anything else. The only other required macro is @code{AC_OUTPUT}
-(@pxref{Output}).
+anything else that produces output. Calls to silent macros, such as
+...@code{ac_defun}, may also occur prior to @code{AC_INIT}, although these
+are generally used via @file{aclocal.m4}, since that is implicitly
+included before the start of @file{configure.ac}. The only other
+required macro is @code{AC_OUTPUT} (@pxref{Output}).
@anchor{AC_INIT}
@defmac AC_INIT (@var{package}, @var{version}, @ovar{bug-report}, @
@@ -1854,8 +1857,7 @@ Versioning
AC_PREREQ([...@value{version}])
@end example
-This macro is the only macro that may be used before @code{AC_INIT}, but
-for consistency, you are invited not to do so.
+This macro may be used before @code{AC_INIT}.
@end defmac
@defmac AC_AUTOCONF_VERSION
--
1.6.3.3.334.g916e1
___
Autoconf mailing list
Autoconf@gnu.org
http://lists.gnu.org/mailman/listinfo/autoconf
Re: compile wrapper script with C++ file
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 [adding bug-automake] According to David Byron on 8/14/2009 1:57 PM: Hi David, Thanks for the report, and sorry for the delayed reply... I'm not sure whether this is something I'm doing wrong or something wrong with automake, autoconf or libtool. At the moment I'm leaning to autoconf + automake. compile is maintained by automake, so I've redirected your patch there. FWIW, it looks okay to me, but Ralf will have to chime in. I get a step closer but I needed to modify the compile script as well (see below). With both of these changes, everything (C and C++) compile fine and the objects go where they're supposed to. Is the kind of thing that could make its way upstream (maybe even for .cpp file support as well)? I'm not sure how to modify autoconf/configure to do what I did manually...or even if's the right thing. $ diff -u compile compile.dbyron --- compile Fri Aug 14 12:37:10 2009 +++ compile.dbyron Fri Aug 14 12:38:02 2009 @@ -1,7 +1,7 @@ #! /bin/sh # Wrapper for compilers which do not understand `-c -o'. -scriptversion=2009-04-28.21; # UTC +scriptversion=2009-08-14.19; # UTC # Copyright (C) 1999, 2000, 2003, 2004, 2005, 2009 Free Software # Foundation, Inc. @@ -79,7 +79,7 @@ ;; esac ;; - *.c) + *.c|*.cc) cfile=$1 set x $@ $1 shift @@ -103,7 +103,7 @@ fi # Name of file we expect compiler to create. -cofile=`echo $cfile | sed 's|^.*[\\/]||; s|^[a-zA-Z]:||; s/\.c$/.o/'` +cofile=`echo $cfile | sed 's|^.*[\\/]||; s|^[a-zA-Z]:||; s/\.c$/.o/; s/\.cc$/.o/'` # Create the lock directory. # Note: use `[/\\:.-]' here to ensure that we don't use the same name - -- Don't work too hard, make some time for fun as well! Eric Blake e...@byu.net -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkqhB8wACgkQ84KuGfSFAYDGJgCfQniR5c/EBpgy6K7mT1b1mJT6 gpAAn314VNfFj1h2Kl4yAElGM+c8ItkM =4GSc -END PGP SIGNATURE- ___ Autoconf mailing list Autoconf@gnu.org http://lists.gnu.org/mailman/listinfo/autoconf
Re: AC_PREREQ comes first in autoscan
On Fri, Sep 4, 2009 at 8:22 AM, Eric Blakee...@byu.net wrote: Yes, indeed. Pushing this (NightStrike, let me know if you'd rather have a real name instead of a pseudonym in THANKS): I prefer anonymity :) ___ Autoconf mailing list Autoconf@gnu.org http://lists.gnu.org/mailman/listinfo/autoconf
Re: AC_PREREQ comes first in autoscan
Hi Eric, * Eric Blake wrote on Fri, Sep 04, 2009 at 02:22:54PM CEST: + Improve wording about what goes before AC_INIT. + * doc/autoconf.texi (Initializing configure): Update wording. + (Versioning) AC_PREREQ: Remove misleading text, to match + autoupdate's behavior. Thanks, and sorry for pushing back all my pending autotools stuff. s/autoupdate/autoscan/ btw. Cheers, Ralf ___ Autoconf mailing list Autoconf@gnu.org http://lists.gnu.org/mailman/listinfo/autoconf
Re: another doc update about Solaris 'tr'
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 8/30/2009 5:21 PM: Hi, Just noticed that the problem with tr '\0' '~' is not really with the '\0' argument, but with the NUL bytes in the input. This version of 'tr' discards NUL bytes in the input even when not asked to do so. It occurs with tr x x but also with tr -d '\r'. Here is a suggested doc update. Also, a mention that using /usr/xpg6/bin/tr might be preferable to /usr/xpg4/bin/tr, when it exists. It supports the '-C' option, the latter doesn't. Thanks again. Patch applied. - -- Don't work too hard, make some time for fun as well! Eric Blake e...@byu.net -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkqhCioACgkQ84KuGfSFAYADLQCcCSvHTZOO3YrKkowfJgit6E+O oZcAn1JDWHwX913+NGUsFO3s75hzwaOi =VCmh -END PGP SIGNATURE-
Re: Renaming old macros
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Reuben Thomas on 8/11/2009 6:31 PM: Hello, and sorry for the delay, Further to my question about AU_ALIAS, we noticed at autoconf-archive that by defining AC_DEFUN/AU_ALIAS in the new macro file we can't get aclocal --diff to notice that something has changed. What should we do to somehow signal the new name to users of the old macro? aclocal is managed by automake; redirecting your question there. My first thought is whether you also bumped the #serial number in your .m4 file? - -- Don't work too hard, make some time for fun as well! Eric Blake e...@byu.net -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkqhDaQACgkQ84KuGfSFAYCFygCdHjeQH20z5eMyJnL1EoR7WiW8 AHcAoMrMhhmzDCPBiAWfQbVSqjoqdz3z =OGYj -END PGP SIGNATURE-
Re: Mention Autoconf archive in autoconf manual
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Reuben Thomas on 8/11/2009 5:47 PM: Attached, a patch against git HEAD to add an appropriate mention of Autoconf archive to the Autoconf manual. Thanks; applied after adding a ChangeLog entry, and fixing a texinfo error (sorry for the delay in reviewing). - -- Don't work too hard, make some time for fun as well! Eric Blake e...@byu.net -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkqhEXsACgkQ84KuGfSFAYChOACfa3D4wv+Bl3ydK/O+yjCYpvit nVwAmgPL6UOBaRuSBULD20YrrXo06wyg =Fp7L -END PGP SIGNATURE-
