Re: bbdb-mode-map should inherit from special-mode-map
Ted Zlatanov writes: On Thu, 14 Apr 2011 21:34:15 +0200 David Engster d...@randomsample.de wrote: DE XEmacs is another matter, though. I attached the current logs for XEmacs DE 21.4 and 21.5. Note that your 'PUSHPATH' eval doesn't work for XEmacs; DE just use -L .. DE I can set up a buildbot, but this only makes sense if all of the builds DE are working initially. So I'm afraid someone would have to volunteer to DE fix the XEmacs stuff first. :-) Can you set it up just for GNU Emacs? We'll add XEmacs when that's ready but for now I'd like to get any regular builds going. A buildbot for BBDB is now running at http://randomsample.de/bbdb-buildbot In the compile log for emacs24 you'll find two warnings which should probably be fixed. I'd then recommend to introduce a new Makefile rule like 'fail-on-warn' which should byte-compile with byte-compile-error-on-warn set to 't'. Mails are send on failed builds to Roland and Ted. -David -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev ___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
Re: [BBDB] ChangLog 2011-04-16
Roland Winkler writes: I extended (and fixed) this patch to inherit from special-mode. Now bbdb-mode is also derived from special-mode. Note that Emacs v22 doesn't have special-mode, so this change will make it break on that version (or earlier, of course). -David -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev ___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
'save-excursion defeated by set-buffer' warning
In the latest Emacs 32.2 pretest, a require of bbdb-gnus leads to a buffer popping up saying save-excursion defeated by set-buffer. This is due to a defadvice in bbdb-com.el, using the (save-excursion (set-buffer ... construct, which now emits the above warning. This can be fixed by applying the attached patch. (BTW: I guess one could get rid of this defadvice-hack by using `choose-completion-string-functions', which I think was introduced in Emacs 22.) Regards, David Index: bbdb-com.el === RCS file: /cvsroot/bbdb/bbdb/lisp/bbdb-com.el,v retrieving revision 1.203 diff -u -r1.203 bbdb-com.el --- bbdb-com.el 16 Mar 2008 23:05:22 - 1.203 +++ bbdb-com.el 23 Feb 2010 14:21:21 - @@ -2272,9 +2272,8 @@ We need to do this as we are abusing completion and it was not meant to work in buffer other than the mini buffer. (when bbdb-complete-name-callback-data -(save-excursion - (set-buffer (car bbdb-complete-name-callback-data)) - (apply 'delete-region (cdr bbdb-complete-name-callback-data) +(with-current-buffer (car bbdb-complete-name-callback-data)) + (apply 'delete-region (cdr bbdb-complete-name-callback-data (defcustom bbdb-complete-name-allow-cycling t Whether to allow cycling of email addresses when calling -- Download Intel#174; Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
