Re: Review Request: Two test cases from snapshots imporevement feature
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9752/ --- (Updated March 20, 2013, 1:33 p.m.) Review request for cloudstack and Prasanna Santhanam. Changes --- Incorporated all the review comments. Description --- Added two test cases for snapshots improvement feature. Diffs (updated) - test/integration/component/test_snapshots_improvements.py PRE-CREATION Diff: https://reviews.apache.org/r/9752/diff/ Testing --- Executed the tests in advanced zone setup. Thanks, sanjeev n
Re: Review Request: Two test cases from snapshots imporevement feature
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9752/ --- (Updated March 19, 2013, 12:45 p.m.) Review request for cloudstack and Prasanna Santhanam. Changes --- Fixed the patch as per the review comments. Description --- Added two test cases for snapshots improvement feature. Diffs (updated) - test/integration/component/test_snapshots_improvements.py PRE-CREATION Diff: https://reviews.apache.org/r/9752/diff/ Testing --- Executed the tests in advanced zone setup. Thanks, sanjeev n
Re: Review Request: Two test cases from snapshots imporevement feature
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9752/#review18073 --- test/integration/component/test_snapshots_improvements.py https://reviews.apache.org/r/9752/#comment38161 Make sure you aren't leaving any unused service dictionaries. test/integration/component/test_snapshots_improvements.py https://reviews.apache.org/r/9752/#comment38160 The url appears to be local. Also - the windows template test will not be checked by cloudstack. So this can be any vhd. Use the default builtin CentOS vhd for this test? test/integration/component/test_snapshots_improvements.py https://reviews.apache.org/r/9752/#comment38162 can you fix the trailing spaces in this patch? git apply --whitespace=fix your.patch should take care of this. test/integration/component/test_snapshots_improvements.py https://reviews.apache.org/r/9752/#comment38164 Can you put a FIXME: JIRA issue CLOUDSTACK-601? test/integration/component/test_snapshots_improvements.py https://reviews.apache.org/r/9752/#comment38165 The test runner code (__main__) can be gotten rid of. It's not required when the test runs on test infra. - Prasanna Santhanam On March 19, 2013, 12:45 p.m., sanjeev n wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9752/ --- (Updated March 19, 2013, 12:45 p.m.) Review request for cloudstack and Prasanna Santhanam. Description --- Added two test cases for snapshots improvement feature. Diffs - test/integration/component/test_snapshots_improvements.py PRE-CREATION Diff: https://reviews.apache.org/r/9752/diff/ Testing --- Executed the tests in advanced zone setup. Thanks, sanjeev n
RE: Review Request: Two test cases from snapshots imporevement feature
Thanks for the comments David. I will add the ASF license header and test_concurrent_snapshot.py is not the intended one. I will remove it. Thanks, Sanjeev From: David Nalley [mailto:nore...@reviews.apache.org] On Behalf Of David Nalley Sent: Tuesday, March 05, 2013 10:49 PM To: Prasanna Santhanam Cc: cloudstack; Sanjeev Neelarapu; David Nalley Subject: Re: Review Request: Two test cases from snapshots imporevement feature This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9752/ First - thanks for working on tests!! It's something we need lots of. Both of these files are missing the ASF license header, please add that in. test/integration/component/test_concurrent_snapshot.pyhttps://reviews.apache.org/r/9752/diff/1/?file=266195#file266195line1 (Diff revision 1) None 1 test This doesn't look like valid python to me. Are you sure this is the intended content? - David On March 5th, 2013, 5:15 p.m., sanjeev n wrote: Review request for cloudstack and Prasanna Santhanam. By sanjeev n. Updated March 5, 2013, 5:15 p.m. Description Added two test cases for snapshots improvement feature. Testing Executed the tests in advanced zone setup. Diffs * test/integration/component/test_concurrent_snapshot.py (PRE-CREATION) * test/integration/component/test_snapshots_improvements.py (PRE-CREATION) View Diffhttps://reviews.apache.org/r/9752/diff/
Re: Review Request: Two test cases from snapshots imporevement feature
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9752/#review17407 --- First - thanks for working on tests!! It's something we need lots of. Both of these files are missing the ASF license header, please add that in. test/integration/component/test_concurrent_snapshot.py https://reviews.apache.org/r/9752/#comment36930 This doesn't look like valid python to me. Are you sure this is the intended content? - David Nalley On March 5, 2013, 5:15 p.m., sanjeev n wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9752/ --- (Updated March 5, 2013, 5:15 p.m.) Review request for cloudstack and Prasanna Santhanam. Description --- Added two test cases for snapshots improvement feature. Diffs - test/integration/component/test_concurrent_snapshot.py PRE-CREATION test/integration/component/test_snapshots_improvements.py PRE-CREATION Diff: https://reviews.apache.org/r/9752/diff/ Testing --- Executed the tests in advanced zone setup. Thanks, sanjeev n
