[Cmake-commits] CMake branch, master, updated. v3.5.0-275-g1449b11
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "CMake". The branch, master has been updated via 1449b11e198f512066d9aca9dd8889ddc1556a97 (commit) from cd992170db7a85f00d4ad38f78f0b38c33f83d1f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1449b11e198f512066d9aca9dd8889ddc1556a97 commit 1449b11e198f512066d9aca9dd8889ddc1556a97 Author: Kitware Robot <kwro...@kitware.com> AuthorDate: Tue Mar 22 00:01:06 2016 -0400 Commit: Kitware Robot <kwro...@kitware.com> CommitDate: Tue Mar 22 00:01:06 2016 -0400 CMake Nightly Date Stamp diff --git a/Source/CMakeVersion.cmake b/Source/CMakeVersion.cmake index 11dff2b..f61e30e 100644 --- a/Source/CMakeVersion.cmake +++ b/Source/CMakeVersion.cmake @@ -1,5 +1,5 @@ # CMake version number components. set(CMake_VERSION_MAJOR 3) set(CMake_VERSION_MINOR 5) -set(CMake_VERSION_PATCH 20160321) +set(CMake_VERSION_PATCH 20160322) #set(CMake_VERSION_RC 1) --- Summary of changes: Source/CMakeVersion.cmake |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/mailman/listinfo/cmake-commits
[cmake-developers] [CMake 0016027]: nvcc encloses -ccbin argument with gratuitous quotation marks during intermediate-link phase
The following issue has been SUBMITTED. == https://public.kitware.com/Bug/view.php?id=16027 == Reported By:Eyal Rozenberg Assigned To: == Project:CMake Issue ID: 16027 Category: Modules Reproducibility:sometimes Severity: minor Priority: normal Status: new == Date Submitted: 2016-03-21 17:06 EDT Last Modified: 2016-03-21 17:06 EDT == Summary:nvcc encloses -ccbin argument with gratuitous quotation marks during intermediate-link phase Description: I've been using CMake on Debian Stretch with CUDA. I'm not sure what the version was until recently, but everything worked fine for me. Then I started getting errors such as: "/usr/local/cuda/bin/gcc": No such file or directory CMakeFiles/tester.dir/build.make:2335: recipe for target 'CMakeFiles/wherever/foo.o' failed The culprit seems to be /usr/share/cmake/Modules/FindCUDA.cmake, line 1554. Pseudo-patch: - list(APPEND nvcc_flags -ccbin "\"${CUDA_HOST_COMPILER}\"") + list(APPEND nvcc_flags -ccbin "${CUDA_HOST_COMPILER}") that resolves the issue. Steps to Reproduce: 1. export CC=/link/to/your/appropriate/gcc 2. cmake a project with CMakeList.txt which finds CUDA and with set(CUDA_SEPARABLE_COMPILATION ON) 3. Build the project The .cu files will compile, the intermediate-link phase won't pass == Issue History Date ModifiedUsername FieldChange == 2016-03-21 17:06 Eyal Rozenberg New Issue == -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Startup Project Configuration [mantis 15578]
On Fri, Mar 18, 2016 at 1:31 PM, Brad Kingwrote: > > Please check that the revised version works for you. I did some more thorough testing and ran into an issue when USE_FOLDERS is enabled. The problem is actually the same one affecting the ALL_BUILD target that is preventing it from being grouped with the PREDEFINED_TARGETS_FOLDER as it should be. It's not actually the first target in a .sln file that is treated as the default startup project, but rather the first _fully defined target_. See this SO comment thread: http://stackoverflow.com/questions/694730/why-is-set-as-startup-option-stored-in-the-suo-file-and-not-the-sln-file#comment40597475_1808352 The solution is to just list all folders in the .sln file first (patch 0002). With the fix in patch 0002, ALL_BUILD can then be put in PREDEFINED_TARGETS_FOLDER (patch 0003). Taylor From 2e4adaba69cd61143c468dc50b9bc82a06d5e484 Mon Sep 17 00:00:00 2001 From: Taylor Braun-Jones Date: Mon, 21 Mar 2016 14:34:34 -0400 Subject: [PATCH 1/3] fixup! VS: Add option to choose the `.sln` startup project (#15578) Change `getFirstProject` macro to more flexible version `getProjectNames` --- Tests/RunCMake/VSSolution/StartupProject-check.cmake | 3 ++- .../RunCMake/VSSolution/StartupProjectMissing-check.cmake | 3 ++- Tests/RunCMake/VSSolution/solution_parsing.cmake | 15 --- 3 files changed, 12 insertions(+), 9 deletions(-) diff --git a/Tests/RunCMake/VSSolution/StartupProject-check.cmake b/Tests/RunCMake/VSSolution/StartupProject-check.cmake index fd7cc28..8890334 100644 --- a/Tests/RunCMake/VSSolution/StartupProject-check.cmake +++ b/Tests/RunCMake/VSSolution/StartupProject-check.cmake @@ -1,4 +1,5 @@ -getFirstProject(first_project StartupProject) +getProjectNames(projects) +list(GET projects 0 first_project) if(NOT first_project STREQUAL "ZERO_CHECK") error("ZERO_CHECK is not the startup project") endif() diff --git a/Tests/RunCMake/VSSolution/StartupProjectMissing-check.cmake b/Tests/RunCMake/VSSolution/StartupProjectMissing-check.cmake index 95fede7..b1017dd 100644 --- a/Tests/RunCMake/VSSolution/StartupProjectMissing-check.cmake +++ b/Tests/RunCMake/VSSolution/StartupProjectMissing-check.cmake @@ -1,4 +1,5 @@ -getFirstProject(first_project StartupProjectMissing) +getProjectNames(projects) +list(GET projects 0 first_project) if(NOT first_project STREQUAL "ALL_BUILD") error("ALL_BUILD is not the startup project") endif() diff --git a/Tests/RunCMake/VSSolution/solution_parsing.cmake b/Tests/RunCMake/VSSolution/solution_parsing.cmake index 001b584..4e5bb59 100644 --- a/Tests/RunCMake/VSSolution/solution_parsing.cmake +++ b/Tests/RunCMake/VSSolution/solution_parsing.cmake @@ -50,17 +50,18 @@ macro(parseGlobalSections arg_out_pre arg_out_post testName) endmacro() -macro(getFirstProject arg_out_first_project testName) - set(${arg_out_first_project} "") - set(sln "${RunCMake_TEST_BINARY_DIR}/${testName}.sln") +macro(getProjectNames arg_out_projects) + set(${arg_out_projects} "") + set(sln "${RunCMake_TEST_BINARY_DIR}/${test}.sln") if(NOT EXISTS "${sln}") error("Expected solution file ${sln} does not exist") endif() file(STRINGS "${sln}" project_lines REGEX "^Project\\(") - list(GET project_lines 0 first_project) - string(REGEX REPLACE ".* = \"" "" first_project "${first_project}") - string(REGEX REPLACE "\", .*" "" first_project "${first_project}") - set(${arg_out_first_project} "${first_project}") + foreach(project_line IN LISTS project_lines) +string(REGEX REPLACE ".* = \"" "" project_line "${project_line}") +string(REGEX REPLACE "\", .*" "" project_line "${project_line}") +list(APPEND ${arg_out_projects} "${project_line}") + endforeach() endmacro() -- 2.7.2.windows.1 From 898826c3dfb86078c6b42578d4bb5ae991552ecc Mon Sep 17 00:00:00 2001 From: Taylor Braun-Jones Date: Mon, 21 Mar 2016 16:01:20 -0400 Subject: [PATCH 2/3] VS: Fix default target support for targets nested inside a folder --- Source/cmGlobalVisualStudio71Generator.cxx | 5 - Tests/RunCMake/VSSolution/RunCMakeTest.cmake | 1 + Tests/RunCMake/VSSolution/StartupProjectUseFolders-check.cmake | 9 + Tests/RunCMake/VSSolution/StartupProjectUseFolders.cmake | 2 ++ 4 files changed, 16 insertions(+), 1 deletion(-) create mode 100644 Tests/RunCMake/VSSolution/StartupProjectUseFolders-check.cmake create mode 100644 Tests/RunCMake/VSSolution/StartupProjectUseFolders.cmake diff --git a/Source/cmGlobalVisualStudio71Generator.cxx b/Source/cmGlobalVisualStudio71Generator.cxx index f6796a5..289fbb5 100644 --- a/Source/cmGlobalVisualStudio71Generator.cxx +++ b/Source/cmGlobalVisualStudio71Generator.cxx @@ -97,7 +97,8 @@ void cmGlobalVisualStudio71Generator OrderedTargetDependSet orderedProjectTargets( projectTargets, this->GetStartupProjectName(root)); -
[cmake-developers] FW: 15975 Bug Fix GHS MULTI try compile
Thank you. The patch seems to solve the problem (15975) for me. I saw the patch was committed on the "next" branch. How does the further procedure look like until it becomes part of an official CMake release and how long does that take usually? Regards, Stefan -Original Message- From: cmake-developers [mailto:cmake-developers-boun...@cmake.org] On Behalf Of Brad King Sent: Montag, 21. März 2016 15:40 To: Geoffrey Viola; cmake-developers@cmake.org Subject: Re: [cmake-developers] 15975 Bug Fix GHS MULTI try compile On 03/21/2016 07:28 AM, Geoffrey Viola wrote: > Attached are updates for the bug recorded at > https://cmake.org/Bug/view.php?id=15975. Thanks, applied: GHS: Fix try_compile https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=bf3e76d2 -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
[Cmake-commits] CMake branch, next, updated. v3.5.0-569-g94df6f7
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "CMake". The branch, next has been updated via 94df6f753ecbf286f8798eecb2f1f3c25f8893fc (commit) via bf3e76d2146485e541ebeed891a8905946b96c9e (commit) from 92ad43890f73dd5afb98b6ca24f0c6f71d943abb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=94df6f753ecbf286f8798eecb2f1f3c25f8893fc commit 94df6f753ecbf286f8798eecb2f1f3c25f8893fc Merge: 92ad438 bf3e76d Author: Brad KingAuthorDate: Mon Mar 21 10:37:52 2016 -0400 Commit: CMake Topic Stage CommitDate: Mon Mar 21 10:37:52 2016 -0400 Merge topic 'ghs-try_compile' into next bf3e76d2 GHS: Fix try_compile (#15975) https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=bf3e76d2146485e541ebeed891a8905946b96c9e commit bf3e76d2146485e541ebeed891a8905946b96c9e Author: Geoff Viola AuthorDate: Mon Mar 21 05:00:35 2016 -0600 Commit: Brad King CommitDate: Mon Mar 21 10:35:01 2016 -0400 GHS: Fix try_compile (#15975) diff --git a/Modules/Compiler/GHS-C.cmake b/Modules/Compiler/GHS-C.cmake index e97d62c..a58d9b0 100644 --- a/Modules/Compiler/GHS-C.cmake +++ b/Modules/Compiler/GHS-C.cmake @@ -12,6 +12,8 @@ set(CMAKE_C_GHS_KERNEL_FLAGS_RELEASE_INIT "${CMAKE_C_FLAGS_RELEASE_INIT}") set(CMAKE_C_GHS_KERNEL_FLAGS_RELWITHDEBINFO_INIT "-ldebug ${CMAKE_C_FLAGS_RELWITHDEBINFO_INIT}") +set(CMAKE_EXECUTABLE_SUFFIX ".as") + if(NOT CMAKE_NOT_USING_CONFIG_FLAGS) set (CMAKE_C_GHS_KERNEL_FLAGS_DEBUG "${CMAKE_C_GHS_KERNEL_FLAGS_DEBUG_INIT}" CACHE STRING "Kernel flags used by the compiler during debug builds.") diff --git a/Modules/Compiler/GHS-CXX.cmake b/Modules/Compiler/GHS-CXX.cmake index 71a0dec..9e202d3 100644 --- a/Modules/Compiler/GHS-CXX.cmake +++ b/Modules/Compiler/GHS-CXX.cmake @@ -15,6 +15,8 @@ set(CMAKE_CXX_GHS_KERNEL_FLAGS_RELEASE_INIT set(CMAKE_CXX_GHS_KERNEL_FLAGS_RELWITHDEBINFO_INIT "-ldebug ${CMAKE_CXX_FLAGS_RELWITHDEBINFO_INIT}") +set(CMAKE_EXECUTABLE_SUFFIX ".as") + if(NOT CMAKE_NOT_USING_CONFIG_FLAGS) set (CMAKE_CXX_GHS_KERNEL_FLAGS_DEBUG "${CMAKE_CXX_GHS_KERNEL_FLAGS_DEBUG_INIT}" diff --git a/Source/cmGhsMultiTargetGenerator.cxx b/Source/cmGhsMultiTargetGenerator.cxx index 18e140e..c5813ba 100644 --- a/Source/cmGhsMultiTargetGenerator.cxx +++ b/Source/cmGhsMultiTargetGenerator.cxx @@ -217,8 +217,11 @@ void cmGhsMultiTargetGenerator::WriteTypeSpecifics(const std::string , if (this->GeneratorTarget->GetType() == cmState::STATIC_LIBRARY) { +std::string const static_library_suffix = + this->Makefile->GetSafeDefinition("CMAKE_STATIC_LIBRARY_SUFFIX"); *this->GetFolderBuildStreams() << "-o \"" - << outputDir << outputFilename << ".a\"" + << outputDir << outputFilename + << static_library_suffix << "\"" << std::endl; } else if (this->GeneratorTarget->GetType() == cmState::EXECUTABLE) @@ -238,8 +241,11 @@ void cmGhsMultiTargetGenerator::WriteTypeSpecifics(const std::string , } else { + std::string const executable_suffix = +this->Makefile->GetSafeDefinition("CMAKE_EXECUTABLE_SUFFIX"); *this->GetFolderBuildStreams() << "-o \"" - << outputDir << outputFilename << ".as\"" + << outputDir << outputFilename + << executable_suffix << "\"" << std::endl; } } --- Summary of changes: Modules/Compiler/GHS-C.cmake |2 ++ Modules/Compiler/GHS-CXX.cmake |2 ++ Source/cmGhsMultiTargetGenerator.cxx | 10 -- 3 files changed, 12 insertions(+), 2 deletions(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/mailman/listinfo/cmake-commits
[Cmake-commits] CMake branch, next, updated. v3.5.0-571-g235feb1
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "CMake". The branch, next has been updated via 235feb1ece8d676a8597429c8461036ddf8f6732 (commit) via 53c0dc2dd2216b7927787e6d819a9a734be2c0eb (commit) from 94df6f753ecbf286f8798eecb2f1f3c25f8893fc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=235feb1ece8d676a8597429c8461036ddf8f6732 commit 235feb1ece8d676a8597429c8461036ddf8f6732 Merge: 94df6f7 53c0dc2 Author: Brad KingAuthorDate: Mon Mar 21 10:52:14 2016 -0400 Commit: CMake Topic Stage CommitDate: Mon Mar 21 10:52:14 2016 -0400 Merge topic 'add-bruce-c' into next 53c0dc2d Add support for Bruce C Compiler (BCC) https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=53c0dc2dd2216b7927787e6d819a9a734be2c0eb commit 53c0dc2dd2216b7927787e6d819a9a734be2c0eb Author: Paweł Stankowski AuthorDate: Sun Mar 20 10:42:19 2016 +0100 Commit: Brad King CommitDate: Mon Mar 21 10:51:50 2016 -0400 Add support for Bruce C Compiler (BCC) Revise C compiler detection code to be K compatible. diff --git a/Help/release/dev/add-bruce-c.rst b/Help/release/dev/add-bruce-c.rst new file mode 100644 index 000..9e47900 --- /dev/null +++ b/Help/release/dev/add-bruce-c.rst @@ -0,0 +1,4 @@ +add-bruce-c +--- + +* Support was added for the Bruce C Compiler with compiler id ``Bruce``. diff --git a/Help/variable/CMAKE_LANG_COMPILER_ID.rst b/Help/variable/CMAKE_LANG_COMPILER_ID.rst index 81976a9..ebd616e 100644 --- a/Help/variable/CMAKE_LANG_COMPILER_ID.rst +++ b/Help/variable/CMAKE_LANG_COMPILER_ID.rst @@ -12,6 +12,7 @@ include: ADSP = Analog VisualDSP++ (analog.com) AppleClang = Apple Clang (apple.com) ARMCC = ARM Compiler (arm.com) + Bruce = Bruce C Compiler CCur = Concurrent Fortran (ccur.com) Clang = LLVM Clang (clang.llvm.org) Cray = Cray Compiler (cray.com) diff --git a/Modules/CMakeCCompilerId.c.in b/Modules/CMakeCCompilerId.c.in index 5bfe0fd..c107dfd 100644 --- a/Modules/CMakeCCompilerId.c.in +++ b/Modules/CMakeCCompilerId.c.in @@ -5,6 +5,11 @@ #if defined(__18CXX) # define ID_VOID_MAIN #endif +#if defined(__CLASSIC_C__) +/* cv-qualifiers did not exist in K C */ +# define const +# define volatile +#endif @CMAKE_C_COMPILER_ID_CONTENT@ @@ -28,23 +33,28 @@ char const *info_cray = "INFO" ":" "compiler_wrapper[CrayPrgEnv]"; @CMAKE_C_COMPILER_ID_PLATFORM_CONTENT@ @CMAKE_C_COMPILER_ID_ERROR_FOR_TEST@ -const char* info_language_dialect_default = "INFO" ":" "dialect_default[" -#if !defined(__STDC_VERSION__) - "90" +#if !defined(__STDC__) +# define C_DIALECT #elif __STDC_VERSION__ >= 201000L - "11" +# define C_DIALECT "11" #elif __STDC_VERSION__ >= 199901L - "99" +# define C_DIALECT "99" #else +# define C_DIALECT "90" #endif -"]"; +const char* info_language_dialect_default = + "INFO" ":" "dialect_default[" C_DIALECT "]"; /*--*/ #ifdef ID_VOID_MAIN void main() {} #else +# if defined(__CLASSIC_C__) +int main(argc, argv) int argc; char *argv[]; +# else int main(int argc, char* argv[]) +# endif { int require = 0; require += info_compiler[argc]; diff --git a/Modules/CMakeCompilerIdDetection.cmake b/Modules/CMakeCompilerIdDetection.cmake index cbc0055..1d341e5 100644 --- a/Modules/CMakeCompilerIdDetection.cmake +++ b/Modules/CMakeCompilerIdDetection.cmake @@ -79,6 +79,7 @@ function(compiler_id_detection outvar lang) if (lang STREQUAL C) list(APPEND ordered_compilers TinyCC +Bruce ) endif() list(APPEND ordered_compilers diff --git a/Modules/CMakeDetermineCCompiler.cmake b/Modules/CMakeDetermineCCompiler.cmake index e0b5468..f8c6303 100644 --- a/Modules/CMakeDetermineCCompiler.cmake +++ b/Modules/CMakeDetermineCCompiler.cmake @@ -87,6 +87,9 @@ else() # Try enabling ANSI mode on HP. "-Aa" + +# Try compiling K code (needed by Bruce C Compiler). +"-D__CLASSIC_C__" ) endif() diff --git a/Modules/CMakePlatformId.h.in b/Modules/CMakePlatformId.h.in index da99b9e..47eb00a 100644 --- a/Modules/CMakePlatformId.h.in +++ b/Modules/CMakePlatformId.h.in @@ -91,11 +91,11 @@ # define PLATFORM_ID "Windows3x" # else /* unknown platform */ -# define PLATFORM_ID "" +# define PLATFORM_ID # endif #else /* unknown platform */ -# define PLATFORM_ID "" +# define PLATFORM_ID #endif @@ -145,7 +145,7 @@ # endif #else -# define ARCHITECTURE_ID "" +# define ARCHITECTURE_ID #endif /* Convert integer to decimal digit literals. */ diff --git
[Cmake-commits] CMake branch, next, updated. v3.5.0-573-gdbc0b84
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "CMake". The branch, next has been updated via dbc0b846dd3c882dbc3472e7b3bf2123fd1b7def (commit) via 8e2aa6caef17aa775e298f799dd4014a8ce46d1d (commit) from 235feb1ece8d676a8597429c8461036ddf8f6732 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=dbc0b846dd3c882dbc3472e7b3bf2123fd1b7def commit dbc0b846dd3c882dbc3472e7b3bf2123fd1b7def Merge: 235feb1 8e2aa6c Author: Brad KingAuthorDate: Mon Mar 21 10:55:04 2016 -0400 Commit: CMake Topic Stage CommitDate: Mon Mar 21 10:55:04 2016 -0400 Merge topic 'TestBigEndian-log-output' into next 8e2aa6ca TestBigEndian: Log success to CMakeOutput.log, not CMakeError.log https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=8e2aa6caef17aa775e298f799dd4014a8ce46d1d commit 8e2aa6caef17aa775e298f799dd4014a8ce46d1d Author: Paweł Stankowski AuthorDate: Mon Mar 21 01:38:38 2016 +0100 Commit: Brad King CommitDate: Mon Mar 21 10:54:02 2016 -0400 TestBigEndian: Log success to CMakeOutput.log, not CMakeError.log diff --git a/Modules/TestBigEndian.cmake b/Modules/TestBigEndian.cmake index fcb41ab..fdc3adb 100644 --- a/Modules/TestBigEndian.cmake +++ b/Modules/TestBigEndian.cmake @@ -104,7 +104,7 @@ macro(TEST_BIG_ENDIAN VARIABLE) message(SEND_ERROR "TEST_BIG_ENDIAN found no result!") endif() -file(APPEND ${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeError.log +file(APPEND ${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeOutput.log "Determining if the system is big endian passed with the following output:\n${OUTPUT}\nTestEndianess.c:\n${TEST_ENDIANESS_FILE_CONTENT}\n\n") else() --- Summary of changes: Modules/TestBigEndian.cmake |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/mailman/listinfo/cmake-commits
Re: [cmake-developers] 15975 Bug Fix GHS MULTI try compile
On 03/21/2016 07:28 AM, Geoffrey Viola wrote: > Attached are updates for the bug recorded at > https://cmake.org/Bug/view.php?id=15975. Thanks, applied: GHS: Fix try_compile https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=bf3e76d2 -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Contribution for Issue #0015146
On 03/19/2016 06:56 AM, Sebastian Windisch wrote: > I like to contribute code for issue #0015146. Thanks! > What I did: I introduced a new flag in cmIDEFlagTable.h called > RegularExpression Good idea. That should be able to handle the special parsing mentioned in my comment in that issue: https://cmake.org/Bug/view.php?id=15146#c36772 > {"UACUIAccess", "MANIFESTUAC:level=([a-zA-Z]+) uiAccess=([a-zA-Z]+)$", > "", "\\2", cmVS7FlagTable::RegularExpression}, This does not look sufficient to match the example given in the issue description: -MANIFESTUAC:"level='requireAdministrator' uiAccess='false'" IIUC the single quotes are optional as they appear to work when passed directly on a command line build. Also I suspect more whitespace needs to be tolerated. There are some existing UACExecutionLevel entries in the link flag tables that were produced by the automated tool we use to generate the flag tables from MSBuild files originally. Please check that they can be removed in favor of your new entries. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] more use of cmXMLWriter
On 03/19/2016 05:08 PM, Daniel Pfeifer wrote: > I ported some more generators to cmXMLWriter. Thanks. I've applied and merged to 'next' for testing: cmXMLWriter: overload Element() method for empty elements https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=dd27e313 cmXMLWriter: add Doctype() method https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=d7407621 cmExtraCodeBlocksGenerator: port to cmXMLWriter https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=27e09764 cmExtraCodeLiteGenerator: port to cmXMLWriter https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=dcdc270e cmGlobalKdevelopGenerator: port to cmXMLWriter https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=dfd8b4d3 cmExtraEclipseCDT4Generator: port to cmXMLWriter https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=9908f705 CPack/IFW: port to cmXMLWriter https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e8356001 -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
[Cmake-commits] CMake branch, next, updated. v3.5.0-567-g92ad438
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "CMake". The branch, next has been updated via 92ad43890f73dd5afb98b6ca24f0c6f71d943abb (commit) via e835600163c926db3bc5a127eaa17937984f5ab2 (commit) via 9908f7055180fc2dd458401582b5852fd177a9f9 (commit) via dfd8b4d3a9c77aa6604e559eefb00fc8f3519dc1 (commit) via dcdc270eeb48ad5eb017aca5c3e16188a0b7d808 (commit) via 27e097645350fc07dadc79a8944b47a97e5ecdc3 (commit) via d740762181976834df32bc9baaf273e5278313b0 (commit) via dd27e31351be89bc0c28183fc347d6082bca1e36 (commit) from 5b9c6c10af412507acce3651d02da93b670767bd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=92ad43890f73dd5afb98b6ca24f0c6f71d943abb commit 92ad43890f73dd5afb98b6ca24f0c6f71d943abb Merge: 5b9c6c1 e835600 Author: Brad KingAuthorDate: Mon Mar 21 10:33:29 2016 -0400 Commit: CMake Topic Stage CommitDate: Mon Mar 21 10:33:29 2016 -0400 Merge topic 'use-cmXMLWriter' into next e8356001 CPack/IFW: port to cmXMLWriter 9908f705 cmExtraEclipseCDT4Generator: port to cmXMLWriter dfd8b4d3 cmGlobalKdevelopGenerator: port to cmXMLWriter dcdc270e cmExtraCodeLiteGenerator: port to cmXMLWriter 27e09764 cmExtraCodeBlocksGenerator: port to cmXMLWriter d7407621 cmXMLWriter: add Doctype() method dd27e313 cmXMLWriter: overload Element() method for empty elements https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e835600163c926db3bc5a127eaa17937984f5ab2 commit e835600163c926db3bc5a127eaa17937984f5ab2 Author: Daniel Pfeifer AuthorDate: Thu Jul 16 21:53:57 2015 +0200 Commit: Brad King CommitDate: Mon Mar 21 10:32:42 2016 -0400 CPack/IFW: port to cmXMLWriter diff --git a/Source/CPack/IFW/cmCPackIFWGenerator.cxx b/Source/CPack/IFW/cmCPackIFWGenerator.cxx index 4eb23c1..50ac971 100644 --- a/Source/CPack/IFW/cmCPackIFWGenerator.cxx +++ b/Source/CPack/IFW/cmCPackIFWGenerator.cxx @@ -27,7 +27,7 @@ #include #include #include -#include +#include #include #include @@ -611,18 +611,19 @@ cmCPackIFWPackage* cmCPackIFWGenerator::GetComponentPackage( } // -void cmCPackIFWGenerator::WriteGeneratedByToStrim(cmGeneratedFileStream ) +void cmCPackIFWGenerator::WriteGeneratedByToStrim(cmXMLWriter ) { - xout << "" - << std::endl; + comment << " tools at " << cmTimestamp().CurrentTime("", true); + xout.Comment(comment.str().c_str()); } diff --git a/Source/CPack/IFW/cmCPackIFWGenerator.h b/Source/CPack/IFW/cmCPackIFWGenerator.h index 3246861..5770451 100644 --- a/Source/CPack/IFW/cmCPackIFWGenerator.h +++ b/Source/CPack/IFW/cmCPackIFWGenerator.h @@ -13,12 +13,13 @@ #ifndef cmCPackIFWGenerator_h #define cmCPackIFWGenerator_h -#include #include #include "cmCPackIFWPackage.h" #include "cmCPackIFWInstaller.h" +class cmXMLWriter; + /** \class cmCPackIFWGenerator * \brief A generator for Qt Installer Framework tools * @@ -121,7 +122,7 @@ protected: // Methods cmCPackIFWPackage* GetGroupPackage(cmCPackComponentGroup *group) const; cmCPackIFWPackage* GetComponentPackage(cmCPackComponent *component) const; - void WriteGeneratedByToStrim(cmGeneratedFileStream& xout); + void WriteGeneratedByToStrim(cmXMLWriter& xout); protected: // Data diff --git a/Source/CPack/IFW/cmCPackIFWInstaller.cxx b/Source/CPack/IFW/cmCPackIFWInstaller.cxx index 8c77a2c..224d606 100644 --- a/Source/CPack/IFW/cmCPackIFWInstaller.cxx +++ b/Source/CPack/IFW/cmCPackIFWInstaller.cxx @@ -17,7 +17,7 @@ #include #include -#include +#include #ifdef cmCPackLogger # undef cmCPackLogger @@ -334,30 +334,27 @@ void cmCPackIFWInstaller::GenerateInstallerFile() } // Output stream - cmGeneratedFileStream xout((Directory + "/config/config.xml").data()); + cmGeneratedFileStream fout((Directory + "/config/config.xml").data()); + cmXMLWriter xout(fout); - xout << "" << std::endl; + xout.StartDocument(); WriteGeneratedByToStrim(xout); - xout << "" << std::endl; + xout.StartElement("Installer"); - xout << "" << cmXMLSafe(Name).str() << "" << std::endl; - - xout << "" << Version << "" << std::endl; - - xout << "" << cmXMLSafe(Title).str() << "" - << std::endl; + xout.Element("Name", Name); + xout.Element("Version", Version); + xout.Element("Title", Title); if(!Publisher.empty()) { -xout << "" << cmXMLSafe(Publisher).str() - << "" << std::endl; +xout.Element("Publisher", Publisher); }
[Cmake-commits] CMake branch, next, updated. v3.5.0-559-g5b9c6c1
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "CMake". The branch, next has been updated via 5b9c6c10af412507acce3651d02da93b670767bd (commit) via 6f6571ec24bddae0341714a481617f551c872947 (commit) from 46764d8624b86571d8036b0ac210d3d697c101e5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5b9c6c10af412507acce3651d02da93b670767bd commit 5b9c6c10af412507acce3651d02da93b670767bd Merge: 46764d8 6f6571e Author: Zack GalbreathAuthorDate: Mon Mar 21 10:12:53 2016 -0400 Commit: CMake Topic Stage CommitDate: Mon Mar 21 10:12:53 2016 -0400 Merge topic 'timeout_after_match' into next 6f6571ec Increase margin of error for "ShouldPass" case https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=6f6571ec24bddae0341714a481617f551c872947 commit 6f6571ec24bddae0341714a481617f551c872947 Author: Zack Galbreath AuthorDate: Mon Mar 21 10:01:50 2016 -0400 Commit: Zack Galbreath CommitDate: Mon Mar 21 10:12:02 2016 -0400 Increase margin of error for "ShouldPass" case Help this test pass on busy nightly builds without unnecessarily increasing the amount of time it takes to run. diff --git a/Tests/RunCMake/CTestTimeoutAfterMatch/RunCMakeTest.cmake b/Tests/RunCMake/CTestTimeoutAfterMatch/RunCMakeTest.cmake index 237a013..ee4db83 100644 --- a/Tests/RunCMake/CTestTimeoutAfterMatch/RunCMakeTest.cmake +++ b/Tests/RunCMake/CTestTimeoutAfterMatch/RunCMakeTest.cmake @@ -8,4 +8,4 @@ endfunction() run_ctest_TimeoutAfterMatch(MissingArg1 "\"-Darg2=Test started\"") run_ctest_TimeoutAfterMatch(MissingArg2 "\"-Darg1=2\"") run_ctest_TimeoutAfterMatch(ShouldTimeout "\"-Darg1=1\" \"-Darg2=Test started\"") -run_ctest_TimeoutAfterMatch(ShouldPass "\"-Darg1=2\" \"-Darg2=Test started\"") +run_ctest_TimeoutAfterMatch(ShouldPass "\"-Darg1=15\" \"-Darg2=Test started\"") --- Summary of changes: Tests/RunCMake/CTestTimeoutAfterMatch/RunCMakeTest.cmake |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/mailman/listinfo/cmake-commits
Re: [CMake] EFFECTIVE_PLATFORM_NAME not expanded in TARGET_* generator expressions on iOS
On 21-Mar-16 19:42, Vladimír Vondruš wrote: Hello, I came across this problem when trying to use XCTest macros ( https://cmake.org/cmake/help/latest/module/FindXCTest.html ) on iOS. When compiling for OSX, ctest properly executes all test cases, but when targeting iOS or iOS simulator, all the test cases fail similarly to the following: 25: Test command: /Applications/Xcode.app/Contents/Developer/usr/bin/xctest "/Users/mosra/Code/corrade/build-ioss/src/Corrade/Utility/Test/Debug${EFFECTIVE_PLATFORM_NAME}/UtilityTypeTraitsTestRunner.xctest/../.." 25: Environment variables: 25: DYLD_FRAMEWORK_PATH=/Users/mosra/Code/corrade/build-ioss/src/Corrade/Utility/Test/Debug${EFFECTIVE_PLATFORM_NAME}/UtilityTypeTraitsTest.framework/.. 25: Test timeout computed to be: 9.99988e+06 25: 2016-03-21 12:41:38.799 xctest[31113:31078264] The bundle “Test” couldn’t be loaded because its executable couldn’t be located. Try reinstalling the bundle. 25/28 Test #25: UtilityTypeTraitsTest ...***Failed0.04 sec As you can see, the `${EFFECTIVE_PLATFORM_NAME}` is not being expanded to `-iphonesimulator` and thus the file is not found. The problem is that the `$` generator expression does not expand the variable. On the other hand, installation works without an issue, because the `cmake_install.cmake` scripts do additional round of variable expansion that (accidentally?) fixes this. The relevant part of the CMake source is here: https://github.com/Kitware/CMake/blob/cd569b962dbeaa7ea718021c16582cddd158df3a/Source/cmGeneratorTarget.cxx#L5063 From the source it looks like the generator is just putting the "${EFFECTIVE_PLATFORM_NAME}" output and hopes that someone later expands it. That's the case with install scripts (so they work), but not with generator expressions. The `TARGET_LINKER_FILE_DIR` is not the only affected, the problem is the same for all `TARGET_*` generator expressions. Currently I'm working around this by partially hardcoding the path, but that's far from ideal and I would like to avoid that: if(CMAKE_OSX_SYSROOT MATCHES "iPhoneOS") set(platform_name "-iphoneos") elseif(CMAKE_OSX_SYSROOT MATCHES "iPhoneSimulator") set(platform_name "-iphonesimulator") endif() set(target_linker_file_dir ${CMAKE_CURRENT_BINARY_DIR}/$${platform_name}/${target}.xctest) Is there any way to fix this directly in CMake? Also the above workaround works only when targeting single SDK and not when having single generated project for both the device and the simulator. Thank you a lot for your help. mosra I doubt I can help with the problem but just for your information: * it wasn't fixed "accidentally", it was a fix for #12506: https://github.com/Kitware/CMake/commit/48fe617e667d2e6b1e471cfb56346de51f984ba5 * there is no "additional round" of variable expansion, EFFECTIVE_PLATFORM_NAME initialized from Xcode's environment variable EFFECTIVE_PLATFORM_NAME on installation As far as I understand the main general problem with iOS device/simulator support is that CMake doesn't have multi-toolchain feature from the box. So for now all this stuff worked by generating some "universal" code that do work for both SDKs. The real SDK can be triggered by additional explicit option, i.e.: * cmake --build _builds -- -sdk iphoneos # trigger iphoneos SDK * cmake --build _builds -- -sdk iphonesimulator # trigger iphonesimulator SDK Ruslo -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake
[Cmake-commits] CMake branch, next, updated. v3.5.0-557-g46764d8
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "CMake". The branch, next has been updated via 46764d8624b86571d8036b0ac210d3d697c101e5 (commit) via 81f90a9a03d38609859adf945471b58f11c200f4 (commit) from 67ad9220b9adcf44680d44d7bd01414233b586fd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=46764d8624b86571d8036b0ac210d3d697c101e5 commit 46764d8624b86571d8036b0ac210d3d697c101e5 Merge: 67ad922 81f90a9 Author: Brad KingAuthorDate: Mon Mar 21 09:46:25 2016 -0400 Commit: CMake Topic Stage CommitDate: Mon Mar 21 09:46:25 2016 -0400 Merge topic 'ninja-directory-targets' into next 81f90a9a fixup! Ninja: Add test for `$subdir/all` targets https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=81f90a9a03d38609859adf945471b58f11c200f4 commit 81f90a9a03d38609859adf945471b58f11c200f4 Author: Brad King AuthorDate: Mon Mar 21 09:45:35 2016 -0400 Commit: Brad King CommitDate: Mon Mar 21 09:45:35 2016 -0400 fixup! Ninja: Add test for `$subdir/all` targets diff --git a/Tests/RunCMake/Ninja/RunCMakeTest.cmake b/Tests/RunCMake/Ninja/RunCMakeTest.cmake index cdf51d9..4e06888 100644 --- a/Tests/RunCMake/Ninja/RunCMakeTest.cmake +++ b/Tests/RunCMake/Ninja/RunCMakeTest.cmake @@ -24,6 +24,11 @@ function(run_SubDir) file(REMOVE_RECURSE "${RunCMake_TEST_BINARY_DIR}") file(MAKE_DIRECTORY "${RunCMake_TEST_BINARY_DIR}") run_cmake(SubDir) - run_cmake_command(SubDir-build ${CMAKE_COMMAND} --build . --target SubDir/all) + if(WIN32) +set(SubDir_all [[SubDir\all]]) + else() +set(SubDir_all [[SubDir/all]]) + endif() + run_cmake_command(SubDir-build ${CMAKE_COMMAND} --build . --target ${SubDir_all}) endfunction() run_SubDir() --- Summary of changes: Tests/RunCMake/Ninja/RunCMakeTest.cmake |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/mailman/listinfo/cmake-commits
[Cmake-commits] CMake branch, next, updated. v3.5.0-555-g67ad922
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "CMake". The branch, next has been updated via 67ad9220b9adcf44680d44d7bd01414233b586fd (commit) via 32dc36be8362318437e8585e90a513af8ebb904a (commit) from 8a7f5803d50b3ca52ba0bdf07ca13b7c70b087d9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=67ad9220b9adcf44680d44d7bd01414233b586fd commit 67ad9220b9adcf44680d44d7bd01414233b586fd Merge: 8a7f580 32dc36b Author: Brad KingAuthorDate: Mon Mar 21 09:41:23 2016 -0400 Commit: CMake Topic Stage CommitDate: Mon Mar 21 09:41:23 2016 -0400 Merge topic 'vs-startup-project' into next 32dc36be fixup! VS: Add option to choose the `.sln` startup project (#15578) https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=32dc36be8362318437e8585e90a513af8ebb904a commit 32dc36be8362318437e8585e90a513af8ebb904a Author: Brad King AuthorDate: Mon Mar 21 09:40:45 2016 -0400 Commit: Brad King CommitDate: Mon Mar 21 09:40:45 2016 -0400 fixup! VS: Add option to choose the `.sln` startup project (#15578) diff --git a/Tests/RunCMake/VSSolution/StartupProject-check.cmake b/Tests/RunCMake/VSSolution/StartupProject-check.cmake index fd7cc28..352bbd5 100644 --- a/Tests/RunCMake/VSSolution/StartupProject-check.cmake +++ b/Tests/RunCMake/VSSolution/StartupProject-check.cmake @@ -1,4 +1,4 @@ getFirstProject(first_project StartupProject) -if(NOT first_project STREQUAL "ZERO_CHECK") - error("ZERO_CHECK is not the startup project") +if(NOT first_project STREQUAL "TestStartup") + error("TestStartup is not the startup project") endif() diff --git a/Tests/RunCMake/VSSolution/StartupProject.cmake b/Tests/RunCMake/VSSolution/StartupProject.cmake index 8ba4e3e..7192f3d 100644 --- a/Tests/RunCMake/VSSolution/StartupProject.cmake +++ b/Tests/RunCMake/VSSolution/StartupProject.cmake @@ -1 +1,2 @@ -set_property(DIRECTORY PROPERTY VS_STARTUP_PROJECT "ZERO_CHECK") +add_custom_target(TestStartup) +set_property(DIRECTORY PROPERTY VS_STARTUP_PROJECT "TestStartup") --- Summary of changes: Tests/RunCMake/VSSolution/StartupProject-check.cmake |4 ++-- Tests/RunCMake/VSSolution/StartupProject.cmake |3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/mailman/listinfo/cmake-commits
[Cmake-commits] CMake branch, next, updated. v3.5.0-553-g8a7f580
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "CMake". The branch, next has been updated via 8a7f5803d50b3ca52ba0bdf07ca13b7c70b087d9 (commit) via cd992170db7a85f00d4ad38f78f0b38c33f83d1f (commit) via 8da0997872d454062bc50b3d4ff5d2777583202f (commit) via 63767a248651916cdb2f8969b783351c998e5fd1 (commit) via bbab373b00b8e85b6574232031d8cd23010f65c6 (commit) via 33594f20fa22c7aea62051f199004e3d4d89c971 (commit) via a9cb00cd50b518656053a5da4147a7106a8bfa78 (commit) from 491b222ec2c1863e75517fda010b7e7a9e079dff (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=8a7f5803d50b3ca52ba0bdf07ca13b7c70b087d9 commit 8a7f5803d50b3ca52ba0bdf07ca13b7c70b087d9 Merge: 491b222 cd99217 Author: Brad KingAuthorDate: Mon Mar 21 09:39:37 2016 -0400 Commit: Brad King CommitDate: Mon Mar 21 09:39:37 2016 -0400 Merge branch 'master' into next --- Summary of changes: Source/CMakeVersion.cmake |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/mailman/listinfo/cmake-commits
[Cmake-commits] CMake branch, master, updated. v3.5.0-274-gcd99217
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "CMake". The branch, master has been updated via cd992170db7a85f00d4ad38f78f0b38c33f83d1f (commit) via d84ba668d7dd77ac38b3795f92e4ef0f894c696e (commit) from 8da0997872d454062bc50b3d4ff5d2777583202f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=cd992170db7a85f00d4ad38f78f0b38c33f83d1f commit cd992170db7a85f00d4ad38f78f0b38c33f83d1f Merge: 8da0997 d84ba66 Author: Brad KingAuthorDate: Mon Mar 21 09:39:24 2016 -0400 Commit: CMake Topic Stage CommitDate: Mon Mar 21 09:39:24 2016 -0400 Merge topic 'cpack-osx-optional-CoreServices' d84ba668 CPack: Avoid using OS X CoreServices if compiler fails on header (#16021) --- Summary of changes: Source/CMakeLists.txt | 15 ++- Source/CPack/cmCPackDragNDropGenerator.cxx |6 ++ 2 files changed, 20 insertions(+), 1 deletion(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/mailman/listinfo/cmake-commits
[Cmake-commits] CMake branch, master, updated. v3.5.0-270-g63767a2
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "CMake". The branch, master has been updated via 63767a248651916cdb2f8969b783351c998e5fd1 (commit) via 527773662c092233be5e99123561192eb8eb6fdc (commit) from bbab373b00b8e85b6574232031d8cd23010f65c6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=63767a248651916cdb2f8969b783351c998e5fd1 commit 63767a248651916cdb2f8969b783351c998e5fd1 Merge: bbab373 5277736 Author: Brad KingAuthorDate: Mon Mar 21 09:39:19 2016 -0400 Commit: CMake Topic Stage CommitDate: Mon Mar 21 09:39:19 2016 -0400 Merge topic 'osx-no-carbon' 52777366 Drop unnecessary LSRequiresCarbon reference from Info.plist files --- Summary of changes: Modules/CPack.OSXX11.Info.plist.in |2 -- Modules/MacOSXBundleInfo.plist.in |2 -- Templates/AppleInfo.plist |2 -- 3 files changed, 6 deletions(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/mailman/listinfo/cmake-commits
[Cmake-commits] CMake branch, master, updated. v3.5.0-272-g8da0997
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "CMake". The branch, master has been updated via 8da0997872d454062bc50b3d4ff5d2777583202f (commit) via 5f6b4f690a3348c43f4f26bcc07c2418c3f2ab2f (commit) from 63767a248651916cdb2f8969b783351c998e5fd1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=8da0997872d454062bc50b3d4ff5d2777583202f commit 8da0997872d454062bc50b3d4ff5d2777583202f Merge: 63767a2 5f6b4f6 Author: Brad KingAuthorDate: Mon Mar 21 09:39:21 2016 -0400 Commit: CMake Topic Stage CommitDate: Mon Mar 21 09:39:21 2016 -0400 Merge topic 'find-blas-lapack-OpenBLAS' 5f6b4f69 Find{BLAS,LAPACK}: Add support for OpenBLAS (#16024) --- Summary of changes: Help/release/dev/find-blas-lapack-OpenBLAS.rst |5 + Modules/FindBLAS.cmake | 20 +--- Modules/FindLAPACK.cmake | 15 ++- 3 files changed, 36 insertions(+), 4 deletions(-) create mode 100644 Help/release/dev/find-blas-lapack-OpenBLAS.rst hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/mailman/listinfo/cmake-commits
[Cmake-commits] CMake branch, next, updated. v3.5.0-546-g491b222
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "CMake". The branch, next has been updated via 491b222ec2c1863e75517fda010b7e7a9e079dff (commit) via 6f4f90548353d9e329bd4ddb2f7492788f28f0e1 (commit) from 020f72fae1990c8da4e291e7cd07b6b220a85d05 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=491b222ec2c1863e75517fda010b7e7a9e079dff commit 491b222ec2c1863e75517fda010b7e7a9e079dff Merge: 020f72f 6f4f905 Author: Brad KingAuthorDate: Mon Mar 21 09:07:11 2016 -0400 Commit: CMake Topic Stage CommitDate: Mon Mar 21 09:07:11 2016 -0400 Merge topic 'fix-repeat-pkg-config' into next 6f4f9054 FindPkgConfig: set correctly named variables in cache (#15903) https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=6f4f90548353d9e329bd4ddb2f7492788f28f0e1 commit 6f4f90548353d9e329bd4ddb2f7492788f28f0e1 Author: Ben Boeckel AuthorDate: Fri Mar 18 15:48:56 2016 -0400 Commit: Brad King CommitDate: Mon Mar 21 08:58:12 2016 -0400 FindPkgConfig: set correctly named variables in cache (#15903) The fix in commit v3.5.0-rc1~27^2 (FindPkgConfig: set standard variables in the cache, 2016-01-20) added the wrong variable name to the cache. The test was only testing that the cache variable existed, not that it also had the correct value. Update the test to ensure that the cache value matches the local variable value. Reported-by: Bernd Lörwald diff --git a/Modules/FindPkgConfig.cmake b/Modules/FindPkgConfig.cmake index 4f50e38..447c526 100644 --- a/Modules/FindPkgConfig.cmake +++ b/Modules/FindPkgConfig.cmake @@ -383,7 +383,7 @@ macro(_pkg_check_modules_internal _is_required _is_silent _no_cmake_path _no_cma pkg_get_variable("${_pkg_check_prefix}_INCLUDEDIR" ${_pkg_check_modules_pkg} "includedir") pkg_get_variable("${_pkg_check_prefix}_LIBDIR" ${_pkg_check_modules_pkg} "libdir") foreach (variable IN ITEMS PREFIX INCLUDEDIR LIBDIR) - _pkgconfig_set("${_pkg_check_modules_pkg}_${variable}" "${${_pkg_check_modules_pkg}_${variable}}") + _pkgconfig_set("${_pkg_check_prefix}_${variable}" "${${_pkg_check_prefix}_${variable}}") endforeach () if (NOT ${_is_silent}) diff --git a/Tests/RunCMake/FindPkgConfig/FindPkgConfig_cache_variables.cmake b/Tests/RunCMake/FindPkgConfig/FindPkgConfig_cache_variables.cmake index 8d8d000..d0046ca 100644 --- a/Tests/RunCMake/FindPkgConfig/FindPkgConfig_cache_variables.cmake +++ b/Tests/RunCMake/FindPkgConfig/FindPkgConfig_cache_variables.cmake @@ -1,14 +1,15 @@ +cmake_minimum_required(VERSION 3.3) + find_package(PkgConfig REQUIRED) pkg_check_modules(NCURSES QUIET ncurses) if (NCURSES_FOUND) foreach (variable IN ITEMS PREFIX INCLUDEDIR LIBDIR) -get_property("${variable}" +get_property(value CACHE "NCURSES_${variable}" - PROPERTY TYPE - SET) -if (NOT ${variable}) - message(FATAL_ERROR "Failed to set cache entry for NCURSES_${variable}") + PROPERTY VALUE) +if (NOT value STREQUAL NCURSES_${variable}) + message(FATAL_ERROR "Failed to set cache entry for NCURSES_${variable}:\nexpected -->${value}<--\nreceived -->${NCURSES_${variable}}<--") endif () endforeach () else () --- Summary of changes: Modules/FindPkgConfig.cmake |2 +- .../FindPkgConfig/FindPkgConfig_cache_variables.cmake | 11 ++- 2 files changed, 7 insertions(+), 6 deletions(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/mailman/listinfo/cmake-commits
[CMake] EFFECTIVE_PLATFORM_NAME not expanded in TARGET_* generator expressions on iOS
Hello, I came across this problem when trying to use XCTest macros ( https://cmake.org/cmake/help/latest/module/FindXCTest.html ) on iOS. When compiling for OSX, ctest properly executes all test cases, but when targeting iOS or iOS simulator, all the test cases fail similarly to the following: 25: Test command: /Applications/Xcode.app/Contents/Developer/usr/bin/xctest "/Users/mosra/Code/corrade/build-ioss/src/Corrade/Utility/Test/Debug${EFFECTIVE_PLATFORM_NAME}/UtilityTypeTraitsTestRunner.xctest/../.." 25: Environment variables: 25: DYLD_FRAMEWORK_PATH=/Users/mosra/Code/corrade/build-ioss/src/Corrade/Utility/Test/Debug${EFFECTIVE_PLATFORM_NAME}/UtilityTypeTraitsTest.framework/.. 25: Test timeout computed to be: 9.99988e+06 25: 2016-03-21 12:41:38.799 xctest[31113:31078264] The bundle “Test” couldn’t be loaded because its executable couldn’t be located. Try reinstalling the bundle. 25/28 Test #25: UtilityTypeTraitsTest ...***Failed0.04 sec As you can see, the `${EFFECTIVE_PLATFORM_NAME}` is not being expanded to `-iphonesimulator` and thus the file is not found. The problem is that the `$` generator expression does not expand the variable. On the other hand, installation works without an issue, because the `cmake_install.cmake` scripts do additional round of variable expansion that (accidentally?) fixes this. The relevant part of the CMake source is here: https://github.com/Kitware/CMake/blob/cd569b962dbeaa7ea718021c16582cddd158df3a/Source/cmGeneratorTarget.cxx#L5063 From the source it looks like the generator is just putting the "${EFFECTIVE_PLATFORM_NAME}" output and hopes that someone later expands it. That's the case with install scripts (so they work), but not with generator expressions. The `TARGET_LINKER_FILE_DIR` is not the only affected, the problem is the same for all `TARGET_*` generator expressions. Currently I'm working around this by partially hardcoding the path, but that's far from ideal and I would like to avoid that: if(CMAKE_OSX_SYSROOT MATCHES "iPhoneOS") set(platform_name "-iphoneos") elseif(CMAKE_OSX_SYSROOT MATCHES "iPhoneSimulator") set(platform_name "-iphonesimulator") endif() set(target_linker_file_dir ${CMAKE_CURRENT_BINARY_DIR}/$${platform_name}/${target}.xctest) Is there any way to fix this directly in CMake? Also the above workaround works only when targeting single SDK and not when having single generated project for both the device and the simulator. Thank you a lot for your help. mosra -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake
[cmake-developers] 15975 Bug Fix GHS MULTI try compile
Attached are updates for the bug recorded at https://cmake.org/Bug/view.php?id=15975. The updates make the Green Hills MULTI executable suffix, .as, set in the CMAKE_EXECUTABLE_SUFFIX macro, instead of in the C++ code where it wasn't accessible to the other parts of CMake. As a side note, both Green Hills and Linux do not have suffixes on their executables by default. The .as suffix is somewhat arbitrary. A CMAKE_EXECUTABLE_SUFFIX value of "" will not work because Green Hills MULTI does not allow for filenames and folders in the same directory. At try_compile's the compilation stage, there will be a folder named after the project name for the project at the root. Since the RUNTIME_OUTPUT_DIRECTORY is set to the root, the compilation will stop and explain that the output file is a directory. This message contains confidential information and is intended only for the recipient. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately if you have received this e-mail by mistake and delete this e-mail from your system. Finally, the recipient should check this email and any attachments for the presence of viruses. The company accepts no liability for any damage caused by any virus transmitted by this email. 0001-15975-fix-for-GHS-MULTI-try_compile.patch Description: 0001-15975-fix-for-GHS-MULTI-try_compile.patch -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] C# support ready for review
Uhm, I have to admit that I have not experience in unity development at all so this is not that much of a simple question for me. But my main motivation for native C# support in CMake was to be able to mix native C++, managed C++ and C# binaries within one solution and to build them all together. If this is what you would like to do: yes this works well for me. best regards, Michael > -Original Message- > From: doom.ooseve...@gmail.com [mailto:doom.ooseve...@gmail.com] > On Behalf Of Jean-Michaël Celerier > Sent: Monday, March 21, 2016 9:26 AM > To: Stuermer, Michael SP/HZA-ZSEP > Cc: CMake Developers > Subject: Re: [cmake-developers] C# support ready for review > > Simple question : do you think that this would be useable in order to have a > single build pipeline based on CMake for a Unity3D project that also requires > some native C++ libs ? > > Thanks ! > > > On Mon, Mar 21, 2016 at 8:09 AM, Stuermer, Michael SP/HZA-ZSEP >wrote: > > Sorry for asking, but do you mean > > > > 1. without support for ninja/nmake/make there is no use having C# > > support in cmake > > > > or > > > > 2. using the current approach this could also work with the other > > generators without too much additional work > > > > ? > > > > I'm just a little confused and try to find out what's on my todo list until > > C# > support may reach a mature level. > > > > best regards, > > Michael > > > >> -Original Message- > >> From: David Cole [mailto:dlrd...@aol.com] > >> Sent: Tuesday, March 08, 2016 12:51 AM > >> To: Brad King > >> Cc: Stuermer, Michael SP/HZA-ZSEP; CMake Developers > >> Subject: Re: [cmake-developers] C# support ready for review > >> > >> Seems to me like C# support should work just fine with other generators: > >> ninja, nmake, and UNIX Makefiles included. Especially with mono on > >> Linux/Mac. > >> > >> > >> David > >> > >> > On Mar 7, 2016, at 2:12 PM, Brad King wrote: > >> > > >> >> On 02/25/2016 05:51 AM, Stuermer, Michael SP/HZA-ZSEP wrote: > >> >> The part that probably needs most additional work is all the C# > >> >> detection and configuration part in the module scripts. > >> > > >> > In your branch Modules/CMakeDetermineCSharpCompiler.cmake > >> currently > >> > has a lot of logic and environment checks for this. It shouldn't > >> > need to be that complicated. Anything requiring deep introspection > >> > of the system (especially the registry) should be something done in > >> > the C++ generator implementation and provided to CMake platform > >> > files as a variable. > >> > > >> > For example, the VS generators always provide msbuild: > >> > > >> > > >> > https://cmake.org/cmake/help/v3.5/variable/CMAKE_VS_MSBUILD_COMM > >> AND.ht > >> > ml > >> > > >> > For the path to the compiler tool, take a look at > >> > > >> > Modules/CompilerId/VS-10.vcxproj.in > >> > > >> > and use of it by Modules/CMakeDetermineCompilerId.cmake. That all > >> > runs while detecting the compiler id using a small test project. > >> > It has a custom command that searches the PATH in the IDE project > >> > build environment to print out the path to the compiler. You > >> > should create one like this for CSharp too. > >> > > >> > We'll also need to define behavior when CSharp is enabled by > >> > projects under a non-VS generator. Other generators should reject > >> > any such attempt with an error message. > >> > > >> > Thanks, > >> > -Brad > >> > > >> > -- > >> > > >> > Powered by www.kitware.com > >> > > >> > Please keep messages on-topic and check the CMake FAQ at: > >> > http://www.cmake.org/Wiki/CMake_FAQ > >> > > >> > Kitware offers various services to support the CMake community. For > >> > more > >> information on each offering, please visit: > >> > > >> > CMake Support: http://cmake.org/cmake/help/support.html > >> > CMake Consulting: http://cmake.org/cmake/help/consulting.html > >> > CMake Training Courses: http://cmake.org/cmake/help/training.html > >> > > >> > Visit other Kitware open-source projects at > >> > http://www.kitware.com/opensource/opensource.html > >> > > >> > Follow this link to subscribe/unsubscribe: > >> > http://public.kitware.com/mailman/listinfo/cmake-developers > > -- > > > > Powered by www.kitware.com > > > > Please keep messages on-topic and check the CMake FAQ at: > > http://www.cmake.org/Wiki/CMake_FAQ > > > > Kitware offers various services to support the CMake community. For more > information on each offering, please visit: > > > > CMake Support: http://cmake.org/cmake/help/support.html > > CMake Consulting: http://cmake.org/cmake/help/consulting.html > > CMake Training Courses: http://cmake.org/cmake/help/training.html > > > > Visit other Kitware open-source projects at > > http://www.kitware.com/opensource/opensource.html > > > > Follow this link to subscribe/unsubscribe: > > http://public.kitware.com/mailman/listinfo/cmake-developers -- Powered by www.kitware.com Please keep messages on-topic
Re: [cmake-developers] C# support ready for review
Simple question : do you think that this would be useable in order to have a single build pipeline based on CMake for a Unity3D project that also requires some native C++ libs ? Thanks ! On Mon, Mar 21, 2016 at 8:09 AM, Stuermer, Michael SP/HZA-ZSEPwrote: > Sorry for asking, but do you mean > > 1. without support for ninja/nmake/make there is no use having C# support in > cmake > > or > > 2. using the current approach this could also work with the other generators > without too much additional work > > ? > > I'm just a little confused and try to find out what's on my todo list until > C# support may reach a mature level. > > best regards, > Michael > >> -Original Message- >> From: David Cole [mailto:dlrd...@aol.com] >> Sent: Tuesday, March 08, 2016 12:51 AM >> To: Brad King >> Cc: Stuermer, Michael SP/HZA-ZSEP; CMake Developers >> Subject: Re: [cmake-developers] C# support ready for review >> >> Seems to me like C# support should work just fine with other generators: >> ninja, nmake, and UNIX Makefiles included. Especially with mono on >> Linux/Mac. >> >> >> David >> >> > On Mar 7, 2016, at 2:12 PM, Brad King wrote: >> > >> >> On 02/25/2016 05:51 AM, Stuermer, Michael SP/HZA-ZSEP wrote: >> >> The part that probably needs most additional work is all the C# >> >> detection and configuration part in the module scripts. >> > >> > In your branch Modules/CMakeDetermineCSharpCompiler.cmake >> currently >> > has a lot of logic and environment checks for this. It shouldn't need >> > to be that complicated. Anything requiring deep introspection of the >> > system (especially the registry) should be something done in the C++ >> > generator implementation and provided to CMake platform files as a >> > variable. >> > >> > For example, the VS generators always provide msbuild: >> > >> > >> https://cmake.org/cmake/help/v3.5/variable/CMAKE_VS_MSBUILD_COMM >> AND.ht >> > ml >> > >> > For the path to the compiler tool, take a look at >> > >> > Modules/CompilerId/VS-10.vcxproj.in >> > >> > and use of it by Modules/CMakeDetermineCompilerId.cmake. That all >> > runs while detecting the compiler id using a small test project. >> > It has a custom command that searches the PATH in the IDE project >> > build environment to print out the path to the compiler. You should >> > create one like this for CSharp too. >> > >> > We'll also need to define behavior when CSharp is enabled by projects >> > under a non-VS generator. Other generators should reject any such >> > attempt with an error message. >> > >> > Thanks, >> > -Brad >> > >> > -- >> > >> > Powered by www.kitware.com >> > >> > Please keep messages on-topic and check the CMake FAQ at: >> > http://www.cmake.org/Wiki/CMake_FAQ >> > >> > Kitware offers various services to support the CMake community. For more >> information on each offering, please visit: >> > >> > CMake Support: http://cmake.org/cmake/help/support.html >> > CMake Consulting: http://cmake.org/cmake/help/consulting.html >> > CMake Training Courses: http://cmake.org/cmake/help/training.html >> > >> > Visit other Kitware open-source projects at >> > http://www.kitware.com/opensource/opensource.html >> > >> > Follow this link to subscribe/unsubscribe: >> > http://public.kitware.com/mailman/listinfo/cmake-developers > -- > > Powered by www.kitware.com > > Please keep messages on-topic and check the CMake FAQ at: > http://www.cmake.org/Wiki/CMake_FAQ > > Kitware offers various services to support the CMake community. For more > information on each offering, please visit: > > CMake Support: http://cmake.org/cmake/help/support.html > CMake Consulting: http://cmake.org/cmake/help/consulting.html > CMake Training Courses: http://cmake.org/cmake/help/training.html > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/cmake-developers -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] C# support ready for review
Sorry for asking, but do you mean 1. without support for ninja/nmake/make there is no use having C# support in cmake or 2. using the current approach this could also work with the other generators without too much additional work ? I'm just a little confused and try to find out what's on my todo list until C# support may reach a mature level. best regards, Michael > -Original Message- > From: David Cole [mailto:dlrd...@aol.com] > Sent: Tuesday, March 08, 2016 12:51 AM > To: Brad King > Cc: Stuermer, Michael SP/HZA-ZSEP; CMake Developers > Subject: Re: [cmake-developers] C# support ready for review > > Seems to me like C# support should work just fine with other generators: > ninja, nmake, and UNIX Makefiles included. Especially with mono on > Linux/Mac. > > > David > > > On Mar 7, 2016, at 2:12 PM, Brad Kingwrote: > > > >> On 02/25/2016 05:51 AM, Stuermer, Michael SP/HZA-ZSEP wrote: > >> The part that probably needs most additional work is all the C# > >> detection and configuration part in the module scripts. > > > > In your branch Modules/CMakeDetermineCSharpCompiler.cmake > currently > > has a lot of logic and environment checks for this. It shouldn't need > > to be that complicated. Anything requiring deep introspection of the > > system (especially the registry) should be something done in the C++ > > generator implementation and provided to CMake platform files as a > > variable. > > > > For example, the VS generators always provide msbuild: > > > > > https://cmake.org/cmake/help/v3.5/variable/CMAKE_VS_MSBUILD_COMM > AND.ht > > ml > > > > For the path to the compiler tool, take a look at > > > > Modules/CompilerId/VS-10.vcxproj.in > > > > and use of it by Modules/CMakeDetermineCompilerId.cmake. That all > > runs while detecting the compiler id using a small test project. > > It has a custom command that searches the PATH in the IDE project > > build environment to print out the path to the compiler. You should > > create one like this for CSharp too. > > > > We'll also need to define behavior when CSharp is enabled by projects > > under a non-VS generator. Other generators should reject any such > > attempt with an error message. > > > > Thanks, > > -Brad > > > > -- > > > > Powered by www.kitware.com > > > > Please keep messages on-topic and check the CMake FAQ at: > > http://www.cmake.org/Wiki/CMake_FAQ > > > > Kitware offers various services to support the CMake community. For more > information on each offering, please visit: > > > > CMake Support: http://cmake.org/cmake/help/support.html > > CMake Consulting: http://cmake.org/cmake/help/consulting.html > > CMake Training Courses: http://cmake.org/cmake/help/training.html > > > > Visit other Kitware open-source projects at > > http://www.kitware.com/opensource/opensource.html > > > > Follow this link to subscribe/unsubscribe: > > http://public.kitware.com/mailman/listinfo/cmake-developers -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] C# support ready for review
Thanks for the hints, I will adapt the C# detection. best regards, Michael > -Original Message- > From: Brad King [mailto:brad.k...@kitware.com] > Sent: Monday, March 07, 2016 8:12 PM > To: Stuermer, Michael SP/HZA-ZSEP > Cc: Gilles Khouzam; CMake Developers > Subject: Re: [cmake-developers] C# support ready for review > > On 02/25/2016 05:51 AM, Stuermer, Michael SP/HZA-ZSEP wrote: > > The part that probably needs most additional work is all the C# > > detection and configuration part in the module scripts. > > In your branch Modules/CMakeDetermineCSharpCompiler.cmake currently > has a lot of logic and environment checks for this. It shouldn't need to be > that complicated. Anything requiring deep introspection of the system > (especially the registry) should be something done in the C++ generator > implementation and provided to CMake platform files as a variable. > > For example, the VS generators always provide msbuild: > > > https://cmake.org/cmake/help/v3.5/variable/CMAKE_VS_MSBUILD_COMM > AND.html > > For the path to the compiler tool, take a look at > > Modules/CompilerId/VS-10.vcxproj.in > > and use of it by Modules/CMakeDetermineCompilerId.cmake. That all runs > while detecting the compiler id using a small test project. > It has a custom command that searches the PATH in the IDE project build > environment to print out the path to the compiler. You should create one > like this for CSharp too. > > We'll also need to define behavior when CSharp is enabled by projects under > a non-VS generator. Other generators should reject any such attempt with > an error message. > > Thanks, > -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers