[Cmake-commits] CMake branch, master, updated. v3.6.0-rc3-237-gc68cf9e
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "CMake". The branch, master has been updated via c68cf9e4d111fa7c92973acec92d71ce6d187ff9 (commit) from 3a0449439f03981865b8d43815ac9b6292574a47 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c68cf9e4d111fa7c92973acec92d71ce6d187ff9 commit c68cf9e4d111fa7c92973acec92d71ce6d187ff9 Author: Kitware Robot <kwro...@kitware.com> AuthorDate: Sun Jun 26 00:01:05 2016 -0400 Commit: Kitware Robot <kwro...@kitware.com> CommitDate: Sun Jun 26 00:01:05 2016 -0400 CMake Nightly Date Stamp diff --git a/Source/CMakeVersion.cmake b/Source/CMakeVersion.cmake index a1d1eb3..733ba92 100644 --- a/Source/CMakeVersion.cmake +++ b/Source/CMakeVersion.cmake @@ -1,5 +1,5 @@ # CMake version number components. set(CMake_VERSION_MAJOR 3) set(CMake_VERSION_MINOR 6) -set(CMake_VERSION_PATCH 20160625) +set(CMake_VERSION_PATCH 20160626) #set(CMake_VERSION_RC 1) --- Summary of changes: Source/CMakeVersion.cmake |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/mailman/listinfo/cmake-commits
Re: [cmake-developers] [patch] iOS combined, some fixes
Great, thank you! On 25-Jun-16 14:56, Gregor Jasny wrote: On 21/06/16 18:48, Ruslan Baratov wrote: Is the patch applied? Let me know if there are any questions left about it. Pushed into next. Sorry for the delay. -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [CMake] CMake terminology
On 25-Jun-16 10:44, Craig Scott wrote: One of the slight wrinkles here is that the distinction between configure and generation times is now a little stronger due to generator expressions. In order to really understand generator expressions, you cannot really avoid getting your head around configure and generate being distinct parts of the process. Personally, I tend to gloss over the distinction when explaining things so as not to distract the reader, but if I'm explaining something to do with generator expressions, then the distinction has to be made and I deliberately use the terms /configure/ and /generation/ stages. I'm not sure I understand the link between "generator expressions" and "confusing configure+generate stage". Do you mean "generator expressions" on "configure+generate stage" vs "build stage"? Also, as Ruslo points out, cmake can be used like a front end to the build step proper (i.e. cmake --build ...). I still see this as the /build/ though, not a cmake-specific step per se. If you treated that as a cmake step, then one could argue the whole build is cmake because cmake can be used to invoke the test and package targets too. I doubt many people think this way, so personally I feel it is clearer to refer to the /build/ stage as simply that without bringing cmake into the terminology. Okay, I agree. "cmake build step" sounds weird, it should be just "build step" which can be triggered by "cmake --build" command. Also to be pedantic: it's CTest for testing stage and CPack for packing stage, not CMake (or you mean CMake tools?). So in summary, here's the set of terminology I use (hopefully similar to what others intuitively expect): Workflow stages in general: cmake (or project setup) --> build --> test --> package If talking about generator expressions: configure --> generate --> build --> test --> package This one reminds me about ExternalProject_Add command. It has "Configure step" with "CONFIGURE_COMMAND". This is where "cmake -H. -B_builds" happens :) So for now I see two choices: * invent new name for configure+generate :) well, this seems like a huge overkill... * use words "configure" and "generate" interchangeably for command line cmake, depending on context, e.g.: * "you can add `-D` on __configure step__ to modify cache..." * "you can add `-G Xcode` on __generate step__ to create Xcode project instead of Makefile..." Ruslo On Sat, Jun 25, 2016 at 5:02 PM, Eric Noulard> wrote: Hi there, I'd like to give my opinion here. I agree that the fact that the cmake ui (qt or curse) makes it possible to separate configure from generate is an implementation detail. In fact one could perfectly decide that the "configure" step should "generate " each time it is run. Making it two-step save some time for big project but I have already seen people forgetting to generate and asking themselves why they didn't get any makefiles... Nevertheless from a user point of view explaining that there are different "time" because CMake is a buid system **generator** and not a build tool seems very important to me. Some action may be run during CMake time some may be done during Build time. For me CMake run is configure+generate. I did gave a tutorial which is now a bit outdated where I tried to picture this. See attached file or: https://github.com/TheErk/CMake-tutorial my 2 cents. 2016-06-25 2:33 GMT+02:00 Ruslan Baratov via CMake >: There is cmake **build** step: cmake --build _builds So in GUI it's: * cmake configure * cmake generate * IDE build (which you can do with cmake --build so it can be called "cmake build" step) in cmd: * cmake configure+generate * cmake build Also I can call it "cmake step" in docs about some C++ project, but if the docs about cmake itself I think this term is too wide On 25-Jun-16 02:13, Craig Scott wrote: In documentation, blog articles, etc. I just call it the "cmake" step (or sometimes the "project setup" step if talking in a more project-wide sense). For many users, the separate configure and generate steps are somewhat of an implementation detail, so it makes more sense to give it a single term. I'm not aware of any generally accepted term, but the ones I use seem to be fairly easy to understand, especially for those new to CMake. YMMV. On Saturday, 25 June 2016, Ruslan Baratov via CMake > wrote: On 24-Jun-16 23:49, Robert Maynard wrote: Please run the configure and generate steps by It's too long :) Also it doesn't express the fact that
Re: [CMake] CMake terminology
On 25-Jun-16 10:02, Eric Noulard wrote: Hi there, I'd like to give my opinion here. I agree that the fact that the cmake ui (qt or curse) makes it possible to separate configure from generate is an implementation detail. In fact one could perfectly decide that the "configure" step should "generate " each time it is run. Making it two-step save some time for big project but I have already seen people forgetting to generate and asking themselves why they didn't get any makefiles... Nevertheless from a user point of view explaining that there are different "time" because CMake is a buid system **generator** and not a build tool seems very important to me. Some action may be run during CMake time some may be done during Build time. For me CMake run is configure+generate. I did gave a tutorial which is now a bit outdated where I tried to picture this. See attached file or: https://github.com/TheErk/CMake-tutorial my 2 cents. Actually it doesn't conflicts with steps notions. "cmake time" for GUI = "cmake configure" step + "cmake generate" step, "cmake time" for command-line = "cmake configure+generate" step. Also by one step you can trigger events from different "times", i.e. "cmake --build _builds --target install" will run "Install time" which can trigger commands from "Build time", which even can trigger commands from "CMake time" (if CMakeLists.txt changed for example). 2016-06-25 2:33 GMT+02:00 Ruslan Baratov via CMake>: There is cmake **build** step: cmake --build _builds So in GUI it's: * cmake configure * cmake generate * IDE build (which you can do with cmake --build so it can be called "cmake build" step) in cmd: * cmake configure+generate * cmake build Also I can call it "cmake step" in docs about some C++ project, but if the docs about cmake itself I think this term is too wide On 25-Jun-16 02:13, Craig Scott wrote: In documentation, blog articles, etc. I just call it the "cmake" step (or sometimes the "project setup" step if talking in a more project-wide sense). For many users, the separate configure and generate steps are somewhat of an implementation detail, so it makes more sense to give it a single term. I'm not aware of any generally accepted term, but the ones I use seem to be fairly easy to understand, especially for those new to CMake. YMMV. On Saturday, 25 June 2016, Ruslan Baratov via CMake > wrote: On 24-Jun-16 23:49, Robert Maynard wrote: Please run the configure and generate steps by It's too long :) Also it doesn't express the fact that it's a single action, consider: "To add variables on configure and generate steps use '-D'" "Before running configure and generate steps note that old variables from cache can be used" etc. On Fri, Jun 24, 2016 at 4:40 PM, Ruslan Baratov wrote: On 24-Jun-16 23:25, Robert Maynard wrote: cmake from the command line is still running the two stages, it just doesn't allow for feedback/input from the user between the two stages. Yes, I understand that. Question is about the name of the step. I.e. when I do write manual what should I choose Please run configure step by: cmake -H. -B_builds or Please run generate step by: cmake -H. -B_builds ? May be both versions are correct? Or both incorrect? Ruslo On Fri, Jun 24, 2016 at 4:06 PM, Ruslan Baratov via CMake wrote: Hi, I have a question about CMake terminology. When we are using CMake GUI there are two buttons "Configure" and "Generate", hence we have two stages: 1. Configure step, when we do configuring project, effectively creating file with cache variables (which we can modify) without really generating native tools files like Makefile/*.sln/etc. 2. Generate step, when we do generating project using file with cache variables, i.e. create those Makefile/*.sln/etc. The question is about command line version of CMake. Since we do creating file with cache and generate native tools
Re: [cmake-developers] [patch] iOS combined, some fixes
On 21/06/16 18:48, Ruslan Baratov wrote: > Is the patch applied? Let me know if there are any questions left about it. Pushed into next. Sorry for the delay. -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [CMake] Using CMake on CLion and adding geoip library
Hej, According to https://cmake.org/cmake/help/v3.4/module/CheckIncludeFile.html the ‘check_include_file’ is a function provided by a module. So you’ll need to include(CheckIncludeFile) at the beginning of your lists-file Sincerely, Jakob > On 25 Jun 2016, at 08:09, Hgfjj Hhjgfwrote: > > I am trying to use an external library (GeoIP). CMake list contains: > message(STATUS "Looking for MaxMind GeoIP header files") > > set(CMAKE_INCLUDE_PATH "${CMAKE_INCLUDE_PATH} ${GEOIP_INCLUDE_DIR}") > check_include_file("GeoIP.h" HAVE_GEOIP_H) > check_include_file("GeoIPCity.h" HAVE_GEOIPCITY_H) > if (HAVE_GEOIP_H AND HAVE_GEOIPCITY_H) > message(STATUS "Looking for MaxMind GeoIP header files - found") > else(HAVE_GEOIP_H AND HAVE_GEOIPCITY_H) > message(FATAL_ERROR "Could not find one or more MaxMind GeoIP header > files. If the MaxMind GeoIP library is installed, you can run CMake again and > specify its location with -DGEOIP_INCLUDE_DIR=") > endif(HAVE_GEOIP_H AND HAVE_GEOIPCITY_H) > > message(STATUS "Looking for MaxMind GeoIP libraries") > find_library(GEOIP_LIB > NAMES GeoIP geoip > PATHS ${GEOIP_LIBRARY_DIR} > ) > if (GEOIP_LIB) > message(STATUS "Looking for MaxMind GeoIP libraries - found") > set(GEOIP_LIBRARIES ${GEOIP_LIB}) > else(GEOIP_LIB) > message(FATAL_ERROR "Could not find MaxMind GeoIP library") > endif(GEOIP_LIB) > > but getting error like "Unknown cmake command: check_include_file" > what's the problem here then? > -- > > Powered by www.kitware.com > > Please keep messages on-topic and check the CMake FAQ at: > http://www.cmake.org/Wiki/CMake_FAQ > > Kitware offers various services to support the CMake community. For more > information on each offering, please visit: > > CMake Support: http://cmake.org/cmake/help/support.html > CMake Consulting: http://cmake.org/cmake/help/consulting.html > CMake Training Courses: http://cmake.org/cmake/help/training.html > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/cmake -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake
Re: [CMake] CMake terminology
One of the slight wrinkles here is that the distinction between configure and generation times is now a little stronger due to generator expressions. In order to really understand generator expressions, you cannot really avoid getting your head around configure and generate being distinct parts of the process. Personally, I tend to gloss over the distinction when explaining things so as not to distract the reader, but if I'm explaining something to do with generator expressions, then the distinction has to be made and I deliberately use the terms *configure* and *generation* stages. Also, as Ruslo points out, cmake can be used like a front end to the build step proper (i.e. cmake --build ...). I still see this as the *build* though, not a cmake-specific step per se. If you treated that as a cmake step, then one could argue the whole build is cmake because cmake can be used to invoke the test and package targets too. I doubt many people think this way, so personally I feel it is clearer to refer to the *build* stage as simply that without bringing cmake into the terminology. So in summary, here's the set of terminology I use (hopefully similar to what others intuitively expect): Workflow stages in general: cmake (or project setup) --> build --> test --> package If talking about generator expressions: configure --> generate --> build --> test --> package On Sat, Jun 25, 2016 at 5:02 PM, Eric Noulardwrote: > Hi there, > > I'd like to give my opinion here. > I agree that the fact that the cmake ui (qt or curse) makes it possible to > separate configure from generate > is an implementation detail. In fact one could perfectly decide that the > "configure" step should "generate " > each time it is run. Making it two-step save some time for big project but > I have already seen people forgetting > to generate and asking themselves why they didn't get any makefiles... > > Nevertheless from a user point of view explaining that there are different > "time" because CMake is a buid system **generator** and not a build tool > seems very important to me. > > Some action may be run during CMake time some may be done during Build > time. > For me CMake run is configure+generate. > > I did gave a tutorial which is now a bit outdated where I tried to picture > this. > See attached file or: > https://github.com/TheErk/CMake-tutorial > > my 2 cents. > > 2016-06-25 2:33 GMT+02:00 Ruslan Baratov via CMake : > >> There is cmake **build** step: cmake --build _builds >> >> So in GUI it's: >> * cmake configure >> * cmake generate >> * IDE build (which you can do with cmake --build so it can be called >> "cmake build" step) >> >> in cmd: >> * cmake configure+generate >> * cmake build >> >> Also I can call it "cmake step" in docs about some C++ project, but if >> the docs about cmake itself I think this term is too wide >> >> >> On 25-Jun-16 02:13, Craig Scott wrote: >> >> In documentation, blog articles, etc. I just call it the "cmake" step (or >> sometimes the "project setup" step if talking in a more project-wide >> sense). For many users, the separate configure and generate steps are >> somewhat of an implementation detail, so it makes more sense to give it a >> single term. I'm not aware of any generally accepted term, but the ones I >> use seem to be fairly easy to understand, especially for those new to >> CMake. YMMV. >> >> On Saturday, 25 June 2016, Ruslan Baratov via CMake < >> cmake@cmake.org> wrote: >> >>> On 24-Jun-16 23:49, Robert Maynard wrote: >>> Please run the configure and generate steps by >>> It's too long :) >>> >>> Also it doesn't express the fact that it's a single action, consider: >>> "To add variables on configure and generate steps use '-D'" >>> "Before running configure and generate steps note that old variables >>> from cache can be used" >>> etc. >>> >>> >>> On Fri, Jun 24, 2016 at 4:40 PM, Ruslan Baratov wrote: > On 24-Jun-16 23:25, Robert Maynard wrote: > >> cmake from the command line is still running the two stages, it just >> doesn't allow for feedback/input from the user between the two stages. >> > Yes, I understand that. Question is about the name of the step. I.e. > when I > do write manual what should I choose >Please run configure step by: cmake -H. -B_builds > or >Please run generate step by: cmake -H. -B_builds > ? > > May be both versions are correct? Or both incorrect? > > Ruslo > > > On Fri, Jun 24, 2016 at 4:06 PM, Ruslan Baratov via CMake >> wrote: >> >>> Hi, >>> >>> I have a question about CMake terminology. When we are using CMake >>> GUI >>> there >>> are two buttons "Configure" and "Generate", hence we have two stages: >>> >>> 1. Configure step, when we do configuring project, effectively >>> creating
[CMake] Using CMake on CLion and adding geoip library
I am trying to use an external library (GeoIP). CMake list contains: message(STATUS "Looking for MaxMind GeoIP header files") set(CMAKE_INCLUDE_PATH "${CMAKE_INCLUDE_PATH} ${GEOIP_INCLUDE_DIR}") check_include_file("GeoIP.h" HAVE_GEOIP_H) check_include_file("GeoIPCity.h" HAVE_GEOIPCITY_H) if (HAVE_GEOIP_H AND HAVE_GEOIPCITY_H) message(STATUS "Looking for MaxMind GeoIP header files - found") else(HAVE_GEOIP_H AND HAVE_GEOIPCITY_H) message(FATAL_ERROR "Could not find one or more MaxMind GeoIP header files. If the MaxMind GeoIP library is installed, you can run CMake again and specify its location with -DGEOIP_INCLUDE_DIR=") endif(HAVE_GEOIP_H AND HAVE_GEOIPCITY_H) message(STATUS "Looking for MaxMind GeoIP libraries") find_library(GEOIP_LIB NAMES GeoIP geoip PATHS ${GEOIP_LIBRARY_DIR} ) if (GEOIP_LIB) message(STATUS "Looking for MaxMind GeoIP libraries - found") set(GEOIP_LIBRARIES ${GEOIP_LIB}) else(GEOIP_LIB) message(FATAL_ERROR "Could not find MaxMind GeoIP library") endif(GEOIP_LIB) but getting error like "Unknown cmake command: check_include_file" what's the problem here then? -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake