DO NOT REPLY [Bug 20296] - [PATCH] Modularized DirectoryGenerator's
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20296. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20296 [PATCH] Modularized DirectoryGenerator's --- Additional Comments From [EMAIL PROTECTED] 2003-06-29 06:10 --- Check out the XpathDirectoryGenerator. Does what you want. I think that what Torsten was doing was integrating code between this and the DirectoryGenerator, not adding Xpath support. Upayavira
DO NOT REPLY [Bug 20296] - [PATCH] Modularized DirectoryGenerator's
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20296. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20296 [PATCH] Modularized DirectoryGenerator's --- Additional Comments From [EMAIL PROTECTED] 2003-06-29 06:21 --- I don't follow - doesn't integrating XPathDirectoryGenerator into the other directory generators add xpath support to them? If not, what IS being integrated from the XPathDirectoryGenerator?
DO NOT REPLY [Bug 20296] - [PATCH] Modularized DirectoryGenerator's
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20296. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20296 [PATCH] Modularized DirectoryGenerator's --- Additional Comments From [EMAIL PROTECTED] 2003-06-28 10:53 --- Hello Torsten, I had a look at your code - and I'm not convinced. You extracted an interface out of the DirectoryGenerator and added a AbstractFileHandler, the old extending generators like MP3DG or ImageDG are reimplemented as FileHandlers. But what's the advantage of this, what are the use cases, where current DirectoryGenerator does not work? We don't have any duplicate code in the current implementation, so the simple design (a base class and some extending classes) seems to be really good. Of course modularization is good, but not always - exactly there where it is not really needed. Or to speak in XP: YAGNI (http://www.xprogramming.com/Practices/PracNotNeed.html) + KISS (http://www.extremeprogramming.org/rules/simple.html). Do you still want to convince me? ;-) At the best with use cases. Also Conal voted for this bug and Miles added his mail address as CC - maybe they know use cases. And furthermore something is completely missing in your patches: documentation - no Javadoc, no XDocs, no anything. Maybe someone else can have a look on this, but I'm about to reject the patch. Joerg
DO NOT REPLY [Bug 20296] - [PATCH] Modularized DirectoryGenerator's
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20296. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20296 [PATCH] Modularized DirectoryGenerator's --- Additional Comments From [EMAIL PROTECTED] 2003-06-29 05:56 --- I'm pretty sure I voted for this as a fix for the broken XPath support in the current DirectoryGenerator, and to provide cacheable generation. I haven't looked at Torsten's source, but this is what I was voting for: caching AND xpath-reference for ALL such generators. My use case was to extract fragments of metadata from a directory of XML documents, to transform into an HTML page of hyperlinks. Without the xpath support I have to transform dir:file elements into XInclude, and then process with the (non-cacheable) XIncludeProcessor. Con
DO NOT REPLY [Bug 20296] - [PATCH] Modularized DirectoryGenerator's
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20296. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20296 [PATCH] Modularized DirectoryGenerator's --- Additional Comments From [EMAIL PROTECTED] 2003-05-31 08:02 --- Torsten, I don't know anything about the directory generators, but I just wanted to point out that we have the coding standard to use 4 spaces instead of tabs for indenting code. Makes it easier for us if you keep to that in your patches. I'd also like to leave a trail here to this message: http://marc.theaimsgroup.com/?l=xml-cocoon-devm=105420595927620w=2 because you mention there that you haven't tested the xpath part. Might be good to know for anyone who considers committing this code.
DO NOT REPLY [Bug 20296] - [PATCH] Modularized DirectoryGenerator's
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20296. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20296 [PATCH] Modularized DirectoryGenerator's --- Additional Comments From [EMAIL PROTECTED] 2003-05-28 12:26 --- Created an attachment (id=6531) The diff for the existing files like doc, webapp, ... (no removes here)
DO NOT REPLY [Bug 20296] - [PATCH] Modularized DirectoryGenerator's
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20296. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20296 [PATCH] Modularized DirectoryGenerator's --- Additional Comments From [EMAIL PROTECTED] 2003-05-28 12:28 --- Created an attachment (id=6532) FileHandler interface for the file type dependent part
DO NOT REPLY [Bug 20296] - [PATCH] Modularized DirectoryGenerator's
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20296. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20296 [PATCH] Modularized DirectoryGenerator's --- Additional Comments From [EMAIL PROTECTED] 2003-05-28 12:28 --- Created an attachment (id=6533) An abstract class for the FileHandler doing dummy's
DO NOT REPLY [Bug 20296] - [PATCH] Modularized DirectoryGenerator's
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20296. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20296 [PATCH] Modularized DirectoryGenerator's --- Additional Comments From [EMAIL PROTECTED] 2003-05-28 12:29 --- Created an attachment (id=6534) The former ImageDirectoryGenerator as FileHandler
DO NOT REPLY [Bug 20296] - [PATCH] Modularized DirectoryGenerator's
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20296. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20296 [PATCH] Modularized DirectoryGenerator's --- Additional Comments From [EMAIL PROTECTED] 2003-05-28 12:29 --- Created an attachment (id=6535) The former MP3DirectoryGenerator as FileHandler
DO NOT REPLY [Bug 20296] - [PATCH] Modularized DirectoryGenerator's
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20296. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20296 [PATCH] Modularized DirectoryGenerator's --- Additional Comments From [EMAIL PROTECTED] 2003-05-28 12:29 --- Created an attachment (id=6536) The former XMLDirectoryGenerator as FileHandler
DO NOT REPLY [Bug 20296] - [PATCH] Modularized DirectoryGenerator's
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20296. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20296 [PATCH] Modularized DirectoryGenerator's --- Additional Comments From [EMAIL PROTECTED] 2003-05-28 12:30 --- Created an attachment (id=6537) Last, the new Generator (was DirectoryGenerator)
