[jira] [Commented] (CASSANDRA-8777) Streaming operations should log both endpoint and port associated with the operation
[ https://issues.apache.org/jira/browse/CASSANDRA-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218702#comment-15218702 ] Aleksey Yeschenko commented on CASSANDRA-8777: -- Committed as [7f6d70d707e672baa0b43416350fe843c7f2fc67|https://github.com/apache/cassandra/commit/7f6d70d707e672baa0b43416350fe843c7f2fc67] to trunk, thanks. > Streaming operations should log both endpoint and port associated with the > operation > > > Key: CASSANDRA-8777 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8777 > Project: Cassandra > Issue Type: Improvement >Reporter: Jeremy Hanna >Assignee: Kaide Mu > Labels: lhf > Fix For: 3.6 > > Attachments: 8777-2.2.txt > > > Currently we log the endpoint for a streaming operation. If the port has > been overridden, it would be valuable to know that that setting is getting > picked up. Therefore, when logging the endpoint address, it would be nice to > also log the port it's trying to use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8777) Streaming operations should log both endpoint and port associated with the operation
[ https://issues.apache.org/jira/browse/CASSANDRA-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216219#comment-15216219 ] Paulo Motta commented on CASSANDRA-8777: Thanks for the patch. LGTM, I moved the CHANGES message up to the top (as it should be), and also made a minor change on the stream error message. Updated patch and tests are below (will mark as ready to commit when CI is happy): ||trunk|| |[branch|https://github.com/apache/cassandra/compare/trunk...pauloricardomg:trunk-8777]| |[testall|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-trunk-8777-testall/lastCompletedBuild/testReport/]| |[dtest|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-trunk-8777-dtest/lastCompletedBuild/testReport/]| > Streaming operations should log both endpoint and port associated with the > operation > > > Key: CASSANDRA-8777 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8777 > Project: Cassandra > Issue Type: Improvement >Reporter: Jeremy Hanna > Labels: lhf > Fix For: 2.1.x > > Attachments: 8777-2.2.txt > > > Currently we log the endpoint for a streaming operation. If the port has > been overridden, it would be valuable to know that that setting is getting > picked up. Therefore, when logging the endpoint address, it would be nice to > also log the port it's trying to use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8777) Streaming operations should log both endpoint and port associated with the operation
[ https://issues.apache.org/jira/browse/CASSANDRA-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15215188#comment-15215188 ] Kaide Mu commented on CASSANDRA-8777: - Hi, [~pauloricardomg] a new [patch|https://github.com/apache/cassandra/compare/trunk...kdmu:8777-trunk?expand=1] is available. This time I'm trying to work on the forked repository, please let me know if there's any mistake. Thank you. > Streaming operations should log both endpoint and port associated with the > operation > > > Key: CASSANDRA-8777 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8777 > Project: Cassandra > Issue Type: Improvement >Reporter: Jeremy Hanna > Labels: lhf > Fix For: 2.1.x > > Attachments: 8777-2.2.txt > > > Currently we log the endpoint for a streaming operation. If the port has > been overridden, it would be valuable to know that that setting is getting > picked up. Therefore, when logging the endpoint address, it would be nice to > also log the port it's trying to use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8777) Streaming operations should log both endpoint and port associated with the operation
[
https://issues.apache.org/jira/browse/CASSANDRA-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15214616#comment-15214616
]
Paulo Motta commented on CASSANDRA-8777:
This will be useful for cases when there is an error before the connection was
established, such as the exception trace shown by Brandon. But it would be nice
to add the endpoint and port to other stream statements while the stream is
connected.
We currently name the {{MessageHandler}} thread after the remote peer address,
so the thread name/peer IP is automatically logged during any stream session
log statement. We should probably use the remote socket address instead, so
both IP and port will be logged, similar to what is done on
{{IncomingStreamingConnection}}.
Minor nits:
* thorow -> through
* since {{connecting}} is almost always equal to {{peer}}, it's probably good
to use [this
trick|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/streaming/StreamSession.java#L239]
to log {{connecting}} only when its different from {{peer}}.
> Streaming operations should log both endpoint and port associated with the
> operation
>
>
> Key: CASSANDRA-8777
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8777
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Jeremy Hanna
> Labels: lhf
> Fix For: 2.1.x
>
> Attachments: 8777-2.2.txt
>
>
> Currently we log the endpoint for a streaming operation. If the port has
> been overridden, it would be valuable to know that that setting is getting
> picked up. Therefore, when logging the endpoint address, it would be nice to
> also log the port it's trying to use.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8777) Streaming operations should log both endpoint and port associated with the operation
[ https://issues.apache.org/jira/browse/CASSANDRA-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212149#comment-15212149 ] Kaide Mu commented on CASSANDRA-8777: - Patch available for review > Streaming operations should log both endpoint and port associated with the > operation > > > Key: CASSANDRA-8777 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8777 > Project: Cassandra > Issue Type: Improvement >Reporter: Jeremy Hanna > Labels: lhf > Fix For: 2.1.x > > Attachments: 8777-2.2.txt > > > Currently we log the endpoint for a streaming operation. If the port has > been overridden, it would be valuable to know that that setting is getting > picked up. Therefore, when logging the endpoint address, it would be nice to > also log the port it's trying to use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8777) Streaming operations should log both endpoint and port associated with the operation
[ https://issues.apache.org/jira/browse/CASSANDRA-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14651836#comment-14651836 ] Gary Dusbabek commented on CASSANDRA-8777: -- Easiest approach: Each stream session is used for a single `peer`, so you could log that and `connecting` in `onError()`. Another option would be to add a `logger.error()` to `DefaultConnectionFactory` right before the throw, and also `BulkLoadConnectionFactory`. Streaming operations should log both endpoint and port associated with the operation Key: CASSANDRA-8777 URL: https://issues.apache.org/jira/browse/CASSANDRA-8777 Project: Cassandra Issue Type: Improvement Components: Core Reporter: Jeremy Hanna Labels: lhf Fix For: 2.1.x Currently we log the endpoint for a streaming operation. If the port has been overridden, it would be valuable to know that that setting is getting picked up. Therefore, when logging the endpoint address, it would be nice to also log the port it's trying to use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8777) Streaming operations should log both endpoint and port associated with the operation
[ https://issues.apache.org/jira/browse/CASSANDRA-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14651892#comment-14651892 ] Ryan Magnusson commented on CASSANDRA-8777: --- Thanks Gary Dusbabek. Is there any reservation from the group with using InetSocketAddress instead of just InetAddress with Stream operations? Streaming operations should log both endpoint and port associated with the operation Key: CASSANDRA-8777 URL: https://issues.apache.org/jira/browse/CASSANDRA-8777 Project: Cassandra Issue Type: Improvement Components: Core Reporter: Jeremy Hanna Labels: lhf Fix For: 2.1.x Currently we log the endpoint for a streaming operation. If the port has been overridden, it would be valuable to know that that setting is getting picked up. Therefore, when logging the endpoint address, it would be nice to also log the port it's trying to use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8777) Streaming operations should log both endpoint and port associated with the operation
[ https://issues.apache.org/jira/browse/CASSANDRA-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14649328#comment-14649328 ] Ryan Magnusson commented on CASSANDRA-8777: --- I would like to take this on, but have some questions to clarify the request. The description says that we currently log the endpoint for a streaming operation, but in the example provided I only see the planId being shown. I see in some parts of the code we do log out InetAddress, but it isn't in the example provided. Is the goal of this task to also add the address to messages for stream operations where it currently is not shown? Streaming operations should log both endpoint and port associated with the operation Key: CASSANDRA-8777 URL: https://issues.apache.org/jira/browse/CASSANDRA-8777 Project: Cassandra Issue Type: Improvement Components: Core Reporter: Jeremy Hanna Labels: lhf Fix For: 2.1.x Currently we log the endpoint for a streaming operation. If the port has been overridden, it would be valuable to know that that setting is getting picked up. Therefore, when logging the endpoint address, it would be nice to also log the port it's trying to use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8777) Streaming operations should log both endpoint and port associated with the operation
[
https://issues.apache.org/jira/browse/CASSANDRA-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14315079#comment-14315079
]
Brandon Williams commented on CASSANDRA-8777:
-
An example of this:
{noformat}
[Stream #f1c44b20-ae44-11e4-8ca2-ff2c74060249] Streaming error occurred
java.net.ConnectException: Connection refused
at sun.nio.ch.Net.connect0(Native Method)
at sun.nio.ch.Net.connect(Net.java:465)
at sun.nio.ch.Net.connect(Net.java:457)
at sun.nio.ch.SocketChannelImpl.connect(SocketChannelImpl.java:666)
at java.nio.channels.SocketChannel.open(SocketChannel.java:184)
at
org.apache.cassandra.tools.BulkLoadConnectionFactory.createConnection(BulkLoadConnectionFactory.java:62)
at
org.apache.cassandra.streaming.StreamSession.createConnection(StreamSession.java:222)
at
org.apache.cassandra.streaming.ConnectionHandler.initiate(ConnectionHandler.java:77)
at org.apache.cassandra.streaming.StreamSession$1.run(StreamSession.java:208)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)
{noformat}
We know the connection was refused, but we don't know where, so in
troubleshooting we have to resort to packet capture.
Streaming operations should log both endpoint and port associated with the
operation
Key: CASSANDRA-8777
URL: https://issues.apache.org/jira/browse/CASSANDRA-8777
Project: Cassandra
Issue Type: Bug
Components: Core
Reporter: Jeremy Hanna
Labels: lhf
Currently we log the endpoint for a streaming operation. If the port has
been overridden, it would be valuable to know that that setting is getting
picked up. Therefore, when logging the endpoint address, it would be nice to
also log the port it's trying to use.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
