Bug#1026385: Please use absolute path to auth-dialog in .service file
Am 30.12.22 um 11:47 schrieb Guido Günther: Hi Michael, On Fri, Dec 30, 2022 at 11:33:50AM +0100, Michael Biebl wrote: Hi, I've made an NMU to DELAYED/14. Please find attached the debdiff. Let me know if you want me to cancel the NMU. Thanks! NMU is fine. Feel Free to accelerate if it helps. Thanks Guido, (re-)uploaded without delay. Regards, Michael OpenPGP_signature Description: OpenPGP digital signature
Bug#1026385: Please use absolute path to auth-dialog in .service file
Hi Michael, On Fri, Dec 30, 2022 at 11:33:50AM +0100, Michael Biebl wrote: > Hi, > > I've made an NMU to DELAYED/14. > > Please find attached the debdiff. > Let me know if you want me to cancel the NMU. Thanks! NMU is fine. Feel Free to accelerate if it helps. -- Guido
Bug#1026385: Please use absolute path to auth-dialog in .service file
Hi, I've made an NMU to DELAYED/14. Please find attached the debdiff. Let me know if you want me to cancel the NMU. Regards, Michael diff -Nru network-manager-iodine-1.2.0/debian/changelog network-manager-iodine-1.2.0/debian/changelog --- network-manager-iodine-1.2.0/debian/changelog 2021-11-17 18:37:25.0 +0100 +++ network-manager-iodine-1.2.0/debian/changelog 2022-12-30 11:19:28.0 +0100 @@ -1,3 +1,12 @@ +network-manager-iodine (1.2.0-3.2) unstable; urgency=medium + + * Non-maintainer upload. + * Use full path to auth-dialog in nm-iodine.service. +This will ensure that the package isn't broken by a possible future change +of libexecdir in network-manager. (Closes: #1026385) + + -- Michael Biebl Fri, 30 Dec 2022 11:19:28 +0100 + network-manager-iodine (1.2.0-3.1) unstable; urgency=high * Non-maintainer upload. diff -Nru network-manager-iodine-1.2.0/debian/patches/series network-manager-iodine-1.2.0/debian/patches/series --- network-manager-iodine-1.2.0/debian/patches/series 2021-11-17 18:28:33.0 +0100 +++ network-manager-iodine-1.2.0/debian/patches/series 2022-12-30 11:19:21.0 +0100 @@ -1,3 +1,4 @@ appdata-rename-the-xml-file.patch Let-dh-handle-any-autoreconf-configure-invocations.patch Install-appdata-into-metainfo.patch +Use-full-path-to-auth-dialog-in-service-file.patch diff -Nru network-manager-iodine-1.2.0/debian/patches/Use-full-path-to-auth-dialog-in-service-file.patch network-manager-iodine-1.2.0/debian/patches/Use-full-path-to-auth-dialog-in-service-file.patch --- network-manager-iodine-1.2.0/debian/patches/Use-full-path-to-auth-dialog-in-service-file.patch 1970-01-01 01:00:00.0 +0100 +++ network-manager-iodine-1.2.0/debian/patches/Use-full-path-to-auth-dialog-in-service-file.patch 2022-12-30 11:19:28.0 +0100 @@ -0,0 +1,25 @@ +From: Michael Biebl +Date: Mon, 19 Dec 2022 11:49:24 +0100 +Subject: Use full path to auth-dialog in service file + +This way we avoid that the search path compiled into other packages, +like network-manager or network-manager-gnome, need to match our own +libexecdir configure parameter. + +Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1026385 +--- + nm-iodine-service.name.in | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/nm-iodine-service.name.in b/nm-iodine-service.name.in +index 4061b43..cf024a3 100644 +--- a/nm-iodine-service.name.in b/nm-iodine-service.name.in +@@ -7,6 +7,6 @@ program=@LIBEXECDIR@/nm-iodine-service + plugin=@PLUGINDIR@/libnm-vpn-plugin-iodine.so + + [GNOME] +-auth-dialog=nm-iodine-auth-dialog ++auth-dialog=@LIBEXECDIR@/nm-iodine-auth-dialog + properties=libnm-iodine-properties + supports-external-ui-mode=true OpenPGP_signature Description: OpenPGP digital signature
Bug#1026385: Please use absolute path to auth-dialog in .service file
Source: network-manager-iodine Version: 1.2.0-3.1 Severity: wishlist Tags: patch Hi, currently, nm-iodine-service.name.in uses auth-dialog=nm-iodine-auth-dialog This means, other programs like nm-connection-editor need to have the same compiled in search path (libexecdir) as network-manager-iodine. There has been a request that I change the libexecdir of NetworkManager (and related packages) from /usr/lib/NetworkManager to /usr/libexec. Doing that, would break network-manager-iodine, so I'd like network-manager-iodine use an absolute path for auth-dialog. This way, affected packages can be changed independently to /usr/libexec without breaking. I'm considering making this change in NetworkManager in bookworm+1, so it would be great to have a fixed network-manager-iodine package in bookworm, to make future backports easier. Thanks for considering the attached patch. I can offer to NMU, fwiw. Regards, Michael -- System Information: Debian Release: bookworm/sid APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 6.0.0-6-amd64 (SMP w/4 CPU threads; PREEMPT) Kernel taint flags: TAINT_FIRMWARE_WORKAROUND Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE not set Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled From: Michael Biebl Date: Mon, 19 Dec 2022 11:49:24 +0100 Subject: Use full path to auth-dialog in service file This way we avoid that the search path compiled into other packages, like network-manager-gnome, need to match our own libexecdir configure parameter. --- nm-iodine-service.name.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nm-iodine-service.name.in b/nm-iodine-service.name.in index 4061b43..cf024a3 100644 --- a/nm-iodine-service.name.in +++ b/nm-iodine-service.name.in @@ -7,6 +7,6 @@ program=@LIBEXECDIR@/nm-iodine-service plugin=@PLUGINDIR@/libnm-vpn-plugin-iodine.so [GNOME] -auth-dialog=nm-iodine-auth-dialog +auth-dialog=@LIBEXECDIR@/nm-iodine-auth-dialog properties=libnm-iodine-properties supports-external-ui-mode=true
