Bug#790996: cgal: library transition may be needed when GCC 5 is the default

[Simon McVittie]

On Sat, 15 Aug 2015 at 13:05:19 +0200, Joachim Reichel wrote:
 Attached is the diff for 4.6.1-2. Several build depends have not yet made the
 transition:
 
 level 3: gmp (791053)

This is believed to not need a transition.

 level 5: qtbase-opensource-src (794518)

This is believed to not need a transition. It needed sourceful changes
to build successfully, but those have been done.

 level 6: libqglviewer, boost

libqglviewer does not appear to need a transition: its only mention of
std::string is in a source file, not a header, and it does not export
any cxx11 symbols.

boost was one of the first few transitions started: Boost 1.55 is
the old ABI, Boost 1.58 is the new ABI.

So I think this part of the transition can start now?

S

Bug#790996: cgal: library transition may be needed when GCC 5 is the default

[Joachim Reichel]

user release.debian@packages.debian.org
usertag 790996 + transition
block 790996 by 790756
reassign 790996 release.debian.org
thanks

Attached is the diff for 4.6.1-2. Several build depends have not yet made the
transition:

level 3: gmp (791053)
level 5: qtbase-opensource-src (794518)
level 6: libqglviewer, boost

Joachim

diff -Nru cgal-4.6.1/debian/changelog cgal-4.6.1/debian/changelog
--- cgal-4.6.1/debian/changelog	2015-06-26 18:58:01.0 +0200
+++ cgal-4.6.1/debian/changelog	2015-08-15 10:57:45.0 +0200
@@ -1,3 +1,9 @@
+cgal (4.6.1-2) unstable; urgency=medium
+
+  * Rename library packages for g++5 ABI transition (Closes: #790996).
+
+ -- Joachim Reichel reic...@debian.org  Sat, 15 Aug 2015 10:57:06 +0200
+
 cgal (4.6.1-1) unstable; urgency=medium
 
   * New upstream release.
diff -Nru cgal-4.6.1/debian/control cgal-4.6.1/debian/control
--- cgal-4.6.1/debian/control	2015-04-10 20:19:57.0 +0200
+++ cgal-4.6.1/debian/control	2015-08-15 10:58:58.0 +0200
@@ -10,7 +10,9 @@
 Homepage: http://www.cgal.org/
 XS-Autobuild: yes
 
-Package: libcgal11
+Package: libcgal11v5
+Conflicts: libcgal11
+Replaces: libcgal11
 Architecture: any
 Multi-Arch: same
 Pre-Depends: ${misc:Pre-Depends}
@@ -35,13 +37,15 @@
  This package contains the main library libCGAL.so as well as two support
  libraries libCGAL_Core.so (from the CORE project) and libCGAL_ImageIO.so
  (image I/O). The library libCGAL_Qt4.so used for visualization in demos
- can be found in the package libcgal-qt4-11.
+ can be found in the package libcgal-qt4-11v5.
 
-Package: libcgal-qt4-11
+Package: libcgal-qt4-11v5
+Conflicts: libcgal-qt4-11
+Replaces: libcgal-qt4-11
 Architecture: any
 Multi-Arch: same
 Pre-Depends: ${misc:Pre-Depends}
-Depends: libcgal11 (= ${binary:Version}), ${shlibs:Depends}, ${misc:Depends}
+Depends: libcgal11v5 (= ${binary:Version}), ${shlibs:Depends}, ${misc:Depends}
 Description: C++ library for computational geometry (support for Qt4)
  CGAL (Computational Geometry Algorithms Library) makes the most important
  of the solutions and methods developed in computational geometry available
@@ -65,7 +69,7 @@
 Section: libdevel
 Architecture: any
 Multi-Arch: same
-Depends: libcgal11 (= ${binary:Version}), libboost-dev, libboost-thread-dev,
+Depends: libcgal11v5 (= ${binary:Version}), libboost-dev, libboost-thread-dev,
  libboost-system-dev, libboost-program-options-dev, libgmp10-dev, libmpfr-dev,
  zlib1g-dev, ${misc:Depends}
 Suggests: libmpfi-dev, libntl-dev, libtbb-dev
@@ -83,7 +87,7 @@
 Section: libdevel
 Architecture: any
 Multi-Arch: same
-Depends: libcgal11 (= ${binary:Version}), libcgal-qt4-11 (= ${binary:Version}),
+Depends: libcgal11v5 (= ${binary:Version}), libcgal-qt4-11v5 (= ${binary:Version}),
  libcgal-dev, libqt4-dev, ${misc:Depends}
 Replaces: libcgal-dev ( 4.1-1)
 Breaks: libcgal-dev ( 4.1-1)
@@ -100,9 +104,9 @@
 Section: devel
 Architecture: all
 Multi-Arch: foreign
-Depends: libcgal-dev (= ${binary:Version}), libcgal11 (= ${binary:Version}),
+Depends: libcgal-dev (= ${binary:Version}), libcgal11v5 (= ${binary:Version}),
  ${misc:Depends}
-Recommends: libcgal-qt4-dev (= ${binary:Version}), libcgal-qt4-11 (= ${binary:Version})
+Recommends: libcgal-qt4-dev (= ${binary:Version}), libcgal-qt4-11v5 (= ${binary:Version})
 Suggests: liblapack-dev, libatlas-base-dev, gfortran,  geomview,
  libqglviewer-dev, libipe-dev (= 7), libglew1.5-dev | libglew-dev,
  libmagick++-dev, qt4-dev-tools, libqt4-opengl-dev, libeigen3-dev (= 3.1.0~beta1-1),
@@ -118,7 +122,7 @@
 Package: libcgal-ipelets
 Section: graphics
 Architecture: any
-Depends: libcgal11 (= ${binary:Version}), ipe (= ${Ipe-Version}), ipe ( ${Ipe-Version}+),
+Depends: libcgal11v5 (= ${binary:Version}), ipe (= ${Ipe-Version}), ipe ( ${Ipe-Version}+),
  ${shlibs:Depends}, ${misc:Depends}
 Conflicts: libcgal5-ipelets
 Replaces: libcgal5-ipelets
diff -Nru cgal-4.6.1/debian/libcgal-qt4-11.install cgal-4.6.1/debian/libcgal-qt4-11.install
--- cgal-4.6.1/debian/libcgal-qt4-11.install	2014-10-24 21:24:42.0 +0200
+++ cgal-4.6.1/debian/libcgal-qt4-11.install	1970-01-01 01:00:00.0 +0100
@@ -1 +0,0 @@
-usr/lib/*/libCGAL_Qt4.so.*
diff -Nru cgal-4.6.1/debian/libcgal-qt4-11.shlibs cgal-4.6.1/debian/libcgal-qt4-11.shlibs
--- cgal-4.6.1/debian/libcgal-qt4-11.shlibs	2015-04-10 20:43:58.0 +0200
+++ cgal-4.6.1/debian/libcgal-qt4-11.shlibs	1970-01-01 01:00:00.0 +0100
@@ -1 +0,0 @@
-libCGAL_Qt4 11 libcgal-qt4-11
diff -Nru cgal-4.6.1/debian/libcgal-qt4-11v5.install cgal-4.6.1/debian/libcgal-qt4-11v5.install
--- cgal-4.6.1/debian/libcgal-qt4-11v5.install	1970-01-01 01:00:00.0 +0100
+++ cgal-4.6.1/debian/libcgal-qt4-11v5.install	2014-10-24 21:24:42.0 +0200
@@ -0,0 +1 @@
+usr/lib/*/libCGAL_Qt4.so.*
diff -Nru cgal-4.6.1/debian/libcgal-qt4-11v5.lintian-overrides cgal-4.6.1/debian/libcgal-qt4-11v5.lintian-overrides
--- cgal-4.6.1/debian/libcgal-qt4-11v5.lintian-overrides	1970-01-01 01:00:00.0 +0100
+++ 

Bug#790996: cgal: library transition may be needed when GCC 5 is the default

[Joachim Reichel]

On 08/10/2015 04:16 PM, Helmut Grohne wrote:
 Control: severity -1 serious
 
 libcgal11 broke ABI in 4.6.1-1+b1.
 
 Example symbol diff:
 
 -CGAL::swallow(std::istream, std::string const)
 +CGAL::swallow(std::istream, std::__cxx11::basic_stringchar, 
 std::char_traitschar, std::allocatorchar  const)

Thanks, I'm aware of that and working on it. Some of the build-depends haven't
made the transition yet: gmp, ntl, qtbase-opensource-src, ipe, geomview,
libqglviewer.

(Additionally, a small part of the patch depends on the names of their binary
packages.)

Joachim


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#790996: cgal: library transition may be needed when GCC 5 is the default

[Helmut Grohne]

Control: severity -1 serious

libcgal11 broke ABI in 4.6.1-1+b1.

Example symbol diff:

-CGAL::swallow(std::istream, std::string const)
+CGAL::swallow(std::istream, std::__cxx11::basic_stringchar, 
std::char_traitschar, std::allocatorchar  const)


On Fri, Jul 03, 2015 at 01:09:11PM +, Matthias Klose wrote:
  - If a library transition is needed, please prepare for the change.
Rename the library package, append v5 to the name of the package
(e.g. libfoo2 - libfoo2v5). Such a change can be avoided, if you
have a soversion bump and you upload this version instead of the
renamed package.  Prepare a patch and attach it to this issue (mark
this issue with patch), so that it is possible to NMU such a
package. We'll probably have more than hundred transitions
triggered. Then reassign the issue to release.debian.org and
properly tag it as a transition issue, by sending an email to
cont...@bugs.debian.org:

  user release.debian@packages.debian.org
  usertag this issue + transition
  block this issue by 790756
  reassign this issue release.debian.org

A library transition is needed.

Helmut


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org