Bug#494640: live-helper: Doesn't follow APT_RECOMMENDS settings in lh_chroot_sources
tags 494640 +pending thanks This is fixed now in git. If the settings are left on default, the binary image does not get tainted by live-helper specific files in /etc/apt/apt.conf.d/. If the settings are set to non-default values by the choice of the user, the live-helper specific files in /etc/apt/apt.conf.d/ are not removed and apt in the resulting binary image does respect the users choice. Regards, Daniel -- Address:Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist Email: [EMAIL PROTECTED] Internet: http://people.panthera-systems.net/~daniel-baumann/ ___ debian-live-devel mailing list debian-live-devel@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/debian-live-devel
Bug#494640: live-helper: Doesn't follow APT_RECOMMENDS settings in lh_chroot_sources
Jeremy [EMAIL PROTECTED] writes: I am just curious as to the idea of a 'tainted image'. It seems to me that it would not allow a user to customize their image. Does everything have to be the default debian setting? I would hope that there is an option to not install recommended packages, especially in the space-tight environment of a live-cd. If the default setting for LH_APT_RECOMMENDS is enabled then wouldn't that be consistent with a normal debian install? I hope I don't sound rude or anything, I would just like someone to explain it to me. Yes, your concept is right and I fully agree with the not installation of recommends by default. -- O T A V I OS A L V A D O R - E-mail: [EMAIL PROTECTED] UIN: 5906116 GNU/Linux User: 239058 GPG ID: 49A5F855 Home Page: http://otavio.ossystems.com.br - Microsoft sells you Windows ... Linux gives you the whole house. ___ debian-live-devel mailing list debian-live-devel@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/debian-live-devel
Bug#494640: live-helper: Doesn't follow APT_RECOMMENDS settings in lh_chroot_sources
Hi Jeremy/Otavio, Jeremy [EMAIL PROTECTED] writes: I am just curious as to the idea of a 'tainted image'. It seems to me that it would not allow a user to customize their image. Well, hmm. So to expand on what I mentioned in my previous email, there is a slight distinction in that whilst there *is* an option to enable/disable the installation of recommended packages, it only applies to the chroot (ie. image building) stages. This means that the installation of bash with APT_RECOMMENDS=disabled will *not* install bash-completion and is thus not included on your ISO image. (You'll need the Git version to see this though) However, the binary image (eg. your finished ISO) will not have the don't install recommends apt stanza. This is problematic because when apt-get dist-upgrade is called it will install all the recommended packages that match the currently installed packages, ie. bash-completion and friends. This especially sucks because a number of users are running dist-upgrade on startup to pull in security updates. Otavio Salvador wrote: Yes, your concept is right and I fully agree with the not installation of recommends by default. Huh? I think I'm missing something here.. we are not discussing whether recommends should be installed by default, but whether the binary image should respect a customisation of that setting. (The default setting of APT_LH_RECOMMENDS is a totally different topic, and Jeremy is not asking for this to be changed here.) Does everything have to be the default debian setting? [..] If the default setting for LH_APT_RECOMMENDS is enabled then wouldn't that be consistent with a normal debian install? No, and I agree with you. Whilst there is some effort to ensure that an image generated with the /default/ settings of live-helper matches Debian as much as possible, this shouldn't mean that users cannot customise stuff. So yes, I think that the binary image should inherit the APT_RECOMMENDS setting. I will commit that later this evening unless Daniel shouts at me otherwise. Regards, -- Chris Lamb, UK [EMAIL PROTECTED] GPG: 0x634F9A20 signature.asc Description: PGP signature ___ debian-live-devel mailing list debian-live-devel@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/debian-live-devel
Bug#494640: live-helper: Doesn't follow APT_RECOMMENDS settings in lh_chroot_sources
Chris Lamb [EMAIL PROTECTED] writes: So yes, I think that the binary image should inherit the APT_RECOMMENDS setting. I will commit that later this evening unless Daniel shouts at me otherwise. Ok. I had misunderstood the discussion. I agree with you too. -- O T A V I OS A L V A D O R - E-mail: [EMAIL PROTECTED] UIN: 5906116 GNU/Linux User: 239058 GPG ID: 49A5F855 Home Page: http://otavio.ossystems.com.br - Microsoft sells you Windows ... Linux gives you the whole house. ___ debian-live-devel mailing list debian-live-devel@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/debian-live-devel
Bug#494640: live-helper: Doesn't follow APT_RECOMMENDS settings in lh_chroot_sources
On Mon, Aug 11, 2008 at 9:03 PM, Chris Lamb [EMAIL PROTECTED] wrote: tags 494640 + pending thanks Jeremy wrote: I don't believe I was missing any script because I first got this problem when running lh_chroot, then lh_binary. However, I was doing many retries (mostly lh_build) on it previously, with only a lh_clean --purge in between. First, thank you for your detailed report. I must also apologise for accusing you of omitting a call (!) -- lh_binary does not call lh_chroot_apt. I can also confirm the behaviour you describe. (In fact, lh_binary cannot call lh_chroot_apt because the binary stages must have a different apt_preferences(5) configuration than the chroot stage to handle chroot_local-packages correctly.) I've committed a change to live-helper in Git which fixes this issue. Regards, -- Chris Lamb, UK [EMAIL PROTECTED] GPG: 0x634F9A20 Thanks so much for replying so promptly and fixing it so quickly. You don't need to apologize, there was a chance I didn't know what was going on. Thanks for the live-helper project, Jeremy ___ debian-live-devel mailing list debian-live-devel@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/debian-live-devel
Bug#494640: live-helper: Doesn't follow APT_RECOMMENDS settings in lh_chroot_sources
Chris Lamb wrote: I've committed a change to live-helper in Git which fixes this issue. this fix does actually do more harm than it solves - it injects the apt settings into the binary image, which is not acceptable as it produces tainted images. we need to be very carefull here and pay attention to what ends up into the binary image and what not, as that defines debian and we don't want to ship a different debian by default that the current official debian is. i personally have considered the chroot to be tainted right after creating the rootfs anyway, if possible, it should be fixed that one can rerun/reruse the chroot safely to build another binary from it. will look into this today. -- Address:Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist Email: [EMAIL PROTECTED] Internet: http://people.panthera-systems.net/~daniel-baumann/ ___ debian-live-devel mailing list debian-live-devel@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/debian-live-devel
Bug#494640: live-helper: Doesn't follow APT_RECOMMENDS settings in lh_chroot_sources
Jeremy Salwen wrote: I found that it was doing an apt-get dist-upgrade which was making it install recommended packages (I believe the default for apt?). This was contrary to the file rootdir/config/common in which I had the line LH_APT_RECOMMENDS=disabled Hm, whilst `lh_chroot_sources` does call dist-upgrade, the chroot's APT config should have already been modified to not install recommended packages by the `lh_chroot_apt` helper. Are you running helpers manually and missing this one? Are you using chroot_local-packages? Regards, -- Chris Lamb, UK [EMAIL PROTECTED] GPG: 0x634F9A20 signature.asc Description: PGP signature ___ debian-live-devel mailing list debian-live-devel@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/debian-live-devel
Bug#494640: live-helper: Doesn't follow APT_RECOMMENDS settings in lh_chroot_sources
Package: live-helper Version: 1.0~a48-1 Severity: normal I have a strange feeling that this might be a 'feature'. When I ran 'lh_chroot_sources install' (with all previous scripts run without errors) or any script which calls it, I found it was installing packages I didn't request. With some investigation I found that it was doing an apt-get dist-upgrade which was making it install recommended packages (I believe the default for apt?). This was contrary to the file rootdir/config/common in which I had the line LH_APT_RECOMMENDS=disabled which seemed to do the job for everything but this script. I think this is a bug, but in the past I have simply misunderstood the correct function of a program and thought it was a bug. Please tell me if the script is supposed to ignore this option. Jeremy -- Package-specific info: -- System Information: Debian Release: lenny/sid APT prefers testing APT policy: (990, 'testing'), (500, 'stable'), (90, 'unstable'), (10, 'experimental') Architecture: i386 (i686) Kernel: Linux 2.6.24 (SMP w/1 CPU core) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages live-helper depends on: ii cdebootstrap 0.5.3 Bootstrap a Debian system ii debootstrap 1.0.10 Bootstrap a basic Debian system live-helper recommends no packages. -- no debconf information ___ debian-live-devel mailing list debian-live-devel@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/debian-live-devel
Bug#494640: live-helper: Doesn't follow APT_RECOMMENDS settings in lh_chroot_sources
On Mon, Aug 11, 2008 at 1:04 AM, Chris Lamb [EMAIL PROTECTED] wrote:
Jeremy Salwen wrote:
I found that it was doing an apt-get dist-upgrade which was making it
install recommended packages (I believe the default for apt?). This was
contrary to the file rootdir/config/common in which I had the line
LH_APT_RECOMMENDS=disabled
Hm, whilst `lh_chroot_sources` does call dist-upgrade, the chroot's APT
config should have already been modified to not install recommended
packages
by the `lh_chroot_apt` helper.
Are you running helpers manually and missing this one? Are you using
chroot_local-packages?
Regards,
--
Chris Lamb, UK
[EMAIL PROTECTED]
GPG: 0x634F9A20
I stumbled upon this issue when I ran lh_binary first. It was installing
many java packages (gcj, bsh, openoffice.org-java), which I didn't request.
I recognized that these were the same packages that aptitude was trying to
install before I had turned recommends off (openoffice.org was recommending
it, I believe).
I then looked at the command tree at the wiki, and ran all the commands
in order, until I ran 'lh_chroot_sources install' and it tried to install
the packages again. I then googled that script and I found some stuff about
putting 'apt-get dist-upgrade' in the script at some point.
In chroot, I tried apt-get dist-upgrade, and sure enough, it tried to
install the packages. However, when I gave it the option
--no-install-recommends, it didn't try to install them.
I then returned to the script, and opened it in an editor. I found the
only place in it where it called 'Apt dist-upgrade'. I looked in
/usr/share/live-helper/functions/ and found 'Apt' in wrapper.sh, and
verified that it was calling
case ${LH_APT} in
apt|apt-get)
Chroot apt-get ${APT_OPTIONS} [EMAIL PROTECTED]
;;
and that
LH_APT=apt
I then put in the line
echo ${APT_OPTIONS}
in lh_chroot_sources right before the 'Apt dist-upgrade'
when I ran it again, it printed out '--yes' and nothing else.
I tried setting the apt settings in chroot to disable recommends.
Apt-config said *APT*::Install-*Recommends* was equal to '1' when I set it
to '0', it didn't work, but when I set it to 'false' it stopped the
unnecessary packaging at least in chroot.
However, lh_chroot_sources was still trying to install them, so I gave up
and added --no-install-recommends to the Apt dist-upgrade line and it
worked.
I am using both chroot_local-packages and chroot_local-packageslists and a
custom repository for both binary and chroot, if that means anything. I
don't believe I was missing any script because I first got this problem when
running lh_chroot, then lh_binary. However, I was doing many retries
(mostly lh_build) on it previously, with only a lh_clean --purge in between.
I hope this helps you
Jeremy
___
debian-live-devel mailing list
debian-live-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/debian-live-devel
Bug#494640: live-helper: Doesn't follow APT_RECOMMENDS settings in lh_chroot_sources
tags 494640 + pending thanks Jeremy wrote: I don't believe I was missing any script because I first got this problem when running lh_chroot, then lh_binary. However, I was doing many retries (mostly lh_build) on it previously, with only a lh_clean --purge in between. First, thank you for your detailed report. I must also apologise for accusing you of omitting a call (!) -- lh_binary does not call lh_chroot_apt. I can also confirm the behaviour you describe. (In fact, lh_binary cannot call lh_chroot_apt because the binary stages must have a different apt_preferences(5) configuration than the chroot stage to handle chroot_local-packages correctly.) I've committed a change to live-helper in Git which fixes this issue. Regards, -- Chris Lamb, UK [EMAIL PROTECTED] GPG: 0x634F9A20 signature.asc Description: PGP signature ___ debian-live-devel mailing list debian-live-devel@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/debian-live-devel
