Re: [VOTE] release of ant 1.8.2

2011-01-04 Thread Jesse Glick

On 12/20/2010 12:32 AM, Antoine Levy-Lambert wrote:

However I was not able to reproduce the problem that you mentioned.
Is it possible that you did not put junit-4 on the classpath when running the 
junit 4 style test suite ?


No, the property was defined to point to a copy of JUnit 4.8.1. Anyway I can 
confirm that my test case works in the 1.8.2 final release (and not with the 
initial candidate).


Or else the antunit testscase which I added does not reproduce the failure case.


Well, editing the control method to be clearly bogus

  public void ok() {throw new RuntimeException(XXX just testing);}

does not cause a failure either, so the testcase is obviously broken. Even making the test class uncompilable does not cause a failure! I am working on fixing the test 
case; the test was being skipped.


Also note that running 'ant test -Dtestcase=...' tests the version of Ant in $PATH, not that from the source tree! I fixed this for JUnit tests but I guess it is still 
broken for AntUnit tests.



-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] release of ant 1.8.2

2011-01-04 Thread Antoine Levy-Lambert

On 1/4/2011 11:47 AM, Jesse Glick wrote:

On 12/20/2010 12:32 AM, Antoine Levy-Lambert wrote:

However I was not able to reproduce the problem that you mentioned.
Is it possible that you did not put junit-4 on the classpath when 
running the junit 4 style test suite ?


No, the property was defined to point to a copy of JUnit 4.8.1. Anyway 
I can confirm that my test case works in the 1.8.2 final release (and 
not with the initial candidate).


Or else the antunit testscase which I added does not reproduce the 
failure case.


Well, editing the control method to be clearly bogus

  public void ok() {throw new RuntimeException(XXX just testing);}

does not cause a failure either, so the testcase is obviously broken. 
Even making the test class uncompilable does not cause a failure! I am 
working on fixing the test case; the test was being skipped.

Thanks. I see your diffs here [1]
I am not good at writing unit tests. Plus I am concerned about how they 
fare when they run in gump ...



Also note that running 'ant test -Dtestcase=...' tests the version of 
Ant in $PATH, not that from the source tree! I fixed this for JUnit 
tests but I guess it is still broken for AntUnit tests.



Thanks this is useful. Can you point me to the changes you did to make 
ant test the version of the source tree ? For antunit tests yes, this is 
certainly broken as you say, you are testing the version of ant in the 
PATH or the one pointed to by ANT_HOME.


Regards,

Antoine

[1] 
http://svn.apache.org/viewvc/ant/core/trunk/src/tests/antunit/taskdefs/optional/junit/junit-test.xml?r1=1050993r2=1055099diff_format=h 



-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] release of ant 1.8.2

2011-01-04 Thread Jesse Glick

On 01/04/2011 12:32 PM, Antoine Levy-Lambert wrote:

Can you point me to the changes you did to make ant test the version of the 
source tree?


http://svn.apache.org/viewvc?diff_format=hview=revisionrevision=944377


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] release of ant 1.8.2

2010-12-20 Thread Antoine Levy Lambert
Because of the fact that a single -1 makes the vote result negative, I 
am going this morning to rollback the version number changes which I had 
done in trunk [2], make a new build with the change concerning the JUnit 
task [1], and start a second vote thread.


Regards,

Antoine

On 12/20/10 12:32 AM, Antoine Levy-Lambert wrote:


[1] http://svn.apache.org/viewvc?view=revisionrevision=1050993

[2] http://svn.apache.org/viewvc?view=revisionrevision=1045376


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] release of ant 1.8.2

2010-12-20 Thread Stefan Bodewig
On 2010-12-20, Antoine Levy Lambert wrote:

 Because of the fact that a single -1 makes the vote result negative,

I haven't counted the votes but still want to point out that releases
are majority votes and can't be vetoed.  Since I voted non-+1 on an
IvyDE release a while back it has become important to me that people
know this is not a veto.

 I am going this morning to rollback the version number changes which I
 had done in trunk [2], make a new build with the change concerning the
 JUnit task [1], and start a second vote thread.

Since you've called for the vote you can always cancel and re-run it if
you deem it necessary, of course.

Jesse will certainly know best whether the fix you've applied re-enables
the feature that seems to be broken (haven't checked).

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] release of ant 1.8.2

2010-12-20 Thread Antoine Levy Lambert

On 12/20/10 11:10 AM, Stefan Bodewig wrote:

On 2010-12-20, Antoine Levy Lambert wrote:


Because of the fact that a single -1 makes the vote result negative,

I haven't counted the votes but still want to point out that releases
are majority votes and can't be vetoed.  Since I voted non-+1 on an
IvyDE release a while back it has become important to me that people
know this is not a veto.

Oooh. I did not re-read the bylaws. You are right of course.

I am going this morning to rollback the version number changes which I
had done in trunk [2], make a new build with the change concerning the
JUnit task [1], and start a second vote thread.

Since you've called for the vote you can always cancel and re-run it if
you deem it necessary, of course.
Since I have already rebuilt a new release candidate, I am going to 
cancel and re-run the vote.



Jesse will certainly know best whether the fix you've applied re-enables
the feature that seems to be broken (haven't checked).

Stefan


Regards,

Antoine

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] release of ant 1.8.2

2010-12-19 Thread Gilles Scokart
On 13 December 2010 21:59, Antoine Levy-Lambert anto...@gmx.de wrote:
 Hi,

 as announced I have built a release candidate for Ant 1.8.2.

 This is available for download from http://people.apache.org/~antoine/dist/

 Do you want to release these artefacts as Apache Ant 1.8.2 ?

 Yes [X]

 No []

 Regards,

 Antoine


+1,


Gilles Scokart

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] release of ant 1.8.2

2010-12-19 Thread Antoine Levy-Lambert

Hello Jesse,

I have committed what you suggested - see [1]
However I was not able to reproduce the problem that you mentioned.
Is it possible that you did not put junit-4 on the classpath when 
running the junit 4 style test suite ?
Or else the antunit testscase which I added does not reproduce the 
failure case.


Regards,

Antoine

[1] http://svn.apache.org/viewvc?view=revisionrevision=1050993

On 12/17/2010 4:36 PM, Jesse Glick wrote:

Jesse Glickjesse.glickat  oracle.com  writes:

Cannot add a test for it easily without relying on JDK 5 to build.

Manual test case (retyped by hand so please excuse any typos):

property name=junit.jar location=.../
echo file=T1.javapublic class T1 extends
junit.framework.TestCase {
public void testOK() {}




-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] release of ant 1.8.2

2010-12-17 Thread Antoine Levy-Lambert
On 12/16/10 5:26 PM, Alexander Kurtakov wrote:

 Is there a reason for having org.apache.tools.ant.taskdefs.optional.perforce 
 package in ant-apache-oro.jar?

 Regards,
 Alex


Hello Alexander,

out of the top of my head this would be because the perforce tasks use
oro to parse output from the p4
executable.

Regards,

Antoine

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] release of ant 1.8.2

2010-12-17 Thread Jesse Glick
Jesse Glick jesse.glick at oracle.com writes:
 there seems to be some problem with #34748 not working correctly
 on JUnit 4.x-style @Test's

Found it. In JUnitTask.init, need to add:

addClasspathEntry(/org/apache/tools/ant/taskdefs/optional/junit
/JUnit4TestMethodAdapter.class);

(Can't get my work laptop online just at the moment
or I would commit this to trunk.)

Regression caused by split of ant-junit4.jar. (Cannot add a test for it easily
without relying on JDK 5 to build.) So -1 from me on binaries built without this
fix.


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] release of ant 1.8.2

2010-12-17 Thread Jesse Glick
Jesse Glick jesse.glick at oracle.com writes:
 Cannot add a test for it easily without relying on JDK 5 to build.

Manual test case (retyped by hand so please excuse any typos):

property name=junit.jar location=.../
echo file=T1.javapublic class T1 extends
junit.framework.TestCase {
public void testOK() {}
public void testBad() {throw new RuntimeException(failed);}
}/echo
echo file=T2.javapublic class T2 {
@org.junit.Test public void ok() {}
@org.junit.Test public void bad() {
throw new RuntimeException(failed);}
}/echo
javac srcdir=. destdir=. includes=T1.java,T2.java source=6
classpath=${junit.jar} includeantruntime=false/
junit fork=true printsummary=true
classpath path=.:${junit.jar}/
test name=T1 methods=testOK/
test name=T2 methods=ok/
/junit

Expected: both test suites pass with one method each.
Actual 1.8.2 proposed build: T1 passes with one method;
T2 fails in bad() which is supposed to be skipped.


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] release of ant 1.8.2

2010-12-17 Thread Antoine Levy-Lambert

Hello Jesse,

this sounds like something which can be written as an antunit test.
so it can become part of our test suite.

Regards,

Antoine

On 12/17/2010 4:36 PM, Jesse Glick wrote:

Jesse Glickjesse.glickat  oracle.com  writes:

Cannot add a test for it easily without relying on JDK 5 to build.

Manual test case (retyped by hand so please excuse any typos):

property name=junit.jar location=.../
echo file=T1.javapublic class T1 extends
junit.framework.TestCase {
public void testOK() {}
public void testBad() {throw new RuntimeException(failed);}
}/echo
echo file=T2.javapublic class T2 {
@org.junit.Test public void ok() {}
@org.junit.Test public void bad() {
throw new RuntimeException(failed);}
}/echo
javac srcdir=. destdir=. includes=T1.java,T2.java source=6
classpath=${junit.jar} includeantruntime=false/
junit fork=true printsummary=true
classpath path=.:${junit.jar}/
test name=T1 methods=testOK/
test name=T2 methods=ok/
/junit

Expected: both test suites pass with one method each.
Actual 1.8.2 proposed build: T1 passes with one method;
T2 fails in bad() which is supposed to be skipped.





-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] release of ant 1.8.2

2010-12-16 Thread Antoine Levy-Lambert

On 12/15/2010 10:50 PM, Kevin Jackson wrote:

Hi Antoine,

I'm bootstrapping on Windows XP SP3 behind a proxy that requires
authentication with oracle jdk6 (1.6.22)

compile-tests:

test-jar:

BUILD FAILED
C:\Temp\apache-ant-1.8.2-src\apache-ant-1.8.2\build.xml:986: The following error
  occurred while executing this line:
C:\Temp\apache-ant-1.8.2-src\apache-ant-1.8.2\build.xml:778: We cannot build the
  test jar unless JUnit is present,
   as JUnit is needed to compile the test classes.

Total time: 7 seconds

... Cleaning Up Build Directories

... Done Bootstrapping Ant Distribution
Bootstrap FAILED
C:\Temp\apache-ant-1.8.2-src\apache-ant-1.8.2

Is this an expected issue?
Kevin, I do not know whether this makes sense or not but I have both 
junit-3.8.2.jar and junit-4.8.1.jar in lib/optional when I build ant.
The build file checks the presence of junit.framework.TestCase to set or 
not the property junit.present.


So in fact the error means that junit-3.8.2.jar is not on the classpath 
in your build.

Kev



Antoine


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] release of ant 1.8.2

2010-12-16 Thread Alexander Kurtakov
On 12:25:05 am Monday, December 13, 2010 Antoine Levy-Lambert wrote:
 Hi,
 
 as announced I have built a release candidate for Ant 1.8.2.
 
 This is available for download from http://people.apache.org/~antoine/dist/
 
 Do you want to release these artefacts as Apache Ant 1.8.2 ?
 
 Yes []
 
 No []
 
 Regards,
 
 Antoine

Is there a reason for having org.apache.tools.ant.taskdefs.optional.perforce 
package in ant-apache-oro.jar?

Regards,
Alex

 
 -
 To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
 For additional commands, e-mail: dev-h...@ant.apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] release of ant 1.8.2

2010-12-16 Thread Kevin Jackson
HI Antoine,

 Kevin, I do not know whether this makes sense or not but I have both
 junit-3.8.2.jar and junit-4.8.1.jar in lib/optional when I build ant.
 The build file checks the presence of junit.framework.TestCase to set or not
 the property junit.present.

 So in fact the error means that junit-3.8.2.jar is not on the classpath in
 your build.

I'm building just using the src code provided in the tar.gz provided
with nothing else.  So I guess this is ok *if* we already mention that
junit 3.8 is a requirement to build ant.

I was under the impression that bootstrapping ant should have no
dependencies which is why I raised the issue.

Thanks,
Kev

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] release of ant 1.8.2

2010-12-15 Thread Paul King


After a little more testing, one thing I did notice was an
apparent stricter treatment of property expansion.
With 1.8.1, having an arg to a forked java task like this:

arg value=-DskipFetch=${skipFetch}/

was happily ignored if skipFetch wasn't defined.
With 1.8.2, we now get a failed build with reason:

Property skipFetch was circularly defined.

The fix was to add a default property defn but it seems
like such a behavior change in a minor update release
should warrant an entry in the WHATSNEW at least?

Cheers, Paul.

On 15/12/2010 1:48 PM, Paul King wrote:


No official vote for me but just as feedback, Ant 1.8.2 built
the latest Groovy with no problems and the (albeit humble)
AntBuilder tests all ran fine.

Cheers, Paul.

On 14/12/2010 6:59 AM, Antoine Levy-Lambert wrote:

Hi,

as announced I have built a release candidate for Ant 1.8.2.

This is available for download from http://people.apache.org/~antoine/dist/

Do you want to release these artefacts as Apache Ant 1.8.2 ?

Yes []

No []

Regards,

Antoine

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] release of ant 1.8.2

2010-12-15 Thread Stefan Bodewig
On 2010-12-15, Paul King wrote:

 After a little more testing, one thing I did notice was an
 apparent stricter treatment of property expansion.
 With 1.8.1, having an arg to a forked java task like this:

 arg value=-DskipFetch=${skipFetch}/

 was happily ignored if skipFetch wasn't defined.
 With 1.8.2, we now get a failed build with reason:

 Property skipFetch was circularly defined.

 The fix was to add a default property defn but it seems
 like such a behavior change in a minor update release
 should warrant an entry in the WHATSNEW at least?

I don't think this a conscious change but rather a side effect of a
change somewhere else.  But it must be more complex than that, I don't
get a warning like yours with

project
target name=foo
  echo${x}/echo
/target
/project

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] release of ant 1.8.2

2010-12-15 Thread Paul King


This is probably enough to reproduce it:

project
  target name=foo
java classname=org.apache.tools.ant.launch.Launcher fork=true
  classpath path=${java.class.path}/
  arg value=-Dbar=${bar}/
/java
  /target
/project

Cheers, Paul.

On 15/12/2010 7:55 PM, Stefan Bodewig wrote:

On 2010-12-15, Paul King wrote:


After a little more testing, one thing I did notice was an
apparent stricter treatment of property expansion.
With 1.8.1, having an arg to a forked java task like this:



arg value=-DskipFetch=${skipFetch}/



was happily ignored if skipFetch wasn't defined.
With 1.8.2, we now get a failed build with reason:



Property skipFetch was circularly defined.



The fix was to add a default property defn but it seems
like such a behavior change in a minor update release
should warrant an entry in the WHATSNEW at least?


I don't think this a conscious change but rather a side effect of a
change somewhere else.  But it must be more complex than that, I don't
get a warning like yours with

project
 target name=foo
   echo${x}/echo
 /target
/project

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] release of ant 1.8.2

2010-12-15 Thread Stefan Bodewig
On 2010-12-15, Paul King wrote:

 This is probably enough to reproduce it:

Yes, it is, thank you Paul.

 project
   target name=foo
 java classname=org.apache.tools.ant.launch.Launcher fork=true
   classpath path=${java.class.path}/
   arg value=-Dbar=${bar}/
 /java
   /target
 /project

The error message is created by the forked Ant process, not the one
executing the build file.  You would see the same if you used

ant -Dbar=${bar}

(with proper shell escaping in place, that is).  Properties specified on
the command line via -D and -propertyfile can now use other properties
in their values.  Prior to Ant 1.8.2 they were not expanded.

What you see really is a border case that only happens because you use
the same property name in your build file and the property use pass to
the forked Ant process.

I'm not even sure how to document the situation 8-)

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] release of ant 1.8.2

2010-12-15 Thread Paul King

On 15/12/2010 10:55 PM, Stefan Bodewig wrote:

On 2010-12-15, Paul King wrote:


This is probably enough to reproduce it:


Yes, it is, thank you Paul.


project
   target name=foo
 java classname=org.apache.tools.ant.launch.Launcher fork=true
   classpath path=${java.class.path}/
   arg value=-Dbar=${bar}/
 /java
   /target
/project


The error message is created by the forked Ant process, not the one
executing the build file.  You would see the same if you used

ant -Dbar=${bar}

(with proper shell escaping in place, that is).  Properties specified on
the command line via -D and -propertyfile can now use other properties
in their values.  Prior to Ant 1.8.2 they were not expanded.

What you see really is a border case that only happens because you use
the same property name in your build file and the property use pass to
the forked Ant process.

I'm not even sure how to document the situation 8-)


Yes, I guess it is a bit unusual. We were running into memory problems so
our build calls back to itself for just one target with a cut down set of
properties. In any case, it sounds like the change isn't too wide spread.
So maybe not release-note worthy after all.

Thanks for the new release.

Cheers, Paul.

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] release of ant 1.8.2

2010-12-15 Thread Kevin Jackson
Hi Antoine,

I'm bootstrapping on Windows XP SP3 behind a proxy that requires
authentication with oracle jdk6 (1.6.22)

compile-tests:

test-jar:

BUILD FAILED
C:\Temp\apache-ant-1.8.2-src\apache-ant-1.8.2\build.xml:986: The following error
 occurred while executing this line:
C:\Temp\apache-ant-1.8.2-src\apache-ant-1.8.2\build.xml:778: We cannot build the
 test jar unless JUnit is present,
  as JUnit is needed to compile the test classes.

Total time: 7 seconds

... Cleaning Up Build Directories

... Done Bootstrapping Ant Distribution
Bootstrap FAILED
C:\Temp\apache-ant-1.8.2-src\apache-ant-1.8.2

Is this an expected issue?

Kev

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] release of ant 1.8.2

2010-12-14 Thread Maarten Coene
+1

I did try it on our build servers without any problem.

Maarten



- Original Message 
From: Antoine Levy-Lambert anto...@gmx.de
To: Ant Developers List dev@ant.apache.org
Sent: Mon, December 13, 2010 9:59:52 PM
Subject: [VOTE] release of ant  1.8.2

Hi,

as announced I have built a release candidate for Ant 1.8.2.

This is available for download from http://people.apache.org/~antoine/dist/

Do you want to release these artefacts as Apache Ant 1.8.2 ?

Yes []

No []

Regards,

Antoine

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org


  

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] release of ant 1.8.2

2010-12-14 Thread Maarten Coene
Btw, the release notes are displayed empty, although the content is not.
http://people.apache.org/~antoine/dist/RELEASE-NOTES-apache-ant-1.8.2.html

I've tried this with both IE and firefox.
I suspect the syntax error on line 2 causes this (non-closing title tag).

Maarten




- Original Message 
From: Maarten Coene maarten_co...@yahoo.com
To: Ant Developers List dev@ant.apache.org
Sent: Tue, December 14, 2010 1:25:42 PM
Subject: Re: [VOTE] release of ant  1.8.2

+1

I did try it on our build servers without any problem.

Maarten



- Original Message 
From: Antoine Levy-Lambert anto...@gmx.de
To: Ant Developers List dev@ant.apache.org
Sent: Mon, December 13, 2010 9:59:52 PM
Subject: [VOTE] release of ant  1.8.2

Hi,

as announced I have built a release candidate for Ant 1.8.2.

This is available for download from http://people.apache.org/~antoine/dist/

Do you want to release these artefacts as Apache Ant 1.8.2 ?

Yes []

No []

Regards,

Antoine

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org


  

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org


  

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] release of ant 1.8.2

2010-12-14 Thread Antoine Levy-Lambert

On 12/14/2010 9:36 AM, Maarten Coene wrote:

Btw, the release notes are displayed empty, although the content is not.
http://people.apache.org/~antoine/dist/RELEASE-NOTES-apache-ant-1.8.2.html

I've tried this with both IE and firefox.
I suspect the syntax error on line 2 causes this (non-closingtitle  tag).


Thanks Maarten, I have fixed it.

Antoine

Maarten






-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] release of ant 1.8.2

2010-12-14 Thread Nicolas Lalevée

Le 13 déc. 2010 à 21:59, Antoine Levy-Lambert a écrit :

 Hi,
 
 as announced I have built a release candidate for Ant 1.8.2.
 
 This is available for download from http://people.apache.org/~antoine/dist/
 
 Do you want to release these artefacts as Apache Ant 1.8.2 ?
 
 Yes [X]
 
 No []

+1

works like a charm.

Nicolas


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] release of ant 1.8.2

2010-12-14 Thread Jesse Glick

On 12/13/2010 03:59 PM, Antoine Levy-Lambert wrote:

http://people.apache.org/~antoine/dist/


Built big chunks of NetBeans sources without problems. Generally seems to be 
working embedded on various scripts.

But there seems to be some problem with #34748 not working correctly on JUnit 4.x-style @Test's which I have not yet tracked down (this works under 1.8.1 with a binary 
patch from the #34748 branch). I'm mostly on holiday now, may not be able to get to the bottom of this before the new year. So far I know that JUnitTestRunner is being 
called with 'methods' as expected, but runs all the test methods anyway:


import org.junit.Test;
public class SomeTest {
@Test public void a() {}
@Test public void b() {}
}

Execute:Java13CommandLauncher: Executing '.../jdk1.6.0_22/bin/java' with 
arguments:
'-ea'
'-classpath'
'...:.../junit-4.8.2.jar:.../ant-launcher.jar:.../ant.jar:.../ant-junit.jar'
'org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner'
'SomeTest'
'methods=a'
'filtertrace=true'
'haltOnError=false'
'haltOnFailure=false'
'showoutput=true'
'outputtoformatters=true'
'logfailedtests=true'
'logtestlistenerevents=true'
'formatter=org.apache.tools.ant.taskdefs.optional.junit.BriefJUnitResultFormatter'
'formatter=org.apache.tools.ant.taskdefs.optional.junit.XMLJUnitResultFormatter,/tmp/TEST-SomeTest.xml'
'crashfile=...'
'propsfile=...'
The ' characters around the executable and arguments are
not part of the command.
Testsuite: SomeTest
junit.framework.TestListener: tests to run: 2
junit.framework.TestListener: startTest(b)
junit.framework.TestListener: endTest(b)
junit.framework.TestListener: startTest(a)
junit.framework.TestListener: endTest(a)
Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0.05 sec


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] release of ant 1.8.2

2010-12-14 Thread Kevin Jackson
Hi,

On Tue, Dec 14, 2010 at 3:59 AM, Antoine Levy-Lambert anto...@gmx.de wrote:
 Hi,

 as announced I have built a release candidate for Ant 1.8.2.

 This is available for download from http://people.apache.org/~antoine/dist/

I'll try to test on both debian squeeze and windows over the next
couple of days...

Kev

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] release of ant 1.8.2

2010-12-14 Thread Paul King


No official vote for me but just as feedback, Ant 1.8.2 built
the latest Groovy with no problems and the (albeit humble)
AntBuilder tests all ran fine.

Cheers, Paul.

On 14/12/2010 6:59 AM, Antoine Levy-Lambert wrote:

Hi,

as announced I have built a release candidate for Ant 1.8.2.

This is available for download from http://people.apache.org/~antoine/dist/

Do you want to release these artefacts as Apache Ant 1.8.2 ?

Yes []

No []

Regards,

Antoine

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: [VOTE] release of ant 1.8.2

2010-12-14 Thread Stefan Bodewig
On 2010-12-13, Antoine Levy-Lambert wrote:

 as announced I have built a release candidate for Ant 1.8.2.

 This is available for download from http://people.apache.org/~antoine/dist/

 Do you want to release these artefacts as Apache Ant 1.8.2 ?

 Yes [X]

 No []

+1

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org