Re: [DISCUSS] Stream Pipelines on hot paths

2024-06-02 Thread Enrico Olivelli
+1 (from the peanuts gallery)

Removing streams from anything that looks like an hot path is indeed a good
thing.

Please balance with 'don't fix things that aren't broken'.

While doing such changes seems a great idea, sometimes it may have side
effects that you don't see until you run on real datasets.

Enrico


Il Dom 2 Giu 2024, 19:38 J. D. Jordan  ha
scritto:

> +1 agree with all this.  Also fine to just use in tests or ban completely.
>
> On Jun 2, 2024, at 11:58 AM, Jake Luciani  wrote:
>
> 
>
> +1 Java streams cause perf issues in hot paths. Its fine for tests and
> slow paths. But for clairity its fine to ban it as well if the majority
> agrees.
>
>
> On Sun, Jun 2, 2024 at 12:34 PM Sam  wrote:
>
>> I completely agree with this. I suspect there is a lot of low-hanging
>> fruit with easy perf wins.
>>
>> On profiling a 90% write workload I found
>> StorageProxy::updateCoordinatorWriteLatencyTableMetric to be a hot-path,
>> consuming between 15-20% of ModificationStatement::executeWithoutCondition
>> cycles.
>>
>> https://github.com/apache/cassandra/pull/3344
>> 
>>
>>
>> On Fri, 31 May 2024 at 21:19, Jacek Lewandowski <
>> lewandowski.ja...@gmail.com> wrote:
>>
>>> Usages of them in tests are ok I think. We have a separate checkstyle
>>> file for the test code.
>>>
>>> - - -- --- -  -
>>> Jacek Lewandowski
>>>
>>>
>>> pt., 31 maj 2024 o 19:14 David Capwell  napisał(a):
>>>
 I am cool for forbidding with a callout that tests are ok.  I am cool
 with forbidding in tests as well, but thats just for consistency reasons
 than anything.

 On May 31, 2024, at 8:12 AM, Brandon Williams  wrote:


 On Fri, May 31, 2024 at 9:35 AM Abe Ratnofsky  wrote:

> +1 to forbidding Stream usage entirely; the convenience of using them
> outside of hot paths is less than the burden of figuring out whether or 
> not
> a particular path is hot.
>

 I think I have most frequently appreciated them in tests, which I think
 we could except, since these are categorically not in the hot path.

 Kind Regards,
 Brandon






Re: [DISCUSS] Java support roadmap

2021-08-27 Thread Enrico Olivelli
(sorry if being slightly off-topic, but let be throw this ball here)

What about joining the OpenJDK Quality outreach program?
https://wiki.openjdk.java.net/display/quality/Quality+Outreach

Many other Apache projects contribute to that initiative and this helps
Java to be always compatible with the most important libraries in the OSS
world

Just my two cents
Enrico

Il giorno ven 27 ago 2021 alle ore 10:17 Benjamin Lerer 
ha scritto:

> +1 on my side too for removal of experimental for 11, and moving trunk to
> 11+17
>
>
> Le jeu. 26 août 2021 à 22:28, Nate McCall  a écrit :
>
> > >
> > >
> > > Last but not least, do we know  anyone running Java 11 in production?
> > > This thread was really opened as a stage to share our thoughts and
> > > hopefully come up with a plan as a community.
> > >
> >
> > I am aware of many large deployments using Java11 and 4.0 in production.
> +1
> > on making this non experimental. Happy to have us push forward with newer
> > versions as well.
> >
> > Thanks for bringing it up, Ekaterina!
> >
> > -Nate
> >
>


Re: [VOTE] Release Apache Cassandra 4.0.0 (take2)

2021-07-15 Thread Enrico Olivelli
+1

- Run all tests with CDC
- Verified checksums and digital signatures

Enrico

Il giorno gio 15 lug 2021 alle ore 16:59 Branimir Lambov <
branimir.lam...@datastax.com> ha scritto:

> +1
>
> On Thu, Jul 15, 2021 at 12:55 AM Scott Andreas 
> wrote:
>
> > +1nb.
> >
> > Thank you for sharing a Circle run, Sumanth!
> >
> > 
> > From: Sumanth Pasupuleti 
> > Sent: Wednesday, July 14, 2021 12:52 PM
> > To: dev@cassandra.apache.org
> > Subject: Re: [VOTE] Release Apache Cassandra 4.0.0 (take2)
> >
> > +1 (nb)
> > Confirmed passing j8 UTs and dtests
> >
> >
> https://app.circleci.com/pipelines/github/sumanth-pasupuleti/cassandra/77/workflows/7b0ad00d-7ae3-41d2-b1a7-82fa63b7
> >
> > On Wed, Jul 14, 2021 at 11:03 AM Jeremy Hanna <
> jeremy.hanna1...@gmail.com>
> > wrote:
> >
> > > +1 (nb)
> > >
> > > > On Jul 15, 2021, at 3:42 AM, Blake Eggleston
> > >  wrote:
> > > >
> > > > +1
> > > >
> > > >> On Jul 14, 2021, at 8:21 AM, Aleksey Yeschenko 
> > > wrote:
> > > >>
> > > >> +1
> > > >>
> > >  On 14 Jul 2021, at 15:37, Jonathan Ellis 
> wrote:
> > > >>>
> > > >>> +1
> > > >>>
> > >  On Tue, Jul 13, 2021 at 5:14 PM Mick Semb Wever 
> > > wrote:
> > > 
> > >  Proposing the test build of Cassandra 4.0.0 for release.
> > > 
> > >  sha1: 924bf92fab1820942137138c779004acaf834187
> > >  Git:
> > > 
> > >
> >
> https://gitbox.apache.org/repos/asf?p=cassandra.git;a=shortlog;h=refs/tags/4.0.0-tentative
> > >  Maven Artifacts:
> > > 
> > > 
> > >
> >
> https://repository.apache.org/content/repositories/orgapachecassandra-1242/org/apache/cassandra/cassandra-all/4.0.0/
> > > 
> > >  The Source and Build Artifacts, and the Debian and RPM packages
> and
> > >  repositories, are available here:
> > >  https://dist.apache.org/repos/dist/dev/cassandra/4.0.0/
> > > 
> > >  The vote will be open for 72 hours (longer if needed). Everyone
> who
> > >  has tested the build is invited to vote. Votes by PMC members are
> > >  considered binding. A vote passes if there are at least three
> > binding
> > >  +1s and no -1's.
> > > 
> > >  [1]: CHANGES.txt:
> > > 
> > > 
> > >
> >
> https://gitbox.apache.org/repos/asf?p=cassandra.git;a=blob_plain;f=CHANGES.txt;hb=refs/tags/4.0.0-tentative
> > >  [2]: NEWS.txt:
> > > 
> > >
> >
> https://gitbox.apache.org/repos/asf?p=cassandra.git;a=blob_plain;f=NEWS.txt;hb=refs/tags/4.0.0-tentative
> > > 
> > > 
> > -
> > >  To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
> > >  For additional commands, e-mail: dev-h...@cassandra.apache.org
> > > 
> > > 
> > > >>>
> > > >>> --
> > > >>> Jonathan Ellis
> > > >>> co-founder, http://www.datastax.com
> > > >>> @spyced
> > > >>
> > > >>
> > > >>
> -
> > > >> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
> > > >> For additional commands, e-mail: dev-h...@cassandra.apache.org
> > > >>
> > > >
> > > > -
> > > > To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
> > > > For additional commands, e-mail: dev-h...@cassandra.apache.org
> > > >
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
> > > For additional commands, e-mail: dev-h...@cassandra.apache.org
> > >
> > >
> >
>
>
> --
> Branimir Lambov
> e. branimir.lam...@datastax.com
> w. www.datastax.com
>