[GitHub] commons-text pull request #85: Add optimization to limited levenshtein dista...
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/85#discussion_r202562835
--- Diff:
src/main/java/org/apache/commons/text/similarity/LevenshteinDistance.java ---
@@ -270,12 +270,6 @@ private static int limitedCompare(CharSequence left,
CharSequence right, final i
final int max = j > Integer.MAX_VALUE - threshold ? n :
Math.min(
n, j + threshold);
-// the stripe may lead off of the table if s and t are of
different
-// sizes
-if (min > max) {
--- End diff --
I'll try to give this a look in the morning (UTC-4), and many thanks for
the contribution.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #83: (doc) Typo: 'RandomStringBuilder' -> 'RandomStringGe...
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/83 Looks good to me. Many thanks for the contribution. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #73: TEXT-106: Exception thrown in ExtendedMessageFormat ...
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/73 This feels like it should come in before I stage `commons-test-1.2`. Thoughts? --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #71: Apply (relaxed) checkstyle rules to test and fix exi...
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/71 Agreed. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #68: TEXT-74 Introduced new StrSubstitutor attribute to d...
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/68 Do we want it to be off by default? --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #68: TEXT-74 Introduced new StrSubstitutor attribute to d...
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/68 Seems reasonable to me. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #62: TEXT-101: Moved RandomStringUtils to Commons-text
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/62 @britter, @PascalSchumacher, @garydgregory - thoughts? --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #64: Minor JavaDoc change for deprecated isDelimiter
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/64 @arunvinudss - would you vote for removing it if we were to roll a, very hypothetical, 2.0 right now? If so, then I'd say we have our decision. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #62: TEXT-101: Moved RandomStringUtils to Commons-text
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/62 As I'm pulling this in this crosses my mind: Wait I'm curious here. Weren't folks leaning towards keeping `RandomStringUtils` in `[lang]`? The thread in question is this one: http://markmail.org/message/5tblwhldrwsbfdym It feels like @britter, @PascalSchumacher, and @garydgregory were all leaning towards the `[lang]` option. If that's the case we should probably go with that. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #62: TEXT-101: Moved RandomStringUtils to Commons-text
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/62 Should be able to look again today. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #62: TEXT-101: Moved RandomStringUtils to Commons-...
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/62#discussion_r140835603
--- Diff: src/main/java/org/apache/commons/text/RandomStringGenerator.java
---
@@ -324,6 +324,40 @@ public Builder withinRange(final int minimumCodePoint,
final int maximumCodePoin
/**
*
+ * Specifies the array of minimum and maximum char allowed in the
+ * generated string.
+ *
+ *
+ * For example:
+ *
+ * {@code
+ * char [][] pairs = {{'0','9'}};
+ * char [][] pairs = {{'a','z'}};
+ * char [][] pairs = {{'a','z'},{'0','9'}};
+ * }
+ *
+ *
+ * @param pairs array of charachters array, expected is to pass
min, max pairs through this arg.
+ * @return {@code this}, to allow method chaining.
+ */
+public Builder withinRange(final char[] ... pairs) {
+characterList = new ArrayList();
+for (char[] pair : pairs) {
+final int minimumCodePoint = pair[0];
+final int maximumCodePoint = pair[1];
--- End diff --
Do we want validation on the definition of a `pair` here? Do we want to
throw an `InvalidParameterException` in this fashion:
```java
for(char[] pair: pairs) {
if (pair.length != 2) {
throw new InvalidParameterException("A char[] pair should look
like {'', ''}");
}
}
I'm not sure. I could go either way. Thoughts?
```
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #16: added findbug and checkstyle support while building
Github user chtompki commented on the issue: https://github.com/apache/commons-cli/pull/16 Oh pardon. I misread. Iâll re-run through it. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #16: added findbug and checkstyle support while building
Github user chtompki commented on the issue: https://github.com/apache/commons-cli/pull/16 Oh pardon. I misread. Iâll re-run through it. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #62: TEXT-101: Moved RandomStringUtils to Commons-text
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/62 Sure I'll get to this next. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #63: small-code-quality-improvements
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/63 That last build failure wasn't on youjust fixed it in the master branch. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #63: small-code-quality-improvements
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/63#discussion_r140545049
--- Diff: src/main/java/org/apache/commons/text/WordUtils.java ---
@@ -614,10 +614,7 @@ public static String swapCase(final String str) {
for (int index = 0; index < strLen;) {
final int oldCodepoint = str.codePointAt(index);
final int newCodePoint;
-if (Character.isUpperCase(oldCodepoint)) {
-newCodePoint = Character.toLowerCase(oldCodepoint);
-whitespace = false;
-} else if (Character.isTitleCase(oldCodepoint)) {
+if (Character.isUpperCase(oldCodepoint) ||
Character.isTitleCase(oldCodepoint) ) {
--- End diff --
Checkstyle want's to see this as
```java
if (Character.isUpperCase(oldCodepoint) ||
Character.isTitleCase(oldCodepoint)) {
```
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #55: TEXT-97: RandomStringGenerator able to pass multiple...
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/55 Pardon...I don't see why this would necessitate a 2.X. Let me re-read. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #55: TEXT-97: RandomStringGenerator able to pass multiple...
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/55 Are we ready to do a change that would necessitate a 2.X? --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #61: Added flexible Travis-ci build script.
Github user chtompki commented on a diff in the pull request: https://github.com/apache/commons-text/pull/61#discussion_r130979086 --- Diff: pom.xml --- @@ -171,6 +171,7 @@ src/site/resources/download_lang.cgi src/test/resources/stringEscapeUtilsTestData.txt src/site/resources/release-notes/RELEASE-NOTES-*.txt + .travis.sh --- End diff -- It looks like, with a quick read of their License.md, that we would minimally need to include their license at the end of ours, but I would have to defer to others for that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #61: Added flexible Travis-ci build script.
Github user chtompki commented on a diff in the pull request: https://github.com/apache/commons-text/pull/61#discussion_r130977723 --- Diff: pom.xml --- @@ -171,6 +171,7 @@ src/site/resources/download_lang.cgi src/test/resources/stringEscapeUtilsTestData.txt src/site/resources/release-notes/RELEASE-NOTES-*.txt + .travis.sh --- End diff -- You could put an Apache License comment at the top of this file because it accommodates comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #61: Added flexible Travis-ci build script.
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/61 Personally I'm a +0 to +1 on this, but @PascalSchumacher has a very valid point. I try to subscribe to the thought that there should be a high bar to sacrificing simplicity. So, with that in mind, should we take this up to the dev list to get other folks opinions? That work for you guys? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #61: Added flexible Travis-ci build script.
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/61 I'll get to this soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #57: TEXT-98: Remove isDelimiter and use HashSets for del...
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/57 Will get to this today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #15: CLI-217: Optional partial matching
Github user chtompki commented on the issue: https://github.com/apache/commons-cli/pull/15 Agreed, pardon my misread. Pulling this in now...only considering documentation on partial matching. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #15: CLI-217: Optional partial matching
Github user chtompki commented on the issue: https://github.com/apache/commons-cli/pull/15 Agreed, pardon my misread. Pulling this in now...only considering documentation on partial matching. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #15: CLI-217: Optional partial matching
Github user chtompki commented on the issue: https://github.com/apache/commons-cli/pull/15 Upon reading [CLI-216](https://issues.apache.org/jira/browse/CLI-216) and [CLI-217](https://issues.apache.org/jira/browse/CLI-217), this pull request looks like it resolves CLI-216 and not CLI-217. I might be missing something. @rubin55 - I'm definitely on board with this change. I just want to document it appropriately. Thoughts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #15: CLI-217: Optional partial matching
Github user chtompki commented on the issue: https://github.com/apache/commons-cli/pull/15 Upon reading [CLI-216](https://issues.apache.org/jira/browse/CLI-216) and [CLI-217](https://issues.apache.org/jira/browse/CLI-217), this pull request looks like it resolves CLI-216 and not CLI-217. I might be missing something. @rubin55 - I'm definitely on board with this change. I just want to document it appropriately. Thoughts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #15: CLI-217: Optional partial matching
Github user chtompki commented on the issue: https://github.com/apache/commons-cli/pull/15 Working on this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #15: CLI-217: Optional partial matching
Github user chtompki commented on the issue: https://github.com/apache/commons-cli/pull/15 Working on this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #59: add oraclejdk9 to travis configuration
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/59 Get a load of this: https://github.com/jacoco/jacoco/blob/master/.travis.sh https://github.com/jacoco/jacoco/blob/master/.travis.yml --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #15: CLI-217: Optional partial matching
Github user chtompki commented on the issue: https://github.com/apache/commons-cli/pull/15 I'll try to get to it today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #15: CLI-217: Optional partial matching
Github user chtompki commented on the issue: https://github.com/apache/commons-cli/pull/15 I'll try to get to it today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections issue #9: COLLECTIONS-551
Github user chtompki commented on the issue: https://github.com/apache/commons-collections/pull/9 Ok no stress. I'll try to see what I can do with it. Cheers, -Rob. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #57: TEXT-98: Remove isDelimiter and use HashSets for del...
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/57 This all opens the question about going `2.x`. I think we have a couple of things that would warrant a 2.x move. Do we want to attempt that in the fall, or is it still too premature? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #49: TEXT-89: WordUtils.initials support for UTF-16 surro...
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/49 Cool. Will look at this in just a bit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections pull request #24: add-some-Unit-Tests Added some Unit Te...
Github user chtompki commented on a diff in the pull request: https://github.com/apache/commons-collections/pull/24#discussion_r127966801 --- Diff: src/test/java/org/apache/commons/collections4/iterators/CollatingIteratorTest.java --- @@ -16,12 +16,14 @@ */ package org.apache.commons.collections4.iterators; -import java.util.ArrayList; -import java.util.Arrays; -import java.util.Comparator; -import java.util.List; - import org.apache.commons.collections4.comparators.ComparableComparator; +import org.junit.Test; + +import java.lang.reflect.Array; +import java.util.*; --- End diff -- This looks like you're using IntelliJ with the default settings. I've had to disable the change to `import package.name.*` for 5 or more from the same location. I would try to turn that off. Further it may not run on save as some folks suggested in https://github.com/apache/commons-text/pull/56 I think it runs when you do a file format command or "reorganize imports" command. Regardless I'll try to change it back. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections issue #5: gitignore and CollectionUtils improvements
Github user chtompki commented on the issue: https://github.com/apache/commons-collections/pull/5 @huseyincelik - Do you mind rebasing this work onto the `master` branch and opening a new pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections issue #9: COLLECTIONS-551
Github user chtompki commented on the issue: https://github.com/apache/commons-collections/pull/9 @gonmarques - Do you mind rebasing this work onto the `master` branch and opening a new pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections issue #10: Add CollectionUtils#containsQuietly method an...
Github user chtompki commented on the issue: https://github.com/apache/commons-collections/pull/10 @AndersDJohnson - Do you mind rebasing this work on the `master` branch and opening a new pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections issue #13: [COLLECTIONS-574] Improve ListUtils#longestCo...
Github user chtompki commented on the issue: https://github.com/apache/commons-collections/pull/13 @kaching88 - Do you mind rebasing to the `master` branch and re-opening this pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections issue #15: Allow minus index
Github user chtompki commented on the issue: https://github.com/apache/commons-collections/pull/15 @lamrongol - Do you mind rebasing to the `master` branch, and re-opening this pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections issue #18: COLLECTIONS-586 PatriciaTrie prefixMap clear ...
Github user chtompki commented on the issue: https://github.com/apache/commons-collections/pull/18 @marko-bekhta - Do you mind rebasing to the `master` branch, and re-opening this pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections issue #19: COLLECTIONS-575: Add synchronized queue wrapp...
Github user chtompki commented on the issue: https://github.com/apache/commons-collections/pull/19 @Xaerxess - As posted in the [Jira Issue](https://issues.apache.org/jira/browse/COLLECTIONS-575), do you mind rebasing to master and re-opening this pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections issue #21: Add VI[M] temporary files to .gitignore
Github user chtompki commented on the issue: https://github.com/apache/commons-collections/pull/21 @mureinik - Do you mind rebasing to master and re-opening this pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections issue #22: [COLLECTIONS-600] Null-safe implementation of...
Github user chtompki commented on the issue: https://github.com/apache/commons-collections/pull/22 @jonasholtkamp - Do you mind rebasing to master and re-opening this pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections issue #3: Added MultiValuedLinkedHashMap to preserve ins...
Github user chtompki commented on the issue: https://github.com/apache/commons-collections/pull/3 @geoffschoeman - Do you mind rebasing to master and re-opening this pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections issue #12: [COLLECTIONS-573] Add CollectionUtils#deepMer...
Github user chtompki commented on the issue: https://github.com/apache/commons-collections/pull/12 Do you mind rebasing to master and re-opening this pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections issue #24: add-some-Unit-Tests Added some Unit Tests to ...
Github user chtompki commented on the issue: https://github.com/apache/commons-collections/pull/24 Actually that's not true today. It's a side effect of my moving collections to git, but I will look at this and try to pull it in tomorrow morning (UTC-4). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #15: CLI-217: Optional partial matching
Github user chtompki commented on the issue: https://github.com/apache/commons-cli/pull/15 Looking at [CLI-217.patch](https://issues.apache.org/jira/secure/attachment/12568952/CLI-217.patch), I was wondering if we shouldn't also include changes to `PosixParser`? The changes would be at https://github.com/apache/commons-cli/blob/master/src/main/java/org/apache/commons/cli/PosixParser.java#L127 and https://github.com/apache/commons-cli/blob/master/src/main/java/org/apache/commons/cli/PosixParser.java#L134 based on the bottom of that patch file. No worries if there is a distinct reason for not including those, just curious if you saw that in the patch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #15: CLI-217: Optional partial matching
Github user chtompki commented on the issue: https://github.com/apache/commons-cli/pull/15 Looking at [CLI-217.patch](https://issues.apache.org/jira/secure/attachment/12568952/CLI-217.patch), I was wondering if we shouldn't also include changes to `PosixParser`? The changes would be at https://github.com/apache/commons-cli/blob/master/src/main/java/org/apache/commons/cli/PosixParser.java#L127 and https://github.com/apache/commons-cli/blob/master/src/main/java/org/apache/commons/cli/PosixParser.java#L134 based on the bottom of that patch file. No worries if there is a distinct reason for not including those, just curious if you saw that in the patch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #15: CLI-217: Optional partial matching
Github user chtompki commented on the issue: https://github.com/apache/commons-cli/pull/15 Yes aside from the `.gitignore` changes, this all looks quite reasonable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #15: CLI-217: Optional partial matching
Github user chtompki commented on the issue: https://github.com/apache/commons-cli/pull/15 Yes aside from the `.gitignore` changes, this all looks quite reasonable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #55: TEXT-97: RandomStringGenerator able to pass multiple...
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/55 @jbduncan has a point here, but the code here does conform to the style of the existing code. So, I'd lean more towards the changes @ameyjadiye is proposing mainly because to re-work the code into a static `builder()` method pattern would require changes that would necessitate a major version change. We could, though, revisit this in the 2.X version if you with @jbduncan. Thoughts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #55: TEXT-97: RandomStringGenerator able to pass multiple...
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/55 Sure...I'll try to look at this in the coming day or so. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #48: TEXT-88: Fixed issue with empty delimiters array wit...
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/48 Should we add to `public static boolean isDelimiter(final char ch, final char[] delimiters)` or `isDelimiter` generally, documentation stating that if an empty array is passed in we always return false? I'm torn on this. What are your thoughts @ameyjadiye? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli pull request #15: CLI-217: Optional partial matching
Github user chtompki commented on a diff in the pull request: https://github.com/apache/commons-cli/pull/15#discussion_r125656068 --- Diff: .gitignore --- @@ -1,5 +1,4 @@ -### https://raw.github.com/github/gitignore/f2ce448f2ba7a092da05482ceca99209127c0884/maven.gitignore - +# maven --- End diff -- Ha...pardon...wrong project. Nevermind about the copy bit. @britter just promoted CLI to git. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli pull request #15: CLI-217: Optional partial matching
Github user chtompki commented on a diff in the pull request: https://github.com/apache/commons-cli/pull/15#discussion_r125656068 --- Diff: .gitignore --- @@ -1,5 +1,4 @@ -### https://raw.github.com/github/gitignore/f2ce448f2ba7a092da05482ceca99209127c0884/maven.gitignore - +# maven --- End diff -- Ha...pardon...wrong project. Nevermind about the copy bit. @britter just promoted CLI to git. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli pull request #15: CLI-217: Optional partial matching
Github user chtompki commented on a diff in the pull request: https://github.com/apache/commons-cli/pull/15#discussion_r125655784 --- Diff: .gitignore --- @@ -1,5 +1,4 @@ -### https://raw.github.com/github/gitignore/f2ce448f2ba7a092da05482ceca99209127c0884/maven.gitignore - +# maven --- End diff -- Nah...I'll work around it...plus it's a change to an SVN project, so I've got to copy in your changes. That reminds me, maybe I'll take collections and promote it to being a git repo in the apache infrastructure. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli pull request #15: CLI-217: Optional partial matching
Github user chtompki commented on a diff in the pull request: https://github.com/apache/commons-cli/pull/15#discussion_r125655784 --- Diff: .gitignore --- @@ -1,5 +1,4 @@ -### https://raw.github.com/github/gitignore/f2ce448f2ba7a092da05482ceca99209127c0884/maven.gitignore - +# maven --- End diff -- Nah...I'll work around it...plus it's a change to an SVN project, so I've got to copy in your changes. That reminds me, maybe I'll take collections and promote it to being a git repo in the apache infrastructure. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli pull request #15: CLI-217: Optional partial matching
Github user chtompki commented on a diff in the pull request: https://github.com/apache/commons-cli/pull/15#discussion_r125636671 --- Diff: .gitignore --- @@ -1,5 +1,4 @@ -### https://raw.github.com/github/gitignore/f2ce448f2ba7a092da05482ceca99209127c0884/maven.gitignore - +# maven --- End diff -- I'm not sure we want to change the `.gitignore` file. I would think these entries would be in one's global `.gitignore` file as the project itself does not generate these files --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli pull request #15: CLI-217: Optional partial matching
Github user chtompki commented on a diff in the pull request: https://github.com/apache/commons-cli/pull/15#discussion_r125636671 --- Diff: .gitignore --- @@ -1,5 +1,4 @@ -### https://raw.github.com/github/gitignore/f2ce448f2ba7a092da05482ceca99209127c0884/maven.gitignore - +# maven --- End diff -- I'm not sure we want to change the `.gitignore` file. I would think these entries would be in one's global `.gitignore` file as the project itself does not generate these files --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/52 Thanks Amey. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/52 Agreed with Pascal here, just for semantics on commit history. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #14: Added BugCLI260 JUnit Test
Github user chtompki commented on the issue: https://github.com/apache/commons-cli/pull/14 No worries at all. While here, what are your thoughts about that scenario? To me it seems odd if you concatenated a flag with the value it represents. Clearly Java delimits arguments passed into a "public static void main" with spaces, so in my mind the ticket could be marked as won't fix and you're tests are still quite valid. Curious what your thoughts are. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #14: Added BugCLI260 JUnit Test
Github user chtompki commented on the issue: https://github.com/apache/commons-cli/pull/14 No worries at all. While here, what are your thoughts about that scenario? To me it seems odd if you concatenated a flag with the value it represents. Clearly Java delimits arguments passed into a "public static void main" with spaces, so in my mind the ticket could be marked as won't fix and you're tests are still quite valid. Curious what your thoughts are. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #46: TEXT-85:Added CaseUtils class with camel case conver...
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/46 Will try to get to this today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #14: Added BugCLI260 JUnit Test
Github user chtompki commented on the issue:
https://github.com/apache/commons-cli/pull/14
My impression base on my reading of the
[CLI-260](https://issues.apache.org/jira/browse/CLI-260) is that from this code:
```java
private DefaultParser parser;
private Options options;
@Before
public void setUp()
{
parser = new DefaultParser();
options = new Options()
.addOption("a", "enable-a", false, "turn [a] on or off")
.addOption("b", "bfile", true, "set the value of [b]")
.addOption("c", "copt", false, "turn [c] on or off")
.addOption("k", "kopt", true, "set value of k");
}
@Test
public void testProblem() throws Exception
{
String[] args = new String[] {"-k'option=value'"};
CommandLine cl = parser.parse(options, args);
String temp = "temp";
}
```
we get this exception:
```
org.apache.commons.cli.UnrecognizedOptionException: Unrecognized option:
-k'option=value'
at
org.apache.commons.cli.DefaultParser.handleUnknownToken(DefaultParser.java:359)
at
org.apache.commons.cli.DefaultParser.handleLongOptionWithEqual(DefaultParser.java:439)
at
org.apache.commons.cli.DefaultParser.handleShortAndLongOption(DefaultParser.java:568)
at
org.apache.commons.cli.DefaultParser.handleToken(DefaultParser.java:242)
at org.apache.commons.cli.DefaultParser.parse(DefaultParser.java:119)
at org.apache.commons.cli.DefaultParser.parse(DefaultParser.java:75)
at org.apache.commons.cli.DefaultParser.parse(DefaultParser.java:59)
at
org.apache.commons.cli.bug.BugCLI260Test.testProblem(BugCLI260Test.java:71)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:547)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
at
com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:51)
at
com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
at
com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
```
@jlm429, @britter - thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #14: Added BugCLI260 JUnit Test
Github user chtompki commented on the issue:
https://github.com/apache/commons-cli/pull/14
My impression base on my reading of the
[CLI-260](https://issues.apache.org/jira/browse/CLI-260) is that from this code:
```java
private DefaultParser parser;
private Options options;
@Before
public void setUp()
{
parser = new DefaultParser();
options = new Options()
.addOption("a", "enable-a", false, "turn [a] on or off")
.addOption("b", "bfile", true, "set the value of [b]")
.addOption("c", "copt", false, "turn [c] on or off")
.addOption("k", "kopt", true, "set value of k");
}
@Test
public void testProblem() throws Exception
{
String[] args = new String[] {"-k'option=value'"};
CommandLine cl = parser.parse(options, args);
String temp = "temp";
}
```
we get this exception:
```
org.apache.commons.cli.UnrecognizedOptionException: Unrecognized option:
-k'option=value'
at
org.apache.commons.cli.DefaultParser.handleUnknownToken(DefaultParser.java:359)
at
org.apache.commons.cli.DefaultParser.handleLongOptionWithEqual(DefaultParser.java:439)
at
org.apache.commons.cli.DefaultParser.handleShortAndLongOption(DefaultParser.java:568)
at
org.apache.commons.cli.DefaultParser.handleToken(DefaultParser.java:242)
at org.apache.commons.cli.DefaultParser.parse(DefaultParser.java:119)
at org.apache.commons.cli.DefaultParser.parse(DefaultParser.java:75)
at org.apache.commons.cli.DefaultParser.parse(DefaultParser.java:59)
at
org.apache.commons.cli.bug.BugCLI260Test.testProblem(BugCLI260Test.java:71)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:547)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
at
com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:51)
at
com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
at
com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
```
@jlm429, @britter - thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #14: Added BugCLI260 JUnit Test
Github user chtompki commented on the issue: https://github.com/apache/commons-cli/pull/14 I see you got it sorted. I'll give this a look in the morning. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #14: Added BugCLI260 JUnit Test
Github user chtompki commented on the issue: https://github.com/apache/commons-cli/pull/14 I see you got it sorted. I'll give this a look in the morning. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/45
I believe the reason that we're getting a "success" to be the fact that the
`docker` command exits with a 0. So might we want to do a `{docker run -v
`pwd`:/work library/ibmjava:8-sdk /bin/bash -c "apt-get update && cd work &&
apt-get install -y maven && mvn} || exit 1` in the docker command.
Further, I've been thinking about this more:
1. I submitted some changes to the official maven docker image (which I
think we should be using). 2. Would we want to have two builds here, one that
builds in a bunch of containers, and a second (presumably running on the target
usage jdk) that does the coveralls bit?
3. Depending on how we do this we loose a certain amount of paralellization.
I think I'll bubble this up to the ML for more discussion. It seems clear
to me that folks want to do this, but it's just a matter of how.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/45 Hm. I'll give this a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #46: TEXT-85:Added CaseUtils class with camel case conver...
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/46 Regarding the `WordUtils.capitalizeFully`, let's open that discussion up in a new Jira. I'll do that now. I think those questions are quite valid. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #46: TEXT-85:Added CaseUtils class with camel case...
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/46#discussion_r121374008
--- Diff: src/main/java/org/apache/commons/text/CaseUtils.java ---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.text;
+
+import org.apache.commons.lang3.StringUtils;
+
+import java.util.HashSet;
+import java.util.Set;
+
+/**
+ * Case manipulation operations on Strings that contain words.
+ *
+ * This class tries to handle null input gracefully.
+ * An exception will not be thrown for a null input.
+ * Each method documents its behaviour in more detail.
+ *
+ * @since 1.0
+ */
+public class CaseUtils {
+
+/**
+ * CaseUtils instances should NOT be constructed in
+ * standard programming. Instead, the class should be used as
+ * CaseUtils.toCamelCase("foo bar", true, new
char[]{'-'});.
+ *
+ * This constructor is public to permit tools that require a
JavaBean
+ * instance to operate.
+ */
+public CaseUtils() {
+super();
+}
+
+// Camel Case
+
//---
+/**
+ * Converts all the delimiter separated words in a String into
camelCase,
+ * that is each word is made up of a titlecase character and then a
series of
+ * lowercase characters. The
+ *
+ * The delimiters represent a set of characters understood to
separate words.
+ * The first non-delimiter character after a delimiter will be
capitalized. The first String
+ * character may or may not be capitalized and it's determined by the
user input for capitalizeFirstLetter
+ * variable.
+ *
+ * A null input String returns null.
+ * Capitalization uses the Unicode title case, normally equivalent to
+ * upper case.
+ *
+ *
+ * CaseUtils.toCamelCase(null, false)
= null
+ * CaseUtils.toCamelCase("", false, *)
= ""
+ * CaseUtils.toCamelCase(*, false, null)
= *
+ * CaseUtils.toCamelCase(*, true, new char[0])
= *
+ * CaseUtils.toCamelCase("To.Camel.Case", false, new char[]{'.'})
= "toCamelCase"
+ * CaseUtils.toCamelCase(" to @ Camel case", true, new char[]{'@'})
= "toCamelCase"
--- End diff --
Wouldn't we want
```java
CaseUtils.toCamelCase(" to @ Camel case", true, new char[]{'@'}) =
"ToCamelCase"
```
because of the `true` boolean?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #46: TEXT-85:Added CaseUtils class with camel case...
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/46#discussion_r121376797
--- Diff: src/main/java/org/apache/commons/text/CaseUtils.java ---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.text;
+
+import org.apache.commons.lang3.StringUtils;
+
+import java.util.HashSet;
+import java.util.Set;
+
+/**
+ * Case manipulation operations on Strings that contain words.
+ *
+ * This class tries to handle null input gracefully.
+ * An exception will not be thrown for a null input.
+ * Each method documents its behaviour in more detail.
+ *
+ * @since 1.0
+ */
+public class CaseUtils {
+
+/**
+ * CaseUtils instances should NOT be constructed in
+ * standard programming. Instead, the class should be used as
+ * CaseUtils.toCamelCase("foo bar", true, new
char[]{'-'});.
+ *
+ * This constructor is public to permit tools that require a
JavaBean
+ * instance to operate.
+ */
+public CaseUtils() {
+super();
+}
+
+// Camel Case
+
//---
+/**
+ * Converts all the delimiter separated words in a String into
camelCase,
+ * that is each word is made up of a titlecase character and then a
series of
+ * lowercase characters. The
+ *
+ * The delimiters represent a set of characters understood to
separate words.
+ * The first non-delimiter character after a delimiter will be
capitalized. The first String
+ * character may or may not be capitalized and it's determined by the
user input for capitalizeFirstLetter
+ * variable.
+ *
+ * A null input String returns null.
+ * Capitalization uses the Unicode title case, normally equivalent to
+ * upper case.
+ *
+ *
+ * CaseUtils.toCamelCase(null, false)
= null
+ * CaseUtils.toCamelCase("", false, *)
= ""
+ * CaseUtils.toCamelCase(*, false, null)
= *
+ * CaseUtils.toCamelCase(*, true, new char[0])
= *
+ * CaseUtils.toCamelCase("To.Camel.Case", false, new char[]{'.'})
= "toCamelCase"
+ * CaseUtils.toCamelCase(" to @ Camel case", true, new char[]{'@'})
= "toCamelCase"
+ * CaseUtils.toCamelCase(" @to @ Camel case", false, new char[]{'@'})
= "toCamelCase"
+ *
+ *
+ * @param str the String to be converted to camelCase, may be null
+ * @param capitalizeFirstLetter boolean that determines if the first
character of first word should be title case.
+ * @param delimiters set of characters to determine capitalization,
null and/or empty array means whitespace
+ * @return camelCase of String, null if null String input
+ */
+public static String toCamelCase(String str, boolean
capitalizeFirstLetter, final char... delimiters) {
--- End diff --
I think that we'll want:
```java
public static String toCamelCase(final String str, final boolean
capitalizeFirstLetter, final char... delimiters)
```
but I see that you've fiddled with the `str` variable below. So I'm open to
discussion on that point.
Generally, I'm torn on whether to have the signature be:
```java
public static String toCamelCase(final String str, final boolean
capitalizeFirstLetter, final char... delimiters);
```
or
```java
public static String toCamelCase(final CharSequence str, final boolean
capitalizeFirstLetter, final char... delimiters);
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
[GitHub] commons-text pull request #46: TEXT-85:Added CaseUtils class with camel case...
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/46#discussion_r121380327
--- Diff: src/main/java/org/apache/commons/text/CaseUtils.java ---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.text;
+
+import org.apache.commons.lang3.StringUtils;
+
+import java.util.HashSet;
+import java.util.Set;
+
+/**
+ * Case manipulation operations on Strings that contain words.
+ *
+ * This class tries to handle null input gracefully.
+ * An exception will not be thrown for a null input.
+ * Each method documents its behaviour in more detail.
+ *
+ * @since 1.0
+ */
+public class CaseUtils {
+
+/**
+ * CaseUtils instances should NOT be constructed in
+ * standard programming. Instead, the class should be used as
+ * CaseUtils.toCamelCase("foo bar", true, new
char[]{'-'});.
+ *
+ * This constructor is public to permit tools that require a
JavaBean
+ * instance to operate.
+ */
+public CaseUtils() {
+super();
+}
+
+// Camel Case
+
//---
+/**
+ * Converts all the delimiter separated words in a String into
camelCase,
+ * that is each word is made up of a titlecase character and then a
series of
+ * lowercase characters. The
+ *
+ * The delimiters represent a set of characters understood to
separate words.
+ * The first non-delimiter character after a delimiter will be
capitalized. The first String
+ * character may or may not be capitalized and it's determined by the
user input for capitalizeFirstLetter
+ * variable.
+ *
+ * A null input String returns null.
+ * Capitalization uses the Unicode title case, normally equivalent to
+ * upper case.
+ *
+ *
+ * CaseUtils.toCamelCase(null, false)
= null
+ * CaseUtils.toCamelCase("", false, *)
= ""
+ * CaseUtils.toCamelCase(*, false, null)
= *
+ * CaseUtils.toCamelCase(*, true, new char[0])
= *
+ * CaseUtils.toCamelCase("To.Camel.Case", false, new char[]{'.'})
= "toCamelCase"
+ * CaseUtils.toCamelCase(" to @ Camel case", true, new char[]{'@'})
= "toCamelCase"
+ * CaseUtils.toCamelCase(" @to @ Camel case", false, new char[]{'@'})
= "toCamelCase"
+ *
+ *
+ * @param str the String to be converted to camelCase, may be null
+ * @param capitalizeFirstLetter boolean that determines if the first
character of first word should be title case.
+ * @param delimiters set of characters to determine capitalization,
null and/or empty array means whitespace
+ * @return camelCase of String, null if null String input
+ */
+public static String toCamelCase(String str, boolean
capitalizeFirstLetter, final char... delimiters) {
+if (StringUtils.isEmpty(str)) {
+return str;
+}
+str = str.toLowerCase();
+int strLen = str.length();
+int [] newCodePoints = new int[strLen];
+int outOffset = 0;
+Set delimiterSet = generateDelimiterSet(delimiters);
+boolean capitalizeNext = false;
+if (capitalizeFirstLetter) {
+capitalizeNext = true;
+}
+for (int index = 0; index < strLen;) {
+final int codePoint = str.codePointAt(index);
+
+if (delimiterSet.contains(codePoint)) {
+capitalizeNext = true;
+if (outOffset == 0) {
+capitalizeNext = false;
+}
+
[GitHub] commons-text pull request #46: TEXT-85:Added CaseUtils class with camel case...
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/46#discussion_r121374329
--- Diff: src/main/java/org/apache/commons/text/CaseUtils.java ---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.text;
+
+import org.apache.commons.lang3.StringUtils;
+
+import java.util.HashSet;
+import java.util.Set;
+
+/**
+ * Case manipulation operations on Strings that contain words.
+ *
+ * This class tries to handle null input gracefully.
+ * An exception will not be thrown for a null input.
+ * Each method documents its behaviour in more detail.
+ *
+ * @since 1.0
+ */
+public class CaseUtils {
+
+/**
+ * CaseUtils instances should NOT be constructed in
+ * standard programming. Instead, the class should be used as
+ * CaseUtils.toCamelCase("foo bar", true, new
char[]{'-'});.
+ *
+ * This constructor is public to permit tools that require a
JavaBean
+ * instance to operate.
+ */
+public CaseUtils() {
--- End diff --
You could make the constructor `private`, but I do like the consistency
with
[`org.apache.commons.lang3.StringUtils.java`](https://github.com/apache/commons-lang/blob/master/src/main/java/org/apache/commons/lang3/StringUtils.java#L176-L186)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #46: TEXT-85:Added CaseUtils class with camel case...
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/46#discussion_r121380270
--- Diff: src/main/java/org/apache/commons/text/CaseUtils.java ---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.text;
+
+import org.apache.commons.lang3.StringUtils;
+
+import java.util.HashSet;
+import java.util.Set;
+
+/**
+ * Case manipulation operations on Strings that contain words.
+ *
+ * This class tries to handle null input gracefully.
+ * An exception will not be thrown for a null input.
+ * Each method documents its behaviour in more detail.
+ *
+ * @since 1.0
+ */
+public class CaseUtils {
+
+/**
+ * CaseUtils instances should NOT be constructed in
+ * standard programming. Instead, the class should be used as
+ * CaseUtils.toCamelCase("foo bar", true, new
char[]{'-'});.
+ *
+ * This constructor is public to permit tools that require a
JavaBean
+ * instance to operate.
+ */
+public CaseUtils() {
+super();
+}
+
+// Camel Case
+
//---
+/**
+ * Converts all the delimiter separated words in a String into
camelCase,
+ * that is each word is made up of a titlecase character and then a
series of
+ * lowercase characters. The
+ *
+ * The delimiters represent a set of characters understood to
separate words.
+ * The first non-delimiter character after a delimiter will be
capitalized. The first String
+ * character may or may not be capitalized and it's determined by the
user input for capitalizeFirstLetter
+ * variable.
+ *
+ * A null input String returns null.
+ * Capitalization uses the Unicode title case, normally equivalent to
+ * upper case.
+ *
--- End diff --
I wonder if, like in
[`Character.toUpperCase`](https://docs.oracle.com/javase/8/docs/api/java/lang/Character.html#toUpperCase-char-),
we should document that we are not locale based which I support. Adding in
`Locale` to the mix throws added complexity that may not be needed. Or document
that we're relying on `Character.toTitleCase` which has no `Locale` based
analogue in `String`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #46: TEXT-85:Added CaseUtils class with camel case...
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/46#discussion_r121378617
--- Diff: src/main/java/org/apache/commons/text/CaseUtils.java ---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.text;
+
+import org.apache.commons.lang3.StringUtils;
+
+import java.util.HashSet;
+import java.util.Set;
+
+/**
+ * Case manipulation operations on Strings that contain words.
+ *
+ * This class tries to handle null input gracefully.
+ * An exception will not be thrown for a null input.
+ * Each method documents its behaviour in more detail.
+ *
+ * @since 1.0
+ */
+public class CaseUtils {
+
+/**
+ * CaseUtils instances should NOT be constructed in
+ * standard programming. Instead, the class should be used as
+ * CaseUtils.toCamelCase("foo bar", true, new
char[]{'-'});.
+ *
+ * This constructor is public to permit tools that require a
JavaBean
+ * instance to operate.
+ */
+public CaseUtils() {
+super();
+}
+
+// Camel Case
+
//---
+/**
+ * Converts all the delimiter separated words in a String into
camelCase,
+ * that is each word is made up of a titlecase character and then a
series of
+ * lowercase characters. The
+ *
+ * The delimiters represent a set of characters understood to
separate words.
+ * The first non-delimiter character after a delimiter will be
capitalized. The first String
+ * character may or may not be capitalized and it's determined by the
user input for capitalizeFirstLetter
+ * variable.
+ *
+ * A null input String returns null.
+ * Capitalization uses the Unicode title case, normally equivalent to
+ * upper case.
+ *
+ *
+ * CaseUtils.toCamelCase(null, false)
= null
+ * CaseUtils.toCamelCase("", false, *)
= ""
+ * CaseUtils.toCamelCase(*, false, null)
= *
+ * CaseUtils.toCamelCase(*, true, new char[0])
= *
+ * CaseUtils.toCamelCase("To.Camel.Case", false, new char[]{'.'})
= "toCamelCase"
+ * CaseUtils.toCamelCase(" to @ Camel case", true, new char[]{'@'})
= "toCamelCase"
+ * CaseUtils.toCamelCase(" @to @ Camel case", false, new char[]{'@'})
= "toCamelCase"
+ *
+ *
+ * @param str the String to be converted to camelCase, may be null
+ * @param capitalizeFirstLetter boolean that determines if the first
character of first word should be title case.
+ * @param delimiters set of characters to determine capitalization,
null and/or empty array means whitespace
+ * @return camelCase of String, null if null String input
+ */
+public static String toCamelCase(String str, boolean
capitalizeFirstLetter, final char... delimiters) {
+if (StringUtils.isEmpty(str)) {
+return str;
+}
+str = str.toLowerCase();
+int strLen = str.length();
+int [] newCodePoints = new int[strLen];
+int outOffset = 0;
+Set delimiterSet = generateDelimiterSet(delimiters);
+boolean capitalizeNext = false;
+if (capitalizeFirstLetter) {
+capitalizeNext = true;
+}
+for (int index = 0; index < strLen;) {
+final int codePoint = str.codePointAt(index);
--- End diff --
If we decide to go with `CharSequence` here, this becomes a tougher move.
We have to begin worrying about UTF-16 and "surrogate pairs' of characters. See
[docs
here](https://docs.oracle.com/javase/8/docs/a
[GitHub] commons-text pull request #46: TEXT-85:Added CaseUtils class with camel case...
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/46#discussion_r121376091
--- Diff: src/main/java/org/apache/commons/text/CaseUtils.java ---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.text;
+
+import org.apache.commons.lang3.StringUtils;
+
+import java.util.HashSet;
+import java.util.Set;
+
+/**
+ * Case manipulation operations on Strings that contain words.
+ *
+ * This class tries to handle null input gracefully.
+ * An exception will not be thrown for a null input.
+ * Each method documents its behaviour in more detail.
+ *
+ * @since 1.0
+ */
+public class CaseUtils {
+
+/**
+ * CaseUtils instances should NOT be constructed in
+ * standard programming. Instead, the class should be used as
+ * CaseUtils.toCamelCase("foo bar", true, new
char[]{'-'});.
+ *
+ * This constructor is public to permit tools that require a
JavaBean
+ * instance to operate.
+ */
+public CaseUtils() {
+super();
+}
+
+// Camel Case
+
//---
+/**
+ * Converts all the delimiter separated words in a String into
camelCase,
+ * that is each word is made up of a titlecase character and then a
series of
+ * lowercase characters. The
+ *
+ * The delimiters represent a set of characters understood to
separate words.
+ * The first non-delimiter character after a delimiter will be
capitalized. The first String
+ * character may or may not be capitalized and it's determined by the
user input for capitalizeFirstLetter
+ * variable.
+ *
+ * A null input String returns null.
+ * Capitalization uses the Unicode title case, normally equivalent to
+ * upper case.
+ *
+ *
+ * CaseUtils.toCamelCase(null, false)
= null
+ * CaseUtils.toCamelCase("", false, *)
= ""
+ * CaseUtils.toCamelCase(*, false, null)
= *
+ * CaseUtils.toCamelCase(*, true, new char[0])
= *
+ * CaseUtils.toCamelCase("To.Camel.Case", false, new char[]{'.'})
= "toCamelCase"
+ * CaseUtils.toCamelCase(" to @ Camel case", true, new char[]{'@'})
= "toCamelCase"
+ * CaseUtils.toCamelCase(" @to @ Camel case", false, new char[]{'@'})
= "toCamelCase"
+ *
+ *
+ * @param str the String to be converted to camelCase, may be null
+ * @param capitalizeFirstLetter boolean that determines if the first
character of first word should be title case.
+ * @param delimiters set of characters to determine capitalization,
null and/or empty array means whitespace
+ * @return camelCase of String, null if null String input
+ */
+public static String toCamelCase(String str, boolean
capitalizeFirstLetter, final char... delimiters) {
+if (StringUtils.isEmpty(str)) {
+return str;
+}
+str = str.toLowerCase();
+int strLen = str.length();
+int [] newCodePoints = new int[strLen];
+int outOffset = 0;
+Set delimiterSet = generateDelimiterSet(delimiters);
+boolean capitalizeNext = false;
+if (capitalizeFirstLetter) {
+capitalizeNext = true;
+}
+for (int index = 0; index < strLen;) {
+final int codePoint = str.codePointAt(index);
+
+if (delimiterSet.contains(codePoint)) {
+capitalizeNext = true;
+if (outOffset == 0) {
+capitalizeNext = false;
+}
+
[GitHub] commons-text pull request #46: TEXT-85:Added CaseUtils class with camel case...
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/46#discussion_r121376021
--- Diff: src/main/java/org/apache/commons/text/CaseUtils.java ---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.text;
+
+import org.apache.commons.lang3.StringUtils;
+
+import java.util.HashSet;
+import java.util.Set;
+
+/**
+ * Case manipulation operations on Strings that contain words.
+ *
+ * This class tries to handle null input gracefully.
+ * An exception will not be thrown for a null input.
+ * Each method documents its behaviour in more detail.
+ *
+ * @since 1.0
+ */
+public class CaseUtils {
+
+/**
+ * CaseUtils instances should NOT be constructed in
+ * standard programming. Instead, the class should be used as
+ * CaseUtils.toCamelCase("foo bar", true, new
char[]{'-'});.
+ *
+ * This constructor is public to permit tools that require a
JavaBean
+ * instance to operate.
+ */
+public CaseUtils() {
+super();
+}
+
+// Camel Case
+
//---
+/**
+ * Converts all the delimiter separated words in a String into
camelCase,
+ * that is each word is made up of a titlecase character and then a
series of
+ * lowercase characters. The
+ *
+ * The delimiters represent a set of characters understood to
separate words.
+ * The first non-delimiter character after a delimiter will be
capitalized. The first String
+ * character may or may not be capitalized and it's determined by the
user input for capitalizeFirstLetter
+ * variable.
+ *
+ * A null input String returns null.
+ * Capitalization uses the Unicode title case, normally equivalent to
+ * upper case.
+ *
+ *
+ * CaseUtils.toCamelCase(null, false)
= null
+ * CaseUtils.toCamelCase("", false, *)
= ""
+ * CaseUtils.toCamelCase(*, false, null)
= *
+ * CaseUtils.toCamelCase(*, true, new char[0])
= *
+ * CaseUtils.toCamelCase("To.Camel.Case", false, new char[]{'.'})
= "toCamelCase"
+ * CaseUtils.toCamelCase(" to @ Camel case", true, new char[]{'@'})
= "toCamelCase"
--- End diff --
After looking at the tests, this appears to be merely a documentation error.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #47: Improved test coverage for StrTokenizer
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/47 I see no reason to not pull this in. Thanks for the contribution. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #45: Added IBM Jdk8 build support to travis-ci con...
Github user chtompki commented on a diff in the pull request: https://github.com/apache/commons-text/pull/45#discussion_r121372102 --- Diff: .travis.yml --- @@ -21,8 +21,15 @@ jdk: - oraclejdk7 - oraclejdk8 +services: + - docker + +before_install: + - docker pull ibmcom/ibmjava:8-sdk + script: - - mvn test apache-rat:check clirr:check checkstyle:check findbugs:check javadoc:javadoc + - mvn + - docker run -v `pwd`:/work library/ibmjava:8-sdk /bin/bash -c "apt-get update && cd work && apt-get install -y maven && mvn" --- End diff -- I'm about to pull this in, but I wonder if we could put in either issues or PR's on the official "maven" docker image whose docker files are given here: https://github.com/carlossg/docker-maven such that we could get oracle java as well as ibm java supported. I've opened the following issue for tracking purposes: https://github.com/carlossg/docker-maven/issues/25 I'm not sure, but I could see licensing being the main blocker to those being brought into the project. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #42: TEXT-83: Deprecate CsvTranslators from from commons ...
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/42 Will look over this again tomorrow early. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #46: TEXT-85:Added CaseUtils class with camel case conver...
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/46 Will look this over in the morning. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/45 Agreed. Will pull this in tonight or in the morning (UTC-4) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #47: Improved test coverage for StrTokenizer
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/47 Cool. I'll get to this point n the morning. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #45: Added IBM Jdk8 build support to travis-ci con...
Github user chtompki commented on a diff in the pull request: https://github.com/apache/commons-text/pull/45#discussion_r121162806 --- Diff: pom.xml --- @@ -150,7 +150,7 @@ -clean test apache-rat:check clirr:check checkstyle:check findbugs:check javadoc:javadoc +clean verify apache-rat:check clirr:check checkstyle:check findbugs:check javadoc:javadoc --- End diff -- +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #45: Added IBM Jdk8 build support to travis-ci con...
Github user chtompki commented on a diff in the pull request: https://github.com/apache/commons-text/pull/45#discussion_r121162871 --- Diff: .travis.yml --- @@ -21,8 +21,15 @@ jdk: - oraclejdk7 - oraclejdk8 +services: + - docker + +before_install: + - docker pull ibmcom/ibmjava:8-sdk --- End diff -- This is a curiousity I'm not sure how to solve. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #45: Added IBM Jdk8 build support to travis-ci con...
Github user chtompki commented on a diff in the pull request: https://github.com/apache/commons-text/pull/45#discussion_r121162778 --- Diff: .travis.yml --- @@ -21,8 +21,15 @@ jdk: - oraclejdk7 - oraclejdk8 +services: + - docker + +before_install: + - docker pull ibmcom/ibmjava:8-sdk + script: - mvn test apache-rat:check clirr:check checkstyle:check findbugs:check javadoc:javadoc + - docker run -v `pwd`:/work ibmcom/ibmjava:8-sdk /bin/bash -c "apt-get update && cd work && apt-get install -y maven && mvn" --- End diff -- The `apt-get update` here might take a long time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #45: Added IBM Jdk8 build support to travis-ci con...
Github user chtompki commented on a diff in the pull request: https://github.com/apache/commons-text/pull/45#discussion_r121162518 --- Diff: .travis.yml --- @@ -21,8 +21,15 @@ jdk: - oraclejdk7 - oraclejdk8 +services: + - docker + +before_install: + - docker pull ibmcom/ibmjava:8-sdk --- End diff -- I would prefer to use `library/ibmjava:8-jsk` because it's marked on dockerhub as "official" whereas `ibmcom` is just public. It's a bit curious though. It seems that they both point to the same place (repository) one points to "master" and one points to a githash. `ibmcom/ibmjava:8-sdk` - https://github.com/ibmruntimes/ci.docker/blob/master/ibmjava/8/sdk/x86_64/ubuntu/Dockerfile `library/ibmjava:8-sdk` - https://github.com/ibmruntimes/ci.docker/blob/a9a184211f9feef1f2bdd0330ff8ae95e6c015cf/ibmjava/8/sdk/x86_64/ubuntu/Dockerfile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #44: [TEXT-80]: Fixed confusing StrLookup API
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/44 @britter - I would have to test it out, but fair point. It feels like we should always maintain source and binary backwards compatibility for minor version updates. But, if the policy is different from that feeling, then I'm not opposed to the changes. @garydgregory - What is the policy on source incompatible changes in minor version updates? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #44: [TEXT-80]: Fixed confusing StrLookup API
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/44
@britter if I declare a class
```java
package com.rt;
import org.apache.commons.text.StrLookup;
public class TextTester extends StrLookup {
public String lookup(String key) {
return null;
}
}
```
on commons-text:1.1, and up-version into these changes, I get compiler
errors. To me, that implies that we must do a major version release to
accommodate them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #44: [TEXT-80]: Fixed confusing StrLookup API
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/44 The change is generally all right with me, but we can't release this until a 2.X release though because of signature changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #44: [TEXT-80]: Fixed confusing StrLookup API
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/44 Would this imply a 2.0 release because of BC compatibility? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-rng pull request #2: RNG-11: refactor such that coveralls uses jacoc...
GitHub user chtompki opened a pull request: https://github.com/apache/commons-rng/pull/2 RNG-11: refactor such that coveralls uses jacoco instead of cobertura Another PR for: https://issues.apache.org/jira/browse/RNG-11 You can merge this pull request into a Git repository by running: $ git pull https://github.com/chtompki/commons-rng RNG-11 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-rng/pull/2.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2 commit 6dbe13089bffb81f55ca9441c47f150f79ef8b0f Author: Rob Tompkins <chtom...@gmail.com> Date: 2016-08-22T11:23:32Z RNG-11: switch back to 0.7.5 jacoco version commit 1ef022d8569d0622a88acfd46885f4b6a27459fa Author: Rob Tompkins <chtom...@gmail.com> Date: 2016-08-22T11:49:55Z RNG-11: refactor such that coveralls uses jacoco instead of cobertura --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-rng pull request #1: RNG-11: adding .travis.yml
GitHub user chtompki opened a pull request: https://github.com/apache/commons-rng/pull/1 RNG-11: adding .travis.yml This resolves https://issues.apache.org/jira/browse/RNG-11 You can merge this pull request into a Git repository by running: $ git pull https://github.com/chtompki/commons-rng RNG-11 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-rng/pull/1.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1 commit 804784a6958d77bfe0c1a25210291da9347dce64 Author: Rob Tompkins <chtom...@gmail.com> Date: 2016-08-21T01:00:42Z RNG-11: adding .travis.yml --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
