Re: [dbcp] 1.3/1.4 RC1 available for review
Jörg Schaible wrote: Hi Phil, Phil Steitz wrote: I have prepared release candidates for DBCP 1.3 and 1.4. Please all interested parties have a look and test. If all goes well, I will kick off a release VOTE based on these artifacts in the next couple of days. I see these as really two sets of artifacts associated with one release, so I am inclined to just do one VOTE including both versions. If anyone disagrees with this, please speak up. I am happy to run two VOTEs. 1.3 (JDBC 3) version: http://people.apache.org/~psteitz/dbcp-1.3-rc1 http://people.apache.org/~psteitz/dbcp-1.3-rc1/site http://people.apache.org/~psteitz/dbcp-1.3-rc1/maven http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_3_RC1/ Like Nial I changed geronimo-jta_1.1_spec to version 1.1. My compiler zoo fails though for blackdown-jdk-1.4.2.03, jrockit-jdk-1.4.2.16 and sun- jdk-1.4.2.19. IMHO you must update the xerces version to a release that contains the driver implementation in the Java-SPI (META-INF/services): I can't replicate these failures. Using the code and config now in branches/DBCP_1_3_BRANCH, Ant 1.7.1, Ubuntu 9.10, the Blackdown, Sun and Oracle JDKs mentioned above all succeed for me. What OS and version of Ant are you using? Phil == % Test set: org.apache.commons.jocl.TestJOCLContentHandler --- Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.047 sec FAILURE! testObject(org.apache.commons.jocl.TestJOCLContentHandler) Time elapsed: 0.006 sec testPrimitives(org.apache.commons.jocl.TestJOCLContentHandler) Time elapsed: 0 sec testParse(org.apache.commons.jocl.TestJOCLContentHandler) Time elapsed: 0.028 sec ERROR! org.xml.sax.SAXException: System property org.xml.sax.driver not specified at org.xml.sax.helpers.XMLReaderFactory.createXMLReader(XMLReaderFactory.java:90) at org.apache.commons.jocl.JOCLContentHandler.parse(JOCLContentHandler.java:339) at org.apache.commons.jocl.JOCLContentHandler.parse(JOCLContentHandler.java:271) at org.apache.commons.jocl.TestJOCLContentHandler.testParse(TestJOCLContentHandler.java:255) == % Using IBM-JDK 1.4.2.13 the build and all tests with Ant 1.6.5 succeed, but I get nevertheless those exceptions, I do not see, when running the other JDKs with Maven: == % [junit] org.apache.commons.dbcp.AbandonedTrace$AbandonedObjectException: DBCP object created 2009-12-08 23:03:07 by the following code was never closed: [junit] at org.apache.commons.dbcp.AbandonedTrace.setStackTrace(AbandonedTrace.java:138) [junit] at org.apache.commons.dbcp.AbandonedObjectPool.borrowObject(AbandonedObjectPool.java:81) [junit] at org.apache.commons.dbcp.PoolingDataSource.getConnection(PoolingDataSource.java:106) [junit] at org.apache.commons.dbcp.BasicDataSource.getConnection(BasicDataSource.java:1044) [junit] at org.apache.commons.dbcp.TestAbandonedBasicDataSource.testAbandoned(TestAbandonedBasicDataSource.java:65) == % == % [junit] org.apache.commons.dbcp.AbandonedTrace$AbandonedObjectException: DBCP object created 2009-12-08 23:03:07 by the following code was never closed: [junit] at org.apache.commons.dbcp.AbandonedTrace.setStackTrace(AbandonedTrace.java:138) [junit] at org.apache.commons.dbcp.AbandonedObjectPool.borrowObject(AbandonedObjectPool.java:81) [junit] at org.apache.commons.dbcp.PoolingDataSource.getConnection(PoolingDataSource.java:106) [junit] at org.apache.commons.dbcp.BasicDataSource.getConnection(BasicDataSource.java:1044) [junit] at org.apache.commons.dbcp.TestBasicDataSource.getConnection(TestBasicDataSource.java:44) [junit] at org.apache.commons.dbcp.TestAbandonedBasicDataSource.testAbandonedClose(TestAbandonedBasicDataSource.java:75) == % == % [junit] org.apache.commons.dbcp.AbandonedTrace$AbandonedObjectException: DBCP object created 2009-12-08 23:03:07 by the following code was never closed:
Re: [dbcp] 1.3/1.4 RC1 available for review
Jörg Schaible wrote: Jörg Schaible wrote: Jörg Schaible wrote: Hi Phil, Phil Steitz wrote: [snip] 1.4 (JDBC 4) version: http://people.apache.org/~psteitz/dbcp-1.4-rc1 http://people.apache.org/~psteitz/dbcp-1.4-rc1/site http://people.apache.org/~psteitz/dbcp-1.4-rc1/maven http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_4_RC1/ Builds from source and runs tests with IcedTea6 1.6.2, Sun JDK 1.6 and Sun JDK 1.7.0.0.alpha69 (add to README.txt ?!?). However it fails with IBM 1.6.0.6: == % --- Test set: org.apache.commons.dbcp.managed.TestBasicManagedDataSource --- Tests run: 46, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.398 sec FAILURE! testReallyClose(org.apache.commons.dbcp.managed.TestBasicManagedDataSource) Time elapsed: 0.066 sec FAILURE! junit.framework.AssertionFailedError: Expecting SQLException - XAResources orphaned at junit.framework.Assert.fail(Assert.java:47) at org.apache.commons.dbcp.managed.TestBasicManagedDataSource.testReallyClose(TestBasicManagedDataSource.java:72) I could use some help debugging this one. I do not have the JDK to test with and the failure makes no sense to me. Does it happen every time? It seems it was caused by a difference in the WeakReference implementation. The DelegactingConnection returned the same hashCode than the inner connection. However, both instances were kept in the registry in xaReference (a WeakMap). Need to figure out why that is happening. This could be a test bug. The connection should only be added once to the registry. After using a distinguishable hashCode, the test succeeds also with IBM JDK. Additionally I dropped the JDK 1.4 deps from the POM. That is OK for the trunk POM. Thanks. I'll look into DBCP 1.3 ASAP - it got too late now ;-) Guess it was really too late yesterday. While TestBasicManagedDataSource works now, my change borked the TestManagedDataSourceInTx tests (interestingly 33 with Sun JDK, but only 28 with IBM). Basically my change broke the contract with hashCode that should be the same for equal objects. Question is now, what to do. If we revert the change, the IBM JDK is broken and it fails to release the transactions. Otherwise we have to change additionally the equals method, so that a DelegatingConnection is not equal to the wrapped Connection. However, this may case even more hick-ups. I've reverted the hashCode change for now that brings back the IBM JDK problem. :-/ Thanks, Jorg. I think changing equals is not a good idea. Thanks again for your help. Phil - Jörg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [dbcp] 1.3/1.4 RC1 available for review
Phil Steitz wrote: Jörg Schaible wrote: Jörg Schaible wrote: Jörg Schaible wrote: Hi Phil, Phil Steitz wrote: [snip] 1.4 (JDBC 4) version: http://people.apache.org/~psteitz/dbcp-1.4-rc1 http://people.apache.org/~psteitz/dbcp-1.4-rc1/site http://people.apache.org/~psteitz/dbcp-1.4-rc1/maven http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_4_RC1/ Builds from source and runs tests with IcedTea6 1.6.2, Sun JDK 1.6 and Sun JDK 1.7.0.0.alpha69 (add to README.txt ?!?). However it fails with IBM 1.6.0.6: == % --- Test set: org.apache.commons.dbcp.managed.TestBasicManagedDataSource --- Tests run: 46, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.398 sec FAILURE! testReallyClose(org.apache.commons.dbcp.managed.TestBasicManagedDataSource) Time elapsed: 0.066 sec FAILURE! junit.framework.AssertionFailedError: Expecting SQLException - XAResources orphaned at junit.framework.Assert.fail(Assert.java:47) at org.apache.commons.dbcp.managed.TestBasicManagedDataSource.testReallyClose(TestBasicManagedDataSource.java:72) I could use some help debugging this one. I do not have the JDK to test with and the failure makes no sense to me. Does it happen every time? It seems it was caused by a difference in the WeakReference implementation. The DelegactingConnection returned the same hashCode than the inner connection. However, both instances were kept in the registry in xaReference (a WeakMap). Need to figure out why that is happening. This could be a test bug. The connection should only be added once to the registry. After using a distinguishable hashCode, the test succeeds also with IBM JDK. Additionally I dropped the JDK 1.4 deps from the POM. That is OK for the trunk POM. Thanks. I'll look into DBCP 1.3 ASAP - it got too late now ;-) Guess it was really too late yesterday. While TestBasicManagedDataSource works now, my change borked the TestManagedDataSourceInTx tests (interestingly 33 with Sun JDK, but only 28 with IBM). Basically my change broke the contract with hashCode that should be the same for equal objects. Question is now, what to do. If we revert the change, the IBM JDK is broken and it fails to release the transactions. Otherwise we have to change additionally the equals method, so that a DelegatingConnection is not equal to the wrapped Connection. However, this may case even more hick-ups. I've reverted the hashCode change for now that brings back the IBM JDK problem. :-/ Thanks, Jorg. I think changing equals is not a good idea. Thanks again for your help. This is a test bug. The test is manually registering the connection after the LocalXAConnectionFactory has already done it. Fixing now. This should eliminate the problem. Phil Phil - Jörg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [dbcp] 1.3/1.4 RC1 available for review
Phil Steitz wrote: Phil Steitz wrote: Jörg Schaible wrote: Jörg Schaible wrote: Jörg Schaible wrote: Hi Phil, Phil Steitz wrote: [snip] 1.4 (JDBC 4) version: http://people.apache.org/~psteitz/dbcp-1.4-rc1 http://people.apache.org/~psteitz/dbcp-1.4-rc1/site http://people.apache.org/~psteitz/dbcp-1.4-rc1/maven http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_4_RC1/ Builds from source and runs tests with IcedTea6 1.6.2, Sun JDK 1.6 and Sun JDK 1.7.0.0.alpha69 (add to README.txt ?!?). However it fails with IBM 1.6.0.6: == % --- Test set: org.apache.commons.dbcp.managed.TestBasicManagedDataSource --- Tests run: 46, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.398 sec FAILURE! testReallyClose(org.apache.commons.dbcp.managed.TestBasicManagedDataSource) Time elapsed: 0.066 sec FAILURE! junit.framework.AssertionFailedError: Expecting SQLException - XAResources orphaned at junit.framework.Assert.fail(Assert.java:47) at org.apache.commons.dbcp.managed.TestBasicManagedDataSource.testReallyClose(TestBasicManagedDataSource.java:72) I could use some help debugging this one. I do not have the JDK to test with and the failure makes no sense to me. Does it happen every time? It seems it was caused by a difference in the WeakReference implementation. The DelegactingConnection returned the same hashCode than the inner connection. However, both instances were kept in the registry in xaReference (a WeakMap). Need to figure out why that is happening. This could be a test bug. The connection should only be added once to the registry. After using a distinguishable hashCode, the test succeeds also with IBM JDK. Additionally I dropped the JDK 1.4 deps from the POM. That is OK for the trunk POM. Thanks. I'll look into DBCP 1.3 ASAP - it got too late now ;-) Guess it was really too late yesterday. While TestBasicManagedDataSource works now, my change borked the TestManagedDataSourceInTx tests (interestingly 33 with Sun JDK, but only 28 with IBM). Basically my change broke the contract with hashCode that should be the same for equal objects. Question is now, what to do. If we revert the change, the IBM JDK is broken and it fails to release the transactions. Otherwise we have to change additionally the equals method, so that a DelegatingConnection is not equal to the wrapped Connection. However, this may case even more hick-ups. I've reverted the hashCode change for now that brings back the IBM JDK problem. :-/ Thanks, Jorg. I think changing equals is not a good idea. Thanks again for your help. This is a test bug. The test is manually registering the connection after the LocalXAConnectionFactory has already done it. Fixing now. This should eliminate the problem. The funny thing is that on Sun JDK registering the ManagedConnection itself will update the entry in the WeakHashMap of the delegated connection. On IBM JDK a new entry is created in the map. Later on is the ManagedConnection removed, but the lookup will now return the delegated connection (may be because of equality of the connection and its hash code when it is used as key. - Jörg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [dbcp] 1.3/1.4 RC1 available for review
Jörg Schaible wrote: Phil Steitz wrote: Phil Steitz wrote: Jörg Schaible wrote: Jörg Schaible wrote: Jörg Schaible wrote: Hi Phil, Phil Steitz wrote: [snip] 1.4 (JDBC 4) version: http://people.apache.org/~psteitz/dbcp-1.4-rc1 http://people.apache.org/~psteitz/dbcp-1.4-rc1/site http://people.apache.org/~psteitz/dbcp-1.4-rc1/maven http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_4_RC1/ Builds from source and runs tests with IcedTea6 1.6.2, Sun JDK 1.6 and Sun JDK 1.7.0.0.alpha69 (add to README.txt ?!?). However it fails with IBM 1.6.0.6: == % --- Test set: org.apache.commons.dbcp.managed.TestBasicManagedDataSource --- Tests run: 46, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.398 sec FAILURE! testReallyClose(org.apache.commons.dbcp.managed.TestBasicManagedDataSource) Time elapsed: 0.066 sec FAILURE! junit.framework.AssertionFailedError: Expecting SQLException - XAResources orphaned at junit.framework.Assert.fail(Assert.java:47) at org.apache.commons.dbcp.managed.TestBasicManagedDataSource.testReallyClose(TestBasicManagedDataSource.java:72) I could use some help debugging this one. I do not have the JDK to test with and the failure makes no sense to me. Does it happen every time? It seems it was caused by a difference in the WeakReference implementation. The DelegactingConnection returned the same hashCode than the inner connection. However, both instances were kept in the registry in xaReference (a WeakMap). Need to figure out why that is happening. This could be a test bug. The connection should only be added once to the registry. After using a distinguishable hashCode, the test succeeds also with IBM JDK. Additionally I dropped the JDK 1.4 deps from the POM. That is OK for the trunk POM. Thanks. I'll look into DBCP 1.3 ASAP - it got too late now ;-) Guess it was really too late yesterday. While TestBasicManagedDataSource works now, my change borked the TestManagedDataSourceInTx tests (interestingly 33 with Sun JDK, but only 28 with IBM). Basically my change broke the contract with hashCode that should be the same for equal objects. Question is now, what to do. If we revert the change, the IBM JDK is broken and it fails to release the transactions. Otherwise we have to change additionally the equals method, so that a DelegatingConnection is not equal to the wrapped Connection. However, this may case even more hick-ups. I've reverted the hashCode change for now that brings back the IBM JDK problem. :-/ Thanks, Jorg. I think changing equals is not a good idea. Thanks again for your help. This is a test bug. The test is manually registering the connection after the LocalXAConnectionFactory has already done it. Fixing now. This should eliminate the problem. The funny thing is that on Sun JDK registering the ManagedConnection itself will update the entry in the WeakHashMap of the delegated connection. On IBM JDK a new entry is created in the map. Later on is the ManagedConnection removed, but the lookup will now return the delegated connection (may be because of equality of the connection and its hash code when it is used as key. IBM JDK 1.6 tested - runs fine now. - Jörg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [dbcp] 1.3/1.4 RC1 available for review
Jörg Schaible wrote: Phil Steitz wrote: Phil Steitz wrote: Jörg Schaible wrote: Jörg Schaible wrote: Jörg Schaible wrote: Hi Phil, Phil Steitz wrote: [snip] 1.4 (JDBC 4) version: http://people.apache.org/~psteitz/dbcp-1.4-rc1 http://people.apache.org/~psteitz/dbcp-1.4-rc1/site http://people.apache.org/~psteitz/dbcp-1.4-rc1/maven http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_4_RC1/ Builds from source and runs tests with IcedTea6 1.6.2, Sun JDK 1.6 and Sun JDK 1.7.0.0.alpha69 (add to README.txt ?!?). However it fails with IBM 1.6.0.6: == % --- Test set: org.apache.commons.dbcp.managed.TestBasicManagedDataSource --- Tests run: 46, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.398 sec FAILURE! testReallyClose(org.apache.commons.dbcp.managed.TestBasicManagedDataSource) Time elapsed: 0.066 sec FAILURE! junit.framework.AssertionFailedError: Expecting SQLException - XAResources orphaned at junit.framework.Assert.fail(Assert.java:47) at org.apache.commons.dbcp.managed.TestBasicManagedDataSource.testReallyClose(TestBasicManagedDataSource.java:72) I could use some help debugging this one. I do not have the JDK to test with and the failure makes no sense to me. Does it happen every time? It seems it was caused by a difference in the WeakReference implementation. The DelegactingConnection returned the same hashCode than the inner connection. However, both instances were kept in the registry in xaReference (a WeakMap). Need to figure out why that is happening. This could be a test bug. The connection should only be added once to the registry. After using a distinguishable hashCode, the test succeeds also with IBM JDK. Additionally I dropped the JDK 1.4 deps from the POM. That is OK for the trunk POM. Thanks. I'll look into DBCP 1.3 ASAP - it got too late now ;-) Guess it was really too late yesterday. While TestBasicManagedDataSource works now, my change borked the TestManagedDataSourceInTx tests (interestingly 33 with Sun JDK, but only 28 with IBM). Basically my change broke the contract with hashCode that should be the same for equal objects. Question is now, what to do. If we revert the change, the IBM JDK is broken and it fails to release the transactions. Otherwise we have to change additionally the equals method, so that a DelegatingConnection is not equal to the wrapped Connection. However, this may case even more hick-ups. I've reverted the hashCode change for now that brings back the IBM JDK problem. :-/ Thanks, Jorg. I think changing equals is not a good idea. Thanks again for your help. This is a test bug. The test is manually registering the connection after the LocalXAConnectionFactory has already done it. Fixing now. This should eliminate the problem. The funny thing is that on Sun JDK registering the ManagedConnection itself will update the entry in the WeakHashMap of the delegated connection. On IBM JDK a new entry is created in the map. Later on is the ManagedConnection removed, but the lookup will now return the delegated connection (may be because of equality of the connection and its hash code when it is used as key. I don't know why the JDK behavior is different, but you have it right - the test code was registering the ManagedConnection returned by the ManagedDataSource whereas the LocalXAConnectionFactory registers the DelegatingConnection that the ManagedConnection wraps. These are equal. Phil - Jörg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [dbcp] 1.3/1.4 RC1 available for review
Jörg Schaible wrote: Hi Phil, Phil Steitz wrote: [snip] 1.4 (JDBC 4) version: http://people.apache.org/~psteitz/dbcp-1.4-rc1 http://people.apache.org/~psteitz/dbcp-1.4-rc1/site http://people.apache.org/~psteitz/dbcp-1.4-rc1/maven http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_4_RC1/ Builds from source and runs tests with IcedTea6 1.6.2, Sun JDK 1.6 and Sun JDK 1.7.0.0.alpha69 (add to README.txt ?!?). However it fails with IBM 1.6.0.6: == % --- Test set: org.apache.commons.dbcp.managed.TestBasicManagedDataSource --- Tests run: 46, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.398 sec FAILURE! testReallyClose(org.apache.commons.dbcp.managed.TestBasicManagedDataSource) Time elapsed: 0.066 sec FAILURE! junit.framework.AssertionFailedError: Expecting SQLException - XAResources orphaned at junit.framework.Assert.fail(Assert.java:47) at org.apache.commons.dbcp.managed.TestBasicManagedDataSource.testReallyClose(TestBasicManagedDataSource.java:72) I could use some help debugging this one. I do not have the JDK to test with and the failure makes no sense to me. Does it happen every time? It seems it was caused by a difference in the WeakReference implementation. The DelegactingConnection returned the same hashCode than the inner connection. However, both instances were kept in the registry in xaReference (a WeakMap). After using a distinguishable hashCode, the test succeeds also with IBM JDK. Additionally I dropped the JDK 1.4 deps from the POM. I'll look into DBCP 1.3 ASAP - it got too late now ;-) Guess it was really too late yesterday. While TestBasicManagedDataSource works now, my change borked the TestManagedDataSourceInTx tests (interestingly 33 with Sun JDK, but only 28 with IBM). Basically my change broke the contract with hashCode that should be the same for equal objects. Question is now, what to do. If we revert the change, the IBM JDK is broken and it fails to release the transactions. Otherwise we have to change additionally the equals method, so that a DelegatingConnection is not equal to the wrapped Connection. However, this may case even more hick-ups. - Jörg - Jörg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [dbcp] 1.3/1.4 RC1 available for review
Jörg Schaible wrote: Jörg Schaible wrote: Hi Phil, Phil Steitz wrote: [snip] 1.4 (JDBC 4) version: http://people.apache.org/~psteitz/dbcp-1.4-rc1 http://people.apache.org/~psteitz/dbcp-1.4-rc1/site http://people.apache.org/~psteitz/dbcp-1.4-rc1/maven http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_4_RC1/ Builds from source and runs tests with IcedTea6 1.6.2, Sun JDK 1.6 and Sun JDK 1.7.0.0.alpha69 (add to README.txt ?!?). However it fails with IBM 1.6.0.6: == % --- Test set: org.apache.commons.dbcp.managed.TestBasicManagedDataSource --- Tests run: 46, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.398 sec FAILURE! testReallyClose(org.apache.commons.dbcp.managed.TestBasicManagedDataSource) Time elapsed: 0.066 sec FAILURE! junit.framework.AssertionFailedError: Expecting SQLException - XAResources orphaned at junit.framework.Assert.fail(Assert.java:47) at org.apache.commons.dbcp.managed.TestBasicManagedDataSource.testReallyClose(TestBasicManagedDataSource.java:72) I could use some help debugging this one. I do not have the JDK to test with and the failure makes no sense to me. Does it happen every time? It seems it was caused by a difference in the WeakReference implementation. The DelegactingConnection returned the same hashCode than the inner connection. However, both instances were kept in the registry in xaReference (a WeakMap). After using a distinguishable hashCode, the test succeeds also with IBM JDK. Additionally I dropped the JDK 1.4 deps from the POM. I'll look into DBCP 1.3 ASAP - it got too late now ;-) Guess it was really too late yesterday. While TestBasicManagedDataSource works now, my change borked the TestManagedDataSourceInTx tests (interestingly 33 with Sun JDK, but only 28 with IBM). Basically my change broke the contract with hashCode that should be the same for equal objects. Question is now, what to do. If we revert the change, the IBM JDK is broken and it fails to release the transactions. Otherwise we have to change additionally the equals method, so that a DelegatingConnection is not equal to the wrapped Connection. However, this may case even more hick-ups. I've reverted the hashCode change for now that brings back the IBM JDK problem. :-/ - Jörg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [dbcp] 1.3/1.4 RC1 available for review
Hi Phil, Phil Steitz wrote: [snip] 1.4 (JDBC 4) version: http://people.apache.org/~psteitz/dbcp-1.4-rc1 http://people.apache.org/~psteitz/dbcp-1.4-rc1/site http://people.apache.org/~psteitz/dbcp-1.4-rc1/maven http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_4_RC1/ Builds from source and runs tests with IcedTea6 1.6.2, Sun JDK 1.6 and Sun JDK 1.7.0.0.alpha69 (add to README.txt ?!?). However it fails with IBM 1.6.0.6: == % --- Test set: org.apache.commons.dbcp.managed.TestBasicManagedDataSource --- Tests run: 46, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.398 sec FAILURE! testReallyClose(org.apache.commons.dbcp.managed.TestBasicManagedDataSource) Time elapsed: 0.066 sec FAILURE! junit.framework.AssertionFailedError: Expecting SQLException - XAResources orphaned at junit.framework.Assert.fail(Assert.java:47) at org.apache.commons.dbcp.managed.TestBasicManagedDataSource.testReallyClose(TestBasicManagedDataSource.java:72) I could use some help debugging this one. I do not have the JDK to test with and the failure makes no sense to me. Does it happen every time? It seems it was caused by a difference in the WeakReference implementation. The DelegactingConnection returned the same hashCode than the inner connection. However, both instances were kept in the registry in xaReference (a WeakMap). After using a distinguishable hashCode, the test succeeds also with IBM JDK. Additionally I dropped the JDK 1.4 deps from the POM. I'll look into DBCP 1.3 ASAP - it got too late now ;-) - Jörg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [dbcp] 1.3/1.4 RC1 available for review
Jörg Schaible wrote: Hi Phil, Phil Steitz wrote: I have prepared release candidates for DBCP 1.3 and 1.4. Please all interested parties have a look and test. If all goes well, I will kick off a release VOTE based on these artifacts in the next couple of days. I see these as really two sets of artifacts associated with one release, so I am inclined to just do one VOTE including both versions. If anyone disagrees with this, please speak up. I am happy to run two VOTEs. 1.3 (JDBC 3) version: http://people.apache.org/~psteitz/dbcp-1.3-rc1 http://people.apache.org/~psteitz/dbcp-1.3-rc1/site http://people.apache.org/~psteitz/dbcp-1.3-rc1/maven http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_3_RC1/ Like Nial I changed geronimo-jta_1.1_spec to version 1.1. My compiler zoo fails though for blackdown-jdk-1.4.2.03, jrockit-jdk-1.4.2.16 and sun- jdk-1.4.2.19. IMHO you must update the xerces version to a release that contains the driver implementation in the Java-SPI (META-INF/services): == % Test set: org.apache.commons.jocl.TestJOCLContentHandler --- Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.047 sec FAILURE! testObject(org.apache.commons.jocl.TestJOCLContentHandler) Time elapsed: 0.006 sec testPrimitives(org.apache.commons.jocl.TestJOCLContentHandler) Time elapsed: 0 sec testParse(org.apache.commons.jocl.TestJOCLContentHandler) Time elapsed: 0.028 sec ERROR! org.xml.sax.SAXException: System property org.xml.sax.driver not specified at org.xml.sax.helpers.XMLReaderFactory.createXMLReader(XMLReaderFactory.java:90) at org.apache.commons.jocl.JOCLContentHandler.parse(JOCLContentHandler.java:339) at org.apache.commons.jocl.JOCLContentHandler.parse(JOCLContentHandler.java:271) at org.apache.commons.jocl.TestJOCLContentHandler.testParse(TestJOCLContentHandler.java:255) I don't get this one. Works fine on Apple 1.4.2 jdk. I am struggling to get a box setup where I can get Sun JDKs installed. I would appreciate any suggestions on how to fix this. == % Using IBM-JDK 1.4.2.13 the build and all tests with Ant 1.6.5 succeed, but I get nevertheless those exceptions, I do not see, when running the other JDKs with Maven: == % [junit] org.apache.commons.dbcp.AbandonedTrace$AbandonedObjectException: DBCP object created 2009-12-08 23:03:07 by the following code was never closed: [junit] at org.apache.commons.dbcp.AbandonedTrace.setStackTrace(AbandonedTrace.java:138) [junit] at org.apache.commons.dbcp.AbandonedObjectPool.borrowObject(AbandonedObjectPool.java:81) [junit] at org.apache.commons.dbcp.PoolingDataSource.getConnection(PoolingDataSource.java:106) [junit] at org.apache.commons.dbcp.BasicDataSource.getConnection(BasicDataSource.java:1044) [junit] at org.apache.commons.dbcp.TestAbandonedBasicDataSource.testAbandoned(TestAbandonedBasicDataSource.java:65) These are harmless, exceptions are expected. == % == % [junit] org.apache.commons.dbcp.AbandonedTrace$AbandonedObjectException: DBCP object created 2009-12-08 23:03:07 by the following code was never closed: [junit] at org.apache.commons.dbcp.AbandonedTrace.setStackTrace(AbandonedTrace.java:138) [junit] at org.apache.commons.dbcp.AbandonedObjectPool.borrowObject(AbandonedObjectPool.java:81) [junit] at org.apache.commons.dbcp.PoolingDataSource.getConnection(PoolingDataSource.java:106) [junit] at org.apache.commons.dbcp.BasicDataSource.getConnection(BasicDataSource.java:1044) [junit] at org.apache.commons.dbcp.TestBasicDataSource.getConnection(TestBasicDataSource.java:44) [junit] at org.apache.commons.dbcp.TestAbandonedBasicDataSource.testAbandonedClose(TestAbandonedBasicDataSource.java:75) == % == % [junit] org.apache.commons.dbcp.AbandonedTrace$AbandonedObjectException: DBCP object created 2009-12-08 23:03:07 by the following code was never closed:
Re: [dbcp] 1.3/1.4 RC1 available for review
Jörg Schaible wrote: Hi Phil, Phil Steitz wrote at Donnerstag, 10. Dezember 2009 12:42: Jörg Schaible wrote: Hi Phil, Phil Steitz wrote: I have prepared release candidates for DBCP 1.3 and 1.4. Please all interested parties have a look and test. If all goes well, I will kick off a release VOTE based on these artifacts in the next couple of days. I see these as really two sets of artifacts associated with one release, so I am inclined to just do one VOTE including both versions. If anyone disagrees with this, please speak up. I am happy to run two VOTEs. 1.3 (JDBC 3) version: http://people.apache.org/~psteitz/dbcp-1.3-rc1 http://people.apache.org/~psteitz/dbcp-1.3-rc1/site http://people.apache.org/~psteitz/dbcp-1.3-rc1/maven http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_3_RC1/ Like Nial I changed geronimo-jta_1.1_spec to version 1.1. My compiler zoo fails though for blackdown-jdk-1.4.2.03, jrockit-jdk-1.4.2.16 and sun- jdk-1.4.2.19. IMHO you must update the xerces version to a release that contains the driver implementation in the Java-SPI (META-INF/services): Thanks, Jorg. I really appreciate your running this through the zoo. Can you identify a suitable Xerces version? Actually I tried that yesterday. I've upgraded to xercesImpl-2.9.1 that contains the SPI entry for sure, but the test still fails. After looking into the code I've seen that the test explicitly sets the system property already. Even after moving that code from constructor into setUp the failure still occurs. This left be somewhat baffled, but I ran out of time to have a further look :-/ I am going to make this and the jta spec change and cut another RC. Thanks all for testing. Did you also see those: Yes. Investigating... [snip] I do not see those using IBM-JDK 1.5.0.10. With this I had a casually 1 failure, but no test reports are generated with Ant nor could I see on the console which test actually failed. Is there a failure in the Ant build that prevents the junit reports to be written? Additionally the Ant build filters-out the JDBC4 stuff ?!? I thought it's not there in 1.3. The 1.3 build does the filtering, though I guess the filtering could be removed from the build in the 1.3 branch, since as part of the branch/release process, I check in the filtered sources. The filtering is left in so that on first build from branched sources, the build does the filtering and succeeds. I guess I could cut the filtering out of the 1.3 build, but then I would have to maintain a separate build script just to do the in-place filtering. Simply wondering, nothing serious. [snip] 1.4 (JDBC 4) version: http://people.apache.org/~psteitz/dbcp-1.4-rc1 http://people.apache.org/~psteitz/dbcp-1.4-rc1/site http://people.apache.org/~psteitz/dbcp-1.4-rc1/maven http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_4_RC1/ Builds from source and runs tests with IcedTea6 1.6.2, Sun JDK 1.6 and Sun JDK 1.7.0.0.alpha69 (add to README.txt ?!?). However it fails with IBM 1.6.0.6: == % --- Test set: org.apache.commons.dbcp.managed.TestBasicManagedDataSource --- Tests run: 46, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.398 sec FAILURE! testReallyClose(org.apache.commons.dbcp.managed.TestBasicManagedDataSource) Time elapsed: 0.066 sec FAILURE! junit.framework.AssertionFailedError: Expecting SQLException - XAResources orphaned at junit.framework.Assert.fail(Assert.java:47) at org.apache.commons.dbcp.managed.TestBasicManagedDataSource.testReallyClose(TestBasicManagedDataSource.java:72) == % Seems that the IBM JDK is behaving differently. Yes. Investigating... The build setup itself looks good though, except a minor nit: == % [WARNING] While downloading xml-apis:xml-apis:2.0.2 This artifact has been relocated to xml-apis:xml-apis:1.0.b2. == % xml-apis-2.0.2 is simply a wrong release and we should refer the correct one. I've replaced it with the latest release 1.3.04. Thanks! Phil - Jörg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [dbcp] 1.3/1.4 RC1 available for review
Phil Steitz wrote: Jörg Schaible wrote: Hi Phil, Phil Steitz wrote at Donnerstag, 10. Dezember 2009 12:42: Jörg Schaible wrote: Hi Phil, Phil Steitz wrote: I have prepared release candidates for DBCP 1.3 and 1.4. Please all interested parties have a look and test. If all goes well, I will kick off a release VOTE based on these artifacts in the next couple of days. I see these as really two sets of artifacts associated with one release, so I am inclined to just do one VOTE including both versions. If anyone disagrees with this, please speak up. I am happy to run two VOTEs. 1.3 (JDBC 3) version: http://people.apache.org/~psteitz/dbcp-1.3-rc1 http://people.apache.org/~psteitz/dbcp-1.3-rc1/site http://people.apache.org/~psteitz/dbcp-1.3-rc1/maven http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_3_RC1/ Like Nial I changed geronimo-jta_1.1_spec to version 1.1. My compiler zoo fails though for blackdown-jdk-1.4.2.03, jrockit-jdk-1.4.2.16 and sun- jdk-1.4.2.19. IMHO you must update the xerces version to a release that contains the driver implementation in the Java-SPI (META-INF/services): Thanks, Jorg. I really appreciate your running this through the zoo. Can you identify a suitable Xerces version? Actually I tried that yesterday. I've upgraded to xercesImpl-2.9.1 that contains the SPI entry for sure, but the test still fails. After looking into the code I've seen that the test explicitly sets the system property already. Even after moving that code from constructor into setUp the failure still occurs. This left be somewhat baffled, but I ran out of time to have a further look :-/ I am going to make this and the jta spec change and cut another RC. Thanks all for testing. Did you also see those: Yes. Investigating... [snip] I do not see those using IBM-JDK 1.5.0.10. With this I had a casually 1 failure, but no test reports are generated with Ant nor could I see on the console which test actually failed. Is there a failure in the Ant build that prevents the junit reports to be written? Forgot to respond to this. Yes, there is a missing format element that makes the build effectively silent. I will add that. Phil Additionally the Ant build filters-out the JDBC4 stuff ?!? I thought it's not there in 1.3. The 1.3 build does the filtering, though I guess the filtering could be removed from the build in the 1.3 branch, since as part of the branch/release process, I check in the filtered sources. The filtering is left in so that on first build from branched sources, the build does the filtering and succeeds. I guess I could cut the filtering out of the 1.3 build, but then I would have to maintain a separate build script just to do the in-place filtering. Simply wondering, nothing serious. [snip] 1.4 (JDBC 4) version: http://people.apache.org/~psteitz/dbcp-1.4-rc1 http://people.apache.org/~psteitz/dbcp-1.4-rc1/site http://people.apache.org/~psteitz/dbcp-1.4-rc1/maven http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_4_RC1/ Builds from source and runs tests with IcedTea6 1.6.2, Sun JDK 1.6 and Sun JDK 1.7.0.0.alpha69 (add to README.txt ?!?). However it fails with IBM 1.6.0.6: == % --- Test set: org.apache.commons.dbcp.managed.TestBasicManagedDataSource --- Tests run: 46, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.398 sec FAILURE! testReallyClose(org.apache.commons.dbcp.managed.TestBasicManagedDataSource) Time elapsed: 0.066 sec FAILURE! junit.framework.AssertionFailedError: Expecting SQLException - XAResources orphaned at junit.framework.Assert.fail(Assert.java:47) at org.apache.commons.dbcp.managed.TestBasicManagedDataSource.testReallyClose(TestBasicManagedDataSource.java:72) == % Seems that the IBM JDK is behaving differently. Yes. Investigating... The build setup itself looks good though, except a minor nit: == % [WARNING] While downloading xml-apis:xml-apis:2.0.2 This artifact has been relocated to xml-apis:xml-apis:1.0.b2. == % xml-apis-2.0.2 is simply a wrong release and we should refer the correct one. I've replaced it with the latest release 1.3.04. Thanks! Phil - Jörg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [dbcp] 1.3/1.4 RC1 available for review
Jörg Schaible wrote: Hi Phil, Phil Steitz wrote: I have prepared release candidates for DBCP 1.3 and 1.4. Please all interested parties have a look and test. If all goes well, I will kick off a release VOTE based on these artifacts in the next couple of days. I see these as really two sets of artifacts associated with one release, so I am inclined to just do one VOTE including both versions. If anyone disagrees with this, please speak up. I am happy to run two VOTEs. 1.3 (JDBC 3) version: http://people.apache.org/~psteitz/dbcp-1.3-rc1 http://people.apache.org/~psteitz/dbcp-1.3-rc1/site http://people.apache.org/~psteitz/dbcp-1.3-rc1/maven http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_3_RC1/ Like Nial I changed geronimo-jta_1.1_spec to version 1.1. My compiler zoo fails though for blackdown-jdk-1.4.2.03, jrockit-jdk-1.4.2.16 and sun- jdk-1.4.2.19. IMHO you must update the xerces version to a release that contains the driver implementation in the Java-SPI (META-INF/services): Thanks, Jorg. I really appreciate your running this through the zoo. Can you identify a suitable Xerces version? I am going to make this and the jta spec change and cut another RC. Thanks all for testing. Phil == % Test set: org.apache.commons.jocl.TestJOCLContentHandler --- Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.047 sec FAILURE! testObject(org.apache.commons.jocl.TestJOCLContentHandler) Time elapsed: 0.006 sec testPrimitives(org.apache.commons.jocl.TestJOCLContentHandler) Time elapsed: 0 sec testParse(org.apache.commons.jocl.TestJOCLContentHandler) Time elapsed: 0.028 sec ERROR! org.xml.sax.SAXException: System property org.xml.sax.driver not specified at org.xml.sax.helpers.XMLReaderFactory.createXMLReader(XMLReaderFactory.java:90) at org.apache.commons.jocl.JOCLContentHandler.parse(JOCLContentHandler.java:339) at org.apache.commons.jocl.JOCLContentHandler.parse(JOCLContentHandler.java:271) at org.apache.commons.jocl.TestJOCLContentHandler.testParse(TestJOCLContentHandler.java:255) == % Using IBM-JDK 1.4.2.13 the build and all tests with Ant 1.6.5 succeed, but I get nevertheless those exceptions, I do not see, when running the other JDKs with Maven: == % [junit] org.apache.commons.dbcp.AbandonedTrace$AbandonedObjectException: DBCP object created 2009-12-08 23:03:07 by the following code was never closed: [junit] at org.apache.commons.dbcp.AbandonedTrace.setStackTrace(AbandonedTrace.java:138) [junit] at org.apache.commons.dbcp.AbandonedObjectPool.borrowObject(AbandonedObjectPool.java:81) [junit] at org.apache.commons.dbcp.PoolingDataSource.getConnection(PoolingDataSource.java:106) [junit] at org.apache.commons.dbcp.BasicDataSource.getConnection(BasicDataSource.java:1044) [junit] at org.apache.commons.dbcp.TestAbandonedBasicDataSource.testAbandoned(TestAbandonedBasicDataSource.java:65) == % == % [junit] org.apache.commons.dbcp.AbandonedTrace$AbandonedObjectException: DBCP object created 2009-12-08 23:03:07 by the following code was never closed: [junit] at org.apache.commons.dbcp.AbandonedTrace.setStackTrace(AbandonedTrace.java:138) [junit] at org.apache.commons.dbcp.AbandonedObjectPool.borrowObject(AbandonedObjectPool.java:81) [junit] at org.apache.commons.dbcp.PoolingDataSource.getConnection(PoolingDataSource.java:106) [junit] at org.apache.commons.dbcp.BasicDataSource.getConnection(BasicDataSource.java:1044) [junit] at org.apache.commons.dbcp.TestBasicDataSource.getConnection(TestBasicDataSource.java:44) [junit] at org.apache.commons.dbcp.TestAbandonedBasicDataSource.testAbandonedClose(TestAbandonedBasicDataSource.java:75) == % == % [junit] org.apache.commons.dbcp.AbandonedTrace$AbandonedObjectException: DBCP object created 2009-12-08 23:03:07 by the following code was never closed:
Re: [dbcp] 1.3/1.4 RC1 available for review
Hi Phil, Phil Steitz wrote at Donnerstag, 10. Dezember 2009 12:42: Jörg Schaible wrote: Hi Phil, Phil Steitz wrote: I have prepared release candidates for DBCP 1.3 and 1.4. Please all interested parties have a look and test. If all goes well, I will kick off a release VOTE based on these artifacts in the next couple of days. I see these as really two sets of artifacts associated with one release, so I am inclined to just do one VOTE including both versions. If anyone disagrees with this, please speak up. I am happy to run two VOTEs. 1.3 (JDBC 3) version: http://people.apache.org/~psteitz/dbcp-1.3-rc1 http://people.apache.org/~psteitz/dbcp-1.3-rc1/site http://people.apache.org/~psteitz/dbcp-1.3-rc1/maven http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_3_RC1/ Like Nial I changed geronimo-jta_1.1_spec to version 1.1. My compiler zoo fails though for blackdown-jdk-1.4.2.03, jrockit-jdk-1.4.2.16 and sun- jdk-1.4.2.19. IMHO you must update the xerces version to a release that contains the driver implementation in the Java-SPI (META-INF/services): Thanks, Jorg. I really appreciate your running this through the zoo. Can you identify a suitable Xerces version? Actually I tried that yesterday. I've upgraded to xercesImpl-2.9.1 that contains the SPI entry for sure, but the test still fails. After looking into the code I've seen that the test explicitly sets the system property already. Even after moving that code from constructor into setUp the failure still occurs. This left be somewhat baffled, but I ran out of time to have a further look :-/ I am going to make this and the jta spec change and cut another RC. Thanks all for testing. Did you also see those: [snip] I do not see those using IBM-JDK 1.5.0.10. With this I had a casually 1 failure, but no test reports are generated with Ant nor could I see on the console which test actually failed. Is there a failure in the Ant build that prevents the junit reports to be written? Additionally the Ant build filters-out the JDBC4 stuff ?!? I thought it's not there in 1.3. Simply wondering, nothing serious. [snip] 1.4 (JDBC 4) version: http://people.apache.org/~psteitz/dbcp-1.4-rc1 http://people.apache.org/~psteitz/dbcp-1.4-rc1/site http://people.apache.org/~psteitz/dbcp-1.4-rc1/maven http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_4_RC1/ Builds from source and runs tests with IcedTea6 1.6.2, Sun JDK 1.6 and Sun JDK 1.7.0.0.alpha69 (add to README.txt ?!?). However it fails with IBM 1.6.0.6: == % --- Test set: org.apache.commons.dbcp.managed.TestBasicManagedDataSource --- Tests run: 46, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.398 sec FAILURE! testReallyClose(org.apache.commons.dbcp.managed.TestBasicManagedDataSource) Time elapsed: 0.066 sec FAILURE! junit.framework.AssertionFailedError: Expecting SQLException - XAResources orphaned at junit.framework.Assert.fail(Assert.java:47) at org.apache.commons.dbcp.managed.TestBasicManagedDataSource.testReallyClose(TestBasicManagedDataSource.java:72) == % Seems that the IBM JDK is behaving differently. The build setup itself looks good though, except a minor nit: == % [WARNING] While downloading xml-apis:xml-apis:2.0.2 This artifact has been relocated to xml-apis:xml-apis:1.0.b2. == % xml-apis-2.0.2 is simply a wrong release and we should refer the correct one. I've replaced it with the latest release 1.3.04. - Jörg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [dbcp] 1.3/1.4 RC1 available for review
On Dec 8, 2009, at 7:51 AM, Mark Thomas wrote: Phil Steitz wrote: I have prepared release candidates for DBCP 1.3 and 1.4. Please all interested parties have a look and test. If all goes well, I will kick off a release VOTE based on these artifacts in the next couple of days. I see these as really two sets of artifacts associated with one release, so I am inclined to just do one VOTE including both versions. If anyone disagrees with this, please speak up. I am happy to run two VOTEs. They look good to me. +1 - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [dbcp] 1.3/1.4 RC1 available for review
Phil Steitz wrote: I have prepared release candidates for DBCP 1.3 and 1.4. Please all interested parties have a look and test. If all goes well, I will kick off a release VOTE based on these artifacts in the next couple of days. I see these as really two sets of artifacts associated with one release, so I am inclined to just do one VOTE including both versions. If anyone disagrees with this, please speak up. I am happy to run two VOTEs. They look good to me. Mark - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [dbcp] 1.3/1.4 RC1 available for review
All the artifacts look good. DBCP 1.4 I ran the tests using m2 and JDK 1.6 and were fine. DBCP 1.3 Test ran fine using m2/JDK 1.5 - but failed to compile using ant/JDK 1.4 because one of the dependencies was built using JDK 1.5 I changed the dependency to use version 1.1 of geronimo-jta_1.1_spec (instead of 1.1.1) and the tests built and ran fine in ant. Its not IMO a blocker for release, but may cause confusion if anyone tries to build with JDK 1.4. Niall On Mon, Dec 7, 2009 at 11:37 AM, Phil Steitz phil.ste...@gmail.com wrote: I have prepared release candidates for DBCP 1.3 and 1.4. Please all interested parties have a look and test. If all goes well, I will kick off a release VOTE based on these artifacts in the next couple of days. I see these as really two sets of artifacts associated with one release, so I am inclined to just do one VOTE including both versions. If anyone disagrees with this, please speak up. I am happy to run two VOTEs. 1.3 (JDBC 3) version: http://people.apache.org/~psteitz/dbcp-1.3-rc1 http://people.apache.org/~psteitz/dbcp-1.3-rc1/site http://people.apache.org/~psteitz/dbcp-1.3-rc1/maven http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_3_RC1/ 1.4 (JDBC 4) version: http://people.apache.org/~psteitz/dbcp-1.4-rc1 http://people.apache.org/~psteitz/dbcp-1.4-rc1/site http://people.apache.org/~psteitz/dbcp-1.4-rc1/maven http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_4_RC1/ Release notes (common version, ships with both) http://people.apache.org/~psteitz/RELEASE-NOTES.txt There is also a recently opened documentation bug (DBCP-309) that I do not see as a showstopper for this release, but would appreciate feedback on the ticket and concurrence that we can push it to 1.3.1/1.4.1. Thanks! Phil - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [dbcp] 1.3/1.4 RC1 available for review
Hi Phil, Phil Steitz wrote: I have prepared release candidates for DBCP 1.3 and 1.4. Please all interested parties have a look and test. If all goes well, I will kick off a release VOTE based on these artifacts in the next couple of days. I see these as really two sets of artifacts associated with one release, so I am inclined to just do one VOTE including both versions. If anyone disagrees with this, please speak up. I am happy to run two VOTEs. 1.3 (JDBC 3) version: http://people.apache.org/~psteitz/dbcp-1.3-rc1 http://people.apache.org/~psteitz/dbcp-1.3-rc1/site http://people.apache.org/~psteitz/dbcp-1.3-rc1/maven http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_3_RC1/ Like Nial I changed geronimo-jta_1.1_spec to version 1.1. My compiler zoo fails though for blackdown-jdk-1.4.2.03, jrockit-jdk-1.4.2.16 and sun- jdk-1.4.2.19. IMHO you must update the xerces version to a release that contains the driver implementation in the Java-SPI (META-INF/services): == % Test set: org.apache.commons.jocl.TestJOCLContentHandler --- Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.047 sec FAILURE! testObject(org.apache.commons.jocl.TestJOCLContentHandler) Time elapsed: 0.006 sec testPrimitives(org.apache.commons.jocl.TestJOCLContentHandler) Time elapsed: 0 sec testParse(org.apache.commons.jocl.TestJOCLContentHandler) Time elapsed: 0.028 sec ERROR! org.xml.sax.SAXException: System property org.xml.sax.driver not specified at org.xml.sax.helpers.XMLReaderFactory.createXMLReader(XMLReaderFactory.java:90) at org.apache.commons.jocl.JOCLContentHandler.parse(JOCLContentHandler.java:339) at org.apache.commons.jocl.JOCLContentHandler.parse(JOCLContentHandler.java:271) at org.apache.commons.jocl.TestJOCLContentHandler.testParse(TestJOCLContentHandler.java:255) == % Using IBM-JDK 1.4.2.13 the build and all tests with Ant 1.6.5 succeed, but I get nevertheless those exceptions, I do not see, when running the other JDKs with Maven: == % [junit] org.apache.commons.dbcp.AbandonedTrace$AbandonedObjectException: DBCP object created 2009-12-08 23:03:07 by the following code was never closed: [junit] at org.apache.commons.dbcp.AbandonedTrace.setStackTrace(AbandonedTrace.java:138) [junit] at org.apache.commons.dbcp.AbandonedObjectPool.borrowObject(AbandonedObjectPool.java:81) [junit] at org.apache.commons.dbcp.PoolingDataSource.getConnection(PoolingDataSource.java:106) [junit] at org.apache.commons.dbcp.BasicDataSource.getConnection(BasicDataSource.java:1044) [junit] at org.apache.commons.dbcp.TestAbandonedBasicDataSource.testAbandoned(TestAbandonedBasicDataSource.java:65) == % == % [junit] org.apache.commons.dbcp.AbandonedTrace$AbandonedObjectException: DBCP object created 2009-12-08 23:03:07 by the following code was never closed: [junit] at org.apache.commons.dbcp.AbandonedTrace.setStackTrace(AbandonedTrace.java:138) [junit] at org.apache.commons.dbcp.AbandonedObjectPool.borrowObject(AbandonedObjectPool.java:81) [junit] at org.apache.commons.dbcp.PoolingDataSource.getConnection(PoolingDataSource.java:106) [junit] at org.apache.commons.dbcp.BasicDataSource.getConnection(BasicDataSource.java:1044) [junit] at org.apache.commons.dbcp.TestBasicDataSource.getConnection(TestBasicDataSource.java:44) [junit] at org.apache.commons.dbcp.TestAbandonedBasicDataSource.testAbandonedClose(TestAbandonedBasicDataSource.java:75) == % == % [junit] org.apache.commons.dbcp.AbandonedTrace$AbandonedObjectException: DBCP object created 2009-12-08 23:03:07 by the following code was never closed: [junit] at org.apache.commons.dbcp.AbandonedTrace.setStackTrace(AbandonedTrace.java:138) [junit] at org.apache.commons.dbcp.AbandonedObjectPool.borrowObject(AbandonedObjectPool.java:81) [junit] at
Re: [dbcp] 1.3/1.4 RC1 available for review
Phil Steitz wrote: I am inclined to just do one VOTE +1 There is also a recently opened documentation bug (DBCP-309) that I do not see as a showstopper for this release, but would appreciate feedback on the ticket and concurrence that we can push it to 1.3.1/1.4.1. +1 Mark - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
