Re: MacOS Safari
There was just a discussion where I showed that the meta key you can get with javascript does give you the apple/command key state. In fact I have a change in the code for my RoundCube install that uses the apple/command key instead of control and it works in Firefox and Safari. That way I can use command-click for non-contiguous multiple select. : jamie On Tue, 14 Mar 2006 17:18:27 -0700, Jacob Brunson [EMAIL PROTECTED] wrote: The scrolling problem should have been fixed with the patches that I submitted a while ago, and it should be fixed with the latest problem. Macs have 4 modifier keys: shift, ctrl, alt/option, apple-key, but they aren't used quite as they are on linux/windows systems. The apple-key is used on a mac where you would normally use a ctrl key on windows (press apple-x to cut instead of ctrl-x). Because macs only have one mouse button, normally you would use the ctrl key with a mouse click to get the context menu (ctrl-click = right mouse button). This creates some problems with safari because a ctrl-click looks like both a ctrl-click and a right mouse button click. This is the problem you seem to be having with the ctrl-click in roundcube. Unfortunately, I know of no ways to detect the apple modifier key from javascript in roundcube. I didn't follow the latest round of changes to try and address the ctrl-click mac bugs, so I don't know what was submitted and if it fixes anything. I'm running the latest public cvs and can say that ctrl-anything doesn't work. The only other thing I can say about safari is that using the arrow keys on the keyboard don't work well. They will always cause the message list frame to scroll to the top. This is a bug in safari (http://bugzilla.opendarwin.org/show_bug.cgi?id=4944). --Jacob On Tuesday 14 March 2006 15:23, Charles McNulty wrote: Tony, Try the latest CVS and see if the selecting works any better. I checked in some changes to try to address the ctrl-click Mac bugs, but I didn't get them in in time to be included in the .1 version. You can also look back in the list archives for the discussion that Jacob and I had around the middle of February. We were passing patches back and forth that might be of use to you. Basically it didn't work because Mac's don't *have* a control key, as best I can tell. I fixed it so that on at least some browsers it will use the Command key or whatever you guys call it. I still haven't been able to test it, so any feedback is appreciated. This is the first I've heard of the scrollbar not working. Is anyone else experiencing this. Jacob (if you're still around) , is this something you experienced? -Charles Tony Zielinski wrote: I was surprised to find that ctrl+click does not work in the inbox in the popular Safari browser on MacOS. Shift+click works fine, just not ctrl+click. Works fine in Firefox and IE. Also, the scrollbar does not work in the inbox list surprisingly. I can see the bar, but it just won't move. I'm using the latest release of Safari on Mac OSX Tiger and the latest stable beta of RoundCube. If you want to really screw up the interface, try sending yourself an HTML email using DIVS to layout the page. All of the graphics end up in the upper-left-most corner of the browser window behind the roundcube logo. This seems to be true across IE and Firefox.
Re: shift-select and control-select patch
I tried applying these changes and the command key still doesn't do anything. If I use ctrl-click I get the desired behavior but no context-menu (maybe that's just a change in the newer app.js I downloaded from cvs) except if I hold ctrl-shift-click the context menu flashes up for a second and disappears. I'll make sure I've updated the entire app from cvs later tonight and re-apply the patch and test. : jamie By doing just a little each day, I can gradually let the task overwhelm me. On Fri, 03 Mar 2006 08:54:02 -0600, Charles McNulty [EMAIL PROTECTED] wrote: Can someone with a Mac test this patch and see if it works for IE and/or Mozilla, Safari, etc? Again what is being tested it the use of the Command key for selecting single non-continuous messages. -Charles Charles McNulty wrote: Actually, looking at the code again, it might not be that hard to support IE for Mac. Can any Mac users confirm on this page: http://www.quirksmode.org/js/events/keys.html that the keyCode for Command is 91? -Charles Jamie Halmick wrote: The standard behavior is for command-click to perform non-contiguous multiple select. shift-click performs contiguous multiple select command-shift-click appears to perform just like shift-click At least that's how it works in the Finder, which I think should be the Mac reference for this type of behaviour. I think that substituting command for control with the current roundcube behaviour would be fine though as it's really just more functionality. : jamie Much human ingenuity has gone into finding the ultimate Before. The current state of knowledge can be summarized thus: In the beginning, there was nothing, which exploded - Terry Pratchett On Thu, 02 Mar 2006 16:21:20 -0600, Charles McNulty [EMAIL PROTECTED] wrote: Is that the standard behavior for Macs? When I implemented the select/control-click behavior, I studied exactly what Outlook, Outlook Express and Thunderbird did in Windows (XP) and attempted to emulate that exact behavior. I don't have a Mac, but if someone could describe the exact behavior and key combinations with a Mac on a similar set of standard applications, I'd be happy to attempt to implement it. Key combinations to test are: Click Shift-Click Command-Click Command-Shift-Click Situations to test are each of these in different combinations with each other in different scenarios: When nothing is selected When a continous list of things are selected When a non-continuous list of things are selected So for instance, what happens when you click a list item, shift-click an item 5 below it, command-click an item two up from that one and then command-shift-click an item another 10 up from that? If you can tell me definitively that a Command-click and command-shift-click do the exact same thing in all situations as a Control, then that will be an easy change. The key is predictability. What I'm going for here is the exact same behavior in RC as in ... well whatever you Mac users use for e-mail. -Charles Jamie Halmick wrote: This new select behavior is nice for contiguous selection but doesn't really work on Macintosh. When you control-click you get the context menu (right click for Mac). Can you add the behavior so that the Command key will do the same on the Mac as Control? : jamie I love deadlines. I like the whooshing sound they make as they fly by - Douglas Adams
Re: shift-select and control-select patch
I'll try to look into this myself over the weekend. Your patch shows me where to look in the code so I'll see if I can make it work. Thanks. : jamie Software is too important to be left to programmers. - Meilir Page-Jones On Fri, 03 Mar 2006 13:11:38 -0600, Charles McNulty [EMAIL PROTECTED] wrote: Removing the context menu is definitely an unrelated change in app.js. Thanks for testing it for me. If nothing different is happening at all, I suspect that it's because the javascript code that recognizes the platform isn't working properly. There's not much more I can offer than what I already have without having a Mac to test on. -Charles Jamie Halmick wrote: I tried applying these changes and the command key still doesn't do anything. If I use ctrl-click I get the desired behavior but no context-menu (maybe that's just a change in the newer app.js I downloaded from cvs) except if I hold ctrl-shift-click the context menu flashes up for a second and disappears. I'll make sure I've updated the entire app from cvs later tonight and re-apply the patch and test. : jamie By doing just a little each day, I can gradually let the task overwhelm me. On Fri, 03 Mar 2006 08:54:02 -0600, Charles McNulty [EMAIL PROTECTED] wrote: Can someone with a Mac test this patch and see if it works for IE and/or Mozilla, Safari, etc? Again what is being tested it the use of the Command key for selecting single non-continuous messages. -Charles Charles McNulty wrote: Actually, looking at the code again, it might not be that hard to support IE for Mac. Can any Mac users confirm on this page: http://www.quirksmode.org/js/events/keys.html that the keyCode for Command is 91? -Charles Jamie Halmick wrote: The standard behavior is for command-click to perform non-contiguous multiple select. shift-click performs contiguous multiple select command-shift-click appears to perform just like shift-click At least that's how it works in the Finder, which I think should be the Mac reference for this type of behaviour. I think that substituting command for control with the current roundcube behaviour would be fine though as it's really just more functionality. : jamie Much human ingenuity has gone into finding the ultimate Before. The current state of knowledge can be summarized thus: In the beginning, there was nothing, which exploded - Terry Pratchett On Thu, 02 Mar 2006 16:21:20 -0600, Charles McNulty [EMAIL PROTECTED] wrote: Is that the standard behavior for Macs? When I implemented the select/control-click behavior, I studied exactly what Outlook, Outlook Express and Thunderbird did in Windows (XP) and attempted to emulate that exact behavior. I don't have a Mac, but if someone could describe the exact behavior and key combinations with a Mac on a similar set of standard applications, I'd be happy to attempt to implement it. Key combinations to test are: Click Shift-Click Command-Click Command-Shift-Click Situations to test are each of these in different combinations with each other in different scenarios: When nothing is selected When a continous list of things are selected When a non-continuous list of things are selected So for instance, what happens when you click a list item, shift-click an item 5 below it, command-click an item two up from that one and then command-shift-click an item another 10 up from that? If you can tell me definitively that a Command-click and command-shift-click do the exact same thing in all situations as a Control, then that will be an easy change. The key is predictability. What I'm going for here is the exact same behavior in RC as in ... well whatever you Mac users use for e-mail. -Charles Jamie Halmick wrote: This new select behavior is nice for contiguous selection but doesn't really work on Macintosh. When you control-click you get the context menu (right click for Mac). Can you add the behavior so that the Command key will do the same on the Mac as Control? : jamie I love deadlines. I like the whooshing sound they make as they fly by - Douglas Adams
Re: shift-select and control-select patch
This new select behavior is nice for contiguous selection but doesn't really work on Macintosh. When you control-click you get the context menu (right click for Mac). Can you add the behavior so that the Command key will do the same on the Mac as Control? : jamie I love deadlines. I like the whooshing sound they make as they fly by. - Douglas Adams
Re: shift-select and control-select patch
The standard behavior is for command-click to perform non-contiguous multiple select. shift-click performs contiguous multiple select command-shift-click appears to perform just like shift-click At least that's how it works in the Finder, which I think should be the Mac reference for this type of behaviour. I think that substituting command for control with the current roundcube behaviour would be fine though as it's really just more functionality. : jamie Much human ingenuity has gone into finding the ultimate Before. The current state of knowledge can be summarized thus: In the beginning, there was nothing, which exploded - Terry Pratchett On Thu, 02 Mar 2006 16:21:20 -0600, Charles McNulty [EMAIL PROTECTED] wrote: Is that the standard behavior for Macs? When I implemented the select/control-click behavior, I studied exactly what Outlook, Outlook Express and Thunderbird did in Windows (XP) and attempted to emulate that exact behavior. I don't have a Mac, but if someone could describe the exact behavior and key combinations with a Mac on a similar set of standard applications, I'd be happy to attempt to implement it. Key combinations to test are: Click Shift-Click Command-Click Command-Shift-Click Situations to test are each of these in different combinations with each other in different scenarios: When nothing is selected When a continous list of things are selected When a non-continuous list of things are selected So for instance, what happens when you click a list item, shift-click an item 5 below it, command-click an item two up from that one and then command-shift-click an item another 10 up from that? If you can tell me definitively that a Command-click and command-shift-click do the exact same thing in all situations as a Control, then that will be an easy change. The key is predictability. What I'm going for here is the exact same behavior in RC as in ... well whatever you Mac users use for e-mail. -Charles Jamie Halmick wrote: This new select behavior is nice for contiguous selection but doesn't really work on Macintosh. When you control-click you get the context menu (right click for Mac). Can you add the behavior so that the Command key will do the same on the Mac as Control? : jamie I love deadlines. I like the whooshing sound they make as they fly by - Douglas Adams
