Re: svn commit: r1537302 - /maven/plugins/trunk/maven-rar-plugin/src/main/java/org/apache/maven/plugin/rar/RarMojo.java
On Thu, 31 Oct 2013 00:20:27 +0100
Bernd Eckenfels e...@zusammenkunft.net wrote:
Am 31.10.2013, 00:06 Uhr, schrieb Olivier Lamy ol...@apache.org:
On 31 October 2013 08:01, tche...@apache.org wrote:
+@Parameter( property = maven.rar.skip )
+private boolean skip;
Does it make sense to add a expression=${maven.rar.skip} (or maybe
${skipMavenRar}?). Especially the skip function is usefull from the
command line.
Hum I follow the *convention* used by other plugins :
maven.test.skip
maven.javadoc.skip
maven.install.skip
...
Bernd
+if ( skip )
+{
+getLog().info( Skipping rar generation. );
+}
+
really skipping? :-)
getLog().debug( === RarMojo settings === );
getLog().debug( rarSourceDirectory[ + rarSourceDirectory +
] );
getLog().debug( manifestFile[ + manifestFile + ] );
Is there a best practise for printing parameters before or after early
return?
I don't know
tony.
--
Tony Chemit
tél: +33 (0) 2 40 50 29 28
http://www.codelutin.com
email: che...@codelutin.com
twitter: https://twitter.com/tchemit
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
Re: svn commit: r1537302 - /maven/plugins/trunk/maven-rar-plugin/src/main/java/org/apache/maven/plugin/rar/RarMojo.java
Le jeudi 31 octobre 2013 07:54:25 Tony Chemit a écrit :
On Thu, 31 Oct 2013 00:20:27 +0100
Bernd Eckenfels e...@zusammenkunft.net wrote:
Am 31.10.2013, 00:06 Uhr, schrieb Olivier Lamy ol...@apache.org:
On 31 October 2013 08:01, tche...@apache.org wrote:
+@Parameter( property = maven.rar.skip )
+private boolean skip;
Does it make sense to add a expression=${maven.rar.skip} (or maybe
${skipMavenRar}?). Especially the skip function is usefull from the
command line.
Hum I follow the *convention* used by other plugins :
maven.test.skip
maven.javadoc.skip
maven.install.skip
...
in fact, the convention is about the parameter name
but for the way to configure the parameter (ie parameter vs expression), it's
more than a convention, it's a change in plugin-tools in version 3.0, done
when adding Java 5 annotations support: expression was the parameter name
provided as javadoc annotations, but it was changed in Java 5 annotations:
1. expanded to not need ${} in http://jira.codehaus.org/browse/MPLUGIN-194
2. renamed to property in http://jira.codehaus.org/browse/MPLUGIN-196
And this means that @Parameter( property = maven.rar.skip ) makes the
property available from the command line, no problem
Regards,
Hervé
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven Release Plugin version 2.4.2
Hi Robert, Am 30.10.2013 19:48, schrieb Robert Scholte: I haven't finished the complete release process yet. There seems to be some misconfiguration to publish/copy the staged docs to production. So I need to fix that first before I'll update the plugins page and send the announcement. No hurry, I just was in the process of checking for updated plugins in my POMs and noticed the release plugin 2.4.2 and thought the docs just had been forgotten to update, so I wanted to drop a note. Greetings -Sascha- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: svn commit: r1537302 - /maven/plugins/trunk/maven-rar-plugin/src/main/java/org/apache/maven/plugin/rar/RarMojo.java
Hello,
Am 31.10.2013, 10:36 Uhr, schrieb Hervé BOUTEMY herve.bout...@free.fr:
but for the way to configure the parameter (ie parameter vs expression),
it's
more than a convention, it's a change in plugin-tools in version 3.0,
done
when adding Java 5 annotations support: expression was the parameter name
provided as javadoc annotations, but it was changed in Java 5
annotations:
1. expanded to not need ${} in
http://jira.codehaus.org/browse/MPLUGIN-194
2. renamed to property in http://jira.codehaus.org/browse/MPLUGIN-196
I see, I was checking a random documentation page on the Web first because
I remebered having seen expressions as default values to be usefull in the
Mojos (and some did not had some).
I was first visiting this page:
http://maven.apache.org/plugin-tools/maven-plugin-tools-annotations/index.html
But as it did not describe the defaultValue/property so I was following
the link at the end to
http://maven.apache.org/developers/mojo-api-specification.html#The_Descriptor_and_Annotations
And I missed the fact that this is not describing the Java annotations but
the JavaDoc ones. So sorry for the confusion. (But maybe it would be
helpful to change the table header from Annotations to JavaDoc Tag?
And the new annotations page really need a detailed description (javadoc?)
of the annotation attributes or link to the apidoc, like:
http://maven.apache.org/plugin-tools/maven-plugin-annotations/apidocs/index.html
And this means that @Parameter( property = maven.rar.skip ) makes the
property available from the command line, no problem
Agreed, you diagnosted the right reason for my wrong comment :)
Bernd
--
http://www.zusammenkunft.net
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[ANN] Apache Maven Release Plugin 2.4.2 Released
The Apache Maven team is pleased to announce the release of the Apache Maven Release Plugin, version 2.4.2 This plugin is used to release a project with Maven, saving a lot of repetitive, manual work. Releasing a project is made in two steps: prepare and perform. http://maven.apache.org/plugins/maven-release-plugin/ You should specify the version in your project's plugin configuration: plugin groupIdorg.apache.maven.plugins/groupId artifactIdmaven-release-plugin/artifactId version2.4.2/version /plugin Release Notes - Maven Release Plugin - Version 2.4.2 ** Bug * [MRELEASE-766] - release:prepare stores settings.xml in a public directory * [MRELEASE-832] - When performing a release, username and password parameters are ignored. * [MRELEASE-846] - m2 release plugin exposes SCM password in release.properties file Enjoy, -The Apache Maven team - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: svn commit: r1537302 - /maven/plugins/trunk/maven-rar-plugin/src/main/java/org/apache/maven/plugin/rar/RarMojo.java
I updated
http://maven.apache.org/developers/mojo-api-specification.html#The_Descriptor_and_Annotations
any other good idea welcome
Regards,
Hervé
Le jeudi 31 octobre 2013 17:12:38 vous avez écrit :
Hello,
Am 31.10.2013, 10:36 Uhr, schrieb Hervé BOUTEMY herve.bout...@free.fr:
but for the way to configure the parameter (ie parameter vs expression),
it's
more than a convention, it's a change in plugin-tools in version 3.0,
done
when adding Java 5 annotations support: expression was the parameter name
provided as javadoc annotations, but it was changed in Java 5
annotations:
1. expanded to not need ${} in
http://jira.codehaus.org/browse/MPLUGIN-194
2. renamed to property in http://jira.codehaus.org/browse/MPLUGIN-196
I see, I was checking a random documentation page on the Web first because
I remebered having seen expressions as default values to be usefull in the
Mojos (and some did not had some).
I was first visiting this page:
http://maven.apache.org/plugin-tools/maven-plugin-tools-annotations/index.ht
ml
But as it did not describe the defaultValue/property so I was following
the link at the end to
http://maven.apache.org/developers/mojo-api-specification.html#The_Descripto
r_and_Annotations
And I missed the fact that this is not describing the Java annotations but
the JavaDoc ones. So sorry for the confusion. (But maybe it would be
helpful to change the table header from Annotations to JavaDoc Tag?
And the new annotations page really need a detailed description (javadoc?)
of the annotation attributes or link to the apidoc, like:
http://maven.apache.org/plugin-tools/maven-plugin-annotations/apidocs/index.
html
And this means that @Parameter( property = maven.rar.skip ) makes the
property available from the command line, no problem
Agreed, you diagnosted the right reason for my wrong comment :)
Bernd
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
