How to use a plexus component inside a maven report ?
Hi, Let me explain my problem, hopes to find here a solution about it. I am currently writing a maven report to describe some plexus components. The idea is to be able to describe the components declared in the very same maven module. I tried this, it found components of the same role from the dependencies, but not the one declared in the module : @org.apache.maven.plugins.annotations.Component(role = TagValueDefinitionProvider.class) protected MapString, TagValueDefinitionProvider tagValueProviders; What did I miss ? Thanks for any help. tony. -- Tony Chemit tél: +33 (0) 2 40 50 29 28 http://www.codelutin.com email: che...@codelutin.com twitter: https://twitter.com/tchemit - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: How to use a plexus component inside a maven report ?
you mean you're trying to do something like plexus:components-report [1]? are you sure you generated the plexus descriptor before running the mojo injecting implementations? Regards, Hervé [1] http://plexus.codehaus.org/plexus-maven-plugin/components-report-mojo.html Le samedi 31 mai 2014 10:05:06 Tony Chemit a écrit : Hi, Let me explain my problem, hopes to find here a solution about it. I am currently writing a maven report to describe some plexus components. The idea is to be able to describe the components declared in the very same maven module. I tried this, it found components of the same role from the dependencies, but not the one declared in the module : @org.apache.maven.plugins.annotations.Component(role = TagValueDefinitionProvider.class) protected MapString, TagValueDefinitionProvider tagValueProviders; What did I miss ? Thanks for any help. tony. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Github pull requests for Maven Core
http://java.dzone.com/articles/squashing-github-pull-requests ? Regards, Hervé Le vendredi 30 mai 2014 09:57:18 Jason van Zyl a écrit : I'm happy to look at pull requests but in the future can anyone making a pull request please squash your commits before making the pull request. Eventually I want to use Gerrit and create a mechanism where pull requests can be tested against the ITs to make it easier for contributors to know they haven't broken anything. Thanks, Jason -- Jason van Zyl Founder, Apache Maven http://twitter.com/jvanzyl http://twitter.com/takari_io - We know what we are, but know not what we may be. -- Shakespeare - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: How to use a plexus component inside a maven report ?
On Sat, 31 May 2014 11:19:57 +0200
Hervé BOUTEMY herve.bout...@free.fr wrote:
you mean you're trying to do something like plexus:components-report [1]?
Yes
are you sure you generated the plexus descriptor before running the mojo
injecting implementations?
Yes,
project/target/classes/META-INF/plexus/components.xml is there.
The maven plugin is here:
http://svn.nuiton.org/eugene/trunk/eugene-maven-plugin/src/main/java/org/nuiton/eugene/plugin/AbstractEugeneReport.java
http://svn.nuiton.org/eugene/trunk/eugene-maven-plugin/src/main/java/org/nuiton/eugene/plugin/TagValueReport.java
I managed to use it adding this configuration in the pluginManagement
plugin
groupIdorg.nuiton.eugene/groupId
artifactIdeugene-maven-plugin/artifactId
dependencies
dependency
groupId${project.groupId}/groupId
artifactId${project.artifactId}/artifactId
version${project.version}/version
/dependency
/dependencies
/plugin
but it look a bit strange to do this, plus it won't work if the project was
never built...
Regards,
Hervé
[1] http://plexus.codehaus.org/plexus-maven-plugin/components-report-mojo.html
Le samedi 31 mai 2014 10:05:06 Tony Chemit a écrit :
Hi,
Let me explain my problem, hopes to find here a solution about it.
I am currently writing a maven report to describe some plexus components.
The idea is to be able to describe the components declared in the very same
maven module.
I tried this, it found components of the same role from the dependencies,
but not the one declared in the module :
@org.apache.maven.plugins.annotations.Component(role =
TagValueDefinitionProvider.class) protected MapString,
TagValueDefinitionProvider tagValueProviders;
What did I miss ?
Thanks for any help.
tony.
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
--
Tony Chemit
tél: +33 (0) 2 40 50 29 28
http://www.codelutin.com
email: che...@codelutin.com
twitter: https://twitter.com/tchemit
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
Re: How to use a plexus component inside a maven report ?
logical, finally: why would the plugin classpath contain actual project?
And since resolution happens from workspace, I imagine that the plugin can get
classes just after compile phase, isn't it?
Regards,
Hervé
Le samedi 31 mai 2014 12:46:34 Tony Chemit a écrit :
On Sat, 31 May 2014 11:19:57 +0200
Hervé BOUTEMY herve.bout...@free.fr wrote:
you mean you're trying to do something like plexus:components-report [1]?
Yes
are you sure you generated the plexus descriptor before running the mojo
injecting implementations?
Yes,
project/target/classes/META-INF/plexus/components.xml is there.
The maven plugin is here:
http://svn.nuiton.org/eugene/trunk/eugene-maven-plugin/src/main/java/org/nui
ton/eugene/plugin/AbstractEugeneReport.java
http://svn.nuiton.org/eugene/trunk/eugene-maven-plugin/src/main/java/org/nu
iton/eugene/plugin/TagValueReport.java
I managed to use it adding this configuration in the pluginManagement
plugin
groupIdorg.nuiton.eugene/groupId
artifactIdeugene-maven-plugin/artifactId
dependencies
dependency
groupId${project.groupId}/groupId
artifactId${project.artifactId}/artifactId
version${project.version}/version
/dependency
/dependencies
/plugin
but it look a bit strange to do this, plus it won't work if the project was
never built...
Regards,
Hervé
[1]
http://plexus.codehaus.org/plexus-maven-plugin/components-report-mojo.htm
l
Le samedi 31 mai 2014 10:05:06 Tony Chemit a écrit :
Hi,
Let me explain my problem, hopes to find here a solution about it.
I am currently writing a maven report to describe some plexus
components.
The idea is to be able to describe the components declared in the very
same
maven module.
I tried this, it found components of the same role from the
dependencies,
but not the one declared in the module :
@org.apache.maven.plugins.annotations.Component(role =
TagValueDefinitionProvider.class) protected MapString,
TagValueDefinitionProvider tagValueProviders;
What did I miss ?
Thanks for any help.
tony.
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
Re: How to use a plexus component inside a maven report ?
Le samedi 31 mai 2014 13:55:47 Hervé BOUTEMY a écrit :
logical, finally: why would the plugin classpath contain actual project?
And since resolution happens from workspace, I imagine that the plugin can
get classes just after compile phase, isn't it?
s/workspace/reactor/
Regards,
Hervé
Le samedi 31 mai 2014 12:46:34 Tony Chemit a écrit :
On Sat, 31 May 2014 11:19:57 +0200
Hervé BOUTEMY herve.bout...@free.fr wrote:
you mean you're trying to do something like plexus:components-report
[1]?
Yes
are you sure you generated the plexus descriptor before running the mojo
injecting implementations?
Yes,
project/target/classes/META-INF/plexus/components.xml is there.
The maven plugin is here:
http://svn.nuiton.org/eugene/trunk/eugene-maven-plugin/src/main/java/org/n
ui ton/eugene/plugin/AbstractEugeneReport.java
http://svn.nuiton.org/eugene/trunk/eugene-maven-plugin/src/main/java/org/n
u
iton/eugene/plugin/TagValueReport.java
I managed to use it adding this configuration in the pluginManagement
plugin
groupIdorg.nuiton.eugene/groupId
artifactIdeugene-maven-plugin/artifactId
dependencies
dependency
groupId${project.groupId}/groupId
artifactId${project.artifactId}/artifactId
version${project.version}/version
/dependency
/dependencies
/plugin
but it look a bit strange to do this, plus it won't work if the project
was
never built...
Regards,
Hervé
[1]
http://plexus.codehaus.org/plexus-maven-plugin/components-report-mojo.ht
m
l
Le samedi 31 mai 2014 10:05:06 Tony Chemit a écrit :
Hi,
Let me explain my problem, hopes to find here a solution about it.
I am currently writing a maven report to describe some plexus
components.
The idea is to be able to describe the components declared in the very
same
maven module.
I tried this, it found components of the same role from the
dependencies,
but not the one declared in the module :
@org.apache.maven.plugins.annotations.Component(role =
TagValueDefinitionProvider.class) protected MapString,
TagValueDefinitionProvider tagValueProviders;
What did I miss ?
Thanks for any help.
tony.
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44749028 Any updates on my pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...
I applied your changes and your test fails. If you want to take look and validate I will take a look later in the weekend. --- T E S T S --- Running org.apache.maven.model.building.ComplexActivationTest Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.171 sec FAILURE! - in org.apache.maven.model.building.ComplexActivationTest testAndConditionInActivation(org.apache.maven.model.building.ComplexActivationTest) Time elapsed: 0.158 sec FAILURE! junit.framework.AssertionFailedError at junit.framework.Assert.fail(Assert.java:47) at junit.framework.Assert.assertTrue(Assert.java:20) at junit.framework.Assert.assertNull(Assert.java:230) at junit.framework.Assert.assertNull(Assert.java:223) at org.apache.maven.model.building.ComplexActivationTest.testAndConditionInActivation(ComplexActivationTest.java:52) Running org.apache.maven.model.building.DefaultModelBuilderFactoryTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.005 sec - in org.apache.maven.model.building.DefaultModelBuilderFactoryTest Running org.apache.maven.model.inheritance.DefaultInheritanceAssemblerTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.678 sec - in org.apache.maven.model.inheritance.DefaultInheritanceAssemblerTest Running org.apache.maven.model.interpolation.StringSearchModelInterpolatorTest Tests run: 28, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.579 sec - in org.apache.maven.model.interpolation.StringSearchModelInterpolatorTest Running org.apache.maven.model.path.DefaultUrlNormalizerTest Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in org.apache.maven.model.path.DefaultUrlNormalizerTest Running org.apache.maven.model.profile.activation.JdkVersionProfileActivatorTest Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.103 sec - in org.apache.maven.model.profile.activation.JdkVersionProfileActivatorTest Running org.apache.maven.model.profile.activation.PropertyProfileActivatorTest Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.13 sec - in org.apache.maven.model.profile.activation.PropertyProfileActivatorTest Running org.apache.maven.model.validation.DefaultModelValidatorTest Tests run: 44, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.512 sec - in org.apache.maven.model.validation.DefaultModelValidatorTest Results : Failed tests: org.apache.maven.model.building.ComplexActivationTest#testAndConditionInActivation AssertionFailedError On May 31, 2014, at 10:00 AM, MysterionRise g...@git.apache.org wrote: Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44749028 Any updates on my pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org Thanks, Jason -- Jason van Zyl Founder, Apache Maven http://twitter.com/jvanzyl http://twitter.com/takari_io -
Re: Github pull requests for Maven Core
Hi, What do you mean by squashing commits? Do you mean: * intermediate crappy/local commits that were incorrectly pushed as-is without having been rebased interactively to provide a clean and understandable history (see the link provided by Hervé as an example) * or that any PR should be squashed into one and only one commit? I totally agree with the first proposition, but would disagree with the latter. Thanks for the clarification. 2014-05-30 15:57 GMT+02:00 Jason van Zyl ja...@takari.io: I'm happy to look at pull requests but in the future can anyone making a pull request please squash your commits before making the pull request. Eventually I want to use Gerrit and create a mechanism where pull requests can be tested against the ITs to make it easier for contributors to know they haven't broken anything. Thanks, Jason -- Jason van Zyl Founder, Apache Maven http://twitter.com/jvanzyl http://twitter.com/takari_io - We know what we are, but know not what we may be. -- Shakespeare -- Baptiste Batmat MATHUS - http://batmat.net Sauvez un arbre, Mangez un castor ! nbsp;!
Re: Github pull requests for Maven Core
On May 31, 2014, at 11:05 AM, Baptiste Mathus m...@batmat.net wrote: Hi, What do you mean by squashing commits? That a pull request should consist of a single, coherent commit. So during the development of the pull request it may consist of several commits but in its final form it needs to be a single commit that corresponds to the change. You normally use git rebase -i sha1-before-your-changes to associate all changes with one commit. You refer to this as squashing. Generally I now try to add a feature or change in a single commit, makes the history easier to look at. Do you mean: * intermediate crappy/local commits that were incorrectly pushed as-is without having been rebased interactively to provide a clean and understandable history (see the link provided by Hervé as an example) * or that any PR should be squashed into one and only one commit? I totally agree with the first proposition, but would disagree with the latter. Thanks for the clarification. 2014-05-30 15:57 GMT+02:00 Jason van Zyl ja...@takari.io: I'm happy to look at pull requests but in the future can anyone making a pull request please squash your commits before making the pull request. Eventually I want to use Gerrit and create a mechanism where pull requests can be tested against the ITs to make it easier for contributors to know they haven't broken anything. Thanks, Jason -- Jason van Zyl Founder, Apache Maven http://twitter.com/jvanzyl http://twitter.com/takari_io - We know what we are, but know not what we may be. -- Shakespeare -- Baptiste Batmat MATHUS - http://batmat.net Sauvez un arbre, Mangez un castor ! nbsp;! Thanks, Jason -- Jason van Zyl Founder, Apache Maven http://twitter.com/jvanzyl http://twitter.com/takari_io - The modern conservative is engaged in one of man's oldest exercises in moral philosophy; that is, the search for a superior moral justification for selfishness. -- John Kenneth Galbraith
[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44751378 Could you tell me, what did you use? I've run tests on Linux: mvn -version Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19 17:51:28+0400) Maven home: /home/mysterion/Downloads/apache-maven-3.0.5 Java version: 1.7.0_25, vendor: Oracle Corporation Java home: /home/mysterion/Downloads/jdk1.7.0_25/jre Default locale: en_US, platform encoding: UTF-8 OS name: linux, version: 3.13.0-27-generic, arch: amd64, family: unix also, i've try with windows mvn -version Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9; 2014-02-14T21:37:5 2+04:00) Maven home: C:\Users\User\Downloads\apache-maven-3.2.1-bin\apache-maven-3.2.1\bi n\.. Java version: 1.7.0_55, vendor: Oracle Corporation Java home: C:\Program Files (x86)\Java\jdk1.7.0_55\jre Default locale: ru_RU, platform encoding: Cp1251 OS name: windows 8, version: 6.2, arch: x86, family: windows and all tests are also passed. Did you use anything that isn't from family: windows or unix? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44755377 I used Maven, master branch at revision 73d35ba9597cd867717310ae8813376888debb9b. I applied your patch to master, and ran the tests with Maven 3.2.1 on OSX. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44755927 Awesome,this is the only platform, I couldn't test against.Could you specify your _mvn -version_ output? I will try to fix test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44756291 Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9; 2014-02-14T12:37:52-05:00) Maven home: /Users/jvanzyl/m2 Java version: 1.7.0_21, vendor: Oracle Corporation Java home: /Library/Java/JavaVirtualMachines/jdk1.7.0_21.jdk/Contents/Home/jre Default locale: en_US, platform encoding: UTF-8 OS name: mac os x, version: 10.9.2, arch: x86_64, family: mac But the same test fails against master as well. You might not want to use platform activators in the tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44756590 Not understand your point about failing against master. I agree that platform activators is not good idea. So same with JDK activator, right? I'm only left with existing/missing file (what I've already use) and property activator (which is tricky for testing) So, how we could resolve it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44756676 I will take a look as soon as I can. Maybe making an activator specifically for helping us test this will be better. Thanks for being patient, we'll get this sorted and integrated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44756700 Maybe creating an activator specifically for testing this might be better. I will take a look as soon as I can. Likely tomorrow. Thanks for your patience, we'll get this integrated shortly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44757042 I'm 100% don't wanna rush. I will think about special activator for testing purpose (It could be _AlwaysTrueActivator_). I will try to give it a try tomorrow. Also, the way which is used now in 4 activators isn't best (I'm talking about condition for checking) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
