Re: [ANN] First call to round up issues for 3.5.1

2017-06-04 Thread Michael Osipov 

Am 2017-06-04 um 20:55 schrieb Karl Heinz Marbaise:

Hi,

I would like to suggest to introduce:

MNG-6206
MNG-6207

to be part of Maven 3.5.1...

Currently for MNG-6206 we have a pull request which solves the issue
also the IT's are Ok for this.

I will check also for MNG-6207..

If there are no objections I will integrate them after the have been
ready into master starting on tuesday ?


+1 Both issues and PRs look fine to me.


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #121: [MNG-6206] display deprecation build warning in case when ...

2017-06-04 Thread dejan2609 
Github user dejan2609 commented on the issue:

https://github.com/apache/maven/pull/121
  
@khmarbaise
Integration tests passed as expected, that's nice.

Commit message is altered just a little bit and force-pushed here.





---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #119: [MNG-6207] display build WARNING if deprecated 'system' sc...

2017-06-04 Thread dejan2609 
Github user dejan2609 commented on the issue:

https://github.com/apache/maven/pull/119
  
@khmarbaise done, I altered commit messaged (added note about tests). 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [ANN] First call to round up issues for 3.5.1

2017-06-04 Thread Karl Heinz Marbaise 

Hi,

I would like to suggest to introduce:

MNG-6206
MNG-6207

to be part of Maven 3.5.1...

Currently for MNG-6206 we have a pull request which solves the issue 
also the IT's are Ok for this.


I will check also for MNG-6207..

If there are no objections I will integrate them after the have been 
ready into master starting on tuesday ?


Kind regards
Karl Heinz Marbaise

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #119: [MNG-6207] display build WARNING if deprecated 'system' sc...

2017-06-04 Thread khmarbaise 
Github user khmarbaise commented on the issue:

https://github.com/apache/maven/pull/119
  
Could you make a real commit log message like:
```
[MNG-6207] Create WARNINGs in case of using system scope
 If needed more description/explanations here.
```
Otherwise I need to do a `git ci --amend ...` which I would like to prevent 
and keep the original commit...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #121: [MNG-6206] display deprecation build warning in case when ...

2017-06-04 Thread khmarbaise 
Github user khmarbaise commented on the issue:

https://github.com/apache/maven/pull/121
  
Please make a complete commit message with reference to the appropriate 
ticket.
```
[MNG-6206] display deprecation build warning in case when dependencies use 
metaversions (LATEST or RELEASE)
 Maybe some explantations/descriptions if needed
```
I have applied your patch on a branch MNG-6206 to check via the integration 
tests. I have modified the commit message see here:

https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commitdiff;h=eb6b212b567c287734a2dbbef3c113fe650f1def

Waiting on the results of the integration tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #146: SUREFIRE-1330: Fix module name in surefire-provid...

2017-06-04 Thread Tibor17 
Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/146
  
@mgreau 
@britter 
Hey guys, let's utilize your power and complete `AbstractSurefireMojo` with 
`ProviderInfo`, some tests are still in progress.
Meanwhile Apache Maven will complete 2.20.1. The reason is the stability of 
this plugin. It is more important to release 2.20.1. Maybe 2.20.1 would split 
again as it was with 2.20 and the release will get faster with faster user 
response.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #141: SUREFIRE-1331: Bump version number for 3.0.0 rele...

2017-06-04 Thread Tibor17 
Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/141
  
@britter 
We have to finish 2.20.1 but we can finish the junit5 provider. Where did 
we finish last time?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #146: SUREFIRE-1330: Fix module name in surefire-provid...

2017-06-04 Thread britter 
Github user britter commented on the issue:

https://github.com/apache/maven-surefire/pull/146
  
@Tibor17 the provider is already part of the 3.0-rc1 branch. Please see 
#142. This just fixes an incorrect module name.

> It's not legal to introduce incomplete feature.

Since we have not added the `ProviderInfo` for JUnit 5 in 
`AbstractSurefireMojo`, the provider is effectively not usable. So we can think 
of this as a feature toggle. The code does not hurt anybody, but it is much 
easier to work on it, when it is already part of the 3.0 line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #141: SUREFIRE-1331: Bump version number for 3.0.0 rele...

2017-06-04 Thread michael-o 
Github user michael-o commented on the issue:

https://github.com/apache/maven-surefire/pull/141
  
2.20.1 will go first.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #141: SUREFIRE-1331: Bump version number for 3.0.0 rele...

2017-06-04 Thread britter 
Github user britter commented on the issue:

https://github.com/apache/maven-surefire/pull/141
  
@Tibor17 what about this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Looking for a collaborator to work on an experimental fork of the maven-dependency-plugin

2017-06-04 Thread Paul Hammant 
So I have 27 releases of XStream unzipped and pushed to
https://github.com/paul-hammant/mc-xs-classes

(8.4M of Jars is now 2.4M of bare .git repo)

All the jars are still available - here -
https://github.com/paul-hammant/mc-xs-classes/releases

Perfect except:


   1. .zip suffix instead of .jar
   2. there's a pesky root folder inside the zip, that matches the tag name
   (GitHub's policy I guess for downloads).
   3. the signatures won't match those for the originals up on 'Central.

I want to fork (experimentally) maven-dependency-plugin (it's in Subversion
now, but the fork should be on GitHub of course), and sprinkle in some
https://github.com/zeroturnaround/zt-zip in order to (1) rename the zip on
download from GitHub, and (2) remove the root folder inside the zip without
a mechanical unzip/rezip ... then put theresult in ~/.m2/repository/ as
normal.

There's probably some pom.xml creativity needed too.

Any takers?

- Paul

Re: Code review. Please approve new branches.

2017-06-04 Thread Michael Osipov 

Am 2017-06-03 um 13:53 schrieb Tibor Digana:

Hi Michael,

I have pushed branch SUREFIRE-1380_2, see [1], and separated the previous
ticket SUREFIRE-1380 to two: SUREFIRE-1380 and SUREFIRE-1381.

The branch SUREFIRE-1380_2 is for Jira SUREFIRE-1380.
[1]:
https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=shortlog;h=refs/heads/SUREFIRE-1380_2


Looks both fine now to me.


On Sat, Jun 3, 2017 at 12:54 PM, Michael Osipov  wrote:


Am 2017-06-03 um 12:36 schrieb Tibor Digana:


Michael, I will split SUREFIRE-1380 in two tickets on tomorrow evening.
Another flush is necessary because the method InputStream.read() is called
in a loop and the flush should be called after last byte. If another
thread
marks the stream to be closed asynchronously, then the bytes can be lost.
Therefore flushing if stream has been closed in the intermediate time
between these two threads. Maybe not clear to understand, we can have a
look deeper.



Please add this profound description to the ticket itself. It will help to
understand the motivation.


On Sat, Jun 3, 2017 at 12:31 PM, Tibor Digana 
wrote:

Am 2017-06-03 um 10:56 schrieb Tibor Digana:


I have added a new branch with small change only, SUREFIRE-1380.

https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git
;a=shortlog;h=refs/heads/SUREFIRE-1380



I am not happy with this: you mix two different taks in one issue,
refactoring and flush. There is no explanation why another flush is
necessary or what the benefit will be, i.e., don't fix things which
aren't
broken.

WDYT?


Michael


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org





--
Cheers
Tibor








-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org








-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org