Re: Legacy repository layout is not supported by Maven 4?
Ah, I understand. After you switched to the non deprecated method, you observed a change. I thought you observed a change without any modification to your code. So yeah, as Tamás explained, this is expected. Le ven. 23 juin 2023 à 17:47, Alexey Venderov a écrit : > Guillaume, > > The change in the behavior is introduced here: > > https://github.com/apache/maven/commit/967d8fc19cbb8a78410ceed70bd91c2e628da813#diff-64f7dba44bfc4bf654efbd092058718253adde1449ce9fc63ac5531fba20a071R97 > . *RepositorySystem.buildArtifactRepository* behaves differently compared > to *MavenRepositorySystem.buildArtifactRepository*. The former reads the > *layout* from the repository passed as an argument, the latter does not. > > Yes, we've seen a change in the behavior. We have a test that defines the > repository with the invalid layout value and expects the failure with the > appropriate message about the invalid layout. This test was working (with > maven 3.8.x, 3.9.x, and 4.x) up until the mentioned change. It is now > failing differently because the invalid value is ignored and "default" is > used instead. > > Best regards, > Alexey Venderov > mailto: avende...@gmail.com > > > On Fri, Jun 23, 2023 at 4:12 PM Guillaume Nodet wrote: > > > Le ven. 23 juin 2023 à 15:21, Alexey Venderov a > > écrit : > > > > > Hi! > > > > > > After this change > > > > > > > > > https://github.com/apache/maven/commit/967d8fc19cbb8a78410ceed70bd91c2e628da813#diff-64f7dba44bfc4bf654efbd092058718253adde1449ce9fc63ac5531fba20a071R97 > > > it looks like that *layout *repository property is not supported > anymore. > > > > *buildArtifactRepostitory* method in *MavenRepositorySystem* ignores the > > > value coming from the configuration and always uses the default layout: > > > > > > > > > https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java#L346 > > > . > > > > > > > I may be missing something, but the line you point at has been changed 9 > > years ago. > > Have you actually seen any change in the behavior of the upcoming alpha-6 > > vs previous alphas in this regard ? > > > > > > > > > > Is it an intended change? Thank you! > > > > > > Best regards, > > > Alexey Venderov > > > mailto: avende...@gmail.com > > > > > > > > > -- > > > > Guillaume Nodet > > > -- Guillaume Nodet
Re: Legacy repository layout is not supported by Maven 4?
Guillaume, The change in the behavior is introduced here: https://github.com/apache/maven/commit/967d8fc19cbb8a78410ceed70bd91c2e628da813#diff-64f7dba44bfc4bf654efbd092058718253adde1449ce9fc63ac5531fba20a071R97 . *RepositorySystem.buildArtifactRepository* behaves differently compared to *MavenRepositorySystem.buildArtifactRepository*. The former reads the *layout* from the repository passed as an argument, the latter does not. Yes, we've seen a change in the behavior. We have a test that defines the repository with the invalid layout value and expects the failure with the appropriate message about the invalid layout. This test was working (with maven 3.8.x, 3.9.x, and 4.x) up until the mentioned change. It is now failing differently because the invalid value is ignored and "default" is used instead. Best regards, Alexey Venderov mailto: avende...@gmail.com On Fri, Jun 23, 2023 at 4:12 PM Guillaume Nodet wrote: > Le ven. 23 juin 2023 à 15:21, Alexey Venderov a > écrit : > > > Hi! > > > > After this change > > > > > https://github.com/apache/maven/commit/967d8fc19cbb8a78410ceed70bd91c2e628da813#diff-64f7dba44bfc4bf654efbd092058718253adde1449ce9fc63ac5531fba20a071R97 > > it looks like that *layout *repository property is not supported anymore. > > *buildArtifactRepostitory* method in *MavenRepositorySystem* ignores the > > value coming from the configuration and always uses the default layout: > > > > > https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java#L346 > > . > > > > I may be missing something, but the line you point at has been changed 9 > years ago. > Have you actually seen any change in the behavior of the upcoming alpha-6 > vs previous alphas in this regard ? > > > > > > Is it an intended change? Thank you! > > > > Best regards, > > Alexey Venderov > > mailto: avende...@gmail.com > > > > > -- > > Guillaume Nodet >
Re: Legacy repository layout is not supported by Maven 4?
Le ven. 23 juin 2023 à 15:21, Alexey Venderov a écrit : > Hi! > > After this change > > https://github.com/apache/maven/commit/967d8fc19cbb8a78410ceed70bd91c2e628da813#diff-64f7dba44bfc4bf654efbd092058718253adde1449ce9fc63ac5531fba20a071R97 > it looks like that *layout *repository property is not supported anymore. *buildArtifactRepostitory* method in *MavenRepositorySystem* ignores the > value coming from the configuration and always uses the default layout: > > https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java#L346 > . > I may be missing something, but the line you point at has been changed 9 years ago. Have you actually seen any change in the behavior of the upcoming alpha-6 vs previous alphas in this regard ? > > Is it an intended change? Thank you! > > Best regards, > Alexey Venderov > mailto: avende...@gmail.com > -- Guillaume Nodet
Re: Legacy repository layout is not supported by Maven 4?
Great! Thank you, Tamás! Would it make sense to log some kind of a warning to tell the user that the value that they have configured in the config will be ignored? Best regards, Alexey Venderov mailto: avende...@gmail.com On Fri, Jun 23, 2023 at 3:29 PM Tamás Cservenák wrote: > Howdy, > > Yes, that;s right. > Maven3 had Maven2 support, Maven4 will have Maven3 support only, we don't > plan to support several generations backward. > Everything moves off from "legacy" :) > > Thanks > T > > On Fri, Jun 23, 2023 at 3:21 PM Alexey Venderov > wrote: > > > Hi! > > > > After this change > > > > > https://github.com/apache/maven/commit/967d8fc19cbb8a78410ceed70bd91c2e628da813#diff-64f7dba44bfc4bf654efbd092058718253adde1449ce9fc63ac5531fba20a071R97 > > it looks like that *layout *repository property is not supported anymore. > > *buildArtifactRepostitory* method in *MavenRepositorySystem* ignores the > > value coming from the configuration and always uses the default layout: > > > > > https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java#L346 > > . > > > > Is it an intended change? Thank you! > > > > Best regards, > > Alexey Venderov > > mailto: avende...@gmail.com > > >
Re: Legacy repository layout is not supported by Maven 4?
Howdy, Yes, that;s right. Maven3 had Maven2 support, Maven4 will have Maven3 support only, we don't plan to support several generations backward. Everything moves off from "legacy" :) Thanks T On Fri, Jun 23, 2023 at 3:21 PM Alexey Venderov wrote: > Hi! > > After this change > > https://github.com/apache/maven/commit/967d8fc19cbb8a78410ceed70bd91c2e628da813#diff-64f7dba44bfc4bf654efbd092058718253adde1449ce9fc63ac5531fba20a071R97 > it looks like that *layout *repository property is not supported anymore. > *buildArtifactRepostitory* method in *MavenRepositorySystem* ignores the > value coming from the configuration and always uses the default layout: > > https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java#L346 > . > > Is it an intended change? Thank you! > > Best regards, > Alexey Venderov > mailto: avende...@gmail.com >
