Re: prepare to release eclipse 2.4

2007-06-28 Thread Max Bowsher
Brian E. Fox wrote:
 Sorry, I didn't mean to start the conversation, then bail. I was hoping
 I could stage and call a vote before I went travelling and working off a
 slow cell connection. 
 
 I'm still having failures on XP. Is this just a windows problem, or is
 stuff really broken, or is it just me?

I'm seeing MECLIPSE-248 still, on Linux.

I've also found some sort of regression, I believe related to
dependencies with classifiers. I will research more and jira something
about it today.

Max.



signature.asc
Description: OpenPGP digital signature


Re: prepare to release eclipse 2.4

2007-06-28 Thread Arnaud HERITIER

I laways have a lot of unable to delete dir on windows.
seems to be related to http://jira.codehaus.org/browse/PLXUTILS-35
the fix in plexus could not be enough
I'm trying to upgrade my jdk
Can't we delete those directories at the jvm shutdown ?
Is there a risk of reuse of these directories between tests ?
Can't we just try/catch this delete ?

Arnaud

On 28/06/07, Max Bowsher [EMAIL PROTECTED] wrote:

Brian E. Fox wrote:
 Sorry, I didn't mean to start the conversation, then bail. I was hoping
 I could stage and call a vote before I went travelling and working off a
 slow cell connection.

 I'm still having failures on XP. Is this just a windows problem, or is
 stuff really broken, or is it just me?

I'm seeing MECLIPSE-248 still, on Linux.

I've also found some sort of regression, I believe related to
dependencies with classifiers. I will research more and jira something
about it today.

Max.






--
..
Arnaud HERITIER
..
OCTO Technology - [EMAIL PROTECTED]
www.octo.com | blog.octo.com
..
ASF - [EMAIL PROTECTED]
www.apache.org | maven.apache.org
...

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: prepare to release eclipse 2.4

2007-06-28 Thread Max Bowsher
Max Bowsher wrote:
 I've also found some sort of regression, I believe related to
 dependencies with classifiers.

Filed MECLIPSE-287.

Max.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: prepare to release eclipse 2.4

2007-06-28 Thread Arnaud HERITIER

Are there some of you who can test/review the most popular issues :
http://jira.codehaus.org/browse/MECLIPSE-78
Some of them have a patch
It could be important to see if we can apply them before the next release.

Arnaud

On 28/06/07, Max Bowsher [EMAIL PROTECTED] wrote:

Max Bowsher wrote:
 I've also found some sort of regression, I believe related to
 dependencies with classifiers.

Filed MECLIPSE-287.

Max.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





--
..
Arnaud HERITIER
..
OCTO Technology - [EMAIL PROTECTED]
www.octo.com | blog.octo.com
..
ASF - [EMAIL PROTECTED]
www.apache.org | maven.apache.org
...

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: prepare to release eclipse 2.4

2007-06-28 Thread Arnaud HERITIER

The link I wanted to paste is :
http://jira.codehaus.org/browse/MECLIPSE?report=com.atlassian.jira.plugin.system.project:popularissues-panel

Arnaud

On 28/06/07, Arnaud HERITIER [EMAIL PROTECTED] wrote:

Are there some of you who can test/review the most popular issues :
http://jira.codehaus.org/browse/MECLIPSE-78
Some of them have a patch
It could be important to see if we can apply them before the next release.

Arnaud

On 28/06/07, Max Bowsher [EMAIL PROTECTED] wrote:
 Max Bowsher wrote:
  I've also found some sort of regression, I believe related to
  dependencies with classifiers.

 Filed MECLIPSE-287.

 Max.

 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]




--
..
Arnaud HERITIER
..
OCTO Technology - [EMAIL PROTECTED]
www.octo.com | blog.octo.com
..
ASF - [EMAIL PROTECTED]
www.apache.org | maven.apache.org
...




--
..
Arnaud HERITIER
..
OCTO Technology - [EMAIL PROTECTED]
www.octo.com | blog.octo.com
..
ASF - [EMAIL PROTECTED]
www.apache.org | maven.apache.org
...

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: prepare to release eclipse 2.4

2007-06-28 Thread Brian E. Fox
I figured out why some tests where failing for me. I have
downloadSourcestrue/downloadSources set in my settings and this was
causing the correct behavior in the plugin, but it didn't match the
expected classpath. I'll write a jira for this to be resolved later
since it's not critical.

-Original Message-
From: Arnaud HERITIER [mailto:[EMAIL PROTECTED] 
Sent: Thursday, June 28, 2007 4:18 PM
To: Maven Developers List
Subject: Re: prepare to release eclipse 2.4

The link I wanted to paste is :
http://jira.codehaus.org/browse/MECLIPSE?report=com.atlassian.jira.plugi
n.system.project:popularissues-panel

Arnaud

On 28/06/07, Arnaud HERITIER [EMAIL PROTECTED] wrote:
 Are there some of you who can test/review the most popular issues :
 http://jira.codehaus.org/browse/MECLIPSE-78
 Some of them have a patch
 It could be important to see if we can apply them before the next
release.

 Arnaud

 On 28/06/07, Max Bowsher [EMAIL PROTECTED] wrote:
  Max Bowsher wrote:
   I've also found some sort of regression, I believe related to
   dependencies with classifiers.
 
  Filed MECLIPSE-287.
 
  Max.
 
 
-
  To unsubscribe, e-mail: [EMAIL PROTECTED]
  For additional commands, e-mail: [EMAIL PROTECTED]
 
 


 --
 ..
 Arnaud HERITIER
 ..
 OCTO Technology - [EMAIL PROTECTED]
 www.octo.com | blog.octo.com
 ..
 ASF - [EMAIL PROTECTED]
 www.apache.org | maven.apache.org
 ...



-- 
..
Arnaud HERITIER
..
OCTO Technology - [EMAIL PROTECTED]
www.octo.com | blog.octo.com
..
ASF - [EMAIL PROTECTED]
www.apache.org | maven.apache.org
...

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: prepare to release eclipse 2.4

2007-06-27 Thread Brian E. Fox
Sorry, I didn't mean to start the conversation, then bail. I was hoping
I could stage and call a vote before I went travelling and working off a
slow cell connection. 

I'm still having failures on XP. Is this just a windows problem, or is
stuff really broken, or is it just me?

-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Carlos
Sanchez
Sent: Friday, June 22, 2007 2:02 PM
To: Maven Developers List
Subject: Re: prepare to release eclipse 2.4

fixed (again) hopefully

On 6/22/07, Max Bowsher [EMAIL PROTECTED] wrote:
 Max Bowsher wrote:
  Oh. I was caught out by the interpolation syntax change ${foo} to
[foo].
  Adapting to that, it now seems to be working - thanks!

 Seems I spoke too soon :-(

 -Declipse.addVersionToProjectName doesn't work. The problem is that
 calculateProjectNameTemplate() attempts to use:
  if ( getProjectNameTemplate() != null )
 to determine if a projectNameTemplate was set, but the @parameter
 declares a default-value, so this is never true.  The simplest fix
would
 be to just drop the default-value from the @parameter declaration.



 A minor feature request whilst it occurs to me - after writing the
 project, the plugin emits (for example):

 [INFO] Wrote Eclipse project for maven-script-beanshell to
 /home/maxb/wc/maven/2.0.x/maven-script/maven-script-beanshell.

 The quoted word is currently just the project's artifactId, but with
 these added project name rewriting facilities, it would be useful to
 have confirmation in the output that a different eclipse project name
 was used - so I suggest putting the generated eclipse project name in
 that log line instead.



 Let me know if you'd like either/both of these issues taken to JIRA.

 Here is a two-line patch encompassing both of the above:

 Index:
src/main/java/org/apache/maven/plugin/eclipse/EclipsePlugin.java
 ===
 --- src/main/java/org/apache/maven/plugin/eclipse/EclipsePlugin.java
 (revision 549790)
 +++ src/main/java/org/apache/maven/plugin/eclipse/EclipsePlugin.java
 (working copy)
 @@ -332,7 +332,7 @@
   *
   * eg. code[groupId].[artifactId]-[version]/code
   *
 - * @parameter expression=${eclipse.projectNameTemplate}
 default-value=[artifactId]
 + * @parameter expression=${eclipse.projectNameTemplate}
   */
  private String projectNameTemplate;

 @@ -836,7 +836,7 @@
  }

  getLog().info( Messages.getString( EclipsePlugin.wrote, new
 Object[] { //$NON-NLS-1$
 -   project.getArtifactId(),
 eclipseProjectDir.getAbsolutePath() } ) );
 +
 config.getEclipseProjectName(), eclipseProjectDir.getAbsolutePath() }
) );
  }

  protected EclipseWriterConfig createEclipseWriterConfig(
 IdeDependency[] deps )


 Max.





-- 
I could give you my word as a Spaniard.
No good. I've known too many Spaniards.
 -- The Princess Bride

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: prepare to release eclipse 2.4

2007-06-22 Thread Arnaud HERITIER

I also had this problem several times. When I stop to develop on the plugin
and I want to use it, maven try to use the test version instead of the 2.3.
It seems that the metadata in my local repo is modified, what shouldn't
happen because the test plugin is installed in a test repo

Arnaud

On 22/06/07, Carlos Sanchez [EMAIL PROTECTED] wrote:


the biggest problem right now is MECLIPSE-248, doesn't seem right to
push the release without at least knowing why is that happening

On 6/21/07, Carlos Sanchez [EMAIL PROTECTED] wrote:
 On 6/21/07, Max Bowsher [EMAIL PROTECTED] wrote:
  Carlos Sanchez wrote:
   yes, it should work, if I configure it in the pom it does, can you
try
   that?
 
  The interpolation does work then, yes. So that bug affects the command
  line only.
 
  Tthe problem of the projectNameTemplate not being applied to project
  dependencies is unaffected by configuration method.

 ah, you mean the linked projects, I think I forgot that detail

 
  Max.
 
 
 
   On 6/21/07, Max Bowsher [EMAIL PROTECTED] wrote:
   Arnaud HERITIER wrote:
are you sure that ${artifactId} is supported ? It's not
   ${pom.artifactId} ?
  
  
   The javadoc in the plugin says:
  
  [snip]
  
   I admit I haven't studied the code to be sure, but given that
   default-value...?
  
   Max.
 
 
 


 --
 I could give you my word as a Spaniard.
 No good. I've known too many Spaniards.
  -- The Princess Bride



--
I could give you my word as a Spaniard.
No good. I've known too many Spaniards.
 -- The Princess Bride

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





--
..
Arnaud HERITIER
..
OCTO Technology - [EMAIL PROTECTED]
www.octo.com | blog.octo.com
..
ASF - [EMAIL PROTECTED]
www.apache.org | maven.apache.org
...


Re: prepare to release eclipse 2.4

2007-06-22 Thread Max Bowsher
Carlos Sanchez wrote:
 On 6/21/07, Carlos Sanchez [EMAIL PROTECTED] wrote:
 On 6/21/07, Max Bowsher [EMAIL PROTECTED] wrote:
  Carlos Sanchez wrote:
   yes, it should work, if I configure it in the pom it does, can you
 try
   that?
 
  The interpolation does work then, yes. So that bug affects the command
  line only.
 
  Tthe problem of the projectNameTemplate not being applied to project
  dependencies is unaffected by configuration method.

 ah, you mean the linked projects, I think I forgot that detail
 
 this should be fixed now

Thanks, but now it's broken in a new and exciting way :-)

Now all the project references in .classpath are referring to the
*current* project, not to the *dependency* projects. I guess the
nametemplate is being interpolated with reference to the wrong object.

Max.



signature.asc
Description: OpenPGP digital signature


Re: prepare to release eclipse 2.4

2007-06-22 Thread Max Bowsher
Max Bowsher wrote:
 Carlos Sanchez wrote:
 On 6/21/07, Carlos Sanchez [EMAIL PROTECTED] wrote:
 On 6/21/07, Max Bowsher [EMAIL PROTECTED] wrote:
 Carlos Sanchez wrote:
 yes, it should work, if I configure it in the pom it does, can you
 try
 that?
 The interpolation does work then, yes. So that bug affects the command
 line only.

 Tthe problem of the projectNameTemplate not being applied to project
 dependencies is unaffected by configuration method.
 ah, you mean the linked projects, I think I forgot that detail
 this should be fixed now
 
 Thanks, but now it's broken in a new and exciting way :-)
 
 Now all the project references in .classpath are referring to the
 *current* project, not to the *dependency* projects. I guess the
 nametemplate is being interpolated with reference to the wrong object.


Oh. I was caught out by the interpolation syntax change ${foo} to [foo].
Adapting to that, it now seems to be working - thanks!

Max.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: prepare to release eclipse 2.4

2007-06-22 Thread Max Bowsher
Max Bowsher wrote:
 Oh. I was caught out by the interpolation syntax change ${foo} to [foo].
 Adapting to that, it now seems to be working - thanks!

Seems I spoke too soon :-(

-Declipse.addVersionToProjectName doesn't work. The problem is that
calculateProjectNameTemplate() attempts to use:
 if ( getProjectNameTemplate() != null )
to determine if a projectNameTemplate was set, but the @parameter
declares a default-value, so this is never true.  The simplest fix would
be to just drop the default-value from the @parameter declaration.



A minor feature request whilst it occurs to me - after writing the
project, the plugin emits (for example):

[INFO] Wrote Eclipse project for maven-script-beanshell to
/home/maxb/wc/maven/2.0.x/maven-script/maven-script-beanshell.

The quoted word is currently just the project's artifactId, but with
these added project name rewriting facilities, it would be useful to
have confirmation in the output that a different eclipse project name
was used - so I suggest putting the generated eclipse project name in
that log line instead.



Let me know if you'd like either/both of these issues taken to JIRA.

Here is a two-line patch encompassing both of the above:

Index: src/main/java/org/apache/maven/plugin/eclipse/EclipsePlugin.java
===
--- src/main/java/org/apache/maven/plugin/eclipse/EclipsePlugin.java
(revision 549790)
+++ src/main/java/org/apache/maven/plugin/eclipse/EclipsePlugin.java
(working copy)
@@ -332,7 +332,7 @@
  *
  * eg. code[groupId].[artifactId]-[version]/code
  *
- * @parameter expression=${eclipse.projectNameTemplate}
default-value=[artifactId]
+ * @parameter expression=${eclipse.projectNameTemplate}
  */
 private String projectNameTemplate;

@@ -836,7 +836,7 @@
 }

 getLog().info( Messages.getString( EclipsePlugin.wrote, new
Object[] { //$NON-NLS-1$
-   project.getArtifactId(),
eclipseProjectDir.getAbsolutePath() } ) );
+
config.getEclipseProjectName(), eclipseProjectDir.getAbsolutePath() } ) );
 }

 protected EclipseWriterConfig createEclipseWriterConfig(
IdeDependency[] deps )


Max.



signature.asc
Description: OpenPGP digital signature


Re: prepare to release eclipse 2.4

2007-06-22 Thread Carlos Sanchez

fixed (again) hopefully

On 6/22/07, Max Bowsher [EMAIL PROTECTED] wrote:

Max Bowsher wrote:
 Oh. I was caught out by the interpolation syntax change ${foo} to [foo].
 Adapting to that, it now seems to be working - thanks!

Seems I spoke too soon :-(

-Declipse.addVersionToProjectName doesn't work. The problem is that
calculateProjectNameTemplate() attempts to use:
 if ( getProjectNameTemplate() != null )
to determine if a projectNameTemplate was set, but the @parameter
declares a default-value, so this is never true.  The simplest fix would
be to just drop the default-value from the @parameter declaration.



A minor feature request whilst it occurs to me - after writing the
project, the plugin emits (for example):

[INFO] Wrote Eclipse project for maven-script-beanshell to
/home/maxb/wc/maven/2.0.x/maven-script/maven-script-beanshell.

The quoted word is currently just the project's artifactId, but with
these added project name rewriting facilities, it would be useful to
have confirmation in the output that a different eclipse project name
was used - so I suggest putting the generated eclipse project name in
that log line instead.



Let me know if you'd like either/both of these issues taken to JIRA.

Here is a two-line patch encompassing both of the above:

Index: src/main/java/org/apache/maven/plugin/eclipse/EclipsePlugin.java
===
--- src/main/java/org/apache/maven/plugin/eclipse/EclipsePlugin.java
(revision 549790)
+++ src/main/java/org/apache/maven/plugin/eclipse/EclipsePlugin.java
(working copy)
@@ -332,7 +332,7 @@
  *
  * eg. code[groupId].[artifactId]-[version]/code
  *
- * @parameter expression=${eclipse.projectNameTemplate}
default-value=[artifactId]
+ * @parameter expression=${eclipse.projectNameTemplate}
  */
 private String projectNameTemplate;

@@ -836,7 +836,7 @@
 }

 getLog().info( Messages.getString( EclipsePlugin.wrote, new
Object[] { //$NON-NLS-1$
-   project.getArtifactId(),
eclipseProjectDir.getAbsolutePath() } ) );
+
config.getEclipseProjectName(), eclipseProjectDir.getAbsolutePath() } ) );
 }

 protected EclipseWriterConfig createEclipseWriterConfig(
IdeDependency[] deps )


Max.






--
I could give you my word as a Spaniard.
No good. I've known too many Spaniards.
-- The Princess Bride

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: prepare to release eclipse 2.4

2007-06-21 Thread Fabrice Bellingard

+1

Fabrice

On 6/20/07, Brian E. Fox [EMAIL PROTECTED] wrote:


It's been about 5 months since we last released eclipse. There are
plenty of issues already fixed:

http://jira.codehaus.org/secure/ReleaseNote.jspa?version=13001styleName
=HtmlprojectId=11133Create=Create



There are currently 24 remaining open. Any objections to cutting a
release as is and bumping the rest to 2.5?




Re: prepare to release eclipse 2.4

2007-06-21 Thread Arnaud HERITIER

I would like to add that I have often some problems to run tests for this
plugin on windows.
Am I the only one to have this behaviour ?

Arnaud

On 20/06/07, Arnaud HERITIER [EMAIL PROTECTED] wrote:


It is in my todo list but up until now I focused on maven 1.
I have several co-workers who reported to me that they are unable to run
tests in this plugin.
I'll study this problem with them tomorrow.
I have also some patchs to apply concerning rad6 and myeclipse but it can
be included in the next release if necessary.
Go for it if you have the time ...

cheers

arnaud

On 20/06/07, Carlos Sanchez [EMAIL PROTECTED]  wrote:

 go for it

 On 6/20/07, Brian E. Fox  [EMAIL PROTECTED] wrote:
  It's been about 5 months since we last released eclipse. There are
  plenty of issues already fixed:
 
 
 http://jira.codehaus.org/secure/ReleaseNote.jspa?version=13001styleName
  =HtmlprojectId=11133Create=Create
 
 
 
  There are currently 24 remaining open. Any objections to cutting a
  release as is and bumping the rest to 2.5?
 
 


 --
 I could give you my word as a Spaniard.
 No good. I've known too many Spaniards.
  -- The Princess Bride

 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]




--
..
Arnaud HERITIER
..
OCTO Technology - [EMAIL PROTECTED]
www.octo.com | blog.octo.com
..
ASF - [EMAIL PROTECTED]
www.apache.org | maven.apache.org
...





--
..
Arnaud HERITIER
..
OCTO Technology - [EMAIL PROTECTED]
www.octo.com | blog.octo.com
..
ASF - [EMAIL PROTECTED]
www.apache.org | maven.apache.org
...


Re: prepare to release eclipse 2.4

2007-06-21 Thread Arnaud HERITIER

Temporary -1
Just noticed a problem that I'm fixing
Some usages of String.contains() which is not compatible with jdk1.4

Arnaud

On 21/06/07, Arnaud HERITIER [EMAIL PROTECTED] wrote:


I would like to add that I have often some problems to run tests for this
plugin on windows.
Am I the only one to have this behaviour ?

Arnaud

On 20/06/07, Arnaud HERITIER [EMAIL PROTECTED] wrote:

 It is in my todo list but up until now I focused on maven 1.
 I have several co-workers who reported to me that they are unable to run
 tests in this plugin.
 I'll study this problem with them tomorrow.
 I have also some patchs to apply concerning rad6 and myeclipse but it
 can be included in the next release if necessary.
 Go for it if you have the time ...

 cheers

 arnaud

 On 20/06/07, Carlos Sanchez  [EMAIL PROTECTED]  wrote:
 
  go for it
 
  On 6/20/07, Brian E. Fox  [EMAIL PROTECTED] wrote:
   It's been about 5 months since we last released eclipse. There are
   plenty of issues already fixed:
  
  
  http://jira.codehaus.org/secure/ReleaseNote.jspa?version=13001styleName
   =HtmlprojectId=11133Create=Create
  
  
  
   There are currently 24 remaining open. Any objections to cutting a
   release as is and bumping the rest to 2.5?
  
  
 
 
  --
  I could give you my word as a Spaniard.
  No good. I've known too many Spaniards.
   -- The Princess Bride
 
  -
  To unsubscribe, e-mail: [EMAIL PROTECTED]
  For additional commands, e-mail: [EMAIL PROTECTED]
 
 


 --
 ..
 Arnaud HERITIER
 ..
 OCTO Technology - [EMAIL PROTECTED]
 www.octo.com | blog.octo.com
 ..
 ASF - [EMAIL PROTECTED]
 www.apache.org | maven.apache.org
 ...




--
..
Arnaud HERITIER
..
OCTO Technology - [EMAIL PROTECTED]
www.octo.com | blog.octo.com
..
ASF - [EMAIL PROTECTED]
www.apache.org | maven.apache.org
...





--
..
Arnaud HERITIER
..
OCTO Technology - [EMAIL PROTECTED]
www.octo.com | blog.octo.com
..
ASF - [EMAIL PROTECTED]
www.apache.org | maven.apache.org
...


Re: prepare to release eclipse 2.4

2007-06-21 Thread Graham Leggett

Arnaud HERITIER wrote:


I would like to add that I have often some problems to run tests for this
plugin on windows.
Am I the only one to have this behaviour ?


I've had problems with tests that fail if there is no direct internet 
access from the machine running the test.


Regards,
Graham
--


smime.p7s
Description: S/MIME Cryptographic Signature


Re: prepare to release eclipse 2.4

2007-06-21 Thread Arnaud HERITIER

fixed.
Just to inform you that it seems that we can't build it with maven
2.0.5(the test version of the plugin isn't generated in the target
dir).
Must we upgrade the prerequisites ?? (is set to 2.0.1 actually)

On 21/06/07, Arnaud HERITIER [EMAIL PROTECTED] wrote:


Temporary -1
Just noticed a problem that I'm fixing
Some usages of String.contains() which is not compatible with jdk1.4

Arnaud

On 21/06/07, Arnaud HERITIER [EMAIL PROTECTED] wrote:

 I would like to add that I have often some problems to run tests for
 this plugin on windows.
 Am I the only one to have this behaviour ?

 Arnaud

 On 20/06/07, Arnaud HERITIER [EMAIL PROTECTED] wrote:
 
  It is in my todo list but up until now I focused on maven 1.
  I have several co-workers who reported to me that they are unable to
  run tests in this plugin.
  I'll study this problem with them tomorrow.
  I have also some patchs to apply concerning rad6 and myeclipse but it
  can be included in the next release if necessary.
  Go for it if you have the time ...
 
  cheers
 
  arnaud
 
  On 20/06/07, Carlos Sanchez  [EMAIL PROTECTED]  wrote:
  
   go for it
  
   On 6/20/07, Brian E. Fox  [EMAIL PROTECTED] wrote:
It's been about 5 months since we last released eclipse. There are
plenty of issues already fixed:
   
   
   http://jira.codehaus.org/secure/ReleaseNote.jspa?version=13001styleName
=HtmlprojectId=11133Create=Create
   
   
   
There are currently 24 remaining open. Any objections to cutting a
  
release as is and bumping the rest to 2.5?
   
   
  
  
   --
   I could give you my word as a Spaniard.
   No good. I've known too many Spaniards.
-- The Princess Bride
  
  
   -
   To unsubscribe, e-mail: [EMAIL PROTECTED]
   For additional commands, e-mail: [EMAIL PROTECTED]
  
  
 
 
  --
  ..
  Arnaud HERITIER
  ..
  OCTO Technology - [EMAIL PROTECTED]
  www.octo.com | blog.octo.com
  ..
  ASF - [EMAIL PROTECTED]
  www.apache.org | maven.apache.org
  ...




 --
 ..
 Arnaud HERITIER
 ..
 OCTO Technology - [EMAIL PROTECTED]
 www.octo.com | blog.octo.com
 ..
 ASF - [EMAIL PROTECTED]
 www.apache.org | maven.apache.org
 ...




--
..
Arnaud HERITIER
..
OCTO Technology - [EMAIL PROTECTED]
www.octo.com | blog.octo.com
..
ASF - [EMAIL PROTECTED]
www.apache.org | maven.apache.org
...





--
..
Arnaud HERITIER
..
OCTO Technology - [EMAIL PROTECTED]
www.octo.com | blog.octo.com
..
ASF - [EMAIL PROTECTED]
www.apache.org | maven.apache.org
...


Re: prepare to release eclipse 2.4

2007-06-21 Thread Daniel Kulp

Can you include MECLIPSE-219 since there is a patch for it?   The patch 
is kind of old so may not apply cleanly anymore though.   I kept meaning 
to go back and apply/update the patch, just never got around to it.  :-(


Dan



On Wednesday 20 June 2007 16:01, Brian E. Fox wrote:
 It's been about 5 months since we last released eclipse. There are
 plenty of issues already fixed:

 http://jira.codehaus.org/secure/ReleaseNote.jspa?version=13001styleNa
me =HtmlprojectId=11133Create=Create



 There are currently 24 remaining open. Any objections to cutting a
 release as is and bumping the rest to 2.5?

-- 
J. Daniel Kulp
Principal Engineer
IONA
P: 781-902-8727C: 508-380-7194
[EMAIL PROTECTED]
http://www.dankulp.com/blog

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: prepare to release eclipse 2.4

2007-06-21 Thread Max Bowsher
Brian E. Fox wrote:
 It's been about 5 months since we last released eclipse. There are
 plenty of issues already fixed:
 
 http://jira.codehaus.org/secure/ReleaseNote.jspa?version=13001styleName
 =HtmlprojectId=11133Create=Create
 
 There are currently 24 remaining open. Any objections to cutting a
 release as is and bumping the rest to 2.5?


I'd absolutely love a release, but for me, the tests seem to have some
sort of nasty breakage. Are they not broken for everyone?

http://jira.codehaus.org/browse/MECLIPSE-248

The issue title is Clean build of maven-eclipse-plugin-2.3 tag fails,
but it's also a problem with trunk as of now.

Max.



signature.asc
Description: OpenPGP digital signature


Re: prepare to release eclipse 2.4

2007-06-21 Thread Arnaud HERITIER

I don't have this one...
But I have some others.
Particularly the build fails regularly on windows because we cannot delete a
temporary directory.
I'm not sure that it couldn't be improved with a new version of the
maven-plugin-testing-tools. There was a lot of changes since the 1.0-alpha-1

Arnaud

On 21/06/07, Max Bowsher [EMAIL PROTECTED] wrote:


Brian E. Fox wrote:
 It's been about 5 months since we last released eclipse. There are
 plenty of issues already fixed:

 http://jira.codehaus.org/secure/ReleaseNote.jspa?version=13001styleName
 =HtmlprojectId=11133Create=Create

 There are currently 24 remaining open. Any objections to cutting a
 release as is and bumping the rest to 2.5?


I'd absolutely love a release, but for me, the tests seem to have some
sort of nasty breakage. Are they not broken for everyone?

http://jira.codehaus.org/browse/MECLIPSE-248

The issue title is Clean build of maven-eclipse-plugin-2.3 tag fails,
but it's also a problem with trunk as of now.

Max.






--
..
Arnaud HERITIER
..
OCTO Technology - [EMAIL PROTECTED]
www.octo.com | blog.octo.com
..
ASF - [EMAIL PROTECTED]
www.apache.org | maven.apache.org
...


Re: prepare to release eclipse 2.4

2007-06-21 Thread Arnaud HERITIER

you're error is also reported by continuum :-(
Arnaud

On 21/06/07, Max Bowsher [EMAIL PROTECTED] wrote:


Brian E. Fox wrote:
 It's been about 5 months since we last released eclipse. There are
 plenty of issues already fixed:

 http://jira.codehaus.org/secure/ReleaseNote.jspa?version=13001styleName
 =HtmlprojectId=11133Create=Create

 There are currently 24 remaining open. Any objections to cutting a
 release as is and bumping the rest to 2.5?


I'd absolutely love a release, but for me, the tests seem to have some
sort of nasty breakage. Are they not broken for everyone?

http://jira.codehaus.org/browse/MECLIPSE-248

The issue title is Clean build of maven-eclipse-plugin-2.3 tag fails,
but it's also a problem with trunk as of now.

Max.






--
..
Arnaud HERITIER
..
OCTO Technology - [EMAIL PROTECTED]
www.octo.com | blog.octo.com
..
ASF - [EMAIL PROTECTED]
www.apache.org | maven.apache.org
...


Re: prepare to release eclipse 2.4

2007-06-21 Thread Max Bowsher
Max Bowsher wrote:
 Brian E. Fox wrote:
 It's been about 5 months since we last released eclipse. There are
 plenty of issues already fixed:

 http://jira.codehaus.org/secure/ReleaseNote.jspa?version=13001styleName
 =HtmlprojectId=11133Create=Create

 There are currently 24 remaining open. Any objections to cutting a
 release as is and bumping the rest to 2.5?
 
 
 I'd absolutely love a release

...

Hmm, I spoke too soon.

The feature I was looking forward to was -Declipse.projectNameTemplate -
unfortunately, it's broken.

I tried:
 mvn eclipse:eclipse -Declipse.projectNameTemplate='${artifactId}-2.0.x'
on the maven-2.0.x components, and what I got was lots of projects
having name null-2.0.x, and the template wasn't even applied at all to
 the projects names going into the .classpath for intra-reactor
dependencies.

Technically, it's a new feature, so the above isn't a regression per se,
though.

Max.



signature.asc
Description: OpenPGP digital signature


Re: prepare to release eclipse 2.4

2007-06-21 Thread Arnaud HERITIER

are you sure that ${artifactId} is supported ? It's not ${pom.artifactId} ?

Arnaud

On 21/06/07, Max Bowsher [EMAIL PROTECTED] wrote:


Max Bowsher wrote:
 Brian E. Fox wrote:
 It's been about 5 months since we last released eclipse. There are
 plenty of issues already fixed:


http://jira.codehaus.org/secure/ReleaseNote.jspa?version=13001styleName
 =HtmlprojectId=11133Create=Create

 There are currently 24 remaining open. Any objections to cutting a
 release as is and bumping the rest to 2.5?


 I'd absolutely love a release

...

Hmm, I spoke too soon.

The feature I was looking forward to was -Declipse.projectNameTemplate -
unfortunately, it's broken.

I tried:
mvn eclipse:eclipse -Declipse.projectNameTemplate='${artifactId}-2.0.x'
on the maven-2.0.x components, and what I got was lots of projects
having name null-2.0.x, and the template wasn't even applied at all to
the projects names going into the .classpath for intra-reactor
dependencies.

Technically, it's a new feature, so the above isn't a regression per se,
though.

Max.






--
..
Arnaud HERITIER
..
OCTO Technology - [EMAIL PROTECTED]
www.octo.com | blog.octo.com
..
ASF - [EMAIL PROTECTED]
www.apache.org | maven.apache.org
...


RE: prepare to release eclipse 2.4

2007-06-21 Thread Brian E. Fox
This might take me a while because there are several test failures in
the trunk right out of the box. I'll take a look and see what I can find
out.

-Original Message-
From: Jason van Zyl [mailto:[EMAIL PROTECTED] 
Sent: Wednesday, June 20, 2007 4:08 PM
To: Maven Developers List
Subject: Re: prepare to release eclipse 2.4

+1

On 20 Jun 07, at 1:01 PM 20 Jun 07, Brian E. Fox wrote:

 It's been about 5 months since we last released eclipse. There are
 plenty of issues already fixed:

 http://jira.codehaus.org/secure/ReleaseNote.jspa? 
 version=13001styleName
 =HtmlprojectId=11133Create=Create



 There are currently 24 remaining open. Any objections to cutting a
 release as is and bumping the rest to 2.5?


Thanks,

Jason

--
Jason van Zyl
Founder and PMC Chair, Apache Maven
jason at sonatype dot com
--




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: prepare to release eclipse 2.4

2007-06-21 Thread Max Bowsher
Arnaud HERITIER wrote:
 are you sure that ${artifactId} is supported ? It's not ${pom.artifactId} ?


The javadoc in the plugin says:

 /**
  * Allows configuring the name of the eclipse projects. This
property wins over
  * addVersionToProjectName and addGroupIdToProjectName
  *
  * You can use code${groupId}/code, code${artifactId}/code and
  * code${version}/code variables.
  *
  * eg. code${groupId}.${artifactId}-${version}/code
  *
  * @parameter expression=${eclipse.projectNameTemplate}
default-value=${artifactId}
  */
 private String projectNameTemplate;

I admit I haven't studied the code to be sure, but given that
default-value...?

Max.



signature.asc
Description: OpenPGP digital signature


Re: prepare to release eclipse 2.4

2007-06-21 Thread Carlos Sanchez

yes, it should work, if I configure it in the pom it does, can you try that?

On 6/21/07, Max Bowsher [EMAIL PROTECTED] wrote:

Arnaud HERITIER wrote:
 are you sure that ${artifactId} is supported ? It's not ${pom.artifactId} ?


The javadoc in the plugin says:

 /**
  * Allows configuring the name of the eclipse projects. This
property wins over
  * addVersionToProjectName and addGroupIdToProjectName
  *
  * You can use code${groupId}/code, code${artifactId}/code and
  * code${version}/code variables.
  *
  * eg. code${groupId}.${artifactId}-${version}/code
  *
  * @parameter expression=${eclipse.projectNameTemplate}
default-value=${artifactId}
  */
 private String projectNameTemplate;

I admit I haven't studied the code to be sure, but given that
default-value...?

Max.






--
I could give you my word as a Spaniard.
No good. I've known too many Spaniards.
-- The Princess Bride

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: prepare to release eclipse 2.4

2007-06-21 Thread Arnaud HERITIER

actually the trunk works for me.
When I have a test broken it's a windows problem like this :

testExtractResourceDirs_ShouldIncludeMainAndTestResourcesWhenBaseDirsDiffer(
org.apache.maven.plugin.eclipse.EclipsePluginUnitTest)  Time elapsed:
0.047sec   ERROR!
java.io.IOException: Directory
c:\Temp\EclipsePlugin.unitTest.1182441351468\src unable to be deleted.

Arnaud

On 21/06/07, Brian E. Fox [EMAIL PROTECTED] wrote:


This might take me a while because there are several test failures in
the trunk right out of the box. I'll take a look and see what I can find
out.

-Original Message-
From: Jason van Zyl [mailto:[EMAIL PROTECTED]
Sent: Wednesday, June 20, 2007 4:08 PM
To: Maven Developers List
Subject: Re: prepare to release eclipse 2.4

+1

On 20 Jun 07, at 1:01 PM 20 Jun 07, Brian E. Fox wrote:

 It's been about 5 months since we last released eclipse. There are
 plenty of issues already fixed:

 http://jira.codehaus.org/secure/ReleaseNote.jspa?
 version=13001styleName
 =HtmlprojectId=11133Create=Create



 There are currently 24 remaining open. Any objections to cutting a
 release as is and bumping the rest to 2.5?


Thanks,

Jason

--
Jason van Zyl
Founder and PMC Chair, Apache Maven
jason at sonatype dot com
--




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





--
..
Arnaud HERITIER
..
OCTO Technology - [EMAIL PROTECTED]
www.octo.com | blog.octo.com
..
ASF - [EMAIL PROTECTED]
www.apache.org | maven.apache.org
...


Re: prepare to release eclipse 2.4

2007-06-21 Thread Max Bowsher
Carlos Sanchez wrote:
 yes, it should work, if I configure it in the pom it does, can you try
 that?

The interpolation does work then, yes. So that bug affects the command
line only.

Tthe problem of the projectNameTemplate not being applied to project
dependencies is unaffected by configuration method.

Max.



 On 6/21/07, Max Bowsher [EMAIL PROTECTED] wrote:
 Arnaud HERITIER wrote:
  are you sure that ${artifactId} is supported ? It's not
 ${pom.artifactId} ?


 The javadoc in the plugin says:

[snip]

 I admit I haven't studied the code to be sure, but given that
 default-value...?

 Max.



signature.asc
Description: OpenPGP digital signature


Re: prepare to release eclipse 2.4

2007-06-21 Thread Carlos Sanchez

On 6/21/07, Max Bowsher [EMAIL PROTECTED] wrote:

Carlos Sanchez wrote:
 yes, it should work, if I configure it in the pom it does, can you try
 that?

The interpolation does work then, yes. So that bug affects the command
line only.

Tthe problem of the projectNameTemplate not being applied to project
dependencies is unaffected by configuration method.


ah, you mean the linked projects, I think I forgot that detail



Max.



 On 6/21/07, Max Bowsher [EMAIL PROTECTED] wrote:
 Arnaud HERITIER wrote:
  are you sure that ${artifactId} is supported ? It's not
 ${pom.artifactId} ?


 The javadoc in the plugin says:

[snip]

 I admit I haven't studied the code to be sure, but given that
 default-value...?

 Max.






--
I could give you my word as a Spaniard.
No good. I've known too many Spaniards.
-- The Princess Bride

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: prepare to release eclipse 2.4

2007-06-21 Thread Carlos Sanchez

the biggest problem right now is MECLIPSE-248, doesn't seem right to
push the release without at least knowing why is that happening

On 6/21/07, Carlos Sanchez [EMAIL PROTECTED] wrote:

On 6/21/07, Max Bowsher [EMAIL PROTECTED] wrote:
 Carlos Sanchez wrote:
  yes, it should work, if I configure it in the pom it does, can you try
  that?

 The interpolation does work then, yes. So that bug affects the command
 line only.

 Tthe problem of the projectNameTemplate not being applied to project
 dependencies is unaffected by configuration method.

ah, you mean the linked projects, I think I forgot that detail


 Max.



  On 6/21/07, Max Bowsher [EMAIL PROTECTED] wrote:
  Arnaud HERITIER wrote:
   are you sure that ${artifactId} is supported ? It's not
  ${pom.artifactId} ?
 
 
  The javadoc in the plugin says:
 
 [snip]
 
  I admit I haven't studied the code to be sure, but given that
  default-value...?
 
  Max.





--
I could give you my word as a Spaniard.
No good. I've known too many Spaniards.
 -- The Princess Bride




--
I could give you my word as a Spaniard.
No good. I've known too many Spaniards.
-- The Princess Bride

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: prepare to release eclipse 2.4

2007-06-21 Thread Carlos Sanchez

On 6/21/07, Carlos Sanchez [EMAIL PROTECTED] wrote:

On 6/21/07, Max Bowsher [EMAIL PROTECTED] wrote:
 Carlos Sanchez wrote:
  yes, it should work, if I configure it in the pom it does, can you try
  that?

 The interpolation does work then, yes. So that bug affects the command
 line only.

 Tthe problem of the projectNameTemplate not being applied to project
 dependencies is unaffected by configuration method.

ah, you mean the linked projects, I think I forgot that detail


this should be fixed now




 Max.



  On 6/21/07, Max Bowsher [EMAIL PROTECTED] wrote:
  Arnaud HERITIER wrote:
   are you sure that ${artifactId} is supported ? It's not
  ${pom.artifactId} ?
 
 
  The javadoc in the plugin says:
 
 [snip]
 
  I admit I haven't studied the code to be sure, but given that
  default-value...?
 
  Max.





--
I could give you my word as a Spaniard.
No good. I've known too many Spaniards.
 -- The Princess Bride




--
I could give you my word as a Spaniard.
No good. I've known too many Spaniards.
-- The Princess Bride

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



prepare to release eclipse 2.4

2007-06-20 Thread Brian E. Fox
It's been about 5 months since we last released eclipse. There are
plenty of issues already fixed:

http://jira.codehaus.org/secure/ReleaseNote.jspa?version=13001styleName
=HtmlprojectId=11133Create=Create

 

There are currently 24 remaining open. Any objections to cutting a
release as is and bumping the rest to 2.5?



Re: prepare to release eclipse 2.4

2007-06-20 Thread Carlos Sanchez

go for it

On 6/20/07, Brian E. Fox [EMAIL PROTECTED] wrote:

It's been about 5 months since we last released eclipse. There are
plenty of issues already fixed:

http://jira.codehaus.org/secure/ReleaseNote.jspa?version=13001styleName
=HtmlprojectId=11133Create=Create



There are currently 24 remaining open. Any objections to cutting a
release as is and bumping the rest to 2.5?





--
I could give you my word as a Spaniard.
No good. I've known too many Spaniards.
-- The Princess Bride

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: prepare to release eclipse 2.4

2007-06-20 Thread Arnaud HERITIER

It is in my todo list but up until now I focused on maven 1.
I have several co-workers who reported to me that they are unable to run
tests in this plugin.
I'll study this problem with them tomorrow.
I have also some patchs to apply concerning rad6 and myeclipse but it can be
included in the next release if necessary.
Go for it if you have the time ...

cheers

arnaud

On 20/06/07, Carlos Sanchez [EMAIL PROTECTED] wrote:


go for it

On 6/20/07, Brian E. Fox [EMAIL PROTECTED] wrote:
 It's been about 5 months since we last released eclipse. There are
 plenty of issues already fixed:

 http://jira.codehaus.org/secure/ReleaseNote.jspa?version=13001styleName
 =HtmlprojectId=11133Create=Create



 There are currently 24 remaining open. Any objections to cutting a
 release as is and bumping the rest to 2.5?




--
I could give you my word as a Spaniard.
No good. I've known too many Spaniards.
 -- The Princess Bride

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





--
..
Arnaud HERITIER
..
OCTO Technology - [EMAIL PROTECTED]
www.octo.com | blog.octo.com
..
ASF - [EMAIL PROTECTED]
www.apache.org | maven.apache.org
...


Re: prepare to release eclipse 2.4

2007-06-20 Thread Jason van Zyl

+1

On 20 Jun 07, at 1:01 PM 20 Jun 07, Brian E. Fox wrote:


It's been about 5 months since we last released eclipse. There are
plenty of issues already fixed:

http://jira.codehaus.org/secure/ReleaseNote.jspa? 
version=13001styleName

=HtmlprojectId=11133Create=Create



There are currently 24 remaining open. Any objections to cutting a
release as is and bumping the rest to 2.5?



Thanks,

Jason

--
Jason van Zyl
Founder and PMC Chair, Apache Maven
jason at sonatype dot com
--




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]