Re: Issue with injection in ActionListener JSF Artifact
In the specs, section 5.4.1 talks about the JSF Artifacts that are eligible for Injection. I tried testing it on Mojarra but couldn't get it to work. I couldn't even get to work other JSF Artifacts on Mojarra, so I'm not sure if they support all the objects specified in section 5.4.1 or if I'm missing some kind of configuration. On Fri, Aug 11, 2017 at 4:57 PM, Thomas Andraschko < andraschko.tho...@gmail.com> wrote: > Not sure. > Does it work in Mojarra or did you check the specs? > > 2017-08-11 22:44 GMT+02:00 Eduardo B: > >> I have encountered an issue with injection on a JSF Artifact. The >> scenario is as follows: >> >> When a class implements ActionListener, and that action listener is >> invoked from a facelet as the snippet below: >> >> >> >> >> >> > /> >> >> >> >> >> >> The behavior I’m seeing is that we cannot do @Inject on the class that >> implements the ActionListener, and @PreDestroy is not being invoked on app >> shut down. However, if we register the action listener in the >> faces-config.xml, I can see that injection is possible. >> >> Is Injection from a facelet for an ActionListener needs to be supported? >> >> >> Regards, >> >> Eduardo M. Breijo-Baullosa >> > >
Re: Issue with injection in ActionListener JSF Artifact
Not sure. Does it work in Mojarra or did you check the specs? 2017-08-11 22:44 GMT+02:00 Eduardo B: > I have encountered an issue with injection on a JSF Artifact. The scenario > is as follows: > > When a class implements ActionListener, and that action listener is > invoked from a facelet as the snippet below: > > > > > > /> > > > > > > The behavior I’m seeing is that we cannot do @Inject on the class that > implements the ActionListener, and @PreDestroy is not being invoked on app > shut down. However, if we register the action listener in the > faces-config.xml, I can see that injection is possible. > > Is Injection from a facelet for an ActionListener needs to be supported? > > > Regards, > > Eduardo M. Breijo-Baullosa >
Issue with injection in ActionListener JSF Artifact
I have encountered an issue with injection on a JSF Artifact. The scenario is as follows: When a class implements ActionListener, and that action listener is invoked from a facelet as the snippet below: The behavior I’m seeing is that we cannot do @Inject on the class that implements the ActionListener, and @PreDestroy is not being invoked on app shut down. However, if we register the action listener in the faces-config.xml, I can see that injection is possible. Is Injection from a facelet for an ActionListener needs to be supported? Regards, Eduardo M. Breijo-Baullosa
[jira] [Created] (TOBAGO-1778) Simplify IconEncoder concept
Udo Schnurpfeil created TOBAGO-1778: --- Summary: Simplify IconEncoder concept Key: TOBAGO-1778 URL: https://issues.apache.org/jira/browse/TOBAGO-1778 Project: MyFaces Tobago Issue Type: Improvement Reporter: Udo Schnurpfeil Assignee: Udo Schnurpfeil The concept introduced (but finalized) in Tobago 3.0 is a bit cumbersome and should be revised. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Reopened] (TOBAGO-1738) No UIComponents for and .
[ https://issues.apache.org/jira/browse/TOBAGO-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Udo Schnurpfeil reopened TOBAGO-1738: - > No UIComponents for and . > --- > > Key: TOBAGO-1738 > URL: https://issues.apache.org/jira/browse/TOBAGO-1738 > Project: MyFaces Tobago > Issue Type: Improvement >Reporter: Udo Schnurpfeil >Assignee: Udo Schnurpfeil > Fix For: 4.0.0 > > > Using a Facelets TagHandler is the simpler solution. So, the ScriptRenderer > and StyleRenderer classes are no longer needed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (TOBAGO-1777) Improve CSS Style rendering
Udo Schnurpfeil created TOBAGO-1777: --- Summary: Improve CSS Style rendering Key: TOBAGO-1777 URL: https://issues.apache.org/jira/browse/TOBAGO-1777 Project: MyFaces Tobago Issue Type: Improvement Reporter: Udo Schnurpfeil Assignee: Udo Schnurpfeil Drop "data-tobago-style" attribute. With CSP Level 2 it's possible, to put individual CSS inside the page marked with a nonce. So we'll get rid of the JavaScript data-attribute solution. That might render faster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TOBAGO-1776) Style RadioButton/Checkbox only by CSS
[ https://issues.apache.org/jira/browse/TOBAGO-1776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123517#comment-16123517 ] Hudson commented on TOBAGO-1776: SUCCESS: Integrated in Jenkins build Tobago Trunk #975 (See [https://builds.apache.org/job/Tobago%20Trunk/975/]) TOBAGO-1776 Style RadioButton/Checkbox only by CSS * add an HTML i tag after an input field, which could be styled * radio buttons / checkboxes are now styled with CSS (hnoeth: [http://svn.apache.org/viewvc/?view=rev=1804797]) * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectBooleanCheckboxRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyCheckboxRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectOneRadioRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/renderkit/css/TobagoClass.java * (edit) tobago-trunk/tobago-core/src/main/resources/scss/_tobago.scss > Style RadioButton/Checkbox only by CSS > -- > > Key: TOBAGO-1776 > URL: https://issues.apache.org/jira/browse/TOBAGO-1776 > Project: MyFaces Tobago > Issue Type: Improvement > Components: Core >Affects Versions: 3.0.4 >Reporter: Henning Noeth >Assignee: Henning Noeth >Priority: Minor > > Currently Tobago renders checkboxes and radiobuttons as follows: > {code} > Text > {code} > To style a radio button, pseudo css elements are needed. But input cannot > have content. This includes pseudo elements. > A pseudo element could be created on the label. But the style cannot depend > on the status of the input tag, because CSS have not a parent() selector. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-3435) [perf] _DeltaList: use ArrayList as parent
[ https://issues.apache.org/jira/browse/MYFACES-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123378#comment-16123378 ] Leonardo Uribe commented on MYFACES-3435: - Please check it > [perf] _DeltaList: use ArrayList as parent > -- > > Key: MYFACES-3435 > URL: https://issues.apache.org/jira/browse/MYFACES-3435 > Project: MyFaces Core > Issue Type: Improvement > Components: General >Affects Versions: 2.0.12-SNAPSHOT, 2.1.6-SNAPSHOT >Reporter: Martin Kočí >Assignee: Martin Kočí >Priority: Minor > Attachments: _ComponentChildrenList2.java, MYFACES-3435-2.patch, > MYFACES-3435-7.patch, MYFACES-3435.patch > > > Two internal classes _DeltaList in API: > 1) now use delegation pattern, but are always initialized with an ArrayList > instance -> use inheritance and ArrayList as parent -> improvement in memory > area, reduces number of GCed object in one request/response of (_DeltaList > instances/2) > 2) initialize expected size of _DeltaList (for example, number of validators > per one component is perhaps never 10, use: new _DeltaList(5)) > 3) use indexes in 'for' instead of iterator (java.util.RandomAccess) -> > improvement in performance -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-3435) [perf] _DeltaList: use ArrayList as parent
[ https://issues.apache.org/jira/browse/MYFACES-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123374#comment-16123374 ] Thomas Andraschko commented on MYFACES-3435: Yep, i would also only do something for 2.3. I didn't checked the View Pooling till now. Would you like to do this ticket? otherwise i could check it. > [perf] _DeltaList: use ArrayList as parent > -- > > Key: MYFACES-3435 > URL: https://issues.apache.org/jira/browse/MYFACES-3435 > Project: MyFaces Core > Issue Type: Improvement > Components: General >Affects Versions: 2.0.12-SNAPSHOT, 2.1.6-SNAPSHOT >Reporter: Martin Kočí >Assignee: Martin Kočí >Priority: Minor > Attachments: _ComponentChildrenList2.java, MYFACES-3435-2.patch, > MYFACES-3435-7.patch, MYFACES-3435.patch > > > Two internal classes _DeltaList in API: > 1) now use delegation pattern, but are always initialized with an ArrayList > instance -> use inheritance and ArrayList as parent -> improvement in memory > area, reduces number of GCed object in one request/response of (_DeltaList > instances/2) > 2) initialize expected size of _DeltaList (for example, number of validators > per one component is perhaps never 10, use: new _DeltaList(5)) > 3) use indexes in 'for' instead of iterator (java.util.RandomAccess) -> > improvement in performance -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-3435) [perf] _DeltaList: use ArrayList as parent
[ https://issues.apache.org/jira/browse/MYFACES-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123359#comment-16123359 ] Leonardo Uribe commented on MYFACES-3435: - I remember it is a trade-off between memory and speed/better code. View Pooling adds some extra cases to _DeltaList (reset delta), so it is an open case, that's the reason why the issue is still open. I would not apply it in 2.2 or lower versions but maybe for 2.3 > [perf] _DeltaList: use ArrayList as parent > -- > > Key: MYFACES-3435 > URL: https://issues.apache.org/jira/browse/MYFACES-3435 > Project: MyFaces Core > Issue Type: Improvement > Components: General >Affects Versions: 2.0.12-SNAPSHOT, 2.1.6-SNAPSHOT >Reporter: Martin Kočí >Assignee: Martin Kočí >Priority: Minor > Attachments: _ComponentChildrenList2.java, MYFACES-3435-2.patch, > MYFACES-3435-7.patch, MYFACES-3435.patch > > > Two internal classes _DeltaList in API: > 1) now use delegation pattern, but are always initialized with an ArrayList > instance -> use inheritance and ArrayList as parent -> improvement in memory > area, reduces number of GCed object in one request/response of (_DeltaList > instances/2) > 2) initialize expected size of _DeltaList (for example, number of validators > per one component is perhaps never 10, use: new _DeltaList(5)) > 3) use indexes in 'for' instead of iterator (java.util.RandomAccess) -> > improvement in performance -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-3435) [perf] _DeltaList: use ArrayList as parent
[ https://issues.apache.org/jira/browse/MYFACES-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1612#comment-1612 ] Thomas Andraschko commented on MYFACES-3435: [~lu4242] Not sure! I checked our applications and on _SMALL_ views, MyFaces creates around ~350 _DeltaLists, which means mean the patch could save around ~350 ArrayList instances of we change from wrapping to inheritance. For multiple users and on bigger views, this are a lot of ArrayList instances we could just save. > [perf] _DeltaList: use ArrayList as parent > -- > > Key: MYFACES-3435 > URL: https://issues.apache.org/jira/browse/MYFACES-3435 > Project: MyFaces Core > Issue Type: Improvement > Components: General >Affects Versions: 2.0.12-SNAPSHOT, 2.1.6-SNAPSHOT >Reporter: Martin Kočí >Assignee: Martin Kočí >Priority: Minor > Attachments: _ComponentChildrenList2.java, MYFACES-3435-2.patch, > MYFACES-3435-7.patch, MYFACES-3435.patch > > > Two internal classes _DeltaList in API: > 1) now use delegation pattern, but are always initialized with an ArrayList > instance -> use inheritance and ArrayList as parent -> improvement in memory > area, reduces number of GCed object in one request/response of (_DeltaList > instances/2) > 2) initialize expected size of _DeltaList (for example, number of validators > per one component is perhaps never 10, use: new _DeltaList(5)) > 3) use indexes in 'for' instead of iterator (java.util.RandomAccess) -> > improvement in performance -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-3435) [perf] _DeltaList: use ArrayList as parent
[ https://issues.apache.org/jira/browse/MYFACES-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123317#comment-16123317 ] Leonardo Uribe commented on MYFACES-3435: - I think the current code is ok. The patch is a good idea, but there are not enough compelling reasons to include it, the current code works just fine and there is no performance improvement here. Please note a lot of things happened over years that has made things change, and since a partial patch was already applied we can close this one as fixed. > [perf] _DeltaList: use ArrayList as parent > -- > > Key: MYFACES-3435 > URL: https://issues.apache.org/jira/browse/MYFACES-3435 > Project: MyFaces Core > Issue Type: Improvement > Components: General >Affects Versions: 2.0.12-SNAPSHOT, 2.1.6-SNAPSHOT >Reporter: Martin Kočí >Assignee: Martin Kočí >Priority: Minor > Attachments: _ComponentChildrenList2.java, MYFACES-3435-2.patch, > MYFACES-3435-7.patch, MYFACES-3435.patch > > > Two internal classes _DeltaList in API: > 1) now use delegation pattern, but are always initialized with an ArrayList > instance -> use inheritance and ArrayList as parent -> improvement in memory > area, reduces number of GCed object in one request/response of (_DeltaList > instances/2) > 2) initialize expected size of _DeltaList (for example, number of validators > per one component is perhaps never 10, use: new _DeltaList(5)) > 3) use indexes in 'for' instead of iterator (java.util.RandomAccess) -> > improvement in performance -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TOBAGO-1721) Optimize HTML output when two renderer are involved
[ https://issues.apache.org/jira/browse/TOBAGO-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123290#comment-16123290 ] Hudson commented on TOBAGO-1721: SUCCESS: Integrated in Jenkins build Tobago Trunk #974 (See [https://builds.apache.org/job/Tobago%20Trunk/974/]) TOBAGO-1721 Optimize HTML output when two renderer are involved * improve CSS class writing and markups (hnoeth: [http://svn.apache.org/viewvc/?view=rev=1804785]) * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/BoxRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/ButtonInsideButtonsRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/ButtonInsideInAfterRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/ButtonInsideInRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/ButtonRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/ButtonsRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/CommandRendererBase.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/FigureRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/FileRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/FlexLayoutRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/FlowLayoutRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/FooterRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/HeaderRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/ImageRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/InRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/LabelRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/LinkInsideCommandRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/LinkInsideLinksRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/MessagesRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/ObjectRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/OutRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/PageRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/PanelRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/PopupRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/ProgressRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SectionRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SegmentLayoutRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectBooleanCheckboxInsideCommandRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectBooleanCheckboxRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyCheckboxInsideCommandRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyCheckboxRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyListboxRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyShuttleRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectOneChoiceRenderer.java * (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectOneListboxRenderer.java *
[jira] [Created] (TOBAGO-1776) Style RadioButton/Checkbox only by CSS
Henning Noeth created TOBAGO-1776: - Summary: Style RadioButton/Checkbox only by CSS Key: TOBAGO-1776 URL: https://issues.apache.org/jira/browse/TOBAGO-1776 Project: MyFaces Tobago Issue Type: Improvement Components: Core Affects Versions: 3.0.4 Reporter: Henning Noeth Assignee: Henning Noeth Priority: Minor Currently Tobago renders checkboxes and radiobuttons as follows: {code} Text {code} To style a radio button, pseudo css elements are needed. But input cannot have content. This includes pseudo elements. A pseudo element could be created on the label. But the style cannot depend on the status of the input tag, because CSS have not a parent() selector. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-3435) [perf] _DeltaList: use ArrayList as parent
[ https://issues.apache.org/jira/browse/MYFACES-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123240#comment-16123240 ] Thomas Andraschko commented on MYFACES-3435: [~lu4242] It seems that none of those patches were applied in the past. Do you think we should do it? IMO the patches are looking good and inheritance seems nicer as wrapping for me. > [perf] _DeltaList: use ArrayList as parent > -- > > Key: MYFACES-3435 > URL: https://issues.apache.org/jira/browse/MYFACES-3435 > Project: MyFaces Core > Issue Type: Improvement > Components: General >Affects Versions: 2.0.12-SNAPSHOT, 2.1.6-SNAPSHOT >Reporter: Martin Kočí >Assignee: Martin Kočí >Priority: Minor > Attachments: _ComponentChildrenList2.java, MYFACES-3435-2.patch, > MYFACES-3435-7.patch, MYFACES-3435.patch > > > Two internal classes _DeltaList in API: > 1) now use delegation pattern, but are always initialized with an ArrayList > instance -> use inheritance and ArrayList as parent -> improvement in memory > area, reduces number of GCed object in one request/response of (_DeltaList > instances/2) > 2) initialize expected size of _DeltaList (for example, number of validators > per one component is perhaps never 10, use: new _DeltaList(5)) > 3) use indexes in 'for' instead of iterator (java.util.RandomAccess) -> > improvement in performance -- This message was sent by Atlassian JIRA (v6.4.14#64029)