Re: [VOTE] Release Tobago 5.4.0 and checkstyle-rules 20

2022-12-12 Thread Dennis Kieselhorst

+1

Dennis


[jira] [Commented] (TOBAGO-2084) CVE suppression for Tobago 5

2021-05-30 Thread Dennis Kieselhorst (Jira)


[ 
https://issues.apache.org/jira/browse/TOBAGO-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17354216#comment-17354216
 ] 

Dennis Kieselhorst commented on TOBAGO-2084:


Why do we require a checkstyle suppression for CVE-2021-23343 path-parse? 
https://nvd.nist.gov/vuln/detail/CVE-2021-23343 mentions that it's fixed in 
1.0.7, can't we just use that version?


> CVE suppression for Tobago 5
> 
>
> Key: TOBAGO-2084
> URL: https://issues.apache.org/jira/browse/TOBAGO-2084
> Project: MyFaces Tobago
>  Issue Type: Task
>  Components: Build
>Reporter: Udo Schnurpfeil
>Assignee: Udo Schnurpfeil
>Priority: Minor
> Fix For: 4.5.4, 5.0.0
>
>
> Split CVE suppression list between Tobago 4 and 5
> Also:
>  * add CVE suppression for npm path-parse



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: [VOTE] Release Tobago 4.5.4, 5.0.0-alpha-1 and checkstyle-rules 14

2021-05-30 Thread Dennis Kieselhorst
Hi,

why do we require a checkstyle suppression for CVE-2021-23343 path-parse? 
https://nvd.nist.gov/vuln/detail/CVE-2021-23343 mentions that it's fixed in 
1.0.7, can't we just use that version?

Best,
Dennis


Re: [VOTE] Release Tobago 2.4.3 and checkstyle-rules 13

2021-01-10 Thread Dennis Kieselhorst

+1

Thanks Udo!



Re: [VOTE] Release Tobago 4.5.1

2020-11-02 Thread Dennis Kieselhorst
+1


Re: Release MyFaces Core 3.0.0-M1?

2019-12-12 Thread Dennis Kieselhorst
Thank you for driving this Thomas.

I like releasing early and often but just indicating a completely refactored 
version from a different branch with a classifier sounds confusing for me. Why 
not using 2.4? There will be no JSF 2.4 version so I don't see any conflict 
there.

Regarding extension repos: We have repos for myfaces-extcdi and myfaces-extval. 
Another additional one for quarkus doesn't hurt, I can take care of creating 
it, if you want.

Best,
Dennis


[jira] [Commented] (TRINIDAD-2566) NullPointerException after upgrading from apache-tomcat-8.5.47 to apache-tomcat-8.5.49

2019-12-07 Thread Dennis Kieselhorst (Jira)


[ 
https://issues.apache.org/jira/browse/TRINIDAD-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990422#comment-16990422
 ] 

Dennis Kieselhorst commented on TRINIDAD-2566:
--

Thanks for your bug report. There are no active Trinidad developers at the 
moment. Any chance that you create a pull request with a fix? You can find the 
code here: 
https://github.com/apache/myfaces-trinidad/blob/master/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/skin/AgentAtRuleMatcher.java

> NullPointerException after upgrading from apache-tomcat-8.5.47 to 
> apache-tomcat-8.5.49 
> ---
>
> Key: TRINIDAD-2566
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2566
> Project: MyFaces Trinidad
>  Issue Type: Bug
>  Components: Skinning
>Affects Versions: 2.2.0-core
> Environment: apache-tomcat-8.5.49
>Reporter: Pervasync
>Priority: Blocker
>
> After upgrading from apache-tomcat-8.5.47 to apache-tomcat-8.5.49, got this 
> exception when loading jspx page:
>  
> {{java.lang.NullPointerException
>   at 
> org.apache.myfaces.trinidadinternal.skin.AgentAtRuleMatcher$TouchScreenCapabilityMatcher.match(AgentAtRuleMatcher.java:863)
>   at 
> org.apache.myfaces.trinidadinternal.skin.AgentAtRuleMatcher.match(AgentAtRuleMatcher.java:502)
>   at 
> org.apache.myfaces.trinidadinternal.style.xml.parse.StyleSheetNode._compareBrowserAndVersion(StyleSheetNode.java:379)
>   at 
> org.apache.myfaces.trinidadinternal.style.xml.parse.StyleSheetNode.compareVariants(StyleSheetNode.java:194)
>   at 
> org.apache.myfaces.trinidadinternal.style.xml.parse.StyleSheetDocument._getStyleSheets(StyleSheetDocument.java:569)
>   at 
> org.apache.myfaces.trinidadinternal.style.xml.parse.StyleSheetDocument.getStyleSheetsAsCollection(StyleSheetDocument.java:201)
>   at 
> org.apache.myfaces.trinidadinternal.style.xml.parse.StyleSheetDocument.getStyleSheets(StyleSheetDocument.java:196)
>   at 
> org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache._getNamespacePrefixes(FileSystemStyleCache.java:1324)
>   at 
> org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache._getStyleSheetDocument(FileSystemStyleCache.java:956)
>   at 
> org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache._getEntry(FileSystemStyleCache.java:425)
>   at 
> org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache.getStyleSheetURIs(FileSystemStyleCache.java:142)
>   at 
> org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.StyleSheetRenderer.encodeAll(StyleSheetRenderer.java:81)
>   at 
> org.apache.myfaces.trinidad.render.CoreRenderer.delegateRenderer(CoreRenderer.java:688)
>   at 
> org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.HeadRenderer.encodeEnd(HeadRenderer.java:97)
>   at 
> org.apache.myfaces.trinidad.render.CoreRenderer.encodeEnd(CoreRenderer.java:551)
>   at 
> org.apache.myfaces.trinidad.component.UIXComponentBase.encodeEnd(UIXComponentBase.java:1239)
>   at javax.faces.component.UIComponent.encodeAll(UIComponent.java:823)
>   at javax.faces.component.UIComponent.encodeAll(UIComponent.java:819)
>   at 
> javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:551)
>   at 
> org.apache.myfaces.shared.view.JspViewDeclarationLanguageBase.actuallyRenderView(JspViewDeclarationLanguageBase.java:351)
>   at 
> org.apache.myfaces.shared.view.JspViewDeclarationLanguageBase.renderView(JspViewDeclarationLanguageBase.java:200)
>   at 
> org.apache.myfaces.trinidad.view.ViewDeclarationLanguageWrapper.renderView(ViewDeclarationLanguageWrapper.java:101)
>   at 
> org.apache.myfaces.trinidadinternal.application.ViewDeclarationLanguageFactoryImpl$ChangeApplyingVDLWrapper.renderView(ViewDeclarationLanguageFactoryImpl.java:338)
>   at 
> org.apache.myfaces.application.ViewHandlerImpl.renderView(ViewHandlerImpl.java:313)
>   at 
> javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:58)
>   at 
> org.apache.myfaces.trinidadinternal.application.ViewHandlerImpl.renderView(ViewHandlerImpl.java:170)
>   at 
> org.apache.myfaces.lifecycle.RenderResponseExecutor.execute(RenderResponseExecutor.java:116)
>   at 
> org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:267)
>   at javax.faces.webapp.FacesServlet.service(FacesServlet.java:200)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.interna

Re: [VOTE] release of MyFaces Core 2.3.5

2019-10-10 Thread Dennis Kieselhorst
+1

Thanks Paul!


Re: [VOTE] Release Tobago 4.4.1

2019-05-28 Thread Dennis Kieselhorst
+1

Thanks!


Re: [VOTE] Release Tobago 2.4.0

2019-01-29 Thread Dennis Kieselhorst
+1
although I don't think it's a good idea to have this breaking change in this 
old version. Users need to migrate from FileItem to Part and it's no longer 
possible to use releases as a drop-in replacement in case of security fixes.

I'm no longer using 2.x and as no one else spoke up it seems to be ok. Another 
2.3.x release can be done if required.

Regards
Dennis



Re: MyFaces 2.3.3 release issue - any help is appreciated

2019-01-17 Thread Dennis Kieselhorst
Hi Paul,

looks like an old assembly-plugin version is used.

This one is for the stacktrace 
https://github.com/apache/maven-assembly-plugin/blob/maven-assembly-plugin-2.2.1/src/main/java/org/apache/maven/plugin/assembly/mojos/AbstractAssemblyMojo.java
 and doesn't allow posix while master 
https://github.com/apache/maven-assembly-plugin/blob/master/src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java
 allows it.

Regards
Dennis


Re: MyFaces 2.3.3 release?

2019-01-15 Thread Dennis Kieselhorst
Hi Paul!

> I started taking a look at starting the new release today and Eduardo
> reminded me that we need to move from SHA1 hashes to SHA256 or SHA512.
> 
> Does anyone know what we need to do in order to fix this in our builds for
> the release?

See https://issues.apache.org/jira/browse/MPOM-205 we already have the change 
in parent poms, so we are fine, aren't we?

Regards
Dennis


Re: Jakarta JSF-API at Eclipse EE4J

2019-01-10 Thread Dennis Kieselhorst


> I can image something like this:
> the javaee-api.jar could contain flatten API classes, without
> implementation details. Just the plain API, without actual logic.
> user could simply add this as provided dependency.

Right that's what I had in mind.

Regards
Dennis


Jakarta JSF-API at Eclipse EE4J

2019-01-10 Thread Dennis Kieselhorst
Hi,

yesterday I noticed this issue: 
https://github.com/eclipse-ee4j/mojarra/issues/4480

Is it that complicated to create an API jar that both works for Mojarra and 
MyFaces?

Regards
Dennis


Sonar analysis results for 3.0.0-SNAPSHOT available

2018-12-20 Thread Dennis Kieselhorst
Hi,

I changed the config for the Sonar build job from SVN to Gitbox master. The 
Sonar analysis results are now available at: 
https://builds.apache.org/analysis/overview?id=28170

Regards
Dennis


Re: [VOTE] Release Tobago 3.1.1 and 4.3.2

2018-11-21 Thread Dennis Kieselhorst
+1


Re: [VOTE] Release Tobago 4.3.1 and checkstyle-rules 12

2018-11-05 Thread Dennis Kieselhorst
+1


Re: [VOTE] Release Tobago 2.3.0

2018-10-31 Thread Dennis Kieselhorst
+1


Re: MyFaces 3.x - Remove "Impl Shaded" + "Impl Shaded Public"? @cc tobago-guys :P

2018-10-20 Thread Dennis Kieselhorst
Go ahead, I don't see a good reason to keep it.

Cheers
Dennis


Re: MyFaces Core 3.0

2018-10-13 Thread Dennis Kieselhorst
On 2018/10/11 12:43:01, Thomas Andraschko  wrote: 
> We could but -1; users can simple stay on 2.x
> 
> Also moving it to own modules is much effort to create and maintain.

+1


Re: [VOTE] Release Tobago 2.2.0, 3.1.0, 4.3.0 and checkstyle-rules 11

2018-09-26 Thread Dennis Kieselhorst
+1

Thanks!


Re: 2.3.2 Release

2018-08-30 Thread Dennis Kieselhorst
> When I perform the above operation there is no new tag created in SVN with
> the source code for the 2.3.2 release. Is this now expected since all of
> our source is in GIT? I just want to ensure that I'm not missing anything.

Yes, SVN is no longer involved (only for site publishing). I can see the tag in 
Git: https://github.com/apache/myfaces/tree/myfaces-core-module-2.3.2

So it looks fine so far...

Regards
Dennis




Re: 2.3.2 Release

2018-08-29 Thread Dennis Kieselhorst
On 2018/08/27 13:19:25, Thomas Andraschko  wrote: 
> I think we just need to change the version after the release in the
> core-pom.

Correct. I've just updated the file.

Regards
Dennis


Re: [VOTE] Release of MyFaces Master POM version 19

2018-08-25 Thread Dennis Kieselhorst
+1

Thanks!


Re: 2.3.2 Release

2018-07-07 Thread Dennis Kieselhorst
Hi!

> In the meantime, I have some questions after the move to Git. I'm not sure
> if after the move, we have to modify some pom.xml files, do you guys know
> if we have to make any modification? Does the release process stay the
> same? Any help here would be great.
 
I've changed the scm section from svn to git directly after the migration but 
you're right there may be other places where we have to modify something. My 
suggestion is to cut a release and let the list know if there are some 
problems. We have some experiences from the Tobago migration, afaik there were 
no big problems.

Please note that the site/ publishing stuff is still in SVN, so no changes 
required in this area.

Regards
Dennis


Re: Migrate all MyFaces projects to Git

2018-06-21 Thread Dennis Kieselhorst
Great, thank you!

On 2018/06/21 13:59:15, Werner Punz  wrote:
> Just deleted it...>



Re: Migrate all MyFaces projects to Git

2018-06-21 Thread Dennis Kieselhorst
I don't know who created 2.3.x_ and for what reason. 2.3.x is currently
on master and that's where we should release the next version.

Best
Dennis

On 2018/06/21 13:30:19, "Paul Nicolucci"  wrote:
>
> I see we have a master branch on git as well as a "2.3.x_". I've been>
> committing changes for version 2.3.x to the master branch should we also>
> commit to the 2.3.x_ branch? Just want to ensure I'm doing the correct>
> deliveries.>
>
> I assume we just need to deliver to master for 2.3 changes right now and>
> then once we start a 2.4 etc we'll catch the 2.3.x branch up to master
and>
> do new forward development in master?>
>
> Thanks,>
>
> Paul Nicolucci>
>
>
>
> From: Dennis Kieselhorst >
> To: >
> Date: 05/23/2018 06:20 AM>
> Subject: Re: Migrate all MyFaces projects to Git>
>
>
>
> > AFAICS you merged the 2.3.x into master, right? Shoudln't we remove
the>
> > 2.3.x branch then?>
>
> You are right. I was waiting for other opinions regarding 2.4.x in
master.>
> For now I've removed the 2.3.x branch.>
>
> Regards>
> Dennis>
>
>
>
>


[jira] [Commented] (TRINIDAD-2564) maven-faces-plugin

2018-06-18 Thread Dennis Kieselhorst (JIRA)


[ 
https://issues.apache.org/jira/browse/TRINIDAD-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515854#comment-16515854
 ] 

Dennis Kieselhorst commented on TRINIDAD-2564:
--

Find a dev who prepares a release and starts a vote by asking on the 
mailinglist: [https://lists.apache.org/list.html?dev@myfaces.apache.org]

[~bommel] has experiences with doing Trinidad releases, but he is quite busy at 
the moment.

> maven-faces-plugin
> --
>
> Key: TRINIDAD-2564
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2564
> Project: MyFaces Trinidad
>  Issue Type: Bug
>  Components: Plugins
>Affects Versions: 2.2.0-core
> Environment: Windows 8.1, Windows 10, Tomcat 8+, Glassfish
>Reporter: Médéric Martin
>Priority: Critical
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> Hi,
> I detect one bog in the last version which is relative to TRINIDAD-2483 . 
> [~arobinson74] said on July 2014 "Fixed in both the plugins and the trunk." 
> Yes it was, but the plugin maven has no release since 13/11/2013 (maven repo 
> public). So, actually the bog is always there, and we have NullPointer with 
> new version of EL on Tomcat 8+. Furthermore, I checkouted source SVN of 
> maven-faces-plugin, and the pom.xml is 2.0.9-SNAPSHOT. With these version, it 
> works... So, is it possible to release a 2.0.9 maven-faces-plugin please ?? 
> (y)
> Thanks



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: MyFaces Svn or Git?

2018-05-29 Thread Dennis Kieselhorst
Hi Eduardo,

you have to use Git. SVN has been switched to readonly.

Regards
Dennis


Re: Migrate all MyFaces projects to Git

2018-05-23 Thread Dennis Kieselhorst
> AFAICS you merged the 2.3.x into master, right? Shoudln't we remove the
> 2.3.x branch then?

You are right. I was waiting for other opinions regarding 2.4.x in master. For 
now I've removed the 2.3.x branch.

Regards
Dennis


[jira] [Commented] (TOBAGO-1899) Error building tobago 4.2.1 on windows 10

2018-05-16 Thread Dennis Kieselhorst (JIRA)

[ 
https://issues.apache.org/jira/browse/TOBAGO-1899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477002#comment-16477002
 ] 

Dennis Kieselhorst commented on TOBAGO-1899:


I was able to reproduce this on a Windows machine.

> Error building tobago 4.2.1 on windows 10
> -
>
> Key: TOBAGO-1899
> URL: https://issues.apache.org/jira/browse/TOBAGO-1899
> Project: MyFaces Tobago
>  Issue Type: Bug
>  Components: Build
>Affects Versions: 4.2.0
> Environment: git clone + maven + windows 10
>Reporter: maurel
>Priority: Minor
>
> Failure is encountered when building tobago-4.2.1 on windows 10:
> ---
> Test set: org.apache.myfaces.tobago.renderkit.css.BootstrapClassUnitTest
> ---
> Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.292 sec <<< 
> FAILURE! - in org.apache.myfaces.tobago.renderkit.css.BootstrapClassUnitTest
> testCompareBootstrapCss(org.apache.myfaces.tobago.renderkit.css.BootstrapClassUnitTest)
>  Time elapsed: 0.054 sec  <<< FAILURE!
> java.lang.AssertionError: These classes are missing in bootstrap.css: 
> [ALIGN_ITEMS_BASELINE, ALIGN_ITEMS_CENTER, ALIGN_ITEMS_END, 
> ALIGN_ITEMS_START, ALIGN_ITEMS_STRETCH, BG_DARK, BORDER_DANGER, BORDER_INFO, 
> BORDER_WARNING, D_FLEX, D_INLINE, D_NONE, D_SM_NONE, FIXED_BOTTOM, FIXED_TOP, 
> FLEX_COLUMN, FLEX_COLUMN_REVERSE, FLEX_ROW, FLEX_ROW_REVERSE, INVISIBLE, 
> JUSTIFY_CONTENT_AROUND, JUSTIFY_CONTENT_BETWEEN, JUSTIFY_CONTENT_CENTER, 
> JUSTIFY_CONTENT_END, JUSTIFY_CONTENT_START, ML_AUTO, ML_LG_AUTO, ML_MD_AUTO, 
> ML_SM_AUTO, ML_XL_AUTO, MR_AUTO, MR_LG_AUTO, MR_MD_AUTO, MR_SM_AUTO, 
> MR_XL_AUTO, MY_LG_0, MY_LG_1, MY_LG_2, MY_LG_3, MY_LG_4, MY_LG_5, MX_AUTO, 
> MX_LG_AUTO, MX_MD_AUTO, MX_SM_AUTO, MX_XL_AUTO, SR_ONLY, TEXT_CENTER, 
> TEXT_JUSTIFY, TEXT_LEFT, TEXT_RIGHT]
> at 
> org.apache.myfaces.tobago.renderkit.css.BootstrapClassUnitTest.testCompareBootstrapCss(BootstrapClassUnitTest.java:86)
> If I comment org.apache.myfaces.tobago.renderkit.css.BootstrapClassUnitTest 
> testCompareBootstrapCss(org.apache.myfaces.tobago.renderkit.css.BootstrapClassUnitTest)
>  then everything runs fine.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Migrate all MyFaces projects to Git

2018-05-14 Thread Dennis Kieselhorst
So the git migration is finished from INFRA point of view. All active projects 
from SVN have been moved to git and all previous mirrored repos have also been 
transfered (except portlet-bridge which was never setup properly and therefore 
removed).

In total we have now 11 repos: 
https://github.com/apache/?utf8=%E2%9C%93=myfaces

I noticed that not every active MyFaces committer has linked his GitHub account 
properly. If you want to work with GitHub (not mandatory), you have to link it 
via: https://gitbox.apache.org/setup/

Everyone should update the documentation (site, release checklists, ...) when 
coming across old svn references.

Cheers
Dennis


Re: Migrate all MyFaces projects to Git

2018-05-09 Thread Dennis Kieselhorst
Build-tools are now also finished, please use 
https://gitbox.apache.org/repos/asf/myfaces-build-tools.git or 
https://github.com/apache/myfaces-build-tools from now (default branch is 
currently wrong on GitHub, needs to be fixed by INFRA).

The site needs an update. Several places still mention SVN, some of these pages 
are even no longer linked in the menu. So far I just put a news entry on the 
main page and updated the doap file.


Re: Migrate all MyFaces projects to Git

2018-05-09 Thread Dennis Kieselhorst
> > WDYT about deleting some unused branches?
> > IMO we can remove everything, we just need the normal versions like 2.2.x,
> > 1.1.x, ...
> >
> > 2.1.x-client-window, 2.1.x-copy,  2.0.8_windowid_prototype, ... can be
> > removerd.

I agree, feel free to remove them. I just took over what we had in SVN.

> About the 2.3.x branch:
> IMO we could also set the master to 2.4.x and leave the 2.3.x branch as it
> is.
> Or should we until the work on JSF.next starts?

I think we should stick to 2.3.x for a while. It will take some time until JSF 
2.4 and although merging is easier with Git, it simplifies the development for 
now.

Regards
Dennis


Re: Migrate all MyFaces projects to Git

2018-05-08 Thread Dennis Kieselhorst
To avoid further confusion I've just done the merge from 2.3.x to master. 
Please have a look, if everything is fine for you. After that we can delete the 
2.3.x branch.

Cheers
Dennis


Re: Migrate all MyFaces projects to Git

2018-05-08 Thread Dennis Kieselhorst
You need to switch to 2.3.x branch. Master still points to 2.2.x because this 
was trunk before the migration.


Re: Migrate all MyFaces projects to Git

2018-05-08 Thread Dennis Kieselhorst
So the migration of MyFaces Core is done. Please use 
https://gitbox.apache.org/repos/asf/myfaces.git or 
https://github.com/apache/myfaces from now.

Any volunteer who merges 2.3.x to master (former 2.2.x trunk)? I think it makes 
sense to switch now.

I'll continue with build-tools, it's more difficult then first thought, so it 
will take some extra time.

I was not aware that we already had mirrors for
https://github.com/apache/myfaces-extcdi
https://github.com/apache/myfaces-extval
https://github.com/apache/myfaces-html5
https://github.com/apache/myfaces-portlet-bridge
https://github.com/apache/myfaces-scripting

I'll have them transfered to Gitbox.


Re: Migrate all MyFaces projects to Git

2018-05-07 Thread Dennis Kieselhorst
As you might have read in the INFRA issue we are close to migrate the core repo 
so please do not commit until further notice. This simplifies the migration 
process. I already have a local git repo, just waiting for INFRA to cleanup old 
mirrors.


Re: [VOTE] Release Tobago 4.2.1

2018-05-06 Thread Dennis Kieselhorst
+1


[jira] [Commented] (TRINIDAD-2564) maven-faces-plugin

2018-05-04 Thread Dennis Kieselhorst (JIRA)

[ 
https://issues.apache.org/jira/browse/TRINIDAD-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463427#comment-16463427
 ] 

Dennis Kieselhorst commented on TRINIDAD-2564:
--

Please note that the sources have been moved to Git: 
https://github.com/apache/myfaces-trinidad-maven

> maven-faces-plugin
> --
>
> Key: TRINIDAD-2564
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2564
> Project: MyFaces Trinidad
>  Issue Type: Bug
>  Components: Plugins
>Affects Versions: 2.2.0-core
> Environment: Windows 8.1, Windows 10, Tomcat 8+, Glassfish
>Reporter: Médéric Martin
>Priority: Critical
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> Hi,
> I detect one bog in the last version which is relative to TRINIDAD-2483 . 
> [~arobinson74] said on July 2014 "Fixed in both the plugins and the trunk." 
> Yes it was, but the plugin maven has no release since 13/11/2013 (maven repo 
> public). So, actually the bog is always there, and we have NullPointer with 
> new version of EL on Tomcat 8+. Furthermore, I checkouted source SVN of 
> maven-faces-plugin, and the pom.xml is 2.0.9-SNAPSHOT. With these version, it 
> works... So, is it possible to release a 2.0.9 maven-faces-plugin please ?? 
> (y)
> Thanks



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (TRINIDAD-2527) Row selection retains with tr:table

2018-05-04 Thread Dennis Kieselhorst (JIRA)

[ 
https://issues.apache.org/jira/browse/TRINIDAD-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463426#comment-16463426
 ] 

Dennis Kieselhorst commented on TRINIDAD-2527:
--

Mike's statement above is still valid. So please fork the project 
http://github.com/apache/myfaces-trinidad and provide a pull request. We will 
review and apply it.

> Row selection retains with tr:table
> ---
>
> Key: TRINIDAD-2527
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2527
> Project: MyFaces Trinidad
>  Issue Type: Bug
>  Components: Archetype
>Affects Versions: 2.1.1-core
> Environment: Windows 7, Java 7
>Reporter: Deepan
>Priority: Major
>   Original Estimate: 120h
>  Remaining Estimate: 120h
>
> A page contains  with rowSelection as "Single/Multiple" and the 
> beans are session scoped. 
> - Select a row using the radio or checkbox
> - Navigate to some other pages
> - Again come back to page 1. Now, previously selected radio or checkbox are 
> selected. 
> {code:title=Sample code|borderStyle=solid}
>  rowSelection="single"
> value="#{myBean.myList}"
> var="groups" varStatus="rowId" rowBandingInterval="1" 
> verticalGridVisible="true"
> selectionListener="#{myBackingBean.myRowSelectListener}">
> ...
> ...
> 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Migrate all MyFaces projects to Git

2018-05-03 Thread Dennis Kieselhorst
test has been moved to https://gitbox.apache.org/repos/asf/myfaces-test.git and 
https://github.com/apache/myfaces-test


Re: [VOTE] release of MyFaces Core 2.3.1

2018-05-01 Thread Dennis Kieselhorst
+1


Re: Migrate all MyFaces projects to Git

2018-04-28 Thread Dennis Kieselhorst
myfaces-master-pom has been moved to 
https://gitbox.apache.org/repos/asf/myfaces-master-pom.git and 
https://github.com/apache/myfaces-master-pom

I was unable to clone myfaces-core from svn:
Checksum mismatch: 
myfaces/core/branches/2.1.x/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlResponseWriterImpl.java
 de45947a39de1f3cd2c2d116cad7581f95b95bf9
expected: 9f9d5ed8f999a5e0742aab118c07666f
 got: f5ee553e7065c5c9c84366ed2a2c7185 

I asked infra to run a verify command to ensure that the svn repo is not 
corrupted.


Re: Perform MyFaces 2.3.1 release?

2018-04-26 Thread Dennis Kieselhorst
Feel free. Could be also a chance to see if everything on Git is working...

Regards
Dennis


Re: Migrate all MyFaces projects to Git

2018-04-26 Thread Dennis Kieselhorst

> > I tried to convert the existing svn repo to git, but unfortunately there
> > are historical svn authors like royalts, dave, o_rossmueller,  How
> > to map them? Are there corresponding Apache committer names or should I use
> > dev-n...@apache.org for them?

I found out that those usernames are SourceForge usernames. I was able to map 
them :D

royalts = Thomas Spiegl
dave = Anton Koinov
o_rossmueller = Oliver Rossmueller
tinytoony = Martin Marinschek
prophecyslides = Travis Reeder 


Re: Migrate all MyFaces projects to Git

2018-04-26 Thread Dennis Kieselhorst
> I've opened an INFRA issue to get the repos ready: 
> https://issues.apache.org/jira/browse/INFRA-16402

Got feedback from INFRA, plan is to update existing myfaces repo first and then 
migrate it to Gitbox.

I tried to convert the existing svn repo to git, but unfortunately there are 
historical svn authors like royalts, dave, o_rossmueller,  How to map 
them? Are there corresponding Apache committer names or should I use 
dev-n...@apache.org for them?

Does anyone know if there's a flag to tell git-svn to default to this entry if 
the key is not in the authors file? I'm using: 
https://git-wip-us.apache.org/authors.txt

Regards
Dennis


Re: [VOTE] Release Tobago 4.2.0

2018-04-22 Thread Dennis Kieselhorst
Just played around a bit, has anyone seen this before?

java.lang.IllegalArgumentException: Intermediate identifier j_id_k in search 
expression j_id_k::command identifies a UIComponent that is not a 
NamingContainer
at javax.faces.component.UIComponentBase.findComponent(UIComponentBase.java:747)
at javax.faces.component.UIComponentBase.findComponent(UIComponentBase.java:751)
at javax.faces.component.UIComponentBase.findComponent(UIComponentBase.java:751)
at 
org.apache.myfaces.tobago.internal.component.AbstractUIPage.markSubmittedForm(AbstractUIPage.java:87)
at 
org.apache.myfaces.tobago.internal.component.AbstractUIPage.processDecodes(AbstractUIPage.java:63)
at 
javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.java:1371)
at javax.faces.component.UIViewRoot._processDecodesDefault(UIViewRoot.java:1446)
at javax.faces.component.UIViewRoot.access$400(UIViewRoot.java:74)
at 
javax.faces.component.UIViewRoot$ApplyRequestValuesPhaseProcessor.process(UIViewRoot.java:1537)
at javax.faces.component.UIViewRoot._process(UIViewRoot.java:1412)
at javax.faces.component.UIViewRoot.processDecodes(UIViewRoot.java:772)
at 
org.apache.myfaces.lifecycle.ApplyRequestValuesExecutor.execute(ApplyRequestValuesExecutor.java:38)
at 
org.apache.myfaces.lifecycle.LifecycleImpl.executePhase(LifecycleImpl.java:171)
at org.apache.myfaces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:118)
at 
org.apache.deltaspike.jsf.impl.listener.request.DeltaSpikeLifecycleWrapper.execute(DeltaSpikeLifecycleWrapper.java:89)
at javax.faces.webapp.FacesServlet.service(FacesServlet.java:189)

I'm unable to reproduce this
therefore +1

Best,
Dennis


Re: [VOTE] Release Tobago 4.2.0

2018-04-22 Thread Dennis Kieselhorst
Hi Udo,

could you please update http://tobago-vm.apache.org with this version? 

Cheers
Dennis


Re: Migrate all MyFaces projects to Git

2018-04-19 Thread Dennis Kieselhorst
I've opened an INFRA issue to get the repos ready: 
https://issues.apache.org/jira/browse/INFRA-16402


Re: Migrate all MyFaces projects to Git

2018-04-12 Thread Dennis Kieselhorst
Yes, everything is working. It's good idea to do the migration.

As far as I can see we need the following repos:
myfaces (for myfaces-core, already exists as old mirror 
https://github.com/apache/myfaces)
myfaces-master-pom
myfaces-build-tools
myfaces-extensions
myfaces-test

The other stuff has not been updated for over a year 
(http://svn.apache.org/viewvc/myfaces/?sortby=date) so looks like no need to 
migrate it?!

Is anyone willing to do further cleanup?

Regards
Dennis

On 2018/04/11 18:37:23, Thomas Andraschko <andraschko.tho...@gmail.com> wrote: 
> Is everything fine now for tobago and trinidad?
> 
> +1 for migrating core now as 2.3.0 is out, maybe we have to wait for 2.3.1
> 
> we could also do a bit a cleanup and only migrate the active projects
> We must also check e.g. the maven plugins and master poms...
> E.g. we could remove the checkstyle files and move them to the tobago and
> core itself instead maintain a projects which contains both...
> 
> It think it would be the right momemt to do a cleanup now, to make it
> easier to maintain in the future.
> 
> 
> 2017-09-17 20:16 GMT+02:00 Dennis Kieselhorst <d...@apache.org>:
> 
> >
> > > https://svn.apache.org/repos/asf/myfaces/trinidad-maven/ has not been
> > > migrated yet, I've requested a new repo for it.
> > Migration of trinidad-maven is finished:
> > https://github.com/apache/myfaces-trinidad-maven or
> > https://gitbox.apache.org/repos/asf?p=myfaces-trinidad-maven.git
> >
> 


Re: [VOTE] Release of MyFaces Master POM version 18

2018-03-18 Thread Dennis Kieselhorst
+1


Re: Questions about MyFaces 2.3.0 release

2018-03-09 Thread Dennis Kieselhorst
On 2018/03/10 03:04:46, Eduardo B  wrote: 
> I can even see it here:
> http://central.maven.org/maven2/org/apache/myfaces/core/myfaces-api/2.3.0/
> 
> But not sure why I cannot see it here when I do the search:
> https://mvnrepository.com/artifact/org.apache.myfaces.core/myfaces-api

I wouldn't care about it, the first thing matters and that looks correct to me.

Cheers
Dennis


[jira] [Commented] (TOBAGO-1868) Update release process: remove MD5 support

2018-03-05 Thread Dennis Kieselhorst (JIRA)

[ 
https://issues.apache.org/jira/browse/TOBAGO-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386034#comment-16386034
 ] 

Dennis Kieselhorst commented on TOBAGO-1868:


Should be done in myfaces-master-pom for all projects, shouldn't it? I noticed 
there is a new apache pom version 19 with digest-algo set.

> Update release process: remove MD5 support
> --
>
> Key: TOBAGO-1868
> URL: https://issues.apache.org/jira/browse/TOBAGO-1868
> Project: MyFaces Tobago
>  Issue Type: Task
>  Components: Build
>Reporter: Udo Schnurpfeil
>Assignee: Udo Schnurpfeil
>Priority: Major
> Fix For: 4.1.1
>
>
> The rules on the Apache pages has been changed:
> http://www.apache.org/dev/release-distribution#sigs-and-sums
> {panel:title=Point 4}
> SHOULD NOT supply a MD5 checksum file (because MD5 is too broken).
> {panel}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: [VOTE] release of MyFaces Core 2.3.0

2018-03-03 Thread Dennis Kieselhorst
+1

Cheers
Dennis


Re: [VOTE] release of MyFaces Core 2.3.0

2018-02-28 Thread Dennis Kieselhorst
Hi Eduardo,

thanks for building the release. I plan to check it on the weekend. Sorry for 
the delay...

Cheers
Dennis


Re: [VOTE] Release Tobago 4.1.0 (2nd try)

2018-02-12 Thread Dennis Kieselhorst
+1


Re: [VOTE] Checkstyle Rules version 10

2018-02-07 Thread Dennis Kieselhorst
+1


Re: [VOTE] Release Tobago 4.1.0

2018-02-07 Thread Dennis Kieselhorst
+1 

Next time you could directly use checkstyle-rules 10 if you start a parallel 
vote anyway.


Re: [Tobago] Preparation for the 4.1.0 release

2018-02-01 Thread Dennis Kieselhorst
Hi Udo,

I appreciate that. Looks like we will be the first library with Bootstrap 4 
final.

Cheers
Dennis


Re: MyFaces 2.3.0 Release?

2018-02-01 Thread Dennis Kieselhorst
Hi Thomas!

> Also we probably need to cleanup the branches/trunk a bit?!
> Trunk is actually 2.2.x - we should move it to a 2.2.x branch.
> Then we would need to merge the changes from 2.3.x into trunk and make
> trunk 2.4.x?

I would leave 2.3.x in trunk for a while as we did with 2.2.x before.

Leo, do you have time to do the release?

Cheers
Dennis


Re: [VOTE] Release Tobago 2.1.1

2018-01-27 Thread Dennis Kieselhorst
+1


Re: [VOTE] Checkstyle Rules version 9

2018-01-20 Thread Dennis Kieselhorst
+1


[jira] [Commented] (TOBAGO-1837) Update Bootstrap to 4.0.0 beta 3 (from beta 2)

2018-01-19 Thread Dennis Kieselhorst (JIRA)

[ 
https://issues.apache.org/jira/browse/TOBAGO-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331943#comment-16331943
 ] 

Dennis Kieselhorst commented on TOBAGO-1837:


FYI 4.0.0 stable has just been released.

> Update Bootstrap to 4.0.0 beta 3 (from beta 2)
> --
>
> Key: TOBAGO-1837
> URL: https://issues.apache.org/jira/browse/TOBAGO-1837
> Project: MyFaces Tobago
>  Issue Type: Task
>  Components: Core, Themes
>Affects Versions: 4.0.0
>Reporter: Henning Noeth
>Assignee: Henning Noeth
>Priority: Major
> Fix For: 4.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (MYFACES-4140) NullPointerException instead of InvalidViewIdException

2018-01-08 Thread Dennis Kieselhorst (JIRA)

 [ 
https://issues.apache.org/jira/browse/MYFACES-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Kieselhorst resolved MYFACES-4140.
-
   Resolution: Duplicate
 Assignee: Dennis Kieselhorst
Fix Version/s: 2.3.0

No longer reproducible, resolving as duplicate of MYFACES-4183.

> NullPointerException instead of InvalidViewIdException
> --
>
> Key: MYFACES-4140
> URL: https://issues.apache.org/jira/browse/MYFACES-4140
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 2.3.0-beta
>    Reporter: Dennis Kieselhorst
>    Assignee: Dennis Kieselhorst
>Priority: Minor
> Fix For: 2.3.0
>
>
> In case of an invalid viewId an NPE is thrown instead of 
> InvalidViewIdException. This is reproducible using tobago-example-demo 
> (NavigationTree /content/root-dummy.xhtml).
> {noformat}
> Caused by: java.lang.NullPointerException
> at 
> org.apache.myfaces.application.ViewHandlerImpl.getViewParameterList(ViewHandlerImpl.java:459)
> at 
> org.apache.myfaces.application.ViewHandlerImpl.getBookmarkableURL(ViewHandlerImpl.java:141)
> at 
> javax.faces.application.ViewHandlerWrapper.getBookmarkableURL(ViewHandlerWrapper.java:134)
> at 
> javax.faces.application.ViewHandlerWrapper.getBookmarkableURL(ViewHandlerWrapper.java:134)
> at 
> org.apache.myfaces.tobago.internal.util.RenderUtils.generateUrl(RenderUtils.java:229)
> at 
> org.apache.myfaces.tobago.internal.renderkit.renderer.CommandRendererBase.encodeBegin(CommandRendererBase.java:86)
> at 
> javax.faces.component.UIComponentBase.encodeBegin(UIComponentBase.java:597)
> at 
> javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:527)
> at 
> javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:551)
> at 
> org.apache.myfaces.tobago.internal.renderkit.renderer.TreeRenderer.encodeEnd(TreeRenderer.java:130)
> at 
> javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:675)
> at javax.faces.component.UIData.encodeEnd(UIData.java:1811)
> at 
> javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:555)
> at 
> javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:551)
> at javax.faces.render.Renderer.encodeChildren(Renderer.java:95)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (MYFACES-4002) Regression? - References to external entities not working with WebXmlParser

2018-01-05 Thread Dennis Kieselhorst (JIRA)

 [ 
https://issues.apache.org/jira/browse/MYFACES-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Kieselhorst updated MYFACES-4002:

Resolution: Not A Problem
Status: Resolved  (was: Patch Available)

[~ttimbul] closing for now, feel free to reopen with more information

> Regression? - References to external entities not working with WebXmlParser
> ---
>
> Key: MYFACES-4002
> URL: https://issues.apache.org/jira/browse/MYFACES-4002
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 2.2.4
> Environment: Myfaces 2.2.4, Tomcat 8.0.23, JDK 1.8_20, Windows 7 64bit
>Reporter: Thomas Timbul
> Attachments: patch1.txt
>
>
> I've searched JIRA and there are a few issues related to WebXmlParser, but 
> this seems almost like a recurrence of MYFACES-1754.
> My web.xml is split into multiple files, each declared as an XML entity 
> relative to the web.xml file itself:
> {code:xml}
> 
> {code}
> (As a side note I used to use 
> {{jndi:/localhost/WEB-INF/webxml/context-params.xml}}, but for some reason 
> Tomcat 8 claims that jndi is an invalid protocol).
> Using resource relative system identifiers Tomcat is now happy and the 
> context starts correctly. However, during its initialization MyFaces 
> re-parses the web.xml descriptor and resolves the entities incorrectly, 
> leading to failure with the message:
> {code}
> 2015-06-17 15:48:13.853 [localhost-startStop-1] ERROR 
> o.a.m.s.w.webxml.WebXmlParser - Unable to parse web.xml
> java.lang.IllegalArgumentException: The resource path 
> [file:///WEB-INF/webxml/context-params.xml] is not valid
> {code}
> The solution is to remove the file:// prefix before passing to the external 
> context to resolve, as in this patch:
> {code}
> Index: org/apache/myfaces/shared_impl/webapp/webxml/WebXmlParser.java
> ===
> --- WebXmlParser.java (revision ???)
> +++ WebXmlParser.java (working copy)
> @@ -138,6 +138,9 @@
>  
>  private InputSource createContextInputSource(String publicId, String 
> systemId)
>  {
> +if(systemId.startsWith("file:")) {
> +systemId = systemId.substring(7); // remove file://
> +}
>  InputStream inStream = _context.getResourceAsStream(systemId);
>  if (inStream == null)
>  {
> {code}
> Those three lines of code are based on other work by the MyFaces team 
> (org.apache.myfaces.config.impl.FacesConfigEntityResolver) and even if it 
> weren't is made available free of charge and free from license restrictions.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Re: [VOTE] Release of MyFaces Master POM version 17

2018-01-04 Thread Dennis Kieselhorst
+1


[jira] [Resolved] (TOBAGO-1836) Add Automatic-Module-Name MANIFEST entry for Java 9 compatibility

2017-12-31 Thread Dennis Kieselhorst (JIRA)

 [ 
https://issues.apache.org/jira/browse/TOBAGO-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Kieselhorst resolved TOBAGO-1836.

   Resolution: Fixed
Fix Version/s: 4.1.0

I've set this to org.apache.myfaces.tobago for tobago-core for now, but I'm 
open for other proposals...

> Add Automatic-Module-Name MANIFEST entry for Java 9 compatibility
> -
>
> Key: TOBAGO-1836
> URL: https://issues.apache.org/jira/browse/TOBAGO-1836
> Project: MyFaces Tobago
>  Issue Type: Improvement
>  Components: Build
>Affects Versions: 4.0.0
>    Reporter: Dennis Kieselhorst
>    Assignee: Dennis Kieselhorst
>Priority: Minor
> Fix For: 4.1.0
>
>
> http://blog.joda.org/2017/04/java-se-9-jpms-module-naming.html
> https://github.com/jodastephen/jpms-module-names
> Similar issues: CXF-7600, IO-551, LANG-1338, CODEC-242



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Re: [ANNOUNCE] Apache Tobago 4.0.0 Release

2017-12-11 Thread Dennis Kieselhorst
Hi Udo,

thanks for doing the release.

I've reposted the annoucement to annou...@apache.org, should be part at least 
for major releases.

Regards
Dennis


Re: MyFaces Master POM should be released

2017-12-07 Thread Dennis Kieselhorst

> I wish the master pom.xml should be released soon. It hasn't been
> released a long time (2015). The last release has apache pom 13 (2013)
> as parent, currently 18 (2016) is released.
> 
I fully agree, already suggested that a year ago.

Cheers
Dennis


Re: [VOTE] Release Tobago 4.0.0 2nd try

2017-12-07 Thread Dennis Kieselhorst
+1


[jira] [Commented] (TRINIDAD-2561) JSF Partial State Saving is not enabled

2017-12-03 Thread Dennis Kieselhorst (JIRA)

[ 
https://issues.apache.org/jira/browse/TRINIDAD-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275991#comment-16275991
 ] 

Dennis Kieselhorst commented on TRINIDAD-2561:
--

We welcome your pull requests: https://github.com/apache/myfaces-trinidad/

> JSF Partial State Saving is not enabled
> ---
>
> Key: TRINIDAD-2561
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2561
> Project: MyFaces Trinidad
>  Issue Type: Improvement
>  Components: Components
>Affects Versions: 2.1.1-core
>Reporter: Deepan
>
> JSF Partial State Saving needs to be enabled in Trinidad. Whenever the PSS is 
> turned on via web xml, Trinidad is printing a log stating that "Partial State 
> Saving won't work with Trinidad and has to be turned off". 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Re: [VOTE] Release Tobago 4.0.0

2017-12-02 Thread Dennis Kieselhorst
+1


Re: [Tobago] Preparation for the 4.0.0 release

2017-11-30 Thread Dennis Kieselhorst
> the email address in the ~/.gitconfig must be added to the account in
> github.org

Right, it works out of the box if you use the apache.org address. Looks better 
now.

Verified is another story, I don't think that's important, but you could of 
course sign your commits: 
https://help.github.com/articles/signing-commits-using-gpg/

Regards
Dennis


Re: [Tobago] Preparation for the 4.0.0 release

2017-11-29 Thread Dennis Kieselhorst
Hi!
> I plan to build the 4.0.0 of Tobago soon.
Great to hear that. Some things I've noticed while reviewing it today:

Udo and Henning, your commits are no longer linked to your GitHub
account (see https://github.com/apache/myfaces-tobago/commits/master) -
you should fix that.

https://builds.apache.org/view/M-R/view/MyFaces/job/Tobago%20Trunk%20integration-test/
last successful run was in August. Any idea why it is no longer working?

Cheers
Dennis


[tobago] (INFRA-13743) Allow deploy execution from builds.apache.org on *-vm.apache.org

2017-11-02 Thread Dennis Kieselhorst
Hi,

please check the comment from Daniel and participate in the discussion.

Cheers
Dennis


Re: Allow deploy execution from builds.apache.org on *-vm.apache.org


For updating the demo instance of the app on your VM, is polling the
public Jenkins artifacts a possible solution? Ideally instead of
installing a new plugin and connecting this VM, pulling in the newly
published artifacts from Jenkins should be possible.

Add Comment
 



Re: Increase checkstyle max line length?

2017-10-28 Thread Dennis Kieselhorst
definitely +1


Re: myfaces 2.3.x impl pom.xml update question

2017-09-30 Thread Dennis Kieselhorst
> Is there any reason to still have the import?

No of course not, good catch. I've fixed it.

Cheers
Dennis


Re: Need help with git

2017-09-25 Thread Dennis Kieselhorst
Hi Volker!

> first i tried github credentials on
> https://github.com/apache/myfaces-tobago. It looks like git on console
> did not work with the two factor auth.

You need to setup a personal access token for that: 
https://help.github.com/articles/creating-a-personal-access-token-for-the-command-line/


> Then i tried on https://gitbox.apache.org but also with github
> credentials which are not working.

You need to use your Apache credentials for that.


> BTW: I could not clone tobago 2.x from
> https://github.com/apache/myfaces-tobago/tree/tobago-2.0.x
> as described on http://myfaces.apache.org/tobago/getting-started.html.

Of course that's wrong, caused by find/ replace. I'll fix that.

Regards
Dennis


Re: Migrate all MyFaces projects to Git

2017-09-17 Thread Dennis Kieselhorst

> https://svn.apache.org/repos/asf/myfaces/trinidad-maven/ has not been
> migrated yet, I've requested a new repo for it.
Migration of trinidad-maven is finished:
https://github.com/apache/myfaces-trinidad-maven or
https://gitbox.apache.org/repos/asf?p=myfaces-trinidad-maven.git


Re: Migrate all MyFaces projects to Git

2017-09-17 Thread Dennis Kieselhorst
I finally managed to migrate trinidad.

Please use https://gitbox.apache.org/repos/asf/myfaces-trinidad.git or
https://github.com/apache/myfaces-trinidad from now on. SVN has been
marked as readonly.

https://svn.apache.org/repos/asf/myfaces/trinidad-maven/ has not been
migrated yet, I've requested a new repo for it.

Dennis


Re: [VOTE] Release Tobago 3.0.6

2017-09-16 Thread Dennis Kieselhorst
+1

Looks fine for me but please note that integration tests are failing in
3.0.x branch and also in master:
https://builds.apache.org/view/M-R/view/MyFaces/job/Tobago%20Trunk%20integration-test/


Re: Migrate all MyFaces projects to Git

2017-09-15 Thread Dennis Kieselhorst
On 2017-09-08 09:49, Dennis Kieselhorst <d...@apache.org> wrote:
> Trinidad will follow till Sunday.

Short update on Trinidad git migration.

I used the following command:
git svn clone --stdlayout --no-metadata --authors-file=authors.txt
https://svn.apache.org/repos/asf/myfaces/trinidad/ trinidad-tmp

This is running for almost a week now and consuming more and more memory
and cpu. I already used a cloud instance to speed this up.

I suggest to add --ignore-paths for all branches except trinidad-1.2.x,
trinidad-2.0.x and trinidad-2.1.x. All other branches haven't been
touched for at least three years. They will still be available in SVN in
readonly mode.

Any objections or other suggestions?

Regards
Dennis


[jira] [Commented] (MYFACES-4140) NullPointerException instead of InvalidViewIdException

2017-09-09 Thread Dennis Kieselhorst (JIRA)

[ 
https://issues.apache.org/jira/browse/MYFACES-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159837#comment-16159837
 ] 

Dennis Kieselhorst commented on MYFACES-4140:
-

Well I'm unsure how to fix it. Simply adding a null check and throw 
InvalidViewIdException will probably cause side effects in other cases. The 
code already contains a comment from [~lu4242] "Temporally reverted by TCK 
issues."

> NullPointerException instead of InvalidViewIdException
> --
>
> Key: MYFACES-4140
> URL: https://issues.apache.org/jira/browse/MYFACES-4140
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 2.3.0-beta
>    Reporter: Dennis Kieselhorst
>Priority: Minor
> Fix For: 2.3.0
>
>
> In case of an invalid viewId an NPE is thrown instead of 
> InvalidViewIdException. This is reproducible using tobago-example-demo 
> (NavigationTree /content/root-dummy.xhtml).
> {noformat}
> Caused by: java.lang.NullPointerException
> at 
> org.apache.myfaces.application.ViewHandlerImpl.getViewParameterList(ViewHandlerImpl.java:459)
> at 
> org.apache.myfaces.application.ViewHandlerImpl.getBookmarkableURL(ViewHandlerImpl.java:141)
> at 
> javax.faces.application.ViewHandlerWrapper.getBookmarkableURL(ViewHandlerWrapper.java:134)
> at 
> javax.faces.application.ViewHandlerWrapper.getBookmarkableURL(ViewHandlerWrapper.java:134)
> at 
> org.apache.myfaces.tobago.internal.util.RenderUtils.generateUrl(RenderUtils.java:229)
> at 
> org.apache.myfaces.tobago.internal.renderkit.renderer.CommandRendererBase.encodeBegin(CommandRendererBase.java:86)
> at 
> javax.faces.component.UIComponentBase.encodeBegin(UIComponentBase.java:597)
> at 
> javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:527)
> at 
> javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:551)
> at 
> org.apache.myfaces.tobago.internal.renderkit.renderer.TreeRenderer.encodeEnd(TreeRenderer.java:130)
> at 
> javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:675)
> at javax.faces.component.UIData.encodeEnd(UIData.java:1811)
> at 
> javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:555)
> at 
> javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:551)
> at javax.faces.render.Renderer.encodeChildren(Renderer.java:95)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Re: Migrate all MyFaces projects to Git

2017-09-08 Thread Dennis Kieselhorst
> Finally I have a working setup to migrate the subversion history to git.
> I already started with Tobago yesterday, Trinidad will follow till
Sunday.
>
> The result for Tobago is the following, will send another mail after
> having pushed this to Gitbox:

Tobago is finished: https://gitbox.apache.org/repos/asf/myfaces-tobago.git

Please no longer use svn for Tobago, I've requested to set it to readonly.

Cheers
Dennis



Re: Migrate all MyFaces projects to Git

2017-09-07 Thread Dennis Kieselhorst
Finally I have a working setup to migrate the subversion history to git.
I already started with Tobago yesterday, Trinidad will follow till Sunday.

The result for Tobago is the following, will send another mail after
having pushed this to Gitbox:
  origin/TOBAGO-1719
  origin/lofwyr
  origin/lofwyr@345942
  origin/lofwyr@394425
  origin/tags/1.0.9-RC1
  origin/tags/start
  origin/tags/start@345942
  origin/tags/start@345944
  origin/tags/start@394425
  origin/tags/tobago-1.0.10
  origin/tags/tobago-1.0.11
  origin/tags/tobago-1.0.12
  origin/tags/tobago-1.0.13
  origin/tags/tobago-1.0.14
  origin/tags/tobago-1.0.15
  origin/tags/tobago-1.0.16
  origin/tags/tobago-1.0.17
  origin/tags/tobago-1.0.18
  origin/tags/tobago-1.0.19
  origin/tags/tobago-1.0.20
  origin/tags/tobago-1.0.21
  origin/tags/tobago-1.0.22
  origin/tags/tobago-1.0.23
  origin/tags/tobago-1.0.24
  origin/tags/tobago-1.0.25
  origin/tags/tobago-1.0.26
  origin/tags/tobago-1.0.27
  origin/tags/tobago-1.0.28
  origin/tags/tobago-1.0.29
  origin/tags/tobago-1.0.30
  origin/tags/tobago-1.0.31
  origin/tags/tobago-1.0.32
  origin/tags/tobago-1.0.33
  origin/tags/tobago-1.0.34
  origin/tags/tobago-1.0.35
  origin/tags/tobago-1.0.36
  origin/tags/tobago-1.0.37
  origin/tags/tobago-1.0.38
  origin/tags/tobago-1.0.39
  origin/tags/tobago-1.0.40
  origin/tags/tobago-1.0.40-SNAPSHOT
  origin/tags/tobago-1.0.41
  origin/tags/tobago-1.0.42
  origin/tags/tobago-1.0.7
  origin/tags/tobago-1.0.8
  origin/tags/tobago-1.0.9
  origin/tags/tobago-1.0.9-RC1
  origin/tags/tobago-1.5.0
  origin/tags/tobago-1.5.0-alpha-1
  origin/tags/tobago-1.5.0-alpha-2
  origin/tags/tobago-1.5.0-beta-1
  origin/tags/tobago-1.5.0-beta-2
  origin/tags/tobago-1.5.1
  origin/tags/tobago-1.5.10
  origin/tags/tobago-1.5.11
  origin/tags/tobago-1.5.12
  origin/tags/tobago-1.5.13
  origin/tags/tobago-1.5.2
  origin/tags/tobago-1.5.3
  origin/tags/tobago-1.5.4
  origin/tags/tobago-1.5.5
  origin/tags/tobago-1.5.6
  origin/tags/tobago-1.5.7
  origin/tags/tobago-1.5.8
  origin/tags/tobago-1.5.9
  origin/tags/tobago-1.6.0-beta-1
  origin/tags/tobago-1.6.0-beta-2
  origin/tags/tobago-2.0.0
  origin/tags/tobago-2.0.0-alpha-1
  origin/tags/tobago-2.0.0-alpha-2
  origin/tags/tobago-2.0.0-alpha-3
  origin/tags/tobago-2.0.0-beta-1
  origin/tags/tobago-2.0.0-beta-2
  origin/tags/tobago-2.0.0-beta-3
  origin/tags/tobago-2.0.0-beta-4
  origin/tags/tobago-2.0.1
  origin/tags/tobago-2.0.10
  origin/tags/tobago-2.0.2
  origin/tags/tobago-2.0.3
  origin/tags/tobago-2.0.4
  origin/tags/tobago-2.0.5
  origin/tags/tobago-2.0.6
  origin/tags/tobago-2.0.7
  origin/tags/tobago-2.0.8
  origin/tags/tobago-2.0.8.TEST
  origin/tags/tobago-2.0.9
  origin/tags/tobago-2.0.9.TEST
  origin/tags/tobago-2.1.0
  origin/tags/tobago-3.0.0
  origin/tags/tobago-3.0.0-alpha-1
  origin/tags/tobago-3.0.0-alpha-2
  origin/tags/tobago-3.0.0-alpha-3
  origin/tags/tobago-3.0.0-alpha-4
  origin/tags/tobago-3.0.0-alpha-5
  origin/tags/tobago-3.0.0-alpha-6
  origin/tags/tobago-3.0.0-alpha-7
  origin/tags/tobago-3.0.0-beta-1
  origin/tags/tobago-3.0.1
  origin/tags/tobago-3.0.2
  origin/tags/tobago-3.0.3
  origin/tags/tobago-3.0.4
  origin/tags/tobago-3.0.5
  origin/tags/tobago_1_0_0
  origin/tags/tobago_1_0_0@346356
  origin/tags/tobago_1_0_0@394425
  origin/tags/tobago_1_0_1
  origin/tags/tobago_1_0_1@346360
  origin/tags/tobago_1_0_1@394425
  origin/tags/tobago_1_0_2
  origin/tags/tobago_1_0_2@346372
  origin/tags/tobago_1_0_2@394425
  origin/tags/tobago_1_0_3
  origin/tags/tobago_1_0_3@346511
  origin/tags/tobago_1_0_3@394425
  origin/tags/tobago_1_0_4
  origin/tags/tobago_1_0_4@346520
  origin/tags/tobago_1_0_4@394425
  origin/tags/tobago_1_0_5
  origin/tags/tobago_1_0_5@347230
  origin/tags/tobago_1_0_5@394425
  origin/tags/tobago_1_0_6
  origin/tags/tobago_1_0_6@347498
  origin/tags/tobago_1_0_6@394425
  origin/tags/tobago_before_vb_for_all
  origin/tags/tobago_before_vb_for_all@346141
  origin/tags/tobago_before_vb_for_all@394425
  origin/tobago-1.0.x
  origin/tobago-1.1.x-progress-layout
  origin/tobago-1.5.x
  origin/tobago-1.6.x-old-apt-generator
  origin/tobago-1.6.x-old-facelets
  origin/tobago-2.0.x
  origin/tobago-3.0.x
  origin/tobago-3.0.x-before-bootstrap-for-all-renderers
  origin/tobago-3.0.x-develop-standard-ajax
  origin/tobago-tree-table
  origin/trunk
  origin/trunk@394425

Regards
Dennis


[jira] [Commented] (MYFACES-4135) Use Java8 instead of commons

2017-09-04 Thread Dennis Kieselhorst (JIRA)

[ 
https://issues.apache.org/jira/browse/MYFACES-4135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152667#comment-16152667
 ] 

Dennis Kieselhorst commented on MYFACES-4135:
-

I think we should keep it. The beanutils library is small and mature.

> Use Java8 instead of commons
> 
>
> Key: MYFACES-4135
> URL: https://issues.apache.org/jira/browse/MYFACES-4135
> Project: MyFaces Core
>  Issue Type: Improvement
>Reporter: Thomas Andraschko
>Assignee: Thomas Andraschko
>Priority: Minor
> Fix For: 2.3.0
>
>
> e.g. Base64 - will check other used parts
> Collections:
> * EmptyIterator (/)
> * LRUMap (/)
> * CollectionUtils.filter (/)
> * Predicate (/)
> Coded: (/)
> * Hex (Could be replaced by javax/xml/bind/DatatypeConverter) (/)
> * DecoderException (/)
> * Base64 (/)
> Digester:
> * Digester (x)
> BeanUtils:
> * BeanUtils (x)
> * PropertyUtils (x)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (MYFACES-4135) Use Java8 instead of commons

2017-08-28 Thread Dennis Kieselhorst (JIRA)

[ 
https://issues.apache.org/jira/browse/MYFACES-4135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144239#comment-16144239
 ] 

Dennis Kieselhorst commented on MYFACES-4135:
-

Ok, just fixed the log message and simplified the code.

> Use Java8 instead of commons
> 
>
> Key: MYFACES-4135
> URL: https://issues.apache.org/jira/browse/MYFACES-4135
> Project: MyFaces Core
>  Issue Type: Improvement
>Reporter: Thomas Andraschko
>Assignee: Thomas Andraschko
>Priority: Minor
> Fix For: 2.3.0
>
>
> e.g. Base64 - will check other used parts
> Collections:
> * EmptyIterator (/)
> * LRUMap (/)
> * CollectionUtils.filter (/)
> * Predicate (/)
> Coded: (/)
> * Hex (Could be replaced by javax/xml/bind/DatatypeConverter) (/)
> * DecoderException (/)
> * Base64 (/)
> Digester:
> * Digester (x)
> BeanUtils:
> * BeanUtils (x)
> * PropertyUtils (x)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (MYFACES-4135) Use Java8 instead of commons

2017-08-26 Thread Dennis Kieselhorst (JIRA)

[ 
https://issues.apache.org/jira/browse/MYFACES-4135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142663#comment-16142663
 ] 

Dennis Kieselhorst commented on MYFACES-4135:
-

I would use java.util.function.Predicate.

> Use Java8 instead of commons
> 
>
> Key: MYFACES-4135
> URL: https://issues.apache.org/jira/browse/MYFACES-4135
> Project: MyFaces Core
>  Issue Type: Improvement
>Reporter: Thomas Andraschko
>Assignee: Thomas Andraschko
>Priority: Minor
> Fix For: 2.3.0
>
>
> e.g. Base64 - will check other used parts
> Collections:
> * EmptyIterator (/)
> * LRUMap (/)
> * CollectionUtils.filter
> * Predicate
> Coded: (/)
> * Hex (Could be replaced by javax/xml/bind/DatatypeConverter) (/)
> * DecoderException (/)
> * Base64 (/)
> Digester:
> * Digester (x)
> BeanUtils:
> * BeanUtils (x)
> * PropertyUtils (x)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (MYFACES-4135) Use Java8 instead of commons

2017-08-25 Thread Dennis Kieselhorst (JIRA)

[ 
https://issues.apache.org/jira/browse/MYFACES-4135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141320#comment-16141320
 ] 

Dennis Kieselhorst commented on MYFACES-4135:
-

How to migrate the org.apache.myfaces.EL_RESOLVER_PREDICATE stuff? Change it to 
java.util.function.Predicate and add a migration warning?

> Use Java8 instead of commons
> 
>
> Key: MYFACES-4135
> URL: https://issues.apache.org/jira/browse/MYFACES-4135
> Project: MyFaces Core
>  Issue Type: Bug
>Reporter: Thomas Andraschko
>Assignee: Thomas Andraschko
>Priority: Minor
> Fix For: 2.3.0
>
>
> e.g. Base64 - will check other used parts
> Collections:
> * EmptyIterator (/)
> * LRUMap
> * CollectionUtils.filter
> * Predicate
> Coded: (/)
> * Hex (Could be replaced by javax/xml/bind/DatatypeConverter) (/)
> * DecoderException (/)
> * Base64 (/)
> Digester:
> * Digester (x)
> BeanUtils:
> * BeanUtils (x)
> * PropertyUtils (x)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (MYFACES-4135) Use Java8 instead of commons

2017-08-25 Thread Dennis Kieselhorst (JIRA)

[ 
https://issues.apache.org/jira/browse/MYFACES-4135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141317#comment-16141317
 ] 

Dennis Kieselhorst commented on MYFACES-4135:
-

[~tandraschko] in the comment you mentioned accessOrder=true but actually it 
wasn't set. I changed it to keep the LRUMap behavior and added a test.

> Use Java8 instead of commons
> 
>
> Key: MYFACES-4135
> URL: https://issues.apache.org/jira/browse/MYFACES-4135
> Project: MyFaces Core
>  Issue Type: Bug
>Reporter: Thomas Andraschko
>Assignee: Thomas Andraschko
>Priority: Minor
> Fix For: 2.3.0
>
>
> e.g. Base64 - will check other used parts
> Collections:
> * EmptyIterator (/)
> * LRUMap
> * CollectionUtils.filter
> * Predicate
> Coded: (/)
> * Hex (Could be replaced by javax/xml/bind/DatatypeConverter) (/)
> * DecoderException (/)
> * Base64 (/)
> Digester:
> * Digester (x)
> BeanUtils:
> * BeanUtils (x)
> * PropertyUtils (x)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (MYFACES-4140) NullPointerException instead of InvalidViewIdException

2017-08-23 Thread Dennis Kieselhorst (JIRA)
Dennis Kieselhorst created MYFACES-4140:
---

 Summary: NullPointerException instead of InvalidViewIdException
 Key: MYFACES-4140
 URL: https://issues.apache.org/jira/browse/MYFACES-4140
 Project: MyFaces Core
  Issue Type: Bug
Affects Versions: 2.3.0-beta
Reporter: Dennis Kieselhorst
Priority: Minor


In case of an invalid viewId an NPE is thrown instead of 
InvalidViewIdException. This is reproducible using tobago-example-demo 
(NavigationTree /content/root-dummy.xhtml).

{noformat}
Caused by: java.lang.NullPointerException
at 
org.apache.myfaces.application.ViewHandlerImpl.getViewParameterList(ViewHandlerImpl.java:459)
at 
org.apache.myfaces.application.ViewHandlerImpl.getBookmarkableURL(ViewHandlerImpl.java:141)
at 
javax.faces.application.ViewHandlerWrapper.getBookmarkableURL(ViewHandlerWrapper.java:134)
at 
javax.faces.application.ViewHandlerWrapper.getBookmarkableURL(ViewHandlerWrapper.java:134)
at 
org.apache.myfaces.tobago.internal.util.RenderUtils.generateUrl(RenderUtils.java:229)
at 
org.apache.myfaces.tobago.internal.renderkit.renderer.CommandRendererBase.encodeBegin(CommandRendererBase.java:86)
at 
javax.faces.component.UIComponentBase.encodeBegin(UIComponentBase.java:597)
at 
javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:527)
at 
javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:551)
at 
org.apache.myfaces.tobago.internal.renderkit.renderer.TreeRenderer.encodeEnd(TreeRenderer.java:130)
at 
javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:675)
at javax.faces.component.UIData.encodeEnd(UIData.java:1811)
at 
javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:555)
at 
javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:551)
at javax.faces.render.Renderer.encodeChildren(Renderer.java:95)
{noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (MYFACES-4134) Update to commons-collections 4

2017-08-23 Thread Dennis Kieselhorst (JIRA)

[ 
https://issues.apache.org/jira/browse/MYFACES-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138407#comment-16138407
 ] 

Dennis Kieselhorst commented on MYFACES-4134:
-

Ok great I'll close this one as duplicate.

> Update to commons-collections 4
> ---
>
> Key: MYFACES-4134
> URL: https://issues.apache.org/jira/browse/MYFACES-4134
> Project: MyFaces Core
>  Issue Type: Improvement
>Affects Versions: 2.3.0-beta
>    Reporter: Dennis Kieselhorst
>Priority: Minor
> Fix For: 2.3.0
>
>
> Should we update to commons-collection 4 for 2.3.0? If nobody objects, I can 
> do the changes...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (TRINIDAD-2559) UNZIP_STATE_FAILED Exception

2017-08-21 Thread Dennis Kieselhorst (JIRA)

[ 
https://issues.apache.org/jira/browse/TRINIDAD-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135518#comment-16135518
 ] 

Dennis Kieselhorst commented on TRINIDAD-2559:
--

Please tell us more about the page structure, I assume it has many components. 
Ideally you provide a testcase and attach it to this issue.

For the meantime you can set COMPRESS_VIEW_STATE to false to avoid the issue.

> UNZIP_STATE_FAILED Exception
> 
>
> Key: TRINIDAD-2559
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2559
> Project: MyFaces Trinidad
>  Issue Type: Bug
>Affects Versions: 2.1.1-core
> Environment: MyFaces 2.1.17 
> OS: Any
> WebSphere 8.5.5
> Java 7
>Reporter: Deepan
>Priority: Blocker
> Attachments: UNZIP_Exception.txt
>
>
> One particular page in our application is sporadically not responding and we 
> are getting "*UNZIP_STATE_FAILED*" exception. I've attached the exception 
> trace. 
> Please help us to resolve this issue.
> *+Web.xml details:+*
> * STATE_SAVING_METHOD - Client
> * CLIENT_STATE_METHOD - Token
> * CACHE_VIEW_ROOT - True
> * CLIENT_STATE_MAX_TOKENS - 100
> * COMPRESS_VIEW_STATE - True



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (MYFACES-4134) Update to commons-collections 4

2017-08-17 Thread Dennis Kieselhorst (JIRA)

[ 
https://issues.apache.org/jira/browse/MYFACES-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130193#comment-16130193
 ] 

Dennis Kieselhorst commented on MYFACES-4134:
-

Only four classes are in use:
* org.apache.commons.collections.map.LRUMap
* org.apache.commons.collections.Predicate
* org.apache.commons.collections.CollectionUtils.filter
* org.apache.commons.collections.iterators.EmptyIterator

I'm not aware of a LRUMap in Java 8 but this could be implemented based on 
LinkedHashMap.

What I just noticed: If org.apache.myfaces.EL_RESOLVER_PREDICATE is in use, 
users will have to migrate their Predicates to commons-collections4 too.

> Update to commons-collections 4
> ---
>
> Key: MYFACES-4134
> URL: https://issues.apache.org/jira/browse/MYFACES-4134
> Project: MyFaces Core
>  Issue Type: Improvement
>Affects Versions: 2.3.0-beta
>    Reporter: Dennis Kieselhorst
>Priority: Minor
> Fix For: 2.3.0
>
>
> Should we update to commons-collection 4 for 2.3.0? If nobody objects, I can 
> do the changes...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (MYFACES-4134) Update to commons-collections 4

2017-08-16 Thread Dennis Kieselhorst (JIRA)
Dennis Kieselhorst created MYFACES-4134:
---

 Summary: Update to commons-collections 4
 Key: MYFACES-4134
 URL: https://issues.apache.org/jira/browse/MYFACES-4134
 Project: MyFaces Core
  Issue Type: Improvement
Affects Versions: 2.3.0-beta
Reporter: Dennis Kieselhorst
Priority: Minor


Should we update to commons-collection 4 for 2.3.0? If nobody objects, I can do 
the changes...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (TOBAGO-1781) Update to commons-lang 3

2017-08-16 Thread Dennis Kieselhorst (JIRA)

 [ 
https://issues.apache.org/jira/browse/TOBAGO-1781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Kieselhorst resolved TOBAGO-1781.

Resolution: Fixed

> Update to commons-lang 3
> 
>
> Key: TOBAGO-1781
> URL: https://issues.apache.org/jira/browse/TOBAGO-1781
> Project: MyFaces Tobago
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 3.0.5
>    Reporter: Dennis Kieselhorst
>    Assignee: Dennis Kieselhorst
>Priority: Minor
> Fix For: 4.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (TOBAGO-1781) Update to commons-lang 3

2017-08-16 Thread Dennis Kieselhorst (JIRA)
Dennis Kieselhorst created TOBAGO-1781:
--

 Summary: Update to commons-lang 3
 Key: TOBAGO-1781
 URL: https://issues.apache.org/jira/browse/TOBAGO-1781
 Project: MyFaces Tobago
  Issue Type: Improvement
  Components: Core
Affects Versions: 3.0.5
Reporter: Dennis Kieselhorst
Assignee: Dennis Kieselhorst
Priority: Minor






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (TOBAGO-1780) Update to commons-collections 4

2017-08-16 Thread Dennis Kieselhorst (JIRA)

 [ 
https://issues.apache.org/jira/browse/TOBAGO-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Kieselhorst resolved TOBAGO-1780.

Resolution: Fixed

> Update to commons-collections 4
> ---
>
> Key: TOBAGO-1780
> URL: https://issues.apache.org/jira/browse/TOBAGO-1780
> Project: MyFaces Tobago
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 3.0.5
>    Reporter: Dennis Kieselhorst
>    Assignee: Dennis Kieselhorst
>Priority: Minor
> Fix For: 4.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (TOBAGO-1780) Update to commons-collections 4

2017-08-16 Thread Dennis Kieselhorst (JIRA)
Dennis Kieselhorst created TOBAGO-1780:
--

 Summary: Update to commons-collections 4
 Key: TOBAGO-1780
 URL: https://issues.apache.org/jira/browse/TOBAGO-1780
 Project: MyFaces Tobago
  Issue Type: Improvement
  Components: Core
Affects Versions: 3.0.5
Reporter: Dennis Kieselhorst
Assignee: Dennis Kieselhorst
Priority: Minor






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


  1   2   3   4   >