Result ( Was: [VOTE] Release of MyFaces Core 2.2.3 )
Hi Thanks to all people who vote We have 6 +1 Werner Punz Michael Kurz Martin Koci Grant Smith Mike Kienenberger Leonardo Uribe so we can continue with the necessary steps to release MyFaces Core 2.2.3 regards, Leonardo Uribe
[VOTE] Release of MyFaces Core 2.2.3
Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following parts: 1. Maven artifact group org.apache.myfaces.shared v4.2.2 [1] 2. Maven artifact group org.apache.myfaces.core v2.2.3 [1] The artifacts were deployed on nexus repo [1] and to my private Apache account [3] for binary and source packages. The release notes could be found at [4]. Also the clirr test does not show binary incompatibilities with myfaces-api. Please take a look at the 2.2.3 artifacts and vote! Please note: This vote is majority approval with a minimum of three +1 votes (see [3]). [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Leonardo Uribe [1] https://repository.apache.org/content/repositories/orgapachemyfaces-1021/org/apache/myfaces/ https://repository.apache.org/content/repositories/orgapachemyfaces-1020/org/apache/myfaces/ [2] http://www.apache.org/foundation/voting.html#ReleaseVotes [3] http://people.apache.org/~lu4242/myfaces223binsrc [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600version=12326543
Re: [VOTE] Release of MyFaces Core 2.2.3
+1 2014-04-22 12:20 GMT+02:00 Leonardo Uribe lu4...@gmail.com: Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following parts: 1. Maven artifact group org.apache.myfaces.shared v4.2.2 [1] 2. Maven artifact group org.apache.myfaces.core v2.2.3 [1] The artifacts were deployed on nexus repo [1] and to my private Apache account [3] for binary and source packages. The release notes could be found at [4]. Also the clirr test does not show binary incompatibilities with myfaces-api. Please take a look at the 2.2.3 artifacts and vote! Please note: This vote is majority approval with a minimum of three +1 votes (see [3]). [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Leonardo Uribe [1] https://repository.apache.org/content/repositories/orgapachemyfaces-1021/org/apache/myfaces/ https://repository.apache.org/content/repositories/orgapachemyfaces-1020/org/apache/myfaces/ [2] http://www.apache.org/foundation/voting.html#ReleaseVotes [3] http://people.apache.org/~lu4242/myfaces223binsrc [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600version=12326543
Re: [VOTE] Release of MyFaces Core 2.2.3
- signatures and checksums match
- source builds
- apache rat passes
+1
Below are the linux commands I used to verify the release of the
myfaces-core-assembly-2.2.3-src files:
=
# check checksums
find . -name '*.md5' -exec cat {} \; -printf ' %f\n' | sed
's|\.md5$||' | md5sum -c
find . -name '*.sha1' -exec cat {} \; -printf ' %f\n' | sed
's|\.sha1$||' | sha1sum -c
# check signatures
wget http://www.apache.org/dist/myfaces/KEYS
gpg --import KEYS
find . -name '*.asc' -exec gpg --verify {} \;
# verify tar.gz and zip sources are identical
mkdir src
cd src
tar xvf ../myfaces-core-assembly-2.2.3-src.tar.gz
mv myfaces-core-2.2.3-src/ myfaces-core-2.2.3-src-tar-gz
unzip ../myfaces-core-assembly-2.2.3-src.zip
# should be no output
diff -rq myfaces-core-2.2.3-src*
# should be are identical output
diff -srq myfaces-core-2.2.3-src*
# build source
cd myfaces-core-2.2.3-src/src
find \( -name '*.jar' -o -name '*.zip' \) -exec unzip -n {} \;
cd myfaces-core-module-2.2.3/
mvn install
mvn apache-rat:check
# To check for all errors, if more than one project is affected
# mvn apache-rat:check -Drat.numUnapprovedLicenses=
# To see details of rat failure, including location of rat report
# mvn -e -X apache-rat:check
On Tue, Apr 22, 2014 at 6:20 AM, Leonardo Uribe lu4...@gmail.com wrote:
+1
2014-04-22 12:20 GMT+02:00 Leonardo Uribe lu4...@gmail.com:
Hi,
I was running the needed tasks to get the 2.2.3 release of Apache
MyFaces core out.
The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip).
Please note that this vote concerns all of the following parts:
1. Maven artifact group org.apache.myfaces.shared v4.2.2 [1]
2. Maven artifact group org.apache.myfaces.core v2.2.3 [1]
The artifacts were deployed on nexus repo [1] and to my private
Apache account [3] for binary and source packages.
The release notes could be found at [4].
Also the clirr test does not show binary incompatibilities with myfaces-api.
Please take a look at the 2.2.3 artifacts and vote!
Please note: This vote is majority approval with a minimum of three
+1 votes (see [3]).
[ ] +1 for community members who have reviewed the bits
[ ] +0
[ ] -1 for fatal flaws that should cause these bits not to be released,
and why..
Thanks,
Leonardo Uribe
[1]
https://repository.apache.org/content/repositories/orgapachemyfaces-1021/org/apache/myfaces/
https://repository.apache.org/content/repositories/orgapachemyfaces-1020/org/apache/myfaces/
[2] http://www.apache.org/foundation/voting.html#ReleaseVotes
[3] http://people.apache.org/~lu4242/myfaces223binsrc
[4]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600version=12326543
Re: [VOTE] Release of MyFaces Core 2.2.3
+1
On Tue, Apr 22, 2014 at 5:48 AM, Mike Kienenberger mkien...@gmail.comwrote:
- signatures and checksums match
- source builds
- apache rat passes
+1
Below are the linux commands I used to verify the release of the
myfaces-core-assembly-2.2.3-src files:
=
# check checksums
find . -name '*.md5' -exec cat {} \; -printf ' %f\n' | sed
's|\.md5$||' | md5sum -c
find . -name '*.sha1' -exec cat {} \; -printf ' %f\n' | sed
's|\.sha1$||' | sha1sum -c
# check signatures
wget http://www.apache.org/dist/myfaces/KEYS
gpg --import KEYS
find . -name '*.asc' -exec gpg --verify {} \;
# verify tar.gz and zip sources are identical
mkdir src
cd src
tar xvf ../myfaces-core-assembly-2.2.3-src.tar.gz
mv myfaces-core-2.2.3-src/ myfaces-core-2.2.3-src-tar-gz
unzip ../myfaces-core-assembly-2.2.3-src.zip
# should be no output
diff -rq myfaces-core-2.2.3-src*
# should be are identical output
diff -srq myfaces-core-2.2.3-src*
# build source
cd myfaces-core-2.2.3-src/src
find \( -name '*.jar' -o -name '*.zip' \) -exec unzip -n {} \;
cd myfaces-core-module-2.2.3/
mvn install
mvn apache-rat:check
# To check for all errors, if more than one project is affected
# mvn apache-rat:check -Drat.numUnapprovedLicenses=
# To see details of rat failure, including location of rat report
# mvn -e -X apache-rat:check
On Tue, Apr 22, 2014 at 6:20 AM, Leonardo Uribe lu4...@gmail.com wrote:
+1
2014-04-22 12:20 GMT+02:00 Leonardo Uribe lu4...@gmail.com:
Hi,
I was running the needed tasks to get the 2.2.3 release of Apache
MyFaces core out.
The artifacts passed the TCK test of Feb 2013
(jsftck-2.2_26-Feb-2013.zip).
Please note that this vote concerns all of the following parts:
1. Maven artifact group org.apache.myfaces.shared v4.2.2 [1]
2. Maven artifact group org.apache.myfaces.core v2.2.3 [1]
The artifacts were deployed on nexus repo [1] and to my private
Apache account [3] for binary and source packages.
The release notes could be found at [4].
Also the clirr test does not show binary incompatibilities with
myfaces-api.
Please take a look at the 2.2.3 artifacts and vote!
Please note: This vote is majority approval with a minimum of three
+1 votes (see [3]).
[ ] +1 for community members who have reviewed the bits
[ ] +0
[ ] -1 for fatal flaws that should cause these bits not to be released,
and why..
Thanks,
Leonardo Uribe
[1]
https://repository.apache.org/content/repositories/orgapachemyfaces-1021/org/apache/myfaces/
https://repository.apache.org/content/repositories/orgapachemyfaces-1020/org/apache/myfaces/
[2] http://www.apache.org/foundation/voting.html#ReleaseVotes
[3] http://people.apache.org/~lu4242/myfaces223binsrc
[4]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600version=12326543
--
Grant Smith - V.P. Information Technology
Marathon Computer Systems, LLC.
Re: [VOTE] Release of MyFaces Core 2.2.3
+1 2014-04-22 12:20 GMT+02:00 Leonardo Uribe lu4...@gmail.com: Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following parts: 1. Maven artifact group org.apache.myfaces.shared v4.2.2 [1] 2. Maven artifact group org.apache.myfaces.core v2.2.3 [1] The artifacts were deployed on nexus repo [1] and to my private Apache account [3] for binary and source packages. The release notes could be found at [4]. Also the clirr test does not show binary incompatibilities with myfaces-api. Please take a look at the 2.2.3 artifacts and vote! Please note: This vote is majority approval with a minimum of three +1 votes (see [3]). [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Leonardo Uribe [1] https://repository.apache.org/content/repositories/orgapachemyfaces-1021/org/apache/myfaces/ https://repository.apache.org/content/repositories/orgapachemyfaces-1020/org/apache/myfaces/ [2] http://www.apache.org/foundation/voting.html#ReleaseVotes [3] http://people.apache.org/~lu4242/myfaces223binsrc [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600version=12326543
Re: [VOTE] Release of MyFaces Core 2.2.3
+1 Am 22.04.2014 um 18:16 schrieb Martin Kočí martin.kocicak.k...@gmail.com: +1 2014-04-22 12:20 GMT+02:00 Leonardo Uribe lu4...@gmail.com: Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following parts: 1. Maven artifact group org.apache.myfaces.shared v4.2.2 [1] 2. Maven artifact group org.apache.myfaces.core v2.2.3 [1] The artifacts were deployed on nexus repo [1] and to my private Apache account [3] for binary and source packages. The release notes could be found at [4]. Also the clirr test does not show binary incompatibilities with myfaces-api. Please take a look at the 2.2.3 artifacts and vote! Please note: This vote is majority approval with a minimum of three +1 votes (see [3]). [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Leonardo Uribe [1] https://repository.apache.org/content/repositories/orgapachemyfaces-1021/org/apache/myfaces/ https://repository.apache.org/content/repositories/orgapachemyfaces-1020/org/apache/myfaces/ [2] http://www.apache.org/foundation/voting.html#ReleaseVotes [3] http://people.apache.org/~lu4242/myfaces223binsrc [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600version=12326543
Re: [VOTE] Release of MyFaces Core 2.2.3
+1 Werner Am 22.04.14 12:20, schrieb Leonardo Uribe: Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following parts: 1. Maven artifact group org.apache.myfaces.shared v4.2.2 [1] 2. Maven artifact group org.apache.myfaces.core v2.2.3 [1] The artifacts were deployed on nexus repo [1] and to my private Apache account [3] for binary and source packages. The release notes could be found at [4]. Also the clirr test does not show binary incompatibilities with myfaces-api. Please take a look at the 2.2.3 artifacts and vote! Please note: This vote is majority approval with a minimum of three +1 votes (see [3]). [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Leonardo Uribe [1] https://repository.apache.org/content/repositories/orgapachemyfaces-1021/org/apache/myfaces/ https://repository.apache.org/content/repositories/orgapachemyfaces-1020/org/apache/myfaces/ [2] http://www.apache.org/foundation/voting.html#ReleaseVotes [3] http://people.apache.org/~lu4242/myfaces223binsrc [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600version=12326543
Re: [VOTE] Release of MyFaces Core 2.2.3
+1 LieGrue, strub On Wednesday, 16 April 2014, 19:18, Leonardo Uribe lu4...@gmail.com wrote: +1 2014-04-16 19:17 GMT+02:00 Leonardo Uribe lu4...@gmail.com: Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following parts: 1. Maven artifact group org.apache.myfaces.shared v4.2.2 [1] 2. Maven artifact group org.apache.myfaces.core v2.2.3 [1] The artifacts were deployed on nexus repo [1] and to my private Apache account [3] for binary and source packages. The release notes could be found at [4]. Also the clirr test does not show binary incompatibilities with myfaces-api. Please take a look at the 2.2.3 artifacts and vote! Please note: This vote is majority approval with a minimum of three +1 votes (see [3]). [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Leonardo Uribe [1] https://repository.apache.org/content/repositories/orgapachemyfaces-1018/org/apache/myfaces/ https://repository.apache.org/content/repositories/orgapachemyfaces-1017/org/apache/myfaces/ [2] http://www.apache.org/foundation/voting.html#ReleaseVotes [3] http://people.apache.org/~lu4242/myfaces223binsrc [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600version=12326543
Re: [VOTE] Release of MyFaces Core 2.2.3
Sorry. -1 Rat shows that we have several non-trivial files that are missing headers: impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_1.xhtml impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_3.xhtml impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_4.xhtml impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_2.xhtml impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_7.xhtml impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/testComposite/dynComp_1.xhtml The rest of these files are not blockers, but are also showing up in rat, which makes evaluating a release take much longer. Can we add headers to them? We could also add them to the exclude list, but if the contents changed to be non-trivial, then we'd need a license anyway, so it's safer to add the license, and each of these file formats supports license comments. impl/src/test/resources/org/apache/myfaces/application/contracts/contracts/red/mylib/myjs.js impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/test1.js impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/test.js impl/src/test/resources/META-INF/contracts/yellow/javax.faces.contract.xml impl/src/test/resources/META-INF/contracts/yellow/mylib/myjs.js impl/src/test/resources/META-INF/contracts/blue/javax.faces.contract.xml impl/src/test/resources/META-INF/contracts/blue/mylib/myjs.js These files needs to be put in the rat exclusions section as I'm fairly certain they do not support having a license in them, and they are trivial. impl/src/main/resources/META-INF/services/javax.enterprise.inject.spi.Extension impl/src/main/resources/META-INF/services/org.apache.myfaces.spi.InjectionProvider On Wed, Apr 16, 2014 at 1:17 PM, Leonardo Uribe lu4...@gmail.com wrote: Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following parts: 1. Maven artifact group org.apache.myfaces.shared v4.2.2 [1] 2. Maven artifact group org.apache.myfaces.core v2.2.3 [1] The artifacts were deployed on nexus repo [1] and to my private Apache account [3] for binary and source packages. The release notes could be found at [4]. Also the clirr test does not show binary incompatibilities with myfaces-api. Please take a look at the 2.2.3 artifacts and vote! Please note: This vote is majority approval with a minimum of three +1 votes (see [3]). [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Leonardo Uribe [1] https://repository.apache.org/content/repositories/orgapachemyfaces-1018/org/apache/myfaces/ https://repository.apache.org/content/repositories/orgapachemyfaces-1017/org/apache/myfaces/ [2] http://www.apache.org/foundation/voting.html#ReleaseVotes [3] http://people.apache.org/~lu4242/myfaces223binsrc [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600version=12326543
Re: [VOTE] Release of MyFaces Core 2.2.3
Hi Those files are used for test only. Is it so important to block a quick fix release? Regards Leonardo On Apr 17, 2014 11:36 AM, Mike Kienenberger mkien...@gmail.com wrote: Sorry. -1 Rat shows that we have several non-trivial files that are missing headers: impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_1.xhtml impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_3.xhtml impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_4.xhtml impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_2.xhtml impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_7.xhtml impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/testComposite/dynComp_1.xhtml The rest of these files are not blockers, but are also showing up in rat, which makes evaluating a release take much longer. Can we add headers to them? We could also add them to the exclude list, but if the contents changed to be non-trivial, then we'd need a license anyway, so it's safer to add the license, and each of these file formats supports license comments. impl/src/test/resources/org/apache/myfaces/application/contracts/contracts/red/mylib/myjs.js impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/test1.js impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/test.js impl/src/test/resources/META-INF/contracts/yellow/javax.faces.contract.xml impl/src/test/resources/META-INF/contracts/yellow/mylib/myjs.js impl/src/test/resources/META-INF/contracts/blue/javax.faces.contract.xml impl/src/test/resources/META-INF/contracts/blue/mylib/myjs.js These files needs to be put in the rat exclusions section as I'm fairly certain they do not support having a license in them, and they are trivial. impl/src/main/resources/META-INF/services/javax.enterprise.inject.spi.Extension impl/src/main/resources/META-INF/services/org.apache.myfaces.spi.InjectionProvider On Wed, Apr 16, 2014 at 1:17 PM, Leonardo Uribe lu4...@gmail.com wrote: Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following parts: 1. Maven artifact group org.apache.myfaces.shared v4.2.2 [1] 2. Maven artifact group org.apache.myfaces.core v2.2.3 [1] The artifacts were deployed on nexus repo [1] and to my private Apache account [3] for binary and source packages. The release notes could be found at [4]. Also the clirr test does not show binary incompatibilities with myfaces-api. Please take a look at the 2.2.3 artifacts and vote! Please note: This vote is majority approval with a minimum of three +1 votes (see [3]). [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Leonardo Uribe [1] https://repository.apache.org/content/repositories/orgapachemyfaces-1018/org/apache/myfaces/ https://repository.apache.org/content/repositories/orgapachemyfaces-1017/org/apache/myfaces/ [2] http://www.apache.org/foundation/voting.html#ReleaseVotes [3] http://people.apache.org/~lu4242/myfaces223binsrc [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600version=12326543
Re: [VOTE] Release of MyFaces Core 2.2.3
I've cleaned up all of these files. Trunk builds and passes rat, so a new release candidate should pass rat as well. On Thu, Apr 17, 2014 at 5:35 AM, Mike Kienenberger mkien...@gmail.com wrote: Sorry. -1 Rat shows that we have several non-trivial files that are missing headers: impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_1.xhtml impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_3.xhtml impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_4.xhtml impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_2.xhtml impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_7.xhtml impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/testComposite/dynComp_1.xhtml The rest of these files are not blockers, but are also showing up in rat, which makes evaluating a release take much longer. Can we add headers to them? We could also add them to the exclude list, but if the contents changed to be non-trivial, then we'd need a license anyway, so it's safer to add the license, and each of these file formats supports license comments. impl/src/test/resources/org/apache/myfaces/application/contracts/contracts/red/mylib/myjs.js impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/test1.js impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/test.js impl/src/test/resources/META-INF/contracts/yellow/javax.faces.contract.xml impl/src/test/resources/META-INF/contracts/yellow/mylib/myjs.js impl/src/test/resources/META-INF/contracts/blue/javax.faces.contract.xml impl/src/test/resources/META-INF/contracts/blue/mylib/myjs.js These files needs to be put in the rat exclusions section as I'm fairly certain they do not support having a license in them, and they are trivial. impl/src/main/resources/META-INF/services/javax.enterprise.inject.spi.Extension impl/src/main/resources/META-INF/services/org.apache.myfaces.spi.InjectionProvider On Wed, Apr 16, 2014 at 1:17 PM, Leonardo Uribe lu4...@gmail.com wrote: Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following parts: 1. Maven artifact group org.apache.myfaces.shared v4.2.2 [1] 2. Maven artifact group org.apache.myfaces.core v2.2.3 [1] The artifacts were deployed on nexus repo [1] and to my private Apache account [3] for binary and source packages. The release notes could be found at [4]. Also the clirr test does not show binary incompatibilities with myfaces-api. Please take a look at the 2.2.3 artifacts and vote! Please note: This vote is majority approval with a minimum of three +1 votes (see [3]). [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Leonardo Uribe [1] https://repository.apache.org/content/repositories/orgapachemyfaces-1018/org/apache/myfaces/ https://repository.apache.org/content/repositories/orgapachemyfaces-1017/org/apache/myfaces/ [2] http://www.apache.org/foundation/voting.html#ReleaseVotes [3] http://people.apache.org/~lu4242/myfaces223binsrc [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600version=12326543
Re: [VOTE] Release of MyFaces Core 2.2.3
You asked about licensing on test files the last time this came up as well so I will point to my previous reply for that topic: http://mail-archives.apache.org/mod_mbox/myfaces-dev/201209.mbox/%3ccam1yojbz2jn5obhkfavo-v5rvfauzsk0yjeoj66pm+wejk_...@mail.gmail.com%3E As for a quick fix release, It doesn't matter whether a release is a quick fix or any other kind. The same rules apply to all releases. On Thu, Apr 17, 2014 at 6:42 AM, Leonardo Uribe lu4...@gmail.com wrote: Hi Those files are used for test only. Is it so important to block a quick fix release? Regards Leonardo On Apr 17, 2014 11:36 AM, Mike Kienenberger mkien...@gmail.com wrote: Sorry. -1 Rat shows that we have several non-trivial files that are missing headers: impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_1.xhtml impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_3.xhtml impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_4.xhtml impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_2.xhtml impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_7.xhtml impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/testComposite/dynComp_1.xhtml The rest of these files are not blockers, but are also showing up in rat, which makes evaluating a release take much longer. Can we add headers to them? We could also add them to the exclude list, but if the contents changed to be non-trivial, then we'd need a license anyway, so it's safer to add the license, and each of these file formats supports license comments. impl/src/test/resources/org/apache/myfaces/application/contracts/contracts/red/mylib/myjs.js impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/test1.js impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/test.js impl/src/test/resources/META-INF/contracts/yellow/javax.faces.contract.xml impl/src/test/resources/META-INF/contracts/yellow/mylib/myjs.js impl/src/test/resources/META-INF/contracts/blue/javax.faces.contract.xml impl/src/test/resources/META-INF/contracts/blue/mylib/myjs.js These files needs to be put in the rat exclusions section as I'm fairly certain they do not support having a license in them, and they are trivial. impl/src/main/resources/META-INF/services/javax.enterprise.inject.spi.Extension impl/src/main/resources/META-INF/services/org.apache.myfaces.spi.InjectionProvider On Wed, Apr 16, 2014 at 1:17 PM, Leonardo Uribe lu4...@gmail.com wrote: Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following parts: 1. Maven artifact group org.apache.myfaces.shared v4.2.2 [1] 2. Maven artifact group org.apache.myfaces.core v2.2.3 [1] The artifacts were deployed on nexus repo [1] and to my private Apache account [3] for binary and source packages. The release notes could be found at [4]. Also the clirr test does not show binary incompatibilities with myfaces-api. Please take a look at the 2.2.3 artifacts and vote! Please note: This vote is majority approval with a minimum of three +1 votes (see [3]). [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Leonardo Uribe [1] https://repository.apache.org/content/repositories/orgapachemyfaces-1018/org/apache/myfaces/ https://repository.apache.org/content/repositories/orgapachemyfaces-1017/org/apache/myfaces/ [2] http://www.apache.org/foundation/voting.html#ReleaseVotes [3] http://people.apache.org/~lu4242/myfaces223binsrc [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600version=12326543
Re: [VOTE] Release of MyFaces Core 2.2.3
For what it's worth, if you and two other people disagree that the licensing of these files should be a blocking issue, you can still do a release. As the release manager, the final decision is yours so long as you have a majority approval. [1] [1] https://www.apache.org/foundation/voting.html#ReleaseVotes On Thu, Apr 17, 2014 at 6:53 AM, Mike Kienenberger mkien...@gmail.com wrote: You asked about licensing on test files the last time this came up as well so I will point to my previous reply for that topic: http://mail-archives.apache.org/mod_mbox/myfaces-dev/201209.mbox/%3ccam1yojbz2jn5obhkfavo-v5rvfauzsk0yjeoj66pm+wejk_...@mail.gmail.com%3E As for a quick fix release, It doesn't matter whether a release is a quick fix or any other kind. The same rules apply to all releases. On Thu, Apr 17, 2014 at 6:42 AM, Leonardo Uribe lu4...@gmail.com wrote: Hi Those files are used for test only. Is it so important to block a quick fix release? Regards Leonardo On Apr 17, 2014 11:36 AM, Mike Kienenberger mkien...@gmail.com wrote: Sorry. -1 Rat shows that we have several non-trivial files that are missing headers: impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_1.xhtml impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_3.xhtml impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_4.xhtml impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_2.xhtml impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_7.xhtml impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/testComposite/dynComp_1.xhtml The rest of these files are not blockers, but are also showing up in rat, which makes evaluating a release take much longer. Can we add headers to them? We could also add them to the exclude list, but if the contents changed to be non-trivial, then we'd need a license anyway, so it's safer to add the license, and each of these file formats supports license comments. impl/src/test/resources/org/apache/myfaces/application/contracts/contracts/red/mylib/myjs.js impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/test1.js impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/test.js impl/src/test/resources/META-INF/contracts/yellow/javax.faces.contract.xml impl/src/test/resources/META-INF/contracts/yellow/mylib/myjs.js impl/src/test/resources/META-INF/contracts/blue/javax.faces.contract.xml impl/src/test/resources/META-INF/contracts/blue/mylib/myjs.js These files needs to be put in the rat exclusions section as I'm fairly certain they do not support having a license in them, and they are trivial. impl/src/main/resources/META-INF/services/javax.enterprise.inject.spi.Extension impl/src/main/resources/META-INF/services/org.apache.myfaces.spi.InjectionProvider On Wed, Apr 16, 2014 at 1:17 PM, Leonardo Uribe lu4...@gmail.com wrote: Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following parts: 1. Maven artifact group org.apache.myfaces.shared v4.2.2 [1] 2. Maven artifact group org.apache.myfaces.core v2.2.3 [1] The artifacts were deployed on nexus repo [1] and to my private Apache account [3] for binary and source packages. The release notes could be found at [4]. Also the clirr test does not show binary incompatibilities with myfaces-api. Please take a look at the 2.2.3 artifacts and vote! Please note: This vote is majority approval with a minimum of three +1 votes (see [3]). [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Leonardo Uribe [1] https://repository.apache.org/content/repositories/orgapachemyfaces-1018/org/apache/myfaces/ https://repository.apache.org/content/repositories/orgapachemyfaces-1017/org/apache/myfaces/ [2] http://www.apache.org/foundation/voting.html#ReleaseVotes [3] http://people.apache.org/~lu4242/myfaces223binsrc [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600version=12326543
Re: [VOTE] Release of MyFaces Core 2.2.3
Ok, so it is unavoidable. I didn't knew that. The problem is rat plugin is never executed automatically as part of the release, so there is no chance to detect and fix it early. I'll take a look at that. On Apr 17, 2014 12:54 PM, Mike Kienenberger mkien...@gmail.com wrote: You asked about licensing on test files the last time this came up as well so I will point to my previous reply for that topic: http://mail-archives.apache.org/mod_mbox/myfaces-dev/201209.mbox/%3ccam1yojbz2jn5obhkfavo-v5rvfauzsk0yjeoj66pm+wejk_...@mail.gmail.com%3E As for a quick fix release, It doesn't matter whether a release is a quick fix or any other kind. The same rules apply to all releases. On Thu, Apr 17, 2014 at 6:42 AM, Leonardo Uribe lu4...@gmail.com wrote: Hi Those files are used for test only. Is it so important to block a quick fix release? Regards Leonardo On Apr 17, 2014 11:36 AM, Mike Kienenberger mkien...@gmail.com wrote: Sorry. -1 Rat shows that we have several non-trivial files that are missing headers: impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_1.xhtml impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_3.xhtml impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_4.xhtml impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_2.xhtml impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_7.xhtml impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/testComposite/dynComp_1.xhtml The rest of these files are not blockers, but are also showing up in rat, which makes evaluating a release take much longer. Can we add headers to them? We could also add them to the exclude list, but if the contents changed to be non-trivial, then we'd need a license anyway, so it's safer to add the license, and each of these file formats supports license comments. impl/src/test/resources/org/apache/myfaces/application/contracts/contracts/red/mylib/myjs.js impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/test1.js impl/src/test/resources/org/apache/myfaces/view/facelets/pool/resources/test.js impl/src/test/resources/META-INF/contracts/yellow/javax.faces.contract.xml impl/src/test/resources/META-INF/contracts/yellow/mylib/myjs.js impl/src/test/resources/META-INF/contracts/blue/javax.faces.contract.xml impl/src/test/resources/META-INF/contracts/blue/mylib/myjs.js These files needs to be put in the rat exclusions section as I'm fairly certain they do not support having a license in them, and they are trivial. impl/src/main/resources/META-INF/services/javax.enterprise.inject.spi.Extension impl/src/main/resources/META-INF/services/org.apache.myfaces.spi.InjectionProvider On Wed, Apr 16, 2014 at 1:17 PM, Leonardo Uribe lu4...@gmail.com wrote: Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following parts: 1. Maven artifact group org.apache.myfaces.shared v4.2.2 [1] 2. Maven artifact group org.apache.myfaces.core v2.2.3 [1] The artifacts were deployed on nexus repo [1] and to my private Apache account [3] for binary and source packages. The release notes could be found at [4]. Also the clirr test does not show binary incompatibilities with myfaces-api. Please take a look at the 2.2.3 artifacts and vote! Please note: This vote is majority approval with a minimum of three +1 votes (see [3]). [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Leonardo Uribe [1] https://repository.apache.org/content/repositories/orgapachemyfaces-1018/org/apache/myfaces/ https://repository.apache.org/content/repositories/orgapachemyfaces-1017/org/apache/myfaces/ [2] http://www.apache.org/foundation/voting.html#ReleaseVotes [3] http://people.apache.org/~lu4242/myfaces223binsrc [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600version=12326543
Re: [VOTE] Release of MyFaces Core 2.2.3
On Thu, Apr 17, 2014 at 7:10 AM, Leonardo Uribe lu4...@gmail.com wrote: The problem is rat plugin is never executed automatically as part of the release, so there is no chance to detect and fix it early. I'll take a look at that. I really hate having to vote against a release just because we missed license headers. Even if we can't make running rat an automatic part of the release maven task, maybe you can add a new step (mvn apache-rat:check) in the release process document of running rat so it always happens? I wasn't sure what you are using as a template for each release document or I would have added the step in there myself.
Re: [VOTE] Release of MyFaces Core 2.2.3
I usually do wiki page for each release. The one for 2.2.3 is here: http://wiki.apache.org/myfaces/CoreRelease223 There are two options, or we put the rat plugin command at the beginning, or we add the plugin when the release preparations are done. The idea is if a file miss the license, the rat plugin will stop the release when: mvn release:prepare -DtagBase=https://svn.apache.org/repos/asf/myfaces/shared/tags -DdryRun=true is executed. For example, clirr plugin and animal sniffer plugin are executed in that way. I'll check how can we do it, and fix it once for all. The only thing I don't like with this situation is execute the TCK again, because it usually takes some time, so probably the next vote attempt will be on this weekend. regards, Leonardo Uribe 2014-04-17 13:19 GMT+02:00 Mike Kienenberger mkien...@gmail.com: On Thu, Apr 17, 2014 at 7:10 AM, Leonardo Uribe lu4...@gmail.com wrote: The problem is rat plugin is never executed automatically as part of the release, so there is no chance to detect and fix it early. I'll take a look at that. I really hate having to vote against a release just because we missed license headers. Even if we can't make running rat an automatic part of the release maven task, maybe you can add a new step (mvn apache-rat:check) in the release process document of running rat so it always happens? I wasn't sure what you are using as a template for each release document or I would have added the step in there myself.
Re: [VOTE] Release of MyFaces Core 2.2.3
Hi I have tried adding this fragment on core/parent/pom.xml profile idprepare-release/id activation property nameprepareRelease/name /property /activation build plugins plugin artifactIdmaven-release-plugin/artifactId configuration arguments-DprepareRelease/arguments /configuration /plugin plugin groupIdorg.apache.rat/groupId artifactIdapache-rat-plugin/artifactId executions execution phaseverify/phase goals goalcheck/goal /goals /execution /executions /plugin /plugins /build /profile It works, so I'll run again the release procedure and send another vote request to the mailing list. regards, Leonardo Uribe 2014-04-17 13:42 GMT+02:00 Leonardo Uribe lu4...@gmail.com: I usually do wiki page for each release. The one for 2.2.3 is here: http://wiki.apache.org/myfaces/CoreRelease223 There are two options, or we put the rat plugin command at the beginning, or we add the plugin when the release preparations are done. The idea is if a file miss the license, the rat plugin will stop the release when: mvn release:prepare -DtagBase=https://svn.apache.org/repos/asf/myfaces/shared/tags -DdryRun=true is executed. For example, clirr plugin and animal sniffer plugin are executed in that way. I'll check how can we do it, and fix it once for all. The only thing I don't like with this situation is execute the TCK again, because it usually takes some time, so probably the next vote attempt will be on this weekend. regards, Leonardo Uribe 2014-04-17 13:19 GMT+02:00 Mike Kienenberger mkien...@gmail.com: On Thu, Apr 17, 2014 at 7:10 AM, Leonardo Uribe lu4...@gmail.com wrote: The problem is rat plugin is never executed automatically as part of the release, so there is no chance to detect and fix it early. I'll take a look at that. I really hate having to vote against a release just because we missed license headers. Even if we can't make running rat an automatic part of the release maven task, maybe you can add a new step (mvn apache-rat:check) in the release process document of running rat so it always happens? I wasn't sure what you are using as a template for each release document or I would have added the step in there myself.
[VOTE] Release of MyFaces Core 2.2.3
Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following parts: 1. Maven artifact group org.apache.myfaces.shared v4.2.2 [1] 2. Maven artifact group org.apache.myfaces.core v2.2.3 [1] The artifacts were deployed on nexus repo [1] and to my private Apache account [3] for binary and source packages. The release notes could be found at [4]. Also the clirr test does not show binary incompatibilities with myfaces-api. Please take a look at the 2.2.3 artifacts and vote! Please note: This vote is majority approval with a minimum of three +1 votes (see [3]). [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Leonardo Uribe [1] https://repository.apache.org/content/repositories/orgapachemyfaces-1018/org/apache/myfaces/ https://repository.apache.org/content/repositories/orgapachemyfaces-1017/org/apache/myfaces/ [2] http://www.apache.org/foundation/voting.html#ReleaseVotes [3] http://people.apache.org/~lu4242/myfaces223binsrc [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600version=12326543
Re: [VOTE] Release of MyFaces Core 2.2.3
+1 2014-04-16 19:17 GMT+02:00 Leonardo Uribe lu4...@gmail.com: Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following parts: 1. Maven artifact group org.apache.myfaces.shared v4.2.2 [1] 2. Maven artifact group org.apache.myfaces.core v2.2.3 [1] The artifacts were deployed on nexus repo [1] and to my private Apache account [3] for binary and source packages. The release notes could be found at [4]. Also the clirr test does not show binary incompatibilities with myfaces-api. Please take a look at the 2.2.3 artifacts and vote! Please note: This vote is majority approval with a minimum of three +1 votes (see [3]). [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Leonardo Uribe [1] https://repository.apache.org/content/repositories/orgapachemyfaces-1018/org/apache/myfaces/ https://repository.apache.org/content/repositories/orgapachemyfaces-1017/org/apache/myfaces/ [2] http://www.apache.org/foundation/voting.html#ReleaseVotes [3] http://people.apache.org/~lu4242/myfaces223binsrc [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600version=12326543
Re: [VOTE] release of MyFaces Core 2.2.3
-1 I have serious problems with version 2.2.3 provided by Leo and with the current snapshot in one of my examples. It seems, that there is some problem with resources or templates or both. The application works and looks fine with 2.2.1 and 2.2.2 but not with 2.2.3 or the current snapshot. Best regards Michi Am 11.04.2014 um 12:10 schrieb Werner Punz werner.p...@gmail.com: +1 Am 08.04.14 17:11, schrieb Leonardo Uribe: Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following parts: 1. Maven artifact group org.apache.myfaces.shared v4.2.2 [1] 2. Maven artifact group org.apache.myfaces.core v2.2.3 [1] The artifacts were deployed on nexus repo [1] and to my private Apache account [3] for binary and source packages. The release notes could be found at [4]. Also the clirr test does not show binary incompatibilities with myfaces-api. Please take a look at the 2.2.3 artifacts and vote! Please note: This vote is majority approval with a minimum of three +1 votes (see [3]). [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Leonardo Uribe [1] https://repository.apache.org/content/repositories/orgapachemyfaces-1016/org/apache/myfaces/ [2] http://www.apache.org/foundation/voting.html#ReleaseVotes [3] http://people.apache.org/~lu4242/myfaces223binsrc [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600version=12326543
Re: [VOTE] release of MyFaces Core 2.2.3
Hi We have only 6 changes in the release, and none of them are related to templates or resources. (3 for html friendly markup, 1 for the wrappers, 1 for the PostRestoreStateEvent, 1 for for attribute in a converter). Could you please give us more information about the specific example?. So I can run it and check by myself if something is wrong? regards, Leonardo Uribe On Apr 12, 2014 3:38 PM, Michael Kurz michi.k...@gmx.at wrote: -1 I have serious problems with version 2.2.3 provided by Leo and with the current snapshot in one of my examples. It seems, that there is some problem with resources or templates or both. The application works and looks fine with 2.2.1 and 2.2.2 but not with 2.2.3 or the current snapshot. Best regards Michi Am 11.04.2014 um 12:10 schrieb Werner Punz werner.p...@gmail.com: +1 Am 08.04.14 17:11, schrieb Leonardo Uribe: Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following parts: 1. Maven artifact group org.apache.myfaces.shared v4.2.2 [1] 2. Maven artifact group org.apache.myfaces.core v2.2.3 [1] The artifacts were deployed on nexus repo [1] and to my private Apache account [3] for binary and source packages. The release notes could be found at [4]. Also the clirr test does not show binary incompatibilities with myfaces-api. Please take a look at the 2.2.3 artifacts and vote! Please note: This vote is majority approval with a minimum of three +1 votes (see [3]). [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Leonardo Uribe [1] https://repository.apache.org/content/repositories/orgapachemyfaces-1016/org/apache/myfaces/ [2] http://www.apache.org/foundation/voting.html#ReleaseVotes [3] http://people.apache.org/~lu4242/myfaces223binsrc [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600version=12326543
Re: [VOTE] release of MyFaces Core 2.2.3
I created MYFACES-3882 including my application. Best regards Michi Am 12.04.2014 um 15:47 schrieb Leonardo Uribe lu4...@gmail.com: Hi We have only 6 changes in the release, and none of them are related to templates or resources. (3 for html friendly markup, 1 for the wrappers, 1 for the PostRestoreStateEvent, 1 for for attribute in a converter). Could you please give us more information about the specific example?. So I can run it and check by myself if something is wrong? regards, Leonardo Uribe On Apr 12, 2014 3:38 PM, Michael Kurz michi.k...@gmx.at wrote: -1 I have serious problems with version 2.2.3 provided by Leo and with the current snapshot in one of my examples. It seems, that there is some problem with resources or templates or both. The application works and looks fine with 2.2.1 and 2.2.2 but not with 2.2.3 or the current snapshot. Best regards Michi Am 11.04.2014 um 12:10 schrieb Werner Punz werner.p...@gmail.com: +1 Am 08.04.14 17:11, schrieb Leonardo Uribe: Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following parts: 1. Maven artifact group org.apache.myfaces.shared v4.2.2 [1] 2. Maven artifact group org.apache.myfaces.core v2.2.3 [1] The artifacts were deployed on nexus repo [1] and to my private Apache account [3] for binary and source packages. The release notes could be found at [4]. Also the clirr test does not show binary incompatibilities with myfaces-api. Please take a look at the 2.2.3 artifacts and vote! Please note: This vote is majority approval with a minimum of three +1 votes (see [3]). [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Leonardo Uribe [1] https://repository.apache.org/content/repositories/orgapachemyfaces-1016/org/apache/myfaces/ [2] http://www.apache.org/foundation/voting.html#ReleaseVotes [3] http://people.apache.org/~lu4242/myfaces223binsrc [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600version=12326543
Re: [VOTE] release of MyFaces Core 2.2.3
Hi The problem is caused because h:outputScript and h:outputStylesheet are the only components that does not have implemented its attributes in the component class, and instead they use an instance of UIOutput. This cause a problem with the new algorithm in place for html5 friendly markup, because it tries to detect when to put the attribute on the normal component attribute map or in the passthrough attribute map using this condition. At first view, the solution is deal with the problem as an exception to the rule. For the ones interested in follow the discussion in jsr344 users list, take a look at: https://java.net/projects/javaserverfaces-spec-public/lists/users/archive/2014-03/message/35 There is no other choice than to fix the bug and try again a new release. I'll do that next week. regards, Leonardo Uribe 2014-04-12 15:50 GMT+02:00 Michael Kurz michi.k...@gmx.at: I created MYFACES-3882 including my application. Best regards Michi Am 12.04.2014 um 15:47 schrieb Leonardo Uribe lu4...@gmail.com: Hi We have only 6 changes in the release, and none of them are related to templates or resources. (3 for html friendly markup, 1 for the wrappers, 1 for the PostRestoreStateEvent, 1 for for attribute in a converter). Could you please give us more information about the specific example?. So I can run it and check by myself if something is wrong? regards, Leonardo Uribe On Apr 12, 2014 3:38 PM, Michael Kurz michi.k...@gmx.at wrote: -1 I have serious problems with version 2.2.3 provided by Leo and with the current snapshot in one of my examples. It seems, that there is some problem with resources or templates or both. The application works and looks fine with 2.2.1 and 2.2.2 but not with 2.2.3 or the current snapshot. Best regards Michi Am 11.04.2014 um 12:10 schrieb Werner Punz werner.p...@gmail.com: +1 Am 08.04.14 17:11, schrieb Leonardo Uribe: Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following parts: 1. Maven artifact group org.apache.myfaces.shared v4.2.2 [1] 2. Maven artifact group org.apache.myfaces.core v2.2.3 [1] The artifacts were deployed on nexus repo [1] and to my private Apache account [3] for binary and source packages. The release notes could be found at [4]. Also the clirr test does not show binary incompatibilities with myfaces-api. Please take a look at the 2.2.3 artifacts and vote! Please note: This vote is majority approval with a minimum of three +1 votes (see [3]). [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Leonardo Uribe [1] https://repository.apache.org/content/repositories/orgapachemyfaces-1016/org/apache/myfaces/ [2] http://www.apache.org/foundation/voting.html#ReleaseVotes [3] http://people.apache.org/~lu4242/myfaces223binsrc [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600version=12326543
Re: [VOTE] release of MyFaces Core 2.2.3
+1 Am 08.04.14 17:11, schrieb Leonardo Uribe: Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following parts: 1. Maven artifact group org.apache.myfaces.shared v4.2.2 [1] 2. Maven artifact group org.apache.myfaces.core v2.2.3 [1] The artifacts were deployed on nexus repo [1] and to my private Apache account [3] for binary and source packages. The release notes could be found at [4]. Also the clirr test does not show binary incompatibilities with myfaces-api. Please take a look at the 2.2.3 artifacts and vote! Please note: This vote is majority approval with a minimum of three +1 votes (see [3]). [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Leonardo Uribe [1] https://repository.apache.org/content/repositories/orgapachemyfaces-1016/org/apache/myfaces/ [2] http://www.apache.org/foundation/voting.html#ReleaseVotes [3] http://people.apache.org/~lu4242/myfaces223binsrc [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600version=12326543
Re: [VOTE] release of MyFaces Core 2.2.3
+1 On Wed, Apr 9, 2014 at 9:04 PM, Paul Nicolucci pnico...@us.ibm.com wrote: +1 Regards, Paul Nicolucci [image: Inactive hide details for Leonardo Uribe ---04/08/2014 11:11:41 AM---Hi, I was running the needed tasks to get the 2.2.3 releas]Leonardo Uribe ---04/08/2014 11:11:41 AM---Hi, I was running the needed tasks to get the 2.2.3 release of Apache From: Leonardo Uribe lu4...@gmail.com To: MyFaces Development dev@myfaces.apache.org, Date: 04/08/2014 11:11 AM Subject: [VOTE] release of MyFaces Core 2.2.3 -- Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following parts: 1. Maven artifact group org.apache.myfaces.shared v4.2.2 [1] 2. Maven artifact group org.apache.myfaces.core v2.2.3 [1] The artifacts were deployed on nexus repo [1] and to my private Apache account [3] for binary and source packages. The release notes could be found at [4]. Also the clirr test does not show binary incompatibilities with myfaces-api. Please take a look at the 2.2.3 artifacts and vote! Please note: This vote is majority approval with a minimum of three +1 votes (see [3]). [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Leonardo Uribe [1] https://repository.apache.org/content/repositories/orgapachemyfaces-1016/org/apache/myfaces/ [2] http://www.apache.org/foundation/voting.html#ReleaseVotes [3] http://people.apache.org/~lu4242/myfaces223binsrc [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600version=12326543 -- Grant Smith - V.P. Information Technology Marathon Computer Systems, LLC. inline: graycol.gif
Re: [VOTE] release of MyFaces Core 2.2.3
+1 Regards, Paul Nicolucci From: Leonardo Uribe lu4...@gmail.com To: MyFaces Development dev@myfaces.apache.org, Date: 04/08/2014 11:11 AM Subject:[VOTE] release of MyFaces Core 2.2.3 Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following parts: 1. Maven artifact group org.apache.myfaces.shared v4.2.2 [1] 2. Maven artifact group org.apache.myfaces.core v2.2.3 [1] The artifacts were deployed on nexus repo [1] and to my private Apache account [3] for binary and source packages. The release notes could be found at [4]. Also the clirr test does not show binary incompatibilities with myfaces-api. Please take a look at the 2.2.3 artifacts and vote! Please note: This vote is majority approval with a minimum of three +1 votes (see [3]). [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Leonardo Uribe [1] https://repository.apache.org/content/repositories/orgapachemyfaces-1016/org/apache/myfaces/ [2] http://www.apache.org/foundation/voting.html#ReleaseVotes [3] http://people.apache.org/~lu4242/myfaces223binsrc [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600version=12326543 inline: graycol.gif
[VOTE] release of MyFaces Core 2.2.3
Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following parts: 1. Maven artifact group org.apache.myfaces.shared v4.2.2 [1] 2. Maven artifact group org.apache.myfaces.core v2.2.3 [1] The artifacts were deployed on nexus repo [1] and to my private Apache account [3] for binary and source packages. The release notes could be found at [4]. Also the clirr test does not show binary incompatibilities with myfaces-api. Please take a look at the 2.2.3 artifacts and vote! Please note: This vote is majority approval with a minimum of three +1 votes (see [3]). [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Leonardo Uribe [1] https://repository.apache.org/content/repositories/orgapachemyfaces-1016/org/apache/myfaces/ [2] http://www.apache.org/foundation/voting.html#ReleaseVotes [3] http://people.apache.org/~lu4242/myfaces223binsrc [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600version=12326543
Re: [VOTE] release of MyFaces Core 2.2.3
+1 2014-04-08 17:11 GMT+02:00 Leonardo Uribe lu4...@gmail.com: Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following parts: 1. Maven artifact group org.apache.myfaces.shared v4.2.2 [1] 2. Maven artifact group org.apache.myfaces.core v2.2.3 [1] The artifacts were deployed on nexus repo [1] and to my private Apache account [3] for binary and source packages. The release notes could be found at [4]. Also the clirr test does not show binary incompatibilities with myfaces-api. Please take a look at the 2.2.3 artifacts and vote! Please note: This vote is majority approval with a minimum of three +1 votes (see [3]). [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Leonardo Uribe [1] https://repository.apache.org/content/repositories/orgapachemyfaces-1016/org/apache/myfaces/ [2] http://www.apache.org/foundation/voting.html#ReleaseVotes [3] http://people.apache.org/~lu4242/myfaces223binsrc [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600version=12326543
