Re: @SHALE-442

2008-04-02 Thread Gary VanMatre
Hi.
I want to fix this bug 442 and want to ask some question here about doing 
that, if thats ok, i'll hope so.

I'll fixed the decorator not to apply shales validator renderer if the 
renderer family matches the ajax stuff, which let them work again.
However this seams not the ultimate approach to me because there are so many 
different familys and renderers which should not be decorated, that i'll have 
to code everytime they change.

Are there any suggestions or ideas (already) how this should be done 
the right way?


I have struggled with this issue and do not see a clean/easy fix.  Most rich 
validators are bundled with component libraries that have a unique rendering 
strategy for script.  In the case of shale's common validator, the script needs 
to be built in the context of rendering.  This is important for children of the 
UIData component family.  Unfortunately, there is not yet a generic way to 
extend a renderer without knowledge of the component library.  This issue 
surfaces with Tomahawks Ajax renderer interface contract.
 
However, I believe that JSF 2.0 will provide listeners that can be attached to 
components and fired at render time but we'll have to wait and see if that can 
be used to build rich validators that are not coupled to a single component 
library. 

Or, maybe bytecode injection would be the ticket?  I guess we could take some 
studies of tapestry 5?  Maybe inject our own listeners :-)

Torsten

Gary---BeginMessage---
Hi.
I want to fix this bug 442 and want to ask some question here about doing 
that, if thats ok, i'll hope so.

I'll fixed the decorator not to apply shales validator renderer if the 
renderer family matches the ajax stuff, which let them work again.
However this seams not the ultimate approach to me because there are so many 
different familys and renderers which should not be decorated, that i'll have 
to code everytime they change.

Are there any suggestions or ideas (already) how this should be done 
the right way?

Torsten


smime.p7s
Description: S/MIME cryptographic signature
---End Message---


Re: @SHALE-442

2008-04-02 Thread Greg Reddin
On Mon, Mar 31, 2008 at 5:24 PM, Torsten Krah
[EMAIL PROTECTED] wrote:
  I want to fix this bug 442 and want to ask some question here about doing
  that, if thats ok, i'll hope so.

This is definitely the right place to discuss such fixes.


  I'll fixed the decorator not to apply shales validator renderer if the
  renderer family matches the ajax stuff, which let them work again.
  However this seams not the ultimate approach to me because there are so many
  different familys and renderers which should not be decorated, that i'll have
  to code everytime they change.

At first glance, I don't think it's a good idea to hardcode a set of
renderer families that will not apply like that. The root of the
problem is that you can't have both the validator and ajax renderers
and the combination is a valid one. So it seems like we need to
rethink (maybe) the way we handle the validator renderers.

Right now I don't have a better answer for you.

Greg