Re: Can't seem to get Dialog2NavigationHandler working

2006-09-07 Thread Craig McClanahan

On 9/6/06, Rahul Akolkar [EMAIL PROTECTED] wrote:


On 9/3/06, Craig McClanahan [EMAIL PROTECTED] wrote:

 Two things -- first, how recent are the bits you're using?  I've been
making
 *lots* of changes through yesterday (a fun way to spend the commercials
 while Oregon was whomping on Stanford :-), and the legacy implementation
now
 works for me.  I've also checked in a test app
(shale-test-dialog2-legacy)
 into the sandbox.  This webapp can be used manually to experiment (it
even
 has a split-screen mode so you can play with two active dialogs in two
 different frames), plus it's got a basic system integration test (mvn
 -Pitest clean install) to run a couple of simple scenarios
automatically.
 Next I'll see about doing something similar for the SCXML
implementation.

snip/

The dialog2-scxml bits are probably just at compiles-clean stage. A
matching shale-test-dialog2-scxml sibling sounds like a good idea,
I'll help there. Probably makes sense to have the same dialogs as
exist in the legacy test app for starters, even though that might mean
some redundancy in the sandbox source tree. Then we can add others to
display some SCXML-specific bits. Is this similar to what you were
thinking?



Yes.

In a broader scope, I'd like to see us migrate test functionality that is
strictly for testing out of the use cases app and into apps like the test
ones (shale-test-core and shale-test-tiger in framework/shale-apps, and
shale-test-dialog2-legacy in sandbox).  That way, we could make room in the
use cases app for stuff with visual appeal (and explanatory backup info) for
demos or a quick learning experience.

Craig


-Rahul




 Craig





Re: Can't seem to get Dialog2NavigationHandler working

2006-09-03 Thread Sean Schofield

OK the problem was with my h:commandLink.  It was not nested inside
a h:form and thus behaving weirdly.  Tomahawk used to compensate for
this by creating a dummy form but we found that caused problems with
the RI.

I do have a new problem, however, which is that it can't seem to find
my dialog definitions (its telling me the dialog doesn't exist.)  I
created a new issue on this, SHALE-271

sean

On 9/1/06, Craig McClanahan [EMAIL PROTECTED] wrote:

On 9/1/06, Sean Schofield [EMAIL PROTECTED] wrote:

 The nav handler is in fact declared and the classname seems correct to
 me.  That was the first thing I checked.  Have you run an actual
 dialog yet or are you still in the just getting things to compile
 stage?


My focus so far has indeed been just getting to the compiles-clean stage.
Getting it to actually work is definitely the next thing to do (and I'll be
spending some time on this weekend).

Sean


Craig

On 9/1/06, Craig McClanahan [EMAIL PROTECTED] wrote:
  On 9/1/06, Sean Schofield [EMAIL PROTECTED] wrote:
  
   I can't seem to get Dialog2NavigationHandler working properly (I'm
   using the 1.2 RI.)  It appears that the faces-config.xml in the jar
   file is beaing read based on this:
  
   2006-09-01 14:27:11,587 [main] INFO
   org.apache.myfaces.config.FacesConfigurator - Reading config
  
  
 
jar:file:/D:/open-source/shale-goodies/shale-petstore/target/shale-petstore/WEB-INF/lib/shale-
   dialog2-1.0.4-SNAPSHOT.jar!/META-INF/faces-config.xml
  
   Unfortunately, it does not appear that the handleNavigation method is
   being called.  I'm also using the 1.0.4-SNAPSHOT of core but with the
   decorated NavigationHandlers that shouldn't matter.
  
   Maybe its possible that the method is getting called and my IDE
   debugger isn't showing it.  I know that this command link certainly
   isn't working:
  
   h:commandLink action=dialog2:Checkout
  
   Any ideas?
 
 
  It's probably a botched faces-config.xml file inside the
  shale-dialog2-xxx.jar file ... if the custom navigation handler isn't
  declared (or if the classname is wrong), it won't ever get invoked.
 
  I'll take a look.
 
  Sean
  
 
 
  Craig
 
 





Re: Can't seem to get Dialog2NavigationHandler working

2006-09-03 Thread Craig McClanahan

On 9/3/06, Sean Schofield [EMAIL PROTECTED] wrote:


OK the problem was with my h:commandLink.  It was not nested inside
a h:form and thus behaving weirdly.  Tomahawk used to compensate for
this by creating a dummy form but we found that caused problems with
the RI.

I do have a new problem, however, which is that it can't seem to find
my dialog definitions (its telling me the dialog doesn't exist.)  I
created a new issue on this, SHALE-271



Two things -- first, how recent are the bits you're using?  I've been making
*lots* of changes through yesterday (a fun way to spend the commercials
while Oregon was whomping on Stanford :-), and the legacy implementation now
works for me.  I've also checked in a test app (shale-test-dialog2-legacy)
into the sandbox.  This webapp can be used manually to experiment (it even
has a split-screen mode so you can play with two active dialogs in two
different frames), plus it's got a basic system integration test (mvn
-Pitest clean install) to run a couple of simple scenarios automatically.
Next I'll see about doing something similar for the SCXML implementation.

The second thing is that, at the moment, you have to explicitly declare your
dialog configuration files in web.xml:

 context-param
   param-nameorg.apache.shale.dialog2.legacy.CONFIGURATION/param-name
   param-value/WEB-INF/dialog-config.xml/param-value
 /context-param

On my list of corrections is making it recognize this default location
automatically ... should be an easy fix.


sean



Craig


Re: Can't seem to get Dialog2NavigationHandler working

2006-09-03 Thread Sean Schofield

Two things -- first, how recent are the bits you're using?  I've been making
*lots* of changes through yesterday (a fun way to spend the commercials
while Oregon was whomping on Stanford :-), and the legacy implementation now
works for me.  I've also checked in a test app (shale-test-dialog2-legacy)
into the sandbox.  This webapp can be used manually to experiment (it even
has a split-screen mode so you can play with two active dialogs in two
different frames), plus it's got a basic system integration test (mvn
-Pitest clean install) to run a couple of simple scenarios automatically.
Next I'll see about doing something similar for the SCXML implementation.


Yeah I realized you had made changes but only after I tried to check
in and the file was no longer in SVN!  No big deal, it was a minor
change and I just copied and pasted it into the new location.  BTW,
I'm glad we renamed the Contexts interface - that was too confusing
having both Context and Contexts.


The second thing is that, at the moment, you have to explicitly declare your
dialog configuration files in web.xml:

  context-param
param-nameorg.apache.shale.dialog2.legacy.CONFIGURATION/param-name
param-value/WEB-INF/dialog-config.xml/param-value
  /context-param

On my list of corrections is making it recognize this default location
automatically ... should be an easy fix.


Yes this was the problem.  The param name was still configured for the
current dialog implementation.


Craig


Sean


Can't seem to get Dialog2NavigationHandler working

2006-09-01 Thread Sean Schofield

I can't seem to get Dialog2NavigationHandler working properly (I'm
using the 1.2 RI.)  It appears that the faces-config.xml in the jar
file is beaing read based on this:

2006-09-01 14:27:11,587 [main] INFO
org.apache.myfaces.config.FacesConfigurator - Reading config
jar:file:/D:/open-source/shale-goodies/shale-petstore/target/shale-petstore/WEB-INF/lib/shale-dialog2-1.0.4-SNAPSHOT.jar!/META-INF/faces-config.xml

Unfortunately, it does not appear that the handleNavigation method is
being called.  I'm also using the 1.0.4-SNAPSHOT of core but with the
decorated NavigationHandlers that shouldn't matter.

Maybe its possible that the method is getting called and my IDE
debugger isn't showing it.  I know that this command link certainly
isn't working:

h:commandLink action=dialog2:Checkout

Any ideas?

Sean


Re: Can't seem to get Dialog2NavigationHandler working

2006-09-01 Thread Craig McClanahan

On 9/1/06, Sean Schofield [EMAIL PROTECTED] wrote:


I can't seem to get Dialog2NavigationHandler working properly (I'm
using the 1.2 RI.)  It appears that the faces-config.xml in the jar
file is beaing read based on this:

2006-09-01 14:27:11,587 [main] INFO
org.apache.myfaces.config.FacesConfigurator - Reading config

jar:file:/D:/open-source/shale-goodies/shale-petstore/target/shale-petstore/WEB-INF/lib/shale-
dialog2-1.0.4-SNAPSHOT.jar!/META-INF/faces-config.xml

Unfortunately, it does not appear that the handleNavigation method is
being called.  I'm also using the 1.0.4-SNAPSHOT of core but with the
decorated NavigationHandlers that shouldn't matter.

Maybe its possible that the method is getting called and my IDE
debugger isn't showing it.  I know that this command link certainly
isn't working:

h:commandLink action=dialog2:Checkout

Any ideas?



It's probably a botched faces-config.xml file inside the
shale-dialog2-xxx.jar file ... if the custom navigation handler isn't
declared (or if the classname is wrong), it won't ever get invoked.

I'll take a look.

Sean





Craig


Re: Can't seem to get Dialog2NavigationHandler working

2006-09-01 Thread Sean Schofield

The nav handler is in fact declared and the classname seems correct to
me.  That was the first thing I checked.  Have you run an actual
dialog yet or are you still in the just getting things to compile
stage?

Sean

On 9/1/06, Craig McClanahan [EMAIL PROTECTED] wrote:

On 9/1/06, Sean Schofield [EMAIL PROTECTED] wrote:

 I can't seem to get Dialog2NavigationHandler working properly (I'm
 using the 1.2 RI.)  It appears that the faces-config.xml in the jar
 file is beaing read based on this:

 2006-09-01 14:27:11,587 [main] INFO
 org.apache.myfaces.config.FacesConfigurator - Reading config

 
jar:file:/D:/open-source/shale-goodies/shale-petstore/target/shale-petstore/WEB-INF/lib/shale-
 dialog2-1.0.4-SNAPSHOT.jar!/META-INF/faces-config.xml

 Unfortunately, it does not appear that the handleNavigation method is
 being called.  I'm also using the 1.0.4-SNAPSHOT of core but with the
 decorated NavigationHandlers that shouldn't matter.

 Maybe its possible that the method is getting called and my IDE
 debugger isn't showing it.  I know that this command link certainly
 isn't working:

 h:commandLink action=dialog2:Checkout

 Any ideas?


It's probably a botched faces-config.xml file inside the
shale-dialog2-xxx.jar file ... if the custom navigation handler isn't
declared (or if the classname is wrong), it won't ever get invoked.

I'll take a look.

Sean



Craig