SHALE-409 fix
Wendy, I have tested the patch in this way:
I have modified the private method afterRenderResponse of
ViewPhaseListener class:
private void afterRenderResponse(PhaseEvent event) {
// Initialize local values we will need
Map map =
event.getFacesContext().getExternalContext().getRequestMap();
// Remove our list of initialized views explicitly
map.remove(FacesConstants.VIEWS_INITIALIZED);
List list = new ArrayList();
Iterator entries = map.entrySet().iterator();
// First select all the ViewController and AbstractRequestBean
instances
while (entries.hasNext()) {
Map.Entry entry = (Map.Entry) entries.next();
if ((entry.getValue() instanceof ViewController)
|| (entry.getValue() instanceof AbstractRequestBean)) {
list.add(entry.getKey());
}
}
// Second select all remaining instances, which will include
annotated
// managed beans if Shale Tiger is present
/* COMMENTED BY BUONOPANE
entries = map.entrySet().iterator();
while (entries.hasNext()) {
Map.Entry entry = (Map.Entry) entries.next();
if (!list.contains(entry.getKey())) {
list.add(entry.getKey());
}
}*/
// Iterate through the keys in the specified order, removing the
// corresponding request scope attribute instances
Iterator keys = list.iterator();
while (keys.hasNext()) {
String key = (String) keys.next();
try {
log.info( removing +key);
map.remove(key);
} catch (Exception e) {
handleException(event.getFacesContext(), e);
}
}
}
I have just commented the line of the second loop identified by the
string COMMENTED BY BUONOPANE.
But I don't know if the loop I commented need to be modified.
What do you think?
Regards
Mario
-Original Message-
From: Wendy Smoak [mailto:[EMAIL PROTECTED]
Sent: 22 maggio 2007 17.33
To: [EMAIL PROTECTED]
Subject: Re: SHALE-409 fix
On 5/22/07, [EMAIL PROTECTED]
[EMAIL PROTECTED] wrote:
Antonio, I have tested the patch suggested by Matt Hughes at
http://issues.apache.org/struts/browse/SHALE-409.
Great! First, please come join us on the development list. We
generally keep the user list for discussion about using released
versions. You can find subscription info here, or you can post
through the Nabble forum interface:
http://shale.apache.org/mail-lists.html
What we need is a svn diff of your changes against the latest Shale
code. That's the quickest way for the developers to review and apply
changes contributed by the community.
Assuming you have the Shale 1.0.x branch checked out and have made
changes to it locally, execute svn diff SHALE-409.patch and attach
the patch file to the issue.
Thanks,
--
Wendy
This message is for the designated recipient only and may contain privileged,
proprietary, or otherwise private information. If you have received it in
error, please notify the sender immediately and delete the original. Any other
use of the email by you is prohibited.
Any one plans to fix SHALE-409 bug?
I have successfully tested to comment the second loop:
// Second select all remaining instances, which will include
annotated
// managed beans if Shale Tiger is present
/*
entries = map.entrySet().iterator();
while (entries.hasNext()) {
Map.Entry entry = (Map.Entry) entries.next();
if (!list.contains(entry.getKey())) {
list.add(entry.getKey());
}
}*/
Is there any one can try it and plans to release the fix?
Can I help you?
Thanks in advance
Mario
This message is for the designated recipient only and may contain privileged,
proprietary, or otherwise private information. If you have received it in
error, please notify the sender immediately and delete the original. Any other
use of the email by you is prohibited.
RE: Any one plans to fix SHALE-409 bug?
I think that the second loop is needed when using Shale Tiger so I think
is better put this code in shale-tiger.jar. In this way, developer (like
me) not using tiger extension does not need it.
Are u agree?
-Original Message-
From: Gary VanMatre [mailto:[EMAIL PROTECTED]
Sent: 26 giugno 2007 05.38
To: dev@shale.apache.org
Subject: Re: Any one plans to fix SHALE-409 bug?
From: [EMAIL PROTECTED]
I have successfully tested to comment the second loop:
// Second select all remaining instances, which will include
annotated
// managed beans if Shale Tiger is present
/*
entries = map.entrySet().iterator();
while (entries.hasNext()) {
Map.Entry entry = (Map.Entry) entries.next();
if (!list.contains(entry.getKey())) {
list.add(entry.getKey());
}
}*/
Is there any one can try it and plans to release the fix?
The problem with commenting out this loop is that we might
break someone else's application. The second loop forces
the destroy method to be invoked for beans with the @Destroy
annotation before the response has completed and the faces
context released.
I've been looking at this one off and on. At first I thought we
could just invoke the LifecycleListener from the ViewPhaseListener
but we don't have ServletContextEvent there.
Another option might be to add a destroy method to the
ViewControllerCallbacks class. This utility bean is registered as
a managed bean. The tiger library overrides the registered bean
to look for the @Preprocess and @Prerender runtime method
annotations. The ViewControllerCallbacks2 class would inspect
for the @Destroy annotation or the other interfaces.
We could remove the second loop and modify the first to use the
ViewControllerCallbacks bean.
Consider:
// First select all the ViewController and AbstractRequestBean
instances
while (entries.hasNext()) {
Map.Entry entry = (Map.Entry) entries.next();
if
(getViewControllerCallbacks(event.getFacesContext()).hasDestroy(entry.ge
tValue())) {
list.add(entry.getKey());
}
}
What do you think?
Can I help you?
Thanks in advance
Mario
This message is for the designated recipient only and may contain
privileged,
proprietary, or otherwise private information. If you have received it
in
error, please notify the sender immediately and delete the original.
Any other
use of the email by you is prohibited.
This message is for the designated recipient only and may contain privileged,
proprietary, or otherwise private information. If you have received it in
error, please notify the sender immediately and delete the original. Any other
use of the email by you is prohibited.
RE: Problem with replaceIdWithLabel
Probably I found the problem:
I have a main tile that use the t:messages tag before the tile:insert of
the page generating the messages.
When the first time the method getOutputLabelMap of HtmlMessageRenderer
is called, does not resolve the value.
If I move the t:messages after the tile:insert does work correctly.
May be a bug?
Regards
Mario
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED]
Sent: 10 luglio 2007 13.33
To: [EMAIL PROTECTED]
Subject: Problem with replaceIdWithLabel
Hi, I'm using replaceIdWithLabel attribute in t:messages but the
validation messages does not show the label (show the id).
I'm using tiles:
t:outputLabel for=dataSinistro
value=#{bundle.dataSinistro} /
t:inputCalendar id=dataSinistro
value=#{ricerche$ricercaPolizzePage.dataSinistro}
required=true /
t:message for=dataSinistro
replaceIdWithLabel=true/
na:messages id=messageList2 replaceIdWithLabel=true
showSummary=true showDetail=true globalOnly=false/
I have tried to debug HtmlMessageRenderer.findInputLabel method, and I
see that when execute this step:
MessageLabelInfo info =
((MessageLabelInfo)outputLabelMap.get(inputClientId));
The value of info.getText() is empty string ().
Is there any one can help me?
Thanks
Mario
This message is for the designated recipient only and may contain
privileged, proprietary, or otherwise private information. If you have
received it in error, please notify the sender immediately and delete
the original. Any other use of the email by you is prohibited.
This message is for the designated recipient only and may contain privileged,
proprietary, or otherwise private information. If you have received it in
error, please notify the sender immediately and delete the original. Any other
use of the email by you is prohibited.
RE: MyFaces
What is an umbrella project? Ciao, Mario -Original Message- From: Mario Ivankovits [mailto:[EMAIL PROTECTED] Sent: 18 ottobre 2007 07.40 To: dev@shale.apache.org Cc: [EMAIL PROTECTED] Subject: Re: MyFaces Kito D. Mann schrieb: So, here's a question. I know originally some people on the MyFaces team thought that Shale should be part of MyFaces. At the time, I know Craig wasn't interested. However, things have changed, and I think Shale could really benefit from the MyFaces community, especially since they are now starting to duplicate some of Shale's functionality (i.e. Orchestra's View Controller). I think this is a great idea. I always loved the idea that MyFaces is the umbrella project for JSF activities at Apache. Ciao, Mario This message is for the designated recipient only and may contain privileged, proprietary, or otherwise private information. If you have received it in error, please notify the sender immediately and delete the original. Any other use of the email by you is prohibited.
More dialogs in same time
My customer want two or more instance of the same dialogs on different windows. The problem is that the windows are created by the same browser (window.open) and with IE (for example) this windows condivide the same HttpSession. Is there a way to do it with Shale Dialog Manager? Thank in advance Mario This message is for the designated recipient only and may contain privileged, proprietary, or otherwise private information. If you have received it in error, please notify the sender immediately and delete the original. Any other use of the email by you is prohibited.
