[jira] [Updated] (SLING-6697) protected nodes show up as tenant in felix console

[Ankush Malhotra (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankush Malhotra updated SLING-6697:
---
Affects Version/s: (was: Tenant 1.1.0)
   Tenant 1.0.2

> protected nodes show up as tenant in felix console
> --
>
> Key: SLING-6697
> URL: https://issues.apache.org/jira/browse/SLING-6697
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Tenant 1.0.2
>Reporter: Ankush Malhotra
> Fix For: Tenant 1.1.0
>
>
> Protected nodes for acl also show up as a tenant
> * navigate to /etc/tenants and apply acl and save it
> * rep:policy node was created on /etc/tenants node
> * access tenant console (http://localhost:4502/system/console/tenants)
> Observed:
> rep:Policy node also displayed as a tenant row on tenant console
> Expected:
> rep:policy node should be not displayed



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (SLING-6697) protected nodes show up as tenant in felix console

[Ankush Malhotra (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankush Malhotra updated SLING-6697:
---
Fix Version/s: Tenant 1.1.0

> protected nodes show up as tenant in felix console
> --
>
> Key: SLING-6697
> URL: https://issues.apache.org/jira/browse/SLING-6697
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Tenant 1.0.2
>Reporter: Ankush Malhotra
> Fix For: Tenant 1.1.0
>
>
> Protected nodes for acl also show up as a tenant
> * navigate to /etc/tenants and apply acl and save it
> * rep:policy node was created on /etc/tenants node
> * access tenant console (http://localhost:4502/system/console/tenants)
> Observed:
> rep:Policy node also displayed as a tenant row on tenant console
> Expected:
> rep:policy node should be not displayed



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (SLING-6697) protected nodes show up as tenant in felix console

[Ankush Malhotra (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankush Malhotra resolved SLING-6697.

Resolution: Incomplete

> protected nodes show up as tenant in felix console
> --
>
> Key: SLING-6697
> URL: https://issues.apache.org/jira/browse/SLING-6697
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Tenant 1.1.0
>Reporter: Ankush Malhotra
>
> Protected nodes for acl also show up as a tenant
> * navigate to /etc/tenants and apply acl and save it
> * rep:policy node was created on /etc/tenants node
> * access tenant console (http://localhost:4502/system/console/tenants)
> Observed:
> rep:Policy node also displayed as a tenant row on tenant console
> Expected:
> rep:policy node should be not displayed



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6697) protected nodes show up as tenant in felix console

[Ankush Malhotra (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944573#comment-15944573
 ] 

Ankush Malhotra commented on SLING-6697:


[~marett] thanks for your response, sorry this was reported on 1.0.2 I see it 
is fixed in 1.1.0 with the use of service user

> protected nodes show up as tenant in felix console
> --
>
> Key: SLING-6697
> URL: https://issues.apache.org/jira/browse/SLING-6697
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Tenant 1.1.0
>Reporter: Ankush Malhotra
>
> Protected nodes for acl also show up as a tenant
> * navigate to /etc/tenants and apply acl and save it
> * rep:policy node was created on /etc/tenants node
> * access tenant console (http://localhost:4502/system/console/tenants)
> Observed:
> rep:Policy node also displayed as a tenant row on tenant console
> Expected:
> rep:policy node should be not displayed



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Maven dependency to org.apache.sling.commons.johnzon

[Carsten Ziegeler]

Karl Pauls wrote
> I agree. I'm not at the point where I can commit anything so all the
> patches are subject to clean-up and I wouldn't want them to get out
> before that. Carsten jumped the gun somewhat on this one but I'll
> clean-up when I'm ready to commit all of this.
> 
:) I just applied one of your patches to spare the pain of merging.
So what are the coordinates to use?

Carsten

> regards,
> 
> Karl
> 
> On Mon, Mar 27, 2017 at 8:52 PM, Justin Edelson
>  wrote:
>> As part of the Commons JSON migration (kudos to all those plugging away at
>> this thankless task), I see that some dependencies are being created
>> directly to org.apache.sling.commons.johnzon, e.g.
>> https://github.com/apache/sling/blob/trunk/bundles/extensions/adapter/pom.xml#L89
>> .
>>
>> IIUC, we should really be depending upon the javax.json API, not our
>> bundling of it. While I don't see any problems related to this right now,
>> it seems like we could end up accidentally creating a dependency to the
>> Johnzon implementation (or our wrapper of the Johnzon implementation).
>>
>> WDYT?
> 
> 
> 


 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: [VOTE] Release Apache Sling Testing Sling Mock 2.2.6, Sling Mock 1.9.6, Sling Mock Oak 2.0.2

[Carsten Ziegeler]

+1

 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: [VOTE] Release Apache Sling CAConfig Impl 1.3.2

[Carsten Ziegeler]

+1

 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Metrics in Sling

[Clelia Meneghin]

Hi

I added a Metric to the Sling Bundles resourceresolver and engine
Please review the issue [0], [1], [2], [3], [4], [5], [6], [7]

Regards,
Clelia

resourceresolver
[0] https://issues.apache.org/jira/browse/SLING-6729
[1] https://issues.apache.org/jira/browse/SLING-6730
[2] https://issues.apache.org/jira/browse/SLING-6731

engine
[3] https://issues.apache.org/jira/browse/SLING-6732
[4] https://issues.apache.org/jira/browse/SLING-6733
[5] https://issues.apache.org/jira/browse/SLING-6734
[6] https://issues.apache.org/jira/browse/SLING-6735
[7] https://issues.apache.org/jira/browse/SLING-6736

[jira] [Updated] (SLING-6736) Metrics mark and count HTTP-Responses

[Clelia Meneghin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Clelia Meneghin updated SLING-6736:
---
Attachment: patchSLING-6736.diff

> Metrics mark and count HTTP-Responses
> -
>
> Key: SLING-6736
> URL: https://issues.apache.org/jira/browse/SLING-6736
> Project: Sling
>  Issue Type: Test
>Reporter: Clelia Meneghin
>Priority: Trivial
> Attachments: patchSLING-6736.diff
>
>
> In the sling engine bundle are all HTTP-Status Codes counted and measures the 
> requests per second to the HTTP-Status-Response



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6736) Metrics mark and count HTTP-Responses

[Clelia Meneghin (JIRA)]

Clelia Meneghin created SLING-6736:
--

 Summary: Metrics mark and count HTTP-Responses
 Key: SLING-6736
 URL: https://issues.apache.org/jira/browse/SLING-6736
 Project: Sling
  Issue Type: Test
Reporter: Clelia Meneghin
Priority: Trivial


In the sling engine bundle are all HTTP-Status Codes counted and measures the 
requests per second to the HTTP-Status-Response



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (SLING-6735) Metric Count Authenticated and Anonymous Request

[Clelia Meneghin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Clelia Meneghin updated SLING-6735:
---
Attachment: patchSLING-6735.diff

> Metric Count Authenticated and Anonymous Request
> 
>
> Key: SLING-6735
> URL: https://issues.apache.org/jira/browse/SLING-6735
> Project: Sling
>  Issue Type: Test
>Reporter: Clelia Meneghin
> Attachments: patchSLING-6735.diff
>
>
> Count how many Requests to Sling are authenticated and how many are anonymous 
> in the sling engine bundle
> Doesn't work yet



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (SLING-6735) Metric Count Authenticated and Anonymous Request

[Clelia Meneghin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Clelia Meneghin updated SLING-6735:
---
Description: 
Count how many Requests to Sling are authenticated and how many are anonymous 
in the sling engine bundle
Doesn't work yet

  was:Count how many Requests to Sling are authenticated and how many are 
anonymous in the sling engine bundle


> Metric Count Authenticated and Anonymous Request
> 
>
> Key: SLING-6735
> URL: https://issues.apache.org/jira/browse/SLING-6735
> Project: Sling
>  Issue Type: Test
>Reporter: Clelia Meneghin
> Attachments: patchSLING-6735.diff
>
>
> Count how many Requests to Sling are authenticated and how many are anonymous 
> in the sling engine bundle
> Doesn't work yet



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6735) Metric Count Authenticated and Anonymous Request

[Clelia Meneghin (JIRA)]

Clelia Meneghin created SLING-6735:
--

 Summary: Metric Count Authenticated and Anonymous Request
 Key: SLING-6735
 URL: https://issues.apache.org/jira/browse/SLING-6735
 Project: Sling
  Issue Type: Test
Reporter: Clelia Meneghin


Count how many Requests to Sling are authenticated and how many are anonymous 
in the sling engine bundle



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (SLING-6734) Metrics create a Histogram of all filters

[Clelia Meneghin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Clelia Meneghin updated SLING-6734:
---
Attachment: patchSLING-6734.diff

> Metrics create a Histogram of all filters
> -
>
> Key: SLING-6734
> URL: https://issues.apache.org/jira/browse/SLING-6734
> Project: Sling
>  Issue Type: Test
>Reporter: Clelia Meneghin
>Priority: Trivial
> Attachments: patchSLING-6734.diff
>
>
> in the sling engine bundle 
> adding a new histogram to see the variation of filter



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6734) Metrics create a Histogram of all filters

[Clelia Meneghin (JIRA)]

Clelia Meneghin created SLING-6734:
--

 Summary: Metrics create a Histogram of all filters
 Key: SLING-6734
 URL: https://issues.apache.org/jira/browse/SLING-6734
 Project: Sling
  Issue Type: Test
Reporter: Clelia Meneghin
Priority: Trivial


in the sling engine bundle 
adding a new histogram to see the variation of filter



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (SLING-6733) Metric duration of a request

[Clelia Meneghin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Clelia Meneghin updated SLING-6733:
---
Attachment: patchSLING-6733.diff

> Metric duration of a request
> 
>
> Key: SLING-6733
> URL: https://issues.apache.org/jira/browse/SLING-6733
> Project: Sling
>  Issue Type: Test
>Reporter: Clelia Meneghin
>Priority: Trivial
> Attachments: patchSLING-6733.diff
>
>
> A Metric is added in the sling engine bundle where measure how long a request 
> needs



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6733) Metric duration of a request

[Clelia Meneghin (JIRA)]

Clelia Meneghin created SLING-6733:
--

 Summary: Metric duration of a request
 Key: SLING-6733
 URL: https://issues.apache.org/jira/browse/SLING-6733
 Project: Sling
  Issue Type: Test
Reporter: Clelia Meneghin
Priority: Trivial


A Metric is added in the sling engine bundle where measure how long a request 
needs



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (SLING-6732) Metric Request per Second Sling has to handle

[Clelia Meneghin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Clelia Meneghin updated SLING-6732:
---
Attachment: patchSLING-6732.diff

> Metric Request per Second Sling has to handle
> -
>
> Key: SLING-6732
> URL: https://issues.apache.org/jira/browse/SLING-6732
> Project: Sling
>  Issue Type: Test
>Reporter: Clelia Meneghin
>Priority: Trivial
> Attachments: patchSLING-6732.diff
>
>
> A Metrik is added to the SlingMainServlet in the engine bundle 
> It s measuring the request per second sling gets



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6732) Metric Request per Second Sling has to handle

[Clelia Meneghin (JIRA)]

Clelia Meneghin created SLING-6732:
--

 Summary: Metric Request per Second Sling has to handle
 Key: SLING-6732
 URL: https://issues.apache.org/jira/browse/SLING-6732
 Project: Sling
  Issue Type: Test
Reporter: Clelia Meneghin
Priority: Trivial


A Metrik is added to the SlingMainServlet in the engine bundle 
It s measuring the request per second sling gets



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Maven dependency to org.apache.sling.commons.johnzon

[Karl Pauls]

I agree. I'm not at the point where I can commit anything so all the
patches are subject to clean-up and I wouldn't want them to get out
before that. Carsten jumped the gun somewhat on this one but I'll
clean-up when I'm ready to commit all of this.

regards,

Karl

On Mon, Mar 27, 2017 at 8:52 PM, Justin Edelson
 wrote:
> As part of the Commons JSON migration (kudos to all those plugging away at
> this thankless task), I see that some dependencies are being created
> directly to org.apache.sling.commons.johnzon, e.g.
> https://github.com/apache/sling/blob/trunk/bundles/extensions/adapter/pom.xml#L89
> .
>
> IIUC, we should really be depending upon the javax.json API, not our
> bundling of it. While I don't see any problems related to this right now,
> it seems like we could end up accidentally creating a dependency to the
> Johnzon implementation (or our wrapper of the Johnzon implementation).
>
> WDYT?



-- 
Karl Pauls
karlpa...@gmail.com

[jira] [Updated] (SLING-6731) Metric increment counter when no resource is found

[Clelia Meneghin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Clelia Meneghin updated SLING-6731:
---
Attachment: patchSLING-6731.diff

> Metric increment counter when no resource is found
> --
>
> Key: SLING-6731
> URL: https://issues.apache.org/jira/browse/SLING-6731
> Project: Sling
>  Issue Type: Test
>Reporter: Clelia Meneghin
>Priority: Trivial
> Attachments: patchSLING-6731.diff
>
>
> Metric increment counter when no resource is found in the sling 
> resourceresolver bundle
> Gives Back Tests error when Building 
> will review this 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (SLING-6731) Metric increment counter when no resource is found

[Clelia Meneghin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Clelia Meneghin updated SLING-6731:
---
Description: 
Metric increment counter when no resource is found in the sling 
resourceresolver bundle
Gives Back Tests error when Building 
will review this 

  was:Metric increment counter when no resource is found in the sling 
resourceresolver bundle


> Metric increment counter when no resource is found
> --
>
> Key: SLING-6731
> URL: https://issues.apache.org/jira/browse/SLING-6731
> Project: Sling
>  Issue Type: Test
>Reporter: Clelia Meneghin
>Priority: Trivial
>
> Metric increment counter when no resource is found in the sling 
> resourceresolver bundle
> Gives Back Tests error when Building 
> will review this 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6731) Metric increment counter when no resource is found

[Clelia Meneghin (JIRA)]

Clelia Meneghin created SLING-6731:
--

 Summary: Metric increment counter when no resource is found
 Key: SLING-6731
 URL: https://issues.apache.org/jira/browse/SLING-6731
 Project: Sling
  Issue Type: Test
Reporter: Clelia Meneghin
Priority: Trivial


Metric increment counter when no resource is found in the sling 
resourceresolver bundle



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Maven dependency to org.apache.sling.commons.johnzon

[Justin Edelson]

As part of the Commons JSON migration (kudos to all those plugging away at
this thankless task), I see that some dependencies are being created
directly to org.apache.sling.commons.johnzon, e.g.
https://github.com/apache/sling/blob/trunk/bundles/extensions/adapter/pom.xml#L89
.

IIUC, we should really be depending upon the javax.json API, not our
bundling of it. While I don't see any problems related to this right now,
it seems like we could end up accidentally creating a dependency to the
Johnzon implementation (or our wrapper of the Johnzon implementation).

WDYT?

[jira] [Updated] (SLING-6730) Metrik Time Sling needs to get a Resource

[Clelia Meneghin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Clelia Meneghin updated SLING-6730:
---
Attachment: patchSLING-6730.diff

> Metrik Time Sling needs to get a Resource
> -
>
> Key: SLING-6730
> URL: https://issues.apache.org/jira/browse/SLING-6730
> Project: Sling
>  Issue Type: Test
>Reporter: Clelia Meneghin
>Priority: Trivial
> Attachments: patchSLING-6730.diff
>
>
> In the resourceresolver is a metric who measures the time sling needs to get 
> a Resource 
> There is a mistake in the code -> that's why it's out comment. Will review 
> this later. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6730) Metrik Time Sling needs to get a Resource

[Clelia Meneghin (JIRA)]

Clelia Meneghin created SLING-6730:
--

 Summary: Metrik Time Sling needs to get a Resource
 Key: SLING-6730
 URL: https://issues.apache.org/jira/browse/SLING-6730
 Project: Sling
  Issue Type: Test
Reporter: Clelia Meneghin
Priority: Trivial


In the resourceresolver is a metric who measures the time sling needs to get a 
Resource 
There is a mistake in the code -> that's why it's out comment. Will review this 
later. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (SLING-6679) Replace usage of org.apache.sling.commons.json.* and org.json

[Karl Pauls (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls updated SLING-6679:
--
Summary: Replace usage of org.apache.sling.commons.json.* and org.json  
(was: Replace usage of org.apache.sling.commons.json.*)

> Replace usage of org.apache.sling.commons.json.* and org.json
> -
>
> Key: SLING-6679
> URL: https://issues.apache.org/jira/browse/SLING-6679
> Project: Sling
>  Issue Type: Improvement
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>
> Following the deprecation of org.apache.sling.commons.json (SLING-6536) we 
> need to replace its usage everywhere else (at least if we want to be able to 
> release other modules that depend on it). 
> This is the umbrella issue for getting this done. The idea is to create 
> sub-issues with patches for individual components, review the patches, and 
> when all are done: close this issue. 
> General discussions and problems should go to this issue and specific ones on 
> the sub-issue in question.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6729) Metrik mark ResourceTypes

[Clelia Meneghin (JIRA)]

Clelia Meneghin created SLING-6729:
--

 Summary: Metrik mark ResourceTypes
 Key: SLING-6729
 URL: https://issues.apache.org/jira/browse/SLING-6729
 Project: Sling
  Issue Type: Test
 Environment: I inserted a metric to bundles/resourceresolver to 
measure the request per second for a specific resource type  
Patch diff is in the attachment
Reporter: Clelia Meneghin
Priority: Trivial
 Attachments: patch.diff





--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: [RT] Configurationless Sling?

[Oliver Lietz]

On Monday 27 March 2017 16:02:50 Carsten Ziegeler wrote:
> Hi,

Hi,

> for a long time we have tried to use sensible defaults for all of our
> configurations. This allows our users to run a default Sling without any
> additional configuration (it should even be possible to run it without a
> Configuration Admin service available - but that's another story).
> 
> While we were pretty successful with this, we simply blew it with the
> move from login administrative to service users. A lot of the (core)
> modules now use service users and these require a configured mapping in
> order to work properly. While for example the servlets resolver
> previously did not require any configuration, it requires at least the
> mapping. Which in turn means you can't simply use that module as-is.
> 
> Switching to service users is of course a good idea but I'm wondering if
> we can find a way to get back to a configurationless Sling again?
> 
> Clearly we don't want to the mapping to be part of the bundles using the
> service users.
> 
> One possible solution would be an out of the box bundle with the
> necessary repo init and configurations. This would cover the core
> bundles like servlets resolver and resource resolver.

we already have artifacts for all repoinit statements (bundle) and 
configurations.

I had to externalize all configurations for Karaf as features only support the 
simple cfg format inline (but Sling and Oak require newer Config Admin 
format):

https://github.com/apache/sling/tree/trunk/karaf/org.apache.sling.karaf-configs/src/main/resources

That said, Sling is one half only. The other half is Oak.

Configurations are part of a feature which get installed together with its 
bundles (and features) when using Sling's Karaf features.

The missing piece for repoinit (to make statements part of a feature) is a 
component which can be feed with "fragments" - similar to what we have for 
service user mappings and "login administrative" white listings (it's on my 
TODO). Currently all repoinit statements are executed when installing a sling-
launchpad-oak-* feature.

https://github.com/apache/sling/tree/trunk/karaf/org.apache.sling.karaf-repoinit/src/main/resources

Those repoinit statements and configurations are used by Testing PaxExam also, 
e.g. Option slingExtensionI18n() will provision all required bundles and 
configurations and in the near future also all repoinit statements.

Regards,
O.

> But maybe there is a better option?
> 
> Regards
> Carsten

Sling Eclipse Tooling and OSGi Bundle Content

[Andreas Schaefer Sr.]

Hi

I am wondering if the current Eclipse Tooling supports OSGi Bundle Content 
(through Sling-Initial-Content)?

If not are the any places to support them in the future?

Thanks - Andy Schaefer

[jira] [Commented] (SLING-4547) JcrResourceBundle does not support multiple base names

[Alexandre Lloret (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943567#comment-15943567
 ] 

Alexandre Lloret commented on SLING-4547:
-

Hi,

We have the same issue any news about the problem ?

Kinds Regards

> JcrResourceBundle does not support multiple base names
> --
>
> Key: SLING-4547
> URL: https://issues.apache.org/jira/browse/SLING-4547
> Project: Sling
>  Issue Type: Bug
>  Components: i18n
>Reporter: Andrei Pilets
>
> The sling:basename property may be multi-valued, that is the messages of a 
> mix:language nodes may belong to multiple base names and thus ResourceBundle 
> instances, as stated at 
> https://sling.apache.org/documentation/bundles/internationalization-support-i18n.html.
>  
> The latest codebase does not work in that way.
> JcrResourceBundle#loadPotentialLanguageRoots():
> if (baseName == null || baseName.equals(properties.get(PROP_BASENAME, ""))) {
>  paths.add(bundle.getPath());
> }
> In case if property sling:basename have multiple values, only the first base 
> name is considered, others are skipped.
> The correct implementation would be to use properties.get(PROP_BASENAME) - 
> method version without default value parameter, which would return array. You 
> would need to iterate over its items and check equality.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

RE: [VOTE] Release Apache Sling File System Resource Provider 2.0.0, File System Resource Provider 1.3.0

[Stefan Seifert]

+1

RE: [VOTE] Release Apache Sling Service User Mapper 1.2.6

[Stefan Seifert]

+1 

RE: [VOTE] Release Apache Sling ResourceResolver 1.5.22

[Stefan Seifert]

+1 

[VOTE] Release Apache Sling File System Resource Provider 2.0.0, File System Resource Provider 1.3.0

[Stefan Seifert]

Hi,

Apache Sling File System Resource Provider 2.0.0  (3 issues)
https://issues.apache.org/jira/browse/SLING/fixforversion/12339777

Apache Sling File System Resource Provider 1.3.0  (2 issues)
https://issues.apache.org/jira/browse/SLING/fixforversion/12338947

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1681/

You can use this UNIX script to download the release and verify the signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1681 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

stefan

[jira] [Commented] (SLING-6719) Add Server-Timing header to enable chrome log server timings

[Alexander Klimetschek (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943521#comment-15943521
 ] 

Alexander Klimetschek commented on SLING-6719:
--

The request progress tracker log could be dumped into the Server-Timings header 
(optional, off by default, as you probably don't want this by default). See 
thread https://twitter.com/cpilsworth/status/845760731278553089

If you want more info like MongoDB access times, these can then be added to the 
tracker log.

> Add Server-Timing header to enable chrome log server timings
> 
>
> Key: SLING-6719
> URL: https://issues.apache.org/jira/browse/SLING-6719
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
> Fix For: Log Tracer 1.0.2
>
>
> Chrome supports Server-Timing header [1] [2] to provide views around time 
> spent on server side for various sub calls as part of overall 
> request-response timing UI.
> We should utlilize that in Sling to log time data for e.g. remote calls made 
> to Mongo as part of given request processing.
> [1] https://w3c.github.io/server-timing/
> [2] https://ma.ttias.be/server-timings-chrome-devtools/



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

RE: [VOTE] Release Apache Sling CAConfig Impl 1.3.2

[Stefan Seifert]

+1

[VOTE] Release Apache Sling CAConfig Impl 1.3.2

[Stefan Seifert]

Hi,

We solved 3 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12340252

There are still some outstanding issues:
https://issues.apache.org/jira/browse/SLING/fixforversion/12340259

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1680/

You can use this UNIX script to download the release and verify the signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1680 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

stefan

RE: [VOTE] Release Apache Sling Testing Sling Mock 2.2.6, Sling Mock 1.9.6, Sling Mock Oak 2.0.2

[Stefan Seifert]

+1

[VOTE] Release Apache Sling Testing Sling Mock 2.2.6, Sling Mock 1.9.6, Sling Mock Oak 2.0.2

[Stefan Seifert]

Hi,

Apache Sling Testing Sling Mock 2.2.6  (3 issues)
https://issues.apache.org/jira/browse/SLING/fixforversion/12338880

Apache Sling Testing Sling Mock 1.9.6  (1 issue)
https://issues.apache.org/jira/browse/SLING/fixforversion/12338881

Apache Sling Testing Sling Mock Oak 1.0.2  (1 issue)
https://issues.apache.org/jira/browse/SLING/fixforversion/12333761

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1679/

You can use this UNIX script to download the release and verify the signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1679 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

stefan

Re: [RT] Configurationless Sling?

[Julian Sedding]

Hi Carsten

I fully agree with the intention of your email.

As a convention for service users, would it make sense to use the
bundle-symbolic-name as the user-ID (or principal-name)? If we can
detect the class name of the service that's creating the
Session/ResourceResolver, we could even use the fully qualified
classname. Not sure that there is a way other than inspecting the call
stack, however.


IIUC the service user mapping is only one part of the story. The other
part are the permissions required by a service user. I suppose
permissions are also a kind of configuration? So how would we go about
having a working default permission setup? Without that, a convention
for service users becomes kind of pointless. Or am I missing
something?

Regards
Julian


On Mon, Mar 27, 2017 at 4:02 PM, Carsten Ziegeler  wrote:
> Hi,
>
> for a long time we have tried to use sensible defaults for all of our
> configurations. This allows our users to run a default Sling without any
> additional configuration (it should even be possible to run it without a
> Configuration Admin service available - but that's another story).
>
> While we were pretty successful with this, we simply blew it with the
> move from login administrative to service users. A lot of the (core)
> modules now use service users and these require a configured mapping in
> order to work properly. While for example the servlets resolver
> previously did not require any configuration, it requires at least the
> mapping. Which in turn means you can't simply use that module as-is.
>
> Switching to service users is of course a good idea but I'm wondering if
> we can find a way to get back to a configurationless Sling again?
>
> Clearly we don't want to the mapping to be part of the bundles using the
> service users.
>
> One possible solution would be an out of the box bundle with the
> necessary repo init and configurations. This would cover the core
> bundles like servlets resolver and resource resolver.
>
> But maybe there is a better option?
>
> Regards
> Carsten
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org

[jira] [Updated] (SLING-5922) allow sling mock to load content from jcrvlt's xml

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert updated SLING-5922:
--
Fix Version/s: (was: Testing Sling Mock 1.10.0)
   (was: Testing Sling Mock 2.3.0)

> allow sling mock to load content from jcrvlt's xml
> --
>
> Key: SLING-5922
> URL: https://issues.apache.org/jira/browse/SLING-5922
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Reporter: Nicolas Peltier
>
> loading test content from json is super simple and cool, but as soon as you 
> have logical content in your project that is serialized in JCR-VLT format 
> (xml), this forces you to:
> - reproduce the application xml's content in a test json file,
> - synchronize both file in later maintenance
> we should allow tester to load mock content from an arbitrary path (not 
> necessarily resource), and accept JCR-VLT format



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (SLING-6728) sling-mock: Resource Resolver Type "NONE" does not work

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-6728.
---
Resolution: Fixed

Completed: At revision: 1788943  


> sling-mock: Resource Resolver Type "NONE" does not work
> ---
>
> Key: SLING-6728
> URL: https://issues.apache.org/jira/browse/SLING-6728
> Project: Sling
>  Issue Type: Bug
>  Components: Testing
>Affects Versions: Testing Sling Mock 2.2.4
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Minor
>  Labels: mocks
> Fix For: Testing Sling Mock 2.3.0
>
>
> support for the "NONE" resource resolver type is broken in sling mocks 2.x



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6728) sling-mock: Resource Resolver Type "NONE" does not work

[Stefan Seifert (JIRA)]

Stefan Seifert created SLING-6728:
-

 Summary: sling-mock: Resource Resolver Type "NONE" does not work
 Key: SLING-6728
 URL: https://issues.apache.org/jira/browse/SLING-6728
 Project: Sling
  Issue Type: Bug
  Components: Testing
Affects Versions: Testing Sling Mock 2.2.4
Reporter: Stefan Seifert
Assignee: Stefan Seifert
Priority: Minor
 Fix For: Testing Sling Mock 2.3.0


support for the "NONE" resource resolver type is broken in sling mocks 2.x



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6618) Specify crx.default as workspace for AEM servers

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943381#comment-15943381
 ] 

Konrad Windszus commented on SLING-6618:


3.1.38 was finally successfully released: 
http://search.maven.org/#artifactdetails%7Corg.apache.jackrabbit.vault%7Corg.apache.jackrabbit.vault%7C3.1.38%7Cbundle.

> Specify crx.default as workspace for AEM servers
> 
>
> Key: SLING-6618
> URL: https://issues.apache.org/jira/browse/SLING-6618
> Project: Sling
>  Issue Type: Bug
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.0.10
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Blocker
> Fix For: Sling Eclipse IDE 1.2.0
>
> Attachments: SLING-6618.patch
>
>
> The current impl-vlt does try to connect to two different repository urls - 
> one for sling and one for crx. In the case of the latter, it apparently needs 
> to subsequently give the default workspace name (crx.default) to the login 
> method - otherwise, trying to connect to the AEM server fails with 
> "precondition failed" messages.
> The full stack trace of the according {{RepositoryException}} looks like this
> {code}
> javax.jcr.lock.LockException: Precondition Failed
>   at 
> org.apache.jackrabbit.spi2dav.ExceptionConverter.generate(ExceptionConverter.java:109)
>   at 
> org.apache.jackrabbit.spi2dav.ExceptionConverter.generate(ExceptionConverter.java:51)
>   at 
> org.apache.jackrabbit.spi2dav.ExceptionConverter.generate(ExceptionConverter.java:45)
>   at 
> org.apache.jackrabbit.spi2dav.RepositoryServiceImpl.obtain(RepositoryServiceImpl.java:809)
>   at 
> org.apache.jackrabbit.spi2dav.RepositoryServiceImpl.obtain(RepositoryServiceImpl.java:753)
>   at 
> org.apache.jackrabbit.spi2davex.RepositoryServiceImpl.obtain(RepositoryServiceImpl.java:307)
>   at 
> org.apache.jackrabbit.jcr2spi.RepositoryImpl.login(RepositoryImpl.java:151)
>   at 
> org.apache.jackrabbit.commons.AbstractRepository.login(AbstractRepository.java:144)
>   at 
> org.apache.sling.ide.jcr.RepositoryUtils.getRepositoryAddress(RepositoryUtils.java:84)
>   at 
> org.apache.sling.ide.jcr.RepositoryUtils.getRepository(RepositoryUtils.java:44)
>   at 
> org.apache.sling.ide.impl.vlt.VltRepository.connect(VltRepository.java:70)
>   at 
> org.apache.sling.ide.impl.vlt.VltRepositoryFactory.connectRepository(VltRepositoryFactory.java:69)
>   at 
> org.apache.sling.ide.eclipse.core.ServerUtil.connectRepository(ServerUtil.java:146)
>   at 
> org.apache.sling.ide.eclipse.core.internal.SlingLaunchpadBehaviour.start(SlingLaunchpadBehaviour.java:95)
>   at 
> org.apache.sling.ide.eclipse.core.internal.SlingLaunchpadLaunchConfigurationDelegate.launch(SlingLaunchpadLaunchConfigurationDelegate.java:45)
>   at 
> org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:885)
>   at 
> org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:739)
>   at 
> org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:731)
>   at 
> org.eclipse.wst.server.core.internal.Server.startImpl2(Server.java:3541)
>   at 
> org.eclipse.wst.server.core.internal.Server.startImpl(Server.java:3477)
>   at 
> org.eclipse.wst.server.core.internal.Server$StartJob.run(Server.java:367)
>   at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
> Caused by: org.apache.jackrabbit.webdav.DavException: Precondition Failed
>   at 
> org.apache.jackrabbit.webdav.client.methods.DavMethodBase.getResponseException(DavMethodBase.java:162)
>   at 
> org.apache.jackrabbit.webdav.client.methods.DavMethodBase.getResponseBodyAsMultiStatus(DavMethodBase.java:91)
>   at 
> org.apache.jackrabbit.spi2dav.RepositoryServiceImpl.obtain(RepositoryServiceImpl.java:781)
>   ... 18 more
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[RT] Configurationless Sling?

[Carsten Ziegeler]

Hi,

for a long time we have tried to use sensible defaults for all of our
configurations. This allows our users to run a default Sling without any
additional configuration (it should even be possible to run it without a
Configuration Admin service available - but that's another story).

While we were pretty successful with this, we simply blew it with the
move from login administrative to service users. A lot of the (core)
modules now use service users and these require a configured mapping in
order to work properly. While for example the servlets resolver
previously did not require any configuration, it requires at least the
mapping. Which in turn means you can't simply use that module as-is.

Switching to service users is of course a good idea but I'm wondering if
we can find a way to get back to a configurationless Sling again?

Clearly we don't want to the mapping to be part of the bundles using the
service users.

One possible solution would be an out of the box bundle with the
necessary repo init and configurations. This would cover the core
bundles like servlets resolver and resource resolver.

But maybe there is a better option?

Regards
Carsten
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[jira] [Resolved] (SLING-6725) Building validation core fails with test errors

[Konrad Windszus (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus resolved SLING-6725.

Resolution: Fixed

> Building validation core fails with test errors
> ---
>
> Key: SLING-6725
> URL: https://issues.apache.org/jira/browse/SLING-6725
> Project: Sling
>  Issue Type: Bug
>  Components: Validation
>Reporter: Karl Pauls
>Assignee: Oliver Lietz
> Fix For: Validation 1.0.0
>
>
> Doing:
> cd bundles/extensions/validation/core 
> mvn clean install
> fails with test errors.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (SLING-6725) Building validation core fails with test errors

[Konrad Windszus (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-6725:
---
Fix Version/s: Validation 1.0.0

> Building validation core fails with test errors
> ---
>
> Key: SLING-6725
> URL: https://issues.apache.org/jira/browse/SLING-6725
> Project: Sling
>  Issue Type: Bug
>  Components: Validation
>Reporter: Karl Pauls
>Assignee: Oliver Lietz
> Fix For: Validation 1.0.0
>
>
> Doing:
> cd bundles/extensions/validation/core 
> mvn clean install
> fails with test errors.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6725) Building validation core fails with test errors

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943258#comment-15943258
 ] 

Konrad Windszus commented on SLING-6725:


Build no longer exposes any test errors: 
https://builds.apache.org/job/sling-bundles-extensions-validation-core-1.8/77/.

> Building validation core fails with test errors
> ---
>
> Key: SLING-6725
> URL: https://issues.apache.org/jira/browse/SLING-6725
> Project: Sling
>  Issue Type: Bug
>  Components: Validation
>Reporter: Karl Pauls
>Assignee: Oliver Lietz
> Fix For: Validation 1.0.0
>
>
> Doing:
> cd bundles/extensions/validation/core 
> mvn clean install
> fails with test errors.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (SLING-6660) Validators should expose their id and severity

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-6660.
-
Resolution: Won't Fix

> Validators should expose their id and severity
> --
>
> Key: SLING-6660
> URL: https://issues.apache.org/jira/browse/SLING-6660
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions, Validation
>Reporter: Oliver Lietz
>
> {{Validator}}s should expose their {{id}} and {{severity}} (maybe from 
> service properties, but haven't to be service properties at all) by their own:
> {noformat}
> [...]
> public interface Validator  {
> [...]
> String getId(); // validator.id
> int getSeverity(); // validator.severity
> [...]
> }
> {noformat}
> This addition allows less code in {{ValidationModelRetrieverImpl}} and makes 
> {{ValidatorAndSeverity}} obsolete.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6660) Validators should expose their id and severity

[Oliver Lietz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943168#comment-15943168
 ] 

Oliver Lietz commented on SLING-6660:
-

Looks much better now. Thanks, [~kwin]!

> Validators should expose their id and severity
> --
>
> Key: SLING-6660
> URL: https://issues.apache.org/jira/browse/SLING-6660
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions, Validation
>Reporter: Oliver Lietz
>
> {{Validator}}s should expose their {{id}} and {{severity}} (maybe from 
> service properties, but haven't to be service properties at all) by their own:
> {noformat}
> [...]
> public interface Validator  {
> [...]
> String getId(); // validator.id
> int getSeverity(); // validator.severity
> [...]
> }
> {noformat}
> This addition allows less code in {{ValidationModelRetrieverImpl}} and makes 
> {{ValidatorAndSeverity}} obsolete.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (SLING-6660) Validators should expose their id and severity

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz closed SLING-6660.
---

> Validators should expose their id and severity
> --
>
> Key: SLING-6660
> URL: https://issues.apache.org/jira/browse/SLING-6660
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions, Validation
>Reporter: Oliver Lietz
>
> {{Validator}}s should expose their {{id}} and {{severity}} (maybe from 
> service properties, but haven't to be service properties at all) by their own:
> {noformat}
> [...]
> public interface Validator  {
> [...]
> String getId(); // validator.id
> int getSeverity(); // validator.severity
> [...]
> }
> {noformat}
> This addition allows less code in {{ValidationModelRetrieverImpl}} and makes 
> {{ValidatorAndSeverity}} obsolete.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6727) Align accessors in API

[Oliver Lietz (JIRA)]

Oliver Lietz created SLING-6727:
---

 Summary: Align accessors in API
 Key: SLING-6727
 URL: https://issues.apache.org/jira/browse/SLING-6727
 Project: Sling
  Issue Type: Improvement
  Components: Extensions, Validation
Reporter: Oliver Lietz
 Fix For: Validation 1.0.0


We currently have {{getValidationModel(...)}} and 
{{getModel(...)}}/{{getModels(...)}}, but should use one or the other.

Also we should remove _Validated_ from 
{{ValidationModel#getValidatedResourceType()}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6725) Building validation core fails with test errors

[Oliver Lietz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943147#comment-15943147
 ] 

Oliver Lietz commented on SLING-6725:
-

Broken by [~kwin]' commit [r1788240|https://svn.apache.org/r1788240]: missing 
colon for path directive.

> Building validation core fails with test errors
> ---
>
> Key: SLING-6725
> URL: https://issues.apache.org/jira/browse/SLING-6725
> Project: Sling
>  Issue Type: Bug
>  Components: Validation
>Reporter: Karl Pauls
>Assignee: Oliver Lietz
>
> Doing:
> cd bundles/extensions/validation/core 
> mvn clean install
> fails with test errors.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6725) Building validation core fails with test errors

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943145#comment-15943145
 ] 

Konrad Windszus commented on SLING-6725:


Sorry, my fault, should be fixed with 
[r1788918|https://svn.apache.org/r1788918].

> Building validation core fails with test errors
> ---
>
> Key: SLING-6725
> URL: https://issues.apache.org/jira/browse/SLING-6725
> Project: Sling
>  Issue Type: Bug
>  Components: Validation
>Reporter: Karl Pauls
>Assignee: Oliver Lietz
>
> Doing:
> cd bundles/extensions/validation/core 
> mvn clean install
> fails with test errors.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6723) Make dependency to javax.jcr, jcr.contentloader and jcr.api optional

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943131#comment-15943131
 ] 

Bertrand Delacretaz commented on SLING-6723:


I like the idea but we should make sure meaningful log messages are emitted if 
the optional packages are missing - I suppose ugly things might happen 
internally in this case, which might by default lead to mysterious errors.

I'm happy to be proven wrong though...just want to make sure we're not 
introducing hard to troubleshoot failure modes.

> Make dependency to javax.jcr, jcr.contentloader and jcr.api optional
> 
>
> Key: SLING-6723
> URL: https://issues.apache.org/jira/browse/SLING-6723
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Servlets Post 2.3.16
>
>
> In order to be able to run Sling in a very minimal version, the dependencies 
> to javax.jcr, jcr.api and jcr.contentloader should be optional. Otherwise a 
> whole set of modules needs to be dragged in just to make the servlets post 
> module provide the basic functionality (which is usually sufficient for most 
> applications)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (SLING-6726) Updated commons-lang3 to 3.5

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-6726.
-
Resolution: Fixed

Done in rev 1788916

> Updated commons-lang3 to 3.5
> 
>
> Key: SLING-6726
> URL: https://issues.apache.org/jira/browse/SLING-6726
> Project: Sling
>  Issue Type: Improvement
>  Components: Launchpad
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Launchpad Builder 9
>
>
> We should update from 3.4 to 3.5



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6726) Updated commons-lang3 to 3.5

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-6726:
---

 Summary: Updated commons-lang3 to 3.5
 Key: SLING-6726
 URL: https://issues.apache.org/jira/browse/SLING-6726
 Project: Sling
  Issue Type: Improvement
  Components: Launchpad
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Launchpad Builder 9


We should update from 3.4 to 3.5



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (SLING-6687) Replace commons.json usage in org.apache.sling.adapter

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-6687.
-
Resolution: Fixed

I've applied the patch in rev 1788910 as it would require some changes to use 
the simple JSONWriter. So applying the patch is more straight forward. In the 
future we can have a look where we can avoid the external dependency to the 
json library.
In addition I've migrated to parent pom 30, R6 OSGi annotations and commons 
lang3

> Replace commons.json usage in org.apache.sling.adapter
> --
>
> Key: SLING-6687
> URL: https://issues.apache.org/jira/browse/SLING-6687
> Project: Sling
>  Issue Type: Sub-task
>  Components: Extensions
>Affects Versions: Adapter 2.1.8
>Reporter: Karl Pauls
>Assignee: Carsten Ziegeler
>  Labels: patch-available
> Fix For: Adapter 2.1.10
>
> Attachments: SLING-6687.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6709) The HAPI implementation doesn't provide the correct attribute type for "itemscope"

[Andrei Dulvac (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943107#comment-15943107
 ] 

Andrei Dulvac commented on SLING-6709:
--

Added unit test in r1788906

> The HAPI implementation doesn't provide the correct attribute type for 
> "itemscope"
> --
>
> Key: SLING-6709
> URL: https://issues.apache.org/jira/browse/SLING-6709
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: HApi 1.0.0
>Reporter: Radu Cotescu
>Assignee: Andrei Dulvac
>
> The microdata specification defines the {{itemscope}} attribute as boolean 
> [0]. However, the current Sling implementation returns a string, leading to 
> invalid HTML 5 markup.
> [0] - https://www.w3.org/TR/microdata/#attr-itemscope



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6724) Scripting core build fails with "ServiceLookup gave up" during tests

[Oliver Lietz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943100#comment-15943100
 ] 

Oliver Lietz commented on SLING-6724:
-

Build failure is related to Sling Parent 30. Switching to OSGi annotations and 
upgrading some dependencies to fix it.

> Scripting core build fails with "ServiceLookup gave up" during tests
> 
>
> Key: SLING-6724
> URL: https://issues.apache.org/jira/browse/SLING-6724
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Karl Pauls
>Assignee: Oliver Lietz
>
> Doing:
> {noformat}
> cd bundles/scripting/core
> mvn clean install
> {noformat}
> fails with test errors.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (SLING-6724) Scripting core build fails with "ServiceLookup gave up" during tests

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz updated SLING-6724:

Description: 
Doing:

{noformat}
cd bundles/scripting/core
mvn clean install
{noformat}

fails with test errors.

  was:
Doing:

cd bundles/extensions/validation/core
mvn clean install

fails with test errors.


> Scripting core build fails with "ServiceLookup gave up" during tests
> 
>
> Key: SLING-6724
> URL: https://issues.apache.org/jira/browse/SLING-6724
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Karl Pauls
>Assignee: Oliver Lietz
>
> Doing:
> {noformat}
> cd bundles/scripting/core
> mvn clean install
> {noformat}
> fails with test errors.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (SLING-6724) Scripting core build fails with "ServiceLookup gave up" during tests

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz reassigned SLING-6724:
---

Assignee: Oliver Lietz

> Scripting core build fails with "ServiceLookup gave up" during tests
> 
>
> Key: SLING-6724
> URL: https://issues.apache.org/jira/browse/SLING-6724
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Karl Pauls
>Assignee: Oliver Lietz
>
> Doing:
> cd bundles/extensions/validation/core
> mvn clean install
> fails with test errors.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (SLING-6725) Building validation core fails with test errors

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz reassigned SLING-6725:
---

Assignee: Oliver Lietz

> Building validation core fails with test errors
> ---
>
> Key: SLING-6725
> URL: https://issues.apache.org/jira/browse/SLING-6725
> Project: Sling
>  Issue Type: Bug
>  Components: Validation
>Reporter: Karl Pauls
>Assignee: Oliver Lietz
>
> Doing:
> cd bundles/extensions/validation/core 
> mvn clean install
> fails with test errors.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6687) Replace commons.json usage in org.apache.sling.adapter

[Karl Pauls (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943077#comment-15943077
 ] 

Karl Pauls commented on SLING-6687:
---

Fine by me. Makes sense as this is related to the webconsole anyhow.

> Replace commons.json usage in org.apache.sling.adapter
> --
>
> Key: SLING-6687
> URL: https://issues.apache.org/jira/browse/SLING-6687
> Project: Sling
>  Issue Type: Sub-task
>  Components: Extensions
>Affects Versions: Adapter 2.1.8
>Reporter: Karl Pauls
>Assignee: Carsten Ziegeler
>  Labels: patch-available
> Fix For: Adapter 2.1.10
>
> Attachments: SLING-6687.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6687) Replace commons.json usage in org.apache.sling.adapter

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943075#comment-15943075
 ] 

Carsten Ziegeler commented on SLING-6687:
-

I think we don't need johnzon here but can just embed the felix.utils 
JSONWriter class

> Replace commons.json usage in org.apache.sling.adapter
> --
>
> Key: SLING-6687
> URL: https://issues.apache.org/jira/browse/SLING-6687
> Project: Sling
>  Issue Type: Sub-task
>  Components: Extensions
>Affects Versions: Adapter 2.1.8
>Reporter: Karl Pauls
>Assignee: Carsten Ziegeler
>  Labels: patch-available
> Fix For: Adapter 2.1.10
>
> Attachments: SLING-6687.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (SLING-6687) Replace commons.json usage in org.apache.sling.adapter

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reassigned SLING-6687:
---

Assignee: Carsten Ziegeler  (was: Karl Pauls)

> Replace commons.json usage in org.apache.sling.adapter
> --
>
> Key: SLING-6687
> URL: https://issues.apache.org/jira/browse/SLING-6687
> Project: Sling
>  Issue Type: Sub-task
>  Components: Extensions
>Affects Versions: Adapter 2.1.8
>Reporter: Karl Pauls
>Assignee: Carsten Ziegeler
>  Labels: patch-available
> Fix For: Adapter 2.1.10
>
> Attachments: SLING-6687.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6725) Building validation core fails with test errors

[Karl Pauls (JIRA)]

Karl Pauls created SLING-6725:
-

 Summary: Building validation core fails with test errors
 Key: SLING-6725
 URL: https://issues.apache.org/jira/browse/SLING-6725
 Project: Sling
  Issue Type: Bug
  Components: Validation
Reporter: Karl Pauls


Doing:

cd bundles/extensions/validation/core 
mvn clean install

fails with test errors.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6724) Scripting core build fails with "ServiceLookup gave up" during tests

[Karl Pauls (JIRA)]

Karl Pauls created SLING-6724:
-

 Summary: Scripting core build fails with "ServiceLookup gave up" 
during tests
 Key: SLING-6724
 URL: https://issues.apache.org/jira/browse/SLING-6724
 Project: Sling
  Issue Type: Bug
  Components: Scripting
Reporter: Karl Pauls


Doing:

cd bundles/extensions/validation/core
mvn clean install

fails with test errors.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6723) Make dependency to javax.jcr, jcr.contentloader and jcr.api optional

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-6723:
---

 Summary: Make dependency to javax.jcr, jcr.contentloader and 
jcr.api optional
 Key: SLING-6723
 URL: https://issues.apache.org/jira/browse/SLING-6723
 Project: Sling
  Issue Type: Improvement
  Components: Servlets
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Servlets Post 2.3.16


In order to be able to run Sling in a very minimal version, the dependencies to 
javax.jcr, jcr.api and jcr.contentloader should be optional. Otherwise a whole 
set of modules needs to be dragged in just to make the servlets post module 
provide the basic functionality (which is usually sufficient for most 
applications)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (SLING-6722) Deprecate AbstractPostOperation

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-6722.
-
Resolution: Fixed

Deprecated in rev 1788892

> Deprecate AbstractPostOperation
> ---
>
> Key: SLING-6722
> URL: https://issues.apache.org/jira/browse/SLING-6722
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Servlets Post 2.3.16
>
>
> The abstract class AbstractPostOperation is using javax.jcr api and therefore 
> creates a mixture between Sling's resource API and the JCR api. As we should 
> provide clear guidance to our clients, we should avoid this mixture.
> Therefore we should deprecate this class



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6722) Deprecate AbstractPostOperation

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-6722:
---

 Summary: Deprecate AbstractPostOperation
 Key: SLING-6722
 URL: https://issues.apache.org/jira/browse/SLING-6722
 Project: Sling
  Issue Type: Improvement
  Components: Servlets
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Servlets Post 2.3.16


The abstract class AbstractPostOperation is using javax.jcr api and therefore 
creates a mixture between Sling's resource API and the JCR api. As we should 
provide clear guidance to our clients, we should avoid this mixture.
Therefore we should deprecate this class



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6721) Migrate to R6 annotations, clean up dependencies

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-6721:
---

 Summary: Migrate to R6 annotations, clean up dependencies
 Key: SLING-6721
 URL: https://issues.apache.org/jira/browse/SLING-6721
 Project: Sling
  Issue Type: Improvement
  Components: Servlets
Reporter: Carsten Ziegeler
 Fix For: Servlets Post 2.3.16






--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (SLING-6720) Deprecate PostResponseWithErrorHandling

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-6720.
-
Resolution: Fixed

Deprecated in rev 176 and 177

> Deprecate PostResponseWithErrorHandling
> ---
>
> Key: SLING-6720
> URL: https://issues.apache.org/jira/browse/SLING-6720
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Servlets Post 2.3.16
>
>
> As part of SLING-2156 PostResponseWithErrorHandling has been added to the 
> public API, however as this is a component I think it should have never been 
> added to the API, but just the impl.
> Therefore we should move it to the impl and deprecate it in the API



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6720) Deprecate PostResponseWithErrorHandling

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-6720:
---

 Summary: Deprecate PostResponseWithErrorHandling
 Key: SLING-6720
 URL: https://issues.apache.org/jira/browse/SLING-6720
 Project: Sling
  Issue Type: Improvement
  Components: Servlets
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Servlets Post 2.3.16


As part of SLING-2156 PostResponseWithErrorHandling has been added to the 
public API, however as this is a component I think it should have never been 
added to the API, but just the impl.
Therefore we should move it to the impl and deprecate it in the API



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (SLING-6675) Sling parent pom 30 breaks o.a.s.engine bundle - empty SCR metadata

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-6675.
-
Resolution: Duplicate

> Sling parent pom 30 breaks o.a.s.engine bundle - empty SCR metadata
> ---
>
> Key: SLING-6675
> URL: https://issues.apache.org/jira/browse/SLING-6675
> Project: Sling
>  Issue Type: Bug
>  Components: Engine
>Reporter: Bertrand Delacretaz
>Priority: Minor
>
> For now I'll revert the bundles/engine pom to use our parent pom 29 as with 
> the current version 30 the generated 
> {{org.apache.sling.engine.impl.SlingMainServlet.xml}} is empty.
> The visible effects are Sling returning a 404 on all requests, as the 
> SlingMainServlet is not registered and the default OSGi HTTP service gets the 
> request.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6719) Add Server-Timing header to enable chrome log server timings

[Chetan Mehrotra (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942997#comment-15942997
 ] 

Chetan Mehrotra commented on SLING-6719:


Got to know from [~alexander.klimetschek] 

/cc [~empire29]

> Add Server-Timing header to enable chrome log server timings
> 
>
> Key: SLING-6719
> URL: https://issues.apache.org/jira/browse/SLING-6719
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
> Fix For: Log Tracer 1.0.2
>
>
> Chrome supports Server-Timing header [1] [2] to provide views around time 
> spent on server side for various sub calls as part of overall 
> request-response timing UI.
> We should utlilize that in Sling to log time data for e.g. remote calls made 
> to Mongo as part of given request processing.
> [1] https://w3c.github.io/server-timing/
> [2] https://ma.ttias.be/server-timings-chrome-devtools/



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6719) Add Server-Timing header to enable chrome log server timings

[Chetan Mehrotra (JIRA)]

Chetan Mehrotra created SLING-6719:
--

 Summary: Add Server-Timing header to enable chrome log server 
timings
 Key: SLING-6719
 URL: https://issues.apache.org/jira/browse/SLING-6719
 Project: Sling
  Issue Type: New Feature
  Components: Extensions
Reporter: Chetan Mehrotra
Assignee: Chetan Mehrotra
 Fix For: Log Tracer 1.0.2


Chrome supports Server-Timing header [1] [2] to provide views around time spent 
on server side for various sub calls as part of overall request-response timing 
UI.

We should utlilize that in Sling to log time data for e.g. remote calls made to 
Mongo as part of given request processing.


[1] https://w3c.github.io/server-timing/
[2] https://ma.ttias.be/server-timings-chrome-devtools/



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6167) Pass new properties hint to JcrResourceListener

[Stefan Egli (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942983#comment-15942983
 ] 

Stefan Egli commented on SLING-6167:


Added and linked to OAK-5990

> Pass new properties hint to JcrResourceListener
> ---
>
> Key: SLING-6167
> URL: https://issues.apache.org/jira/browse/SLING-6167
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR Resource 2.8.0
>Reporter: Stefan Egli
>
> With SLING-6164 there's now support for a _property names hint_ in the 
> ResourceChangeListener. So far without implementation though. This ticket is 
> about implementing this for JCR Resource. It depends on support from oak 
> though (ticket link tbd)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (SLING-6718) Use commons collections 4

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-6718.
-
Resolution: Fixed

Updated in rev 1788873

> Use commons collections 4
> -
>
> Key: SLING-6718
> URL: https://issues.apache.org/jira/browse/SLING-6718
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Resource Resolver 1.5.24
>
>
> We should move to the newer commons collections 4 and not use the legacy 3.x 
> version anymore



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6718) Use commons collections 4

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-6718:
---

 Summary: Use commons collections 4
 Key: SLING-6718
 URL: https://issues.apache.org/jira/browse/SLING-6718
 Project: Sling
  Issue Type: Improvement
  Components: ResourceResolver
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Resource Resolver 1.5.24


We should move to the newer commons collections 4 and not use the legacy 3.x 
version anymore



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (SLING-6717) Use commons lang3

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-6717:

Component/s: ResourceResolver

> Use commons lang3
> -
>
> Key: SLING-6717
> URL: https://issues.apache.org/jira/browse/SLING-6717
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver, Servlets
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Servlets Resolver 2.4.12, Servlets Get 2.1.24, Resource 
> Resolver 1.5.24
>
>
> We should move to the newer commons.lang3 and not use the legacy commons.lang 
> anymore



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6717) Use commons lang3

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942970#comment-15942970
 ] 

Carsten Ziegeler commented on SLING-6717:
-

Updated resource resolver in rev 1788870

> Use commons lang3
> -
>
> Key: SLING-6717
> URL: https://issues.apache.org/jira/browse/SLING-6717
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver, Servlets
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Servlets Resolver 2.4.12, Servlets Get 2.1.24, Resource 
> Resolver 1.5.24
>
>
> We should move to the newer commons.lang3 and not use the legacy commons.lang 
> anymore



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (SLING-6709) The HAPI implementation doesn't provide the correct attribute type for "itemscope"

[Andrei Dulvac (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac resolved SLING-6709.
--
Resolution: Fixed

Resolved in r1788868

> The HAPI implementation doesn't provide the correct attribute type for 
> "itemscope"
> --
>
> Key: SLING-6709
> URL: https://issues.apache.org/jira/browse/SLING-6709
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: HApi 1.0.0
>Reporter: Radu Cotescu
>Assignee: Andrei Dulvac
>
> The microdata specification defines the {{itemscope}} attribute as boolean 
> [0]. However, the current Sling implementation returns a string, leading to 
> invalid HTML 5 markup.
> [0] - https://www.w3.org/TR/microdata/#attr-itemscope



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (SLING-6717) Use commons lang3

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-6717:

Fix Version/s: Resource Resolver 1.5.24

> Use commons lang3
> -
>
> Key: SLING-6717
> URL: https://issues.apache.org/jira/browse/SLING-6717
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Servlets Resolver 2.4.12, Servlets Get 2.1.24, Resource 
> Resolver 1.5.24
>
>
> We should move to the newer commons.lang3 and not use the legacy commons.lang 
> anymore



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Comment Edited] (SLING-6717) Use commons lang3

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942956#comment-15942956
 ] 

Carsten Ziegeler edited comment on SLING-6717 at 3/27/17 9:52 AM:
--

Updated in rev 1788864 for servlets.resolver
in rev 1788867 for servlets.get


was (Author: cziegeler):
Updated in rev 1788864

> Use commons lang3
> -
>
> Key: SLING-6717
> URL: https://issues.apache.org/jira/browse/SLING-6717
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Servlets Resolver 2.4.12, Servlets Get 2.1.24
>
>
> We should move to the newer commons.lang3 and not use the legacy commons.lang 
> anymore



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (SLING-6717) Use commons lang3

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-6717:

Fix Version/s: Servlets Get 2.1.24

> Use commons lang3
> -
>
> Key: SLING-6717
> URL: https://issues.apache.org/jira/browse/SLING-6717
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Servlets Resolver 2.4.12, Servlets Get 2.1.24
>
>
> We should move to the newer commons.lang3 and not use the legacy commons.lang 
> anymore



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (SLING-6649) Enable Felix SCR BndTools plugin

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz closed SLING-6649.
---

> Enable Felix SCR BndTools plugin
> 
>
> Key: SLING-6649
> URL: https://issues.apache.org/jira/browse/SLING-6649
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Affects Versions: Parent 30
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>
> The [Felix SCR BndTools 
> plugin|http://felix.apache.org/documentation/subprojects/apache-felix-maven-scr-plugin/apache-felix-scr-bndtools-use.html]
>  is currently disabled in Sling Parent:
> {noformat}
> [...]
> 
> ${sling.bree}
> 
> 
> <_plugin>org.apache.felix.bundleplugin.BlueprintPlugin,aQute.lib.spring.SpringXMLType
> 
> [...]
> {noformat}
> I tried several configurations to restore a working build of 
> {{org.apache.sling.event}} with {{maven-scr-plugin}} *and* 
> {{maven-bundle-plugin}} including testing (missing SCR descriptors) to no 
> avail and finally removed {{maven-scr-plugin}} and enabled 
> {{org.apache.felix.scrplugin.bnd.SCRDescriptorBndPlugin}} in [r1787036 
> |https://svn.apache.org/r1787036].
> Using Felix SCR BndTools plugin is a quick fix obviously before switching to 
> official OSGi annotations.
> We should enable Felix SCR BndTools plugin to not block modules upgrading to 
> Sling Parent >= 30 (without reconfiguring Maven Bundle Plugin in their own 
> POMs or switching to official OSGi annotations).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (SLING-6717) Use commons lang3

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-6717.
-
Resolution: Fixed

Updated in rev 1788864

> Use commons lang3
> -
>
> Key: SLING-6717
> URL: https://issues.apache.org/jira/browse/SLING-6717
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Servlets Resolver 2.4.12
>
>
> We should move to the newer commons.lang3 and not use the legacy commons.lang 
> anymore



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (SLING-6649) Enable Felix SCR BndTools plugin

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-6649.
-
Resolution: Won't Fix

> Enable Felix SCR BndTools plugin
> 
>
> Key: SLING-6649
> URL: https://issues.apache.org/jira/browse/SLING-6649
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Affects Versions: Parent 30
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>
> The [Felix SCR BndTools 
> plugin|http://felix.apache.org/documentation/subprojects/apache-felix-maven-scr-plugin/apache-felix-scr-bndtools-use.html]
>  is currently disabled in Sling Parent:
> {noformat}
> [...]
> 
> ${sling.bree}
> 
> 
> <_plugin>org.apache.felix.bundleplugin.BlueprintPlugin,aQute.lib.spring.SpringXMLType
> 
> [...]
> {noformat}
> I tried several configurations to restore a working build of 
> {{org.apache.sling.event}} with {{maven-scr-plugin}} *and* 
> {{maven-bundle-plugin}} including testing (missing SCR descriptors) to no 
> avail and finally removed {{maven-scr-plugin}} and enabled 
> {{org.apache.felix.scrplugin.bnd.SCRDescriptorBndPlugin}} in [r1787036 
> |https://svn.apache.org/r1787036].
> Using Felix SCR BndTools plugin is a quick fix obviously before switching to 
> official OSGi annotations.
> We should enable Felix SCR BndTools plugin to not block modules upgrading to 
> Sling Parent >= 30 (without reconfiguring Maven Bundle Plugin in their own 
> POMs or switching to official OSGi annotations).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (SLING-6649) Enable Felix SCR BndTools plugin

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz updated SLING-6649:

Fix Version/s: (was: Parent 31)

> Enable Felix SCR BndTools plugin
> 
>
> Key: SLING-6649
> URL: https://issues.apache.org/jira/browse/SLING-6649
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Affects Versions: Parent 30
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>
> The [Felix SCR BndTools 
> plugin|http://felix.apache.org/documentation/subprojects/apache-felix-maven-scr-plugin/apache-felix-scr-bndtools-use.html]
>  is currently disabled in Sling Parent:
> {noformat}
> [...]
> 
> ${sling.bree}
> 
> 
> <_plugin>org.apache.felix.bundleplugin.BlueprintPlugin,aQute.lib.spring.SpringXMLType
> 
> [...]
> {noformat}
> I tried several configurations to restore a working build of 
> {{org.apache.sling.event}} with {{maven-scr-plugin}} *and* 
> {{maven-bundle-plugin}} including testing (missing SCR descriptors) to no 
> avail and finally removed {{maven-scr-plugin}} and enabled 
> {{org.apache.felix.scrplugin.bnd.SCRDescriptorBndPlugin}} in [r1787036 
> |https://svn.apache.org/r1787036].
> Using Felix SCR BndTools plugin is a quick fix obviously before switching to 
> official OSGi annotations.
> We should enable Felix SCR BndTools plugin to not block modules upgrading to 
> Sling Parent >= 30 (without reconfiguring Maven Bundle Plugin in their own 
> POMs or switching to official OSGi annotations).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6649) Enable Felix SCR BndTools plugin

[Oliver Lietz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942955#comment-15942955
 ] 

Oliver Lietz commented on SLING-6649:
-

Thanks, [~cziegeler].

Resolving this issue as _Won't fix_ as [~cziegeler] and [~bdelacretaz] prefer a 
blocking approach.

IMHO every module should upgrade to latest parent before doing a new release. 
We still have current releases without _baselining_ enabled.

> Enable Felix SCR BndTools plugin
> 
>
> Key: SLING-6649
> URL: https://issues.apache.org/jira/browse/SLING-6649
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Affects Versions: Parent 30
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>
> The [Felix SCR BndTools 
> plugin|http://felix.apache.org/documentation/subprojects/apache-felix-maven-scr-plugin/apache-felix-scr-bndtools-use.html]
>  is currently disabled in Sling Parent:
> {noformat}
> [...]
> 
> ${sling.bree}
> 
> 
> <_plugin>org.apache.felix.bundleplugin.BlueprintPlugin,aQute.lib.spring.SpringXMLType
> 
> [...]
> {noformat}
> I tried several configurations to restore a working build of 
> {{org.apache.sling.event}} with {{maven-scr-plugin}} *and* 
> {{maven-bundle-plugin}} including testing (missing SCR descriptors) to no 
> avail and finally removed {{maven-scr-plugin}} and enabled 
> {{org.apache.felix.scrplugin.bnd.SCRDescriptorBndPlugin}} in [r1787036 
> |https://svn.apache.org/r1787036].
> Using Felix SCR BndTools plugin is a quick fix obviously before switching to 
> official OSGi annotations.
> We should enable Felix SCR BndTools plugin to not block modules upgrading to 
> Sling Parent >= 30 (without reconfiguring Maven Bundle Plugin in their own 
> POMs or switching to official OSGi annotations).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: [VOTE] Release Apache Sling Service User Mapper 1.2.6

[Robert Munteanu]

On Mon, 2017-03-27 at 10:41 +0200, Carsten Ziegeler wrote:
> Please vote to approve this release:

+1

Robert

signature.asc
Description: This is a digitally signed message part

[jira] [Created] (SLING-6717) Use commons lang3

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-6717:
---

 Summary: Use commons lang3
 Key: SLING-6717
 URL: https://issues.apache.org/jira/browse/SLING-6717
 Project: Sling
  Issue Type: Improvement
  Components: Servlets
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Servlets Resolver 2.4.12


We should move to the newer commons.lang3 and not use the legacy commons.lang 
anymore



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Comment Edited] (SLING-6716) Migrate to R6 annotations, clean up dependencies

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942910#comment-15942910
 ] 

Carsten Ziegeler edited comment on SLING-6716 at 3/27/17 9:39 AM:
--

Moved to R6 annotations in rev 1788859, removed deprecated internal constants 
and remove dependency to deprecated engine api 


was (Author: cziegeler):
Moved to R6 annotations in rev 1788859

> Migrate to R6 annotations, clean up dependencies
> 
>
> Key: SLING-6716
> URL: https://issues.apache.org/jira/browse/SLING-6716
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Servlets Resolver 2.4.12
>
>
> We should migrate to the R6 annotations and check whether we can remove some 
> of the dependencies.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6686) Replace commons.json usage in org.apache.sling.servlets.compat (or retire that module)

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942927#comment-15942927
 ] 

Bertrand Delacretaz commented on SLING-6686:


bq. The seed job is configured to not delete remove jobs but instead to disable 
them to prevent accidents leading to job history loss...

That's fine with me, thanks for clarifying! I was just mentioning that in case 
we use this ticket as an example for retiring other modules.

> Replace commons.json usage in org.apache.sling.servlets.compat (or retire 
> that module)
> --
>
> Key: SLING-6686
> URL: https://issues.apache.org/jira/browse/SLING-6686
> Project: Sling
>  Issue Type: Sub-task
>  Components: Servlets
>Affects Versions: Servlets Compat 1.0.0
>Reporter: Karl Pauls
>Assignee: Bertrand Delacretaz
>
> Not sure we have to update this one?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6702) Make MetricsService accessible as easily as a Logger

[Chetan Mehrotra (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942920#comment-15942920
 ] 

Chetan Mehrotra commented on SLING-6702:


Not yet as its not possible to reach this state easily. We can add such a 
support in various impl instance and add such checks for each api call. Not 
sure though we that all effort should be made

> Make MetricsService accessible as easily as a Logger
> 
>
> Key: SLING-6702
> URL: https://issues.apache.org/jira/browse/SLING-6702
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Commons Metrics 1.2.0
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Commons Metrics 1.2.2
>
>
> Metrics are useful in all classes, not only OSGi components, so getting the 
> {{MetricsService}} should be as useful as getting a {{Logger}} for example.
> I'll add a public {{MetricsServiceFactory}} class to our metrics module, 
> usable like
> {code}
>   MetricsService ms = 
> MetricsServiceFactory.getMetricsService(this.getClass());
> {code}
> There's already a private {{MetricsServiceFactory}} class in that module, 
> I'll rename that to {{InternalMetricsServiceFactory}} to avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6686) Replace commons.json usage in org.apache.sling.servlets.compat (or retire that module)

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942912#comment-15942912
 ] 

Robert Munteanu commented on SLING-6686:


{quote}Removing them from tooling/jenkins/create_jobs.groovy didn't cause the 
seed job to delete them, but executing that job ( 
https://builds.apache.org/view/S-Z/view/Sling/job/sling-seed-build/ ) correctly 
listed them as "Unreferenced".{quote}

The seed job is configured to not delete remove jobs but instead to disable 
them to prevent accidents leading to job history loss. If we think deleting 
them outright is the better option, we can always change the config of the seed 
job.

> Replace commons.json usage in org.apache.sling.servlets.compat (or retire 
> that module)
> --
>
> Key: SLING-6686
> URL: https://issues.apache.org/jira/browse/SLING-6686
> Project: Sling
>  Issue Type: Sub-task
>  Components: Servlets
>Affects Versions: Servlets Compat 1.0.0
>Reporter: Karl Pauls
>Assignee: Bertrand Delacretaz
>
> Not sure we have to update this one?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (SLING-6716) Migrate to R6 annotations, clean up dependencies

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-6716.
-
Resolution: Fixed

Moved to R6 annotations in rev 1788859

> Migrate to R6 annotations, clean up dependencies
> 
>
> Key: SLING-6716
> URL: https://issues.apache.org/jira/browse/SLING-6716
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Servlets Resolver 2.4.12
>
>
> We should migrate to the R6 annotations and check whether we can remove some 
> of the dependencies.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6686) Replace commons.json usage in org.apache.sling.servlets.compat (or retire that module)

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942854#comment-15942854
 ] 

Bertrand Delacretaz commented on SLING-6686:


I have also deleted the corresponding Jenkins jobs. Removing them from 
{{tooling/jenkins/create_jobs.groovy}} didn't cause the seed job to delete 
them, but executing that job ( 
https://builds.apache.org/view/S-Z/view/Sling/job/sling-seed-build/ ) correctly 
listed them as "Unreferenced".

https://builds.apache.org/view/S-Z/view/Sling/job/sling-bundles-servlets-compat-1.7/
https://builds.apache.org/view/S-Z/view/Sling/job/sling-bundles-servlets-compat-1.8/

> Replace commons.json usage in org.apache.sling.servlets.compat (or retire 
> that module)
> --
>
> Key: SLING-6686
> URL: https://issues.apache.org/jira/browse/SLING-6686
> Project: Sling
>  Issue Type: Sub-task
>  Components: Servlets
>Affects Versions: Servlets Compat 1.0.0
>Reporter: Karl Pauls
>Assignee: Bertrand Delacretaz
>
> Not sure we have to update this one?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)