[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #968 is FIXED

2022-03-10 Thread Apache Jenkins Server
Please see 
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/968/
 for details.

No further emails will be sent until the status of the build is changed.

[VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.1.12

2022-03-10 Thread Karl Pauls
I'd like to call the release on the following component:

Content-Package to Feature Model Converter 1.1.12:
https://issues.apache.org/jira/projects/SLING/versions/12350576

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2613

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2613 /tmp/sling-staging

Please vote to approve these releases:

  [ ] +1 Approve the releases
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...


[jira] [Updated] (SLING-11134) Extract Oak index definitions and package them as an additional file

2022-03-10 Thread Karl Pauls (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls updated SLING-11134:
---
Fix Version/s: Content-Package to Feature Model Converter 1.1.14
   Content-Package to Feature Model Converter 1.1.14
   (was: Content-Package to Feature Model Converter 1.1.12)

> Extract Oak index definitions and package them as an additional file
> 
>
> Key: SLING-11134
> URL: https://issues.apache.org/jira/browse/SLING-11134
> Project: Sling
>  Issue Type: New Feature
>  Components: Content-Package to Feature Model Converter
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.14
>
>
> It is sometimes useful to read the Oak index definitions from the content 
> package and package them as an additional file ( in JSON format? ) so they 
> can be more easily consumed by downstream tools that need to know the index 
> definitions.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (SLING-10774) Fix sonar findings in content-package to feature model converter

2022-03-10 Thread Karl Pauls (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls updated SLING-10774:
---
Fix Version/s: Content-Package to Feature Model Converter 1.1.14
   Content-Package to Feature Model Converter 1.1.14
   (was: Content-Package to Feature Model Converter 1.1.12)

> Fix sonar findings in content-package to feature model converter
> 
>
> Key: SLING-10774
> URL: https://issues.apache.org/jira/browse/SLING-10774
> Project: Sling
>  Issue Type: Improvement
>  Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.14
>
>
> sonar reports quite some findings for the content-package to feature model 
> converter bundle that are easy to fix preventing broken window syndrome i 
> would suggest to keep fixing as much as possible.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (SLING-10861) Subpackages are missing dependency on their container

2022-03-10 Thread Karl Pauls (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls updated SLING-10861:
---
Fix Version/s: Content-Package to Feature Model Converter 1.1.14
   Content-Package to Feature Model Converter 1.1.14
   (was: Content-Package to Feature Model Converter 1.1.12)

> Subpackages are missing dependency on their container
> -
>
> Key: SLING-10861
> URL: https://issues.apache.org/jira/browse/SLING-10861
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.10
>Reporter: Karl Pauls
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.14
>
>
> When the converter is extracting sub packages it is not adding a dependency 
> to their containing package to them. It does for embedded packages but not 
> for subpackages. It should add a dependency in both cases.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (SLING-10779) ContentPackage2FeatureModelConverter.getAclManager should never return null

2022-03-10 Thread Karl Pauls (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls updated SLING-10779:
---
Fix Version/s: Content-Package to Feature Model Converter 1.1.14
   Content-Package to Feature Model Converter 1.1.14
   (was: Content-Package to Feature Model Converter 1.1.12)

> ContentPackage2FeatureModelConverter.getAclManager should never return null
> ---
>
> Key: SLING-10779
> URL: https://issues.apache.org/jira/browse/SLING-10779
> Project: Sling
>  Issue Type: Improvement
>  Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Priority: Minor
> Fix For: Content-Package to Feature Model Converter 1.1.14
>
>
> {{ContentPackage2FeatureModelConverter.getAclManager}} is used across the 
> converter code base and always expected to be not-null. so, instead of 
> defining it as 'nullable' we should find ways to make sure it is always 
> present on the converter. this would allow to get rid of 
> Objects.requireNotNull and the warnings about potential NPE where the check 
> is missing.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (SLING-10571) Hardcoded application paths in VaultPackageUtils.detectPackageType

2022-03-10 Thread Karl Pauls (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls updated SLING-10571:
---
Fix Version/s: Content-Package to Feature Model Converter 1.1.14
   Content-Package to Feature Model Converter 1.1.14
   (was: Content-Package to Feature Model Converter 1.1.12)

> Hardcoded application paths in VaultPackageUtils.detectPackageType
> --
>
> Key: SLING-10571
> URL: https://issues.apache.org/jira/browse/SLING-10571
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Priority: Minor
>  Labels: technical_debt
> Fix For: Content-Package to Feature Model Converter 1.1.14
>
>
> while investigating SLING-10467 i noticed hardcoded paths for what should be 
> considered application content in {{VaultPackageUtils.detectPackageType}}.
> the method looks as follows:
> {code}
> public static @NotNull PackageType detectPackageType(String path) {
> if ("/apps".equals(path)
> || path.startsWith("/apps/")
> || "/libs".equals(path)
> || path.startsWith("/libs/")) {
> return PackageType.APPLICATION;
> } else {
> return PackageType.CONTENT;
> }
> }
> {code}
> instead of hardcoding /apps and /libs which are details of Adobe AEM, these 
> paths should be configured with the converter-launcher. in particular since 
> the list looks a bit arbitrary as there are other paths that IMHO should be 
> considered application content like nodetype registry, namespace registry, 
> privilege registry, service users etc.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (SLING-10768) AbstractJcrNodeParser and subclasses ignore namespace mappings

2022-03-10 Thread Karl Pauls (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls updated SLING-10768:
---
Fix Version/s: Content-Package to Feature Model Converter 1.1.14
   Content-Package to Feature Model Converter 1.1.14
   (was: Content-Package to Feature Model Converter 1.1.12)

> AbstractJcrNodeParser and subclasses ignore namespace mappings
> --
>
> Key: SLING-10768
> URL: https://issues.apache.org/jira/browse/SLING-10768
> Project: Sling
>  Issue Type: Improvement
>  Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Priority: Minor
> Fix For: Content-Package to Feature Model Converter 1.1.14
>
>
> The {{AbstractJcrNodeParser}} has a constant defined for "jcr:root". It would 
> be better if it (and subclasses) would not rely on the default namespace 
> mappings.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (SLING-10784) BundleEntryHandler - sonar findings

2022-03-10 Thread Karl Pauls (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls updated SLING-10784:
---
Fix Version/s: Content-Package to Feature Model Converter 1.1.14
   Content-Package to Feature Model Converter 1.1.14
   (was: Content-Package to Feature Model Converter 1.1.12)

> BundleEntryHandler - sonar findings
> ---
>
> Key: SLING-10784
> URL: https://issues.apache.org/jira/browse/SLING-10784
> Project: Sling
>  Issue Type: Sub-task
>  Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.14
>
>
> https://sonarcloud.io/code?id=apache_sling-org-apache-sling-feature-cpconverter=apache_sling-org-apache-sling-feature-cpconverter%3Asrc%2Fmain%2Fjava%2Forg%2Fapache%2Fsling%2Ffeature%2Fcpconverter%2Fhandlers%2FBundleEntryHandler.java



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (SLING-11060) CPConverter - sling initial content - ACL support

2022-03-10 Thread Karl Pauls (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls updated SLING-11060:
---
Fix Version/s: Content-Package to Feature Model Converter 1.1.14
   Content-Package to Feature Model Converter 1.1.14
   (was: Content-Package to Feature Model Converter 1.1.12)

> CPConverter - sling initial content - ACL support
> -
>
> Key: SLING-11060
> URL: https://issues.apache.org/jira/browse/SLING-11060
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.10
>Reporter: Niek Raaijmakers
>Assignee: Niek Raaijmakers
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.14
>
>
> Currently, we do not implement the ACL support for Sling Initial Content as 
> specified : 
> [https://sling.apache.org/documentation/bundles/repository-initialization.html]
> We need the following methods 
> (org.apache.sling.feature.cpconverter.handlers.slinginitialcontent.VaultContentXMLContentCreator)
>   implemented or another workaround found:
>  
> {code:java}
> @Override
> public boolean switchCurrentNode(String subPath, String newNodeType) throws 
> RepositoryException {
> throw new UnsupportedOperationException();
> }
> @Override
> public void createUser(String name, String password, Map 
> extraProperties) throws RepositoryException {
> throw new UnsupportedOperationException();
> }
> @Override
> public void createGroup(String name, String[] members, Map 
> extraProperties) throws RepositoryException {
> throw new UnsupportedOperationException();
> }
> @Override
> public void createAce(String principal, String[] grantedPrivileges, String[] 
> deniedPrivileges, String order) throws RepositoryException {
> throw new UnsupportedOperationException();
> }
> @Override
> public void createAce(String principalId, String[] grantedPrivilegeNames, 
> String[] deniedPrivilegeNames,
> String order, Map restrictions, Map 
> mvRestrictions,
> Set removedRestrictionNames) throws RepositoryException {
> throw new UnsupportedOperationException();
> }{code}
>  
> Stashed code is on branch: SLING-10931 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (SLING-10790) BundleEntryHandler.extractArtifactId may use wrong GAV

2022-03-10 Thread Karl Pauls (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls updated SLING-10790:
---
Fix Version/s: Content-Package to Feature Model Converter 1.1.14
   Content-Package to Feature Model Converter 1.1.14
   (was: Content-Package to Feature Model Converter 1.1.12)

> BundleEntryHandler.extractArtifactId may use wrong GAV
> --
>
> Key: SLING-10790
> URL: https://issues.apache.org/jira/browse/SLING-10790
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Priority: Minor
> Fix For: Content-Package to Feature Model Converter 1.1.14
>
>
> [~kpauls], if my reading of {{BundleEntryHandler.extractArtifactId}} is 
> correct it the method might be ending up using the wrong 
> groupId/artifactId/version.
> the code will loop over jar-entries and stop if the extracted GAV matches the 
> bundle name. however, groupId/artifactId/version are not reset to {{null}} in 
> case they were successfully extracted but didn't end up matching the bundle 
> name i.e. {quote}it was the pom.properties  we were looking for{quote}.
> i can't tell how big of an issue that is (and how likely). but given the fact 
> that there is some extra effort to verify that the parsed pom is actually the 
> right one, it might actually be relevant. the relies on a compliant content 
> package that does contain a matching pom, which may or may not be the case... 
> logging a warning or throwing a ConverterException in case of violation might 
> help spotting troublesome content packages instead of getting some sort of 
> side effect if another pom was spotted.
> a heavily simplified copy of the method:
> {code}
> String artifactId = null;
> String version = null;
> String groupId = null;
> String classifier = null;
> for (Enumeration e = jarFile.entries(); 
> e.hasMoreElements();) {
> [...]
> // extract groupId/artifactId/version
> [...]
>
> if (groupId != null && artifactId != null && version != null) {
> // bundleName is now the bare name without extension
> String synthesized = artifactId + "-" + version;
> // it was the pom.properties  we were looking for
> if (bundleName.startsWith(synthesized) || 
> bundleName.equals(artifactId)) {
> [...]
> 
> // no need to iterate further
> break;
> }
> }
> }
> 
> if (groupId == null) {
> [...]
> }
> return new ArtifactId(groupId, artifactId, version, classifier, 
> JAR_TYPE);
> {code}
> feel free to resolve as not a problem in case my reading of the code is all 
> wrong.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (SLING-10781) ContentPackage2FeatureModelConverterLauncher - sonar findings

2022-03-10 Thread Karl Pauls (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls updated SLING-10781:
---
Fix Version/s: Content-Package to Feature Model Converter 1.1.14
   Content-Package to Feature Model Converter 1.1.14
   (was: Content-Package to Feature Model Converter 1.1.12)

> ContentPackage2FeatureModelConverterLauncher - sonar findings
> -
>
> Key: SLING-10781
> URL: https://issues.apache.org/jira/browse/SLING-10781
> Project: Sling
>  Issue Type: Sub-task
>  Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.14
>
>
> see 
> https://sonarcloud.io/code?id=apache_sling-org-apache-sling-feature-cpconverter=apache_sling-org-apache-sling-feature-cpconverter%3Asrc%2Fmain%2Fjava%2Forg%2Fapache%2Fsling%2Ffeature%2Fcpconverter%2Fcli%2FContentPackage2FeatureModelConverterLauncher.java



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (SLING-10787) BundleEntryHandler.extractArtifactId prone to IllegalArgumentException

2022-03-10 Thread Karl Pauls (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls updated SLING-10787:
---
Fix Version/s: Content-Package to Feature Model Converter 1.1.14
   Content-Package to Feature Model Converter 1.1.14
   (was: Content-Package to Feature Model Converter 1.1.12)

> BundleEntryHandler.extractArtifactId prone to IllegalArgumentException
> --
>
> Key: SLING-10787
> URL: https://issues.apache.org/jira/browse/SLING-10787
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.14
>
>
> trying to address sonar findings for {{BundleEntryHandler}} (see SLING-10784) 
> i noticed that there is no guarantee that 'artifactId' and 'version' are not 
> left null after all the processing completed. if any of the two is null 
> constructing a new {{ArtifactId}} object from the given strings will fail 
> will {{IllegalArgumentException}}.
> it might be as simple as extracting the following statements out of the 
> previous block that handles the {{groupId == null}} case:
> {code}
> if (artifactId == null || artifactId.isEmpty()) {
> artifactId = groupId;
> }
> 
> if (version == null) {
> Version osgiVersion = 
> Version.parseVersion(getCheckedProperty(jarFile.getManifest(), 
> Constants.BUNDLE_VERSION));
> version = osgiVersion.getMajor() + "." + osgiVersion.getMinor() + 
> "." + osgiVersion.getMicro() + (osgiVersion.getQualifier().isEmpty() ? "" : 
> "-" + osgiVersion.getQualifier());
> }
> {code}
> but i am not totally sure there is a reason the method 
> {{BundleEntryHandler.extractArtifactId}} gets called out by sonar :)
> note: on line 472 of the same method {{IllegalArgumentException}} is 
> caught so i assume the code doesn't expect this method to fail upon 
> building the {{ArtifactId}}.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (SLING-10914) CpConverter - package type calculation should take filters into account

2022-03-10 Thread Karl Pauls (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls updated SLING-10914:
---
Fix Version/s: Content-Package to Feature Model Converter 1.1.14
   Content-Package to Feature Model Converter 1.1.14
   (was: Content-Package to Feature Model Converter 1.1.12)

> CpConverter - package type calculation should take filters into account
> ---
>
> Key: SLING-10914
> URL: https://issues.apache.org/jira/browse/SLING-10914
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.10
>Reporter: Niek Raaijmakers
>Assignee: Niek Raaijmakers
>Priority: Minor
> Fix For: Content-Package to Feature Model Converter 1.1.14
>
>
> The converter does attempt to (re-)calculate the package type (application, 
> content, mixed) as part of creating the converted packages. However, it 
> doesn't take the targets of the filters into account when determining the 
> type. As such, it is possible that e.g. a package containing a filter 
> targeting apps would end up being classified as being of type content. 
> Furthermore, it when looking into the content, it doesn't take into account 
> if the content is covered by filters - ie., it doesn't really check if the 
> content would be ignored by vault. 
> Given that it is hard to know what vault will install or not, it might not be 
> possible to fix the second issue - however, it should be possible to at least 
> look at the filters and take their targets into account (as pathes) when 
> (re-)calculating the package type.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (SLING-10760) Converter ignores access control content and users/groups in .content.xml files

2022-03-10 Thread Karl Pauls (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls updated SLING-10760:
---
Fix Version/s: Content-Package to Feature Model Converter 1.1.14
   (was: Content-Package to Feature Model Converter 1.1.12)

> Converter ignores access control content and users/groups in .content.xml 
> files
> ---
>
> Key: SLING-10760
> URL: https://issues.apache.org/jira/browse/SLING-10760
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Priority: Critical
> Fix For: Content-Package to Feature Model Converter 1.1.14
>
> Attachments: subtree_in_contentxml_policy.png, 
> subtree_in_contentxml_sibling.png
>
>
> [~kpauls], while trying to find more edge cases that could cause SLING-10754, 
> i noticed that not only sibling nodes but also access control content (like 
> e.g. _rep:policy_ nodes) contained in a _.content.xml_ get installed by 
> Jackrabbit Filevault even if those nodes are not covered by the corresponding 
> {{WorkspaceFilter}}.
> It also seems that these package 'entries' are not spotted by the converter 
> and thus the dedicated {{EntryHandler}} implementations that are intended to 
> analyze and convert special content like e.g. access control (but probably 
> not limited to that) are not triggered.
> In other words: content hidden in _.content.xml_ will not be properly 
> converted but will be installed even if not covered by _filter.xml_ 
> associated with the content package. I don't know if that actually intended 
> behavior of Jackrabbit FileVault (the documentation clearly stating that 
> everything should be covered by filter rules [0], section 'Usage for 
> Import/Installation'), but if it is correct it might in the worse case 
> require the converter to parse all _.content.xml_ files and delegate to the 
> proper handler implementations.
> [~kwin], I would appreciate your input on the FileVault related question of 
> this ticket. In particular: is it correct and intended that subnodes defined 
> in _.content.xml_ get installed even if not covered by any filter rule?
> [0] https://jackrabbit.apache.org/filevault/filter.html



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (SLING-11158) The starter's "Start Sling" instructions don't work with feature launcher v1.1.28 or later

2022-03-10 Thread Eric Norman (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-11158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17504548#comment-17504548
 ] 

Eric Norman commented on SLING-11158:
-

Perhaps we can start a discussion on what would be the preferred way to move 
forward.

These may be a couple of possible ways to resolve this problem:

1) Produce and release an additional alternate "uber" jar packaging of the 
feature launcher in a single jar file as it was before v1.1.28, and leave 
everything else as is?  The feature launcher assembly would continue to include 
the "thin" jar.

2) Change the starter build (and the feature-launcher-maven-plugin) to download 
the new feature launcher assembly, unpack it somewhere and use the new scripts 
to launch it?

... or maybe there is some other solution that I haven't thought of.

> The starter's "Start Sling" instructions don't work with feature launcher 
> v1.1.28 or later
> --
>
> Key: SLING-11158
> URL: https://issues.apache.org/jira/browse/SLING-11158
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Feature Model Launcher 1.1.28, Feature Model Launcher 
> 1.2.0
>Reporter: Eric Norman
>Priority: Major
> Fix For: Feature Launcher Maven Plugin 0.1.4, Feature Model 
> Launcher 1.2.2
>
>
> After the SLING-10956 changes, launching the Starter with the README provided 
> instructions while using the v1.1.28 or later feature launcher does not work 
> anymore.
> For example,
> {noformat}
> $ java -jar target/dependency/org.apache.sling.feature.launcher.jar -f 
> target/slingfeature-tmp/feature-oak_tar.json
> Error: Unable to initialize main class 
> org.apache.sling.feature.launcher.impl.Main
> Caused by: java.lang.NoClassDefFoundError: 
> org/apache/commons/cli/ParseException{noformat}
>  
> Also, the start goal of the feature-launcher-maven-plugin fails with the same 
> exception when paired with a featureLauncherVersion of 1.1.28 or later.
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


Re: [Content Loader] Decide on approach to unblock Sling 12

2022-03-10 Thread Eric Norman
+1 for b)

Stefan, I reviewed your feedback to PR #13 and have applied an improvement
that should reduce the log message noise to one WARN message per affected
bundle and no stack trace to fill up the log file.  Hopefully that
addresses your concerns.

I'd like to hear more about 'c)', it seems like you may be saying that you
want to defer all Content-Loading until all of the configured
'defaultRequireImportProviders' are satisfied?  I'm not sure that is better
than 'b)' since you may encounter a situation where you are waiting for
something that never arrives and is never used.

Regards,
-Eric

On Thu, Mar 10, 2022 at 8:33 AM Stefan Seifert
 wrote:

> during release process of Sling 12 we discovered SLING-11189 [1] which
> happens only on certain windows environments, but is there a blocker as
> Sling-Initial-Content from bundles like composum (may affect other apps as
> well) are corrupted during extraction, actually breaking the application.
> the root cause is a race condition on sling startup where the content
> reader implementations are registered after the whiteboard for handling
> them is registered, and after the first bundles are actually processed.
>
> to solve this we have multiple approaches, i want to do a quick vote on
> these options to unblock the release:
>
> a) apply only PR #12 [2] which simply defines a mandatory dependency
> between the whiteboard and the 4 built-in readers via DS. the list of
> mandatory readers is hardcoded in the code.
>
> b) apply only PR #13 [3] which introduces a new directive
> "requireImportProviders" allowing bundles to actually define which import
> providers they depend on, and if those are not there the importing of the
> initial content is delayed until they become available. if the directive is
> missing a default list is assumed which is configurable via OSGi (and
> defaults to the 4 built-in readers). the current implementation has the
> small drawback that it prints out some error messages in case the bundle
> processing is delayed, even if it's only for a few milliseconds due to
> sling startup.
>
> c) combine PR #12 [2] and PR #13 [3] to avoid the error messages for the
> built-in readers.
>
> d) look for other solutions, e.g. implementing a) "the other way around"
> by having the whiteboard register the reader implementations itself, which
> probably means moving away from DS for those reader service implementations.
>
> z) take more time for discussing the options a)-d) and go with workaround
> from [4] for Sling 12 which fixes this issue via configuration only for
> Sling Starter, not in the content loader bundle itself.
>
> please cast your votes on this options.
>
> stefan
>
> [1] https://issues.apache.org/jira/browse/SLING-11189
> [2]
> https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12
> [3]
> https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/13
> [4] https://github.com/apache/sling-org-apache-sling-starter/pull/59
>


[GitHub] [sling-org-apache-sling-jcr-contentloader] enapps-enorman edited a comment on pull request #13: SLING-11189 Race condition registering readers vs. loading content

2022-03-10 Thread GitBox


enapps-enorman edited a comment on pull request #13:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/13#issuecomment-1064413713


   @stefanseifert Thanks for confirming that it eventually gets into the right 
state.  I've made another adjustment that should reduce the log message noise.  
Does this resolve your concerns?
   
   You should now get one WARN message (no stacktrace) per bundle the first 
time it fails and then one INFO message per bundle after the retry logic is 
successful.
   
   For example:
   `[main] WARN org.apache.sling.jcr.contentloader.internal.BundleContentLoader 
- Cannot load initial content for bundle mock-bundle : Unable to locate a 
required content reader for entry SLING-INF/libs/app.xml`
   
   `[main] INFO org.apache.sling.jcr.contentloader.internal.BundleContentLoader 
- Retrying to load initial content for bundle mock-bundle succeeded.
   `


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-jcr-contentloader] enapps-enorman edited a comment on pull request #13: SLING-11189 Race condition registering readers vs. loading content

2022-03-10 Thread GitBox


enapps-enorman edited a comment on pull request #13:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/13#issuecomment-1064413713


   @stefanseifert Thanks for confirming that it eventually gets into the right 
state.  I've made another adjustment that should reduce the log message noise.  
Does this resolve your concerns?
   
   You should now get one WARN message (no stacktrace) per bundle the first 
time it fails and then one INFO message per bundle after the retry logic is 
successful.
   
   For example:
   `[main] WARN org.apache.sling.jcr.contentloader.internal.BundleContentLoader 
- Cannot load initial content for bundle mock-bundle : Unable to locate a 
required content reader for entry SLING-INF/libs/app.xml
   
   [main] INFO org.apache.sling.jcr.contentloader.internal.BundleContentLoader 
- Retrying to load initial content for bundle mock-bundle succeeded.
   `


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-jcr-contentloader] enapps-enorman commented on pull request #13: SLING-11189 Race condition registering readers vs. loading content

2022-03-10 Thread GitBox


enapps-enorman commented on pull request #13:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/13#issuecomment-1064413713


   @stefanseifert Thanks for confirming that it eventually gets into the right 
state.  I've made another adjustment that should reduce the log message noise.  
Does this resolve your concerns?
   
   You should now get one WARN message (no stacktrace) per bundle the first 
time it fails and then one INFO message per bundle after the retry logic is 
successful.
   
   For example:
   `[main] WARN org.apache.sling.jcr.contentloader.internal.BundleContentLoader 
- Cannot load initial content for bundle mock-bundle : Unable to locate a 
required content reader for entry SLING-INF/libs/app.xml
   [main] INFO org.apache.sling.jcr.contentloader.internal.BundleContentLoader 
- Retrying to load initial content for bundle mock-bundle succeeded.
   `


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-jcr-contentloader] sonarcloud[bot] removed a comment on pull request #13: SLING-11189 Race condition registering readers vs. loading content

2022-03-10 Thread GitBox


sonarcloud[bot] removed a comment on pull request #13:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/13#issuecomment-1063495469


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=CODE_SMELL)
   
   
[![91.8%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/90-16px.png
 
'91.8%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=13=new_coverage=list)
 [91.8% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=13=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=13=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=13=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-jcr-contentloader] sonarcloud[bot] commented on pull request #13: SLING-11189 Race condition registering readers vs. loading content

2022-03-10 Thread GitBox


sonarcloud[bot] commented on pull request #13:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/13#issuecomment-1064409849


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=CODE_SMELL)
 [2 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=13=false=CODE_SMELL)
   
   
[![91.2%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/90-16px.png
 
'91.2%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=13=new_coverage=list)
 [91.2% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=13=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=13=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=13=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




Re: [Content Loader] Decide on approach to unblock Sling 12

2022-03-10 Thread Konrad Windszus
+1 for a) for now.

Afterwards we can take some time and  probably do c) or improve b) by waiting 
for the service to become active (in case it is resolvable in the current 
system).

Konrad

> On 10. Mar 2022, at 17:33, Stefan Seifert  
> wrote:
> 
> during release process of Sling 12 we discovered SLING-11189 [1] which 
> happens only on certain windows environments, but is there a blocker as 
> Sling-Initial-Content from bundles like composum (may affect other apps as 
> well) are corrupted during extraction, actually breaking the application. the 
> root cause is a race condition on sling startup where the content reader 
> implementations are registered after the whiteboard for handling them is 
> registered, and after the first bundles are actually processed.
> 
> to solve this we have multiple approaches, i want to do a quick vote on these 
> options to unblock the release:
> 
> a) apply only PR #12 [2] which simply defines a mandatory dependency between 
> the whiteboard and the 4 built-in readers via DS. the list of mandatory 
> readers is hardcoded in the code.
> 
> b) apply only PR #13 [3] which introduces a new directive 
> "requireImportProviders" allowing bundles to actually define which import 
> providers they depend on, and if those are not there the importing of the 
> initial content is delayed until they become available. if the directive is 
> missing a default list is assumed which is configurable via OSGi (and 
> defaults to the 4 built-in readers). the current implementation has the small 
> drawback that it prints out some error messages in case the bundle processing 
> is delayed, even if it's only for a few milliseconds due to sling startup.
> 
> c) combine PR #12 [2] and PR #13 [3] to avoid the error messages for the 
> built-in readers.
> 
> d) look for other solutions, e.g. implementing a) "the other way around" by 
> having the whiteboard register the reader implementations itself, which 
> probably means moving away from DS for those reader service implementations.
> 
> z) take more time for discussing the options a)-d) and go with workaround 
> from [4] for Sling 12 which fixes this issue via configuration only for Sling 
> Starter, not in the content loader bundle itself.
> 
> please cast your votes on this options.
> 
> stefan
> 
> [1] https://issues.apache.org/jira/browse/SLING-11189
> [2] https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12
> [3] https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/13
> [4] https://github.com/apache/sling-org-apache-sling-starter/pull/59



Re: [VOTE] Release Apache Sling Discovery Oak 1.2.36

2022-03-10 Thread Stefan Egli

+1

(always funny to self-vote)

Cheers,
Stefan

On 10.03.22 19:10, Stefan Egli wrote:

Hi,


We solved 1 issue in theis release:
https://issues.apache.org/jira/projects/SLING/versions/12350271


Note that this release requires Discovery Commons 1.0.26, which is also 
currently in release voting.


Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2612

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD 




Usage:
sh check_staged_release.sh 2612 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.


Cheers,
Stefan


[VOTE] Release Apache Sling Discovery Oak 1.2.36

2022-03-10 Thread Stefan Egli

Hi,


We solved 1 issue in theis release:
https://issues.apache.org/jira/projects/SLING/versions/12350271


Note that this release requires Discovery Commons 1.0.26, which is also 
currently in release voting.


Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2612

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD


Usage:
sh check_staged_release.sh 2612 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.


Cheers,
Stefan


[jira] [Updated] (SLING-5598) Exclude slow tests by default with assume(sling.slow.tests.enabled)

2022-03-10 Thread Stefan Egli (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli updated SLING-5598:
---
Fix Version/s: Discovery Oak 1.2.38
   (was: Discovery Oak 1.2.36)

> Exclude slow tests by default with assume(sling.slow.tests.enabled) 
> 
>
> Key: SLING-5598
> URL: https://issues.apache.org/jira/browse/SLING-5598
> Project: Sling
>  Issue Type: Task
>  Components: Extensions
>Affects Versions: Discovery Impl 1.2.6, Discovery Base 1.1.2, Discovery 
> Commons 1.0.10, Discovery Oak 1.2.6
>Reporter: Stefan Egli
>Priority: Major
> Fix For: Discovery Impl 1.2.14, Discovery Commons 1.0.28, 
> Discovery Base 2.0.14, Discovery Oak 1.2.38
>
> Attachments: SLING-5598-commons-testing.patch, 
> SLING-5598-discovery.patch
>
>
> As suggested by [~bdelacretaz] on [the 
> list|http://markmail.org/message/yad5awqg53epk3ck] we should improve test 
> duration (ideally 1-2min per bundle max, 10-15min overall). While they are 
> not yet improved however, slow tests should be excluded by default and run 
> only if enabled explicitly. Here's an example {{@Before}} method to achieve 
> that:
> {noformat}
> @Before
> public void checkSlowTests() {
> assumeNotNull(System.getProperty("sling.slow.tests.enabled"));
> }
> {noformat}
> and to enable the slow tests you do: {{mvn -Dsling.slow.tests.enabled=true 
> clean test}}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (SLING-9625) DiscoveryServiceImpl#doUpdateProperties may fail due to a LoginException

2022-03-10 Thread Stefan Egli (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli updated SLING-9625:
---
Fix Version/s: Discovery Oak 1.2.38
   (was: Discovery Oak 1.2.36)

> DiscoveryServiceImpl#doUpdateProperties may fail due to a LoginException 
> -
>
> Key: SLING-9625
> URL: https://issues.apache.org/jira/browse/SLING-9625
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Discovery Oak 1.2.30
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Discovery Oak 1.2.38
>
>
> While stopping the OSGi container (Sling Starter 12 SNAPSHOT) I observed the 
> following error
> {code}
> 03.08.2020 10:30:06.262 *INFO * [Apache Sling Terminator] Stopping Apache 
> Sling
> ERROR: bundle org.apache.sling.discovery.oak:1.2.28 
> (139)[org.apache.sling.discovery.oak.OakDiscoveryService(200)] : The 
> updatedPropertyProvider method has thrown an exception
> java.lang.RuntimeException: Could not log in to repository 
> (org.apache.sling.api.resource.LoginException: Cannot derive user name for 
> bundle org.apache.sling.discovery.oak [139] and sub service null)
>   at 
> org.apache.sling.discovery.oak.OakDiscoveryService.doUpdateProperties(OakDiscoveryService.java:540)
>   at 
> org.apache.sling.discovery.oak.OakDiscoveryService.bindPropertyProviderInteral(OakDiscoveryService.java:406)
>   at 
> org.apache.sling.discovery.oak.OakDiscoveryService.updatedPropertyProvider(OakDiscoveryService.java:421)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.apache.felix.scr.impl.inject.methods.BaseMethod.invokeMethod(BaseMethod.java:242)
>   at 
> org.apache.felix.scr.impl.inject.methods.BaseMethod.access$500(BaseMethod.java:41)
>   at 
> org.apache.felix.scr.impl.inject.methods.BaseMethod$Resolved.invoke(BaseMethod.java:678)
>   at 
> org.apache.felix.scr.impl.inject.methods.BaseMethod$NotResolved.invoke(BaseMethod.java:633)
>   at 
> org.apache.felix.scr.impl.inject.methods.BaseMethod.invoke(BaseMethod.java:524)
>   at 
> org.apache.felix.scr.impl.inject.methods.BindMethod.invoke(BindMethod.java:42)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager.invokeUpdatedMethod(DependencyManager.java:1934)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.invokeUpdatedMethod(SingleComponentManager.java:448)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynamicCustomizer.modifiedService(DependencyManager.java:366)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynamicCustomizer.modifiedService(DependencyManager.java:297)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerModified(ServiceTracker.java:1229)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerModified(ServiceTracker.java:1137)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$AbstractTracked.track(ServiceTracker.java:883)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:1168)
>   at 
> org.apache.felix.scr.impl.BundleComponentActivator$ListenerInfo.serviceChanged(BundleComponentActivator.java:125)
>   at 
> org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990)
>   at 
> org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:838)
>   at 
> org.apache.felix.framework.EventDispatcher.fireServiceEvent(EventDispatcher.java:545)
>   at org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4833)
>   at org.apache.felix.framework.Felix.access$000(Felix.java:112)
>   at org.apache.felix.framework.Felix$1.serviceChanged(Felix.java:434)
>   at 
> org.apache.felix.framework.ServiceRegistry.servicePropertiesModified(ServiceRegistry.java:601)
>   at 
> org.apache.felix.framework.ServiceRegistrationImpl.setProperties(ServiceRegistrationImpl.java:132)
>   at 
> org.apache.sling.event.impl.jobs.JobConsumerManager.unbindService(JobConsumerManager.java:354)
>   at 
> org.apache.sling.event.impl.jobs.JobConsumerManager.unbindJobExecutor(JobConsumerManager.java:270)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at 

[jira] [Resolved] (SLING-10489) Ignore partially started, newly joining instances to avoid disturbing discovery (for a while)

2022-03-10 Thread Stefan Egli (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli resolved SLING-10489.
-
Resolution: Fixed

Marking as done, next step are releasing discovery.oak 1.2.36 (and finish up 
release of discovery.base 2.0.12 and discovery.commons 1.0.26) - but those are 
not exactly tied to this ticket

> Ignore partially started, newly joining instances to avoid disturbing 
> discovery (for a while)
> -
>
> Key: SLING-10489
> URL: https://issues.apache.org/jira/browse/SLING-10489
> Project: Sling
>  Issue Type: Improvement
>  Components: Discovery
>Affects Versions: Discovery Commons 1.0.24, Discovery Base 2.0.10, 
> Discovery Oak 1.2.34
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Major
> Fix For: Discovery Base 2.0.12, Discovery Commons 1.0.26, 
> Discovery Oak 1.2.36
>
>  Time Spent: 8h 10m
>  Remaining Estimate: 0h
>
> Discovery.oak requires that both Oak and Sling are operating normally in 
> order to declare victory and announce a new topology.
> The startup phase is especially tricky in this regard, since there are 
> multiple elements that need to get updated (some are in the Oak layer, some 
> in Sling) :
>  * lease & clusterNodeId : this is maintained by Oak
>  * idMap : this is maintained by IdMapService (Sling)
>  * leaderElectionId : this is maintained by OakViewChecker (Sling)
>  * syncToken : this is maintained by SyncTokenService (Sling)
> Situations have been seen where Oak starts up fine, but higher level (eg 
> Sling) bundles were not activated within a reasonable amount of time. This 
> lead to discovery staying in TOPOLOGY_CHANGING state for longer than expected.
> There should be a mechanism that ignores (suppresses) newly joining instances 
> if they start up only partially. However, after a certain timeout this 
> mechanism should give up.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (SLING-10489) Ignore partially started, newly joining instances to avoid disturbing discovery (for a while)

2022-03-10 Thread Stefan Egli (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-10489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17504480#comment-17504480
 ] 

Stefan Egli commented on SLING-10489:
-

* merged [discovery.oak 
PR#4|https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/4]

> Ignore partially started, newly joining instances to avoid disturbing 
> discovery (for a while)
> -
>
> Key: SLING-10489
> URL: https://issues.apache.org/jira/browse/SLING-10489
> Project: Sling
>  Issue Type: Improvement
>  Components: Discovery
>Affects Versions: Discovery Commons 1.0.24, Discovery Base 2.0.10, 
> Discovery Oak 1.2.34
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Major
> Fix For: Discovery Base 2.0.12, Discovery Commons 1.0.26, 
> Discovery Oak 1.2.36
>
>  Time Spent: 8h 10m
>  Remaining Estimate: 0h
>
> Discovery.oak requires that both Oak and Sling are operating normally in 
> order to declare victory and announce a new topology.
> The startup phase is especially tricky in this regard, since there are 
> multiple elements that need to get updated (some are in the Oak layer, some 
> in Sling) :
>  * lease & clusterNodeId : this is maintained by Oak
>  * idMap : this is maintained by IdMapService (Sling)
>  * leaderElectionId : this is maintained by OakViewChecker (Sling)
>  * syncToken : this is maintained by SyncTokenService (Sling)
> Situations have been seen where Oak starts up fine, but higher level (eg 
> Sling) bundles were not activated within a reasonable amount of time. This 
> lead to discovery staying in TOPOLOGY_CHANGING state for longer than expected.
> There should be a mechanism that ignores (suppresses) newly joining instances 
> if they start up only partially. However, after a certain timeout this 
> mechanism should give up.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [sling-org-apache-sling-caconfig-integration-tests] sonarcloud[bot] removed a comment on pull request #1: SLING-11114 update SLING API to 2.21.0

2022-03-10 Thread GitBox


sonarcloud[bot] removed a comment on pull request #1:
URL: 
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1060055120


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-caconfig-integration-tests] sonarcloud[bot] commented on pull request #1: SLING-11114 update SLING API to 2.21.0

2022-03-10 Thread GitBox


sonarcloud[bot] commented on pull request #1:
URL: 
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1064327520


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-discovery-oak] stefan-egli merged pull request #4: SLING-10489 : introducing partial startup detector

2022-03-10 Thread GitBox


stefan-egli merged pull request #4:
URL: https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/4


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #967 is BROKEN

2022-03-10 Thread Apache Jenkins Server
[INFO] Checking legal files in: 
org.apache.sling.launchpad.testing-13-SNAPSHOT.jar
[INFO] Checking legal files in: 
org.apache.sling.launchpad.testing-13-SNAPSHOT-sources.jar
[INFO] 
[INFO] --- apache-rat-plugin:0.13:check (rat-check) @ 
org.apache.sling.launchpad.testing ---
[INFO] Enabled default license matchers.
[INFO] Will parse SCM ignores for exclusions...
[INFO] Parsing exclusions from 
/home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master/.gitignore
[INFO] Finished adding exclusions from SCM ignore files.
[INFO] 75 implicit excludes (use -debug for more details).
[INFO] 13 explicit excludes (use -debug for more details).
[INFO] 4 resources included (use -debug for more details)
[INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 
0, approved: 3 licenses.
[INFO] 
[INFO] --- maven-failsafe-plugin:2.21.0:verify (default) @ 
org.apache.sling.launchpad.testing ---
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time:  16:26 min
[INFO] Finished at: 2022-03-10T17:24:34Z
[INFO] 
[INFO] [jenkins-event-spy] Generated 
/home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master@tmp/withMavend0e15f5b/maven-spy-20220310-170807-4464963313767752596611.log
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-failsafe-plugin:2.21.0:verify (default) on 
project org.apache.sling.launchpad.testing: There are test failures.
[ERROR] 
[ERROR] Please refer to 
/home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master/target/failsafe-reports
 for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump, 
[date].dumpstream and [date]-jvmRun[N].dumpstream.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[Pipeline] }
[withMaven] junitPublisher - Archive test results for Maven artifact 
org.apache.sling:org.apache.sling.launchpad.testing:jar:13-SNAPSHOT generated 
by maven-surefire-plugin:test (default-test): target/surefire-reports/*.xml
Recording test results
None of the test reports contained any result
[withMaven] junitPublisher - Archive test results for Maven artifact 
org.apache.sling:org.apache.sling.launchpad.testing:jar:13-SNAPSHOT generated 
by maven-failsafe-plugin:integration-test (default): 
target/failsafe-reports/*.xml
Recording test results
No test report files were found. Configuration error?
[withMaven] Jenkins Task Scanner Plugin not found, don't display results of 
source code scanning for 'TODO' and 'FIXME' in pipeline screen.
[DevOpticsMavenPublisher] dependencies consumed: 93, artifacts produced: 0
[withMaven] Publishers: Pipeline Graph Publisher: 1 ms, Generated Artifacts 
Publisher: 344 ms, Junit Publisher: 72456 ms, Dependencies Fingerprint 
Publisher: 705 ms, Open Task Scanner Publisher: 9 ms, CloudBees DevOptics Gate 
Artifact Publisher: 33121 ms
[Pipeline] // withMaven
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // timeout
[Pipeline] stage
[Pipeline] { (Notifications)
[Pipeline] echo
Status change is BROKEN, notifications will be sent.
[Pipeline] emailext

[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #965 is FIXED

2022-03-10 Thread Apache Jenkins Server
Please see 
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/965/
 for details.

No further emails will be sent until the status of the build is changed.

Re: [Content Loader] Decide on approach to unblock Sling 12

2022-03-10 Thread Robert Munteanu
Hi Stefan,

Thanks for setting this up, very helpful.

On Thu, 2022-03-10 at 16:33 +, Stefan Seifert wrote:
> during release process of Sling 12 we discovered SLING-11189 [1]
> which happens only on certain windows environments, but is there a
> blocker as Sling-Initial-Content from bundles like composum (may
> affect other apps as well) are corrupted during extraction, actually
> breaking the application. the root cause is a race condition on sling
> startup where the content reader implementations are registered after
> the whiteboard for handling them is registered, and after the first
> bundles are actually processed.
> 
> to solve this we have multiple approaches, i want to do a quick vote
> on these options to unblock the release:

Any of a-z would actually work for me. I would prefer we don't lose the
benefit of declarative services, if at all possible.

One constraint I would like us to keep is to not log additional
WARN/ERROR entries, so b) would likely need to be combined with a) into
c), or be adjusted.

FWIW, this is how this is how a similar problem is approached in Oak
[5].

Thanks,
Robert
> 
> a) apply only PR #12 [2] which simply defines a mandatory dependency
> between the whiteboard and the 4 built-in readers via DS. the list of
> mandatory readers is hardcoded in the code.
> 
> b) apply only PR #13 [3] which introduces a new directive
> "requireImportProviders" allowing bundles to actually define which
> import providers they depend on, and if those are not there the
> importing of the initial content is delayed until they become
> available. if the directive is missing a default list is assumed
> which is configurable via OSGi (and defaults to the 4 built-in
> readers). the current implementation has the small drawback that it
> prints out some error messages in case the bundle processing is
> delayed, even if it's only for a few milliseconds due to sling
> startup.
> 
> c) combine PR #12 [2] and PR #13 [3] to avoid the error messages for
> the built-in readers.
> 
> d) look for other solutions, e.g. implementing a) "the other way
> around" by having the whiteboard register the reader implementations
> itself, which probably means moving away from DS for those reader
> service implementations.
> 
> z) take more time for discussing the options a)-d) and go with
> workaround from [4] for Sling 12 which fixes this issue via
> configuration only for Sling Starter, not in the content loader
> bundle itself.
> 
> please cast your votes on this options.
> 
> stefan
> 
> [1] https://issues.apache.org/jira/browse/SLING-11189
> [2]
> https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12
> [3]
> https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/13
> [4] https://github.com/apache/sling-org-apache-sling-starter/pull/59

[5]:
https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/internal/SecurityProviderRegistration.java


[GitHub] [sling-org-apache-sling-jcr-contentloader] sonarcloud[bot] commented on pull request #14: SLING-11194 Content Loader: Add log message if Sling-Initial-Content is not processed due to stale lo

2022-03-10 Thread GitBox


sonarcloud[bot] commented on pull request #14:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/14#issuecomment-1064294793


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=14=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=14=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=14=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=14=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=14=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=14=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader=14=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader=14=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader=14=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=14=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=14=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=14=false=CODE_SMELL)
   
   
[![100.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/100-16px.png
 
'100.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=14=new_coverage=list)
 [100.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=14=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=14=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=14=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-starter] rombert merged pull request #61: Update to o.a.s.event 4.3.0

2022-03-10 Thread GitBox


rombert merged pull request #61:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/61


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] commented on pull request #61: Update to o.a.s.event 4.3.0

2022-03-10 Thread GitBox


sonarcloud[bot] commented on pull request #61:
URL: 
https://github.com/apache/sling-org-apache-sling-starter/pull/61#issuecomment-1064285803


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=61=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=61=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=61=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=61=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=61=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=61=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=61=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=61=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=61=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=61=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=61=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=61=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter=61)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter=61=duplicated_lines_density=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (SLING-11194) Content Loader: Add log message if Sling-Initial-Content is not processed due to stale lock node at /var/sling/bundle-content

2022-03-10 Thread Stefan Seifert (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17504422#comment-17504422
 ] 

Stefan Seifert commented on SLING-11194:


PR: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/14

> Content Loader: Add log message if Sling-Initial-Content is not processed due 
> to stale lock node at /var/sling/bundle-content
> -
>
> Key: SLING-11194
> URL: https://issues.apache.org/jira/browse/SLING-11194
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: JCR ContentLoader 2.5.0
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> we had one occurrence of a very difficult to debug issue that on only one out 
> of many instances a given bundle with Sling-Initial-Content was not processed 
> properly when the bundle was registered by ContentLoader without any 
> indication about the reason in the log files, even at DEBUG level.
> only the message {{Registering bundle XYZ for content loading.}} was logged 
> but nothing more, the Sling-Initial-Content was completely ignored.
> we found out that the root cause was a stale "locking node" at 
> {{/var/sling/bundle-content/XYZ}} which was probably left there after and 
> unexpected instance shutdown or other failure. the problem was solved by 
> deleting this locking node, but the error log did not help. we should add 
> some more DEBUG log messages in this error to help diagnosing rare problems 
> like this.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [sling-org-apache-sling-jcr-contentloader] stefanseifert opened a new pull request #14: SLING-11194 Content Loader: Add log message if Sling-Initial-Content is not processed due to stale lock

2022-03-10 Thread GitBox


stefanseifert opened a new pull request #14:
URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/14


   https://issues.apache.org/jira/browse/SLING-11194


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Resolved] (SLING-11195) Downgrade ANTLR to match Sling HTL Engine

2022-03-10 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-11195.
-
Resolution: Fixed

> Downgrade ANTLR to match Sling HTL Engine
> -
>
> Key: SLING-11195
> URL: https://issues.apache.org/jira/browse/SLING-11195
> Project: Sling
>  Issue Type: Improvement
>  Components: Starter
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Starter 12
>
>
> (Description copied from 
> https://github.com/apache/sling-org-apache-sling-starter/pull/34 )
> Opening http://localhost/htl/repl.html gives the following warning:
> ANTLR Tool version 4.7.1 used for code generation does not match the current 
> runtime version 4.9.1
> ANTLR Runtime version 4.7.1 used for parser compilation does not match the 
> current runtime version 4.9.1
> This is caused by Sling HTL Engine being compiled with ANTLR 4.7.1. This is 
> probably harmless (HTL works fine seemingly), but one static field was 
> removed in antlr-runtime (no idea how important), so the versions are in 
> principle not ABI compatible.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [sling-org-apache-sling-starter] rombert commented on pull request #34: Downgrade ANTLR to match Sling HTL Engine

2022-03-10 Thread GitBox


rombert commented on pull request #34:
URL: 
https://github.com/apache/sling-org-apache-sling-starter/pull/34#issuecomment-1064280378


   Thanks for the PR @golinski , applied it after creating a Jira issue for it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-starter] rombert merged pull request #34: Downgrade ANTLR to match Sling HTL Engine

2022-03-10 Thread GitBox


rombert merged pull request #34:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/34


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (SLING-11194) Content Loader: Add log message if Sling-Initial-Content is not processed due to stale lock node at /var/sling/bundle-content

2022-03-10 Thread Stefan Seifert (Jira)
Stefan Seifert created SLING-11194:
--

 Summary: Content Loader: Add log message if Sling-Initial-Content 
is not processed due to stale lock node at /var/sling/bundle-content
 Key: SLING-11194
 URL: https://issues.apache.org/jira/browse/SLING-11194
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Affects Versions: JCR ContentLoader 2.5.0
Reporter: Stefan Seifert
Assignee: Stefan Seifert


we had one occurrence of a very difficult to debug issue that on only one out 
of many instances a given bundle with Sling-Initial-Content was not processed 
properly when the bundle was registered by ContentLoader without any indication 
about the reason in the log files, even at DEBUG level.

only the message {{Registering bundle XYZ for content loading.}} was logged but 
nothing more, the Sling-Initial-Content was completely ignored.

we found out that the root cause was a stale "locking node" at 
{{/var/sling/bundle-content/XYZ}} which was probably left there after and 
unexpected instance shutdown or other failure. the problem was solved by 
deleting this locking node, but the error log did not help. we should add some 
more DEBUG log messages in this error to help diagnosing rare problems like 
this.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Created] (SLING-11195) Downgrade ANTLR to match Sling HTL Engine

2022-03-10 Thread Robert Munteanu (Jira)
Robert Munteanu created SLING-11195:
---

 Summary: Downgrade ANTLR to match Sling HTL Engine
 Key: SLING-11195
 URL: https://issues.apache.org/jira/browse/SLING-11195
 Project: Sling
  Issue Type: Improvement
  Components: Starter
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Starter 12


(Description copied from 
https://github.com/apache/sling-org-apache-sling-starter/pull/34 )

Opening http://localhost/htl/repl.html gives the following warning:

ANTLR Tool version 4.7.1 used for code generation does not match the current 
runtime version 4.9.1
ANTLR Runtime version 4.7.1 used for parser compilation does not match the 
current runtime version 4.9.1

This is caused by Sling HTL Engine being compiled with ANTLR 4.7.1. This is 
probably harmless (HTL works fine seemingly), but one static field was removed 
in antlr-runtime (no idea how important), so the versions are in principle not 
ABI compatible.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Resolved] (SLING-11193) Configure the quartz scheduler with the known allowed thread pool names

2022-03-10 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-11193.
-
Resolution: Fixed

> Configure the quartz scheduler with the known allowed thread pool names
> ---
>
> Key: SLING-11193
> URL: https://issues.apache.org/jira/browse/SLING-11193
> Project: Sling
>  Issue Type: Improvement
>  Components: Starter
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Starter 12
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Running the Starter now produces warnings similar to 
> {noformat}
> 10.03.2022 15:47:32.111 *WARN* [FelixStartLevel] 
> org.apache.sling.commons.scheduler.impl.QuartzScheduler Scheduler job 
> requested thread pool with name oak but this thread pool is not in the list 
> of allowed pools.
> 10.03.2022 15:47:32.111 *WARN* [FelixStartLevel] 
> org.apache.sling.commons.scheduler.impl.QuartzScheduler Scheduler job 
> requested thread pool with name oak but this thread pool is not in the list 
> of allowed pools.
> 10.03.2022 15:47:32.111 *WARN* [FelixStartLevel] 
> org.apache.sling.commons.scheduler.impl.QuartzScheduler Scheduler job 
> requested thread pool with name oak but this thread pool is not in the list 
> of allowed pools.
> 10.03.2022 15:47:32.111 *WARN* [FelixStartLevel] 
> org.apache.sling.commons.scheduler.impl.QuartzScheduler Scheduler job 
> requested thread pool with name oak but this thread pool is not in the list 
> of allowed pools.
> {noformat}
> This needs to be configured via 
> https://github.com/apache/sling-org-apache-sling-commons-scheduler/blob/08cbef57b9623e842486624b1e29bcb1754eae54/src/main/java/org/apache/sling/commons/scheduler/impl/QuartzSchedulerConfiguration.java#L35-L39
>  .



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [sling-org-apache-sling-starter] rombert merged pull request #60: SLING-11193 - Configure the quartz scheduler with the known allowed thread pool names

2022-03-10 Thread GitBox


rombert merged pull request #60:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/60


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] commented on pull request #60: SLING-11193 - Configure the quartz scheduler with the known allowed thread pool names

2022-03-10 Thread GitBox


sonarcloud[bot] commented on pull request #60:
URL: 
https://github.com/apache/sling-org-apache-sling-starter/pull/60#issuecomment-1064269982


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=60=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=60=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=60=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=60=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=60=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=60=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=60=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=60=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=60=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=60=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=60=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=60=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter=60)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter=60=duplicated_lines_density=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (SLING-11189) Content Loader: Race condition registering readers vs. loading content

2022-03-10 Thread Stefan Seifert (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-11189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17504405#comment-17504405
 ] 

Stefan Seifert commented on SLING-11189:


i've started a dicsussion on the mailing list with the available options to 
vote on the way to get this finally resolved: 
https://lists.apache.org/thread/cys2k35dkh3k9o9ys9nbrpnx9szcgdmh

> Content Loader: Race condition registering readers vs. loading content
> --
>
> Key: SLING-11189
> URL: https://issues.apache.org/jira/browse/SLING-11189
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: JCR ContentLoader 2.5.0
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: JCR ContentLoader 2.5.2
>
>  Time Spent: 4h
>  Remaining Estimate: 0h
>
> in SLING-11168 we detected a specific problem with Composum in Sling Starter 
> 12, which only occured on Windows 10 environments (and even there not 
> consistently in every scenario).
> it seems that it may happen that Sling-Initial-Content is loaded from the 
> bundles when the ContentReader implementations are not yet registered on the 
> ContentReaderWhiteboard.
> when this happens, the content is loaded into the repository, but files like 
> *.json are not transformed to nodes and properties, but is stored as binary 
> json files in the repository.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


RE: [Content Loader] Decide on approach to unblock Sling 12

2022-03-10 Thread Stefan Seifert
+1 for either a) or c) from my side

stefan


[Content Loader] Decide on approach to unblock Sling 12

2022-03-10 Thread Stefan Seifert
during release process of Sling 12 we discovered SLING-11189 [1] which happens 
only on certain windows environments, but is there a blocker as 
Sling-Initial-Content from bundles like composum (may affect other apps as 
well) are corrupted during extraction, actually breaking the application. the 
root cause is a race condition on sling startup where the content reader 
implementations are registered after the whiteboard for handling them is 
registered, and after the first bundles are actually processed.

to solve this we have multiple approaches, i want to do a quick vote on these 
options to unblock the release:

a) apply only PR #12 [2] which simply defines a mandatory dependency between 
the whiteboard and the 4 built-in readers via DS. the list of mandatory readers 
is hardcoded in the code.

b) apply only PR #13 [3] which introduces a new directive 
"requireImportProviders" allowing bundles to actually define which import 
providers they depend on, and if those are not there the importing of the 
initial content is delayed until they become available. if the directive is 
missing a default list is assumed which is configurable via OSGi (and defaults 
to the 4 built-in readers). the current implementation has the small drawback 
that it prints out some error messages in case the bundle processing is 
delayed, even if it's only for a few milliseconds due to sling startup.

c) combine PR #12 [2] and PR #13 [3] to avoid the error messages for the 
built-in readers.

d) look for other solutions, e.g. implementing a) "the other way around" by 
having the whiteboard register the reader implementations itself, which 
probably means moving away from DS for those reader service implementations.

z) take more time for discussing the options a)-d) and go with workaround from 
[4] for Sling 12 which fixes this issue via configuration only for Sling 
Starter, not in the content loader bundle itself.

please cast your votes on this options.

stefan

[1] https://issues.apache.org/jira/browse/SLING-11189
[2] https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12
[3] https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/13
[4] https://github.com/apache/sling-org-apache-sling-starter/pull/59


[GitHub] [sling-org-apache-sling-starter] rombert opened a new pull request #60: SLING-11193 - Configure the quartz scheduler with the known allowed thread pool names

2022-03-10 Thread GitBox


rombert opened a new pull request #60:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/60


   Allow a thread pool named 'oak'.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (SLING-11193) Configure the quartz scheduler with the known allowed thread pool names

2022-03-10 Thread Robert Munteanu (Jira)
Robert Munteanu created SLING-11193:
---

 Summary: Configure the quartz scheduler with the known allowed 
thread pool names
 Key: SLING-11193
 URL: https://issues.apache.org/jira/browse/SLING-11193
 Project: Sling
  Issue Type: Improvement
  Components: Starter
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Starter 12


Running the Starter now produces warnings similar to 

{noformat}
10.03.2022 15:47:32.111 *WARN* [FelixStartLevel] 
org.apache.sling.commons.scheduler.impl.QuartzScheduler Scheduler job requested 
thread pool with name oak but this thread pool is not in the list of allowed 
pools.
10.03.2022 15:47:32.111 *WARN* [FelixStartLevel] 
org.apache.sling.commons.scheduler.impl.QuartzScheduler Scheduler job requested 
thread pool with name oak but this thread pool is not in the list of allowed 
pools.
10.03.2022 15:47:32.111 *WARN* [FelixStartLevel] 
org.apache.sling.commons.scheduler.impl.QuartzScheduler Scheduler job requested 
thread pool with name oak but this thread pool is not in the list of allowed 
pools.
10.03.2022 15:47:32.111 *WARN* [FelixStartLevel] 
org.apache.sling.commons.scheduler.impl.QuartzScheduler Scheduler job requested 
thread pool with name oak but this thread pool is not in the list of allowed 
pools.
{noformat}

This needs to be configured via 
https://github.com/apache/sling-org-apache-sling-commons-scheduler/blob/08cbef57b9623e842486624b1e29bcb1754eae54/src/main/java/org/apache/sling/commons/scheduler/impl/QuartzSchedulerConfiguration.java#L35-L39
 .



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


Re: [VOTE] Release Apache Sling Scripting Core 2.4.6

2022-03-10 Thread Karl Pauls
+1

regards,

Karl

On Thu, Mar 10, 2022 at 5:08 PM Stefan Seifert
 wrote:
>
> +1
>
> stefan



-- 
Karl Pauls
karlpa...@gmail.com


Re: [VOTE] Release Apache Sling Discovery Commons 1.0.26 and Discovery Base 2.0.12

2022-03-10 Thread Stefan Egli

+1

Cheers,
Stefan

On 09.03.22 14:51, Stefan Egli wrote:

Hi,


We solved 2 issues completely and 1 issue partially in both of these release:
https://issues.apache.org/jira/projects/SLING/versions/12350269
https://issues.apache.org/jira/projects/SLING/versions/12350270

The main issue still open is SLING-10489, which will be fixed with upcoming discovery.oak release 
(which coincidentally, not, is dependent on Discovery Commons 1.0.26)



Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2610

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD 




Usage:
sh check_staged_release.sh 2610 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.


Cheers,
Stefan


RE: [VOTE] Release Apache Sling Scripting Core 2.4.6

2022-03-10 Thread Stefan Seifert
+1

stefan


[GitHub] [sling-org-apache-sling-discovery-oak] sonarcloud[bot] commented on pull request #4: SLING-10489 : introducing partial startup detector

2022-03-10 Thread GitBox


sonarcloud[bot] commented on pull request #4:
URL: 
https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/4#issuecomment-1064163864


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=4=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=4=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=4=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=4=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=4=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=4=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak=4=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak=4=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak=4=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=4=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=4=false=CODE_SMELL)
 [54 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=4=false=CODE_SMELL)
   
   
[![84.3%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png
 
'84.3%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=4=new_coverage=list)
 [84.3% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=4=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=4=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=4=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-discovery-oak] sonarcloud[bot] removed a comment on pull request #4: SLING-10489 : introducing partial startup detector

2022-03-10 Thread GitBox


sonarcloud[bot] removed a comment on pull request #4:
URL: 
https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/4#issuecomment-1062967546


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=4=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=4=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=4=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=4=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=4=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=4=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak=4=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak=4=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak=4=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=4=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=4=false=CODE_SMELL)
 [50 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=4=false=CODE_SMELL)
   
   
[![85.3%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png
 
'85.3%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=4=new_coverage=list)
 [85.3% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=4=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=4=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=4=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




Re: [VOTE] Release Apache Sling Scripting Core 2.4.6

2022-03-10 Thread Stefan Egli

+1,

Cheers,
Stefan

On 10.03.22 15:32, Radu Cotescu wrote:

Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12351342

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2611/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2611 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Radu Cotescu


Re: [VOTE] Release Apache Sling Starter 12 testing modules ( was: [VOTE] Release Apache Sling Starter 12, Apache Sling Project Archetype 1.0.6 and associated testing modules)

2022-03-10 Thread Stefan Egli

+1,

(245 artifacts if i counted that correctly)

Cheers,
Stefan

On 10.03.22 15:15, Robert Munteanu wrote:

Hi,

I have amended the staging repository to drop the
org.apache.sling.starter and sling-project-archetype artifacts.

The vote will continue with only the testing artifacts included.

The repository and check instructions remain the same, see below.

Thanks,
Robert

On Fri, 2022-02-25 at 17:37 +0100, Robert Munteanu wrote:

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2604

You can use this UNIX script to download the release and verify the
signatures:

https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2604 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Thanks,
Robert




[jira] [Commented] (SLING-11158) The starter's "Start Sling" instructions don't work with feature launcher v1.1.28 or later

2022-03-10 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-11158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17504338#comment-17504338
 ] 

Robert Munteanu commented on SLING-11158:
-

[~hanspeterstoerr] - yes, we have pinned the version to 1.1.26 until we have a 
plan for how to update to newer versions.

> The starter's "Start Sling" instructions don't work with feature launcher 
> v1.1.28 or later
> --
>
> Key: SLING-11158
> URL: https://issues.apache.org/jira/browse/SLING-11158
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Feature Model Launcher 1.1.28, Feature Model Launcher 
> 1.2.0
>Reporter: Eric Norman
>Priority: Major
> Fix For: Feature Launcher Maven Plugin 0.1.4, Feature Model 
> Launcher 1.2.2
>
>
> After the SLING-10956 changes, launching the Starter with the README provided 
> instructions while using the v1.1.28 or later feature launcher does not work 
> anymore.
> For example,
> {noformat}
> $ java -jar target/dependency/org.apache.sling.feature.launcher.jar -f 
> target/slingfeature-tmp/feature-oak_tar.json
> Error: Unable to initialize main class 
> org.apache.sling.feature.launcher.impl.Main
> Caused by: java.lang.NoClassDefFoundError: 
> org/apache/commons/cli/ParseException{noformat}
>  
> Also, the start goal of the feature-launcher-maven-plugin fails with the same 
> exception when paired with a featureLauncherVersion of 1.1.28 or later.
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [sling-org-apache-sling-jcr-contentloader] stefanseifert edited a comment on pull request #12: SLING-11189 ensure all built-in content readers are registered before processing any bundle in t

2022-03-10 Thread GitBox


stefanseifert edited a comment on pull request #12:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-1064151813


   played around a bit with "the other way around" letting the whiteboard 
directly register the content readers itself - in actual code it's not looking 
more elegant than the current approach. it still prefer the approach from this 
PR, probably in combination with #13.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-jcr-contentloader] stefanseifert commented on pull request #12: SLING-11189 ensure all built-in content readers are registered before processing any bundle in this lis

2022-03-10 Thread GitBox


stefanseifert commented on pull request #12:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-1064151813


   played around a bit with "the other way around" letting the whiteboard 
directly register the content readers itself - in actual code it's not looking 
more elegant than the current approach. it sill prefer the approach from this 
PR, probably in combination with #13.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Assigned] (SLING-11173) Wrong version of org.osgi.framework exported (OSGi R7 instead of OSGi R8)

2022-03-10 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus reassigned SLING-11173:
---

Assignee: Konrad Windszus

> Wrong version of org.osgi.framework exported (OSGi R7 instead of OSGi R8)
> -
>
> Key: SLING-11173
> URL: https://issues.apache.org/jira/browse/SLING-11173
> Project: Sling
>  Issue Type: Bug
>  Components: Starter
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Blocker
> Fix For: Starter 12
>
>
> Although Felix was updated in SLING-10409 to Felix 7 (OSGi R8 compliant) the 
> package exports are still only for OSGi R7 in 
> https://github.com/apache/sling-org-apache-sling-starter/blob/150e60df97a6d8911e938b76903f64d54f1201df/src/main/features/boot.json#L151.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Resolved] (SLING-11173) Wrong version of org.osgi.framework exported (OSGi R7 instead of OSGi R8)

2022-03-10 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus resolved SLING-11173.
-
Resolution: Fixed

This was fixed through https://issues.apache.org/jira/browse/SLING-9624.

> Wrong version of org.osgi.framework exported (OSGi R7 instead of OSGi R8)
> -
>
> Key: SLING-11173
> URL: https://issues.apache.org/jira/browse/SLING-11173
> Project: Sling
>  Issue Type: Bug
>  Components: Starter
>Reporter: Konrad Windszus
>Priority: Blocker
> Fix For: Starter 12
>
>
> Although Felix was updated in SLING-10409 to Felix 7 (OSGi R8 compliant) the 
> package exports are still only for OSGi R7 in 
> https://github.com/apache/sling-org-apache-sling-starter/blob/150e60df97a6d8911e938b76903f64d54f1201df/src/main/features/boot.json#L151.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (SLING-11158) The starter's "Start Sling" instructions don't work with feature launcher v1.1.28 or later

2022-03-10 Thread Hans-Peter Stoerr (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-11158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17504326#comment-17504326
 ] 

Hans-Peter Stoerr commented on SLING-11158:
---

Unfortunately, this also applies to version 1.2.0 of the feature launcher. :( 
So both releases are unusable.

> The starter's "Start Sling" instructions don't work with feature launcher 
> v1.1.28 or later
> --
>
> Key: SLING-11158
> URL: https://issues.apache.org/jira/browse/SLING-11158
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Feature Model Launcher 1.1.28, Feature Model Launcher 
> 1.2.0
>Reporter: Eric Norman
>Priority: Major
> Fix For: Feature Launcher Maven Plugin 0.1.4, Feature Model 
> Launcher 1.2.2
>
>
> After the SLING-10956 changes, launching the Starter with the README provided 
> instructions while using the v1.1.28 or later feature launcher does not work 
> anymore.
> For example,
> {noformat}
> $ java -jar target/dependency/org.apache.sling.feature.launcher.jar -f 
> target/slingfeature-tmp/feature-oak_tar.json
> Error: Unable to initialize main class 
> org.apache.sling.feature.launcher.impl.Main
> Caused by: java.lang.NoClassDefFoundError: 
> org/apache/commons/cli/ParseException{noformat}
>  
> Also, the start goal of the feature-launcher-maven-plugin fails with the same 
> exception when paired with a featureLauncherVersion of 1.1.28 or later.
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


Re: [VOTE] Release Apache Sling Scripting Core 2.4.6

2022-03-10 Thread Robert Munteanu
On Thu, 2022-03-10 at 14:32 +, Radu Cotescu wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part


[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] commented on pull request #55: SLING-11170 update to DS 1.5 compatible implementation of Felix SCR

2022-03-10 Thread GitBox


sonarcloud[bot] commented on pull request #55:
URL: 
https://github.com/apache/sling-org-apache-sling-starter/pull/55#issuecomment-1064142558


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=55=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=55=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=55=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=55=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=55=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=55=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=55=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=55=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=55=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=55=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=55=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=55=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter=55)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter=55=duplicated_lines_density=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] removed a comment on pull request #55: SLING-11170 update to DS 1.5 compatible implementation of Felix SCR

2022-03-10 Thread GitBox


sonarcloud[bot] removed a comment on pull request #55:
URL: 
https://github.com/apache/sling-org-apache-sling-starter/pull/55#issuecomment-1064140389


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=55=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=55=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=55=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=55=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=55=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=55=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=55=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=55=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=55=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=55=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=55=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=55=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter=55)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter=55=duplicated_lines_density=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] commented on pull request #55: SLING-11170 update to DS 1.5 compatible implementation of Felix SCR

2022-03-10 Thread GitBox


sonarcloud[bot] commented on pull request #55:
URL: 
https://github.com/apache/sling-org-apache-sling-starter/pull/55#issuecomment-1064140389


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=55=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=55=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=55=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=55=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=55=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=55=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=55=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=55=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-starter=55=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=55=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=55=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=55=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter=55)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter=55=duplicated_lines_density=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Resolved] (SLING-9624) Get rid of custom "org.osgi.framework.system.packages"

2022-03-10 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus resolved SLING-9624.

Resolution: Fixed

Fixed in 
https://github.com/apache/sling-org-apache-sling-starter/commit/a2aba48787e0bac8e3fa333057e4c5f73523367c
 by relying on Felix default but exporting the XML packages in addition with 
the Sling-specific versions for backwards-compatibility.

> Get rid of custom "org.osgi.framework.system.packages"
> --
>
> Key: SLING-9624
> URL: https://issues.apache.org/jira/browse/SLING-9624
> Project: Sling
>  Issue Type: Improvement
>  Components: Starter
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Starter 12
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Instead of using a Sling specific "org.osgi.framework.system.packages" 
> property 
> (https://github.com/apache/sling-org-apache-sling-starter/blob/5f44b7f6c6b75e4cfd5574fb701c3e7eca8405ef/src/main/provisioning/launchpad.txt#L26)
>  we should just rely on the Felix default 
> (https://github.com/apache/felix-dev/blob/master/framework/src/main/resources/default.properties)
>  to not miss to export all relevant packages for the different JREs
> compare with 
> https://lists.apache.org/thread.html/r0aa3c02c38b5026e24684a00de3c6c8506e166334e77892ac2ee0ab3%40%3Cdev.sling.apache.org%3E.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (SLING-9624) Get rid of custom "org.osgi.framework.system.packages"

2022-03-10 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-9624:
---
Fix Version/s: Starter 12
   (was: Starter 13)

> Get rid of custom "org.osgi.framework.system.packages"
> --
>
> Key: SLING-9624
> URL: https://issues.apache.org/jira/browse/SLING-9624
> Project: Sling
>  Issue Type: Improvement
>  Components: Starter
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Starter 12
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Instead of using a Sling specific "org.osgi.framework.system.packages" 
> property 
> (https://github.com/apache/sling-org-apache-sling-starter/blob/5f44b7f6c6b75e4cfd5574fb701c3e7eca8405ef/src/main/provisioning/launchpad.txt#L26)
>  we should just rely on the Felix default 
> (https://github.com/apache/felix-dev/blob/master/framework/src/main/resources/default.properties)
>  to not miss to export all relevant packages for the different JREs
> compare with 
> https://lists.apache.org/thread.html/r0aa3c02c38b5026e24684a00de3c6c8506e166334e77892ac2ee0ab3%40%3Cdev.sling.apache.org%3E.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [sling-org-apache-sling-starter] kwin merged pull request #56: SLING-9624 rely on Felix defaults for system packages exports

2022-03-10 Thread GitBox


kwin merged pull request #56:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/56


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[VOTE] Release Apache Sling Scripting Core 2.4.6

2022-03-10 Thread Radu Cotescu
Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12351342

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2611/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2611 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Radu Cotescu


[jira] [Resolved] (SLING-11182) Correct potential errors introduced by BVP logging

2022-03-10 Thread Radu Cotescu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu resolved SLING-11182.
--
Resolution: Fixed

Fixed in [commit 
04e005b|https://github.com/apache/sling-org-apache-sling-scripting-core/commit/04e005bf059dffdbac550883a1da5901c531352f].

> Correct potential errors introduced by BVP logging
> --
>
> Key: SLING-11182
> URL: https://issues.apache.org/jira/browse/SLING-11182
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting Core 2.4.4
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting Core 2.4.6
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> SLING-11122 has the potential to introduce some NPEs in applications using an 
> older version of the Sling API but a newer version of the Scripting Core 
> bundle. The logging functionality introduced relies on the presence of the 
> {{RequestProgressTracker}}. However, older versions of the Sling API didn't 
> annotate 
> {{org.apache.sling.api.SlingHttpServletRequest#getRequestProgressTracker}} 
> with {{@NotNull}}.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (SLING-11192) Calculating metrics takes too long

2022-03-10 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-11192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17504305#comment-17504305
 ] 

Robert Munteanu commented on SLING-11192:
-

Maybe there is an opportunity here to add some support classes to the Sling 
Metrics bundle that provide cached metrics.

> Calculating metrics takes too long
> --
>
> Key: SLING-11192
> URL: https://issues.apache.org/jira/browse/SLING-11192
> Project: Sling
>  Issue Type: Improvement
>  Components: Event
>Affects Versions: Event 4.2.24
>Reporter: Joerg Hoh
>Priority: Major
>
> we use the prometheus exporter to export Sling Metrics / Dropwizard metrics, 
> and we often see messages like this:
> {noformat}
> 10.03.2022 08:50:15.333 [...] *WARN* [qtp568481508-1779] 
> io.prometheus.client.dropwizard.DropwizardExports Gauge has been blacklisted 
> for 30 ms due timeout:  Generated from Dropwizard metric import 
> (metric=sling_event.jobs.cancelled.count, 
> type=org.apache.sling.event.impl.jobs.stats.GaugeSupport$2) 
> {noformat}
> This means that calculating the metric took too long. We should make sure 
> that the calculation is done asnychronously and just pre-computed values are 
> returned.
> For at least these values the handling needs to be improved:
> * sling_event.jobs.active.count
> * sling_event.jobs.averageProcessingTime
> * sling_event.jobs.averageWaitingTime
> * sling_event.jobs.cancelled.count



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #963 is BROKEN

2022-03-10 Thread Apache Jenkins Server
er.pattern=[/], request.max=-1, service.bundleid=133, 
service.description=Filter for request parameter support, service.id=476, 
service.ranking=2147483647, service.scope=bundle, service.vendor=The Apache 
Software Foundation, sling.default.max.parameters=1, 
sling.default.parameter.checkForAdditionalContainerParameters=false, 
sling.default.parameter.encoding=ISO-8859-1}] Ignoring unmatching Filter service
[DEBUG] [ServiceReference 94 from bundle 39 : 
org.apache.sling.launchpad.test-services:13.0.0.SNAPSHOT 
ref=[javax.servlet.Servlet] properties={component.id=64, 
component.name=org.apache.sling.launchpad.testservices.servlets.R6WhiteboardServlet,
 objectClass=[javax.servlet.Servlet], 
osgi.http.whiteboard.context.select=(osgi.http.whiteboard.context.name=org.apache.sling),
 osgi.http.whiteboard.servlet.pattern=/whiteboard_r6, service.bundleid=39, 
service.id=94, service.scope=bundle}] Ignoring unmatching Servlet service
[INFO] Apachde Felix Http Whiteboard Service stopped
[INFO] Stopped Jetty.
[INFO] 
[INFO] --- tools-maven-plugin:1.4:verify-legal-files (verify-legal-files) @ 
org.apache.sling.launchpad.testing ---
[INFO] Checking legal files in: 
org.apache.sling.launchpad.testing-13-SNAPSHOT.jar
[INFO] Checking legal files in: 
org.apache.sling.launchpad.testing-13-SNAPSHOT-sources.jar
[INFO] 
[INFO] --- apache-rat-plugin:0.13:check (rat-check) @ 
org.apache.sling.launchpad.testing ---
[INFO] Enabled default license matchers.
[INFO] Will parse SCM ignores for exclusions...
[INFO] Parsing exclusions from 
/home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master/.gitignore
[INFO] Finished adding exclusions from SCM ignore files.
[INFO] 75 implicit excludes (use -debug for more details).
[INFO] 13 explicit excludes (use -debug for more details).
[INFO] 4 resources included (use -debug for more details)
[INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 
0, approved: 3 licenses.
[INFO] 
[INFO] --- maven-failsafe-plugin:2.21.0:verify (default) @ 
org.apache.sling.launchpad.testing ---
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time:  03:42 min
[INFO] Finished at: 2022-03-10T14:24:22Z
[INFO] 
[INFO] [jenkins-event-spy] Generated 
/home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master@tmp/withMaven42354386/maven-spy-20220310-142039-2629007645221222550626.log
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-failsafe-plugin:2.21.0:verify (default) on 
project org.apache.sling.launchpad.testing: There are test failures.
[ERROR] 
[ERROR] Please refer to 
/home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master/target/failsafe-reports
 for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump, 
[date].dumpstream and [date]-jvmRun[N].dumpstream.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[Pipeline] }
[withMaven] junitPublisher - Archive test results for Maven artifact 
org.apache.sling:org.apache.sling.launchpad.testing:jar:13-SNAPSHOT generated 
by maven-surefire-plugin:test (default-test): target/surefire-reports/*.xml
Recording test results
None of the test reports contained any result
[withMaven] junitPublisher - Archive test results for Maven artifact 
org.apache.sling:org.apache.sling.launchpad.testing:jar:13-SNAPSHOT generated 
by maven-failsafe-plugin:integration-test (default): 
target/failsafe-reports/*.xml
Recording test results
No test report files were found. Configuration error?
[withMaven] Jenkins Task Scanner Plugin not found, don't display results of 
source code scanning for 'TODO' and 'FIXME' in pipeline screen.
[DevOpticsMavenPublisher] dependencies consumed: 93, artifacts produced: 0
[withMaven] Publishers: Pipeline Graph Publisher: 1 ms, Generated Artifacts 
Publisher: 353 ms, Junit Publisher: 80662 ms, Dependencies Fingerprint 
Publisher: 1197 ms, Open Task Scanner Publisher: 9 ms, CloudBees DevOptics Gate 
Artifact Publisher: 41977 ms
[Pipeline] // withMaven
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // timeout
[Pipeline] stage
[Pipeline] { (Notifications)
[Pipeline] echo
Status change is BROKEN, notifications will be sent.
[Pipeline] emailext

Re: [VOTE] Release Apache Sling Starter 12 testing modules ( was: [VOTE] Release Apache Sling Starter 12, Apache Sling Project Archetype 1.0.6 and associated testing modules)

2022-03-10 Thread Robert Munteanu
On Thu, 2022-03-10 at 15:15 +0100, Robert Munteanu wrote:
> Hi,
> 
> I have amended the staging repository to drop the
> org.apache.sling.starter and sling-project-archetype artifacts.
> 
> The vote will continue with only the testing artifacts included.
> 
> The repository and check instructions remain the same, see below.
> 
> Thanks,
> Robert
> 
> On Fri, 2022-02-25 at 17:37 +0100, Robert Munteanu wrote:
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-2604
> > 
> > You can use this UNIX script to download the release and verify the
> > signatures:
> > 
> > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> > 
> > Usage:
> > sh check_staged_release.sh 2604 /tmp/sling-staging
> > 
> > Please vote to approve this release:


+1
Robert


signature.asc
Description: This is a digitally signed message part


[GitHub] [sling-org-apache-sling-discovery-oak] stefan-egli commented on pull request #4: SLING-10489 : introducing partial startup detector

2022-03-10 Thread GitBox


stefan-egli commented on pull request #4:
URL: 
https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/4#issuecomment-1064116176


   @mreutegg , now added a system property 
`org.apache.sling.discovery.oak.joinerdelay.enabled` that allows to overwrite 
the config as to whether this feature is enabled or not. The default of the 
config itself is disabled. The system property not being present hence results 
in the feature being disabled. This way IMO it is safe to go ahead with this 
PR, merge and release and revisit problems at a later stage if they arise. Wdyt?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[VOTE] Release Apache Sling Starter 12 testing modules ( was: [VOTE] Release Apache Sling Starter 12, Apache Sling Project Archetype 1.0.6 and associated testing modules)

2022-03-10 Thread Robert Munteanu
Hi,

I have amended the staging repository to drop the
org.apache.sling.starter and sling-project-archetype artifacts.

The vote will continue with only the testing artifacts included.

The repository and check instructions remain the same, see below.

Thanks,
Robert

On Fri, 2022-02-25 at 17:37 +0100, Robert Munteanu wrote:
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2604
> 
> You can use this UNIX script to download the release and verify the
> signatures:
> 
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 2604 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> 
> Thanks,
> Robert



[jira] [Updated] (SLING-10600) Add a mapping entry redirecting to the project's top-level content path

2022-03-10 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-10600:

Fix Version/s: Sling Project Archetype 1.0.8
   (was: Sling Project Archetype 1.0.6)

> Add a mapping entry redirecting to the project's top-level content path
> ---
>
> Key: SLING-10600
> URL: https://issues.apache.org/jira/browse/SLING-10600
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Sling Project Archetype 1.0.8
>
>
> When a project created via the sling-project-archetype is deployed it creates 
> an entry under {{/content/${contentFolderName}/home}} which is not easily 
> accessible. We should create a mapping entry that redirects to that page, 
> which is what many projects want.
> Since it can 'hijack' the front page we should not deploy it by default, but 
> allow enabling it from the sample module.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (SLING-10608) Refresh sample servlets

2022-03-10 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-10608:

Fix Version/s: Sling Project Archetype 1.0.8
   (was: Sling Project Archetype 1.0.6)

> Refresh sample servlets
> ---
>
> Key: SLING-10608
> URL: https://issues.apache.org/jira/browse/SLING-10608
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Sling Project Archetype 1.0.8
>
>
> We should improve the documentation and add more sample servlets.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (SLING-10604) Add default, simple, styling to the generated project

2022-03-10 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-10604:

Fix Version/s: Sling Project Archetype 1.0.8
   (was: Sling Project Archetype 1.0.6)

> Add default, simple, styling to the generated project
> -
>
> Key: SLING-10604
> URL: https://issues.apache.org/jira/browse/SLING-10604
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Sling Project Archetype 1.0.8
>
>
> We should make the generated project looks a bit better by adding some basic 
> layouts and a bit more content ( for the samples ).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (SLING-10363) Update to Sling Archetype Parent 6

2022-03-10 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-10363:

Fix Version/s: Sling Project Archetype 1.0.8
   (was: Sling Project Archetype 1.0.6)

> Update to Sling Archetype Parent 6
> --
>
> Key: SLING-10363
> URL: https://issues.apache.org/jira/browse/SLING-10363
> Project: Sling
>  Issue Type: Task
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Sling Project Archetype 1.0.8
>
>
> Update to sling-archetype-parent version 6 so the project will build properly 
> with java 11



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (SLING-10595) Project archetype should default to Java 11

2022-03-10 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-10595:

Fix Version/s: Sling Project Archetype 1.0.8
   (was: Sling Project Archetype 1.0.6)

> Project archetype should default to Java 11
> ---
>
> Key: SLING-10595
> URL: https://issues.apache.org/jira/browse/SLING-10595
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Sling Project Archetype 1.0.8
>
>
> The archetype generates projects configured with Java 7, which is really old. 
> Java 11 is probably a better conservative default.
> We should also configure the Jenkins job to build with Java 11.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (SLING-10594) Generated project imports with error in Eclipse

2022-03-10 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-10594:

Fix Version/s: Sling Project Archetype 1.0.8
   (was: Sling Project Archetype 1.0.6)

> Generated project imports with error in Eclipse
> ---
>
> Key: SLING-10594
> URL: https://issues.apache.org/jira/browse/SLING-10594
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: Sling Project Archetype 1.0.4
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Sling Project Archetype 1.0.8
>
>
> I generated a project using the following command
> {noformat}
> $ mvn archetype:generate \
>  -DarchetypeGroupId=org.apache.sling \
>  -DarchetypeArtifactId=sling-project-archetype \
>  -DarchetypeVersion=1.0.4 \
>  -B \
>  -DgroupId=com.example \
>  -DartifactId=apachecon001 \
>  -Dversion=1.0.0-SNAPSHOT \
>  -DartifactName=ApacheCon \
>  -Dpackage=com.example.apachecon \
>  -DpackageGroup=apachecon \
>  -DappsFolderName=apachecon001 \
>  -DcontentFolderName=apachecon001 \
>  -DslingModelSubPackage=models \
>  -DslingHostName=localhost \
>  -DslingPort=8080 \
>  -DoptionAll=y \
>  -DoptionExample=s
> {noformat}
> And ended up with a couple of compilation error in Eclipse:
> {noformat}
> Description   ResourcePathLocationType
> The declared package "empty" does not match the expected package 
> "com.example.apachecon.empty"DoesNothing.java
> /core/src/main/java/com/example/apachecon/empty line 17 Java Problem
> The declared package "com.example.apachecon.servlet" does not match the 
> expected package "com.example.apachecon.com.example.apachecon.servlet"
> ByPathServletTest.java  
> /core.example/src/test/java/com/example/apachecon/com/example/apachecon/servlet
>  line 17 Java Problem
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (SLING-10601) Add a launcher module to the project archetype

2022-03-10 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-10601:

Fix Version/s: Sling Project Archetype 1.0.8
   (was: Sling Project Archetype 1.0.6)

> Add a launcher module to the project archetype
> --
>
> Key: SLING-10601
> URL: https://issues.apache.org/jira/browse/SLING-10601
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Sling Project Archetype 1.0.8
>
>
> We should include a launcher module showing how to build on top of the Sling 
> Starter. The module should deploy the core bundle and the ui.apps module, but 
> not the all or any of the samples.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


Re: content hacks in the pipeline

2022-03-10 Thread Julian Sedding
Hi Nicolas

If you want to go with a decoration approach (whether it is via a
resource provider or decorator), a few classes I put into the
whiteboard a while ago might help [1]. I once used them to "mount"
repetitive and/or dynamic parts of AEM dialog definitions into a
static AEM dialog definition.

Regards
Julian

[1] https://github.com/apache/sling-whiteboard/tree/feature/sling-resource-graft

On Thu, Mar 10, 2022 at 10:55 AM Konrad Windszus  wrote:
>
> Hi Nicolas, anything which eases the process of content migration for 
> blue/green deployments will be highly appreciated. Hiding the differences on 
> the resource level sounds like a good idea although you probably have to 
> distinguish between read/write access. Looking forward to your proposal.
> Konrad
>
> > Am 10.03.2022 um 10:51 schrieb Nicolas Peltier :
> >
> > Hey,
> >
> > i've been discussing here & there several times about having sling pipes in
> > a CI/CD pipeline as part of a new application deployment where content
> > handling changed substantially and application v(n+1) can't work with
> > content v(n).
> > pipes responsibility would be to handle the switch of content to v(n+1).
> >
> > thinking/discussing about it, it does not sound right to me if there is no
> > possibility to serve 2 versions of the content at the same time and to
> > quickly validate that everything is correct, as it ends up being non
> > validated code (pipe on specific prod content is new).
> >
> > The other alternative is to have code handling both versions of the
> > content, when no occurrence of the v(n) content is there anymore (which can
> > be done by code, or accelerated eventually sling pipe execution), switch to
> > a simpler version. To make that approach less expensive, i was thinking
> > about something at sling level (resource provider and decorator) that would
> > help doing those things quicker, through some annotations.
> >
> > Any thoughts / feedbacks / concerns before i dig deeper ?
> >
> > Nicolas
>


[GitHub] [sling-org-apache-sling-jcr-contentloader] stefanseifert commented on pull request #12: SLING-11189 ensure all built-in content readers are registered before processing any bundle in this lis

2022-03-10 Thread GitBox


stefanseifert commented on pull request #12:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-1064060508


   yes, that probably would be more elegant. in that case we have to use osgi 
framework instead of DS i suppose.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-starter] jsedding commented on a change in pull request #59: SLING-11168 - Sling Starter 12: Unable to launch Composum

2022-03-10 Thread GitBox


jsedding commented on a change in pull request #59:
URL: 
https://github.com/apache/sling-org-apache-sling-starter/pull/59#discussion_r823709936



##
File path: src/main/features/base.json
##
@@ -358,6 +358,10 @@
 "user.mapping":[
 "org.apache.sling.jcr.contentloader=[sling-jcr-content-loader]"
 ]
+},
+"org.apache.sling.jcr.contentloader.internal.ContentReaderWhiteboard": 
{
+// SLING-11168 - ensure all four ootb readers are started
+"contentReader.cardinality.minimum": 4

Review comment:
   I agree this should not be a permanent fix. It may or may not be a good 
solution to unblock the Sling 12 release.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-jcr-contentloader] jsedding commented on pull request #12: SLING-11189 ensure all built-in content readers are registered before processing any bundle in this listener

2022-03-10 Thread GitBox


jsedding commented on pull request #12:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-1064050136


   We could also turn the problem around: create the reader instances using 
their respective constructor within the `ContentReaderWhiteboard` and also 
register them as services.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-starter] rombert commented on a change in pull request #59: SLING-11168 - Sling Starter 12: Unable to launch Composum

2022-03-10 Thread GitBox


rombert commented on a change in pull request #59:
URL: 
https://github.com/apache/sling-org-apache-sling-starter/pull/59#discussion_r823697047



##
File path: src/main/features/base.json
##
@@ -358,6 +358,10 @@
 "user.mapping":[
 "org.apache.sling.jcr.contentloader=[sling-jcr-content-loader]"
 ]
+},
+"org.apache.sling.jcr.contentloader.internal.ContentReaderWhiteboard": 
{
+// SLING-11168 - ensure all four ootb readers are started
+"contentReader.cardinality.minimum": 4

Review comment:
   I haven't followed the conversations closely. If we think are close to a 
final solution, then we can wait for a couple of days more, sure.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (SLING-11189) Content Loader: Race condition registering readers vs. loading content

2022-03-10 Thread Stefan Seifert (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-11189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17504248#comment-17504248
 ] 

Stefan Seifert commented on SLING-11189:


i've put some comments in PR #13, it also fixes the problem but produces 
unnecessary error messages at the moment.
probably we should just combine both PRs together for the best solution.

> Content Loader: Race condition registering readers vs. loading content
> --
>
> Key: SLING-11189
> URL: https://issues.apache.org/jira/browse/SLING-11189
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: JCR ContentLoader 2.5.0
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: JCR ContentLoader 2.5.2
>
>  Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> in SLING-11168 we detected a specific problem with Composum in Sling Starter 
> 12, which only occured on Windows 10 environments (and even there not 
> consistently in every scenario).
> it seems that it may happen that Sling-Initial-Content is loaded from the 
> bundles when the ContentReader implementations are not yet registered on the 
> ContentReaderWhiteboard.
> when this happens, the content is loaded into the repository, but files like 
> *.json are not transformed to nodes and properties, but is stored as binary 
> json files in the repository.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [sling-org-apache-sling-starter] stefanseifert commented on a change in pull request #59: SLING-11168 - Sling Starter 12: Unable to launch Composum

2022-03-10 Thread GitBox


stefanseifert commented on a change in pull request #59:
URL: 
https://github.com/apache/sling-org-apache-sling-starter/pull/59#discussion_r823695462



##
File path: src/main/features/base.json
##
@@ -358,6 +358,10 @@
 "user.mapping":[
 "org.apache.sling.jcr.contentloader=[sling-jcr-content-loader]"
 ]
+},
+"org.apache.sling.jcr.contentloader.internal.ContentReaderWhiteboard": 
{
+// SLING-11168 - ensure all four ootb readers are started
+"contentReader.cardinality.minimum": 4

Review comment:
   that would be possible, but is it worth taking those extra-roundtrip? i 
think we are very close to the final solution, we have even two PRs in place 
which actually fix the problem. once we have the final solution ready we could 
release a new contentloader bundle version together with the final sling 12 
starter?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




Re: Enable Web Analytics with Matomo?

2022-03-10 Thread Robert Munteanu
On Thu, 2022-03-10 at 13:58 +0100, Konrad Windszus wrote:
> At least the high-level dashboard doesn’t require any login:
> https://matomo.privacy.apache.org/ <
> https://matomo.privacy.apache.org/>
> I don’t know which additional info is exposed if you have an account
> TBH.

Got it, thanks.

Robert


[GitHub] [sling-org-apache-sling-jcr-contentloader] stefanseifert commented on pull request #13: SLING-11189 Race condition registering readers vs. loading content

2022-03-10 Thread GitBox


stefanseifert commented on pull request #13:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/13#issuecomment-1064032075


   maybe we should combine both PRs into a single PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-jcr-contentloader] stefanseifert commented on pull request #13: SLING-11189 Race condition registering readers vs. loading content

2022-03-10 Thread GitBox


stefanseifert commented on pull request #13:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/13#issuecomment-1064031216


   i can confirm that this PR actually fixes the problem loading composum on my 
windows environment, same as 
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12
   
   what is not so nice with this PR is the "log experience" - although nothing 
is "wrong" a lot of error messages are logged only due to the delayed startup 
behavior:
   
[220310_error.log](https://github.com/apache/sling-org-apache-sling-jcr-contentloader/files/8223524/220310_error.log)
   
   such an error message is important if there is really no fitting content 
reader present. but it should not be shown only because the reader from the 
same bundle takes a few microseconds more to load to be ready. this is 
confusing for anyone monitoring the error log.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




Re: Enable Web Analytics with Matomo?

2022-03-10 Thread Konrad Windszus
At least the high-level dashboard doesn’t require any login: 
https://matomo.privacy.apache.org/ 
I don’t know which additional info is exposed if you have an account TBH.
Konrad

> On 10. Mar 2022, at 13:56, Robert Munteanu  wrote:
> 
> On Mon, 2022-03-07 at 16:34 +0100, Konrad Windszus wrote:
>> WDYT about enabling web analytics with Matomo to learn more about our
>> visitors?
> 
> Sounds good to me. Is it already defined who can access the analytics
> data?
> 
> Thanks,
> Robert



Re: Enable Web Analytics with Matomo?

2022-03-10 Thread Robert Munteanu
On Mon, 2022-03-07 at 16:34 +0100, Konrad Windszus wrote:
> WDYT about enabling web analytics with Matomo to learn more about our
> visitors?

Sounds good to me. Is it already defined who can access the analytics
data?

Thanks,
Robert


[RESULT] [VOTE] Release Apache Sling Event Support 4.3.0

2022-03-10 Thread Robert Munteanu
Hi,

The vote has passed with the following result:

+1 (binding): Nicolas Peltier, Stefan Egli, Stefan Seifert
+1 (non-binding): none

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Regards,
Robert Munteanu


  1   2   >