Re: [HI][TAGS] Greetings
Like I said this is only add-ons For example in the tiles I need to develop for my own purpose a tag that verify if an attribute was set or not during the call of the tile. It has the same behavior as the logic:present tag but focus on the tiles. I also need to develop some add-ons for the bean:message for being flexible with arguments coming from beans or the logic:redirect Even some times I need to compare two beans with the logic tags. Cedric - Original Message - From: Joe Germuska [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Sent: Friday, October 15, 2004 2:33 AM Subject: Re: [HI][TAGS] Greetings I'm here to see if the struts development community is open for tags add-on for the existing struts tagslibs. Depends -- what do you have in mind? Going forward, I think we would only want to add tags that are specifically focused around Struts functionality. Tags that don't depend on Struts don't really belong in the Struts project -- some might fit into existing Jakarta Taglibs projects, or might be proposed as new subprojects there, and others might make good projects on their own, like the displaytag libraries. What do your tag libraries do? Joe -- Joe Germuska [EMAIL PROTECTED] http://blog.germuska.com In fact, when I die, if I don't hear 'A Love Supreme,' I'll turn back; I'll know I'm in the wrong place. - Carlos Santana - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Roadmap
On Fri, 2004-10-15 at 00:22, Joe Germuska wrote: Hmmm You may be thinking of HiveMind, which is the refactored IOC-type container that grew out of Tapestry. HiveMind is similar in focus to Spring, but follows an approach that is similar to Eclipse. (separation of configuration, services, with extension points). No, I know about HiveMind, although I must admit that it seems like a lot of overhead for a lightweight container. So far, Spring is serving my purposes for dependency injection pretty well... agreed. With that said, let me just go on record as saying I was intrigued with Tapestry. We should definitely learn all the lessons we can from Tapestry, and all the other controllers out there. Easier for me to say than to do, although I have looked at WebWork a little bit. WebWorks reminds me of Struts. In fact, with small adjustments, struts can behave like WebWorks (I'm not suggesting it should ;-) (although struts can borrow some decorator ideas from site mesh -- with the request processor chain it could be possible to pretty easily make a StrutsMesh). What would StrutsMesh do that couldn't just be done with SiteMesh? I have only looked at SiteMesh a little, but it seems like it should be able to fit in anyway. I haven't put much thought into it. More so, I was using chain as a solution in search of a problem. But with that said SiteMesh decorator pattern utilizes request filters, which follows a very similar pattern to Chain (with exceptions). I thought it would be an interesting experiment with Chains to take SiteMesh and apply it to a template processing like velocity templates. I have some very email centric applications and this would be very handy for maintaining a consistent look and feel, and for applying users preferences (html -or- plain/text etc). As for StrutsMesh, I know that SiteMesh can just be used with filters, but if you could apply site mesh decorators at different stages in a custom request process you may be able to do some cool things utilizing info stored in the Request Context. For example, maybe using tiles definitions to decorate sections, or form validation results to decorate with error messages instead of tags. Just a thought... haven't really had time to play it out. The biggest bang for the buck of a StrutsMesh type thing, IMO, would be an abstraction of SiteMesh from the servlet container (assuming Struts chain is moving that way some day). This leads back to my original thoughts, about using SiteMesh + Chain to do offline template decoration. And just to be clear... I have no idea if SiteMesh is already capable of this type thing. From what I saw it was Filter focused. Please correct me if I'm wrong. - Mike -- Joe Germuska [EMAIL PROTECTED] http://blog.germuska.com In fact, when I die, if I don't hear 'A Love Supreme,' I'll turn back; I'll know I'm in the wrong place. - Carlos Santana - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [HI][TAGS] Greetings
In general, we are advising people to use JSTL tags wherever they serve a purpose that overlaps with Struts tags. It sounds like c:if and similar tags would probably serve most of your logic test needs. As for verifying the presence of a request attribute, it seems that the Jakarta Taglibs request taglib has a tag which can do that. http://jakarta.apache.org/taglibs/doc/request-doc/request-1.0/index.html#reference Struts tags that have a guaranteed future would be those that encode knowledge about things that Struts does uniquely -- for example, the logic:messagesPresent tag and the html:messages tag. Tags that do something which could be used in any JSP application, whether or not Struts is the controller, don't have many champions. We recommend that those be developed in a way which makes their independence from Struts more clear. Joe At 11:18 AM +0200 10/15/04, Levieux Cedric wrote: Like I said this is only add-ons For example in the tiles I need to develop for my own purpose a tag that verify if an attribute was set or not during the call of the tile. It has the same behavior as the logic:present tag but focus on the tiles. I also need to develop some add-ons for the bean:message for being flexible with arguments coming from beans or the logic:redirect Even some times I need to compare two beans with the logic tags. Cedric - Original Message - From: Joe Germuska [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Sent: Friday, October 15, 2004 2:33 AM Subject: Re: [HI][TAGS] Greetings I'm here to see if the struts development community is open for tags add-on for the existing struts tagslibs. Depends -- what do you have in mind? Going forward, I think we would only want to add tags that are specifically focused around Struts functionality. Tags that don't depend on Struts don't really belong in the Struts project -- some might fit into existing Jakarta Taglibs projects, or might be proposed as new subprojects there, and others might make good projects on their own, like the displaytag libraries. What do your tag libraries do? Joe -- Joe Germuska [EMAIL PROTECTED] http://blog.germuska.com In fact, when I die, if I don't hear 'A Love Supreme,' I'll turn back; I'll know I'm in the wrong place. - Carlos Santana - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Joe Germuska [EMAIL PROTECTED] http://blog.germuska.com In fact, when I die, if I don't hear 'A Love Supreme,' I'll turn back; I'll know I'm in the wrong place. - Carlos Santana - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Roadmap
And just to be clear... I have no idea if SiteMesh is already capable of this type thing. From what I saw it was Filter focused. Please correct me if I'm wrong. No, I'm pretty sure you're right there. You make some interesting points. It seems like it would be hard to get SiteMesh involved in decorating JSPs in any way but using filters, given some of the specifics of how JSPs are implemented, but I can't think of any reason you couldn't process HTML generated by Velocity or XSLT through a SiteMesh type process without being bound to Servlet Filters. A little poking around on the SiteMesh site turned up a link to Static Mesh for offline application of SiteMesh properties: http://www.pols.co.uk/downloads/static-mesh/ That might give some clues... Joe -- Joe Germuska [EMAIL PROTECTED] http://blog.germuska.com In fact, when I die, if I don't hear 'A Love Supreme,' I'll turn back; I'll know I'm in the wrong place. - Carlos Santana - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: struts-faces maven build
One issue is that no jsf artifacts exist on ibiblio. It turns out they are already on bluesunrise (You'll set this in the project.properties) That file actually gets generated as part of the build (along with the documentation file describing the tag library. In a binary distribution, you'll find it in the META-INF directory of struts-faces.jar as well. ah, so that's why I didn't see it. Ok, I took your ant scripts and put them in maven.xml, so the struts-faces.tld gets generated. I didn't do the doc one, but it's the same idea. I haven't used maven for producing docs at all. would I arrange the consolidation that is done in the top-level build.xml file of the struts-faces subdirectory, which basically delegates to the individual build scripts for each piece, and then combines the results? That's the genearl idea. You use the m:reactor jelly tag. I put this in the maven.xml which sits in the top struts-faces directory. You'll see in that tag I have an empty goals attribute. This calls the default goal, which is set in maven.xml. The other thing I did in this maven.xml is override the behaviors defined in the upper (struts-wide) maven.xml. Now you can just cd to struts-faces and type maven. This will generate struts-faces.jar and example1-webapp.war. I posted this latest patch: http://www.benanderson.us/bd/maven2.txt It's still kind of raw, but I think it displays most of the things you're looking for. You'll see I ran this diff from struts-faces instead of the base struts dir. One other thing - I finally got example1 working, but I had to add validator-rules.xml, which was absent. This needs to be there, correct? I don't see it in svn. Thanks, Ben - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31729] New: - Modify Action.getErrors to save the new ActionMessages
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31729.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=31729
Modify Action.getErrors to save the new ActionMessages
Summary: Modify Action.getErrors to save the new ActionMessages
Product: Struts
Version: 1.2.4
Platform: All
OS/Version: All
Status: NEW
Severity: Enhancement
Priority: Other
Component: Standard Actions
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
org.apache.struts.action.Action contains
protected ActionMessages getErrors(HttpServletRequest request) {
ActionMessages errors =
(ActionMessages) request.getAttribute(Globals.ERROR_KEY);
if (errors == null) {
errors = new ActionMessages();
}
return errors;
}
It may be considered more robust if the new messages object was always placed
in the request attribute thusly:
protected ActionMessages getErrors(HttpServletRequest request) {
ActionMessages errors =
(ActionMessages) request.getAttribute(Globals.ERROR_KEY);
if (errors == null) {
errors = new ActionMessages();
request.setAttribute(Globals.ERROR_KEY, errors);
}
return errors;
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31731] New: - ClassCastException from ActionServlet.getRequestProcessor()
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31731.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=31731
ClassCastException from ActionServlet.getRequestProcessor()
Summary: ClassCastException from
ActionServlet.getRequestProcessor()
Product: Struts
Version: 1.2.4
Platform: PC
OS/Version: Windows XP
Status: NEW
Severity: Major
Priority: Other
Component: Controller
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
This is just as much of a weblogic defect as a struts defect. I've logged a
case with bea, but they are slow to fix things.
When developing a Struts application in Weblogic 8.1, if you copy a
struts-related class to the weblogic deployment directory, Weblogic
automatically picks up that class so you can execute it immediately. However,
there is a problem with the weblogic classloader where it doesn't no that some
of the class loaders have changed.
The problem occurs on line 855 of ActionServlet in Struts 1.1 RC1, or line 605
in Struts 1.2.4. It casts the object in the ServletContext to a
RequestProcessor. The problem is that because the classloader for ActionServlet
is different than the original creator of RequestProcessor, a ClassCastException
is generated.
The fix is a simple two liner. Here's what worked for us (Struts 1.2.4,
ActionServlet):
private RequestProcessor getProcessorForModule(ModuleConfig config) {
String key = Globals.REQUEST_PROCESSOR_KEY + config.getPrefix();
Object proc = getServletContext().getAttribute(key);
// CHANGE: before casting, do an instanceof to
// catch the diff classloader issue
return (proc instanceof RequestProcessor) ? (RequestProcessor) proc : null;
}
I hope this helps since a lot of people develop on Struts and Weblogic 8.1.
Note, this is not a problem with earlier versions of Weblogic.
Adam
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [HI][TAGS] Greetings
On Fri, 15 Oct 2004 07:45:59 -0500, Joe Germuska [EMAIL PROTECTED] wrote:
In general, we are advising people to use JSTL tags wherever they
serve a purpose that overlaps with Struts tags. It sounds like
c:if and similar tags would probably serve most of your logic test
needs. As for verifying the presence of a request attribute, it
seems that the Jakarta Taglibs request taglib has a tag which can
do that.
http://jakarta.apache.org/taglibs/doc/request-doc/request-1.0/index.html#reference
Or you can use JSTL for this too:
c:if test=${requestScope.myAttr}
...
/c:if
--
Martin Cooper
Struts tags that have a guaranteed future would be those that encode
knowledge about things that Struts does uniquely -- for example, the
logic:messagesPresent tag and the html:messages tag. Tags that
do something which could be used in any JSP application, whether or
not Struts is the controller, don't have many champions. We
recommend that those be developed in a way which makes their
independence from Struts more clear.
Joe
At 11:18 AM +0200 10/15/04, Levieux Cedric wrote:
Like I said this is only add-ons
For example in the tiles I need to develop for my own purpose a tag that
verify if an attribute was set or not during the call of the tile.
It has the same behavior as the logic:present tag but focus on the tiles.
I also need to develop some add-ons for the bean:message for being flexible
with arguments coming from beans or the logic:redirect
Even some times I need to compare two beans with the logic tags.
Cedric
- Original Message -
From: Joe Germuska [EMAIL PROTECTED]
To: Struts Developers List [EMAIL PROTECTED]
Sent: Friday, October 15, 2004 2:33 AM
Subject: Re: [HI][TAGS] Greetings
I'm here to see if the struts development community is open for tags
add-on for the existing struts tagslibs.
Depends -- what do you have in mind?
Going forward, I think we would only want to add tags that are
specifically focused around Struts functionality. Tags that don't
depend on Struts don't really belong in the Struts project -- some
might fit into existing Jakarta Taglibs projects, or might be
proposed as new subprojects there, and others might make good
projects on their own, like the displaytag libraries.
What do your tag libraries do?
Joe
--
Joe Germuska
[EMAIL PROTECTED]
http://blog.germuska.com
In fact, when I die, if I don't hear 'A Love Supreme,' I'll turn
back; I'll know I'm in the wrong place.
- Carlos Santana
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
Joe Germuska
[EMAIL PROTECTED]
http://blog.germuska.com
In fact, when I die, if I don't hear 'A Love Supreme,' I'll turn
back; I'll know I'm in the wrong place.
- Carlos Santana
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31729] - Modify Action.getErrors to save the new ActionMessages
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31729. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31729 Modify Action.getErrors to save the new ActionMessages [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Additional Comments From [EMAIL PROTECTED] 2004-10-15 17:55 --- This will create a problem for existing apps that depend on it 'not being there' as opposed to 'being there, but having a size() of 0'. I am -1 on such a change. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31729] - Modify Action.getErrors to save the new ActionMessages
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31729. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31729 Modify Action.getErrors to save the new ActionMessages --- Additional Comments From [EMAIL PROTECTED] 2004-10-15 18:06 --- I think this should be considered an enhancement request for whichever compatibility-breaking version of struts is next released. I think reopening this with a future target milestone is appropriate. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17165] - logic:iterate tag not releasing collections from memory
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=17165. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=17165 logic:iterate tag not releasing collections from memory [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] Severity|Major |Normal Status|RESOLVED|REOPENED OS/Version|Solaris |All Platform|Sun |All Resolution|INVALID | Version|1.0.2 Final |1.2.4 --- Additional Comments From [EMAIL PROTECTED] 2004-10-15 18:35 --- I'm reopening this bug to mark it for a future patch. The issue with the handler is the use of a strong reference to the collection object. When there is a delay in the invocation of the handler's release method (as in the case of tag pooling), the handler's strong reference to the collection may outlive any other strong references to that object in the rest of the application. Obviously, that can cause an unnecessary delay in making the object available for GC. The patch will address this by having the handler maintain a strong reference to the object only during the execution of its doStartTag, doAfterBody, and doEndTag methods. Otherwise, the only reference maintained by the handler will be a weak reference. Unfortunately, this can't be done effectively until the minimum requirement is moved to at least JSP 1.2 so that the TryCatchFinally interface can be used. I should probably also state that patching the handler to implement TryCatchFinally will not break binary compatibility. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17165] - logic:iterate tag not releasing collections from memory
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=17165. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=17165 logic:iterate tag not releasing collections from memory [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||LATER --- Additional Comments From [EMAIL PROTECTED] 2004-10-15 18:38 --- Patch will be made available when minumum requirement is moved to at least JSP 1.2. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: CVS - SVN / Roadmap
I should be able to bring the Roadmap up to date later today (Friday), so you will be able to roll it over the weekend. -Ted. On Thu, 14 Oct 2004 15:40:56 -0700, Don Brown wrote: All that should remain is updating the roadmap, which I'll leave to folks more involved in the roadmap discussions. If there is anything else, let me know and I'll do it. Don - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17165] - logic:iterate tag not releasing collections from memory
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=17165. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=17165 logic:iterate tag not releasing collections from memory --- Additional Comments From [EMAIL PROTECTED] 2004-10-15 19:43 --- Sure, if an app can make use of JSTL, that's great, even preferable. But that won't make this bug go away ;-). Now, if the plan is that by the time Struts moves to JSP 1.2+ it will no longer include this handler, then the discussion is moot. The reason the handler currently has to wait until the release method is invoked to set the reference to null is because the container can determine that it doesn't need to explicitly set a pooled handler's properties (in this case via the handler's setCollection method). If the reference is set to null when the doEndTag method is invoked, then the handler's internal state will be out of sync with what the container expects. I'll have to check into the Standard Taglib stuff... - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31731] - ClassCastException from ActionServlet.getRequestProcessor()
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31731. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31731 ClassCastException from ActionServlet.getRequestProcessor() --- Additional Comments From [EMAIL PROTECTED] 2004-10-15 19:51 --- Just curious, have you tried the following in /WEB-INF/weblogic.xml: weblogic-web-app container-descriptor prefer-web-inf-classestrue/prefer-web-inf-classes /container-descriptor /weblogic-web-app By default, prefer-web-inf-classes is set to false, which means the standard J2SE classloader delegation is in effect. To get J2EE style classloading, set this to true. In other words, setting this to true makes WLS load classes more like Tomcat. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: struts-faces maven build
Just starting to play with the proposed patch now, but to answer your question ... On Fri, 15 Oct 2004 07:17:35 -0700, Ben Anderson [EMAIL PROTECTED] wrote: One other thing - I finally got example1 working, but I had to add validator-rules.xml, which was absent. This needs to be there, correct? I don't see it in svn. It doesn't need to be in svn for the example app itself, because it's copied from the lib directory of your Struts distribution, along with all the TLD files, in the static target of build.xml. The myfaces-specific variants are going to have more of the same sort of thing, because it requires some additional libraries not required by the JSF RI. Thanks, Ben Craig - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17165] - logic:iterate tag not releasing collections from memory
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=17165. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=17165 logic:iterate tag not releasing collections from memory --- Additional Comments From [EMAIL PROTECTED] 2004-10-16 00:00 --- Regarding Also, of course, that this is ultimately a problem of broken tag pooling implementations is annoying, the issue is not about broken tag pooling implementations. The implementations that do this are fully compliant with the JSP spec, and are not required to invoke release() until the tag handler instance itself is going away. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: rev 54884 - struts/trunk/struts-faces/core-library/src/java/org/apache/struts/faces/application
Author: craigmcc
Date: Fri Oct 15 17:14:53 2004
New Revision: 54884
Modified:
struts/trunk/struts-faces/core-library/src/java/org/apache/struts/faces/application/FacesTilesRequestProcessor.java
Log:
Commit the proposed change (from Piero Colagrosso, pcolagrosso AT yahoo.com)
to FacesTileRequestProcessor. This change cures the blank page scenarios
that I was able to reproduce -- hopefully others will download tonight's
nightly build (20041016) and test this in their own code.
PR: Bugzilla #30696.
Modified:
struts/trunk/struts-faces/core-library/src/java/org/apache/struts/faces/application/FacesTilesRequestProcessor.java
==
---
struts/trunk/struts-faces/core-library/src/java/org/apache/struts/faces/application/FacesTilesRequestProcessor.java
(original)
+++
struts/trunk/struts-faces/core-library/src/java/org/apache/struts/faces/application/FacesTilesRequestProcessor.java
Fri Oct 15 17:14:53 2004
@@ -147,7 +147,8 @@
if (log.isTraceEnabled()) {
log.trace( Marking request complete for ' + uri + ');
}
-context.responseComplete();
+// context.responseComplete();
+context.release();
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 30696] - Struts-Tiles-JSF-Integration SOMETIMES creates blank pages
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=30696. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=30696 Struts-Tiles-JSF-Integration SOMETIMES creates blank pages [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2004-10-16 00:18 --- I've applied the proposed change from Piero Colagrosso to FacesTilesRequestProcessor. This cures all the blank page scenarios that I have been able to reproduce. Please download the 20041016 nightly build tomorrow (or rebuild from current svn sources) and try this in your own applications. Many many thanks to Piero for the proposed solution! - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: rev 54886 - struts/trunk/struts-faces/example2-webapp/src/web/WEB-INF
Author: craigmcc Date: Fri Oct 15 17:31:56 2004 New Revision: 54886 Modified: struts/trunk/struts-faces/example2-webapp/src/web/WEB-INF/struts-config.xml Log: Correct logical forwards to point at the tiles definitions, instead of the JSP page that represents the body content. Among other things, this fixes the bug where entering an incorrect username/password combination on the logon page causes an exception. Thanks to Chris Wewerka for the clue that led to this realization. PR: Bugzilla #31015 Submitted by: Piero Colagrosso pcolagrosso AT yahoo.com Modified: struts/trunk/struts-faces/example2-webapp/src/web/WEB-INF/struts-config.xml == --- struts/trunk/struts-faces/example2-webapp/src/web/WEB-INF/struts-config.xml (original) +++ struts/trunk/struts-faces/example2-webapp/src/web/WEB-INF/struts-config.xml Fri Oct 15 17:31:56 2004 @@ -85,8 +85,8 @@ !-- == Global Forward Definitions == -- global-forwards -forward name=logoff path=/logoff.do/ -forward name=logonpath=/logon.faces/ +forward name=logoff path=.welcome/ +forward name=logonpath=.logon/ forward name=registration path=.registration/ forward name=subscription path=.subscription/ forward name=success path=.mainMenu/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31015] - Stack trace when running WAR File of struts-faces2 example - Tomcat 5.0.26
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31015. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31015 Stack trace when running WAR File of struts-faces2 example - Tomcat 5.0.26 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2004-10-16 00:34 --- Fixed in nightly build 20041016. It was a botch in my forward definition for logon, which was cut-n-pasted from the first version of the app, and pointed at the /logon.jsp page instead of the entire tile definition. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31097] - Struts-faces renders blank pages when refreshing page.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31097. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31097 Struts-faces renders blank pages when refreshing page. --- Additional Comments From [EMAIL PROTECTED] 2004-10-16 00:38 --- Could you please download the 20041016 version of the Struts-Faces nightly build, and try this again? It includes both the bugfix to FacesTilesRequestProcessor and a fix to the logical forwards in the Tiles-based example app. If the problem still occurs, I would be interested in seeing if it might be related to the JBoss Unified Class Loader. Could you try it with both settings for this property, to see if the behavior changes? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31220] - s:message and s:errors error
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31220. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31220 s:message and s:errors error --- Additional Comments From [EMAIL PROTECTED] 2004-10-16 00:41 --- Could you please try this again with the most recent nightly build (20041016) which includes some additional bugfixes? If it still fails, could you please try turning off the JBoss unified class loader and see if the behavior changes? It is quite interesting that so many reported issues are only reproducible under JBoss, so I'm trying to narrow down what particular settings might be involved. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31351] - JSF 1.1_01 and Struts-faces Problem
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31351. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31351 JSF 1.1_01 and Struts-faces Problem --- Additional Comments From [EMAIL PROTECTED] 2004-10-16 00:42 --- The 20041016 version of the nightly build will contain Piero's fix ... please download the new version (tomorrow morning) and try it again. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: rev 54888 - struts/trunk/src/test/org/apache/struts/taglib
Author: jmitchell
Date: Fri Oct 15 17:54:34 2004
New Revision: 54888
Added:
struts/trunk/src/test/org/apache/struts/taglib/TaglibTestBase.java (contents,
props changed)
Log:
new base class with a few utility methods
Added: struts/trunk/src/test/org/apache/struts/taglib/TaglibTestBase.java
==
--- (empty file)
+++ struts/trunk/src/test/org/apache/struts/taglib/TaglibTestBase.java Fri Oct 15
17:54:34 2004
@@ -0,0 +1,70 @@
+/*
+ * $Id$
+ *
+ * Copyright 1999-2004 The Apache Software Foundation.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License);
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.struts.taglib;
+
+import junit.framework.Assert;
+import junit.framework.Test;
+import junit.framework.TestSuite;
+
+import org.apache.cactus.JspTestCase;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
+import org.apache.oro.text.perl.Perl5Util;
+
+public class TaglibTestBase extends JspTestCase{
+
+private static Log log = LogFactory.getLog(TaglibTestBase.class);
+
+private Perl5Util perl = new Perl5Util();
+
+public TaglibTestBase(String arg0) {
+super(arg0);
+}
+// Return the tests included in this test suite
+public static Test suite() {
+return (new TestSuite(TaglibTestBase.class));
+}
+
+protected void runTest(String whichTest, String jsp) throws Exception {
+request.setAttribute(runTest, whichTest);
+pageContext.forward(jsp);
+}
+
+protected String replace(String source, String find, String replace){
+
+return perl.substitute(s/ + find + / + replace + /, source);
+
+}
+
+/**
+ * Utility method for reuse from the test JSPs.
+ * @param expected The expected results for the test.
+ * @param compareTo The results to compare to the expected results.
+ */
+public static void assertResults(String expected, String compareTo){
+Perl5Util perl = new Perl5Util();
+expected = perl.substitute(s/[\\r\\n]//gmx, expected);
+compareTo = perl.substitute(s/[\\r\\n]//gmx, compareTo);
+Assert.assertEquals(expected, compareTo);
+}
+
+public static void fail(String msg){
+Assert.fail(msg);
+}
+
+}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: rev 54890 - in struts/trunk/doc: . faqs
Author: husted Date: Fri Oct 15 17:58:00 2004 New Revision: 54890 Modified: struts/trunk/doc/acquiring.xml struts/trunk/doc/bylaws.xml struts/trunk/doc/faqs/kickstart.xml struts/trunk/doc/project.xml struts/trunk/doc/releases.xml struts/trunk/doc/using.xml Log: Update source repository references. Modified: struts/trunk/doc/acquiring.xml == --- struts/trunk/doc/acquiring.xml (original) +++ struts/trunk/doc/acquiring.xml Fri Oct 15 17:58:00 2004 @@ -76,20 +76,20 @@ li Nightly builds - Download the source directly via -a href=http://jakarta.apache.org/getinvolved/cvsindex.html; -Anonymous CVS/a. +a href=http://www.apache.org/dev/version-control.html; +anonymous access/a. /li li Nightly builds - Download the binary distributions from the - a href=http://cvs.apache.org/builds/jakarta-struts/nightly; +a href=http://svn.apache.org/builds/struts/nightly/; Struts nightly builds directory/a. /li li -Nightly builds - Download the source distributions from the -a href=http://cvs.apache.org/builds/jakarta-struts/nightly/src; -Struts nightly build source directory/a. +Nightly builds - Download the binary distributions from the + a href=http://svn.apache.org/builds/struts/nightly/; +Struts nightly builds directory/a. /li /ul @@ -105,7 +105,7 @@ p If you are interested in the Tag Library Descriptor (TLD) files, they are maintained in the -a href=http://cvs.apache.org/viewcvs/jakarta-struts/conf/share/; +a href=http://svn.apache.org/repos/asf/struts/trunk/conf/share/; /conf/share/a folder of the main repository. /p @@ -116,11 +116,11 @@ /p p -Access to the CVS source repository for Struts is available through both -a href=http://cvs.apache.org/viewcvs/jakarta-struts/;web browser/a +Access to the source repository for Struts is available through both +a href=http://svn.apache.org/viewcvs.cgi/struts/trunk/?root=Apache-SVN;web browser/a and -a href=http://jakarta.apache.org/getinvolved/cvsindex.html; -CVS client/a interfaces. +a href=http://www.apache.org/dev/version-control.html; +Subversion client/a interfaces. /p /section Modified: struts/trunk/doc/bylaws.xml == --- struts/trunk/doc/bylaws.xml (original) +++ struts/trunk/doc/bylaws.xml Fri Oct 15 17:58:00 2004 @@ -46,7 +46,8 @@ strongContributors./strong Contributors are the people who write code or documentation patches or contribute positively to the project in other ways. When a volunteer's -patch is applied, the contribution is recognized in the CVS log. +patch is applied, the contribution is recognized in the version control +log. /p p @@ -89,7 +90,7 @@ The PMC is responsible for the day-to-day management of the Struts Project. The PMC oversees all changes made to the codebase. The PMC must ensure that all code under a -Apache Struts CVS is the lawful property of the Foundation and +Apache Struts repository is the lawful property of the Foundation and may be distributed under the a href=http://apache.org/licenses/; Apache Software License/a. All releases of a Struts subproject must be sanctioned by the Project Management Committee. Modified: struts/trunk/doc/faqs/kickstart.xml == --- struts/trunk/doc/faqs/kickstart.xml (original) +++ struts/trunk/doc/faqs/kickstart.xml Fri Oct 15 17:58:00 2004 @@ -132,7 +132,7 @@ p For static unit tests, we use the a href=http://www.junit.org;JUnit framework/a. The sources for these tests are in the src/test -hierarchy in the CVS repository, and are executed via the test.junit +hierarchy in the source repository, and are executed via the test.junit target in the top-level build.xml file. Such tests are focused on the low-level functionality of individual methods, are particularly suitable for the static methods in the org.apache.struts.util utility @@ -291,7 +291,7 @@ a href=http://java.sun.com/j2ee/javaserverfaces/index.jsp;Java ServerFaces page/a. An early-release JavaServer Faces taglib for Struts, strongStruts-Faces/strong, is also in early release and available through the -a href=http://cvs.apache.org/builds/jakarta-struts/nightly/struts-faces/;nightly build/a. +a href=http://svn.apache.org/builds/jakarta-struts/nightly/struts-faces/;nightly build/a. The Struts Faces taglib is expected to work with any compliant JSF implementation, including a href=http://www.myfaces.org/;MyFaces/a. /p Modified: struts/trunk/doc/project.xml
svn commit: rev 54892 - struts/trunk/src/test/org/apache/struts/taglib/html
Author: jmitchell
Date: Fri Oct 15 17:58:59 2004
New Revision: 54892
Modified:
struts/trunk/src/test/org/apache/struts/taglib/html/TestBaseTag.java
Log:
Removing dependency on commons-lang
Modified: struts/trunk/src/test/org/apache/struts/taglib/html/TestBaseTag.java
==
--- struts/trunk/src/test/org/apache/struts/taglib/html/TestBaseTag.java
(original)
+++ struts/trunk/src/test/org/apache/struts/taglib/html/TestBaseTag.javaFri
Oct 15 17:58:59 2004
@@ -1,7 +1,7 @@
/*
* $Header:
/home/cvs/jakarta-struts/src/test/org/apache/struts/taglib/html/TestBaseTag.java,v
1.11 2004/03/14 06:23:41 sraeburn Exp $
* $Revision: 1.11 $
- * $Date: 2004/03/14 06:23:41 $
+ * $Date$
*
* Copyright 1999-2004 The Apache Software Foundation.
*
@@ -22,8 +22,8 @@
import junit.framework.Test;
import junit.framework.TestSuite;
-import org.apache.cactus.JspTestCase;
-import org.apache.commons.lang.StringUtils;
+import org.apache.struts.taglib.TaglibTestBase;
+
/**
@@ -31,7 +31,7 @@
* codeorg.apache.struts.taglib.html.BaseTag/code class.
*
*/
-public class TestBaseTag extends JspTestCase {
+public class TestBaseTag extends TaglibTestBase {
/**
* Defines the testcase name for JUnit.
@@ -65,13 +65,6 @@
pageContext.forward(/test/org/apache/struts/taglib/html/TestBaseTag.jsp);
}
- private void formatAndTest(String compare, String output) {
- //fix for introduced carriage return / line feeds
- output = StringUtils.replace(output,\r,);
- output = StringUtils.replace(output,\n,);
- output = output.trim();
- assertEquals(compare, output);
- }
/*
* Testing BaseTag.
*/
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: rev 54893 - struts/trunk/src/test/org/apache/struts/taglib/bean
Author: jmitchell
Date: Fri Oct 15 18:32:32 2004
New Revision: 54893
Modified:
struts/trunk/src/test/org/apache/struts/taglib/bean/TestStrutsTag.java
Log:
Removing dependency on commons-lang
Modified: struts/trunk/src/test/org/apache/struts/taglib/bean/TestStrutsTag.java
==
--- struts/trunk/src/test/org/apache/struts/taglib/bean/TestStrutsTag.java
(original)
+++ struts/trunk/src/test/org/apache/struts/taglib/bean/TestStrutsTag.java Fri
Oct 15 18:32:32 2004
@@ -1,7 +1,7 @@
/*
* $Header:
/home/cvs/jakarta-struts/src/test/org/apache/struts/taglib/bean/TestStrutsTag.java,v
1.8 2004/03/14 06:23:48 sraeburn Exp $
* $Revision: 1.8 $
- * $Date: 2004/03/14 06:23:48 $
+ * $Date$
*
* Copyright 1999-2004 The Apache Software Foundation.
*
@@ -22,19 +22,19 @@
import java.io.IOException;
import javax.servlet.ServletException;
+
import junit.framework.Test;
import junit.framework.TestSuite;
-import org.apache.cactus.JspTestCase;
import org.apache.cactus.WebResponse;
-import org.apache.commons.lang.StringUtils;
+import org.apache.struts.taglib.TaglibTestBase;
/**
* Suite of unit tests for the
* codeorg.apache.struts.taglib.bean.StrutsTag/code class.
*
*/
-public class TestStrutsTag extends JspTestCase {
+public class TestStrutsTag extends TaglibTestBase {
protected final static String TEST_VAL = Test Value;
protected final static String REQUEST_KEY = REQUEST_KEY;
@@ -67,8 +67,8 @@
private void formatAndTest(String compare, String output) {
//fix for introduced carriage return / line feeds
- output = StringUtils.replace(output,\r,);
- output = StringUtils.replace(output,\n,);
+ output = replace(output,\r,);
+ output = replace(output,\n,);
output = output.trim();
//System.out.println(Testing [ + compare + ] == [ + output + ]);
assertEquals(compare, output);
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: rev 54895 - struts/trunk/src/test/org/apache/struts/taglib/bean
Author: jmitchell
Date: Fri Oct 15 18:38:09 2004
New Revision: 54895
Modified:
struts/trunk/src/test/org/apache/struts/taglib/bean/TestCookieTag.java
Log:
Removing dependency on commons-lang
Modified: struts/trunk/src/test/org/apache/struts/taglib/bean/TestCookieTag.java
==
--- struts/trunk/src/test/org/apache/struts/taglib/bean/TestCookieTag.java
(original)
+++ struts/trunk/src/test/org/apache/struts/taglib/bean/TestCookieTag.java Fri
Oct 15 18:38:09 2004
@@ -1,7 +1,7 @@
/*
* $Header:
/home/cvs/jakarta-struts/src/test/org/apache/struts/taglib/bean/TestCookieTag.java,v
1.11 2004/07/06 06:38:52 craigmcc Exp $
* $Revision: 1.11 $
- * $Date: 2004/07/06 06:38:52 $
+ * $Date$
*
* Copyright 1999-2004 The Apache Software Foundation.
*
@@ -21,18 +21,14 @@
import junit.framework.Test;
import junit.framework.TestSuite;
-
-import org.apache.cactus.JspTestCase;
-import org.apache.cactus.WebRequest;
-import org.apache.cactus.WebResponse;
-import org.apache.commons.lang.StringUtils;
+import org.apache.struts.taglib.TaglibTestBase;
/**
* Suite of unit tests for the
* codeorg.apache.struts.taglib.bean.CookieTag/code class.
*
*/
-public class TestCookieTag extends JspTestCase {
+public class TestCookieTag extends TaglibTestBase {
protected final static String COOKIE_KEY = COOKIE_KEY;
protected final static String COOKIE_VAL = COOKIE_VAL;
@@ -73,8 +69,8 @@
private void formatAndTest(String compare, String output) {
//fix for introduced carriage return / line feeds
-output = StringUtils.replace(output,\r,);
-output = StringUtils.replace(output,\n,);
+output = replace(output,\r,);
+output = replace(output,\n,);
output = output.trim();
//System.out.println(Testing [ + compare + ] == [ + output + ]);
assertEquals(compare, output);
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: rev 54897 - struts/trunk/src/test/org/apache/struts/taglib/bean
Author: jmitchell
Date: Fri Oct 15 18:38:51 2004
New Revision: 54897
Modified:
struts/trunk/src/test/org/apache/struts/taglib/bean/TestPageTag.java
Log:
Removing dependency on commons-lang
Modified: struts/trunk/src/test/org/apache/struts/taglib/bean/TestPageTag.java
==
--- struts/trunk/src/test/org/apache/struts/taglib/bean/TestPageTag.java
(original)
+++ struts/trunk/src/test/org/apache/struts/taglib/bean/TestPageTag.javaFri
Oct 15 18:38:51 2004
@@ -1,7 +1,7 @@
/*
* $Header:
/home/cvs/jakarta-struts/src/test/org/apache/struts/taglib/bean/TestPageTag.java,v
1.10 2004/03/14 06:23:48 sraeburn Exp $
* $Revision: 1.10 $
- * $Date: 2004/03/14 06:23:48 $
+ * $Date$
*
* Copyright 1999-2004 The Apache Software Foundation.
*
@@ -20,19 +20,19 @@
package org.apache.struts.taglib.bean;
import javax.servlet.jsp.PageContext;
+
import junit.framework.Test;
import junit.framework.TestSuite;
-import org.apache.cactus.JspTestCase;
import org.apache.cactus.WebResponse;
-import org.apache.commons.lang.StringUtils;
+import org.apache.struts.taglib.TaglibTestBase;
/**
* Suite of unit tests for the
* codeorg.apache.struts.taglib.bean.PageTag/code class.
*
*/
-public class TestPageTag extends JspTestCase {
+public class TestPageTag extends TaglibTestBase {
protected final static String PAGETAG_KEY = PAGETAG_KEY;
protected final static String PAGETAG_VAL = PAGETAG_VAL;
@@ -71,8 +71,8 @@
private void formatAndTest(String compare, String output) {
//fix for introduced carriage return / line feeds
-output = StringUtils.replace(output,\r,);
-output = StringUtils.replace(output,\n,);
+output = replace(output,\r,);
+output = replace(output,\n,);
output = output.trim();
//System.out.println(Testing [ + compare + ] == [ + output + ]);
assertEquals(compare, output);
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: rev 54899 - struts/trunk/src/test/org/apache/struts/taglib/bean
Author: jmitchell
Date: Fri Oct 15 18:39:19 2004
New Revision: 54899
Modified:
struts/trunk/src/test/org/apache/struts/taglib/bean/TestIncludeTag.java
Log:
Removing dependency on commons-lang
Modified: struts/trunk/src/test/org/apache/struts/taglib/bean/TestIncludeTag.java
==
--- struts/trunk/src/test/org/apache/struts/taglib/bean/TestIncludeTag.java
(original)
+++ struts/trunk/src/test/org/apache/struts/taglib/bean/TestIncludeTag.java Fri
Oct 15 18:39:19 2004
@@ -1,7 +1,7 @@
/*
* $Header:
/home/cvs/jakarta-struts/src/test/org/apache/struts/taglib/bean/TestIncludeTag.java,v
1.12 2004/03/14 06:23:48 sraeburn Exp $
* $Revision: 1.12 $
- * $Date: 2004/03/14 06:23:48 $
+ * $Date$
*
* Copyright 1999-2004 The Apache Software Foundation.
*
@@ -21,15 +21,14 @@
import junit.framework.Test;
import junit.framework.TestSuite;
-
-import org.apache.cactus.JspTestCase;
+import org.apache.struts.taglib.TaglibTestBase;
/**
* Suite of unit tests for the
* codeorg.apache.struts.taglib.bean.IncludeTag/code class.
*
*/
-public class TestIncludeTag extends JspTestCase {
+public class TestIncludeTag extends TaglibTestBase {
/**
* Defines the testcase name for JUnit.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: rev 54900 - struts/trunk/src/test/org/apache/struts/taglib/bean
Author: jmitchell
Date: Fri Oct 15 18:39:30 2004
New Revision: 54900
Modified:
struts/trunk/src/test/org/apache/struts/taglib/bean/TestMessageTag.java
Log:
Removing dependency on commons-lang
Modified: struts/trunk/src/test/org/apache/struts/taglib/bean/TestMessageTag.java
==
--- struts/trunk/src/test/org/apache/struts/taglib/bean/TestMessageTag.java
(original)
+++ struts/trunk/src/test/org/apache/struts/taglib/bean/TestMessageTag.java Fri
Oct 15 18:39:30 2004
@@ -1,7 +1,7 @@
/*
* $Header:
/home/cvs/jakarta-struts/src/test/org/apache/struts/taglib/bean/TestMessageTag.java,v
1.10 2004/03/14 06:23:48 sraeburn Exp $
* $Revision: 1.10 $
- * $Date: 2004/03/14 06:23:48 $
+ * $Date$
*
* Copyright 1999-2004 The Apache Software Foundation.
*
@@ -22,14 +22,14 @@
import java.util.Locale;
import javax.servlet.jsp.PageContext;
+
import junit.framework.Test;
import junit.framework.TestSuite;
-import org.apache.cactus.JspTestCase;
import org.apache.cactus.WebResponse;
import org.apache.struts.Globals;
import org.apache.struts.taglib.SimpleBeanForTesting;
-import org.apache.commons.lang.StringUtils;
+import org.apache.struts.taglib.TaglibTestBase;
/**
* These tests attempt to cover every single possible configuration of the
@@ -42,7 +42,7 @@
* checked here in endXXX method.
*
*/
-public class TestMessageTag extends JspTestCase {
+public class TestMessageTag extends TaglibTestBase {
protected final static String TEST_KEY = BeanKey;
protected final static String TEST_VAL = Testing Message;
@@ -77,8 +77,8 @@
private void formatAndTest(String compare, String output) {
//fix for introduced carriage return / line feeds
-output = StringUtils.replace(output,\r,);
-output = StringUtils.replace(output,\n,);
+output = replace(output,\r,);
+output = replace(output,\n,);
output = output.trim();
//System.out.println(Testing [ + compare + ] == [ + output + ]);
assertEquals(compare, output);
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: rev 54901 - struts/trunk/src/test/org/apache/struts/taglib/bean
Author: jmitchell
Date: Fri Oct 15 18:39:50 2004
New Revision: 54901
Modified:
struts/trunk/src/test/org/apache/struts/taglib/bean/TestDefineTag.java
struts/trunk/src/test/org/apache/struts/taglib/bean/TestHeaderTag.java
struts/trunk/src/test/org/apache/struts/taglib/bean/TestMessageTag_fr.java
struts/trunk/src/test/org/apache/struts/taglib/bean/TestResourceTag.java
struts/trunk/src/test/org/apache/struts/taglib/bean/TestWriteTag.java
Log:
Removing dependency on commons-lang
Modified: struts/trunk/src/test/org/apache/struts/taglib/bean/TestDefineTag.java
==
--- struts/trunk/src/test/org/apache/struts/taglib/bean/TestDefineTag.java
(original)
+++ struts/trunk/src/test/org/apache/struts/taglib/bean/TestDefineTag.java Fri
Oct 15 18:39:50 2004
@@ -1,7 +1,7 @@
/*
* $Header:
/home/cvs/jakarta-struts/src/test/org/apache/struts/taglib/bean/TestDefineTag.java,v
1.10 2004/03/14 06:23:48 sraeburn Exp $
* $Revision: 1.10 $
- * $Date: 2004/03/14 06:23:48 $
+ * $Date$
*
* Copyright 1999-2004 The Apache Software Foundation.
*
@@ -20,20 +20,20 @@
package org.apache.struts.taglib.bean;
import javax.servlet.jsp.PageContext;
+
import junit.framework.Test;
import junit.framework.TestSuite;
-import org.apache.cactus.JspTestCase;
import org.apache.cactus.WebResponse;
import org.apache.struts.util.LabelValueBean;
-import org.apache.commons.lang.StringUtils;
+import org.apache.struts.taglib.TaglibTestBase;
/**
* Suite of unit tests for the
* codeorg.apache.struts.taglib.bean.DefineTag/code class.
*
*/
-public class TestDefineTag extends JspTestCase {
+public class TestDefineTag extends TaglibTestBase {
protected final static String TEST_KEY = TestDefineTag;
protected final static String TEST_VALUE = Test Value;
@@ -72,8 +72,8 @@
private void formatAndTest(String compare, String output) {
//fix for introduced carriage return / line feeds
-output = StringUtils.replace(output,\r,);
-output = StringUtils.replace(output,\n,);
+output = replace(output,\r,);
+output = replace(output,\n,);
output = output.trim();
assertEquals(compare, output);
}
Modified: struts/trunk/src/test/org/apache/struts/taglib/bean/TestHeaderTag.java
==
--- struts/trunk/src/test/org/apache/struts/taglib/bean/TestHeaderTag.java
(original)
+++ struts/trunk/src/test/org/apache/struts/taglib/bean/TestHeaderTag.java Fri
Oct 15 18:39:50 2004
@@ -1,7 +1,7 @@
/*
* $Header:
/home/cvs/jakarta-struts/src/test/org/apache/struts/taglib/bean/TestHeaderTag.java,v
1.10 2004/03/14 06:23:48 sraeburn Exp $
* $Revision: 1.10 $
- * $Date: 2004/03/14 06:23:48 $
+ * $Date$
*
* Copyright 1999-2004 The Apache Software Foundation.
*
@@ -22,17 +22,16 @@
import junit.framework.Test;
import junit.framework.TestSuite;
-import org.apache.cactus.JspTestCase;
import org.apache.cactus.WebRequest;
import org.apache.cactus.WebResponse;
-import org.apache.commons.lang.StringUtils;
+import org.apache.struts.taglib.TaglibTestBase;
/**
* Suite of unit tests for the
* codeorg.apache.struts.taglib.bean.HeaderTag/code class.
*
*/
-public class TestHeaderTag extends JspTestCase {
+public class TestHeaderTag extends TaglibTestBase {
protected final static String HEADER_KEY = HEADER_KEY;
protected final static String HEADER_VAL = HEADER_VAL;
@@ -71,8 +70,8 @@
private void formatAndTest(String compare, String output) {
//fix for introduced carriage return / line feeds
-output = StringUtils.replace(output,\r,);
-output = StringUtils.replace(output,\n,);
+output = replace(output,\r,);
+output = replace(output,\n,);
output = output.trim();
assertEquals(compare, output);
}
Modified: struts/trunk/src/test/org/apache/struts/taglib/bean/TestMessageTag_fr.java
==
--- struts/trunk/src/test/org/apache/struts/taglib/bean/TestMessageTag_fr.java
(original)
+++ struts/trunk/src/test/org/apache/struts/taglib/bean/TestMessageTag_fr.java Fri
Oct 15 18:39:50 2004
@@ -1,7 +1,7 @@
/*
* $Header:
/home/cvs/jakarta-struts/src/test/org/apache/struts/taglib/bean/TestMessageTag_fr.java,v
1.10 2004/03/14 06:23:48 sraeburn Exp $
* $Revision: 1.10 $
- * $Date: 2004/03/14 06:23:48 $
+ * $Date$
*
* Copyright 1999-2004 The Apache Software Foundation.
*
@@ -22,14 +22,14 @@
import java.util.Locale;
import javax.servlet.jsp.PageContext;
+
import junit.framework.Test;
import junit.framework.TestSuite;
-import org.apache.cactus.JspTestCase;
import org.apache.cactus.WebResponse;
import
svn commit: rev 54902 - struts/trunk/src/test/org/apache/struts/taglib/logic
Author: jmitchell
Date: Fri Oct 15 18:42:16 2004
New Revision: 54902
Modified:
struts/trunk/src/test/org/apache/struts/taglib/logic/TestIterateTag.java
Log:
Removing dependency on commons-lang
Modified: struts/trunk/src/test/org/apache/struts/taglib/logic/TestIterateTag.java
==
--- struts/trunk/src/test/org/apache/struts/taglib/logic/TestIterateTag.java
(original)
+++ struts/trunk/src/test/org/apache/struts/taglib/logic/TestIterateTag.javaFri
Oct 15 18:42:16 2004
@@ -1,7 +1,7 @@
/*
* $Header:
/home/cvs/jakarta-struts/src/test/org/apache/struts/taglib/logic/TestIterateTag.java,v
1.9 2004/07/01 00:52:02 husted Exp $
* $Revision: 1.9 $
- * $Date: 2004/07/01 00:52:02 $
+ * $Date$
*
* Copyright 1999-2004 The Apache Software Foundation.
*
@@ -31,10 +31,10 @@
import junit.framework.Test;
import junit.framework.TestSuite;
-import org.apache.cactus.JspTestCase;
import org.apache.cactus.WebResponse;
-import org.apache.commons.lang.StringUtils;
import org.apache.struts.taglib.SimpleBeanForTesting;
+import org.apache.struts.taglib.TaglibTestBase;
+
/**
@@ -42,7 +42,7 @@
* codeorg.apache.struts.taglib.logic.IterateTag/code class.
*
*/
-public class TestIterateTag extends JspTestCase {
+public class TestIterateTag extends TaglibTestBase {
private int iterations = 2;
@@ -125,8 +125,8 @@
}
//fix for introduced carriage return / line feeds
- output = StringUtils.replace(output,\r,);
- output = StringUtils.replace(output,\n,);
+ output = replace(output,\r,);
+ output = replace(output,\n,);
assertEquals(compare, output);
}
@@ -172,8 +172,8 @@
}
//fix for introduced carriage return / line feeds
- output = StringUtils.replace(compare,\r,);
- output = StringUtils.replace(output,\n,);
+ output = replace(compare,\r,);
+ output = replace(output,\n,);
assertEquals(compare, output);
}
@@ -219,8 +219,8 @@
}
//fix for introduced carriage return / line feeds
- output = StringUtils.replace(compare,\r,);
- output = StringUtils.replace(output,\r,);
+ output = replace(compare,\r,);
+ output = replace(output,\r,);
assertEquals(compare, output);
}
@@ -287,8 +287,8 @@
}
//fix for introduced carriage return / line feeds
- output = StringUtils.replace(compare,\r,);
- output = StringUtils.replace(output,\n,);
+ output = replace(compare,\r,);
+ output = replace(output,\n,);
assertEquals(compare, output);
}
@@ -345,8 +345,8 @@
}
//fix for introduced carriage return / line feeds
- output = StringUtils.replace(compare,\r,);
- output = StringUtils.replace(output,\n,);
+ output = replace(compare,\r,);
+ output = replace(output,\n,);
assertEquals(compare, output);
}
@@ -403,8 +403,8 @@
}
//fix for introduced carriage return / line feeds
- output = StringUtils.replace(compare,\r,);
- output = StringUtils.replace(output,\n,);
+ output = replace(compare,\r,);
+ output = replace(output,\n,);
assertEquals(compare, output);
}
@@ -459,8 +459,8 @@
}
//fix for introduced carriage return / line feeds
- output = StringUtils.replace(compare,\r,);
- output = StringUtils.replace(output,\n,);
+ output = replace(compare,\r,);
+ output = replace(output,\n,);
assertEquals(compare, output);
}
@@ -503,8 +503,8 @@
}
//fix for introduced carriage return / line feeds
- output = StringUtils.replace(compare,\r,);
- output = StringUtils.replace(output,\n,);
+ output = replace(compare,\r,);
+ output = replace(output,\n,);
assertEquals(compare, output);
}
@@ -547,8 +547,8 @@
}
//fix for introduced carriage return / line feeds
- output = StringUtils.replace(compare,\r,);
- output = StringUtils.replace(output,\n,);
+ output = replace(compare,\r,);
+ output = replace(output,\n,);
assertEquals(compare, output);
}
@@ -606,8 +606,8 @@
}
//fix for introduced carriage return / line feeds
- output =
Status: 1.2.5
What's new: -- I have removed the dependency on commons-lang. All build config files have been changed to reflect this. Test suite: -- Running the full test suite... jdk1.3 | jdk1.4 | jdk1.5 | test.junit | fail[0] | pass | pass | test.tomcat.all - 3.3 | pass| pass | pass | - 4.0 | fail[1] | pass | pass | - 4.1 | | pass | pass | [0] I had to copy 'jakarta-oro-2.0.8.jar' to $ANT_HOME/lib (not sure what changed in build.xml since the last time I ran it ... mapper type=regexp...[line 322] ... [1] I have no idea why this happened. Stack: ... ... prepare.test.war: prepare.test.tomcat.40: [delete] Deleting directory D:\cygwin\home\jmitchell\svn\struts\trunk\target\test\servers\tomcat40\webap ps\test [copy] Copying 1 file to D:\cygwin\home\jmitchell\svn\struts\trunk\target\test\servers\tomcat40\webap ps test.tomcat.40: start.tomcat.40: [java] Exception during startup processing [java] java.lang.reflect.InvocationTargetException: java.lang.NoClassDefFoundError: org/xml/sax/HandlerBase [java] at java.lang.ClassLoader.defineClass0(Native Method) [java] at java.lang.ClassLoader.defineClass(ClassLoader.java:488) [java] at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:106) ... ... What I need: --- Can someone put together a perl/python/shell/whatever script that can iterate over the entire repository and replace all of our cvs keywords with svn appropriate ones? Would be nice: - As mentioned in another thread (I think), it would be nice to have a few tests that will install all of the generated webapps and bang on the pages to verify they are working correctly. Unless someone beats me to it, I will do this after cutting 1.2.5. Status: -- Ted, I saw your update, do I need to wait on anything else? I am running 'ant release' as I type this. Assuming all goes well after that (apps build, docs build, etc), I'll proceed with the check list that is on the wiki. -- James Mitchell Software Engineer / Open Source Evangelist EdgeTech, Inc. 678.910.8017 AIM: jmitchtx - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: rev 54907 - struts/trunk/contrib/struts-el
Author: jmitchell Date: Fri Oct 15 20:04:45 2004 New Revision: 54907 Modified: struts/trunk/contrib/struts-el/project.xml Log: Changes for 1.2.5 release candidate Modified: struts/trunk/contrib/struts-el/project.xml == --- struts/trunk/contrib/struts-el/project.xml (original) +++ struts/trunk/contrib/struts-el/project.xml Fri Oct 15 20:04:45 2004 @@ -5,7 +5,7 @@ namestruts-el/name idstruts-el/id groupIdstruts/groupId - currentVersion1.2.4/currentVersion + currentVersion1.2.5/currentVersion inceptionYear2003/inceptionYear packageorg.apache.strutsel/package shortDescriptionExtension/adaptation of Struts tag libraries to use JSP 1.2 expression language./shortDescription @@ -57,7 +57,7 @@ dependency groupIdstruts/groupId artifactIdstruts/artifactId - version1.2.4/version + version1.2.5/version urlhttp://jakarta.apache.org/struts//url /dependency dependency - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31641] - javax.servlet.UnavailableException: Initializing application data source
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31641. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31641 javax.servlet.UnavailableException: Initializing application data source --- Additional Comments From [EMAIL PROTECTED] 2004-10-16 03:07 --- This doesn't look like a Struts issue to me - looks to me like you've only granted access to the root user for localhost. Connect to the mysql database in MySQL and query the user, db and host tables to find out what's authorised - they each have a host column. More details on MySQL access control here: http://dev.mysql.com/doc/mysql/en/Connection_access.html Niall - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31642] - bean:include always include Session id (if any) even for external Urls (href attribute)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31642. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31642 bean:include always include Session id (if any) even for external Urls (href attribute) --- Additional Comments From [EMAIL PROTECTED] 2004-10-16 03:09 --- Is this related to Bug 18032? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Downloads: download.cgi giving HTTP 500
Howdy Y'all, I'm getting an internal server error (HTTP 500) when trying to download via the site. I thought I'd throw an FYI just in case nobody is aware. Having been out of pocket a bit, I haven't a clue what the problem could be. Eddie --- avast! Antivirus: Outbound message clean. Virus Database (VPS): 0442-3, 10/15/2004 Tested on: 10/15/2004 10:17:40 PM avast! - copyright (c) 2000-2004 ALWIL Software. http://www.avast.com
[Apache Struts Wiki] Updated: StrutsRelease125
Date: 2004-10-15T20:19:29 Editor: NiallPemberton [EMAIL PROTECTED] Wiki: Apache Struts Wiki Page: StrutsRelease125 URL: http://wiki.apache.org/struts/StrutsRelease125 no comment Change Log: -- @@ -64,7 +64,7 @@ See also Commons [http://jakarta.apache.org/commons/releases/release.html Step-by-Step Guide] || '''#''' || '''Description''' || '''Completed''' || -|| A1. || Tag release in cvs: STRUTS_1_2_4 || _ || +|| A1. || Tag release in cvs: STRUTS_1_2_5 || _ || || A2. || Run Distribution Target || _ || || A3. || Upload Distribution to cvs.apache.org:/www/cvs.apache.org/dist/struts/v1.2.5 || _ || || A4. || Deploy JAR to Apache Java-Repository || _ || @@ -81,5 +81,10 @@ || B3. || Update Acquiring page on website and Test Downloads || _ || || B4. || Post an announcement to lists and website || _ || || B5. || Request new Bugzilla version level (1.2.5) || _ || + +== Other == + +[http://www.gentoo.org/ Gentoo] is publishing [http://packages.gentoo.org/search/?sstring=struts Struts distributions]. In order to have them publish the latest Struts version a bug should be raised in their [http://bugs.gentoo.org/ bugzilla] system. + CategoryHomepage StrutsReleasePlans - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Status: 1.2.5
At 10:13 PM -0400 10/15/04, James Mitchell wrote: What I need: --- Can someone put together a perl/python/shell/whatever script that can iterate over the entire repository and replace all of our cvs keywords with svn appropriate ones? I can do this, but a quick googling didn't turn up any specifics on what the change should be. I believe some recent discussion about replacing all keyword tags with just $Id$ had no strong opponents and a few in favor -- does SVN use the same syntax? I can do the search/replace/commit using BBEdit in ten or fifteen minutes, tops as soon as I get a few confirmations... Joe -- Joe Germuska [EMAIL PROTECTED] http://blog.germuska.com In fact, when I die, if I don't hear 'A Love Supreme,' I'll turn back; I'll know I'm in the wrong place. - Carlos Santana
DO NOT REPLY [Bug 31641] - javax.servlet.UnavailableException: Initializing application data source
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31641. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31641 javax.servlet.UnavailableException: Initializing application data source [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2004-10-16 03:46 --- This problem was solved by granting privileges to the application server. This bug may treat as closed. Simon Antony - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Status: 1.2.5
+1 for $Id$ Joe Germuska wrote: At 10:13 PM -0400 10/15/04, James Mitchell wrote: What I need: --- Can someone put together a perl/python/shell/whatever script that can iterate over the entire repository and replace all of our cvs keywords with svn appropriate ones? I can do this, but a quick googling didn't turn up any specifics on what the change should be. I believe some recent discussion about replacing all keyword tags with just $Id$ had no strong opponents and a few in favor -- does SVN use the same syntax? I can do the search/replace/commit using BBEdit in ten or fifteen minutes, tops as soon as I get a few confirmations... Joe -- Joe Germuska[EMAIL PROTECTED] http://blog.germuska.com In fact, when I die, if I don't hear 'A Love Supreme,' I'll turn back; I'll know I'm in the wrong place. - Carlos Santana - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Status: 1.2.5
I believe most of us agreed on $Id$, but if I am wrong, here is my +1 -- James Mitchell Software Engineer / Open Source Evangelist EdgeTech, Inc. 678.910.8017 AIM: jmitchtx - Original Message - From: Don Brown [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Sent: Saturday, October 16, 2004 12:02 AM Subject: Re: Status: 1.2.5 +1 for $Id$ Joe Germuska wrote: At 10:13 PM -0400 10/15/04, James Mitchell wrote: What I need: --- Can someone put together a perl/python/shell/whatever script that can iterate over the entire repository and replace all of our cvs keywords with svn appropriate ones? I can do this, but a quick googling didn't turn up any specifics on what the change should be. I believe some recent discussion about replacing all keyword tags with just $Id$ had no strong opponents and a few in favor -- does SVN use the same syntax? I can do the search/replace/commit using BBEdit in ten or fifteen minutes, tops as soon as I get a few confirmations... Joe -- Joe Germuska[EMAIL PROTECTED] http://blog.germuska.com In fact, when I die, if I don't hear 'A Love Supreme,' I'll turn back; I'll know I'm in the wrong place. - Carlos Santana - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Status: 1.2.5
On Fri, 15 Oct 2004 22:33:58 -0500, Joe Germuska [EMAIL PROTECTED] wrote: At 10:13 PM -0400 10/15/04, James Mitchell wrote: What I need: --- Can someone put together a perl/python/shell/whatever script that can iterate over the entire repository and replace all of our cvs keywords with svn appropriate ones? I can do this, but a quick googling didn't turn up any specifics on what the change should be. I believe some recent discussion about replacing all keyword tags with just $Id$ had no strong opponents and a few in favor -- does SVN use the same syntax? I can do the search/replace/commit using BBEdit in ten or fifteen minutes, tops as soon as I get a few confirmations... Doh! Crossed lines. You volunteered before I did, so go for it. ;-) Yes, $Id$ is what we want. -- Martin Cooper Joe -- Joe Germuska [EMAIL PROTECTED] http://blog.germuska.com In fact, when I die, if I don't hear 'A Love Supreme,' I'll turn back; I'll know I'm in the wrong place. - Carlos Santana - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Downloads: download.cgi giving HTTP 500
Fixed. It seems that download.cgi works only when the line ends in that file are Unix style, and a recent site update switched them to Windows style. I think we probably need to tell SVN that this is a binary file, so that the line ends don't get changed. If someone knows how to do that, please let me know. Otherwise, I'll dig into the SVN book and try to figure it out. -- Martin Cooper On Fri, 15 Oct 2004 22:17:39 -0500, Eddie Bush [EMAIL PROTECTED] wrote: Howdy Y'all, I'm getting an internal server error (HTTP 500) when trying to download via the site. I thought I'd throw an FYI just in case nobody is aware. Having been out of pocket a bit, I haven't a clue what the problem could be. Eddie --- avast! Antivirus: Outbound message clean. Virus Database (VPS): 0442-3, 10/15/2004 Tested on: 10/15/2004 10:17:40 PM avast! - copyright (c) 2000-2004 ALWIL Software. http://www.avast.com - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Downloads: download.cgi giving HTTP 500
From what (very) little I know about SVN, seems to me it stores everything binary. You can ask for special line-ending treatment by adding the -kb switch, I believe. It's ... gee I don't recall where I saw that now. Ah ... perhaps this helps: html-help-quote CVS users have to mark binary files with -kb flags, to prevent data from being garbled (due to keyword expansion and line-ending translations). They sometimes forget to do this. /html-help-quote If that means more to you than it does me then it may be sufficient. Otherwise, I apologize for (currently) being too ignorant about SVN to be much help. Thanks for the fix :-) - Original Message - From: Martin Cooper [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Sent: Friday, October 15, 2004 11:34 PM Subject: Re: Downloads: download.cgi giving HTTP 500 Fixed. It seems that download.cgi works only when the line ends in that file are Unix style, and a recent site update switched them to Windows style. I think we probably need to tell SVN that this is a binary file, so that the line ends don't get changed. If someone knows how to do that, please let me know. Otherwise, I'll dig into the SVN book and try to figure it out. -- Martin Cooper On Fri, 15 Oct 2004 22:17:39 -0500, Eddie Bush [EMAIL PROTECTED] wrote: Howdy Y'all, I'm getting an internal server error (HTTP 500) when trying to download via the site. I thought I'd throw an FYI just in case nobody is aware. Having been out of pocket a bit, I haven't a clue what the problem could be. Eddie --- avast! Antivirus: Outbound message clean. Virus Database (VPS): 0442-3, 10/15/2004 Tested on: 10/15/2004 10:17:40 PM avast! - copyright (c) 2000-2004 ALWIL Software. http://www.avast.com - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --- avast! Antivirus: Outbound message clean. Virus Database (VPS): 0442-3, 10/15/2004 Tested on: 10/15/2004 11:41:02 PM avast! - copyright (c) 2000-2004 ALWIL Software. http://www.avast.com - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
