Re: Portlet 2.0 Plugin was moved to trunk
2011/6/23 Johannes Geppert jo...@apache.org:
I have copied the latest version of the Portlet 1.0 Plugin to the archive
and replaced the version in trunk with the sandbox version. Also i have made
same small changes on the Portlet Sample App which is running fine in
jetspeed for me with the new portlet plugin version.
Nice work!
I have only one Problem in Test PortletRequestMapTest in Method
testEntrySet()
public void testEntrySet() {
MockPortletRequest request = new MockPortletRequest();
request.setAttribute(testAttribute1, testValue1);
request.setAttribute(testAttribute2, testValue2);
PortletRequestMap map = new PortletRequestMap(request);
Set entries = map.entrySet();
//TODO Why is Entry Size 3?
assertEquals(2, entries.size());
Iterator it = entries.iterator();
Map.Entry entry = (Map.Entry)it.next();
checkEntry(entry);
entry = (Map.Entry)it.next();
checkEntry(entry);
}
The Test runs into Failure because the entries.size() == 3 ?!?
This Test runs in the Sandbox version. Has anyone an Idea or Suggestion?
Did you try to debug to see what's on the list ?
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Warszawa JUG conference - Confitura http://confitura.pl/
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
Re: Portlet 2.0 Plugin was moved to trunk
Just did an update from trunk, and the tests ran fine with me (Java
1.6.0, Maven 2.2.1).
Nils-H
On Thu, Jun 23, 2011 at 11:24 PM, Johannes Geppert jo...@apache.org wrote:
Hi Guys,
I have copied the latest version of the Portlet 1.0 Plugin to the archive
and replaced the version in trunk with the sandbox version. Also i have made
same small changes on the Portlet Sample App which is running fine in
jetspeed for me with the new portlet plugin version.
I have only one Problem in Test PortletRequestMapTest in Method
testEntrySet()
public void testEntrySet() {
MockPortletRequest request = new MockPortletRequest();
request.setAttribute(testAttribute1, testValue1);
request.setAttribute(testAttribute2, testValue2);
PortletRequestMap map = new PortletRequestMap(request);
Set entries = map.entrySet();
//TODO Why is Entry Size 3?
assertEquals(2, entries.size());
Iterator it = entries.iterator();
Map.Entry entry = (Map.Entry)it.next();
checkEntry(entry);
entry = (Map.Entry)it.next();
checkEntry(entry);
}
The Test runs into Failure because the entries.size() == 3 ?!?
This Test runs in the Sandbox version. Has anyone an Idea or Suggestion?
Johannes
-
web: http://www.jgeppert.com
twitter: http://twitter.com/jogep
--
View this message in context:
http://struts.1045723.n5.nabble.com/Portlet-2-0-Plugin-was-moved-to-trunk-tp4519115p4519115.html
Sent from the Struts - Dev mailing list archive at Nabble.com.
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
Re: Portlet 2.0 Plugin was moved to trunk
There is a new key [1] in PortletRequest and what I've read it was
introduced in Portlet 2.0 spec. It's ok, just change the test, right ?
[1] javax.portlet.lifecycle_phase
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Warszawa JUG conference - Confitura http://confitura.pl/
2011/6/24 Nils-Helge Garli Hegvik nil...@gmail.com:
Just did an update from trunk, and the tests ran fine with me (Java
1.6.0, Maven 2.2.1).
Nils-H
On Thu, Jun 23, 2011 at 11:24 PM, Johannes Geppert jo...@apache.org wrote:
Hi Guys,
I have copied the latest version of the Portlet 1.0 Plugin to the archive
and replaced the version in trunk with the sandbox version. Also i have made
same small changes on the Portlet Sample App which is running fine in
jetspeed for me with the new portlet plugin version.
I have only one Problem in Test PortletRequestMapTest in Method
testEntrySet()
public void testEntrySet() {
MockPortletRequest request = new MockPortletRequest();
request.setAttribute(testAttribute1, testValue1);
request.setAttribute(testAttribute2, testValue2);
PortletRequestMap map = new PortletRequestMap(request);
Set entries = map.entrySet();
//TODO Why is Entry Size 3?
assertEquals(2, entries.size());
Iterator it = entries.iterator();
Map.Entry entry = (Map.Entry)it.next();
checkEntry(entry);
entry = (Map.Entry)it.next();
checkEntry(entry);
}
The Test runs into Failure because the entries.size() == 3 ?!?
This Test runs in the Sandbox version. Has anyone an Idea or Suggestion?
Johannes
-
web: http://www.jgeppert.com
twitter: http://twitter.com/jogep
--
View this message in context:
http://struts.1045723.n5.nabble.com/Portlet-2-0-Plugin-was-moved-to-trunk-tp4519115p4519115.html
Sent from the Struts - Dev mailing list archive at Nabble.com.
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
Re: Portlet 2.0 Plugin was moved to trunk
@Nils I have temporary commented out this part. @Lukasz You are right the third attribute is the javax.portlet.lifecycle_phase, but I am a little bit confused about it because this Test runs fine in the Sandbox Version. Johannes - web: http://www.jgeppert.com twitter: http://twitter.com/jogep -- View this message in context: http://struts.1045723.n5.nabble.com/Portlet-2-0-Plugin-was-moved-to-trunk-tp4519115p4520160.html Sent from the Struts - Dev mailing list archive at Nabble.com. - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
Re: Portlet 2.0 Plugin was moved to trunk
@Nils I have temporary commented out this part. @Lukasz You are right the third attribute is the javax.portlet.lifecycle_phase, but I am a little bit confused about it because this Test runs fine in the Sandbox Version. Johannes - web: http://www.jgeppert.com twitter: http://twitter.com/jogep -- View this message in context: http://struts.1045723.n5.nabble.com/Portlet-2-0-Plugin-was-moved-to-trunk-tp4519115p4520159.html Sent from the Struts - Dev mailing list archive at Nabble.com. - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
Re: Portlet 2.0 Plugin was moved to trunk
2011/6/24 Johannes Geppert jo...@apache.org: @Lukasz You are right the third attribute is the javax.portlet.lifecycle_phase, but I am a little bit confused about it because this Test runs fine in the Sandbox Version. What version of Spring is used in sandbox ? Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ Warszawa JUG conference - Confitura http://confitura.pl/ - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
Re: Portlet 2.0 Plugin was moved to trunk
Lukasz you are right changing the Spring Version in the Sandbox raises also the Failure. I have modified the Test like your suggestion. Johannes - web: http://www.jgeppert.com twitter: http://twitter.com/jogep -- View this message in context: http://struts.1045723.n5.nabble.com/Portlet-2-0-Plugin-was-moved-to-trunk-tp4519115p4520183.html Sent from the Struts - Dev mailing list archive at Nabble.com. - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
Re: Portlet 2.0 Plugin was moved to trunk
Great work, Johannes!
The only thing that concerns me a bit is that we seem to have lost the
commit history of the new plugin, since you have applied the sandbox
sources as patch to the current plugin. The history how p1 mutated to p2
is imo important ...
How do others feel about this? It's not too late to revert this to a move.
- René
On 23.06.11 23:24, Johannes Geppert wrote:
Hi Guys,
I have copied the latest version of the Portlet 1.0 Plugin to the archive
and replaced the version in trunk with the sandbox version. Also i have made
same small changes on the Portlet Sample App which is running fine in
jetspeed for me with the new portlet plugin version.
I have only one Problem in Test PortletRequestMapTest in Method
testEntrySet()
public void testEntrySet() {
MockPortletRequest request = new MockPortletRequest();
request.setAttribute(testAttribute1, testValue1);
request.setAttribute(testAttribute2, testValue2);
PortletRequestMap map = new PortletRequestMap(request);
Set entries = map.entrySet();
//TODO Why is Entry Size 3?
assertEquals(2, entries.size());
Iterator it = entries.iterator();
Map.Entry entry = (Map.Entry)it.next();
checkEntry(entry);
entry = (Map.Entry)it.next();
checkEntry(entry);
}
The Test runs into Failure because the entries.size() == 3 ?!?
This Test runs in the Sandbox version. Has anyone an Idea or Suggestion?
Johannes
-
web: http://www.jgeppert.com
twitter: http://twitter.com/jogep
--
View this message in context:
http://struts.1045723.n5.nabble.com/Portlet-2-0-Plugin-was-moved-to-trunk-tp4519115p4519115.html
Sent from the Struts - Dev mailing list archive at Nabble.com.
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
--
René Gielen
IT-Neering.net
Saarstrasse 100, 52062 Aachen, Germany
Tel: +49-(0)241-4010770
Fax: +49-(0)241-4010771
Cel: +49-(0)163-2844164
http://twitter.com/rgielen
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
Build failed in Jenkins: Struts2 » Struts 2 GXP Plugin #324
See https://builds.apache.org/job/Struts2/org.apache.struts$struts2-gxp-plugin/324/ -- [JENKINS] Archiving /home/hudson/hudson-slave/workspace/Struts2/struts2/plugins/embeddedjsp/pom.xml to /home/hudson/hudson/jobs/Struts2/modules/org.apache.struts$struts2-embeddedjsp-plugin/builds/2011-06-24_07-41-08/archive/org.apache.struts/struts2-embeddedjsp-plugin/2.3.1-SNAPSHOT/struts2-embeddedjsp-plugin-2.3.1-SNAPSHOT.pom [INFO] Downloading: http://repo1.maven.org/maven2/org/apache/maven/plugins/maven-idea-plugin/maven-metadata.xml [INFO] [INFO] Building Struts 2 GXP Plugin 2.3.1-SNAPSHOT [INFO] Downloaded: http://repo1.maven.org/maven2/org/apache/maven/plugins/maven-idea-plugin/maven-metadata.xml (436 B at 1.2 KB/sec) [INFO] [INFO] Deleting https://builds.apache.org/job/Struts2/org.apache.struts$struts2-gxp-plugin/ws/target [INFO] --- maven-clean-plugin:2.4.1:clean (default-clean) @ struts2-gxp-plugin --- [INFO] [INFO] --- maven-remote-resources-plugin:1.1:process (default) @ struts2-gxp-plugin --- [INFO] [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 1 resource [INFO] Copying 3 resources [INFO] --- maven-resources-plugin:2.4:resources (default-resources) @ struts2-gxp-plugin --- [INFO] [INFO] --- maven-compiler-plugin:2.0.2:compile (default-compile) @ struts2-gxp-plugin --- [INFO] Compiling 6 source files to https://builds.apache.org/job/Struts2/org.apache.struts$struts2-gxp-plugin/ws/target/classes mojoFailed org.apache.maven.plugins:maven-compiler-plugin:2.0.2(default-compile) projectFailed org.apache.struts:struts2-gxp-plugin:2.3.1-SNAPSHOT - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
Build failed in Jenkins: Struts2 » Struts 2 Embedded JSP Plugin #324
See https://builds.apache.org/job/Struts2/org.apache.struts$struts2-embeddedjsp-plugin/324/ -- [JENKINS] Archiving /home/hudson/hudson-slave/workspace/Struts2/struts2/plugins/json/pom.xml to /home/hudson/hudson/jobs/Struts2/modules/org.apache.struts$struts2-json-plugin/builds/2011-06-24_07-41-08/archive/org.apache.struts/struts2-json-plugin/2.3.1-SNAPSHOT/struts2-json-plugin-2.3.1-SNAPSHOT.pom [JENKINS] Archiving /home/hudson/hudson-slave/workspace/Struts2/struts2/plugins/json/target/struts2-json-plugin-2.3.1-SNAPSHOT.jar to /home/hudson/hudson/jobs/Struts2/modules/org.apache.struts$struts2-json-plugin/builds/2011-06-24_07-41-08/archive/org.apache.struts/struts2-json-plugin/2.3.1-SNAPSHOT/struts2-json-plugin-2.3.1-SNAPSHOT.jar [JENKINS] Archiving /home/hudson/hudson-slave/workspace/Struts2/struts2/plugins/json/target/struts2-json-plugin-2.3.1-SNAPSHOT-sources.jar to /home/hudson/hudson/jobs/Struts2/modules/org.apache.struts$struts2-json-plugin/builds/2011-06-24_07-41-08/archive/org.apache.struts/struts2-json-plugin/2.3.1-SNAPSHOT/struts2-json-plugin-2.3.1-SNAPSHOT-sources.jar [INFO] Downloading: http://repo1.maven.org/maven2/org/apache/maven/plugins/maven-idea-plugin/maven-metadata.xml [INFO] [INFO] Building Struts 2 Embedded JSP Plugin 2.3.1-SNAPSHOT [INFO] Downloaded: http://repo1.maven.org/maven2/org/apache/maven/plugins/maven-idea-plugin/maven-metadata.xml (436 B at 1.2 KB/sec) [INFO] Deleting https://builds.apache.org/job/Struts2/org.apache.struts$struts2-embeddedjsp-plugin/ws/target [INFO] [INFO] --- maven-clean-plugin:2.4.1:clean (default-clean) @ struts2-embeddedjsp-plugin --- [INFO] [INFO] --- maven-remote-resources-plugin:1.1:process (default) @ struts2-embeddedjsp-plugin --- [INFO] [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 6 resources [INFO] --- maven-resources-plugin:2.4:resources (default-resources) @ struts2-embeddedjsp-plugin --- [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:2.0.2:compile (default-compile) @ struts2-embeddedjsp-plugin --- [INFO] Compiling 177 source files to https://builds.apache.org/job/Struts2/org.apache.struts$struts2-embeddedjsp-plugin/ws/target/classes mojoFailed org.apache.maven.plugins:maven-compiler-plugin:2.0.2(default-compile) projectFailed org.apache.struts:struts2-embeddedjsp-plugin:2.3.1-SNAPSHOT - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
Build failed in Jenkins: Struts2 #324
See https://builds.apache.org/job/Struts2/324/changes Changes: [jogep] WW-3620: Bring Portlet 2.0 (JSR286) plugin from sandbox to trunk -- [...truncated 6907 lines...] [INFO] --- maven-bundle-plugin:2.1.0:manifest (bundle-manifest) @ struts2-archetype-portlet --- [WARNING] Warning in manifest for org.apache.struts:struts2-archetype-portlet:jar:2.3.1-SNAPSHOT : Superfluous export-package instructions: [archetype-resources.src, archetype-resources.src.main.webapp.WEB-INF.jsp, archetype-resources.src.test, archetype-resources.src.main, archetype-resources.src.main.webapp] [INFO] [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory https://builds.apache.org/job/Struts2/ws/struts2/archetypes/struts2-archetype-portlet/src/test/resources [INFO] Copying 3 resources [INFO] --- maven-resources-plugin:2.4:testResources (default-testResources) @ struts2-archetype-portlet --- [INFO] Not compiling test sources [INFO] [INFO] --- maven-compiler-plugin:2.0.2:testCompile (default-testCompile) @ struts2-archetype-portlet --- [INFO] [INFO] Tests are skipped. [INFO] --- maven-surefire-plugin:2.3.1:test (default-test) @ struts2-archetype-portlet --- [INFO] [INFO] --- maven-jar-plugin:2.3:jar (default-jar) @ struts2-archetype-portlet --- [INFO] Building jar: https://builds.apache.org/job/Struts2/ws/struts2/archetypes/struts2-archetype-portlet/target/struts2-archetype-portlet-2.3.1-SNAPSHOT.jar mojo forkStarted org.apache.maven.plugins:maven-source-plugin:2.1.1(attach-source) mojo forkSucceeded org.apache.maven.plugins:maven-source-plugin:2.1.1(attach-source) ignoring exception during new ExecutedMojo null [INFO] [INFO] Building jar: https://builds.apache.org/job/Struts2/ws/struts2/archetypes/struts2-archetype-portlet/target/struts2-archetype-portlet-2.3.1-SNAPSHOT-sources.jar [INFO] --- maven-source-plugin:2.1.1:jar (attach-source) @ struts2-archetype-portlet --- [INFO] [INFO] Installing https://builds.apache.org/job/Struts2/ws/struts2/archetypes/struts2-archetype-portlet/target/struts2-archetype-portlet-2.3.1-SNAPSHOT.jar to /home/hudson/.m2/repository/org/apache/struts/struts2-archetype-portlet/2.3.1-SNAPSHOT/struts2-archetype-portlet-2.3.1-SNAPSHOT.jar [INFO] Installing https://builds.apache.org/job/Struts2/ws/struts2/archetypes/struts2-archetype-portlet/pom.xml to /home/hudson/.m2/repository/org/apache/struts/struts2-archetype-portlet/2.3.1-SNAPSHOT/struts2-archetype-portlet-2.3.1-SNAPSHOT.pom [INFO] Installing https://builds.apache.org/job/Struts2/ws/struts2/archetypes/struts2-archetype-portlet/target/struts2-archetype-portlet-2.3.1-SNAPSHOT-sources.jar to /home/hudson/.m2/repository/org/apache/struts/struts2-archetype-portlet/2.3.1-SNAPSHOT/struts2-archetype-portlet-2.3.1-SNAPSHOT-sources.jar [INFO] --- maven-install-plugin:2.3:install (default-install) @ struts2-archetype-portlet --- projectSucceeded org.apache.struts:struts2-archetype-portlet:2.3.1-SNAPSHOT [JENKINS] Archiving https://builds.apache.org/job/Struts2/ws/struts2/archetypes/struts2-archetype-portlet/pom.xml to /home/hudson/hudson/jobs/Struts2/modules/org.apache.struts$struts2-archetype-portlet/builds/2011-06-24_07-41-08/archive/org.apache.struts/struts2-archetype-portlet/2.3.1-SNAPSHOT/struts2-archetype-portlet-2.3.1-SNAPSHOT.pom [JENKINS] Archiving https://builds.apache.org/job/Struts2/ws/struts2/archetypes/struts2-archetype-portlet/target/struts2-archetype-portlet-2.3.1-SNAPSHOT.jar to /home/hudson/hudson/jobs/Struts2/modules/org.apache.struts$struts2-archetype-portlet/builds/2011-06-24_07-41-08/archive/org.apache.struts/struts2-archetype-portlet/2.3.1-SNAPSHOT/struts2-archetype-portlet-2.3.1-SNAPSHOT.jar [JENKINS] Archiving https://builds.apache.org/job/Struts2/ws/struts2/archetypes/struts2-archetype-portlet/target/struts2-archetype-portlet-2.3.1-SNAPSHOT-sources.jar to /home/hudson/hudson/jobs/Struts2/modules/org.apache.struts$struts2-archetype-portlet/builds/2011-06-24_07-41-08/archive/org.apache.struts/struts2-archetype-portlet/2.3.1-SNAPSHOT/struts2-archetype-portlet-2.3.1-SNAPSHOT-sources.jar [INFO] Downloading: http://repo1.maven.org/maven2/org/apache/maven/plugins/maven-idea-plugin/maven-metadata.xml [INFO] [INFO] Building Struts 2 Archetypes - Starter 2.3.1-SNAPSHOT [INFO] Downloaded: http://repo1.maven.org/maven2/org/apache/maven/plugins/maven-idea-plugin/maven-metadata.xml (436 B at 1.2 KB/sec) [INFO] [INFO] Deleting https://builds.apache.org/job/Struts2/ws/struts2/archetypes/struts2-archetype-starter/target [INFO] --- maven-clean-plugin:2.4.1:clean (default-clean) @ struts2-archetype-starter --- [INFO] [INFO] --- maven-remote-resources-plugin:1.1:process (default) @ struts2-archetype-starter
Re: Portlet 2.0 Plugin was moved to trunk
It's probably because of an updated spring mock dependency. The
MockPortletRequest object has this line of code:
attributes.put(javax.portlet.lifecycle_phase, getLifecyclePhase());
So the test should be rewritten to not be dependent on the number of
elements in the entry set, but rather that the elements that are
prepared exists in the entry set.
Nils-H
On Fri, Jun 24, 2011 at 9:44 AM, Rene Gielen gie...@it-neering.net wrote:
Great work, Johannes!
The only thing that concerns me a bit is that we seem to have lost the
commit history of the new plugin, since you have applied the sandbox
sources as patch to the current plugin. The history how p1 mutated to p2
is imo important ...
How do others feel about this? It's not too late to revert this to a move.
- René
On 23.06.11 23:24, Johannes Geppert wrote:
Hi Guys,
I have copied the latest version of the Portlet 1.0 Plugin to the archive
and replaced the version in trunk with the sandbox version. Also i have made
same small changes on the Portlet Sample App which is running fine in
jetspeed for me with the new portlet plugin version.
I have only one Problem in Test PortletRequestMapTest in Method
testEntrySet()
public void testEntrySet() {
MockPortletRequest request = new MockPortletRequest();
request.setAttribute(testAttribute1, testValue1);
request.setAttribute(testAttribute2, testValue2);
PortletRequestMap map = new PortletRequestMap(request);
Set entries = map.entrySet();
//TODO Why is Entry Size 3?
assertEquals(2, entries.size());
Iterator it = entries.iterator();
Map.Entry entry = (Map.Entry)it.next();
checkEntry(entry);
entry = (Map.Entry)it.next();
checkEntry(entry);
}
The Test runs into Failure because the entries.size() == 3 ?!?
This Test runs in the Sandbox version. Has anyone an Idea or Suggestion?
Johannes
-
web: http://www.jgeppert.com
twitter: http://twitter.com/jogep
--
View this message in context:
http://struts.1045723.n5.nabble.com/Portlet-2-0-Plugin-was-moved-to-trunk-tp4519115p4519115.html
Sent from the Struts - Dev mailing list archive at Nabble.com.
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
--
René Gielen
IT-Neering.net
Saarstrasse 100, 52062 Aachen, Germany
Tel: +49-(0)241-4010770
Fax: +49-(0)241-4010771
Cel: +49-(0)163-2844164
http://twitter.com/rgielen
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
Re: Portlet 2.0 Plugin was moved to trunk
On Fri, Jun 24, 2011 at 12:44 AM, Rene Gielen gie...@it-neering.net wrote:
Great work, Johannes!
The only thing that concerns me a bit is that we seem to have lost the
commit history of the new plugin, since you have applied the sandbox
sources as patch to the current plugin. The history how p1 mutated to p2
is imo important ...
Ouch. You are right, keeping the history is important. If we can go
back and address this, I would suggest that we do that.
--
Martin Cooper
How do others feel about this? It's not too late to revert this to a move.
- René
On 23.06.11 23:24, Johannes Geppert wrote:
Hi Guys,
I have copied the latest version of the Portlet 1.0 Plugin to the archive
and replaced the version in trunk with the sandbox version. Also i have made
same small changes on the Portlet Sample App which is running fine in
jetspeed for me with the new portlet plugin version.
I have only one Problem in Test PortletRequestMapTest in Method
testEntrySet()
public void testEntrySet() {
MockPortletRequest request = new MockPortletRequest();
request.setAttribute(testAttribute1, testValue1);
request.setAttribute(testAttribute2, testValue2);
PortletRequestMap map = new PortletRequestMap(request);
Set entries = map.entrySet();
//TODO Why is Entry Size 3?
assertEquals(2, entries.size());
Iterator it = entries.iterator();
Map.Entry entry = (Map.Entry)it.next();
checkEntry(entry);
entry = (Map.Entry)it.next();
checkEntry(entry);
}
The Test runs into Failure because the entries.size() == 3 ?!?
This Test runs in the Sandbox version. Has anyone an Idea or Suggestion?
Johannes
-
web: http://www.jgeppert.com
twitter: http://twitter.com/jogep
--
View this message in context:
http://struts.1045723.n5.nabble.com/Portlet-2-0-Plugin-was-moved-to-trunk-tp4519115p4519115.html
Sent from the Struts - Dev mailing list archive at Nabble.com.
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
--
René Gielen
IT-Neering.net
Saarstrasse 100, 52062 Aachen, Germany
Tel: +49-(0)241-4010770
Fax: +49-(0)241-4010771
Cel: +49-(0)163-2844164
http://twitter.com/rgielen
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
